[jira] [Commented] (LOG4J2-702) LoggerConfig#waitForCompletion is not thread safe

2014-07-12 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060004#comment-14060004 ] Ralph Goers commented on LOG4J2-702: Did you really mean Remko's solution or what I pr

Re: [VOTE] Log4j 2.0 candidate 1

2014-07-12 Thread Ralph Goers
I have no idea why it is complaining about Jackson. I can understand why it doesn’t like us using the com.sun stuff. I wonder if we are defaulting to https://github.com/checkstyle/checkstyle/blob/master/import-control.xml Ralph On Jul 12, 2014, at 7:40 PM, Gary Gregory wrote: > What is the

[jira] [Commented] (LOG4J2-702) LoggerConfig#waitForCompletion is not thread safe

2014-07-12 Thread Sean Bridges (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059991#comment-14059991 ] Sean Bridges commented on LOG4J2-702: - Remko, I think your solution works. > LoggerCo

Re: Next release

2014-07-12 Thread Bruce Brouwer
Here is what I am thinking. I will make the branch tomorrow and put just the minimal changes in place with the modified StatusLogger api. This way when I fix things completely we won't have a breaking api change after 2.0 release. If you like it, we can put just that in trunk and release. On Jul 12

Re: [VOTE] Log4j 2.0 candidate 1

2014-07-12 Thread Gary Gregory
What is the story with the "Disallowed import" checkstyle warnings? Gary On Sat, Jul 12, 2014 at 8:25 PM, Ralph Goers wrote: > This is a vote to release Log4j 2.0, the first GA release of Log4j 2. > > Please test and cast your votes. > [] +1, release the artifacts > [] -1, don't release becaus

[VOTE] Log4j 2.0 candidate 1

2014-07-12 Thread Ralph Goers
This is a vote to release Log4j 2.0, the first GA release of Log4j 2. Please test and cast your votes. [] +1, release the artifacts [] -1, don't release because… The vote will remain open for 72 hours (or more if required). New features: o LOG4J2-519: Added support for generating custom logger

[jira] [Commented] (LOG4J2-702) LoggerConfig#waitForCompletion is not thread safe

2014-07-12 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059962#comment-14059962 ] Ralph Goers commented on LOG4J2-702: Yes, it would be undesirable. But the only time

[jira] [Commented] (LOG4J2-702) LoggerConfig#waitForCompletion is not thread safe

2014-07-12 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059958#comment-14059958 ] Remko Popma commented on LOG4J2-702: Ah, yes, I only increased its visibility, that's

[jira] [Commented] (LOG4J2-702) LoggerConfig#waitForCompletion is not thread safe

2014-07-12 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059945#comment-14059945 ] Ralph Goers commented on LOG4J2-702: Actually, I think I created it. It is also called

[jira] [Comment Edited] (LOG4J2-702) LoggerConfig#waitForCompletion is not thread safe

2014-07-12 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059942#comment-14059942 ] Remko Popma edited comment on LOG4J2-702 at 7/12/14 10:25 PM: --

[jira] [Commented] (LOG4J2-702) LoggerConfig#waitForCompletion is not thread safe

2014-07-12 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059942#comment-14059942 ] Remko Popma commented on LOG4J2-702: PrivateLogger.logEvent() is called by AsyncLogger

[jira] [Commented] (LOG4J2-702) LoggerConfig#waitForCompletion is not thread safe

2014-07-12 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059927#comment-14059927 ] Ralph Goers commented on LOG4J2-702: Here is what I am thinking. 1. I really don't kno

Re: Next release

2014-07-12 Thread Bruno Mahé
Hi, We have been testing Apache Log4j 2.0rc2 at Tango for a few weeks and have been very impressed. We are in the process of migrating our services to Apache Log 2.0rc2 so they can be ready for roll out when 2.0 comes out. The only issue we had so far was about configuring async logger for al

[jira] [Commented] (LOG4J2-702) LoggerConfig#waitForCompletion is not thread safe

2014-07-12 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059884#comment-14059884 ] Ralph Goers commented on LOG4J2-702: While I agree with you Remko, the problem really

Re: Next release

2014-07-12 Thread Bruce Brouwer
If StatusLogger is not really part of the api and is really only meant for internal use then I feel comfortable putting my changes in at a later time. Could we put a comment on the StatusLogger at least so people are aware of this distinction. (Maybe there already is one) I can do that much easily

Re: Next release

2014-07-12 Thread Ralph Goers
I am not sure why making the StatusLogger better at closing files should cause compatibility problems. I really wish it didn't have to be in the API since it is really meant to be for internal use. Sent from my iPad > On Jul 12, 2014, at 7:04 AM, Gary Gregory wrote: > > What about binary com

Re: Next release

2014-07-12 Thread Gary Gregory
What about binary compatibility? Gary Original message From: Remko Popma Date:07/12/2014 08:31 (GMT-05:00) To: Log4J Developers List Subject: Re: Next release I would really like to do the 2.0 release vote this weekend. Bruce, based on what I've seen from the patch, the A

Re: Next release

2014-07-12 Thread Remko Popma
I would really like to do the 2.0 release vote this weekend. Bruce, based on what I've seen from the patch, the API changes you have in mind will not be very disruptive (as you already mentioned). If addressing this issue will take some time, I would prefer to release 2.0 this weekend and do the fi

Re: Next release

2014-07-12 Thread Gary Gregory
Creating a branch won't hurt :-) Gary Original message From: Bruce Brouwer Date:07/12/2014 07:28 (GMT-05:00) To: Log4J Developers List Subject: Re: Next release Shall I make a branch for this and check in what I have? If we really want to push to get this out soon maybe

Re: Next release

2014-07-12 Thread Bruce Brouwer
Shall I make a branch for this and check in what I have? If we really want to push to get this out soon maybe someone else could help out on the branch. On Jul 11, 2014 11:30 PM, "Gary Gregory" wrote: > Sure looks like worth fixing. Leaks are nasty, even if it is a corner > case, someone will hit

[jira] [Resolved] (LOG4J2-705) Async logger loses thread context stack for events

2014-07-12 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-705. Resolution: Fixed Fix Version/s: 2.0 Fixed in revision 1609903. Please verify and close. >

[jira] [Comment Edited] (LOG4J2-705) Async logger loses thread context stack for events

2014-07-12 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059745#comment-14059745 ] Remko Popma edited comment on LOG4J2-705 at 7/12/14 11:16 AM: --

[jira] [Commented] (LOG4J2-705) Async logger loses thread context stack for events

2014-07-12 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059745#comment-14059745 ] Remko Popma commented on LOG4J2-705: I'm surprised this has not been found earlier. Th

[jira] [Commented] (LOG4J2-705) Async logger loses thread context stack for events

2014-07-12 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14059692#comment-14059692 ] Remko Popma commented on LOG4J2-705: Your analysis of the problem is correct. The stac