Lars Gullik Bjønnes wrote:
Georg Baum [EMAIL PROTECTED]
writes:
This is a wrapper...
Yes, it was a misunderstanding, I was thinking you suggested a wrapper
around the wrapper, and I could not see why we want two wrappers ;-)
is formatlist a member of something, or a global var?
It is a
Vladimir Prus [EMAIL PROTECTED] writes:
| Lars Gullik Bj?nnes wrote:
| I'm not sure I understand the separation argument -- the extra
| forwarding layer just adds complexity (e.g. your change to inMatched()
| in insets/insetbase.h just double the number of characters ;-) ), but
| anyway...
Jean-Marc Lasgouttes wrote:
Does the following one-liner patch help? I think this is a consequence
of the fix of bug 1415, which increased the value of num_units.
Thanks, Jean-Marc. I'll try it when I am back home (Thursday).
Jürgen
José Abílio Oliveira Matos wrote:
cutting the nonsense and being objective what needs to be done to release
a stable 1.4.0?
Is it reasonable to have a HEAD that has problems while Alfredo is fixing
the bugs in the other branch?
Looking in bugzilla for bugs related with 1.4.0, blocker,
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
| Hair-sore?
Lars I get the correct expression is ... [in norwegian: hårsår] ...
Lars takes easily offence over trivialities ... I don't know.
In French, avoir mal au cheveux is what you feel in the morning
after an evening/night with too
Juergen Spitzmueller wrote:
I am have scanned bugzilla regularly recently and, if I could not fix
them, tried to at least verify the status of the critical and major bugs.
There are indeed not much that need to be fixed urgently (lots are
fixedintrunk, others ar long-time bugs), but bugzilla
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
| +void layoutSelected(LyXView lv, string name)
Lars string const name
Oops! It seems that it pays to post the patches.
| + // Yes, the _() is correct
Lars But it shouldn't be... Should we ever work with translated names
Lars inside
Alfredo == Alfredo Braunstein [EMAIL PROTECTED] writes:
Alfredo now that drawSelection is separated from draw and called
Alfredo before it, the background painting of colored insets
Alfredo overwrites the selection.
Alfredo A possible way of solving this is to draw the background in
Alfredo
Juergen Spitzmueller wrote:
Does the following one-liner patch help? I think this is a consequence
of the fix of bug 1415, which increased the value of num_units.
Thanks, Jean-Marc. I'll try it when I am back home (Thursday).
Actually, I just tried it and it fixes the crash. As in 1.3.x,
Jean-Marc Lasgouttes wrote:
Alfredo now that drawSelection is separated from draw and called
Alfredo before it, the background painting of colored insets
Alfredo overwrites the selection.
Alfredo A possible way of solving this is to draw the background in
Alfredo InsetText::drawSelection
Alfredo == Alfredo Braunstein [EMAIL PROTECTED] writes:
Alfredo are you suggesting that we rename the virtual drawSelection
Alfredo to drawBackground in the base inset class? Too many files to
Alfredo change ;-)
It is just that the name drawSelection will become misleading if it
draws the
Jean-Marc Lasgouttes wrote:
Alfredo are you suggesting that we rename the virtual drawSelection
Alfredo to drawBackground in the base inset class? Too many files to
Alfredo change ;-)
It is just that the name drawSelection will become misleading if it
draws the background too...
You are
On Tue, 2004-11-09 at 00:47 +, Andreas Vox wrote:
Americans say 'touchy', I think, and in German it would be dünnhäutig
(having a thin skin). Maybe _that_ is what makes you are perfect target
for flame baits? ;-)
Thin-skinned works in English, although the opposite expression is more
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
| | +void layoutSelected(LyXView lv, string name)
| Lars string const name
| Oops! It seems that it pays to post the patches.
| | + // Yes, the _() is correct
| Lars But it shouldn't be...
Juergen Spitzmueller [EMAIL PROTECTED] writes:
I try to check if all features are still working. Haven't tried branches and
friends for a long time now.
I'm using branches with 1.4.0cvs. 60 page DocBook document, two branches with
10-20 insets total, lots of figures, one table.
The table
Lars Gullik Bj?nnes wrote:
| I always though the point about NVI is that you can add
| pre-processing/post-processing before calling the virtual function. At
| least that what I've heard -- I never needed to add such pre/post
| processing.
That is also an argument. If you look at
Vladimir Prus [EMAIL PROTECTED] writes:
| small methods like accessors and 'clone' is up to you. I don't (yet?) think
| so.
It is only aimed at virtual functions... do you often have virtual
accessor functions?
--
Lgb
Lars Gullik Bj?nnes wrote:
Vladimir Prus [EMAIL PROTECTED] writes:
| small methods like accessors and 'clone' is up to you. I don't (yet?)
| think so.
It is only aimed at virtual functions... do you often have virtual
accessor functions?
No. But here's what your patch contains:
-
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
Lars Yes, I know. but ideally we should not work on the translated
Lars name, but on some index instead.
What makes it a bit complicated is that obsolete layouts, which do
have an index in the list of layouts, do not appear in the combox. So
Vladimir Prus [EMAIL PROTECTED] writes:
| Lars Gullik Bj?nnes wrote:
Vladimir Prus [EMAIL PROTECTED] writes:
| small methods like accessors and 'clone' is up to you. I don't (yet?)
| think so.
It is only aimed at virtual functions... do you often have virtual
accessor functions?
| No.
Lars Gullik Bj?nnes wrote:
| - virtual bool isSpace() const { return false; }
| + bool isSpace() const { return doIsSpace(); }
| // should we have a non-filled line before this inset?
| - virtual bool display() const { return false; }
| + bool display() const
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
| Lars Yes, I know. but ideally we should not work on the translated
| Lars name, but on some index instead.
| What makes it a bit complicated is that obsolete layouts, which do
| have an index
Vladimir Prus [EMAIL PROTECTED] writes:
| Lars Gullik Bj?nnes wrote:
| - virtual bool isSpace() const { return false; }
| + bool isSpace() const { return doIsSpace(); }
| // should we have a non-filled line before this inset?
| - virtual bool display() const {
On Tue, Nov 09, 2004 at 01:38:49PM +0100, Jean-Marc Lasgouttes wrote:
What makes it a bit complicated is that obsolete layouts, which do
have an index in the list of layouts, do not appear in the combox. So
using indices means more work.
Notice that we can remove the support for obsolete
On Tue, Nov 09, 2004 at 11:39:50AM +, Andreas Vox wrote:
Branches work fine except two minor quirks:
* If you insert a branch for the whole section, the layout becomes standard
inside the branch inset and stays section outside, causing empty sectgions.
Could you give an example of
Andre' cursor positioning inside mathed doesn't work in coordbranch because
we are missing getCursorPos implementations. Could you have a look?
Alfredo
José == José Abílio Oliveira Matos [EMAIL PROTECTED] writes:
José On Tue, Nov 09, 2004 at 01:38:49PM +0100, Jean-Marc Lasgouttes
José wrote:
What makes it a bit complicated is that obsolete layouts, which do
have an index in the list of layouts, do not appear in the combox.
So using indices
Lars Gullik Bjønnes wrote:
| As it stands now I will not do further work on the booktabs stuff. I
| really don't know wether that has any influence on the number of fixed
| bugs or not.
That'd be a pity.
I might be swayed if all three of you test and perfect this patch.
Well, then let's do
Alfredo Braunstein wrote:
I see. And what's the improvement wrt to plain LaTeX tables? The ability
to put horizontal lines independently in any column?
The output quality. You can kind of emulate formal tables with LaTeX's own
tabular stuff, but that looks just plain ugly (to say the least).
On Tue, Nov 09, 2004 at 04:05:28PM +0100, Jean-Marc Lasgouttes wrote:
José Notice that we can remove the support for obsolete layouts
José from the textclass and pass them to lyx2lyx. Even use a user
José defined file to do this convertion. What do you think?
I know, but I am ambivalent
On Tue, Nov 09, 2004 at 10:08:50AM +0100, Juergen Spitzmueller wrote:
What needs to be done beneath fixing the crashes is: getting the merge
feature in a workable state again.
This is not a big deal, since it's new in 1.4, it can easily be backed
out.
regards
john
Juergen Spitzmueller wrote:
I might be swayed if all three of you test and perfect this patch.
Well, then let's do our best ;-)
Well said.
Seriously, Georg, if we had a branch, it would be much easier to improve
and test in parallel (given that someone (you?) is willing to maintain
the
Am Dienstag, 9. November 2004 09:19 schrieb Lars Gullik Bjønnes:
I am quite happy with your patch...
Good.
with this fixed.
Of course ;-)
I am applying this now. I'll fix the users format later if it is needed
after Herberts explanation (which he hopefully gives).
Georg
Am Dienstag, 9. November 2004 18:28 schrieb Juergen Spitzmueller:
Lars Gullik Bjønnes wrote:
I might be swayed if all three of you test and perfect this patch.
Well, then let's do our best ;-)
Seriously, Georg, if we had a branch, it would be much easier to improve
and
test in parallel
For me a pure virtual method is an interface method and any other
is an implentation. What's wrong with virtual interface methods?
I prefer to think like Scott Meyers (of Effective C++/STL fame):
1. nonvirtual functions are invariants across specializations -- they should
never be overriden
On Nov 8, 2004, at 11:13 AM, Jean-Marc Lasgouttes wrote:
Bennett == Bennett Helm [EMAIL PROTECTED] writes:
Bennett The trouble in part is that the Mac's native file open/save
Bennett dialogs (which we now use) are drop-down sheets. When a
Bennett dialog is open in front of the main application
Lars Gullik Bjønnes wrote:
> Georg Baum <[EMAIL PROTECTED]>
> writes:
> This is a wrapper...
Yes, it was a misunderstanding, I was thinking you suggested a wrapper
around the wrapper, and I could not see why we want two wrappers ;-)
> is formatlist a member of something, or a global var?
It is
Vladimir Prus <[EMAIL PROTECTED]> writes:
| Lars Gullik Bj?nnes wrote:
>
>> | I'm not sure I understand the separation argument -- the extra
>> | forwarding layer just adds complexity (e.g. your change to inMatched()
>> | in insets/insetbase.h just double the number of characters ;-) ), but
>> |
Jean-Marc Lasgouttes wrote:
> Does the following one-liner patch help? I think this is a consequence
> of the fix of bug 1415, which increased the value of num_units.
Thanks, Jean-Marc. I'll try it when I am back home (Thursday).
Jürgen
José Abílio Oliveira Matos wrote:
> cutting the nonsense and being objective what needs to be done to release
> a stable 1.4.0?
>
> Is it reasonable to have a HEAD that has problems while Alfredo is fixing
> the bugs in the other branch?
>
> Looking in bugzilla for bugs related with 1.4.0,
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
| Hair-sore?
Lars> I get the correct expression is ... [in norwegian: hårsår] ...
Lars> "takes easily offence over trivialities" ... I don't know.
In French, "avoir mal au cheveux" is what you feel in the morning
after an
Juergen Spitzmueller wrote:
> I am have scanned bugzilla regularly recently and, if I could not fix
> them, tried to at least verify the status of the critical and major bugs.
> There are indeed not much that need to be fixed urgently (lots are
> "fixedintrunk", others ar long-time bugs), but
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
| +void layoutSelected(LyXView & lv, string name)
Lars> string const & name
Oops! It seems that it pays to post the patches.
| + // Yes, the _() is correct
Lars> But it shouldn't be... Should we ever work with translated names
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes:
Alfredo> now that drawSelection is separated from draw and called
Alfredo> before it, the background painting of colored insets
Alfredo> overwrites the selection.
Alfredo> A possible way of solving this is to draw the background
Juergen Spitzmueller wrote:
>> Does the following one-liner patch help? I think this is a consequence
>> of the fix of bug 1415, which increased the value of num_units.
>
> Thanks, Jean-Marc. I'll try it when I am back home (Thursday).
Actually, I just tried it and it fixes the crash. As in
Jean-Marc Lasgouttes wrote:
> Alfredo> now that drawSelection is separated from draw and called
> Alfredo> before it, the background painting of colored insets
> Alfredo> overwrites the selection.
>
> Alfredo> A possible way of solving this is to draw the background in
> Alfredo>
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes:
Alfredo> are you suggesting that we rename the virtual drawSelection
Alfredo> to drawBackground in the base inset class? Too many files to
Alfredo> change ;-)
It is just that the name drawSelection will become misleading if it
Jean-Marc Lasgouttes wrote:
> Alfredo> are you suggesting that we rename the virtual drawSelection
> Alfredo> to drawBackground in the base inset class? Too many files to
> Alfredo> change ;-)
>
> It is just that the name drawSelection will become misleading if it
> draws the background too...
On Tue, 2004-11-09 at 00:47 +, Andreas Vox wrote:
> Americans say 'touchy', I think, and in German it would be "dünnhäutig"
> (having a thin skin). Maybe _that_ is what makes you are perfect target
> for flame baits? ;-)
Thin-skinned works in English, although the opposite expression is more
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
>
| | +void layoutSelected(LyXView & lv, string name)
>
| Lars> string const & name
>
| Oops! It seems that it pays to post the patches.
>
| | + // Yes, the _() is correct
>
| Lars>
Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
> I try to check if all features are still working. Haven't tried branches and
> friends for a long time now.
I'm using branches with 1.4.0cvs. 60 page DocBook document, two branches with
10-20 insets total, lots of figures, one table.
The table
Lars Gullik Bj?nnes wrote:
>>> | I always though the point about NVI is that you can add
>>> | pre-processing/post-processing before calling the virtual function. At
>>> | least that what I've heard -- I never needed to add such pre/post
>>> | processing.
>>>
>>> That is also an argument. If you
Vladimir Prus <[EMAIL PROTECTED]> writes:
| small methods like accessors and 'clone' is up to you. I don't (yet?) think
| so.
It is only aimed at virtual functions... do you often have virtual
accessor functions?
--
Lgb
Lars Gullik Bj?nnes wrote:
> Vladimir Prus <[EMAIL PROTECTED]> writes:
>
> | small methods like accessors and 'clone' is up to you. I don't (yet?)
> | think so.
>
> It is only aimed at virtual functions... do you often have virtual
> accessor functions?
No. But here's what your patch contains:
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> Yes, I know. but ideally we should not work on the translated
Lars> name, but on some index instead.
What makes it a bit complicated is that obsolete layouts, which do
have an index in the list of layouts, do not appear in the
Vladimir Prus <[EMAIL PROTECTED]> writes:
| Lars Gullik Bj?nnes wrote:
>
>> Vladimir Prus <[EMAIL PROTECTED]> writes:
>>
>> | small methods like accessors and 'clone' is up to you. I don't (yet?)
>> | think so.
>>
>> It is only aimed at virtual functions... do you often have virtual
>> accessor
Lars Gullik Bj?nnes wrote:
> | - virtual bool isSpace() const { return false; }
> | + bool isSpace() const { return doIsSpace(); }
> | // should we have a non-filled line before this inset?
> | - virtual bool display() const { return false; }
> | + bool display()
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
>
| Lars> Yes, I know. but ideally we should not work on the translated
| Lars> name, but on some index instead.
>
| What makes it a bit complicated is that obsolete layouts, which do
Vladimir Prus <[EMAIL PROTECTED]> writes:
| Lars Gullik Bj?nnes wrote:
>
>> | - virtual bool isSpace() const { return false; }
>> | + bool isSpace() const { return doIsSpace(); }
>> | // should we have a non-filled line before this inset?
>> | - virtual bool display()
On Tue, Nov 09, 2004 at 01:38:49PM +0100, Jean-Marc Lasgouttes wrote:
>
> What makes it a bit complicated is that obsolete layouts, which do
> have an index in the list of layouts, do not appear in the combox. So
> using indices means more work.
Notice that we can remove the support for
On Tue, Nov 09, 2004 at 11:39:50AM +, Andreas Vox wrote:
>
> Branches work fine except two minor quirks:
> * If you insert a branch for the whole section, the layout becomes "standard"
>inside the branch inset and stays section outside, causing empty sectgions.
Could you give an
Andre' cursor positioning inside mathed doesn't work in coordbranch because
we are missing getCursorPos implementations. Could you have a look?
Alfredo
> "José" == José Abílio Oliveira Matos <[EMAIL PROTECTED]> writes:
José> On Tue, Nov 09, 2004 at 01:38:49PM +0100, Jean-Marc Lasgouttes
José> wrote:
>> What makes it a bit complicated is that obsolete layouts, which do
>> have an index in the list of layouts, do not appear in the combox.
>>
Lars Gullik Bjønnes wrote:
> | As it stands now I will not do further work on the booktabs stuff. I
> | really don't know wether that has any influence on the number of fixed
> | bugs or not.
That'd be a pity.
> I might be swayed if all three of you test and "perfect" this patch.
Well, then
Alfredo Braunstein wrote:
> I see. And what's the improvement wrt to plain LaTeX tables? The ability
> to put horizontal lines independently in any column?
The output quality. You can kind of "emulate" formal tables with LaTeX's own
tabular stuff, but that looks just plain ugly (to say the
On Tue, Nov 09, 2004 at 04:05:28PM +0100, Jean-Marc Lasgouttes wrote:
>
> José> Notice that we can remove the support for obsolete layouts
> José> from the textclass and pass them to lyx2lyx. Even use a user
> José> defined file to do this convertion. What do you think?
>
> I know, but I am
On Tue, Nov 09, 2004 at 10:08:50AM +0100, Juergen Spitzmueller wrote:
> What needs to be done beneath fixing the crashes is: getting the merge
> feature in a workable state again.
This is not a big deal, since it's new in 1.4, it can easily be backed
out.
regards
john
Juergen Spitzmueller wrote:
>> I might be swayed if all three of you test and "perfect" this patch.
>
> Well, then let's do our best ;-)
Well said.
> Seriously, Georg, if we had a branch, it would be much easier to improve
> and test in parallel (given that someone (you?) is willing to
Am Dienstag, 9. November 2004 09:19 schrieb Lars Gullik Bjønnes:
> I am quite happy with your patch...
Good.
> with this fixed.
Of course ;-)
I am applying this now. I'll fix the "users" format later if it is needed
after Herberts explanation (which he hopefully gives).
Georg
Am Dienstag, 9. November 2004 18:28 schrieb Juergen Spitzmueller:
> Lars Gullik Bjønnes wrote:
> > I might be swayed if all three of you test and "perfect" this patch.
>
> Well, then let's do our best ;-)
> Seriously, Georg, if we had a branch, it would be much easier to improve
and
> test in
> For me a pure virtual method is an interface method and any other
> is an implentation. What's wrong with virtual interface methods?
I prefer to think like Scott Meyers (of Effective C++/STL fame):
1. nonvirtual functions are invariants across specializations -- they should
never be overriden
On Nov 8, 2004, at 11:13 AM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> The trouble in part is that the Mac's native file open/save
Bennett> dialogs (which we now use) are drop-down sheets. When a
Bennett> dialog is open in front of the main
72 matches
Mail list logo
