Getting rid of qttableview.[Ch]

2006-05-05 Thread Abdelrazak Younes
I see that qttableview in current lyx code is exactly the same as the one in my local Qt3Win tree except for the include of and the test on HAVE_LIMITS_H. This change was done at revision 9876 by Angus with the following log: Consistent use of preprocessor guards; include in .C files, not .h

Re: Getting rid of qttableview.[Ch]

2006-05-05 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : I see that qttableview in current lyx code is exactly the same as the one in my local Qt3Win tree except for the include of and the test on HAVE_LIMITS_H. This change was done at revision 9876 by Angus with the following log: Consistent use of preprocessor guards;

Re: Getting rid of qttableview.[Ch]

2006-05-05 Thread Georg Baum
Abdelrazak Younes wrote: > This class was supposed to be obsoleted after Qt3.0 but I see that it is > in my Qt3Win tree. Is it also there on the official Qt3 distribution? No. The last relase that contains it was 3.0 according to http://doc.trolltech.com. > If > yes, we should just use it and r

Re: Getting rid of qttableview.[Ch]

2006-05-05 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: This class was supposed to be obsoleted after Qt3.0 but I see that it is in my Qt3Win tree. Is it also there on the official Qt3 distribution? No. The last relase that contains it was 3.0 according to http://doc.trolltech.com. If yes, we should

Re: Getting rid of qttableview.[Ch]

2006-05-05 Thread Georg Baum
Abdelrazak Younes wrote: > It is there in src/attic/ of Qt-3.3 as well as qtmultilineedit. See my > other post. That does not help. I am not going to compile my own qt but use the one SuSE provides, and that does not contain it. Georg

Re: Getting rid of qttableview.[Ch]

2006-05-05 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I see that qttableview in current lyx code is exactly the Abdelrazak> same as the one in my local Qt3Win tree except for the Abdelrazak> include of and the test on HAVE_LIMITS_H. This Abdelrazak> change was done at re

Re: Getting rid of qttableview.[Ch]

2006-05-05 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> By the way, there is not any explanation as to why testing Abdelrazak> for HAVE_LIMITS_H have been introduced in svn history. I Abdelrazak> think it is again a gettext need. This has nothing todo with gettext. Some s

Re: Getting rid of qttableview.[Ch]

2006-05-05 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I see that qttableview in current lyx code is exactly the Abdelrazak> same as the one in my local Qt3Win tree except for the Abdelrazak> include of and the test on HAVE_LIMITS_H. This Abdel

Re: Getting rid of qttableview.[Ch]

2006-05-05 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: It is there in src/attic/ of Qt-3.3 as well as qtmultilineedit. See my other post. That does not help. I am not going to compile my own qt but use the one SuSE provides, and that does not contain it. Of course it doesn't help, I am proposing to

Re: Getting rid of qttableview.[Ch]

2006-05-05 Thread Angus Leeming
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Of course it doesn't help, I am proposing to update the copy to the > current version (included in Qt3.3 source). > You guys make a big story about a grain of salt. The file in question is deprecated by Qt and exists in our sources as a band-aid so

Re: Getting rid of qttableview.[Ch]

2006-05-05 Thread Abdelrazak Younes
Angus Leeming a écrit : Abdelrazak Younes <[EMAIL PROTECTED]> writes: Of course it doesn't help, I am proposing to update the copy to the current version (included in Qt3.3 source). You guys make a big story about a grain of salt. The file in question is deprecated by Qt and exists in our s

Re: Getting rid of qttableview.[Ch]

2006-05-07 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdel. | Index: qttableview.C | === | --- qttableview.C (revision 13796) | +++ qttableview.C (working copy) | @@ -1,36 +1,24 @@ | /**

Re: Getting rid of qttableview.[Ch]

2006-05-09 Thread younes . a
Hum this mail is not in gmane too... Quoting Jean-Marc Lasgouttes <[EMAIL PROTECTED]>: > > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Abdelrazak> Nothing happened to qttableview.h only to qttableview.C. > Abdelrazak> qttableview.h is the verbatim copy of december 2001; s

Re: Getting rid of qttableview.[Ch]

2006-05-09 Thread Jean-Marc Lasgouttes
> "younes" == younes a <[EMAIL PROTECTED]> writes: >> Indeed. And I have checked that both qt and boost input without >> any guard, which means that we can indeed remove the HAVE_LIMITS_H >> macro. younes> Houra!!! We spoke about that bloody change for a complete day. You would have been mo

Re: Getting rid of qttableview.[Ch]

2006-05-09 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "younes" == younes a <[EMAIL PROTECTED]> writes: Indeed. And I have checked that both qt and boost input without any guard, which means that we can indeed remove the HAVE_LIMITS_H macro. younes> Houra!!! We spoke about that bloody change for a complete day. Y

Re: Getting rid of qttableview.[Ch]

2006-05-09 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "younes" == younes a <[EMAIL PROTECTED]> writes: | | >> Indeed. And I have checked that both qt and boost input without | >> any guard, which means that we can indeed remove the HAVE_LIMITS_H | >> macro. | | younes> Houra!!! We spoke abou

Re: Getting rid of qttableview.[Ch]

2006-05-09 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I think (not sure) I have said that the original file Abdelrazak> didn't do the test and that Qt is very portable so why Abdelrazak> should we? Yes, but the file was not part of qt itself, and I was suspicious it migh

Re: Getting rid of qttableview.[Ch]

2006-05-09 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: | | Abdelrazak> I think (not sure) I have said that the original file | Abdelrazak> didn't do the test and that Qt is very portable so why | Abdelrazak> should we? | | Yes, but

Re: Getting rid of qttableview.[Ch]

2006-05-09 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> support/lyxdir.h? Sorry. support/lyxlib.h. I think most of it is covered by boost, isn't it? JMarc

Re: Getting rid of qttableview.[Ch]

2006-05-09 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Actually that one is troublesome... last time I checked boost Lars> have no way of setting the mode for the created dir. What mode does it use? I see we use either 700 or 777, why is that? We could just rely on umask, couldn't

Re: Getting rid of qttableview.[Ch]

2006-05-09 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Actually that one is troublesome... last time I checked boost Lars> have no way of setting the mode for the created dir. Jean-Marc> What mode does it use? I

Re: Getting rid of qttableview.[Ch]

2006-05-09 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> support/lyxdir.h? | | Sorry. support/lyxlib.h. I think most of it is covered by boost, isn't | it? getcwd rename¹ copy unlink mkdir² ¹ boost::rename might not be goo

Re: Getting rid of qttableview.[Ch]

2006-05-09 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Lars> And... the easy way to change these functions is not to change | Lars> the header files, at least not initally, but just change the | Lars> implementation. | | Or not use the function at all, but rather boost directly? I would prefere just