Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Andre Poenitz
On Tue, Feb 03, 2004 at 10:43:28AM -0800, Kayvan A. Sylvan wrote: The math mode seems to work again (no superscript crash) --- I have not tested extensively. I noticed the following: 1) selection does not seem to be giving visual feedback (i.e. I can position the cursor and then do

Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Andre Poenitz
On Tue, Feb 03, 2004 at 09:11:51PM +0100, Alfredo Braunstein wrote: Kayvan A. Sylvan wrote: The math mode seems to work again (no superscript crash) --- I have not tested extensively. I noticed the following: 1) selection does not seem to be giving visual feedback (i.e. I can

Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Alfredo Braunstein
Andre Poenitz wrote: The following patch should fix the crash. The culprit is that insetcollapsable::edit(x,y) should not call insettext::edit(cur,x,y) when opening (the inset was not visible before) but insettext::edit(cur, true). Hm.. is that a proper fix? You tell me. The fact is that

Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Andre Poenitz
On Wed, Feb 04, 2004 at 09:50:43AM +0100, Alfredo Braunstein wrote: Andre Poenitz wrote: The following patch should fix the crash. The culprit is that insetcollapsable::edit(x,y) should not call insettext::edit(cur,x,y) when opening (the inset was not visible before) but

Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Alfredo Braunstein
Andre Poenitz wrote: Put it in and add a #warning look here. Done. The fact is that it's kind of dumb to try to acess the insettext's coordinates when it hasn't been drawn before: the user surely didn't intended that when clicking (the inset wasn't visible). It seems cleaner to me not to

Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Andre Poenitz
On Wed, Feb 04, 2004 at 10:21:00AM +0100, Alfredo Braunstein wrote: Otherwise, we should ascertain that we have coordinates before (i.e. an update has been called) before calling LyXText::edit(x,y)... ugly. Or put some 'sensible' value there, i.e. LCursor::getPos() or similae Put a

Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Andre Poenitz
On Tue, Feb 03, 2004 at 10:43:28AM -0800, Kayvan A. Sylvan wrote: > The math mode seems to work again (no superscript crash) --- I have > not tested extensively. > > I noticed the following: > > 1) selection does not seem to be giving visual feedback (i.e. I can position >the cursor and then

Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Andre Poenitz
On Tue, Feb 03, 2004 at 09:11:51PM +0100, Alfredo Braunstein wrote: > Kayvan A. Sylvan wrote: > > > The math mode seems to work again (no superscript crash) --- I have > > not tested extensively. > > > > I noticed the following: > > > > 1) selection does not seem to be giving visual feedback

Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Alfredo Braunstein
Andre Poenitz wrote: >> The following patch should fix the crash. The culprit is that >> insetcollapsable::edit(x,y) should not call insettext::edit(cur,x,y) when >> opening (the inset was not visible before) but insettext::edit(cur, >> true). > > Hm.. is that a proper fix? You tell me. The

Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Andre Poenitz
On Wed, Feb 04, 2004 at 09:50:43AM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > >> The following patch should fix the crash. The culprit is that > >> insetcollapsable::edit(x,y) should not call insettext::edit(cur,x,y) when > >> opening (the inset was not visible before) but

Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Alfredo Braunstein
Andre Poenitz wrote: > Put it in and add a "#warning look here". Done. >> The fact is that it's kind of dumb to try to acess the insettext's >> coordinates when it hasn't been drawn before: the user surely didn't >> intended that when clicking (the inset wasn't visible). It seems cleaner >> to

Re: Latest CVS Lyx: Much better!

2004-02-04 Thread Andre Poenitz
On Wed, Feb 04, 2004 at 10:21:00AM +0100, Alfredo Braunstein wrote: > >> Otherwise, we should ascertain that we have coordinates before (i.e. an > >> update has been called) before calling LyXText::edit(x,y)... ugly. > > > > Or put some 'sensible' value there, i.e. LCursor::getPos() or similae >

Latest CVS Lyx: Much better!

2004-02-03 Thread Kayvan A. Sylvan
The math mode seems to work again (no superscript crash) --- I have not tested extensively. I noticed the following: 1) selection does not seem to be giving visual feedback (i.e. I can position the cursor and then do SHIFT-down-arrow and BACKSPACE to delete some text, but the selection is

Re: Latest CVS Lyx: Much better!

2004-02-03 Thread Alfredo Braunstein
Kayvan A. Sylvan wrote: The math mode seems to work again (no superscript crash) --- I have not tested extensively. I noticed the following: 1) selection does not seem to be giving visual feedback (i.e. I can position the cursor and then do SHIFT-down-arrow and BACKSPACE to delete

Re: Latest CVS Lyx: Much better!

2004-02-03 Thread Alfredo Braunstein
Alfredo Braunstein wrote: The following patch should fix the crash. The culprit is that Upmh old patch. See this one instead. Alfredo? PosIterator.C-save ? PosIterator.h-save ? all.diff ? bfs.cpp ? files ? save ? frontends/screen.C-save Index: insets/insetcollapsable.C

Latest CVS Lyx: Much better!

2004-02-03 Thread Kayvan A. Sylvan
The math mode seems to work again (no superscript crash) --- I have not tested extensively. I noticed the following: 1) selection does not seem to be giving visual feedback (i.e. I can position the cursor and then do SHIFT-down-arrow and BACKSPACE to delete some text, but the selection is

Re: Latest CVS Lyx: Much better!

2004-02-03 Thread Alfredo Braunstein
Kayvan A. Sylvan wrote: > The math mode seems to work again (no superscript crash) --- I have > not tested extensively. > > I noticed the following: > > 1) selection does not seem to be giving visual feedback (i.e. I can > position >the cursor and then do SHIFT-down-arrow and BACKSPACE to

Re: Latest CVS Lyx: Much better!

2004-02-03 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > The following patch should fix the crash. The culprit is that Upmh old patch. See this one instead. Alfredo? PosIterator.C-save ? PosIterator.h-save ? all.diff ? bfs.cpp ? files ? save ? frontends/screen.C-save Index: insets/insetcollapsable.C