Re: Patch for bug in elsarticle.cls

2018-12-31 Thread Scott Kostyshak
ller wrote: > > > > 2018-09-06 10:48 GMT+02:00 Rishikesan Nair T : > > > > > > > > > Dear Jürgen, > > > > > > > > > > Thank you for the patch. Next week we will release an updated version > > > > > to > >

Re: Patch for bug in elsarticle.cls

2018-12-31 Thread Kornel Benko
> > > > > > Dear Jürgen, > > > > > > > > Thank you for the patch. Next week we will release an updated version to > > > > CTAN. We will include this patch as well. > > > > > > > > thank you > > > > > > > &g

Re: Patch for bug in elsarticle.cls

2018-12-31 Thread Scott Kostyshak
On Thu, Sep 06, 2018 at 10:50:50AM +0200, Jürgen Spitzmüller wrote: > 2018-09-06 10:48 GMT+02:00 Rishikesan Nair T : > > > Dear Jürgen, > > > > Thank you for the patch. Next week we will release an updated version to > > CTAN. We will include this patch as well. &

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 18:20, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Try again with recent master. Jürgen I'll give up. It was fun. Daniel

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 16:29, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 13:56 +0100 schrieb Daniel: Did you check whether those not on the list do actually have GBs? Yes. Daniel And some are missing from your list, like FindAndReplaceUi.ui. Thanks, added. Jürgen Okay, I'll give

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 12:35 +0100 schrieb Jürgen Spitzmüller: > Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: > > Thanks. But I like mine more (see attached screen shot). > > I don't see the misalignment in your screenshot here on Linux. But I > saw a misalignme

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: > Thanks. But the buttons are misaligned now (see attachment). Try again with recent master. Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:56 +0100 schrieb Daniel: > > Did you check whether those not on the list do actually have GBs? Yes. > > > > Daniel > > And some are missing from your list, like FindAndReplaceUi.ui. Thanks, added. Jürgen signature.asc Description: This is a digitally signed

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:43 +0100 schrieb Daniel: > > I am probably confused. Do you ask me to recreate my patch with > current > master Yes, please. > which you successfully applied before and found to be misaligned? Yes. Thanks Jürgen > > Daniel > s

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
patch (in the following message) does not apply to master. If you remove your patch it should apply fine. Merry Christmas Jürgen Merry Christmas to you too! Daniel I really like your critical approach. I think it is beneficial for the development of LyX. But I hope you understand that I

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
understand that this is a general rule of dialogs in LyX. However, please consider an exception to this rule for the quick search and replace dialog. No. That's hard to reason with. All apps I checked have the checkboxes aligned to minimize space. BTW your patch (in the following message) does

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 13:46, Daniel wrote: On 25/12/2018 13:22, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: It is not that only some of the GBs are out of line. Almost all are non-flat. I count only a minority where the flat designation was missing. Namely    

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 13:22, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: It is not that only some of the GBs are out of line. Almost all are non-flat. I count only a minority where the flat designation was missing. Namely

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 13:26, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 13:08 +0100 schrieb Daniel: Can you show me what my patch looks like on the style you use? Then I could try to figure out what went wrong with it. If you send me a patch that applies to master, sure. Jürgen You

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:08 +0100 schrieb Daniel: > Can you show me what my patch looks like on the style you use? Then > I > could try to figure out what went wrong with it. If you send me a patch that applies to master, sure. Jürgen > > Daniel > signatu

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: > > It is not that only some of the GBs are out of line. Almost all are > non-flat. I count only a minority where the flat designation was missing. Namely src/frontends/qt4/ui/CharacterUi.ui src/frontends/qt4/ui/CitationUi.ui

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:35, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: Thanks. But I like mine more (see attached screen shot). I don't see the misalignment in your screenshot here on Linux. But I saw a misalignment with your patch. It maybe depends on the Qt

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). Sorry, forgot to comment on this. That the misalignment does not happen for you is because text

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
of dialogs in LyX. However, please consider an exception to this rule for the quick search and replace dialog. No. That's hard to reason with. All apps I checked have the checkboxes aligned to minimize space. BTW your patch (in the following message) does not apply to master. If you remove

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 25/12/2018 12:28, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:21 +0100 schrieb Daniel: Thanks. You changed the group box style to flat, right? I still think this isn't LyX standard. It's LyX standard. We changed that some years ago. If some GBs are non- flat, we should change

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: > Thanks. But I like mine more (see attached screen shot). I don't see the misalignment in your screenshot here on Linux. But I saw a misalignment with your patch. It maybe depends on the Qt style. Jürgen signature.asc Descript

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:21 +0100 schrieb Daniel: > Thanks. You changed the group box style to flat, right? I still > think > this isn't LyX standard. It's LyX standard. We changed that some years ago. If some GBs are non- flat, we should change that. Jürgen signature.asc Description:

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
ever, > please consider an exception to this rule for the quick search and > replace dialog. No. BTW your patch (in the following message) does not apply to master. Merry Christmas Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel
On 24/12/2018 22:45, Daniel wrote: On 24/12/2018 14:48, Jürgen Spitzmüller wrote: Am Montag, den 29.10.2018, 15:16 +0100 schrieb Daniel: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could pro

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Daniel
On 24/12/2018 14:48, Jürgen Spitzmüller wrote: Am Montag, den 29.10.2018, 15:16 +0100 schrieb Daniel: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the other dialog fixes. Sorry, reord

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Daniel
On 24/12/2018 16:01, Jürgen Spitzmüller wrote: Am Mittwoch, den 31.10.2018, 07:57 +0100 schrieb Daniel: Compare dialog. Reworked version committed. Thanks, Jürgen Thanks. You changed the group box style to flat, right? I still think this isn't LyX standard. It is also not Qt's default.

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Daniel
On 24/12/2018 17:46, Jürgen Spitzmüller wrote: Am Mittwoch, den 24.10.2018, 13:36 +0200 schrieb Daniel: fixed version attached. Please repost as separate patch, should this combined patch include something not yet addressed. Thanks, Jürgen I don't think so. I separated all after being

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Daniel
On 24/12/2018 16:03, Jürgen Spitzmüller wrote: Am Mittwoch, den 31.10.2018, 16:58 +0100 schrieb Daniel: Okay, maybe I should explain a bit, especially if a change might be controversial. I think the checkbox is better placed next to the button box because it makes is more obvious where it

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 24.10.2018, 13:36 +0200 schrieb Daniel: > fixed version attached. Please repost as separate patch, should this combined patch include something not yet addressed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.10.2018, 18:20 +0100 schrieb Daniel: > Search & Replace Advanced. A bit more extensive changes. Slightly modified version committed (additional vspacer added). Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Donnerstag, den 22.11.2018, 11:03 +0100 schrieb Daniel: > Paragraph dialog fixes attached. Committed minus the group box changes (we use flat GBs in all dialogs). Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
awkwardly stretched > > > > Daniel > > And the patch ... Committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Freitag, den 16.11.2018, 15:41 +0100 schrieb Daniel: > Just stumbled upon a misplaced spacer in the Table Insert dialog. > Patch and screen captures attached. Committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.10.2018, 17:46 +0100 schrieb Daniel: > Messages Pane. Committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.10.2018, 16:58 +0100 schrieb Daniel: > Okay, maybe I should explain a bit, especially if a change might be > controversial. I think the checkbox is better placed next to the > button > box because it makes is more obvious where it belongs to. There is > no > other obvious

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.10.2018, 07:57 +0100 schrieb Daniel: > Compare dialog. Reworked version committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Mittwoch, den 31.10.2018, 07:24 +0100 schrieb Daniel: > Thesaurus dialog. Committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Dienstag, den 30.10.2018, 21:23 +0100 schrieb Daniel: > Spellchecker dialog. Committed. Jürgen signature.asc Description: This is a digitally signed message part

Re: Patch test with several minor dialog alignment fixes

2018-12-24 Thread Jürgen Spitzmüller
Am Montag, den 29.10.2018, 15:16 +0100 schrieb Daniel: > On 29/10/2018 14:12, Daniel wrote: > > Attached is a patch for the Find & Replace (Quick) dialog for > > master. If > > the patch is works, I could proceed with the other dialog fixes. > > Sorry, reordere

Re: Patch for Windows Slowness Problem

2018-12-13 Thread Jean-Marc Lasgouttes
for testing and, if that works, then I'll release a 2.3.2-1 tarball and a Windows installer built on it as soon as I'm able. Comments welcome on that, too. The other patch Both patches seem fine to me. JMarc

Re: Patch for Windows Slowness Problem

2018-12-11 Thread Richard Kimberly Heck
On 12/12/18 1:41 AM, Richard Kimberly Heck wrote: > Another issue like the one we had with the 2.3.1 release, related to the > fix for #9158. The commit message explains the issue. The fix seems to > me to make sense anyway. > > The second patch also seems to me to make sens

Patch for Windows Slowness Problem

2018-12-11 Thread Richard Kimberly Heck
Another issue like the one we had with the 2.3.1 release, related to the fix for #9158. The commit message explains the issue. The fix seems to me to make sense anyway. The second patch also seems to me to make sense, and it ought to prevent these kinds of issues arising in future. But maybe it's

Re: [patch] Keep permissions on the saved files

2018-12-07 Thread Richard Kimberly Heck
On 12/7/18 10:25 AM, Pavel Sanda wrote: > Hi, > > per discussion on users list, attached is the patch which will > keep permission after saving of the file. > By default creating temps is subject to rw+ for user only > and after moving temp to original location the pe

[patch] Keep permissions on the saved files

2018-12-07 Thread Pavel Sanda
Hi, per discussion on users list, attached is the patch which will keep permission after saving of the file. By default creating temps is subject to rw+ for user only and after moving temp to original location the perms were destroyed. Will commit soon if nobody objects. Pavel diff --git a/src

Re: [patch] Correctly update after buffer-anonymize in branch

2018-12-01 Thread Pavel Sanda
On Thu, Nov 29, 2018 at 02:16:28PM +0100, Jean-Marc Lasgouttes wrote: > I do not know why there is a difference between master and branch, and I do > not like it. > > I think this should go in both master and branch, because it is sane. There there. P

Re: [patch] Correctly update after buffer-anonymize in branch

2018-11-29 Thread Richard Kimberly Heck
On 11/29/18 8:16 AM, Jean-Marc Lasgouttes wrote: > Le 29/11/2018 à 13:21, Pavel Sanda a écrit : >> Riki, >> >> this needs to get to the branch at certain point. >> >> In master the screen update after buffer-anonymize happens without >> screenUpdate, >&g

Re: [patch] Correctly update after buffer-anonymize in branch

2018-11-29 Thread Jean-Marc Lasgouttes
Le 29/11/2018 à 13:21, Pavel Sanda a écrit : Riki, this needs to get to the branch at certain point. In master the screen update after buffer-anonymize happens without screenUpdate, but in branch it does not, hence the patch. It touches only this esoteric lfun, so it's safe, but it can wait

[patch] Correctly update after buffer-anonymize in branch

2018-11-29 Thread Pavel Sanda
Riki, this needs to get to the branch at certain point. In master the screen update after buffer-anonymize happens without screenUpdate, but in branch it does not, hence the patch. It touches only this esoteric lfun, so it's safe, but it can wait after release if you wish. Pavel diff --git

Re: Patch test with several minor dialog alignment fixes

2018-11-22 Thread Kornel Benko
Am Donnerstag, 22. November 2018 11:03:00 CET schrieb Daniel : > Paragraph dialog fixes attached. > > Daniel +1 Kornel signature.asc Description: This is a digitally signed message part.

Re: Patch test with several minor dialog alignment fixes

2018-11-22 Thread Daniel
the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. Compare dialog. Preferences dialog. (This might be a more controversial change.) Messages Pane. Search & Replace Advanced. A bit more extensive changes. Just stumbled upon a misplaced spacer in the Table Insert

Re: Patch test with several minor dialog alignment fixes

2018-11-22 Thread Daniel
ker dialog. Thesaurus dialog. Compare dialog. Preferences dialog. (This might be a more controversial change.) Messages Pane. Search & Replace Advanced. A bit more extensive changes. Just stumbled upon a misplaced spacer in the Table Insert dialog. Patch and screen captures attached

Re: Patch test with several minor dialog alignment fixes

2018-11-22 Thread Daniel
are dialog. Preferences dialog. (This might be a more controversial change.) Messages Pane. Search & Replace Advanced. A bit more extensive changes. Just stumbled upon a misplaced spacer in the Table Insert dialog. Patch and screen captures attached. Daniel I suggest a fixed

Re: Patch test with several minor dialog alignment fixes

2018-11-16 Thread Daniel
This might be a more controversial change.) Messages Pane. Search & Replace Advanced. A bit more extensive changes. Just stumbled upon a misplaced spacer in the Table Insert dialog. Patch and screen captures attached. Daniel >From 9922b971ae8c8419a1e369e427b8981072b4c01e Mon Sep 17 0

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Scott Kostyshak
On Thu, Nov 01, 2018 at 09:35:25PM +0100, Daniel wrote: > On 2018-11-01 21:07, Scott Kostyshak wrote: > > On Thu, Nov 01, 2018 at 05:18:18PM +0100, Daniel wrote: > > > On 01/11/2018 16:58, Scott Kostyshak wrote: > > > > On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: > > > > > > > > >

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Daniel
On 2018-11-01 21:07, Scott Kostyshak wrote: On Thu, Nov 01, 2018 at 05:18:18PM +0100, Daniel wrote: On 01/11/2018 16:58, Scott Kostyshak wrote: On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: Great. And by the way, while I tend to think all the changes I make sense, I can change

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Scott Kostyshak
On Thu, Nov 01, 2018 at 05:18:18PM +0100, Daniel wrote: > On 01/11/2018 16:58, Scott Kostyshak wrote: > > On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: > > > > > Great. And by the way, while I tend to think all the changes I make > > > sense, I > > > can change things on feedback. > >

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Daniel
On 01/11/2018 16:58, Scott Kostyshak wrote: On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: Great. And by the way, while I tend to think all the changes I make sense, I can change things on feedback. Sounds good. One comment which I'm not sure is relevant is: often Qt Creator

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Scott Kostyshak
On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: > Great. And by the way, while I tend to think all the changes I make sense, I > can change things on feedback. Sounds good. One comment which I'm not sure is relevant is: often Qt Creator reformats a bunch of things when you save. I find

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Daniel
On 01/11/2018 12:45, Kornel Benko wrote: Am Donnerstag, 1. November 2018 12:32:13 CET schrieb Daniel : On 01/11/2018 10:42, Kornel Benko wrote: Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel : Thanks for checking. That the left hand labels don't stretch was driven by the

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Kornel Benko
Am Donnerstag, 1. November 2018 12:32:13 CET schrieb Daniel : > On 01/11/2018 10:42, Kornel Benko wrote: > > Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel > > : > > > Thanks for checking. That the left hand labels don't stretch was driven > by > the idea that it

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Daniel
On 01/11/2018 10:42, Kornel Benko wrote: Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel : Thanks for checking. That the left hand labels don't stretch was driven by the idea that it would be easier to match the label and the text boxes. As for the buttons: I have never seen a

Re: Patch test with several minor dialog alignment fixes

2018-11-01 Thread Kornel Benko
Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel : ... > >> Thanks for checking. That the left hand labels don't stretch was driven by > >> the idea that it would be easier to match the label and the text boxes. As > >> for the buttons: I have never seen a (professional) dialog UI where

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
On 01/11/2018 02:02, Scott Kostyshak wrote: On Wed, Oct 31, 2018 at 04:54:21PM +0100, Daniel wrote: On 31/10/2018 16:05, Scott Kostyshak wrote: On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46,

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Scott Kostyshak
On Wed, Oct 31, 2018 at 04:54:21PM +0100, Daniel wrote: > On 31/10/2018 16:05, Scott Kostyshak wrote: > > On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: > > > On 30/10/2018 21:23, Daniel wrote: > > > > On 30/10/2018 17:37, Daniel wrote: > > > > > On 30/10/2018 16:46, Scott Kostyshak

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
ane. >From 7096147624ff1d3564a670fd9a09b77f220da27c Mon Sep 17 00:00:00 2001 From: Daniel Ramoeller Date: Wed, 31 Oct 2018 17:44:27 +0100 Subject: [PATCH] Fix for Messages dialog UI: - keep the options together --- src/frontends/qt4/ui/ProgressViewUi.ui | 213 ++--- 1 file changed, 119 inse

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
On 31/10/2018 16:05, Scott Kostyshak wrote: On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking.

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Scott Kostyshak
On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: > On 30/10/2018 21:23, Daniel wrote: > > On 30/10/2018 17:37, Daniel wrote: > > > On 30/10/2018 16:46, Scott Kostyshak wrote: > > > > On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: > > > > > > > > > Thanks for checking. The minimum

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
d fix what seem to me positioning issues in the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. Compare dialog. >From 4bc23c796007af34dd09be23b7dd1d3d4bf1c53d Mon Sep 17 00:00:00 2001 From: Daniel Ramoeller Date: Wed, 31 Oct 2018 07:42:31 +0100 Subject: [PATCH] Fix for Comp

Re: Patch test with several minor dialog alignment fixes

2018-10-31 Thread Daniel
ing issues in the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. >From 665d52a28bf6c96f10cb451729d84b9b5e7ebe44 Mon Sep 17 00:00:00 2001 From: Daniel Ramoeller Date: Wed, 31 Oct 2018 07:23:33 +0100 Subject: [PATCH] Fix for Thesaurus dialog UI: - don't stretch labels and butt

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Daniel
. Daniel Spellchecker dialog. >From 7e9d36065fa3c892d53b69951d0f7055325d02b9 Mon Sep 17 00:00:00 2001 From: Daniel Ramoeller Date: Tue, 30 Oct 2018 21:22:26 +0100 Subject: [PATCH] Fix for Spellchecker dialog UI: - fixed button width --- src/frontends/qt4/ui/SpellcheckerUi.ui | 249 +++-

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Daniel
On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Scott Kostyshak
On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: > Thanks for checking. The minimum height was actually a bit imprecise. I > should have written: "fixed at minimum height". In current master you can > increase the height but I couldn't see what is to be gained by this and many > other apps

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Daniel
On 30/10/2018 16:09, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 09:07:54AM +0100, Daniel wrote: On 30/10/2018 00:14, Richard Kimberly Heck wrote: On 10/29/18 10:16 AM, Daniel wrote: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for ma

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Scott Kostyshak
On Tue, Oct 30, 2018 at 09:07:54AM +0100, Daniel wrote: > On 30/10/2018 00:14, Richard Kimberly Heck wrote: > > On 10/29/18 10:16 AM, Daniel wrote: > > > On 29/10/2018 14:12, Daniel wrote: > > > > Attached is a patch for the Find & Replace (Quick) dialog for mas

Re: Patch test with several minor dialog alignment fixes

2018-10-30 Thread Daniel
On 30/10/2018 00:14, Richard Kimberly Heck wrote: On 10/29/18 10:16 AM, Daniel wrote: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the other dialog fixes. Sorry, reordered checkb

Re: Patch test with several minor dialog alignment fixes

2018-10-29 Thread Richard Kimberly Heck
On 10/29/18 10:16 AM, Daniel wrote: > On 29/10/2018 14:12, Daniel wrote: >> Attached is a patch for the Find & Replace (Quick) dialog for master. >> If the patch is works, I could proceed with the other dialog fixes. > > Sorry, reordered checkboxes for no good reason...

Re: Patch test with several minor dialog alignment fixes

2018-10-29 Thread Daniel
On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the other dialog fixes. Sorry, reordered checkboxes for no good reason... Daniel From 3a91987679bae0211959101a6fd27d7e74c474df Mon Sep 17 0

Re: Patch test with several minor dialog alignment fixes

2018-10-29 Thread Daniel
Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the other dialog fixes. Daniel From edca7251626378a5bff5aab0806a0a1689debd0a Mon Sep 17 00:00:00 2001 From: Daniel Ramoeller Date: Mon, 29 Oct 2018 14:08:34 +0100 Subject: [P

Re: Patch test with several minor dialog alignment fixes

2018-10-27 Thread Richard Kimberly Heck
t;>> possible, for example, on MacOS but it seems not to be on Windows. >>>>>>> So, it would be great if someone could test what it looks like >>>>>>> when docked to the top.[...] >>>>>> >>>>>> This was apparently due to a

Re: Patch test with several minor dialog alignment fixes

2018-10-27 Thread Daniel
fine in Windows with Qt 5.9.7. Top/bottom docked looks a bit ugly (as it used to). I'll try to fix it. New patch attached. Also a screen capture as an example of how I changed things. Two things I noticed: - The Quick Find & Replace dialog had a variable height but there were no elements in it th

Re: Patch test with several minor dialog alignment fixes

2018-10-27 Thread Richard Kimberly Heck
>>>> when docked to the top.[...] >>>> >>>> This was apparently due to a bug in Qt 5.11.2. Docking works fine >>>> in Windows with Qt 5.9.7. Top/bottom docked looks a bit ugly (as it >>>> used to). I'll try to fix it. >>> >

Re: Patch test with several minor dialog alignment fixes

2018-10-26 Thread Daniel
On 24/10/2018 13:36, Daniel wrote: On 24/10/2018 12:20, Daniel wrote: On 24/10/2018 11:40, Daniel wrote: On 23/10/2018 18:37, Daniel wrote: - There is something strange going on with the size of the Advanced Find and Replace Widget. When docked to the top (or docked to the top and then

Re: Patch test with several minor dialog alignment fixes

2018-10-25 Thread Daniel
On 25/10/2018 20:40, Richard Kimberly Heck wrote: On 10/25/18 5:47 AM, Daniel wrote: The patch was created with 2.3.x checked out. Maybe that is not how one has to do it? I was unable to work on master due to incompatibility with visual studio. These problems are fixed now but I don't know how

Re: Patch test with several minor dialog alignment fixes

2018-10-25 Thread Richard Kimberly Heck
On 10/25/18 5:47 AM, Daniel wrote: > The patch was created with 2.3.x checked out. Maybe that is not how > one has to do it? I was unable to work on master due to > incompatibility with visual studio. These problems are fixed now but I > don't know how to "forport". Any

Re: Patch test with several minor dialog alignment fixes

2018-10-25 Thread Daniel
The patch was created with 2.3.x checked out. Maybe that is not how one has to do it? I was unable to work on master due to incompatibility with visual studio. These problems are fixed now but I don't know how to "forport". Any suggestion appreciated. Or is it enough that the

Re: Patch test with several minor dialog alignment fixes

2018-10-24 Thread Daniel
try to fix it. New patch attached. Also a screen capture as an example of how I changed things. Two things I noticed: - The Quick Find & Replace dialog had a variable height but there were no elements in it that would need a variable height so I fixed it. But maybe there is a specifi

Re: Patch test with several minor dialog alignment fixes

2018-10-24 Thread Daniel
eems not to be on Windows. So, it would be great if someone could test what it looks like when docked to the top.[...] This was apparently due to a bug in Qt 5.11.2. Docking works fine in Windows with Qt 5.9.7. Top/bottom docked looks a bit ugly (as it used to). I'll try to fix it. New patch attached.

Re: Patch test with several minor dialog alignment fixes

2018-10-24 Thread Daniel
reat if someone could test what it looks like when docked to the top.[...] This was apparently due to a bug in Qt 5.11.2. Docking works fine in Windows with Qt 5.9.7. Top/bottom docked looks a bit ugly (as it used to). I'll try to fix it. New patch attached. Also a screen capture as an exa

Re: Patch test with several minor dialog alignment fixes

2018-10-23 Thread Daniel
On 23/10/2018 11:21, Daniel wrote: [...] One thing I couldn't try out is the Advanced Search & Replace dialog when docked to the top or bottom. I remember that this is possible, for example, on MacOS but it seems not to be on Windows. So, it would be great if someone could test what it looks

Patch test with several minor dialog alignment fixes

2018-10-23 Thread Daniel
Attached is an attempt to create a patch. I hope everything is set up correctly. I did some minor dialog alignment fixes using Qt Creator. One thing I couldn't try out is the Advanced Search & Replace dialog when docked to the top or bottom. I remember that this is possible, for exa

Re: [PATCH] [2.3.x] tex2lyx support for horizontal longtabular alignment

2018-09-10 Thread Richard Kimberly Heck
On 09/10/2018 07:10 AM, Jürgen Spitzmüller wrote: > This is already in master. > > OK? OK. Riki

[PATCH] [2.3.x] tex2lyx support for horizontal longtabular alignment

2018-09-10 Thread Jürgen Spitzmüller
This is already in master. OK? Jürgen diff --git a/src/tex2lyx/TODO.txt b/src/tex2lyx/TODO.txt index c33b4964b9..fa2bd7aca7 100644 --- a/src/tex2lyx/TODO.txt +++ b/src/tex2lyx/TODO.txt @@ -25,7 +25,6 @@ Format LaTeX featureLyX feature % !BIB program =

Re: Patch for bug in elsarticle.cls

2018-09-06 Thread Rishikesan Nair T
On Thu, Sep 6, 2018 at 1:55 PM, Jürgen Spitzmüller wrote: > Dear colleagues > > Please find attached a patch that fixes an issue in recent elsarticle.cls > (3.0). The problem is that you forgot to check the existence of the > titlefootnote (tnote) label (\X@t) in \tnotem

Re: Patch for bug in elsarticle.cls

2018-09-06 Thread Jürgen Spitzmüller
2018-09-06 10:48 GMT+02:00 Rishikesan Nair T : > Dear Jürgen, > > Thank you for the patch. Next week we will release an updated version to > CTAN. We will include this patch as well. > > thank you > Dear Rishi Excellent. Thanks for the swift reaction! Jürgen

Patch for bug in elsarticle.cls

2018-09-06 Thread Jürgen Spitzmüller
Dear colleagues Please find attached a patch that fixes an issue in recent elsarticle.cls (3.0). The problem is that you forgot to check the existence of the titlefootnote (tnote) label (\X@t) in \tnotemark (as opposed to the other labels in other contexts, where you check with \elsRef

Re: [patch] ditch date-insert

2018-08-20 Thread Jürgen Spitzmüller
Am Sonntag, den 19.08.2018, 16:08 -0400 schrieb Richard Kimberly Heck: > On 08/19/2018 03:14 AM, Jürgen Spitzmüller wrote: > > Am Samstag, den 18.08.2018, 14:26 -0400 schrieb Richard Kimberly > > Heck: > > > Did we also remove, or are you also going to remove, the 'date' > > > external > > >

Re: [patch] ditch date-insert

2018-08-19 Thread Richard Kimberly Heck
On 08/19/2018 03:14 AM, Jürgen Spitzmüller wrote: > Am Samstag, den 18.08.2018, 14:26 -0400 schrieb Richard Kimberly Heck: >> Did we also remove, or are you also going to remove, the 'date' >> external >> template? > Oh, I forgot we also have this. Yes, I propose to remove that as well. > But this

Re: [patch] ditch date-insert

2018-08-19 Thread Jürgen Spitzmüller
Am Samstag, den 18.08.2018, 14:26 -0400 schrieb Richard Kimberly Heck: > Did we also remove, or are you also going to remove, the 'date' > external > template? Oh, I forgot we also have this. Yes, I propose to remove that as well. But this will be a file format change. Jürgen > > Riki >

Re: [patch] ditch date-insert

2018-08-18 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > The attached patch strips date-insert (and the related rc entry and > helper functions) from master. The function is obsoleted by the more > flexible and powerful date info-insets. > > Objections? Good move. Pavel

<    5   6   7   8   9   10   11   12   13   14   >