Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404703 )
Change subject: Hygiene: Remove ExtMobileFrontend::eventLog
..
Hygiene: Remove ExtMobileFrontend::eventLog
Since I25f9e1ca, the method is
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404495 )
Change subject: Drop use of MobileOptionsTracking schema
..
Drop use of MobileOptionsTracking schema
Going forward we can rely on pageview
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/400408 )
Change subject: Revision: Handle all return values of Title::newFromId
..
Revision: Handle all return values of Title::newFromId
In
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398293 )
Change subject: instrumentation: Bump schema revision
..
instrumentation: Bump schema revision
Following on from I6643168a, the client-side
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398116 )
Change subject: Update MobileContext#logMobileMode documentation
..
Update MobileContext#logMobileMode documentation
... with a note to
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394058 )
Change subject: Add npm job for the Chromium render service
..
Add npm job for the Chromium render service
The Chromium render service is
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383831 )
Change subject: gateway/rest: Handle large "small" thumbnails
..
gateway/rest: Handle large "small" thumbnails
NOTE: This is a test case to
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383350 )
Change subject: Register PHPUnit tests via UnitTestsList hook
..
Register PHPUnit tests via UnitTestsList hook
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383347 )
Change subject: Don't request render if renderer not configured
..
Don't request render if renderer not configured
If
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/379532 )
Change subject: subscriber: Wait until browser idle before logging
..
subscriber: Wait until browser idle before logging
If no additional
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378686 )
Change subject: pagePreviews: Stop A/B test on enwiki and dewiki
..
pagePreviews: Stop A/B test on enwiki and dewiki
Changes:
* Remove A/B
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374815 )
Change subject: pagePreviews: Scale A/B test bucket sizes by 10
..
pagePreviews: Scale A/B test bucket sizes by 10
Currently, we're seeing
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373541 )
Change subject: pagePreviews: Bump on/control group size to 25% (BC-only)
..
pagePreviews: Bump on/control group size to 25% (BC-only)
Bug:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373531 )
Change subject: pagePreviews: Re-enable on Beta Cluster
..
pagePreviews: Re-enable on Beta Cluster
I85c3fcfd accidentally disabled Page
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373264 )
Change subject: pagePreviews: Enable A/B test (BC-only)
..
pagePreviews: Enable A/B test (BC-only)
Enable anonymous user bucket on all
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373043 )
Change subject: relatedArticles: Tidy up config
..
relatedArticles: Tidy up config
The sidebar feature has been removed, meaning that
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/372137 )
Change subject: pagePreviews: Deploy to next 100 stage 1 wikis
..
pagePreviews: Deploy to next 100 stage 1 wikis
Note well that the dewiki
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369960 )
Change subject: pagePreviews: Deploy to first 50 of stage 1 wikis
..
pagePreviews: Deploy to first 50 of stage 1 wikis
Add the pp_stage2
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367398 )
Change subject: pagePreviews: Increase i13n sampling rate for ruwiki
..
pagePreviews: Increase i13n sampling rate for ruwiki
Correct the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366882 )
Change subject: pagePreviews: Increase instrumentation sampling rate
..
pagePreviews: Increase instrumentation sampling rate
... for
Hello jenkins-bot, Dereckson,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/366546
to review the following change.
Change subject: Revert "Revert "Stop RelatedArticles A/B test and clean up
config""
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366287 )
Change subject: i13n: popupEnabled = false for disabled event
..
i13n: popupEnabled = false for disabled event
... for consistency with the
Hello Florianschmidtwelzow, jenkins-bot, Jdlrobson,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/365943
to review the following change.
Change subject: Revert "Enable page previews for everyone on labs"
Hello Florianschmidtwelzow, jenkins-bot, Jdlrobson,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/365941
to review the following change.
Change subject: Revert "Log all events for page previews in beta cluster"
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/365939 )
Change subject: pagePreviews: Re-enable Popups extension on Beta Cluster
..
pagePreviews: Re-enable Popups extension on Beta Cluster
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364389 )
Change subject: Don't subscribe EventLogging twice if window.onload fires twice
..
Don't subscribe EventLogging twice if window.onload fires
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364230 )
Change subject: Hygiene: Remove wgMFTidyMobileViewSections
..
Hygiene: Remove wgMFTidyMobileViewSections
wgMFTidyMobileViewSections was
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364188 )
Change subject: WIP
..
WIP
Change-Id: I348079ee80e1d27f9dd70c0340237edc8d0371b0
---
M modules/ext.eventLogging.subscriber.js
1 file
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/362977 )
Change subject: Hygiene: i13n: Return false over not sampling
..
Hygiene: i13n: Return false over not sampling
Previously, if the browser
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/361643 )
Change subject: i13n: Update MobileOptionsTracking schema rev
..
i13n: Update MobileOptionsTracking schema rev
The images property has now
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360165 )
Change subject: Hygiene: SamplingRate -> BucketSize
..
Hygiene: SamplingRate -> BucketSize
In order to avoid further confusion, clarify
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360166 )
Change subject: relatedArticles: SamplingRate -> BucketSize
..
relatedArticles: SamplingRate -> BucketSize
In order to avoid further
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359921 )
Change subject: i13n: Don't sample by pageview
..
i13n: Don't sample by pageview
Currently, the mw.eventLog.Schema class samples per
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359918 )
Change subject: experiments: Extract mediawiki.hash class
..
experiments: Extract mediawiki.hash class
mw.experiments uses a private
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359193 )
Change subject: RelatedArticles no longer depends on Cards
..
RelatedArticles no longer depends on Cards
Since I784fd132, the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359130 )
Change subject: Hygiene: Group instrumentation modules
..
Hygiene: Group instrumentation modules
Following on from I4f653bba, since the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359123 )
Change subject: pagePreviews: Consume HTML from RESTBase endpoint
..
pagePreviews: Consume HTML from RESTBase endpoint
... on the Beta
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358957 )
Change subject: i13n: Log EL events with mw.track
..
i13n: Log EL events with mw.track
Currently, the mw.eventLog.Schema class samples per
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358956 )
Change subject: i13n: Extract experiments module
..
i13n: Extract experiments module
... from the statsvInstrumentation module so that the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358528 )
Change subject: actions/rest: Use DB-key version of title
..
actions/rest: Use DB-key version of title
This reduces the number of 301
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358338 )
Change subject: actions/rest: Use DB-key version of title
..
actions/rest: Use DB-key version of title
This reduces the number of 301
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/357570 )
Change subject: eventLogging: Add missing properties to "tapped settings cog"
event
..
eventLogging: Add missing properties to "tapped
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/357359 )
Change subject: gateway: Fix Accept header sent by rest gateway
..
gateway: Fix Accept header sent by rest gateway
Prior to this change the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355749 )
Change subject: doc: Document reducers/eventLogging module
..
doc: Document reducers/eventLogging module
Bug: T158236
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355646 )
Change subject: eventLogging: Add perceivedWait prop to all events
..
eventLogging: Add perceivedWait prop to all events
... and the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355634 )
Change subject: doc: Document userSettings module
..
doc: Document userSettings module
Bug: T158236
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355607 )
Change subject: doc: Add doc:start script
..
doc: Add doc:start script
Supporting changes:
* Use nodemon@1.11.0.
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355474 )
Change subject: WIP doc: Document gateway modules
..
WIP doc: Document gateway modules
Additional changes:
* Fix the summary not showing up
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355401 )
Change subject: doc: Document statsvInstrumentation module
..
doc: Document statsvInstrumentation module
Bug: T158236
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355397 )
Change subject: mobileFrontend: Move first paragraph before infobox
..
mobileFrontend: Move first paragraph before infobox
Following on
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355199 )
Change subject: doc: Document counts module
..
doc: Document counts module
Bug: T158236
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355200 )
Change subject: doc: Document isEnabled module
..
doc: Document isEnabled module
Bug: T158236
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355145 )
Change subject: docs: Document schema module
..
docs: Document schema module
Bug: T158236
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355144 )
Change subject: doc: Document wait module
..
doc: Document wait module
Bug: T158236
Change-Id: I5bdd3d7bb6fd0eb219b01ae113dc5bc8bdf12d0a
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355143 )
Change subject: doc: Document preview/model module
..
doc: Document preview/model module
Changes:
* Assign exports to exports rather than
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354455 )
Change subject: WIP Make JSDuck Work Again
..
WIP Make JSDuck Work Again
Change-Id: I8da712075dd28f6b228c96fa9577ca39eb148fb5
---
M
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354225 )
Change subject: rl: Break out mobile.mainMenu style module
..
rl: Break out mobile.mainMenu style module
The mobile.mainMenu styles are
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354222 )
Change subject: Hygiene: Break out mobile.messageBox styles module
..
Hygiene: Break out mobile.messageBox styles module
Because the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/353903 )
Change subject: actions: Mix title and namespaceID into LINK_DWELL
..
actions: Mix title and namespaceID into LINK_DWELL
This fixes a bug
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/353058 )
Change subject: eventLogging: Discard events with duplicate tokens
..
eventLogging: Discard events with duplicate tokens
I6a38a261 made the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/353038 )
Change subject: eventLogging: Discard events with duplicate tokens
..
eventLogging: Discard events with duplicate tokens
I6a38a261 made the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/353035 )
Change subject: eventLogging: Discard events with duplicate tokens
..
eventLogging: Discard events with duplicate tokens
I6a38a261 made the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/352870 )
Change subject: WIP eventLogging: Add missing *Hover properties
..
WIP eventLogging: Add missing *Hover properties
Bug: T164256
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/352868 )
Change subject: eventLogging: Round perceivedWait property
..
eventLogging: Round perceivedWait property
The perceivedWait property,
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/351798 )
Change subject: Hygiene: Tidy up QUnit references
..
Hygiene: Tidy up QUnit references
Since Ieea378c9 all QUnit tests are run in Node.js
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/351605 )
Change subject: eventLogging: Add missing perceivedWait property
..
eventLogging: Add missing perceivedWait property
Per the Popups schema
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/351286 )
Change subject: pagePreviews: Create pp_stage0.dblist
..
pagePreviews: Create pp_stage0.dblist
Extract the repeated set of stage 0 wikis
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/351287 )
Change subject: pagePreviews: Deploy to first 50 of stage 1 wikis
..
pagePreviews: Deploy to first 50 of stage 1 wikis
Add the pp_stage2
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350814 )
Change subject: Document removeXMLProcInst line in .svgo.yml
..
Document removeXMLProcInst line in .svgo.yml
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350552 )
Change subject: Remove isLoggingEnabled with Null Object pattern
..
Remove isLoggingEnabled with Null Object pattern
The statsv change
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350395 )
Change subject: Optimise SVGs with svgo
..
Optimise SVGs with svgo
... by running the following:
svgo --disable removeXMLProcInst
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350377 )
Change subject: Reading Web Page Previews alerts
..
Reading Web Page Previews alerts
Use the Nagios Grafana alerts adapter introduced in
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350206 )
Change subject: Track and discard duplicate enqueued events
..
Track and discard duplicate enqueued events
The eventLogging change listener
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349410 )
Change subject: Don't show preview when user abandons link
..
Don't show preview when user abandons link
Bug: T163350
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/349231 )
Change subject: Don't occlude link when preview is above mouse
..
Don't occlude link when preview is above mouse
When the user dwells on a
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348919 )
Change subject: Foo
..
Foo
Change-Id: I1acdfc15237d1d91e144b9fa5933ab6b3cfd9186
---
M tests/node-qunit/actions.test.js
1 file changed, 5
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348789 )
Change subject: reducers: Don't destroy interaction on LINK_CLICK
..
reducers: Don't destroy interaction on LINK_CLICK
I09d8776 introduced
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348790 )
Change subject: actions: Conditionally dispatch ABANDON_*
..
actions: Conditionally dispatch ABANDON_*
If the user CmdOrCtrl+Clicks on a
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348780 )
Change subject: WIP
..
WIP
Bug: T162924
Change-Id: I340dee6881437b254c53b187c15a1adad7769b27
---
M resources/dist/index.js
M
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348321 )
Change subject: reducers: Make LINK_CLICK finalize but not close
..
reducers: Make LINK_CLICK finalize but not close
... the interaction.
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348266 )
Change subject: reducers: Update eventLogging documentation
..
reducers: Update eventLogging documentation
Bug: T159490
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348226 )
Change subject: dist: Bundle assets with webpack@2.4.1
..
dist: Bundle assets with webpack@2.4.1
Change-Id:
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348200 )
Change subject: WIP
..
WIP
Change-Id: If1ee1853ba7a9b2a66b24bb93b4e6062b92b0dba
---
M includes/PopupsHooks.php
1 file changed, 4
Hello Krinkle, Jack Phoenix, jenkins-bot, Jforrester,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/348068
to review the following change.
Change subject: WIP Revert "Upgrade to jQuery v3"
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348058 )
Change subject: WIP
..
WIP
Change-Id: Id5315b67ddd0e6be6cae5176377acda13f8dd9bb
---
M api.php
1 file changed, 1 insertion(+), 1 deletion(-)
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347886 )
Change subject: formatter: Change log channel of infobox message
..
formatter: Change log channel of infobox message
By default, the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347829 )
Change subject: reducers: Make LINK_CLICK finalize interaction
..
reducers: Make LINK_CLICK finalize interaction
... in the eventLogging
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347802 )
Change subject: formatter: Change log level of infobox message
..
formatter: Change log level of infobox message
I61d20ea was only
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347619 )
Change subject: formatter: Change log channel of infobox message
..
formatter: Change log channel of infobox message
By default, the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347598 )
Change subject: actions: Add token to PREVIEW_SHOW
..
actions: Add token to PREVIEW_SHOW
Mirroring all other actions that are dispatched
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347600 )
Change subject: reducers: Make PREVIEW_SHOW require a token
..
reducers: Make PREVIEW_SHOW require a token
Like the FETCH_COMPLETE and
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347599 )
Change subject: Hygiene: DRY up eventLogging reducer
..
Hygiene: DRY up eventLogging reducer
Extract the repeated token testing for the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347291 )
Change subject: pagePreviews: Enable NavPopups gadget detection
..
pagePreviews: Enable NavPopups gadget detection
Note well that the name
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347148 )
Change subject: Remove dependency on es5-shim RL module
..
Remove dependency on es5-shim RL module
Per I95400637, the es5-shim module is
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346981 )
Change subject: Hygiene: Reduce nesting of test cases
..
Hygiene: Reduce nesting of test cases
The ABANDON_START action test cases were
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346979 )
Change subject: reducers: Reduce FETCH_COMPLETE if token matches
..
reducers: Reduce FETCH_COMPLETE if token matches
... instead of using
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346970 )
Change subject: WIP
..
WIP
Change-Id: Ic71dd3ce5e7933273f84a9a64d41e7f3a4cb03f4
---
M resources/dist/index.js
M resources/dist/index.js.map
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346834 )
Change subject: Hygiene: Remove trailing whitespace
..
Hygiene: Remove trailing whitespace
... from tests/node-qunit/actions.test.js.
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346832 )
Change subject: actions: Correctly delay FETCH_COMPLETE
..
actions: Correctly delay FETCH_COMPLETE
I496fe317 caused a regression where the
Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/346830 )
Change subject: actions: Correctly delay FETCH_COMPLETE
..
actions: Correctly delay FETCH_COMPLETE
I496fe317 caused a regression where the
1 - 100 of 708 matches
Mail list logo
