Re: [PATCH 5 of 8 evolve-ext, V2] metaedit: use faster setparents instead of full update

2016-12-20 Thread Pierre-Yves David
@ -1570,8 +1566,11 @@ TODO: don't create a new commit in this 47: foobar2 $ hg diff -r 45 -r 46 --hidden -'fold' one commit +'fold' one commit with dirty wc + $ echo x > newfile $ hg metaedit 39 --fold --user foobar3 1 changesets folded $ hg log -r 48 --temp

Re: [PATCH 8 of 8 evolve-ext, V2] metaedit: make metaedit work nice when new unstable commits are disallowed

2016-12-20 Thread Pierre-Yves David
69f6b2a5@default(draft) add uu (with metaedit) + | + | o 48:2603fdb715ea@default(draft) will cause conflict at evolve + | | + | | o 47:f72774e0c084@default(draft) amended + | | | + | x | 38:f8e30e9317aa@default(draft) will be evolved safely + | | | + | x | 37:36030b147271@default(draft) wil

Re: [PATCH 6 of 8 evolve-ext, V2] metaedit: rewrite rewritemeta to reuse manifests

2016-12-20 Thread Pierre-Yves David
_ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 3 of 3] changegroup: simplify logic around enabling changegroup 03

2016-12-20 Thread Pierre-Yves David
On 12/20/2016 08:35 PM, Augie Fackler wrote: On Mon, Dec 19, 2016 at 07:41:23AM +0100, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1482117918 -3600 # Mon Dec 19 04:25:18 2016 +0100 # Node ID e62c766c60a19d89c4e0e50881701135c251fb6f # Parent

Re: [PATCH RFC] check-commit: add magic string to bypass check-commit

2016-12-21 Thread Pierre-Yves David
+ r".*[(]bc[)]", "(BC) needs to be uppercase"), (beforepatch + r".*[(]issue \d\d\d", @@ -59,6 +60,9 @@ exitcode = 0 printed = node is None hits = [] +if re.search(bypass, commit, re.MULTILINE): +return 0 + for exp, msg in errors:

Re: [PATCH RFC] check-commit: add magic string to bypass check-commit

2016-12-21 Thread Pierre-Yves David
On 12/21/2016 12:36 PM, Pierre-Yves David wrote: On 12/21/2016 05:05 AM, David Soria Parra wrote: # HG changeset patch # User David Soria Parra # Date 1482293000 28800 # Tue Dec 20 20:03:20 2016 -0800 # Node ID ff1014e78d5a3084eda379ec51b1c0a1fc4f5b2a # Parent

Re: [PATCH] tests: exclude bundled pywatchman from check-code test

2016-12-21 Thread Pierre-Yves David
uot;$check_code" --warnings --per-file=0 || false Skipping i18n/polib.py it has no-che?k-code (glob) Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob) Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob) Cheers, -- Pierre-Yves David __

Re: [PATCH 2 of 9] py3: replace os.environ with encoding.environ (part 2 of 5)

2016-12-21 Thread Pierre-Yves David
34:41 2016 +0530 +++ b/tests/test-check-config.t Sun Dec 18 01:46:39 2016 +0530 @@ -7,3 +7,6 @@ $ hg files "set:(**.py or **.txt) - tests/**" | sed 's|\\|/|g' | > python contrib/check-config.py + p = ui.config("pager", "pager", encoding.environ.

Re: [PATCH 2 of 9] py3: replace os.environ with encoding.environ (part 2 of 5)

2016-12-21 Thread Pierre-Yves David
On 12/21/2016 01:03 PM, Pierre-Yves David wrote: On 12/20/2016 03:03 PM, Pulkit Goyal wrote: # HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1482005799 -19800 # Sun Dec 18 01:46:39 2016 +0530 # Node ID c1a8b0e2a088a8cd365f7aa6a3f5d609fc57a92f #

Re: [PATCH 9 of 9] py3: replace sys.platform with pycompat.sysplatform (part 2 of 2)

2016-12-21 Thread Pierre-Yves David
t(None, 1)[0]), @@ -1383,7 +1383,7 @@ def gui(): '''Are we running in a GUI?''' -if sys.platform == 'darwin': +if pycompat.sysplatform == 'darwin': if 'SSH_CONNECTION' in encoding.environ: # handle SSH access to a box where the user is logged in return False ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH STABLE V2] demandimport: do not raise ImportError for unknown item in fromlist

2016-12-21 Thread Pierre-Yves David
raise ImportError for unknown item in fromlist That one is pushed. Thanks for the test clarification. Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial

Re: [PATCH] convert: config option for git rename limit

2016-12-21 Thread Pierre-Yves David
limit By default, Git applies rename and copy detection to 400 files. The diff.renamelimit config option and -l argument to diff commands can override this. Looks reasonable, pushed. Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial

[PATCH 4 of 4] color: load 'colortable' from extension using an 'extraloader'

2016-12-21 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1479489495 -3600 # Fri Nov 18 18:18:15 2016 +0100 # Node ID ea3cd4faf533dcf3323cbb2a11468a30ea065af3 # Parent 764600c7f44086f0d6bbbaf31a668093999190ce # EXP-Topic color color: load 'colortable' from extension using an 'ex

[PATCH 3 of 4] color: move hgext.color._styles to mercurial.color.style

2016-12-21 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1479488976 -3600 # Fri Nov 18 18:09:36 2016 +0100 # Node ID 764600c7f44086f0d6bbbaf31a668093999190ce # Parent a2f55e5d78ca779bd031a5ab6cd32167f4a6ffdf # EXP-Topic color color: move hgext.color._styles to mercurial.color.style This is

[PATCH 2 of 4] color: drop use of the 'global' keyword for '_style'

2016-12-21 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1479490159 -3600 # Fri Nov 18 18:29:19 2016 +0100 # Node ID a2f55e5d78ca779bd031a5ab6cd32167f4a6ffdf # Parent 0038b17608085d0bc611dc7b0c9d1b97a1ea05e4 # EXP-Topic color color: drop use of the 'global' keyword for '_style&

[PATCH 1 of 4] color: drop use of the 'global' keyword for _terminfo_params

2016-12-21 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1479490033 -3600 # Fri Nov 18 18:27:13 2016 +0100 # Node ID 0038b17608085d0bc611dc7b0c9d1b97a1ea05e4 # Parent e1d6aa0e4c3aed73e0dc523b8a8fd5f9fe23510a # EXP-Topic color color: drop use of the 'global' keyword for _terminfo_par

Re: [PATCH RFC] check-commit: add magic string to bypass check-commit

2016-12-21 Thread Pierre-Yves David
On 12/21/2016 10:47 PM, David Soria Parra wrote: -Original Message- From: Pierre-Yves David [mailto:pierre-yves.da...@ens-lyon.org] I would prefer to have that exclusion logic in 'test-check-commit.t', These commit still fails our commit checks, but we skip them from

Re: [PATCH v2] tests: add magic string to bypass check-commit

2016-12-22 Thread Pierre-Yves David
Thanks for tackling that. I don't think the lack of "start of line" will be too much of an issue. If it ever become some we'll improve the check then. Cheers. -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial

Re: [PATCH 2 of 2 v2] fsmonitor: refresh pywatchman to upstream

2016-12-22 Thread Pierre-Yves David
never used tests/filterpyflakes.py:39: undefined name 'undefinedname' ERROR: test-check-pyflakes.t output changed You can also drop the inserted: "no-check-code -- this is a 3rd party library" since David Soria Para already made the whole directory ignored. -- Pie

Re: [PATCH 2 of 2 v2] fsmonitor: refresh pywatchman to upstream

2016-12-22 Thread Pierre-Yves David
or between the file level exclusion and the directory level exclusion. Can you make them consistent and submit a V2 ? (note: that would probably still be a good idea to fix these warning upstream) Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH STABLE] posix: make poll() restart on interruption by signal (issue5452)

2016-12-22 Thread Pierre-Yves David
. Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 2 of 2 v3] fsmonitor: refresh pywatchman to upstream

2016-12-22 Thread Pierre-Yves David
s a minor update to 'test-check-py3-compat.t' as c77452 no longer have the py3 compatibility issues the previous version had. # no-check-commit The refresh includes fixes to improve windows compatibility. # no-check-commit Cheers, -- Pierre-Yves David ___

Re: [PATCH] convert: config option for git rename limit

2016-12-23 Thread Pierre-Yves David
a note in case it was obvious to you. My git version is 2.7.4, if that's relevant here. Thanks, Danek Should we drop that patch in the mean time ? Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercuria

Re: [PATCH] tests: make test-convert-git.t reproducible

2016-12-24 Thread Pierre-Yves David
y0 + copy-source + A source-copy1 +copy-source test binary conversion (issue1359) $ count=19 -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 1 of 5 flagprocessor v6] documentation: better censor flag documentation

2016-12-24 Thread Pierre-Yves David
log. 12-15 (4 bytes) ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mer

Re: [PATCH 1 of 5 flagprocessor v6] documentation: better censor flag documentation

2016-12-24 Thread Pierre-Yves David
first one. (test-check-commit.t says hi) I'll review the rest later. On Sat, 24 Dec 2016 at 13:31 Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 12/24/2016 05:36 PM, Remi Chaintron wrote: > # HG changeset patch > # User Remi Chaintron mailto

Re: [PATCH 01 of 10] check-code: add AST check for mutable default argument values

2016-12-27 Thread Pierre-Yves David
est-hg-parseurl.py:7: + > def testparse(url, branch=[]): + mutable default argument value (list) + tests/test-trusted.py:175: + > def assertraises(f, exc=error.Abort): + attribute default argument value may be mutable [1] @commands in debugcommands.py should be in alphabetical order

Re: [PATCH 02 of 10] config: don't use mutable default argument value

2016-12-27 Thread Pierre-Yves David
h(self, pats=[], include=None, exclude=None, default='glob', mutable default argument value (list) mercurial/context.py:1498: Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.

Re: [PATCH 03 of 10] context: don't use mutable default argument value

2016-12-27 Thread Pierre-Yves David
ncoding.py:54: _______ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 05 of 10] hgweb: don't use mutable default argument value

2016-12-27 Thread Pierre-Yves David
ercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/list

Re: [PATCH 04 of 10] filemerge: don't use mutable default argument value

2016-12-27 Thread Pierre-Yves David
vel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 08 of 10] util: don't use mutable default argument value

2016-12-27 Thread Pierre-Yves David
g https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 06 of 10] hgweb: don't use default mutable argument value

2016-12-27 Thread Pierre-Yves David
ercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/list

Re: [PATCH 09 of 10] mq: don't use mutable default argument value

2016-12-27 Thread Pierre-Yves David
@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 07 of 10] match: don't use mutable default argument value

2016-12-27 Thread Pierre-Yves David
x27;HGMODULEPOLICY', policy) use encoding.environ instead (py3) Skipping mercurial/statprof.py it has no-che?k-code (glob) ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-dev

Re: [PATCH] match: adding non-recursive directory matching

2016-12-27 Thread Pierre-Yves David
arious patterns use it basic, easily recognizable cases. We poked at updating the code to have basic regexp matching a subtree recognized as such and that was quite easy. Rodrigo, does that match your current understanding of the situation? Cheers, -- Pierre-Yves David

Re: Constant naming convention

2016-12-28 Thread Pierre-Yves David
On 12/15/2016 11:38 PM, Augie Fackler wrote: (I’m trying to be brief here - hopefully it doesn’t come across as upset, because I’m not - mostly I was blindsided by a policy claim that I don’t remember.) On Dec 15, 2016, at 3:40 PM, Pierre-Yves David wrote: So, to sum up, my stance is

Re: [PATCH 1 of 5 flagprocessor v6] documentation: better censor flag documentation

2016-12-28 Thread Pierre-Yves David
On 12/24/2016 08:48 PM, Augie Fackler wrote: On Sat, Dec 24, 2016 at 07:30:57PM +0100, Pierre-Yves David wrote: On 12/24/2016 05:36 PM, Remi Chaintron wrote: # HG changeset patch # User Remi Chaintron # Date 1482451718 18000 # Thu Dec 22 19:08:38 2016 -0500 # Node ID

Re: [PATCH 1 of 7] py3: have bytes version of os.getenv

2016-12-28 Thread Pierre-Yves David
etenvb() does not exist on Windows. I'd rather replace getenv() with environ.get() and ban the use of os.getenv() and .setenv(). So, that patch seems broken on windows, should we drop it? Cheers -- Pierre-Yves David ___ Mercurial-devel mailing lis

[PATCH] Makefile: drop old deployment rules

2016-12-30 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1483091528 -3600 # Fri Dec 30 10:52:08 2016 +0100 # Node ID 7dc955330c55b8cea601edd9e3d77a1b40883b05 # Parent ef6da0fd2a0cdfbc59503c7a3c221efe59f7e609 Makefile: drop old deployment rules We use a different machine now and the process on

Re: [PATCH 1 of 5 flagprocessor v6] documentation: better censor flag documentation

2016-12-30 Thread Pierre-Yves David
On 12/28/2016 05:25 PM, Augie Fackler wrote: (bcc adgar in case he can provide insight, but I don’t know if he remembers or if he’s on vacation this/next week at all) On Dec 28, 2016, at 11:20 AM, Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: diff --git a/mercuria

Re: [PATCH 3 of 5 flagprocessor v6] revlog: pass revlog flags to addrevision

2016-12-30 Thread Pierre-Yves David
flags, cachedelta, ifh, dfh, raw=False) finally: if dfh: dfh.close() ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-deve

Re: [PATCH 2 of 5 flagprocessor v6] revlog: add 'raw' argument to revision and _addrevision

2016-12-30 Thread Pierre-Yves David
ionrepo.py b/mercurial/unionrepo.py --- a/mercurial/unionrepo.py +++ b/mercurial/unionrepo.py @@ -93,7 +93,7 @@ return mdiff.textdiff(self.revision(self.node(rev1)), self.revision(self.node(rev2))) -def revision(self, nodeorrev): +def revision(self, nodeorrev, raw=False): """return an uncompressed revision of a given node or revision number. """ Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] Makefile: drop old deployment rules

2016-12-30 Thread Pierre-Yves David
That should be flagged 'website', but I messed up. On 12/30/2016 10:55 AM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1483091528 -3600 # Fri Dec 30 10:52:08 2016 +0100 # Node ID 7dc955330c55b8cea601edd9e3d77a1b40883b0

Re: [PATCH 2 of 5 flagprocessor v6] revlog: add 'raw' argument to revision and _addrevision

2016-12-30 Thread Pierre-Yves David
cture more self-documenting? I legitimately don’t see why the parameter version is preferable design-wise. What about you check the IRC log so that remi and I can focus on getting this things out? The log are still warm and fresh. Cheers, -- Pierre-Yves

Re: [PATCH 3 of 5 flagprocessor v6] revlog: pass revlog flags to addrevision

2016-12-31 Thread Pierre-Yves David
entangled with the one we would backout. Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 4 of 5 flagprocessor v6] revlog: processflags()

2017-01-02 Thread Pierre-Yves David
ight the apparent full overlap between "write processing" and "write raw processing". The above is a bit hairy, so I would not be surprise one got out of it confused but here is a couple of shorter "conclusion" - if actual transform are applied in _addrevision, t

Re: [PATCH 1 of 5 shelve-ext] shelve: move temporary commit creation to a separate function

2017-01-03 Thread Pierre-Yves David
of ui.quiet to separate functions. It's unclear that we have to care about the state of ui.quiet when adding some code to _dounshelve(). So IMO, each function should restore ui.quiet at the end. I don't think this followup ever happen (but having a quick look at the code. What is t

Re: [PATCH evolve-ext] fold: disallow multiple revisions without --exact

2017-01-04 Thread Pierre-Yves David
On 12/18/2016 06:36 PM, Martin von Zweigbergk via Mercurial-devel wrote: On Fri, Dec 16, 2016, 23:53 Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 11/05/2016 12:58 AM, Martin von Zweigbergk via Mercurial-devel wrote: > # HG changeset patch > #

Re: [PATCH 01 of 10] check-code: add AST check for mutable default argument values

2017-01-04 Thread Pierre-Yves David
On 12/28/2016 06:43 PM, Augie Fackler wrote: On Dec 27, 2016, at 4:57 AM, Pierre-Yves David wrote: This patch introduces a check-code check for the sanity of default argument values. It does so by parsing and walking the AST. Previously, all check-code checks were implemented as regular

Re: [PATCH 01 of 10] check-code: add AST check for mutable default argument values

2017-01-04 Thread Pierre-Yves David
se(url, branch=[]): + mutable default argument value (list) + tests/test-trusted.py:175: + > def assertraises(f, exc=error.Abort): + attribute default argument value may be mutable [1] @commands in debugcommands.py should be in alphabetical order. ________

Re: [PATCH] hgweb: link to raw-file on annotation page (BC)

2017-01-04 Thread Pierre-Yves David
ght.t +++ b/tests/test-highlight.t @@ -235,9 +235,9 @@ hgweb fileannotate, html diff comparison annotate file log - raw + raw help ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.

Re: [PATCH] cmdutil: add special string that ignores rest of text

2017-01-04 Thread Pierre-Yves David
text, flags=re.MULTILINE) +if stripbelow: +editortext = editortext[:stripbelow.start()] + text = re.sub("(?m)^HG:.*(\n|$)", "", editortext) os.chdir(olddir) if finishdesc: text = finishdesc(text) Cheers, -- Pierre-Yves David ___

Re: [PATCH] rebase: fail-fast pull if working dir is not clean

2017-01-04 Thread Pierre-Yves David
revsprepull = len(repo) origpostincoming = commands.postincoming def _dummy(*args, **kwargs): -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 3 of 5 V4] templates-default: factor out definition of changeset labels

2017-01-04 Thread Pierre-Yves David
t.{phase}", +fullcset = '{label("{_cset_labels}", "changeset: {rev}:{node}")}\n' parent = '{label("log.parent changeset.{phase}", ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.o

Re: [PATCH 4 of 5 V4] templates: display evolution "troubles" in command line style

2017-01-04 Thread Pierre-Yves David
3w_3_c 4:94b33453f93b (draft) [ ] add original_d - 5:cda648ca50f5 (draft) [tip ] add original_e + 5:cda648ca50f5 (draft unstable) [tip ] add original_e $ hg push ../tmpf -f # -f because be push unstable too pushing to ../tmpf searching for changes @@ -548,7 +548,7 @@ no warning displaye

Re: [PATCH 1 of 7 flagprocessor v7] documentation: better censor flag documentation

2017-01-04 Thread Pierre-Yves David
data. 8-11 (4 bytes) Compressed length of revision data / chunk as stored in revlog. 12-15 (4 bytes) ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 01 of 10] check-code: add AST check for mutable default argument values

2017-01-04 Thread Pierre-Yves David
On 01/04/2017 04:59 PM, Augie Fackler wrote: On Jan 4, 2017, at 10:14 AM, Pierre-Yves David wrote: Can you have a look in that other tools and tell us what you find? I know pylint can do this, but configuring pylint is a bit fussy. I scanned quickly through the pylint help and got

Re: [PATCH 2 of 2] repair: combine two loops over changelog revisions

2017-01-04 Thread Pierre-Yves David
d(r) saveheads.difference_update(cl.parentrevs(r)) ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-de

Re: [PATCH evolve-ext] fold: disallow multiple revisions without --exact

2017-01-04 Thread Pierre-Yves David
On 01/04/2017 05:38 PM, Martin von Zweigbergk wrote: On Wed, Jan 4, 2017 at 4:53 AM, Pierre-Yves David wrote: On 12/18/2016 06:36 PM, Martin von Zweigbergk via Mercurial-devel wrote: On Fri, Dec 16, 2016, 23:53 Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote:

Re: [PATCH V2] setup: pass named argument to setup_zstd

2017-01-05 Thread Pierre-Yves David
Pushed, thanks. -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH V2] hgweb: add missing slash to file log url in rss style

2017-01-05 Thread Pierre-Yves David
confirm=True -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH V2] hgweb: add missing slash to file log url in rss style

2017-01-05 Thread Pierre-Yves David
confirm [patchbomb] confirm=True works and actually does ask to confirm. Which means the suggested patchbomb config in ContributingChanges page is misleading currently. Good catch, I've fixed it. -- Pierre-Yves David ___ Mercurial-devel mailing

Re: [PATCH 4 of 5 V4] templates: display evolution "troubles" in command line style

2017-01-05 Thread Pierre-Yves David
On 01/05/2017 04:16 PM, Yuya Nishihara wrote: On Wed, 4 Jan 2017 17:23:52 +0100, Pierre-Yves David wrote: On 01/03/2017 01:54 PM, Denis Laxalde wrote: # HG changeset patch # User Denis Laxalde # Date 1478597306 -3600 # Tue Nov 08 10:28:26 2016 +0100 # Node ID

Re: [PATCH 2 of 5 V4] cmdutil: add support for evolution "troubles" display in changeset_printer

2017-01-05 Thread Pierre-Yves David
ed(): +self.ui.write(_("trouble: %s\n") % ', '.join(ctx.troubles()), + label='ui.note log.trouble') A small nit: please copy-paste the '# i18n: column positioning for "hg log"' comment so translato

Re: [PATCH 3 of 3 V2] summary: add evolution "troubles" information to parents header lines

2017-01-05 Thread Pierre-Yves David
On 01/05/2017 08:29 PM, Sean Farley wrote: Denis Laxalde writes: Pierre-Yves David a écrit : On 11/08/2016 03:19 PM, Denis Laxalde wrote: # HG changeset patch # User Denis Laxalde # Date 1475935828 -7200 # Sat Oct 08 16:10:28 2016 +0200 # Node ID

Re: [PATCH 2 of 2 V2] config: add docs for ignoring all text below in the editor

2017-01-05 Thread Pierre-Yves David
Sean via IRC. Many thanks. nb_unfixed_recurrent_topic -= 1 marmoute.bonus_point["smf"] += 1 Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] make: remove targets for building packages for ubuntu wily (end of life)

2017-01-05 Thread Pierre-Yves David
packages for ubuntu wily (end of life) Pushed, thanks. Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 2 of 2] repair: combine two loops over changelog revisions

2017-01-05 Thread Pierre-Yves David
On 01/04/2017 08:09 PM, Martin von Zweigbergk via Mercurial-devel wrote: On Wed, Jan 4, 2017 at 11:06 AM, Pierre-Yves David wrote: On 01/04/2017 07:52 PM, Martin von Zweigbergk via Mercurial-devel wrote: # HG changeset patch # User Martin von Zweigbergk # Date 1483554904 28800

Re: [PATCH RFC] patch: add index line for diff output

2017-01-05 Thread Pierre-Yves David
7;.join(header) + '\n' ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH V3] rebase: fail-fast the pull if working dir is not clean (BC)

2017-01-05 Thread Pierre-Yves David
now That seems a bit too hacky. Can we change this to having an actual interrupted operation going on ? + $ hg pull --rebase + abort: rebase in progress + (use 'hg rebase --continue' or 'hg rebase --abort') + [255] + $ rm .hg/rebasestate In

Re: [PATCH evolve-ext] tests: fix tests to reflect hg core changes

2017-01-05 Thread Pierre-Yves David
curial-3.x (eg: mercurial-3.4) branch that descend from evolve stable branch and contains test update to match the version. Cheers -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailma

Re: [PATCH] hgweb: link to raw-file on annotation page (BC)

2017-01-06 Thread Pierre-Yves David
On 01/04/2017 07:06 PM, Gregory Szorc wrote: On Jan 4, 2017, at 07:37, Pierre-Yves David wrote: On 12/28/2016 11:53 PM, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1482965297 25200 # Wed Dec 28 15:48:17 2016 -0700 # Node ID

Re: [PATCH] rebase: replace stray call of 'os.path.exists' with repo.vfs.exists at 'hg summary' hook

2017-01-06 Thread Pierre-Yves David
'os.path.exists' with repo.vfs.exists at 'hg summary' hook I've pushed this, our commit checker was complaining about the summary lenght, I've updated it to: rebase: use repo.vfs.exists in 'hg summary' hook Thanks, -- Pierre-Yves David _

Re: [PATCH 1 of 3 V4] rebase: fail-fast the pull if working dir is not clean (BC)

2017-01-06 Thread Pierre-Yves David
rcurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH evolve-ext] fold: disallow multiple revisions without --exact

2017-01-06 Thread Pierre-Yves David
On 01/04/2017 10:47 PM, Martin von Zweigbergk wrote: On Wed, Jan 4, 2017 at 11:40 AM, Pierre-Yves David wrote: On 01/04/2017 05:38 PM, Martin von Zweigbergk wrote: On Wed, Jan 4, 2017 at 4:53 AM, Pierre-Yves David wrote: On 12/18/2016 06:36 PM, Martin von Zweigbergk via Mercurial-devel

Re: [PATCH V3] rebase: fail-fast the pull if working dir is not clean (BC)

2017-01-06 Thread Pierre-Yves David
nce of state-file in .hg/ dir]... Testing normal user flow seems a better idea than testing implementation details. I can think of simpler way to check for unfinished state. For example a small histedit session (using edit) can create such condition

Re: [PATCH 6 of 6 V5] summary: add evolution "troubles" information to summary output

2017-01-06 Thread Pierre-Yves David
evolution "troubles" information to summary output That series seems fine and is pushed. Thanks for the various fixes/cleanup. -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.o

Re: [PATCH] revset: introduce the summary predicate

2017-01-06 Thread Pierre-Yves David
summary: commit-foo-subdir + + changeset: 1:95b38e3a5b2e + user:test + date:Thu Jan 01 00:00:00 1970 + + summary: commit-foo-dot + subdir log $ cd foo $ hg log . + changeset: 2:5364ddbe8265 + tag: tip + user:

Re: [PATCH] run-tests: unset CHGDEBUG

2017-01-06 Thread Pierre-Yves David
it(): if k in env: del env[k] ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercuria

Re: [PATCH 2 of 5 flagprocessor v6] revlog: add 'raw' argument to revision and _addrevision

2017-01-07 Thread Pierre-Yves David
On 12/30/2016 08:46 PM, Augie Fackler wrote: On Dec 30, 2016 12:30, "Pierre-Yves David" wrote: On 12/30/2016 06:09 PM, Augie Fackler wrote: On Dec 30, 2016, at 12:04 PM, Rémi Chaintron wrote: Following discussion with marmoute on IRC, I'll drop the rawrevision()

Re: [PATCH] revset: introduce the summary predicate

2017-01-08 Thread Pierre-Yves David
On 01/07/2017 08:56 AM, Yuya Nishihara wrote: On Fri, 6 Jan 2017 21:29:43 -0500, Matt Harbison wrote: On Jan 6, 2017, at 11:19 AM, Pierre-Yves David wrote: On 01/04/2017 07:04 PM, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1483550016 18000 # Wed Jan 04 12

Re: [PATCH] revset: introduce the summary predicate

2017-01-08 Thread Pierre-Yves David
2017 02:56:48 -0500, Yuya Nishihara wrote: On Fri, 6 Jan 2017 21:29:43 -0500, Matt Harbison wrote: > On Jan 6, 2017, at 11:19 AM, Pierre-Yves David wrote: >> On 01/04/2017 07:04 PM, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 14835

Re: [PATCH V5] rebase: fail-fast the pull if working dir is not clean (BC)

2017-01-08 Thread Pierre-Yves David
tests, we create a 'histedit' session to verify that also an unfinished state is detected and handled. If I've followed the discussion so far, this patch seems to address all of Pierre-Yves' comments, so I think it's good to go. Marking as pre-reviewed. Yep, that one

Re: Picking a date for Mercurial 4.2 sprint (California, February-March)

2017-01-08 Thread Pierre-Yves David
y of the sprint dates. So I'll let him jump in and clarify his preference (CCed him to make sure he sees that). Let us aims are putting a final stamp one sprint date by Tuesday January 10th. What do you think? Cheers, -- Pierre-Yves David PS: sprint page: http

Re: [PATCH] zstd: fix compilation with Solaris Studio

2017-01-09 Thread Pierre-Yves David
ntinuous integration build (or even default build) with that option to catch such errors earlier? Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH V3] rebase: fail-fast the pull if working dir is not clean (BC)

2017-01-09 Thread Pierre-Yves David
e to provide more context ;-) So +1 for improving these too (but as mentioned in my initial reply, that's a scope bloat so I too the debug version for now). (third paragraph of https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-January/092041.html ) Cheers, -- Pierre-Yves Dav

Re: [PATCH] revset: introduce the summary predicate

2017-01-09 Thread Pierre-Yves David
On 01/08/2017 09:34 PM, Matt Harbison wrote: On Sun, 08 Jan 2017 07:59:36 -0500, Pierre-Yves David wrote: (ha, I wrote my previous reply in a train and it got sent when I connected again (and received that one). I'm going to try to adress the new content in this email and sometime r

Re: [PATCH 1 of 4 flagprocessor v8] revlog: add 'raw' argument to revision and _addrevision

2017-01-09 Thread Pierre-Yves David
if addrevisioncb: addrevisioncb(self, chain) […] -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 3 of 4 flagprocessor v8] revlog: flag processor

2017-01-09 Thread Pierre-Yves David
o-eol) (esc) + + $ hg cat -r . nop-base64 + [NOP][BASE64] + $ hg debugdata nop-base64 0 + W05PUF1bQkFTRTY0XQo= (no-eol) + + $ hg cat -r . nop-gzip + [NOP][GZIP] + $ hg debugdata nop-gzip 0 + x\x9c\x8b\xf6\xf3\x0f\x88\x8dv\x8f\xf2\x0c\x88\xe5\x02\x

Re: [LAST CALL] Picking a date for Mercurial 4.2 sprint (California, February-March)

2017-01-09 Thread Pierre-Yves David
On 01/08/2017 09:45 PM, Gregory Szorc wrote: On Sun, Jan 8, 2017 at 10:01 AM, Martin von Zweigbergk mailto:martinv...@google.com>> wrote: On Sun, Jan 8, 2017, 05:19 Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 01/06/2017 08:46 PM

Re: [PATCH 3 of 4 flagprocessor v9] revlog: flag processor

2017-01-10 Thread Pierre-Yves David
lagprocess for the censors flag (since for none of the censor handling is using the new API). Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: Constant naming convention

2017-01-10 Thread Pierre-Yves David
been putting the card before the hoax here. On Dec 28, 2016, at 10:17, Pierre-Yves David wrote: On 12/15/2016 11:38 PM, Augie Fackler wrote: (I’m trying to be brief here - hopefully it doesn’t come across as upset, because I’m not - mostly I was blindsided by a policy claim that I don’t

Re: [PATCH RFC] crecord: make an option for space key to move cursor down (issue5159) (RFC)

2017-01-10 Thread Pierre-Yves David
___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 04 of 11] httppeer: use compression engine API for decompressing responses

2017-01-10 Thread Pierre-Yves David
be wrong) should we create a ticket to track it? Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 3 of 3 4bf0d7 flagprocessor v10] revlog: REVIDX_EXTSTORED flag

2017-01-10 Thread Pierre-Yves David
_KNOWN_FLAGS = util.bitsfrom(REVIDX_FLAGS_ORDER) ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel

Re: [PATCH 7 of 8] chg: remove getpager support

2017-01-10 Thread Pierre-Yves David
et? could have reordered or folded this patch to avoid being temporarily broken? Cheers, -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 4 of 4 flagprocessor v11] revlog: REVIDX_EXTSTORED flag

2017-01-10 Thread Pierre-Yves David
is pushed with a small inflight fix to appease test-check-commit.t. Thanks, (I'm not a fan of that bitsfrom function added to utils since it only has one caller but lets move forward) Cheers -- Pierre-Yves David ___ Mercurial-devel mailing

Re: [PATCH 04 of 11] httppeer: use compression engine API for decompressing responses

2017-01-10 Thread Pierre-Yves David
On 01/10/2017 07:37 PM, Gregory Szorc wrote: On Tue, Jan 10, 2017 at 8:56 AM, Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 11/26/2016 11:19 AM, Yuya Nishihara wrote: On Sun, 20 Nov 2016 14:23:41 -0800, Gregory Szorc wrote: # HG cha

Re: Constant naming convention

2017-01-10 Thread Pierre-Yves David
On 01/10/2017 06:29 PM, Martin von Zweigbergk wrote: On Tue, Jan 10, 2017 at 7:42 AM, Pierre-Yves David wrote: […] So, I went to gather basic data about the actual situation. I used basic grepping of assignment without any indentation in mercurial/ and hgext/ pythons file. This isn't pe

<    2   3   4   5   6   7   8   9   10   11   >