[Mesa-dev] [PATCH 1/5] radeon/r200: fix bogus assert/scissor wrt width/height 2048

2012-07-26 Thread Roland Scheidegger
This addresses one issue raised in bug #51658 discovered by Eugene St Leger. The assert is bogus since there's no problem with texture width/height being 2048 (the width/height programmed is width/height minus one). OTOH though the programmed size for scissor rect should be width/height minus one t

[Mesa-dev] [PATCH 5/5] r200: get rid of dubious aux scissor bits

2012-07-26 Thread Roland Scheidegger
no point in emitting aux scissor values if we a) never enable them b) never set the actual values plus it is enough to have that aux scissor enable reg (which we never set to enable) in one place not two. --- src/mesa/drivers/dri/r200/r200_context.h| 35 +++--- src/mesa/

[Mesa-dev] [PATCH 3/5] r200: get rid of old gart memory functions from old dri1

2012-07-26 Thread Roland Scheidegger
Those functions are SO dead. --- src/mesa/drivers/dri/r200/r200_ioctl.c | 26 -- src/mesa/drivers/dri/r200/r200_ioctl.h |6 -- 2 files changed, 0 insertions(+), 32 deletions(-) diff --git a/src/mesa/drivers/dri/r200/r200_ioctl.c b/src/mesa/drivers/dri/r200/r200_

Re: [Mesa-dev] Mesa 8.0 branch maintenance

2012-07-26 Thread Jakob Bornecrantz
- Original Message - > We've been really crappy about keeping up on stable releases. The > biggest problem has been bug fixes sitting on master never getting > cherry picked over. Release time comes along, and either I cherry > pick 57 patches over the day before the release or Jakob send

[Mesa-dev] [PATCH 4/5] radeon/r200: get rid of some unneeded cliprect/scissor code

2012-07-26 Thread Roland Scheidegger
Noone was interested in the number of cliprects, and noone cared about the intersect result neither. So just nuke this. --- src/mesa/drivers/dri/radeon/radeon_common.c| 56 +-- src/mesa/drivers/dri/radeon/radeon_common.h|1 - .../drivers/dri/radeon/radeon_comm

[Mesa-dev] [PATCH 2/5] radeon/r200: fix bogus clears

2012-07-26 Thread Roland Scheidegger
There were several problems with these functions (which are a remnant of dri1 hyperz mostly - should bring it back somehow someday). First, it would always do a swrast clear if the buffer to clear was a fbo. Second, for buffers we wouldn't handle the clear (I guess aux/accum?) we would actually sti

[Mesa-dev] some radeon/r200 cleanup/fixes

2012-07-26 Thread Roland Scheidegger
This patches are just some cleanups and fixes however only compile tested (my r100 got broken and the r200 isn't in a useful box right now) so testers would be great. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/m

[Mesa-dev] [Bug 38970] [bisected]piglit glx/glx-pixmap-multi failed

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38970 Gordon Jin changed: What|Removed |Added AssignedTo|xunx.f...@intel.com |i...@freedesktop.org -- Configure bugmail:

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #42 from Barto 2012-07-27 01:40:32 PDT --- (In reply to comment #40) > > --- a/src/mesa/drivers/common/meta.c > +++ b/src/mesa/drivers/common/meta.c > @@ -2280,8 +2280,7 @@ _mesa_meta_DrawPixels(struct gl_context *ctx, > * Det

[Mesa-dev] Mesa 8.0 branch maintenance

2012-07-26 Thread Ian Romanick
We've been really crappy about keeping up on stable releases. The biggest problem has been bug fixes sitting on master never getting cherry picked over. Release time comes along, and either I cherry pick 57 patches over the day before the release or Jakob sends out an email with a similar lis

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #41 from Barto 2012-07-27 01:21:23 PDT --- (In reply to comment #39) > Try setting a breakpoint on radeonSpanRenderStart() and get some stack traces > when gdb stops there. Maybe set the breakpoint after the splash screen/window > g

Re: [Mesa-dev] [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor.

2012-07-26 Thread Jordan Justen
On Thu, Jul 26, 2012 at 5:27 PM, Eric Anholt wrote: > As we get into supporting GL 3.x core, we come across more and more features > of the API that depend on the version number as opposed to just the extension > list. This will let us more sanely do version checks than "(VersionMajor == 3 > && V

Re: [Mesa-dev] [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor.

2012-07-26 Thread Brian Paul
On Thu, Jul 26, 2012 at 6:27 PM, Eric Anholt wrote: > As we get into supporting GL 3.x core, we come across more and more features > of the API that depend on the version number as opposed to just the extension > list. This will let us more sanely do version checks than "(VersionMajor == 3 > && V

Re: [Mesa-dev] [PATCH 15/15] intel: Advertise multisample DRI2 configs on gen >= 6

2012-07-26 Thread Chad Versace
On 07/23/2012 01:45 PM, Ian Romanick wrote: > On 07/21/2012 05:36 PM, Chad Versace wrote: >> This turns on window system multisampling. >> >> No Piglit regressions on Ivybridge. >> >> Tested with `glxgears -samples 1`. >> >> Passes 53/70 of oglconform's winsys multisample tests. The failing tests >

Re: [Mesa-dev] [PATCH 14/15] intel: Refactor intel_screen_make_configs

2012-07-26 Thread Chad Versace
On 07/25/2012 11:11 AM, Eric Anholt wrote: > Chad Versace writes: > >> Transform the code from clever, obfuscated, and imperative to >> straight-forward and table-driven. > > I don't like this change. It increases the amount of code, and to > change any single option, you need to change more co

Re: [Mesa-dev] [PATCH 14/15] intel: Refactor intel_screen_make_configs

2012-07-26 Thread Chad Versace
On 07/23/2012 01:35 PM, Ian Romanick wrote: > On 07/21/2012 05:36 PM, Chad Versace wrote: >> Transform the code from clever, obfuscated, and imperative to >> straight-forward and table-driven. > > Does the output of glxinfo change? It's somewhat advantageous for the IDs > associated with a specif

Re: [Mesa-dev] [PATCH 11/15] intel: Downsample during glReadPixels

2012-07-26 Thread Chad Versace
On 07/23/2012 03:49 PM, Paul Berry wrote: > On 21 July 2012 17:36, Chad Versace > wrote: > > Actually, this patch forces an automatic downsample during > intel_miptree_map. And this should occur only due to glReadPixels. > > CC: Eric Anholt mailt

Re: [Mesa-dev] [PATCH] intel: Set num samples for winsys renderbuffers (v3)

2012-07-26 Thread Eric Anholt
Chad Versace writes: > Add a new param, num_samples, to intel_create_renderbuffer and > intel_create_private_renderbuffer. > > No multisample GL config is yet advertised, so the value of num_samples is > currently 0. For server-owned winsys buffers, gl_renderbuffer::NumSamples > is not yet used.

[Mesa-dev] [PATCH 4/4] mesa: Expose texture buffer objects when the context is GL 3.1 core.

2012-07-26 Thread Eric Anholt
--- src/mesa/main/bufferobj.c |3 ++- src/mesa/main/get.c | 16 +++- src/mesa/main/teximage.c |6 -- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index ad28f8a..dbdc3f1 100644 --- a/src/mesa/m

[Mesa-dev] [PATCH 3/4] mesa: Only change version in compute_version() if it's better.

2012-07-26 Thread Eric Anholt
This should allow a driver to assert support for a version of the API without supporting parts of component extensions that didn't get rolled into core. --- src/mesa/main/version.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/version.c b/src/mesa/main/

[Mesa-dev] [PATCH 2/4] mesa: Switch a bunch of VersionMajor/VersionMinor checks to Version.

2012-07-26 Thread Eric Anholt
--- src/mesa/drivers/dri/intel/intel_screen.c |4 +--- src/mesa/drivers/dri/nouveau/nouveau_context.c |4 +--- src/mesa/drivers/dri/r200/r200_context.c |4 +--- src/mesa/drivers/dri/radeon/radeon_context.c |4 +--- src/mesa/main/enable.c |4

[Mesa-dev] [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor.

2012-07-26 Thread Eric Anholt
As we get into supporting GL 3.x core, we come across more and more features of the API that depend on the version number as opposed to just the extension list. This will let us more sanely do version checks than "(VersionMajor == 3 && VersionMinor >= 2) || VersionMajor >= 4". --- src/mesa/main/m

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #40 from Roland Scheidegger 2012-07-27 00:24:19 UTC --- I was actually wondering, do we really need the fallback when there's PixelTransfer state? Clearly this applies to DrawPixels, but doesn't this also apply to TexImage() calls he

Re: [Mesa-dev] [PATCH 2/2] mesa: Support glGetString(GL_SHADING_LANGUAGE_VERSION) for >= 1.40.

2012-07-26 Thread Eric Anholt
Kenneth Graunke writes: > This will need to get refactored when we add support for core profiles > or forward-compatible contexts, but we may as well have it in the > meantime. This allows us to override the GLSL version and experiment. also r-b. pgpH9kquAd4CI.pgp Description: PGP signature _

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #39 from Brian Paul 2012-07-26 23:39:26 PDT --- Try setting a breakpoint on radeonSpanRenderStart() and get some stack traces when gdb stops there. Maybe set the breakpoint after the splash screen/window goes away because it's sure

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Marek Olšák
Ah, I see. Thank you for the clarification. Marek On Fri, Jul 27, 2012 at 12:29 AM, Eric Anholt wrote: > Marek Olšák writes: > >> Michel Dänzer told me on IRC that setting CFLAGS overrode all flags, >> while OPT_FLAGS was only appended to existing CFLAGS, which is the >> reason I have been usin

Re: [Mesa-dev] [PATCH] intel: Set num samples for winsys renderbuffers (v3)

2012-07-26 Thread Kenneth Graunke
On 07/26/2012 01:39 PM, Chad Versace wrote: > Add a new param, num_samples, to intel_create_renderbuffer and > intel_create_private_renderbuffer. > > No multisample GL config is yet advertised, so the value of num_samples is > currently 0. For server-owned winsys buffers, gl_renderbuffer::NumSamp

Re: [Mesa-dev] [PATCH 1/2] glsl: Refactor #version validation to be more future-proof.

2012-07-26 Thread Eric Anholt
Kenneth Graunke writes: > The previous implementation required a flag in _mesa_glsl_parse_state > and line of code to initialize it for every version of the shading > language we intend to support. As we look to add 150, 330, 400, 410, > 420, and beyond, this gets rather unwieldy. > > This patch

[Mesa-dev] [PATCH 2/2] mesa: Support glGetString(GL_SHADING_LANGUAGE_VERSION) for >= 1.40.

2012-07-26 Thread Kenneth Graunke
This will need to get refactored when we add support for core profiles or forward-compatible contexts, but we may as well have it in the meantime. This allows us to override the GLSL version and experiment. Signed-off-by: Kenneth Graunke --- src/mesa/main/getstring.c | 10 ++ 1 file cha

[Mesa-dev] [PATCH 1/2] glsl: Refactor #version validation to be more future-proof.

2012-07-26 Thread Kenneth Graunke
The previous implementation required a flag in _mesa_glsl_parse_state and line of code to initialize it for every version of the shading language we intend to support. As we look to add 150, 330, 400, 410, 420, and beyond, this gets rather unwieldy. This patch retains the switch statement (to rej

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #38 from Barto 2012-07-26 22:33:11 PDT --- (In reply to comment #37) > Try setting the RADEON_DEBUG env var to "fall". Ex: export RADEON_DEBUG=fall > then run blender. It should print a message to stdout/err when a software > fallb

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Eric Anholt
Marek Olšák writes: > Michel Dänzer told me on IRC that setting CFLAGS overrode all flags, > while OPT_FLAGS was only appended to existing CFLAGS, which is the > reason I have been using OPT_FLAGS. Is that not true anymore? By default, configure's CFLAGS and CXXFLAGS are "-g -O2" on gcc and "-O2

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #37 from Brian Paul 2012-07-26 22:13:28 PDT --- Try setting the RADEON_DEBUG env var to "fall". Ex: export RADEON_DEBUG=fall then run blender. It should print a message to stdout/err when a software fallback is hit. That should g

Re: [Mesa-dev] [PATCH] svga: fix invalid memory reference in needs_to_create_zero()

2012-07-26 Thread Brian Paul
On 07/26/2012 02:39 PM, Jose Fonseca wrote: Looks good. While we're at it, we could ensure the whole key, including num_textures, gets zeroed. The bulk of Mesa/Gallium code assumes structures are zeroed at initialization, which makes it extremely easy to overlook those few places where that's

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #36 from Roland Scheidegger 2012-07-26 21:42:26 PDT --- (In reply to comment #33) > Also, IIRC, blender uses GL_SELECT for which is currently always software. > There is a patch to hw accelerate it, but it never made it into master:

Re: [Mesa-dev] [PATCH 08/15] intel: Allocate miptree for multisample DRI2 buffers

2012-07-26 Thread Chad Versace
On 07/23/2012 03:16 PM, Paul Berry wrote: > On 21 July 2012 17:36, Chad Versace > wrote: > > Immediately after obtaining, with DRI2GetBuffersWithFormat, the DRM buffer > handle for a DRI2 buffer, we wrap that DRM buffer handle with a region and > a

Re: [Mesa-dev] [PATCH] svga: fix invalid memory reference in needs_to_create_zero()

2012-07-26 Thread Jose Fonseca
Looks good. While we're at it, we could ensure the whole key, including num_textures, gets zeroed. The bulk of Mesa/Gallium code assumes structures are zeroed at initialization, which makes it extremely easy to overlook those few places where that's isn't true. Jose - Original Message ---

[Mesa-dev] [PATCH] intel: Set num samples for winsys renderbuffers (v3)

2012-07-26 Thread Chad Versace
Add a new param, num_samples, to intel_create_renderbuffer and intel_create_private_renderbuffer. No multisample GL config is yet advertised, so the value of num_samples is currently 0. For server-owned winsys buffers, gl_renderbuffer::NumSamples is not yet used. v2: Quantize num_samples just on

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Marek Olšák
Michel Dänzer told me on IRC that setting CFLAGS overrode all flags, while OPT_FLAGS was only appended to existing CFLAGS, which is the reason I have been using OPT_FLAGS. Is that not true anymore? Marek On Thu, Jul 26, 2012 at 6:52 PM, Eric Anholt wrote: > If you want to change your compiler ar

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #35 from Barto 2012-07-26 20:33:26 PDT --- (In reply to comment #31) > (In reply to comment #29) > Unfortunately I think this is expected. Previously swrast didn't map whole > buffers, only parts of them. For much simpler and more ro

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #34 from Roland Scheidegger 2012-07-26 20:24:37 PDT --- (In reply to comment #31) > Unfortunately I think this is expected. Previously swrast didn't map whole > buffers, only parts of them. For much simpler and more robust code thoug

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #33 from Alex Deucher 2012-07-26 20:22:21 UTC --- Also, IIRC, blender uses GL_SELECT for which is currently always software. There is a patch to hw accelerate it, but it never made it into master: http://cgit.freedesktop.org/mesa/mes

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #32 from Barto 2012-07-26 20:13:04 PDT --- (In reply to comment #30) > That'll be a bit more work to diagnose. Have you ever used any profiling > tools? > no, but I can try to learn how to use these tools, I notice that the fall

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #31 from Roland Scheidegger 2012-07-26 20:10:28 PDT --- (In reply to comment #29) > I compiled mesa lib, Blender runs without crash, but it still very slow in the > GUI ( too much lag when I click in the gui, menus ), it's not norma

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #30 from Brian Paul 2012-07-26 19:56:28 PDT --- (In reply to comment #29) > (In reply to comment #28) > > Can you try making this change to radeon_span.c: > > > > diff --git a/src/mesa/drivers/dri/radeon/radeon_span.c > > b/src/mesa

[Mesa-dev] [PATCH] svga: fix invalid memory reference in needs_to_create_zero()

2012-07-26 Thread Brian Paul
The emit->key.fkey info is only valid if we're generating a fragment shader. We should not look at it if we're generating a vertex shader. When generating a vertex shader, the value of emit->key.fkey.num_textures was garbage and the loop over num_textures would read invalid data. At best this wou

Re: [Mesa-dev] [PATCH] intel: Set num samples for winsys renderbuffers (v2)

2012-07-26 Thread Eric Anholt
Chad Versace writes: > Eric, I refactored this patch so that intelCreateBuffer produces one call to > intel_quantize_samples rather than up to 4. I don't understand your logic for > why the screen argument is unneeded. I was saying screen argument wouldn't be needed for the two intel_create_rende

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #29 from Barto 2012-07-26 19:19:49 PDT --- (In reply to comment #28) > Can you try making this change to radeon_span.c: > > diff --git a/src/mesa/drivers/dri/radeon/radeon_span.c > b/src/mesa/drivers/dri/ra > index 1f2ba49..fd91f88

Re: [Mesa-dev] [PATCH 1/2] automake: Remove ARCH_FLAGS.

2012-07-26 Thread Ian Romanick
On 07/26/2012 09:52 AM, Eric Anholt wrote: In all current uses, it was appended to CFLAGS, which already had -m32. If you want to do some other flag supplied to compiler invocations, there's CFLAGS/CXXFLAGS. ARCH_FLAGS, OPT_FLAGS, and one or two other _FLAGS were used so that some configs cou

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-26 Thread Will Schmidt
On Thu, 2012-07-26 at 11:35 -0700, Jose Fonseca wrote: > > - Original Message - > > On Thu, 2012-07-26 at 10:31 -0700, Jose Fonseca wrote: > > > - Original Message - > > > > On Thu, 2012-07-26 at 07:52 -0700, Jose Fonseca wrote: > > > > > - Original Message - > > > > > > On

[Mesa-dev] [PATCH] intel: Set num samples for winsys renderbuffers (v2)

2012-07-26 Thread Chad Versace
Add a new param, num_samples, to intel_create_renderbuffer and intel_create_private_renderbuffer. No multisample GL config is yet advertised, so the value of num_samples is currently 0. For server-owned winsys buffers, gl_renderbuffer::NumSamples is not yet used. v2: Quantize num_samples just on

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #28 from Brian Paul 2012-07-26 18:45:48 PDT --- Can you try making this change to radeon_span.c: diff --git a/src/mesa/drivers/dri/radeon/radeon_span.c b/src/mesa/drivers/dri/ra index 1f2ba49..fd91f88 100644 --- a/src/mesa/drivers/d

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-26 Thread Jose Fonseca
- Original Message - > On Thu, 2012-07-26 at 10:31 -0700, Jose Fonseca wrote: > > - Original Message - > > > On Thu, 2012-07-26 at 07:52 -0700, Jose Fonseca wrote: > > > > - Original Message - > > > > > On 7/21/12 5:53 AM, Jose Fonseca wrote: > > > > > > - Original Mes

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-26 Thread Will Schmidt
On Thu, 2012-07-26 at 10:31 -0700, Jose Fonseca wrote: > - Original Message - > > On Thu, 2012-07-26 at 07:52 -0700, Jose Fonseca wrote: > > > - Original Message - > > > > On 7/21/12 5:53 AM, Jose Fonseca wrote: > > > > > - Original Message - > > > > >> Hi guys > > > > >> >

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Kenneth Graunke
On 07/26/2012 09:52 AM, Eric Anholt wrote: > If you want to change your compiler arguments, just set CFLAGS/CXXFLAGS. > Having Mesa have this separate variable is a great way to have your arguments > not thoroughly propagated to all compiler invocations. > --- > > I don't feel strongly about remov

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-26 Thread Jose Fonseca
- Original Message - > On Thu, 2012-07-26 at 07:52 -0700, Jose Fonseca wrote: > > - Original Message - > > > On 7/21/12 5:53 AM, Jose Fonseca wrote: > > > > - Original Message - > > > >> Hi guys > > > >> > > > >> LLVM 2.8 doesn't appear to have mcjit, so we end up with no >

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Brian Paul
On 07/26/2012 10:52 AM, Eric Anholt wrote: If you want to change your compiler arguments, just set CFLAGS/CXXFLAGS. Having Mesa have this separate variable is a great way to have your arguments not thoroughly propagated to all compiler invocations. --- I don't feel strongly about removing the va

Re: [Mesa-dev] [PATCH 5/9] intel gen4-5: Compute the interpolation status for every variable in one place.

2012-07-26 Thread Eric Anholt
Olivier Galibert writes: > The program keys are updated accordingly, but the values are not used > yet. > > Signed-off-by: Olivier Galibert > --- > src/mesa/drivers/dri/i965/brw_clip.c| 90 > ++- > src/mesa/drivers/dri/i965/brw_clip.h|1 + > src/mesa/d

Re: [Mesa-dev] [Intel-gfx] [PATCH 2/9] intel gen4-5: simplify the bfc copy in the sf.

2012-07-26 Thread Eric Anholt
Olivier Galibert writes: > @@ -121,12 +108,15 @@ static void do_twoside_color( struct brw_sf_compile *c ) > brw_push_insn_state(p); > brw_CMP(p, vec4(brw_null_reg()), backface_conditional, c->det, > brw_imm_f(0)); > brw_IF(p, BRW_EXECUTE_4); > - { > - switch (c->nr_verts) { > -

Re: [Mesa-dev] [Intel-gfx] [PATCH 3/9] intel gen4-5: fix GL_VERTEX_PROGRAM_TWO_SIDE selection.

2012-07-26 Thread Eric Anholt
Olivier Galibert writes: > Previous code only selected two side in pure fixed-function setups. > This version also activates it when needed with shaders programs. > > Signed-off-by: Olivier Galibert > --- > src/mesa/drivers/dri/i965/brw_sf.c |2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [Mesa-dev] [PATCH 1/9] intel gen4-5: fix the vue view in the fs.

2012-07-26 Thread Eric Anholt
Olivier Galibert writes: > In some cases the fragment shader view of the vue registers was out of > sync with the builder. This fixes it. s/builder/SF outputs/ ? I'd love to see the pre-gen6 code get rearranged so the FS walked the bitfield of FS inputs from SF and chose the urb offset for eac

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Matt Turner
On Thu, Jul 26, 2012 at 9:52 AM, Eric Anholt wrote: > If you want to change your compiler arguments, just set CFLAGS/CXXFLAGS. > Having Mesa have this separate variable is a great way to have your arguments > not thoroughly propagated to all compiler invocations. > --- Reviewed-by: Matt Turner _

Re: [Mesa-dev] [PATCH 1/2] automake: Remove ARCH_FLAGS.

2012-07-26 Thread Matt Turner
On Thu, Jul 26, 2012 at 9:52 AM, Eric Anholt wrote: > In all current uses, it was appended to CFLAGS, which already had -m32. If > you want to do some other flag supplied to compiler invocations, there's > CFLAGS/CXXFLAGS. > --- > configs/current.in |5 ++--- > configure.ac

Re: [Mesa-dev] [PATCH] mesa: Add support for glGetProgramiv pnames for UBOs.

2012-07-26 Thread Eric Anholt
Brian Paul writes: > On 07/26/2012 10:24 AM, Eric Anholt wrote: >> Fixes piglit ARB_uniform_buffer_object/getprogramiv. >> >> v2: Add extension checks. >> --- >> >> Since there were only two cases, I didn't use goto on this patch. >> >> src/mesa/main/shaderapi.c | 29 +

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #27 from Barto 2012-07-26 16:56:50 PDT --- (In reply to comment #26) > (In reply to comment #24) > > > (gdb) print colorType > > $3 = 0 > > > > that's why this assertion fails in line 1326 : > > > > GLchan rgbaSave[MAX_WIDTH][4];

[Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Eric Anholt
If you want to change your compiler arguments, just set CFLAGS/CXXFLAGS. Having Mesa have this separate variable is a great way to have your arguments not thoroughly propagated to all compiler invocations. --- I don't feel strongly about removing the variable from configure, just as long as we don

[Mesa-dev] [PATCH 1/2] automake: Remove ARCH_FLAGS.

2012-07-26 Thread Eric Anholt
In all current uses, it was appended to CFLAGS, which already had -m32. If you want to do some other flag supplied to compiler invocations, there's CFLAGS/CXXFLAGS. --- configs/current.in |5 ++--- configure.ac |8 ++-- src/gallium/drivers/r30

Re: [Mesa-dev] [PATCH] xlib: add X error handler around XGetImage() call

2012-07-26 Thread Ian Romanick
On 07/25/2012 03:23 PM, Brian Paul wrote: XGetImage() will generate a BadMatch error if the source window isn't visible. When that happens, create a new XImage. Fixes piglit 'select' test failures with swrast/xlib driver. NOTE: This is a candidate for the 8.0 branch. Reviewed-by: Ian Romanic

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #26 from Brian Paul 2012-07-26 16:45:30 PDT --- (In reply to comment #24) > (gdb) print colorType > $3 = 0 > > that's why this assertion fails in line 1326 : > > GLchan rgbaSave[MAX_WIDTH][4]; > struct swrast_renderbuffer *srb = s

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #25 from Roland Scheidegger 2012-07-26 16:30:37 PDT --- A very quick look at blender source shows it can indeed use PixelTransfer ops, in particular scale/bias. Those should be possible to accelerate (both with and without fragment s

Re: [Mesa-dev] [PATCH 11/11] glsl: Reject linking shaders with too many uniform blocks.

2012-07-26 Thread Brian Paul
On 07/26/2012 10:17 AM, Eric Anholt wrote: Brian Paul writes: On 07/20/2012 04:33 PM, Eric Anholt wrote: Part of fixing piglit maxblocks. --- src/glsl/linker.cpp | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/glsl/linker.cpp b/src/glsl/linke

Re: [Mesa-dev] [PATCH] mesa: Add support for glGetProgramiv pnames for UBOs.

2012-07-26 Thread Brian Paul
On 07/26/2012 10:24 AM, Eric Anholt wrote: Fixes piglit ARB_uniform_buffer_object/getprogramiv. v2: Add extension checks. --- Since there were only two cases, I didn't use goto on this patch. src/mesa/main/shaderapi.c | 29 + 1 file changed, 29 insertions(+) d

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-26 Thread Will Schmidt
On Thu, 2012-07-26 at 07:52 -0700, Jose Fonseca wrote: > - Original Message - > > On 7/21/12 5:53 AM, Jose Fonseca wrote: > > > - Original Message - > > >> Hi guys > > >> > > >> LLVM 2.8 doesn't appear to have mcjit, so we end up with no llvm > > >> libs > > >> defined, > > > > > >

[Mesa-dev] [PATCH] mesa: Add support for glGetProgramiv pnames for UBOs.

2012-07-26 Thread Eric Anholt
Fixes piglit ARB_uniform_buffer_object/getprogramiv. v2: Add extension checks. --- Since there were only two cases, I didn't use goto on this patch. src/mesa/main/shaderapi.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/mesa/main/shaderapi.c b/src/mes

Re: [Mesa-dev] [PATCH 11/11] glsl: Reject linking shaders with too many uniform blocks.

2012-07-26 Thread Eric Anholt
Brian Paul writes: > On 07/20/2012 04:33 PM, Eric Anholt wrote: >> Part of fixing piglit maxblocks. >> --- >> src/glsl/linker.cpp | 34 ++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp >> index bfdde40..f4e578

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #24 from Barto 2012-07-26 16:11:31 PDT --- I have finished the compilation of the debug mesa lib ( with CFLAG=-g ) now the result when gdb stops in breakpoint in meta.c, line 2258 : (gdb) print ctx->_ImageTransferState $4 = 1 (gdb

Re: [Mesa-dev] can't build/install osmesa and gl at same time

2012-07-26 Thread Eric Anholt
Jon TURNEY writes: > On 17/07/2012 16:48, Jon TURNEY wrote: >> On 17/07/2012 06:55, Dave Airlie wrote: >>> In Fedora we've always built both osmesa and GL versions of mesa, we >>> used to do this in two passes but its been possible for a while to do >>> this in a single pass, and it seems to work

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #23 from Barto 2012-07-26 15:46:16 PDT --- (In reply to comment #22) > > Hmm, if _ImageTransferState==0 and ctx->Fog.Enabled==0 the condition is false > and we shouldn't be setting fallback=true. > > How did you build Mesa? See co

Re: [Mesa-dev] can't build/install osmesa and gl at same time

2012-07-26 Thread Jon TURNEY
On 17/07/2012 16:48, Jon TURNEY wrote: > On 17/07/2012 06:55, Dave Airlie wrote: >> In Fedora we've always built both osmesa and GL versions of mesa, we >> used to do this in two passes but its been possible for a while to do >> this in a single pass, and it seems to work. >> >> However now src/mes

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #22 from Brian Paul 2012-07-26 15:24:00 PDT --- (In reply to comment #21) > (In reply to comment #20) > > (In reply to comment #19) > > > > There's a leading underscore on that variable. Did you miss that? > > I miss the underscor

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-26 Thread Jose Fonseca
- Original Message - > On 7/26/12 10:52 AM, Jose Fonseca wrote: > > - Original Message - > >> Are the problems of mcjit simply a superset > >> of the problems with the old jit? > > > > The only reason we started to look at mcjit was because old jit > > didn't support avx. But on c

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-26 Thread Adam Jackson
On 7/26/12 10:52 AM, Jose Fonseca wrote: - Original Message - Are the problems of mcjit simply a superset of the problems with the old jit? The only reason we started to look at mcjit was because old jit didn't support avx. But on current trunk (ie llvm-3.2) it does. To be honest, ap

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #21 from Barto 2012-07-26 15:12:44 PDT --- (In reply to comment #20) > (In reply to comment #19) > > There's a leading underscore on that variable. Did you miss that? I miss the underscore, after correctin here is the result :

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #20 from Brian Paul 2012-07-26 15:09:14 UTC --- (In reply to comment #19) > I use another way and now it works, gdb can reach _mesa_meta_DrawPixels, > > for that I set 4 breakpoints in order to reach the line where "fallback = > GL_

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #19 from Barto 2012-07-26 15:07:37 UTC --- I use another way and now it works, gdb can reach _mesa_meta_DrawPixels, for that I set 4 breakpoints in order to reach the line where "fallback = GL_TRUE" in meta.c file : break meta.c:22

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-26 Thread Jose Fonseca
- Original Message - > On 7/21/12 5:53 AM, Jose Fonseca wrote: > > - Original Message - > >> Hi guys > >> > >> LLVM 2.8 doesn't appear to have mcjit, so we end up with no llvm > >> libs > >> defined, > > > > Yes, mcjit is only used/necessary from llvm-3.1 onwards, so the > > autocon

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-26 Thread Adam Jackson
On 7/21/12 5:53 AM, Jose Fonseca wrote: - Original Message - Hi guys LLVM 2.8 doesn't appear to have mcjit, so we end up with no llvm libs defined, Yes, mcjit is only used/necessary from llvm-3.1 onwards, so the autoconf code should check conditiionally. BTW, I'll soon commit a chan

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #18 from Barto 2012-07-26 14:10:17 PDT --- (In reply to comment #17) > According to hartmut's comment #2 earlier, the stack trace says > _mesa_meta_DrawPixels() was called. Can you verify that? That is, after the > assertion fails

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #17 from Brian Paul 2012-07-26 13:50:00 PDT --- (In reply to comment #16) > (In reply to comment #15) > > > Let's first find out why the 'fallback' variable in _mesa_meta_DrawPixels() > > is > > getting set. Basically, use gdb to

[Mesa-dev] [Bug 47375] Blender crash on startup after upgrade to mesa 8.0.1

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47375 --- Comment #16 from Barto 2012-07-26 12:25:36 PDT --- (In reply to comment #15) > Let's first find out why the 'fallback' variable in _mesa_meta_DrawPixels() is > getting set. Basically, use gdb to set a breakpoint in > _mesa_meta_DrawPixels

[Mesa-dev] [Bug 52405] Openarena 0.8.8 performance regression with current master.

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52405 --- Comment #4 from Iaroslav 2012-07-26 11:17:14 PDT --- The problem in x-server 1.13 or xf86-video-ati + new xserver video abi and related dri|gl2proto headers. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ---

[Mesa-dev] [Bug 52140] Ubuntu Unity - Launcher and switcher icons disappeared

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52140 --- Comment #15 from Vasco Alves 2012-07-26 10:58:08 PDT --- Added my own logs, hope this also helps. On Sandy Bridge graphics. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail beca

[Mesa-dev] [Bug 52140] Ubuntu Unity - Launcher and switcher icons disappeared

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52140 --- Comment #14 from Vasco Alves 2012-07-26 10:54:14 PDT --- Created attachment 64717 --> https://bugs.freedesktop.org/attachment.cgi?id=64717 Vasco's glxinfo -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ---

[Mesa-dev] [Bug 52140] Ubuntu Unity - Launcher and switcher icons disappeared

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52140 --- Comment #13 from Vasco Alves 2012-07-26 10:52:36 PDT --- Created attachment 64716 --> https://bugs.freedesktop.org/attachment.cgi?id=64716 Vasco's dmesg -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- Y

[Mesa-dev] [Bug 52140] Ubuntu Unity - Launcher and switcher icons disappeared

2012-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52140 --- Comment #12 from Vasco Alves 2012-07-26 10:49:52 PDT --- Created attachment 64715 --> https://bugs.freedesktop.org/attachment.cgi?id=64715 Vasco's Xorg log -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --