Re: [Mesa-dev] [PATCH 16/21] anv: Implement VK_KHX_external_semaphore_fd

On Wed 03 May 2017, Jason Ekstrand wrote: > On Tue, May 2, 2017 at 5:15 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Fri 14 Apr 2017, Jason Ekstrand wrote: > > This implementation allocates a 4k BO for each semaphore that can be > > exported using OPAQUE_FD and uses

Re: [Mesa-dev] [PATCH v2 5/7] docs/releasing: added relevant people for build/check with Windows

On 05/03/2017 12:14 PM, Andres Gomez wrote: v2: Brian Paul as main contact point and Jose Fonseca as fallback (Vinson, Jose) Signed-off-by: Andres Gomez Cc: Emil Velikov Cc: Vinson Lee Cc: Brian Paul

[Mesa-dev] [PATCH v2] glsl: Corrected some typos and error messages

v2: left code style/formatting corrections out. Signed-off-by: Andres Gomez --- src/compiler/glsl/ast_to_hir.cpp | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index

Re: [Mesa-dev] [PATCH 0/4] Call for testing: Gallium set_index_buffer removal etc.

> On May 2, 2017, at 5:33 PM, Marek Olšák wrote: > > On Wed, May 3, 2017 at 12:18 AM, Cherniak, Bruce > wrote: >> >> On May 2, 2017, at 4:11 PM, Cherniak, Bruce >> wrote: >> >> >> On May 2, 2017, at 3:41 PM, Cherniak,

Re: [Mesa-dev] [PATCH 14/18] anv/allocator: Add the capability to allocate blocks of different sizes

On Wed, May 3, 2017 at 9:59 AM, Juan A. Suarez Romero wrote: > On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_allocator.c| 23 > ++- > > src/intel/vulkan/tests/block_pool_no_free.c | 7 --- > >

[Mesa-dev] [PATCH v2 6/7] docs/releasing: added relevant people for build/check with Android

v2: Tapani as main contact and Mauro just for help with debugging/building (Mauro). Signed-off-by: Andres Gomez Cc: Emil Velikov Cc: Tapani Pälli Cc: Mauro Rossi Acked-by: Tapani Pälli

Re: [Mesa-dev] [PATCH 16/18] anv/allocator: Support pushing multiple blocks onto a free list at once

On Wed, May 3, 2017 at 10:19 AM, Juan A. Suarez Romero wrote: > On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_allocator.c | 19 --- > > 1 file changed, 16 insertions(+), 3 deletions(-) > > > > diff --git

[Mesa-dev] [PATCH v2 5/7] docs/releasing: added relevant people for build/check with Windows

v2: Brian Paul as main contact point and Jose Fonseca as fallback (Vinson, Jose) Signed-off-by: Andres Gomez Cc: Emil Velikov Cc: Vinson Lee Cc: Brian Paul Cc: Jose Fonseca ---

Re: [Mesa-dev] [PATCH v03 17/38] genxml: Add rules to build gen4, gen45 and ge5.

In the subject: s/ge5/gen5/ But don't we need to squash this into the previous patch? Alone that patch won't even link, right? On Mon, May 01, 2017 at 06:43:05PM -0700, Rafael Antognolli wrote: > Signed-off-by: Rafael Antognolli > --- >

[Mesa-dev] [PATCH] radv: Don't use FLAT_SHADE for constants.

Setting both offset to 0x20 and flat shade results in passthrough mode instead of the constant. Signed-off-by: Bas Nieuwenhuizen Fixes: f205e19e4f8 "radv/ac: eliminate unused vertex shader outputs. (v2)" --- src/amd/vulkan/radv_pipeline.c | 8 1 file changed, 4

Re: [Mesa-dev] [PATCH v03 16/38] i965: Get real per-gen atom lists

On Mon, May 01, 2017 at 06:43:04PM -0700, Rafael Antognolli wrote: > From: Kenneth Graunke > > Make atoms initalization compile conditionally based on the target > platform. > --- > src/mesa/drivers/dri/i965/brw_state.h | 12 +- >

Re: [Mesa-dev] [PATCH v03 14/38] i965: Move MOCS macros to brw_context.h.

On Mon, May 01, 2017 at 06:43:02PM -0700, Rafael Antognolli wrote: > These macros are defined in brw_defines.h, which contains a lot of > macros that conflict with autogenerated code from genxml. But we need to > use them (the MOCS macros) in some of that same genxml code. > > Moving them to

Re: [Mesa-dev] [PATCH 04/18] anv: Get rid of a bunch of uses of size_t

On Wed, 2017-05-03 at 09:40 -0700, Jason Ekstrand wrote: > On Fri, Apr 28, 2017 at 1:34 AM, Juan A. Suarez Romero > wrote: > > On Thu, 2017-04-27 at 20:36 -0700, Jason Ekstrand wrote: > > > On Thu, Apr 27, 2017 at 9:23 AM, Juan A. Suarez Romero > > >

Re: [Mesa-dev] [PATCH 16/18] anv/allocator: Support pushing multiple blocks onto a free list at once

On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_allocator.c | 19 --- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/src/intel/vulkan/anv_allocator.c > b/src/intel/vulkan/anv_allocator.c > index 0e33d1e..7a687b7 100644 >

Re: [Mesa-dev] [PATCH 1/1] radeonsi: Use libdrm to get chipset name

Thanks for the comments. I was thinking probably marketing names only make sense for amdgpu, but I am OK to add a pointer to radeon_winsys. Will send a v2 later. Sam -Original Message- From: Nicolai Hähnle [mailto:nhaeh...@gmail.com] Sent: Wednesday, May 03, 2017 12:17 PM To: Li,

Re: [Mesa-dev] [PATCH 14/18] anv/allocator: Add the capability to allocate blocks of different sizes

On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_allocator.c| 23 ++- > src/intel/vulkan/tests/block_pool_no_free.c | 7 --- > 2 files changed, 14 insertions(+), 16 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 04/18] anv: Get rid of a bunch of uses of size_t

On Wed, May 3, 2017 at 9:40 AM, Jason Ekstrand wrote: > On Fri, Apr 28, 2017 at 1:34 AM, Juan A. Suarez Romero < > jasua...@igalia.com> wrote: > >> On Thu, 2017-04-27 at 20:36 -0700, Jason Ekstrand wrote: >> >> On Thu, Apr 27, 2017 at 9:23 AM, Juan A. Suarez Romero < >>

[Mesa-dev] [PATCH] anv/allocator: Improve block pool growing asserts

--- src/intel/vulkan/anv_allocator.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c index d7b86c8..40913ec 100644 --- a/src/intel/vulkan/anv_allocator.c +++ b/src/intel/vulkan/anv_allocator.c @@

Re: [Mesa-dev] [PATCH 04/18] anv: Get rid of a bunch of uses of size_t

On Fri, Apr 28, 2017 at 1:34 AM, Juan A. Suarez Romero wrote: > On Thu, 2017-04-27 at 20:36 -0700, Jason Ekstrand wrote: > > On Thu, Apr 27, 2017 at 9:23 AM, Juan A. Suarez Romero < > jasua...@igalia.com> wrote: > > On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: >

[Mesa-dev] [PATCH v2 3/3] glsl: reject memory qualifiers with uniform blocks

The spec allows memory qualifiers to be used with image variables, buffers variables and shader storage blocks. This patch also fixes validate_memory_qualifier_for_type(). Fixes the following ARB_uniform_buffer_object test: uniform-block-memory-qualifier.frag v2: - rewrite commit

[Mesa-dev] [PATCH v2 2/2] glthread/gallium: require safe_glthread to start glthread

Otherwise print a warning v2: based on Nicolai feedback Check the DRI extension version Signed-off-by: Gregory Hainaut --- src/gallium/state_trackers/dri/dri_context.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v2 1/2] glx|egl: allow to test if glthread is safe enough on X11 platform

I extended the struct __DRIbackgroundCallableExtensionRec because the other function pointer is already related for glthread. DRI2/DRI3 glx code path check that display can be locked (basically XInitThread was called) EGL code path is more tricky as we don't want to pull X11 header. Instead the

[Mesa-dev] [PATCH v2 0/2 Disable glthread is libX11 isn't thread-safe]

Hello, Following the discussion from https://lists.freedesktop.org/archives/mesa-dev/2017-April/153137.html A check was added to ensure that X11 display can be locked. It should be enough to ensure thread safety between X11 and glthread. I also did the check on DRI3 as I'm not 100% sure that it

Re: [Mesa-dev] [PATCH 16/21] anv: Implement VK_KHX_external_semaphore_fd

On Tue, May 2, 2017 at 5:15 PM, Chad Versace wrote: > On Fri 14 Apr 2017, Jason Ekstrand wrote: > > This implementation allocates a 4k BO for each semaphore that can be > > exported using OPAQUE_FD and uses the kernel's already-existing > > synchronization mechanism on

Re: [Mesa-dev] [PATCH 12.5/18] anv/allocator: Tweak the block pool growing algorithm

Reviewed-by: Juan A. Suarez Romero On Wed, 2017-04-26 at 10:01 -0700, Jason Ekstrand wrote: > The old algorithm worked fine assuming a constant block size. We're > about to break that assumption so we need an algorithm that's a bit more > robust against suddenly growing by

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: fix the DCE pass in presence of loops

On 05/03/2017 06:21 PM, Nicolai Hähnle wrote: On 02.05.2017 16:43, Samuel Pitoiset wrote: The TGSI DCE pass doesn't eliminate dead assignments like MOV TEMP[0], TEMP[1] in presence of loops because it assumes that the visitor doesn't emit dead code. This assumption is actually wrong and this

Re: [Mesa-dev] [PATCH v2] mesa/vbo: reduce prim array size

On 03.05.2017 18:16, Bartosz Tomczyk wrote: Yes, please push it for me. Done. Cheers, Nicolai On 03.05.2017 17:41, Nicolai Hähnle wrote: Reviewed-by: Nicolai Hähnle Do you need somebody to push this? On 02.05.2017 13:19, Bartosz Tomczyk wrote: We always use

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: fix the DCE pass in presence of loops

On 02.05.2017 16:43, Samuel Pitoiset wrote: The TGSI DCE pass doesn't eliminate dead assignments like MOV TEMP[0], TEMP[1] in presence of loops because it assumes that the visitor doesn't emit dead code. This assumption is actually wrong and this situation happens. However, it appears that the

Re: [Mesa-dev] [PATCH 1/1] radeonsi: Use libdrm to get chipset name

Hi Sam, Please use git send-email in the future, it doesn't mess up the formatting :) This is generally not how we do winsys things, because radeon needs to be supported in addition to amdgpu. The usual approach is to add a new callback function pointer to struct radeon_winsys, in this case

Re: [Mesa-dev] [PATCH v2] mesa/vbo: reduce prim array size

Yes, please push it for me. On 03.05.2017 17:41, Nicolai Hähnle wrote: Reviewed-by: Nicolai Hähnle Do you need somebody to push this? On 02.05.2017 13:19, Bartosz Tomczyk wrote: We always use only single element. v2: Change signle element arrays to variables ---

Re: [Mesa-dev] [PATCH v3 00/13] anv: Implement VK_KHX_multiview

On Wed, May 3, 2017 at 12:15 AM, Iago Toral wrote: > Hi Jason > > Sorry that I missed this. All the changes look good to me and I have > sent reviews for the patches that missed them. With this series we pass > all the multiview tests. Thanks! > > Iago > > On Thu,

Re: [Mesa-dev] [PATCH 16/17] st/mesa: upload zero-stride vertex attributes here

On 01.05.2017 14:53, Marek Olšák wrote: From: Marek Olšák This is the best place to do it. Now drivers without u_vbuf don't have to do it. --- src/mesa/state_tracker/st_atom_array.c | 56 -- src/mesa/state_tracker/st_context.c| 2 ++

[Mesa-dev] [PATCH 3/3] egl: Implement EGL_EXT_device_{base, query, enumeration}

From: Jonny Lamb This is a rebase/squash/rewrite of a series Jonny had sent long ago. The major change is implementing this in terms of the drmDevice API. Both relevant piglits go from skip to pass on i965. Signed-off-by: Adam Jackson ---

Re: [Mesa-dev] [PATCH 14/17] st/mesa: simplify the signature of get_client_array

Patches 8 - 14: Reviewed-by: Nicolai Hähnle On 01.05.2017 14:53, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_atom_array.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] egl/x11: Honor the EGL_PLATFORM_X11_SCREEN_EXT attribute

Signed-off-by: Adam Jackson --- src/egl/drivers/dri2/platform_x11.c | 2 +- src/egl/main/egldisplay.c | 19 --- src/egl/main/egldisplay.h | 1 + 3 files changed, 14 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] egl/platform/drm: Don't take display ownership until gbm is initialized

If the gbm_create_device() call here actually did fail, any subsequent eglTerminate on the display would segfault. Signed-off-by: Adam Jackson --- src/egl/drivers/dri2/platform_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 3/3] glsl: validate memory qualifiers inside structures/interfaces

On 05/03/2017 05:31 PM, Nicolai Hähnle wrote: On 01.05.2017 12:34, Samuel Pitoiset wrote: This relaxes using memory qualifiers for buffer variables because they are allowed. Fixes the following ARB_shader_image_load_store test: memory-qualifier-with-non-image-type.frag Signed-off-by:

[Mesa-dev] [PATCH kmscube] HACK: automatic modifier selection

This lacks proper abstractions and error checks, but sending out anyways, as it might be helpful for other people testing the whole modifier chain. This works on top of Ben's plane property blob patches. Signed-off-by: Lucas Stach --- common.c | 29

Re: [Mesa-dev] [PATCH 06/17] st/mesa: unify TCS, TES, GS st_*_program structures

With Gustaw's and possibly Brian's comment addressed, patches 1, 3-6: Reviewed-by: Nicolai Hähnle On 01.05.2017 14:52, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_atom.c | 12 ++---

Re: [Mesa-dev] [PATCH v2] mesa/vbo: reduce prim array size

Reviewed-by: Nicolai Hähnle Do you need somebody to push this? On 02.05.2017 13:19, Bartosz Tomczyk wrote: We always use only single element. v2: Change signle element arrays to variables --- src/mesa/vbo/vbo_exec_array.c | 74

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 Rob Clark changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 2/2] radeonsi/gfx9: fix gl_ViewportIndex

On 02.05.2017 16:25, Marek Olšák wrote: From: Marek Olšák Cc: 17.1 --- src/gallium/drivers/radeonsi/si_shader.c| 43 + src/gallium/drivers/radeonsi/si_state_shaders.c | 13 ++-- 2 files changed, 48

Re: [Mesa-dev] [PATCH 3/3] glsl: validate memory qualifiers inside structures/interfaces

On 01.05.2017 12:34, Samuel Pitoiset wrote: This relaxes using memory qualifiers for buffer variables because they are allowed. Fixes the following ARB_shader_image_load_store test: memory-qualifier-with-non-image-type.frag Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH 2/3] glsl: reject format qualifiers with non-image types everywhere

On 01.05.2017 12:34, Samuel Pitoiset wrote: Including structures, interfaces and uniform blocks. Fixes the following ARB_shader_image_load_store test: format-layout-with-non-image-type.frag Signed-off-by: Samuel Pitoiset Patches 1&2: Reviewed-by: Nicolai Hähnle

Re: [Mesa-dev] [RFC 2/2] glthread/gallium: require safe_glthread to start glthread

On 28.04.2017 23:11, Gregory Hainaut wrote: Otherwise print a warning Signed-off-by: Gregory Hainaut --- src/gallium/state_trackers/dri/dri_context.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [RFC 1/2] glx|egl: allow to test if glthread is safe enough on X11 platform

On 28.04.2017 23:11, Gregory Hainaut wrote: I extended the struct __DRIbackgroundCallableExtensionRec because the other function pointer is already related for glthread. DRI2/DRI3 glx code path check that display can be locked (basically XInitThread was called) EGL code path is more tricky as

[Mesa-dev] [Bug 100916] Multiple definition of `glwMDrawingAreaWidgetClass'

https://bugs.freedesktop.org/show_bug.cgi?id=100916 Bug ID: 100916 Summary: Multiple definition of `glwMDrawingAreaWidgetClass' Product: Mesa Version: 8.0 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH 12/18] anv/allocator: Embed the block_pool in the state_pool

Reviewed-by: Juan A. Suarez Romero On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > Now that the state stream is allocating off of the state pool, there's > no reason why we need the block pool to be separate. > --- > src/intel/vulkan/anv_allocator.c

Re: [Mesa-dev] [PATCH] i965: Set modifier for imported and duplicated images

Hey Emil, On 3 May 2017 at 15:32, Emil Velikov wrote: > On 3 May 2017 at 09:43, Daniel Stone wrote: >> @@ -805,6 +807,7 @@ intel_create_image_from_fds(__DRIscreen *dri_screen, >> if (image == NULL) >>return NULL; >> >> +

Re: [Mesa-dev] [PATCH 10/18] anv: Allocate binding table blocks through the state pool

Reviewed-by: Juan A. Suarez Romero On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_batch_chain.c | 47 > +- > src/intel/vulkan/anv_private.h | 2 +- > 2 files changed, 22 insertions(+), 27

Re: [Mesa-dev] [PATCH v2 2/4] egl, dri: Propagate context priority hint to driver->CreateContext

On Wed, May 03, 2017 at 03:42:42PM +0100, Emil Velikov wrote: > On 3 May 2017 at 15:29, Chris Wilson wrote: > > On Wed, Apr 12, 2017 at 02:58:50PM +0100, Emil Velikov wrote: > >> On 11 April 2017 at 17:11, Chris Wilson wrote: > >> > Jump

Re: [Mesa-dev] [PATCH] radeonsi: constify a bunch of the perfcounter structs.

On 03.05.2017 00:41, Dave Airlie wrote: From: Dave Airlie This moves the structs from the data segment to the rodata segment, which seems like the more correct place for them. Signed-off-by: Dave Airlie Reviewed-by: Nicolai Hähnle

Re: [Mesa-dev] [PATCH 09/18] anv/allocator: Add support for "back" allocations to state_pool

Reviewed-by: Juan A. Suarez Romero On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_allocator.c | 31 +-- > src/intel/vulkan/anv_private.h | 4 > 2 files changed, 33 insertions(+), 2 deletions(-) > >

Re: [Mesa-dev] [PATCH 08/18] anv/allocator: Drop the block_size field from block_pool

Reviewed-by: Juan A. Suarez Romero On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > Since the state_stream is now pulling from a state_pool, the only thing > pulling directly off the block pool is the state pool so we can just > move the block_size there. The one

Re: [Mesa-dev] [PATCH v2 2/4] egl, dri: Propagate context priority hint to driver->CreateContext

On 3 May 2017 at 15:29, Chris Wilson wrote: > On Wed, Apr 12, 2017 at 02:58:50PM +0100, Emil Velikov wrote: >> On 11 April 2017 at 17:11, Chris Wilson wrote: >> > Jump through the layers of abstraction between egl and dri in order to >> > feed

Re: [Mesa-dev] [PATCH] gbm/dri: Fix sign-extension in modifier query

On 3 May 2017 at 15:18, Daniel Stone wrote: > On 3 May 2017 at 15:15, Emil Velikov wrote: >> On 2 May 2017 at 19:49, Daniel Stone wrote: >>> - ret |= mod; >>> + ret |= (uint64_t)(mod & 0x); >>> >> I was itching

Re: [Mesa-dev] [PATCH] i965: Set modifier for imported and duplicated images

Hi Dan, On 3 May 2017 at 09:43, Daniel Stone wrote: > When a buffer is being created from FD or GEM flink import, the current > API makes no provision for passing modifier information along with this. > Set the modifier for such images to DRM_FORMAT_MOD_INVALID. > > Also

Re: [Mesa-dev] [PATCH v2 2/4] egl, dri: Propagate context priority hint to driver->CreateContext

On Wed, Apr 12, 2017 at 02:58:50PM +0100, Emil Velikov wrote: > On 11 April 2017 at 17:11, Chris Wilson wrote: > > Jump through the layers of abstraction between egl and dri in order to > > feed the context priority attribute through to the backend. This > > requires us

Re: [Mesa-dev] [PATCH] gbm/dri: Fix sign-extension in modifier query

On 3 May 2017 at 15:15, Emil Velikov wrote: > On 2 May 2017 at 19:49, Daniel Stone wrote: >> - ret |= mod; >> + ret |= (uint64_t)(mod & 0x); >> > I was itching to suggest the following from the start, but your patch > also works ;-) >

Re: [Mesa-dev] [PATCH] gbm/dri: Fix sign-extension in modifier query

On 2 May 2017 at 19:49, Daniel Stone wrote: > When we were assembling the unsigned 64-bit query return from its > two signed 32-bit component parts, the lower half was getting > sign-extended into the top half. Be more explicit about what we want to > do. > > Fixes

[Mesa-dev] [PATCH 3/4] radeonsi: fix gl_PrimitiveID in tessellation with instanced draws on SI

From: Nicolai Hähnle Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_state_draw.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c

[Mesa-dev] [PATCH 1/4] radeonsi: fix primitive ID in fragment shader when using tessellation

From: Nicolai Hähnle In a VS->TCS->TES->PS pipeline, the primitive ID is read from TES exports, so it is as if TES were using the primitive ID. Specifically, this fixes a bug where the primitive ID is not reset at the start of a new instance. Cc:

[Mesa-dev] [PATCH 4/4] radeonsi: clarify documentation of existing SI workaround

From: Nicolai Hähnle Limiting LS-HS to a single wave is required on all SI chips due to an issue with a power management feature. --- src/gallium/drivers/radeonsi/si_state_draw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/4] radeonsi: load patch_id for TES-as-ES when exporting for PS

From: Nicolai Hähnle For some reason, this change is only necessary on SI. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_state_shaders.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 0/4] radeonsi: fix gl_PrimitiveID bugs related to tesselation

Hi, This series fixes a few subtle bugs when using gl_PrimitiveID and tessellation. I've also sent out a bunch of new piglit tests to exercise gl_PrimitiveID + instancing (+ tessellation). Please review! Thanks, Nicolai -- src/gallium/drivers/radeonsi/si_state_draw.c | 18 +-

[Mesa-dev] [PATCH 2/2] radeonsi: get rid of secondary input/output word

From: Nicolai Hähnle We only advertise a maximum of 32 inputs and outputs in each shader stage, so everything fits into 64 bits. --- src/gallium/drivers/radeonsi/si_shader.c| 35 +++--- src/gallium/drivers/radeonsi/si_shader.h| 6 +---

[Mesa-dev] [PATCH 1/2] radeonsi: split per-patch from per-vertex indices

From: Nicolai Hähnle Make it a bit clearer that the index spaces are logically seperate by having them defined in different functions. --- src/gallium/drivers/radeonsi/si_shader.c| 56 + src/gallium/drivers/radeonsi/si_shader.h|

Re: [Mesa-dev] [PATCH] radv/wsi: report presentation error per image request

On 2 May 2017 at 04:41, Dave Airlie wrote: > From: Dave Airlie > > This ports > 0fcb92c17dee681bd39c08ddf0abc358a27337c7 > anv: wsi: report presentation error per image request > > This fixes: > dEQP-VK.wsi.xlib.incremental_present.scale_none.* > >

Re: [Mesa-dev] [PATCH] anv: anv_gem_mmap() returns MAP_FAILED as mapping error

On 3 May 2017 at 14:26, Samuel Iglesias Gonsálvez wrote: > On Wed, 2017-05-03 at 14:15 +0100, Emil Velikov wrote: >> On 3 May 2017 at 12:33, Samuel Iglesias Gonsálvez > om> wrote: >> > On Wed, 2017-05-03 at 11:50 +0100, Emil Velikov wrote: >> > > Hi

[Mesa-dev] [Bug 99591] Segmentation fault when running vulkaninfo with RADV Radeon Vulkan driver

https://bugs.freedesktop.org/show_bug.cgi?id=99591 --- Comment #8 from Vasilis LIaskovitis --- I am getting a very similar backtrace in radv (with git master Vulkan-LoaderAndValidationLayers): (gdb) bt #0 0x0001e006 in ?? () #1 0x7fffedcc7e42 in

Re: [Mesa-dev] [PATCH] anv: anv_gem_mmap() returns MAP_FAILED as mapping error

On Wed, 2017-05-03 at 14:15 +0100, Emil Velikov wrote: > On 3 May 2017 at 12:33, Samuel Iglesias Gonsálvez om> wrote: > > On Wed, 2017-05-03 at 11:50 +0100, Emil Velikov wrote: > > > Hi Samuel, > > > > > > On 3 May 2017 at 08:57, Samuel Iglesias Gonsálvez >

Re: [Mesa-dev] [PATCH] anv: anv_gem_mmap() returns MAP_FAILED as mapping error

On 3 May 2017 at 12:33, Samuel Iglesias Gonsálvez wrote: > On Wed, 2017-05-03 at 11:50 +0100, Emil Velikov wrote: >> Hi Samuel, >> >> On 3 May 2017 at 08:57, Samuel Iglesias Gonsálvez > om> wrote: >> > Take it into account when checking if the mapping

Re: [Mesa-dev] [PATCH 01/13] gallium/dri: always link against shared glapi

On 28.04.2017 15:14, Emil Velikov wrote: From: Emil Velikov In the early days of Xorg and Mesa we had multiple providers of the GLAPI. All of those were the ones responsible for dlopening the DRI module. Hence it was perfectly fine, and actually expected, for the

Re: [Mesa-dev] [PATCH V3] glapi: add KHR_no_error support to dispatch table generation

On 03.05.2017 06:25, Timothy Arceri wrote: This will allows us to create no error versions of functions noted by a _no_error suffix. We also need to set a no_error attribute equal to "true" in the xml. V3: stop the no_error attribute being overwritten when functions alias another. V2: tidy

[Mesa-dev] [PATCH v3 2/2] i965/vec4: load dvec3/4 uniforms first in the push constant buffer

Reorder the uniforms to load first the dvec4-aligned variables in the push constant buffer and then push the vec4-aligned ones. This fixes a bug were the dvec3/4 might be loaded one part on a GRF and the rest in next GRF, so the region parameters to read that could break the HW rules. v2: - Fix

Re: [Mesa-dev] [PATCH 06/18] anv/allocator: Roll fixed_size_state_pool into state_pool

Reviewed-by: Juan A. Suarez Romero On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > The helper functions aren't really gaining us as much as they claim and > are actually about to be in the way. > --- > src/intel/vulkan/anv_allocator.c | 85 >

Re: [Mesa-dev] [PATCH 03/18] anv/allocator: Convert the state stream to pull from a state pool

On Fri, 2017-04-28 at 10:31 +0200, Juan A. Suarez Romero wrote: > On Thu, 2017-04-27 at 20:30 -0700, Jason Ekstrand wrote: > > On Wed, Apr 26, 2017 at 9:04 AM, Juan A. Suarez Romero > > wrote: > > > On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > > > > --- > > > >

Re: [Mesa-dev] [PATCH v2 1/2] i965/vec4: fix swizzle and writemask when loading an uniform with constant offset

On Tue, 2017-05-02 at 12:23 -0700, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > El Viernes, 28 de abril de 2017 16:08:35 Francisco Jerez escribió: > > > Samuel Iglesias Gonsálvez writes: > > > > It was setting XYWZ swizzle and

Re: [Mesa-dev] [PATCH 01/18] anv/allocator: Add no-valgrind versions of state_pool_alloc/free

On Thu, 2017-04-27 at 20:34 -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 9:20 AM, Juan A. Suarez Romero > wrote: > > On Wed, 2017-04-26 at 07:35 -0700, Jason Ekstrand wrote: > > > --- > > >  src/intel/vulkan/anv_allocator.c | 24 +++- > > >  1

Re: [Mesa-dev] [PATCH] anv: anv_gem_mmap() returns MAP_FAILED as mapping error

On Wed, 2017-05-03 at 11:50 +0100, Emil Velikov wrote: > Hi Samuel, > > On 3 May 2017 at 08:57, Samuel Iglesias Gonsálvez om> wrote: > > Take it into account when checking if the mapping failed. > > > > Signed-off-by: Samuel Iglesias Gonsálvez > > ---

Re: [Mesa-dev] [PATCH] anv: anv_gem_mmap() returns MAP_FAILED as mapping error

Hi Samuel, On 3 May 2017 at 08:57, Samuel Iglesias Gonsálvez wrote: > Take it into account when checking if the mapping failed. > > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/intel/vulkan/anv_allocator.c | 2 +- >

[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

https://bugs.freedesktop.org/show_bug.cgi?id=100690 --- Comment #12 from Gregor Münch --- I saw something like that before. Sometimes the red squares appeared, sometimes it was like on your picture and sometimes it was just very dark when you zoomed out. I played now

Re: [Mesa-dev] [PATCH] etnaviv: add L8A8_UNORM texture format

On Tue, 2017-05-02 at 22:06 +0200, Christian Gmeiner wrote: > No piglit regressions. > > Signed-off-by: Christian Gmeiner Reviewed-by: Philipp Zabel > --- > src/gallium/drivers/etnaviv/etnaviv_format.c | 2 ++ > 1 file changed, 2

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

On 03.05.2017 12:31, Marc Dietrich wrote: > Hi Constantine, > > Am Mittwoch, 3. Mai 2017, 05:48:14 CEST schrieb Constantine Kharlamov: >> On 03.05.2017 00:50, Constantine Kharlamov wrote: >>> On 28.04.2017 10:57, Marc Dietrich wrote: Hi Constantine, Am Donnerstag, 27. April 2017,

Re: [Mesa-dev] [PATCH 2/2] mesa: make _mesa_accum() static

On 05/03/2017 11:30 AM, Timothy Arceri wrote: On 03/05/17 17:27, Samuel Pitoiset wrote: Why don't inline _mesa_acum()? inline is only meaningful if the function is in the header. Just marking it as static will do the same thing in a c file. i.e leave it up to the compiler as to whether it

Re: [Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

Hi Constantine, Am Mittwoch, 3. Mai 2017, 05:48:14 CEST schrieb Constantine Kharlamov: > On 03.05.2017 00:50, Constantine Kharlamov wrote: > > On 28.04.2017 10:57, Marc Dietrich wrote: > >> Hi Constantine, > >> > >> Am Donnerstag, 27. April 2017, 21:04:37 CEST schrieb Constantine Kharlamov: >

Re: [Mesa-dev] [PATCH 2/2] mesa: make _mesa_accum() static

On 03/05/17 17:27, Samuel Pitoiset wrote: Why don't inline _mesa_acum()? inline is only meaningful if the function is in the header. Just marking it as static will do the same thing in a c file. i.e leave it up to the compiler as to whether it should be inlined or not. At least that's how I

[Mesa-dev] [v2 37/39] intel/isl/gen7/hack: Use stencil vertical alignment of 8 instead of 4

Signed-off-by: Topi Pohjolainen --- src/intel/isl/isl_gen7.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl_gen7.c b/src/intel/isl/isl_gen7.c index 18687b5..cf5b377 100644 --- a/src/intel/isl/isl_gen7.c +++

[Mesa-dev] [v2 38/39] i965/miptree: Represent w-tiled stencil surfaces with isl

leaving y-tiled (r8stencil) copies still as they were. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.c | 24 +++ src/mesa/drivers/dri/i965/brw_tex_layout.c| 57 ---

[Mesa-dev] [v2 35/39] i965/gen8+: Prepare depth state emission for isl based miptrees

Also drops unnecessary check for stencil_mt when setting qpitch - that is inside stencil_mt guarded block already. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen8_depth_state.c | 38 +++- 1 file changed, 31 insertions(+), 7

[Mesa-dev] [v2 36/39] i965: Add isl based miptree creator

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 91 +++ 1 file changed, 91 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index

[Mesa-dev] [v2 34/39] i965/gen7: Prepare depth state emission for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen7_misc_state.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_misc_state.c b/src/mesa/drivers/dri/i965/gen7_misc_state.c

[Mesa-dev] [v2 39/39] i965/miptree: Represent y-tiled stencil copies with isl

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [v2 32/39] i965: Prepare texture validator for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_tex_validate.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_validate.c b/src/mesa/drivers/dri/i965/intel_tex_validate.c index

[Mesa-dev] [v2 33/39] i965: Prepare slice copy for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index

[Mesa-dev] [v2 30/39] i965: Prepare framebuffer validator for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_fbo.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c index

[Mesa-dev] [v2 24/39] i965: Prepare up/downsampling for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 46 ++- 1 file changed, 38 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [v2 29/39] i965: Prepare slice validator for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h index

[Mesa-dev] [v2 28/39] i965: Prepare tex, img and rt state emission for isl based miptrees

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 25 +--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c

[Mesa-dev] [v2 27/39] i965: Refactor miptree to isl converter and adjustment

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 69 ++-- 1 file changed, 41 insertions(+), 28 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c

<    1   2   3   >