[Mesa-dev] [PATCH] i965: don't call dup() twice when calling eglDupNativeFenceFDANDROID.

2017-06-16 Thread Tapani Pälli
From: Randy Xu This was causing crashes in Vulkan and GLES stress testing. Currently, both libEGL and the DRI module call dup when the function is called. Remove the former since it's ultimately a driver decision how to manage the file descriptor. v2: remove dup from the EGL layer (Emil Velikov

Re: [Mesa-dev] [PATCH] i965: don't call dup() twice when calling eglDupNativeFenceFDANDROID.

2017-06-16 Thread Tapani Pälli
Oops sorry, forget about this one. This does not work ok :/ Need to take a closer look why. On 06/16/2017 10:21 AM, Tapani Pälli wrote: From: Randy Xu This was causing crashes in Vulkan and GLES stress testing. Currently, both libEGL and the DRI module call dup when the function is called. R

Re: [Mesa-dev] [PATCH 0/6] i965/vec4: Implement partial DF register spilling

2017-06-16 Thread Samuel Iglesias Gonsálvez
On Thu, 2017-06-15 at 13:15 +0200, Samuel Iglesias Gonsálvez wrote: > Hello, > > As mentioned in the patch series that implemented Ivybridge support > ARB_gpu_shader_fp64 [0], the only missing feature in that series was > register spilling of 64-bit data and, because of that, about ~39 fp64 > pigl

[Mesa-dev] [PATCH] i965: skip varyings without slot

2017-06-16 Thread Juan A. Suarez Romero
Commit 00620782c9 (i965: use nir_shader_gather_info() over do_set_program_inouts()) changed how we compute the outputs written. In the previous version it was using the IR declared outputs, while in the new one it uses NIR to parse the instructions that write outputs. Thus, if the shader has decl

[Mesa-dev] [Bug 101464] PrimitiveRestartNV inside a render list causes a crash

2017-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101464 Bug ID: 101464 Summary: PrimitiveRestartNV inside a render list causes a crash Product: Mesa Version: 17.0 Hardware: x86-64 (AMD64) OS: All Status: NEW S

[Mesa-dev] [PATCH] i965: update MaxTextureRectSize to match PRMs and comply with OpenGL 4.1+

2017-06-16 Thread Iago Toral Quiroga
We were exposing 4096, but we can do up to 8192 in Gen4-6 and up to 16384 in gen7+. OpenGL 4.1+ requires at least 16384. --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH mesa v2 1/2] egl/display: only detect the platform once

2017-06-16 Thread Grazvydas Ignotas
On Fri, Jun 16, 2017 at 1:53 AM, Eric Engestrom wrote: > My refactor missed the fact that `native_platform` is static. > Add the proper guard around the detection code, as it might not be > necessary, and only print the debug message when a detection was > actually performed. > > Bugzilla: https:/

[Mesa-dev] [PATCH v2 2/3] mesa/st: glsl_to_tgsi Implement a new lifetime tracker for temporaries

2017-06-16 Thread Gert Wollny
This patch adds new classes and tests to implement a tracker for the life time of temporary registers for the register renaming stage of glsl_to_tgsi. The tracker aims at estimating the shortest possible life time for each register. The code base requires c++11, the flag is propagated from the LLVM

[Mesa-dev] [PATCH v2 0/3][RFC]mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

2017-06-16 Thread Gert Wollny
Dear all, with the help of Nicolai's comments I rewrote the proposed patch set to improve the register renaming. The patch is related to bugs where shader compilation fails with "- translation from TGSI failed!" Among these is https://bugs.freedesktop.org/show_bug.cgi?id=65448 which I can

[Mesa-dev] [PATCH v2 3/3] mesa/st: glsl_to_tgsi: tie in the new register renaming approach

2017-06-16 Thread Gert Wollny
This patch replaces the old register livetime estimation with the new approach. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.

[Mesa-dev] [PATCH v2 1/3] mesa/st: glsl_to_tgsi move some helper classes to extra files

2017-06-16 Thread Gert Wollny
To prepare the implementation of a temp register lifetime tracker some of the classes and functions are moved into seperate header/ implementation files to make them accessible from other files. Specifically these are: class st_src_reg; class st_dst_reg; class glsl_to_tgsi_instruction;

[Mesa-dev] [PATCH] glsl: gl_Max{Vertex, Fragment}UniformComponents exist in all desktop GL versions

2017-06-16 Thread Iago Toral Quiroga
The current implementation assumed that these were replaced in GLSL >= 4.10 by gl_Max{Vertex,Fragment}UniformVectors, however this is not true: both built-ins should be produced from GLSL 4.10 onwards. This was raised by new CTS tests that are in development. --- src/compiler/glsl/builtin_variabl

Re: [Mesa-dev] [PATCH] st/mesa: don't set the border color if it's unused

2017-06-16 Thread Marek Olšák
On Jun 16, 2017 6:08 AM, "Michel Dänzer" wrote: On 15/06/17 08:56 PM, Marek Olšák wrote: > From: Marek Olšák [...] > /* For non-black borders... */ > - if (msamp->BorderColor.ui[0] || > - msamp->BorderColor.ui[1] || > - msamp->BorderColor.ui[2] || > - msamp->BorderColor

Re: [Mesa-dev] [PATCH mesa v2 1/2] egl/display: only detect the platform once

2017-06-16 Thread Eric Engestrom
On Friday, 2017-06-16 12:10:55 +0300, Grazvydas Ignotas wrote: > On Fri, Jun 16, 2017 at 1:53 AM, Eric Engestrom wrote: > > My refactor missed the fact that `native_platform` is static. > > Add the proper guard around the detection code, as it might not be > > necessary, and only print the debug m

[Mesa-dev] [Bug 101252] eglGetDisplay() is not thread safe

2017-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101252 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive restart for non-strip prims based on app list

2017-06-16 Thread Marek Olšák
Hi, Feral's games still enable primitive restart for all draw calls. FYI, I will push this patch on Monday if there is no other feedback. Some other points: - This is not the first occurrence of private app lists in drivers. r300 also has an app list in r300_chipset.c. - The list of Feral's games

Re: [Mesa-dev] R600/AMDGPU fixes for Clover

2017-06-16 Thread Emil Velikov
On 15 June 2017 at 14:03, Aaron Watry wrote: > Hey all, > > We haven't landed the fixes to break the r600g dependency on AMDGPU yet. > I'm headed out of town for a long weekend and don't feel like risking the > push before being gone for five days. > > I've got a v3 of Emil's patch 4/5 that remove

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

2017-06-16 Thread Emil Velikov
On 25 April 2017 at 15:32, Emil Velikov wrote: > On 25 April 2017 at 15:06, Christian König wrote: >> Am 25.04.2017 um 15:17 schrieb Ilia Mirkin: >>> >>> [SNIP] >>> Is there a patch I should test? >> >> >> Patch is attached, but only compile tested. >> >> Basically if OpenGL/VDPAU interop worked

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

2017-06-16 Thread Ilia Mirkin
On Fri, Jun 16, 2017 at 7:51 AM, Emil Velikov wrote: > On 25 April 2017 at 15:32, Emil Velikov wrote: >> On 25 April 2017 at 15:06, Christian König wrote: >>> Am 25.04.2017 um 15:17 schrieb Ilia Mirkin: [SNIP] Is there a patch I should test? >>> >>> >>> Patch is attached, but only

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

2017-06-16 Thread Emil Velikov
On 16 June 2017 at 13:00, Ilia Mirkin wrote: > On Fri, Jun 16, 2017 at 7:51 AM, Emil Velikov > wrote: >> On 25 April 2017 at 15:32, Emil Velikov wrote: >>> On 25 April 2017 at 15:06, Christian König wrote: Am 25.04.2017 um 15:17 schrieb Ilia Mirkin: > > [SNIP] > Is there a pat

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

2017-06-16 Thread Ilia Mirkin
On Jun 16, 2017 8:09 AM, "Emil Velikov" wrote: On 16 June 2017 at 13:00, Ilia Mirkin wrote: > On Fri, Jun 16, 2017 at 7:51 AM, Emil Velikov wrote: >> On 25 April 2017 at 15:32, Emil Velikov wrote: >>> On 25 April 2017 at 15:06, Christian König wrote: Am 25.04.2017 um 15:17 schrieb Ilia M

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

2017-06-16 Thread Emil Velikov
On 16 June 2017 at 13:11, Ilia Mirkin wrote: > On Jun 16, 2017 8:09 AM, "Emil Velikov" wrote: > > On 16 June 2017 at 13:00, Ilia Mirkin wrote: >> On Fri, Jun 16, 2017 at 7:51 AM, Emil Velikov >> wrote: >>> On 25 April 2017 at 15:32, Emil Velikov wrote: On 25 April 2017 at 15:06, Christian

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: fold vdpau_interop.h and vdpau_dmabuf.h

2017-06-16 Thread Ilia Mirkin
On Fri, Jun 16, 2017 at 8:15 AM, Emil Velikov wrote: > On 16 June 2017 at 13:11, Ilia Mirkin wrote: >> On Jun 16, 2017 8:09 AM, "Emil Velikov" wrote: >> >> On 16 June 2017 at 13:00, Ilia Mirkin wrote: >>> On Fri, Jun 16, 2017 at 7:51 AM, Emil Velikov >>> wrote: On 25 April 2017 at 15:32,

[Mesa-dev] [PATCH 1/2] ac: parse EVENT_WRITE_EOP, RELEASE_MEM, WAIT_REG_MEM, NOWHERE

2017-06-16 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_debug.c | 46 ++ src/amd/common/sid.h | 1 + 2 files changed, 47 insertions(+) diff --git a/src/amd/common/ac_debug.c b/src/amd/common/ac_debug.c index a8f81bf..79473ec 100644 --- a/src/amd/common/ac_debug

[Mesa-dev] [PATCH 2/2] ac/sid.h: don't use parentheses in PKT3_RELEASE_MEM definition

2017-06-16 Thread Marek Olšák
From: Marek Olšák The parses skips the line if it contains parentheses. --- src/amd/common/sid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/sid.h b/src/amd/common/sid.h index c69f4f6..a8c78c1 100644 --- a/src/amd/common/sid.h +++ b/src/amd/common/sid.h @@

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive restart for non-strip prims based on app list

2017-06-16 Thread Marc Di Luzio
Hi, >From what I'm aware this is the progress on the fixes: TotalWarhammer and HitmanPro should now have a fix in shipping. MadMax, DeusExMD and DirtRally have the fix in a patch making it's way through our internal testing. We would still very much prefer to not have a special case for our game

Re: [Mesa-dev] [PATCH v1 2/7] etnaviv: Add return statement to etna_amode so compiler is happy

2017-06-16 Thread Emil Velikov
On 15 June 2017 at 21:47, Robert Foss wrote: > From: Tomeu Vizoso > > Signed-off-by: Robert Foss > --- > src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c > b/src/gallium/drivers/etnaviv/etna

[Mesa-dev] [PATCH 7/9] radeonsi/gfx9: keep reusing the same buffer/address for the gfx9 flush fence

2017-06-16 Thread Marek Olšák
From: Marek Olšák instead of using a monotonic suballocator --- src/gallium/drivers/radeonsi/si_pipe.c | 6 ++ src/gallium/drivers/radeonsi/si_pipe.h | 2 ++ src/gallium/drivers/radeonsi/si_state_draw.c | 16 3 files changed, 16 insertions(+), 8 deletions(-) d

[Mesa-dev] [PATCH 0/9] RadeonSI cache flush optimizations

2017-06-16 Thread Marek Olšák
Hi, This series: - reworks CB (MSAA-only) and DB flushes - removes L2 flushes for CP packets and indirect buffers for GFX9 - enables the constant engine for GFX9 (yay!) - removes all flushes and waits from the end of IBs (relying on the kernel fence to do that) The rework of CB and DB flushes i

[Mesa-dev] [PATCH 3/9] radeonsi: unify CB_RESOLVE blitter invocation code

2017-06-16 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 35 +- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index f0abfdc..0993ebd 100644 --- a/src/gallium/d

[Mesa-dev] [PATCH 2/9] radeonsi: flush DB caches only when transitioning from DB to texturing

2017-06-16 Thread Marek Olšák
From: Marek Olšák Use the mechanism of si_decompress_textures, but instead of doing the actual decompression, just flag the DB cache flush there. This removes a lot of unnecessary DB cache flushes. --- src/gallium/drivers/radeonsi/si_blit.c| 36 +-- src/gallium/d

[Mesa-dev] [PATCH 8/9] radeonsi: don't emit partial flushes at the end of IBs

2017-06-16 Thread Marek Olšák
From: Marek Olšák The kernel sort of does the same thing with fences. --- src/gallium/drivers/radeonsi/si_hw_context.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_hw_context.c b/src/gallium/drivers/radeonsi/si_hw_context.c index

[Mesa-dev] [PATCH 6/9] radeonsi/gfx9: enable the constant engine

2017-06-16 Thread Marek Olšák
From: Marek Olšák I think this kernel commit fixes it: drm/amdgpu:use FRAME_CNTL for new GFX ucode --- src/gallium/drivers/radeonsi/si_pipe.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pip

[Mesa-dev] [PATCH 1/9] radeonsi: add separate HUD counters for CB and DB cache flushes

2017-06-16 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 3 ++- src/gallium/drivers/radeon/r600_query.c | 17 - src/gallium/drivers/radeon/r600_query.h | 3 ++- src/gallium/drivers/radeonsi/si_state_draw.c | 7 --- 4 files changed, 20 insertions(+

[Mesa-dev] [PATCH 4/9] radeonsi: flush CB after MSAA only when transitioning from CB to textures

2017-06-16 Thread Marek Olšák
From: Marek Olšák The main flush before texturing is done after the FMASK decompress pass. CB after MSAA rendering is not flushed in set_framebuffer_state and also not in memory_barrier if the current color buffer is MSAA. We fully rely on the FMASK decompress pass for the flushing. Some CB dec

[Mesa-dev] [PATCH 9/9] radeonsi: don't do any flushes at the end of IBs

2017-06-16 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_hw_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_hw_context.c b/src/gallium/drivers/radeonsi/si_hw_context.c index 5d930a6..b420c9f 100644 --- a/src/gallium/drivers/radeonsi/si_hw_context.c

[Mesa-dev] [PATCH 5/9] radeonsi/gfx9: indirect buffers and all CP packets use TC L2

2017-06-16 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c| 5 +++-- src/gallium/drivers/radeonsi/si_pipe.c | 6 -- src/gallium/drivers/radeonsi/si_state.c | 4 +++- src/gallium/drivers/radeonsi/si_state_draw.c | 19 +++ 4 files changed, 21 insertions(+

Re: [Mesa-dev] [PATCH v1 3/7] gallium: os_process fixes for Android

2017-06-16 Thread Emil Velikov
On 16 June 2017 at 04:38, Chih-Wei Huang wrote: > 2017-06-16 4:47 GMT+08:00 Robert Foss : >> From: Rob Herring >> >> Signed-off-by: Rob Herring >> --- >> src/gallium/auxiliary/os/os_process.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/src/gallium/auxiliary/

Re: [Mesa-dev] [PATCH v1 4/7] gbm: add XBGR8888 support for dumb buffers

2017-06-16 Thread Emil Velikov
On 15 June 2017 at 21:47, Robert Foss wrote: > From: Rob Herring > > Signed-off-by: Rob Herring > --- > src/gbm/backends/dri/gbm_dri.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c > index 19be440d48..58b

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

2017-06-16 Thread Emil Velikov
On 15 June 2017 at 21:47, Robert Foss wrote: > From: Rob Herring > > This is required by freedreno at least for GLES3 support. > > See docs/patents.txt for information about turning this on for s/w > renderers. > I'm inclined to agree with Tapani. We're not lawyers and with the patent expiring in

Re: [Mesa-dev] [PATCH v1 6/7] android: add etnaviv driver build support

2017-06-16 Thread Emil Velikov
Hi Rob, There's a handful of small nitpicks, but nothing serious. On 15 June 2017 at 21:47, Robert Foss wrote: > From: Rob Herring > > Add etnaviv to Android makefiles. > > Signed-off-by: Rob Herring > --- > Android.mk| 5 +-- > src/gallium/Android.mk

Re: [Mesa-dev] [PATCH v1 2/7] etnaviv: Add return statement to etna_amode so compiler is happy

2017-06-16 Thread Christian Gmeiner
2017-06-16 14:54 GMT+02:00 Emil Velikov : > On 15 June 2017 at 21:47, Robert Foss wrote: >> From: Tomeu Vizoso >> >> Signed-off-by: Robert Foss >> --- >> src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/gallium/drivers/etnaviv/etna

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

2017-06-16 Thread Rob Clark
On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov wrote: > On 15 June 2017 at 21:47, Robert Foss wrote: >> From: Rob Herring >> >> This is required by freedreno at least for GLES3 support. >> >> See docs/patents.txt for information about turning this on for s/w >> renderers. >> > I'm inclined to agr

Re: [Mesa-dev] [PATCH v1 4/7] gbm: add XBGR8888 support for dumb buffers

2017-06-16 Thread Daniel Stone
Hi, On 15 June 2017 at 21:47, Robert Foss wrote: > From: Rob Herring > diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c > index 19be440d48..58b62ac361 100644 > --- a/src/gbm/backends/dri/gbm_dri.c > +++ b/src/gbm/backends/dri/gbm_dri.c > @@ -1067,7 +1067,7 @@ create_d

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

2017-06-16 Thread Emil Velikov
On 16 June 2017 at 14:25, Rob Clark wrote: > On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov > wrote: >> On 15 June 2017 at 21:47, Robert Foss wrote: >>> From: Rob Herring >>> >>> This is required by freedreno at least for GLES3 support. >>> >>> See docs/patents.txt for information about turning

Re: [Mesa-dev] [PATCH v1 7/7] android: build imx-drm winsys

2017-06-16 Thread Emil Velikov
Hi Rob, I missed something in the pl111+vc4 case, which is also applicable here. If one selects the DC w/o the GPU the build will fail. To resolve that one option is to simply pull the GPU static libs as dependencies for the DC ones. Some example/specifics below. On 15 June 2017 at 21:47, Robert

Re: [Mesa-dev] [PATCH v1 6/7] android: add etnaviv driver build support

2017-06-16 Thread Rob Herring
On Fri, Jun 16, 2017 at 8:24 AM, Emil Velikov wrote: > Hi Rob, > > There's a handful of small nitpicks, but nothing serious. > > On 15 June 2017 at 21:47, Robert Foss wrote: >> From: Rob Herring >> >> Add etnaviv to Android makefiles. >> >> Signed-off-by: Rob Herring >> --- >> @@ -46,7 +47,7

Re: [Mesa-dev] [PATCH v2 0/3][RFC]mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

2017-06-16 Thread Emil Velikov
Hi Gert, Welcome to Mesa, and apologies for chiming in so late. Please don't use STL within core mesa code. While some places do use it, those are quite isolated and have specific role. For example: - st/clover - heavily templated, pure C++ - drivers/swr - as above - drivers/nouveau/codegen -

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

2017-06-16 Thread Rob Clark
On Fri, Jun 16, 2017 at 9:49 AM, Emil Velikov wrote: > On 16 June 2017 at 14:25, Rob Clark wrote: >> On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov >> wrote: >>> On 15 June 2017 at 21:47, Robert Foss wrote: From: Rob Herring This is required by freedreno at least for GLES3 suppo

[Mesa-dev] [Bug 101467] swr driver leaks memory (texture management)

2017-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101467 Bug ID: 101467 Summary: swr driver leaks memory (texture management) Product: Mesa Version: 17.1 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [RFC 13/22] RFC: vulkan: Update registry for MESAX dma_buf extensions

2017-06-16 Thread Emil Velikov
Hi gents, On 8 June 2017 at 19:44, Daniel Stone wrote: > - VK_MESAX_external_memory_dma_buf > - VK_MESAX_external_image_dma_buf Perhaps not so crazy idea: Considering a handful of the people involved (Collabora, Google, Intel) are Khronos members, it should be possible to have the extension

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

2017-06-16 Thread Emil Velikov
On 16 June 2017 at 15:30, Rob Clark wrote: > On Fri, Jun 16, 2017 at 9:49 AM, Emil Velikov > wrote: >> On 16 June 2017 at 14:25, Rob Clark wrote: >>> On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov >>> wrote: On 15 June 2017 at 21:47, Robert Foss wrote: > From: Rob Herring >

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

2017-06-16 Thread Matt Turner
On Fri, Jun 16, 2017 at 6:18 AM, Emil Velikov wrote: > On 15 June 2017 at 21:47, Robert Foss wrote: >> From: Rob Herring >> >> This is required by freedreno at least for GLES3 support. >> >> See docs/patents.txt for information about turning this on for s/w >> renderers. >> > I'm inclined to agr

Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float

2017-06-16 Thread Emil Velikov
On 16 June 2017 at 15:45, Matt Turner wrote: > On Fri, Jun 16, 2017 at 6:18 AM, Emil Velikov > wrote: >> On 15 June 2017 at 21:47, Robert Foss wrote: >>> From: Rob Herring >>> >>> This is required by freedreno at least for GLES3 support. >>> >>> See docs/patents.txt for information about turni

Re: [Mesa-dev] [PATCH 2/2] ac/sid.h: don't use parentheses in PKT3_RELEASE_MEM definition

2017-06-16 Thread Alex Deucher
On Fri, Jun 16, 2017 at 8:30 AM, Marek Olšák wrote: > From: Marek Olšák > > The parses skips the line if it contains parentheses. Series is: Reviewed-by: Alex Deucher > --- > src/amd/common/sid.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/common/sid.h b/s

[Mesa-dev] [PATCH 2/2] vc4: Set shareable BOs as T tiled if possible.

2017-06-16 Thread Eric Anholt
X11 and GL compositor performance on VC4 has been terrible because of our SHARED-usage buffers all being forced to linear. This swaps SHARED && !LINEAR buffers over to being tiled. This is an expected win for all GL compositors during rendering (a full copy of each shared texture per draw call),

[Mesa-dev] [PATCH 1/2] vc4: Switch back to using a local copy of vc4_drm.h.

2017-06-16 Thread Eric Anholt
Needing to get our uapi header from libdrm has only complicated things. Follow intel's lead and drop our requirement for it. Generated from 056f4f02abb7e9e4a0cf0cda0211586df5e43842 of drm-misc-next --- Sending this patch to the list due to touching configure.ac. configure.ac

[Mesa-dev] [PATCH v2 03/13] i965: convert MI_REPORT_PERF_COUNT to genxml

2017-06-16 Thread Lionel Landwerlin
Also make it available from gen7 only to gen7+. Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_context.h | 11 src/mesa/drivers/dri/i965/brw_performance_query.c | 33 --- src/mesa/drivers/dri/i965/genX_state_upload.c | 18 +++

[Mesa-dev] [PATCH v2 02/13] i965: perf: fix codegen with single operand equation

2017-06-16 Thread Lionel Landwerlin
We did support single value operand equations, but not single variable operand ones. In particular we were failing on "$Sampler0Bottleneck". Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_oa.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/dr

[Mesa-dev] [PATCH v2 09/13] i965: perf: keep on reading reports until delimiting timestamp

2017-06-16 Thread Lionel Landwerlin
Due to an underlying hardware race condition, we have no guarantee that all the reports coming from the OA buffer related to the workload we're trying to measure have landed to memory by the time all the work submitted has completed. That means we need to keep on reading the OA stream until we read

[Mesa-dev] [PATCH v2 05/13] intel: common: add number of thread per eu

2017-06-16 Thread Lionel Landwerlin
This will be used by to normalize OA counters. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_device_info.c | 24 ++-- src/intel/common/gen_device_info.h | 6 ++ 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/src/intel/common/gen_device_info.c

[Mesa-dev] [PATCH v2 00/13] i965: Add performance query OA support on Gen 8 & 9

2017-06-16 Thread Lionel Landwerlin
Hi, Here is a v2 following some comments by Ken. Some patches already have a rb-by/ack-by. Here is the list that needs looking at : 1, 2, 3, 4, 5 & 8. The list will probably filter some of the big patches, you can find the branch there : https://github.com/djdeath/mesa/commits/wip/djdeath/oa-ne

[Mesa-dev] [PATCH v2 01/13] intel: common: add flag to identify platforms by name

2017-06-16 Thread Lionel Landwerlin
The perf infrastructure needs to identify specific platforms, not just generations. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_device_info.c | 26 -- src/intel/common/gen_device_info.h | 4 2 files changed, 24 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH v2 11/13] i965: perf: use gen_device_info rather then brw_context

2017-06-16 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_performance_query.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_performance_query.c b/src/mesa/drivers/dri/i965/brw_performance_query

[Mesa-dev] [PATCH v2 08/13] i965: Add Gen8+ INTEL_performance_query support

2017-06-16 Thread Lionel Landwerlin
From: Robert Bragg Enables access to OA unit metrics on Gen8+ via INTEL_performance_query. v2: make use of new parameters coming from gen_device_info (Lionel) Signed-off-by: Robert Bragg Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/Makefile.am | 8 +- src/mesa

[Mesa-dev] [PATCH v2 10/13] i965: perf: ensure isolated timer reports while idle don't confuse filtering

2017-06-16 Thread Lionel Landwerlin
From: Robert Bragg From experimentation in IGT, we found that the OA unit might label some report as "idle" (using an invalid context ID), right after a report for a given context. Deltas generated by those reports actually belong to the previous context, even though they're not labelled as such.

[Mesa-dev] [PATCH v2 06/13] i965: Add Gen8+ sys_vars for generated OA code

2017-06-16 Thread Lionel Landwerlin
From: Robert Bragg In preparation for adding XML OA metric set descriptions for Gen 8 and 9 which will result in auto generated code that depends on a number of new system variables ($EuSubslicesTotalCount, $EuThreadsCount and $SliceMask) this adds corresponding members to brw->perf.sys_vars. Si

[Mesa-dev] [PATCH v2 04/13] intel: common: express timestamps units in frequency

2017-06-16 Thread Lionel Landwerlin
Rather than storing the period as a double that looses some precision. Also fixes the Gen9LP timestamp frequency which is no 19200123 but 1920 as pointed by Ville : https://lists.freedesktop.org/archives/intel-gfx/2017-April/125126.html Finally add the Cannonlake timestamp frequency. Signed

Re: [Mesa-dev] [PATCH 11/11] intel: Enable vulkan build for gen10

2017-06-16 Thread Anuj Phogat
On Thu, Jun 15, 2017 at 4:12 PM, Jason Ekstrand wrote: > 7-11 are > > Reviewed-by: Jason Ekstrand > Thanks. > Have you tried reverting my patch and running the CTS? > No, I'll do it soon. > On Tue, Jun 13, 2017 at 11:28 AM, Anuj Phogat wrote: >> >> This patch just enables building Vulkan libs f

[Mesa-dev] [PATCH] radeonsi: add new polaris12 pci id

2017-06-16 Thread Alex Deucher
Signed-off-by: Alex Deucher Cc: 17.0 17.1 --- include/pci_ids/radeonsi_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index 50f638f..9453c1c 100644 --- a/include/pci_ids/radeonsi_pci_ids.h +++ b/include/pci_i

Re: [Mesa-dev] [PATCH v2 0/3][RFC]mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

2017-06-16 Thread Gert Wollny
Hello Emil, Am Freitag, den 16.06.2017, 15:21 +0100 schrieb Emil Velikov: > > Please don't use STL within core mesa code. May I ask why? I always try to not re-implement already available functionality and since mesa already uses C++ it seems kind of natural to use the STL because it provides a

Re: [Mesa-dev] [PATCH 02/15] i965: Add helper for converting isl tiling to bufmgr tiling

2017-06-16 Thread Nanley Chery
On Thu, Jun 15, 2017 at 06:23:24PM -0700, Jason Ekstrand wrote: > On Thu, Jun 15, 2017 at 5:18 PM, Nanley Chery wrote: > > > On Tue, Jun 13, 2017 at 05:50:00PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > > src/mesa/drivers/dri/i965/intel_blit.h | 13 ++

Re: [Mesa-dev] [PATCH 02/15] i965: Add helper for converting isl tiling to bufmgr tiling

2017-06-16 Thread Nanley Chery
On Fri, Jun 16, 2017 at 07:58:02AM +0300, Pohjolainen, Topi wrote: > On Thu, Jun 15, 2017 at 05:18:22PM -0700, Nanley Chery wrote: > > On Tue, Jun 13, 2017 at 05:50:00PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > > src/mesa/drivers/dri/i965/intel_blit.h | 1

Re: [Mesa-dev] [PATCH 9/9] radeonsi: don't do any flushes at the end of IBs

2017-06-16 Thread Marek Olšák
Please ignore this patch. There are some regressions with depth_resolve piglit tests. Marek On Fri, Jun 16, 2017 at 2:58 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_hw_context.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/dri

[Mesa-dev] [PATCH] radeonsi: fix dumping shader descriptors into ddebug logs

2017-06-16 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 76 ++--- 1 file changed, 41 insertions(+), 35 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index 25c3882..35bfec7 100644 --- a/src/gallium

Re: [Mesa-dev] [PATCH 09/15] i965: Prepare slice copy for isl based miptrees

2017-06-16 Thread Nanley Chery
On Thu, Jun 15, 2017 at 10:01:53PM +0300, Pohjolainen, Topi wrote: > On Thu, Jun 15, 2017 at 11:39:44AM -0700, Jason Ekstrand wrote: > > On Tue, Jun 13, 2017 at 7:50 AM, Topi Pohjolainen < > > topi.pohjolai...@gmail.com> wrote: > > > > > Signed-off-by: Topi Pohjolainen > > > --- > > > src/mesa/d

[Mesa-dev] [PATCH 10/11] egl/wayland: Remove duplicate wl_buffer creation code

2017-06-16 Thread Daniel Stone
Now create_wl_buffer is generic enough, we can use it for the EGL_WL_create_wayland_buffer_from_image extension. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 71 + 1 file changed, 11 insertions(+), 60 deletions(-) diff --git a/src/egl

[Mesa-dev] [PATCH 01/11] util: Remove u_math from u_vector

2017-06-16 Thread Daniel Stone
u_vector.h doesn't actually use anything from u_math, but it does mean everyone has to pull in src/gallium/auxiliary/util includes. Just remove it, adding a include to u_vector.c to cover memcpy. Signed-off-by: Daniel Stone --- src/util/u_vector.c | 2 ++ src/util/u_vector.h | 1 - 2 files cha

[Mesa-dev] [PATCH 00/11] EGL/Wayland modifiers, format cleanup

2017-06-16 Thread Daniel Stone
Hi, This series adds support for multi-planar buffers, as well as buffers with modifiers, in the Wayland EGL client platform. Rather than extending wl_drm, we use the generic zwp_linux_dambuf_v1 protocol, which is implemented in Weston. This makes it a bit easier to, amongst other things, write co

[Mesa-dev] [PATCH 11/11] egl/wayland: Use linux-dmabuf interface for buffers

2017-06-16 Thread Daniel Stone
When available, use the zwp_linux_dambuf_v1 interface to create buffers, which allows multiple planes and buffer modifiers to be used. Signed-off-by: Daniel Stone --- configure.ac| 5 +- src/egl/Makefile.am | 22 +++- src/egl/drivers/dri2/.gitig

[Mesa-dev] [PATCH 04/11] gbm: Axe buffer import format conversion table

2017-06-16 Thread Daniel Stone
Wayland buffers coming from wl_drm use the WL_DRM_FORMAT_* enums, which are identical to GBM_FORMAT_*. Similarly, FD imports do not need to convert between GBM and DRI FourCC, since they are (almost) completely compatible. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 62 +

[Mesa-dev] [PATCH 02/11] egl/wayland: Fix whitespace damage

2017-06-16 Thread Daniel Stone
Convert tabs to spaces, fix misalignments. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 38 + 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayl

[Mesa-dev] [PATCH 08/11] egl/wayland: Make create_wl_buffer more generic

2017-06-16 Thread Daniel Stone
Remove surface-specific code from create_wl_buffer, so it's now just a generic translation from DRIimage to wl_buffer. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 66 + 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/s

[Mesa-dev] [PATCH 09/11] egl/wayland: Remove more surface specifics from create_wl_buffer

2017-06-16 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 32 ++-- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 7a85cb1073..b7197d0a75 100644 ---

[Mesa-dev] [PATCH 03/11] egl/wayland: Use MIN2 for wl_drm version

2017-06-16 Thread Daniel Stone
Use a slightly more explicit version cap for binding wl_drm, so we can add other interfaces with different versioning schemes later. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/egl/drivers/dri2

[Mesa-dev] [PATCH 07/11] gbm: Remove is_planar_format dead code

2017-06-16 Thread Daniel Stone
This was only used in create_dumb() to blacklist planar formats. However, the start of the function already whitelists ARGB (cursor) and XRGB (scanout), and nothing else. So this entire function can be removed. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 32 +

[Mesa-dev] [PATCH 06/11] gbm: Check harder for supported formats

2017-06-16 Thread Daniel Stone
Luckily no-one really used the is_format_supported() call, because it only supported three formats. Also, since buffers with alpha can be displayed on planes, stop banning them from use. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 40

[Mesa-dev] [PATCH 05/11] gbm: Pull out FourCC <-> DRIimage format table

2017-06-16 Thread Daniel Stone
Rather than duplicated (yet asymmetric) open-coded tables, pull them out to a common structure. Signed-off-by: Daniel Stone --- src/gbm/Makefile.am| 1 + src/gbm/backends/dri/gbm_dri.c | 105 ++--- 2 files changed, 46 insertions(+), 60 deletions(

Re: [Mesa-dev] [PATCH 10/15] i965/miptree: Add option to resolve offsets using isl_surf

2017-06-16 Thread Nanley Chery
On Tue, Jun 13, 2017 at 05:50:08PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 16 > 1 file changed, 16 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > b/src/mesa/drivers

Re: [Mesa-dev] [PATCH v1 2/3] nir: Add a lowering pass for UYVY textures Similar with support for YUYV but with byte order difference in sampler

2017-06-16 Thread Kristian H. Kristensen
Johnson Lin writes: > --- > src/compiler/nir/nir.h | 1 + > src/compiler/nir/nir_lower_tex.c | 16 > 2 files changed, 17 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index ab7ba14303b7..1b4e47058d4d 100644 > --- a/src/compiler/nir/n

Re: [Mesa-dev] [PATCH 07/11] gbm: Remove is_planar_format dead code

2017-06-16 Thread Eric Engestrom
On Friday, 2017-06-16 18:14:30 +0100, Daniel Stone wrote: > This was only used in create_dumb() to blacklist planar formats. > However, the start of the function already whitelists ARGB (cursor) > and XRGB (scanout), and nothing else. So this entire function can be > removed. > > Signed-of

Re: [Mesa-dev] [PATCH 05/11] gbm: Pull out FourCC <-> DRIimage format table

2017-06-16 Thread Eric Engestrom
On Friday, 2017-06-16 18:14:28 +0100, Daniel Stone wrote: > Rather than duplicated (yet asymmetric) open-coded tables, pull them out > to a common structure. > > Signed-off-by: Daniel Stone > --- > src/gbm/Makefile.am| 1 + > src/gbm/backends/dri/gbm_dri.c | 105 >

Re: [Mesa-dev] [PATCH 11/15] i965: Add isl based miptree creator

2017-06-16 Thread Nanley Chery
On Tue, Jun 13, 2017 at 05:50:09PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 76 > +++ > 1 file changed, 76 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > b/sr

[Mesa-dev] [PATCH] ac: add missing stdint.h include for uint32_t

2017-06-16 Thread Emil Velikov
From: Emil Velikov Cc: Mark Janes Signed-off-by: Emil Velikov --- src/amd/common/ac_gpu_info.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/common/ac_gpu_info.h b/src/amd/common/ac_gpu_info.h index a72ab58f9a3..69e9d2828f5 100644 --- a/src/amd/common/ac_gpu_info.h +++ b/src/amd/

Re: [Mesa-dev] [PATCH 00/16] swr: rasterizer update

2017-06-16 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jun 15, 2017, at 1:37 PM, Tim Rowley wrote: > > Highlights include: jit cache (disabled currently), work in progress > to shrink the vertex structure used in the frontend, and refactoring > to speed recompiles if simdintrin.h is changed. > > Tim Rowley (16): >

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

2017-06-16 Thread Chad Versace
On Thu 15 Jun 2017, Rob Herring wrote: > On Tue, Jun 13, 2017 at 1:55 PM, Chad Versace > wrote: > > On Fri 09 Jun 2017, Tapani Pälli wrote: > >> > >> > >> On 06/08/2017 09:27 PM, Chad Versace wrote: > >> > On Thu 08 Jun 2017, Tomasz Figa wrote: > >> > > On Thu, Jun 8, 2017 at 4:08 PM, Tapani Päll

Re: [Mesa-dev] [RFC 13/22] RFC: vulkan: Update registry for MESAX dma_buf extensions

2017-06-16 Thread Chad Versace
On Fri 16 Jun 2017, Emil Velikov wrote: > Hi gents, > > On 8 June 2017 at 19:44, Daniel Stone wrote: > > > - VK_MESAX_external_memory_dma_buf > > - VK_MESAX_external_image_dma_buf > Perhaps not so crazy idea: > > Considering a handful of the people involved (Collabora, Google, > Intel) are

Re: [Mesa-dev] [PATCH v2] swr: Don't crash when encountering a VBO with stride = 0.

2017-06-16 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Jun 15, 2017, at 11:24 AM, Bruce Cherniak mailto:bruce.chern...@intel.com>> wrote: The swr driver uses vertex_buffer->stride to determine the number of elements in a VBO. A recent change to the state-tracker made it possible for VBO

Re: [Mesa-dev] [PATCH 11/15] i965: Add isl based miptree creator

2017-06-16 Thread Jason Ekstrand
On Fri, Jun 16, 2017 at 11:11 AM, Nanley Chery wrote: > On Tue, Jun 13, 2017 at 05:50:09PM +0300, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 76 > +++ > > 1 file changed, 76 insertions(+) > > >

[Mesa-dev] [Bug 101471] Mesa fails to build: unknown typename bool

2017-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101471 Bug ID: 101471 Summary: Mesa fails to build: unknown typename bool Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

  1   2   3   >