If external format is used, we store the external format identifier in
conversion to be used later when creating VkImageView.
v2: rebase to b43f955037c changes
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src
v2: rebase to b43f955037c changes
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_android.c | 31
src/intel/vulkan/anv_android.h | 2 ++
src/intel/vulkan/anv_android_stubs.c | 7 +++
3 files changed, 40 insertions(+)
diff --git a/src/intel
as expected for HAL_PIXEL_FORMAT_NV12_Y_TILED_INTEL
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_android.c | 106 +
1 file changed, 106 insertions(+)
diff --git a/src/intel/vulkan/anv_android.c b/src/intel/vulkan/anv_android.c
index 916e76c93ff..54b62b9d02f
v2: handle R8G8B8X8 as R8G8B8_UNORM (Jason)
v3: add HAL_PIXEL_FORMAT_NV12_Y_TILED_INTEL, we make it define
for now to avoid direct dependency to minigbm headers
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/vk_format_info.h | 50 +++
1 file changed, 50
If a conversion struct was passed, then initialize view using
format from the conversion structure.
v2: use vk_format directly from the anv_format struct
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_image.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 4
src/intel/vulkan/anv_private.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index 6e7807579df..f27456fa41d 100644
--- a/src/intel/vulkan/anv_formats.c
This will be utilized later by GetAndroidHardwareBufferPropertiesANDROID.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 22 +++---
src/intel/vulkan/anv_private.h | 5 +
2 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/src/intel/vulkan
v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB)
v3: properly handle usage bits when creating from image
v4: refactor, code cleanup (Jason)
v5: rebase to b43f955037c changes,
initialize bo flags as ANV_BO_EXTERNAL (Lionel)
Signed-off-by: Tapani Pälli
---
src/intel/vulkan
v2: have separate memory properties for android, set usage
flags for buffers correctly
v3: code cleanup (Jason)
+ limit maxArrayLayers to 1 for AHardwareBuffer based images
v4: rebase to b43f955037c changes
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 41
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_extensions.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index 7c81228f705..ed9b2edef32 100644
--- a/src/intel/vulkan/anv_extensions.py
+++ b/src/intel/vulkan
://cgit.freedesktop.org/~tpalli/mesa/log/?h=ahw
android tree used in testing:
https://github.com/tpalli/external-mesa/tree/ahw-android
CI was happy:
https://mesa-ci.01.org/tpalli/builds/642/group/63a9f0ea7bb98050796b649e85481845
Tapani Pälli (15):
anv: add create_flags as part of anv_image
anv: refactor
or non-YUV
formats but skip setting up conversion when format does not have
can_ycbcr flag set.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/genX_state.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_sta
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_image.c | 78 ++
src/intel/vulkan/anv_private.h | 5 +++
2 files changed, 46 insertions(+), 37 deletions(-)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 50fa688c052
This will make it possible for next patch to rip
anv_image_create_info out from make_surface function.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_image.c | 1 +
src/intel/vulkan/anv_private.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c b/src
Seems already unused at the commit that introduced it ..
Reviewed-by: Tapani Pälli
On 11/27/18 10:10 AM, Matt Turner wrote:
---
src/compiler/glsl/glsl_to_nir.cpp | 4
1 file changed, 4 deletions(-)
diff --git a/src/compiler/glsl/glsl_to_nir.cpp
b/src/compiler/glsl/glsl_to_nir.cpp
Reviewed-by: Tapani Pälli
On 11/27/18 10:08 AM, Matt Turner wrote:
We normally call with stderr which is unbuffered, so this won't affect
that, but it does let me call nir_print_shader(nir, fopen("log", "w+"))
from gdb and actually get the whole shader in my file.
--
Similar warning is done in platform_x11.c;
Reviewed-by: Tapani Pälli
On 11/23/18 2:59 PM, Emil Velikov wrote:
From: Emil Velikov
Currently as the function fails, we pass uninitialized data to the
authentication function. Stop doing that and print an warning when
the function fails.
Cc
Hi;
On 11/23/18 10:29 AM, Gert Wollny wrote:
Hello Tapani,
since you wrote the original code, could you have a look at this patch?
Sure. I was able to reproduce this leak with Piglit's
"ext_transform_feedback-points" and fix LGTM;
Reviewed-by: Tapani Pälli
Many thanks
Hi;
On 11/23/18 9:06 AM, yanhua wrote:
Hi, Tapani:
Recently I come into a problem. I have a opengl program, if the
program run, it can take up almost one core, and the Xorg takes almost
one core too.
I found this program continuously recvmsg from the Xorg. I'm sure
the CPU is
Reviewed-by: Tapani Pälli
On 11/22/18 8:18 PM, Eric Engestrom wrote:
Not a hot path obviously, but the table still has 425 extensions, which
you can go through in just 9 steps with a binary search.
The table is already sorted, as required by other parts of the code and
enforced by mesa's
Ping, this series has not landed yet, planning to land it soon?
On 11/9/18 7:58 AM, Tapani Pälli wrote:
Thanks, _mesa_has makes things a lot cleaner and simpler to manage;
Reviewed-by: Tapani Pälli
On 11/8/18 2:42 PM, Erik Faye-Lund wrote:
Here's v2 of this series. Changes are as follows
Hi;
On 11/22/18 6:20 PM, Emil Velikov wrote:
On 2018/11/22, Tapani Pälli wrote:
Fixes issues with following SkQP tests:
unitTest_VulkanHardwareBuffer_Vulkan_EGL_Syncs
unitTest_VulkanHardwareBuffer_Vulkan_Vulkan_Syncs
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_queue.c | 3
Fixes issues with following SkQP tests:
unitTest_VulkanHardwareBuffer_Vulkan_EGL_Syncs
unitTest_VulkanHardwareBuffer_Vulkan_Vulkan_Syncs
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_queue.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan
Hi;
On 11/13/18 4:28 AM, Timothy Arceri wrote:
Sorry for not getting back sooner on this one.
I'm leaning towards a NAK on this one. This is just under 300 new lines
of code to work around a possibly over strict piglit test. While the
test is not wrong an implementation is also not required
matches the spec
Reviewed-by: Tapani Pälli
On 11/13/18 4:10 PM, Lionel Landwerlin wrote:
According to the EGL_EXT_image_dma_buf_import spec, creating an EGL
image with a DRM format not supported should yield the BAD_MATCH
error :
"
* If is EGL_LINUX_DMA_BU
On 11/13/18 1:43 PM, Lionel Landwerlin wrote:
I think this chunk (or the whole patch) should be cherry picked to stable.
Otherwise we get a BAD_ATTRIBUTE error for trying to create an AYUV
EGLImage.
We should have BAD_MATCH instead.
Or should we change the reported error code in places
On 11/6/18 3:01 PM, Lionel Landwerlin wrote:
We could touch the macros in anv_formats.c to include VkFormat in
anv_format if that makes your life easier.
Yep, this makes sense. I'll add VkFormat there.
On 30/10/2018 05:26, Tapani Pälli wrote:
Signed-off-by: Tapani Pälli
---
src/intel
LGTM
Reviewed-by: Tapani Pälli
On 11/8/18 8:23 PM, Lionel Landwerlin wrote:
Signed-off-by: Lionel Landwerlin
---
src/intel/compiler/brw_compiler.h| 1 +
src/intel/compiler/brw_nir.c | 1 +
src/mesa/drivers/dri/i965/brw_wm.c | 6 ++
src/mesa/drivers/dri/i965
'
so 2103 is correct.
Reviewed-by: Tapani Pälli
On 11/8/18 8:23 PM, Lionel Landwerlin wrote:
Signed-off-by: Lionel Landwerlin
---
src/compiler/nir/nir.h | 1 +
src/compiler/nir/nir_lower_tex.c | 36 ++--
2 files changed, 31 insertions(+), 6 deletions
Reviewed-by: Tapani Pälli
On 11/8/18 10:55 PM, Chad Versace wrote:
The warning is emitted when building without INLINE_SSE41.
---
src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965
Thanks, _mesa_has makes things a lot cleaner and simpler to manage;
Reviewed-by: Tapani Pälli
On 11/8/18 2:42 PM, Erik Faye-Lund wrote:
Here's v2 of this series. Changes are as follows:
- 5/13: also check for ARB_occlusion_query2, for core-contexts
- 8/13: also check
Wanted to note that I'm not sure if we need this for Android but if so
we will need and entry in platform_android.c droid_yuv_formats table
too. It looks like there's no matching HAL format, so it would be a new
HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED entry.
On 11/8/18 8:23 PM, Lionel
Reviewed-by: Tapani Pälli
On 11/8/18 8:23 PM, Lionel Landwerlin wrote:
Signed-off-by: Lionel Landwerlin
---
include/GL/internal/dri_interface.h | 2 ++
src/egl/drivers/dri2/egl_dri2.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/include/GL/internal/dri_interface.h
b/include
On 11/8/18 1:02 PM, Tapani Pälli wrote:
On 11/8/18 11:53 AM, Erik Faye-Lund wrote:
On Thu, 2018-11-08 at 10:47 +0200, Tapani Pälli wrote:
On 11/8/18 10:44 AM, Erik Faye-Lund wrote:
On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote:
FYI there's a whole lot of tests that start to fail
On 11/8/18 11:53 AM, Erik Faye-Lund wrote:
On Thu, 2018-11-08 at 10:47 +0200, Tapani Pälli wrote:
On 11/8/18 10:44 AM, Erik Faye-Lund wrote:
On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote:
FYI there's a whole lot of tests that start to fail when this
series
running on Intel CI
On 11/7/18 5:58 PM, Erik Faye-Lund wrote:
ctx->Extensions.EXT_timer_query is set based on the driver-
capabilities, not based on the context type. We need to check against
_mesa_has_EXT_timer_query(ctx) instead to figure out if the extension
is really supported.
This turns usage of
On 11/8/18 10:44 AM, Erik Faye-Lund wrote:
On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote:
FYI there's a whole lot of tests that start to fail when this series
running on Intel CI. It includes dEQP but also Piglit tests, can you
do
Intel CI run or do you want me to send you results
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108636
Reviewed-by: Tapani Pälli
On 11/7/18 10:01 AM, Hanno Böck wrote:
The variable state is free'd and afterwards state->error is used
as the return value, resulting in a use after free bug detected
by memory safety tools like addr
FYI there's a whole lot of tests that start to fail when this series
running on Intel CI. It includes dEQP but also Piglit tests, can you do
Intel CI run or do you want me to send you results?
// Tapani
On 11/7/18 5:58 PM, Erik Faye-Lund wrote:
Here's a bunch of patches for missing error
think? It seems OK to me, and so I'd give this
patch my Reviewed-by, but I want you to be happy with it before we
land anything.
Android team has done full validation round and haven't seen any issues
so it looks we are safe to lift this restriction.
Reviewed-by: Tapani Pälli
diff --git
On 11/6/18 12:31 PM, Lionel Landwerlin wrote:
On 30/10/2018 05:26, Tapani Pälli wrote:
v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB)
v3: properly handle usage bits when creating from image
v4: refactor, code cleanup (Jason)
Signed-off-by: Tapani Pälli
---
src/intel
On 11/6/18 12:07 PM, Lionel Landwerlin wrote:
On 30/10/2018 05:26, Tapani Pälli wrote:
v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB)
v3: properly handle usage bits when creating from image
v4: refactor, code cleanup (Jason)
Signed-off-by: Tapani Pälli
---
src/intel
definitions in place as
anv_entrypoints.h does not include anything.
With this small change, both patches are:
Reviewed-by: Tapani Pälli
#include "isl/isl.h"
#include "common/gen_debug.h"
@@ -3096,14 +3096,6 @@ VkResult anv_image_create(VkDevice _device,
unitTest_VulkanHardwareBuffer_Vulkan_Vulkan_Syncs fail
// Tapani
On 10/30/18 7:25 AM, Tapani Pälli wrote:
Hi;
Here are fixes to earlier series with some refactoring, addressing
Jason's comments and fixing some bugs I found when running Android CTS
suite.
With these changes following
On 11/5/18 8:23 PM, Lionel Landwerlin wrote:
On 30/10/2018 06:26, Tapani Pälli wrote:
const VkPhysicalDeviceExternalImageFormatInfo *external_info = NULL;
VkExternalImageFormatPropertiesKHR *external_props = NULL;
VkSamplerYcbcrConversionImageFormatProperties *ycbcr_props = NULL
Series is
Reviewed-by: Tapani Pälli
On 10/29/18 8:14 PM, Lionel Landwerlin wrote:
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/intel_dump_gpu.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/tools/intel_dump_gpu.in
b/src/intel/tools/intel_dump_gpu.in
index
On 11/1/18 11:59 AM, Erik Faye-Lund wrote:
On Thu, 2018-11-01 at 07:49 +0200, Tapani Pälli wrote:
On 10/31/18 7:03 PM, Ilia Mirkin wrote:
On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund
wrote:
On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote:
I had to do a double (or triple) take
Reviewed-by: Tapani Pälli
This fixes:
dEQP-EGL.functional.get_proc_address.extension.egl_ext_device_base
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108617
On 11/1/18 9:40 AM, mathias.froehl...@gmx.net wrote:
From: Mathias Fröhlich
Hi Emil,
There seems to be a failure
On 10/31/18 7:03 PM, Ilia Mirkin wrote:
On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund
wrote:
On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote:
I had to do a double (or triple) take on this logic as well. Part of
the subtlety is that the fallback only applies for ES when there's a
LGTM, series is:
Reviewed-by: Tapani Pälli
On 10/30/18 7:11 PM, Erik Faye-Lund wrote:
EXT_shader_implicit_conversions is a useful extension that adds implicit
conversions to OpenGL ES 3.1. Since it's tested excensively in dEQP, and
Mesa already has support for implicit conversions, it seems
On 10/30/18 7:11 PM, Erik Faye-Lund wrote:
In GLES, we currently either need an exact match with a local function,
or an exact match with a builtin.
However, if we add support for implicit conversions for GLES shaders,
we also need to fall back to a non-exact match in the case where there
On 10/31/18 7:28 AM, Tapani Pälli wrote:
On 10/31/18 12:57 AM, Timothy Arceri wrote:
On 30/10/18 10:14 pm, Tapani Pälli wrote:
Hi;
On 10/30/18 1:28 AM, Timothy Arceri wrote:
On 29/10/18 10:05 pm, Vadim Shovkoplias wrote:
Hi Timothy,
Thanks for the review. Piglit patch is updated
On 10/31/18 12:57 AM, Timothy Arceri wrote:
On 30/10/18 10:14 pm, Tapani Pälli wrote:
Hi;
On 10/30/18 1:28 AM, Timothy Arceri wrote:
On 29/10/18 10:05 pm, Vadim Shovkoplias wrote:
Hi Timothy,
Thanks for the review. Piglit patch is updated with the additional
out var: https
Hi;
On 10/30/18 1:28 AM, Timothy Arceri wrote:
On 29/10/18 10:05 pm, Vadim Shovkoplias wrote:
Hi Timothy,
Thanks for the review. Piglit patch is updated with the additional out
var: https://patchwork.freedesktop.org/patch/258899/
Original reporter confirmed that issue is finally fixed with
Yeah, this looks correct. I did not realize x86.mk does not have it
since all the targets we use with Celadon have it set.
Reviewed-by: Tapani Pälli
On 10/29/18 1:59 PM, Mauro Rossi wrote:
x86 32 bit generic target does not enable ARCH_X86_HAVE_SSE4_1
for this reason all Android library
On 10/30/18 8:26 AM, Zhaowei Yuan wrote:
Pointer dri2_dpy->driver_name is probably NULL when calling
dri2_display_destory, check this before releasing it.
It's fine for it to be NULL though and it looks like all the drivers set
it correctly, there is no need for such check. Does this change
Reviewed-by: Tapani Pälli
On 10/30/18 2:01 AM, Kenneth Graunke wrote:
Apparently, we're supposed to look at the texture object's built-in
sampler object's sRGB decode setting in order to decide whether to
decode/downsample/re-encode, or simply downsample as-is. Previously,
I had always done
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_extensions.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index ab9240f9fd8..ca414284fdd 100644
--- a/src/intel/vulkan/anv_extensions.py
+++ b/src/intel/vulkan
,
calculate stride correctly for rgb(x) surfaces, rename as
'resolve_ahw_image'
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_android.c | 39
src/intel/vulkan/anv_device.c | 2 +-
src/intel/vulkan/anv_image.c | 108 -
src/intel/vulkan
If external format is used, we store the external format identifier in
conversion to be used later when creating VkImageView.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/intel/vulkan/anv_formats.c b/src
If a conversion struct was passed, then we resolve the format from
conversion structure.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_image.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan
or non-YUV
formats but skip setting up conversion when format does not have
can_ycbcr flag set.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/genX_state.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_sta
v2: add support for non-image buffers (AHARDWAREBUFFER_FORMAT_BLOB)
v3: properly handle usage bits when creating from image
v4: refactor, code cleanup (Jason)
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_android.c | 128 +
src/intel/vulkan/anv_device.c
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 18 ++
src/intel/vulkan/anv_private.h | 3 +++
2 files changed, 21 insertions(+)
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index 1d3b1f67928..166b50f5a07 100644
--- a/src/intel
v2: have separate memory properties for android, set usage
flags for buffers correctly
v3: code cleanup (Jason)
+ limit maxArrayLayers to 1 for AHardwareBuffer based images
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 46 ++
1 file
Use the anv_format address in formats table as implementation-defined
external format identifier for now. When adding YUV format support this
might need to change.
v2: code cleanup (Jason)
v3: set anv_format address as identifier
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_android.c
v2: handle R8G8B8X8 as R8G8B8_UNORM (Jason)
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/vk_format_info.h | 43 +++
1 file changed, 43 insertions(+)
diff --git a/src/intel/vulkan/vk_format_info.h
b/src/intel/vulkan/vk_format_info.h
index a1cc6952c8f
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_android.c | 31 +++
src/intel/vulkan/anv_private.h | 3 +++
2 files changed, 34 insertions(+)
diff --git a/src/intel/vulkan/anv_android.c b/src/intel/vulkan/anv_android.c
index 67e9adee73e..d0a20dd85c5 100644
This makes it cleaner to introduce more cases where we import memory
from different types of external memory buffers.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_device.c | 64 +++
1 file changed, 34 insertions(+), 30 deletions(-)
diff --git a/src/intel
Celadon compatible tree:
https://github.com/tpalli/external-mesa/tree/ahw-android
No regressions spotted by Intel CI. Any comments appreciated!
Tapani Pälli (15):
anv: add create_flags as part of anv_image
anv: refactor make_surface to use data from anv_image
anv: make
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_image.c | 78 ++
src/intel/vulkan/anv_private.h | 5 +++
2 files changed, 46 insertions(+), 37 deletions(-)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index c92e032a239
This will make it possible for next patch to rip
anv_image_create_info out from make_surface function.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_image.c | 1 +
src/intel/vulkan/anv_private.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c b/src
This will be utilized later by GetAndroidHardwareBufferPropertiesANDROID.
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_formats.c | 22 +++---
src/intel/vulkan/anv_private.h | 5 +
2 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/src/intel/vulkan
On 10/27/18 1:32 AM, Timothy Arceri wrote:
On Fri, Oct 12, 2018, at 5:04 AM, Tapani Pälli wrote:
Patch does a 'dry run' of assign_attribute_or_color_locations before
optimizations to catch cases where we have aliasing of unused attributes
which is forbidden by the GLSL ES 3.x specifications
ping
On 10/12/18 3:04 PM, Tapani Pälli wrote:
Patch does a 'dry run' of assign_attribute_or_color_locations before
optimizations to catch cases where we have aliasing of unused attributes
which is forbidden by the GLSL ES 3.x specifications.
We need to run this pass before unused attributes
Reviewed-by: Tapani Pälli
On 10/24/18 1:56 AM, Dylan Baker wrote:
extra_files is just a nice way to to tell certain IDE's (and those
reading the file) that this file is also a dependency. Meson will use
the .d file generated by the compiler to figure out what the target
actually depends
Thanks for fixing these issues;
Reviewed-by: Tapani Pälli
On 10/24/18 1:56 AM, Dylan Baker wrote:
There are two problems with the fixed patch. First, it fails to create a
dependency on the sourced .c file, so changes to intel_tiled_memcpy.c
won't trigger a rebuild. It also doesn't get
of the users verify if 'base
format' is sane this way? If this is the case and there are no regressions;
Reviewed-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/brw_blorp.c | 2 +-
src/mesa/main/glformats.c | 27 ---
src/mesa/main/glformats.h | 3
On 10/22/18 11:47 PM, Matt Turner wrote:
On Mon, Sep 24, 2018 at 4:20 AM Tapani Pälli wrote:
From: Scott D Phillips
Rename the (un)map_gtt functions to (un)map_map (map by
returning a map) and add new functions (un)map_tiled_memcpy that
return a shadow buffer populated
information from program, therefore we re-use existing
pass in linker rather than attempt to write another one.
This fixes WebGL2 test 'gl-bindAttribLocation-aliasing-inactive' and
Piglit test 'gles-3.0-attribute-aliasing'.
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id
On 10/11/18 2:22 PM, Eric Engestrom wrote:
On Thursday, 2018-10-11 08:16:52 +0300, Tapani Pälli wrote:
ping ... this fixes Android build as anv_device.c started to include
"git_sha1.h" but build does not currently pass the path to this header.
I don't know much about the and
ping ... this fixes Android build as anv_device.c started to include
"git_sha1.h" but build does not currently pass the path to this header.
On 10/3/18 1:46 PM, Tapani Pälli wrote:
Fixes: e4538b9 "anv: Implement VK_KHR_driver_properties"
Signed-off-by: Tapani Pä
Reviewed-by: Tapani Pälli
On 10/9/18 7:09 PM, Vadym Shovkoplias wrote:
Adding compile time check for subroutine functions with
the same names. Similar check for intrastage linking was already
landed in commit 5f0567a4f60.
From Section 6.1.2 (Subroutines) of the GLSL 4.00 specification
Reviewed-by: Tapani Pälli
On 10/10/18 1:51 PM, Vadym Shovkoplias wrote:
Also there is no "OpenGL ES Shading Language 4.00" spec,
so change it to GLSL 4.00 spec.
Signed-off-by: Vadym Shovkoplias
---
src/compiler/glsl/linker.cpp | 11 +--
1 file changed, 5 insertions(+), 6
On 10/8/18 9:23 AM, Kenneth Graunke wrote:
On Monday, September 24, 2018 4:19:36 AM PDT Tapani Pälli wrote:
Hi;
Here's another try to inline sse41 code and get rid of gtt maps
in intel_miptree_map (revert 58fb613a519). To be able to safely
utilize sse41 we separate sse41 functionality
Reviewed-by: Tapani Pälli
In the future, please remember update patch version when making changes
and posting patch again, easiest way is to give '-v2' to
git-format-patch and then update commit message with information what
was changed. This will help the review process. Otherwise it may
On 9/17/18 1:43 AM, Lionel Landwerlin wrote:
On 16/09/2018 21:57, Bas Nieuwenhuizen wrote:
On Tue, Sep 11, 2018 at 10:23 PM Lionel Landwerlin
wrote:
This new extension adds an implicitly allocated block of uniforms into
the descriptors sets through a new descriptor type.
We implement this
Fixes: e4538b9 "anv: Implement VK_KHR_driver_properties"
Signed-off-by: Tapani Pälli
---
src/intel/Android.vulkan.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/Android.vulkan.mk b/src/intel/Android.vulkan.mk
index 8dc20149784..03120cf48a0 100644
--- a
ativeTests:
#SingleLayer_ColorTest_GpuColorOutputCpuRead_R8G8B8X8_UNORM
#SingleLayer_ColorTest_GpuColorOutputIsRenderable_R8G8B8X8_UNORM
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/intel_fbo.c | 63 ---
1 file changed, 37 insertions(+), 26 deletions(-)
diff --git
.
Yeah I was considering it could be done by storing some data but it
seems this is probably the most straightforward version.
On Tue, Oct 2, 2018 at 10:02 AM Tapani Pälli <mailto:tapani.pa...@intel.com>> wrote:
On 10/1/18 5:03 PM, Vadym Shovkoplias wrote:
> From Section 6.1.2 (Su
Reviewed-by: Tapani Pälli
On 10/2/18 12:29 PM, Lionel Landwerlin wrote:
Signed-off-by: Lionel Landwerlin
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108120
---
src/intel/tools/error2aub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/tools/error2aub.c b/src/intel
On 10/1/18 5:03 PM, Vadym Shovkoplias wrote:
From Section 6.1.2 (Subroutines) of the GLSL 4.00 specification
"A program will fail to compile or link if any shader
or stage contains two or more functions with the same
name if the name is associated with a subroutine type."
maybe also move the declaration of ret closer to the actual usage in
anv_wait_for_bo_fences?
Reviewed-by: Tapani Pälli
On 9/30/18 9:12 PM, Bas Nieuwenhuizen wrote:
All three are only used in asserts, so this silences release build
warnings.
---
src/intel/vulkan/anv_blorp.c | 3
On 9/26/18 4:46 PM, Jason Ekstrand wrote:
On Wed, Sep 26, 2018 at 8:29 AM Tapani Pälli <mailto:tapani.pa...@intel.com>> wrote:
On 9/26/18 10:46 AM, Jason Ekstrand wrote:
> On Mon, Aug 27, 2018 at 2:22 AM Jason Ekstrand
mailto:ja...@jlekstrand.net>
On 9/26/18 10:46 AM, Jason Ekstrand wrote:
On Mon, Aug 27, 2018 at 2:22 AM Jason Ekstrand <mailto:ja...@jlekstrand.net>> wrote:
On Sun, Aug 26, 2018 at 11:54 PM Tapani Pälli
mailto:tapani.pa...@intel.com>> wrote:
On 08/24/2018 05:04 PM, Jason
v2: check types of both operands (Ian)
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108012
---
src/compiler/glsl/ast_to_hir.cpp | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/compiler/glsl/ast_to_hir.cpp
On 9/24/18 4:38 PM, Ian Romanick wrote:
On 09/24/2018 06:23 AM, Tapani Pälli wrote:
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108012
---
src/compiler/glsl/ast_to_hir.cpp | 5 +
1 file changed, 5 insertions
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108012
---
src/compiler/glsl/ast_to_hir.cpp | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index
Wilson (v5)
Reviewed-by: Kenneth Graunke (v5)
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 110 +-
1 file changed, 106 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965
build support (Tapani)
v4: squash 'fix i915: Fix streaming loads for intel_tiled_memcpy'
separate sse41 to own static library (Tapani)
Reviewed-by: Chris Wilson (v2)
Reviewed-by: Matt Turner (v2)
Acked-by: Kenneth Graunke (v2)
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965
101 - 200 of 2124 matches
Mail list logo
