Re: [Mesa-dev] [PATCH] gallium/util: Don't use __builtin_clrsb in util_last_bit().

On Tue, Feb 3, 2015 at 7:58 PM, Matt Turner matts...@gmail.com wrote: On Tue, Feb 3, 2015 at 6:13 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Tue, Feb 3, 2015 at 2:28 AM, Matt Turner matts...@gmail.com wrote: Unclear circumstances lead to undefined symbols on x86. Bugzilla: https

Re: [Mesa-dev] [PATCH 2/2] nir/validate: Validate that only float ALU outputs are saturated

On Tue, Feb 3, 2015 at 9:43 PM, Jason Ekstrand ja...@jlekstrand.net wrote: --- src/glsl/nir/nir_validate.c | 8 1 file changed, 8 insertions(+) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index 7c801b2..89dfdf8 100644 --- a/src/glsl/nir/nir_validate.c

Re: [Mesa-dev] [PATCH 01/11] mesa: Returns a GL_INVALID_VALUE error on several glGet* APIs when max length is negative

On Tue, Jan 20, 2015 at 3:54 AM, Ian Romanick i...@freedesktop.org wrote: On 01/19/2015 04:35 AM, Erik Faye-Lund wrote: On Mon, Jan 19, 2015 at 1:31 PM, Erik Faye-Lund kusmab...@gmail.com wrote: On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev el...@igalia.com wrote: The manual page

Re: [Mesa-dev] [PATCH 07/11] glsl: error out on empty declarations

On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com So far we have only been emitting a warning. Fixes the following 2 dEQP tests: dEQP-GLES3.functional.shaders.arrays.invalid.empty_declaration_without_var_name_vertex

Re: [Mesa-dev] [PATCH 08/11] glsl: GLSL ES identifiers cannot exceed 1024 characters

On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev el...@igalia.com wrote: From: Iago Toral Quiroga ito...@igalia.com Fixes the following 2 dEQP tests: dEQP-GLES3.functional.shaders.keywords.invalid_identifiers.max_length_vertex

Re: [Mesa-dev] [PATCH 01/11] mesa: Returns a GL_INVALID_VALUE error on several glGet* APIs when max length is negative

On Mon, Jan 19, 2015 at 1:31 PM, Erik Faye-Lund kusmab...@gmail.com wrote: On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev el...@igalia.com wrote: The manual page for glGetAttachedShaders, glGetShaderSource, glGetActiveUniform and glGetActiveUniform state that a GL_INVALID_VALUE

Re: [Mesa-dev] [PATCH 01/11] mesa: Returns a GL_INVALID_VALUE error on several glGet* APIs when max length is negative

On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev el...@igalia.com wrote: The manual page for glGetAttachedShaders, glGetShaderSource, glGetActiveUniform and glGetActiveUniform state that a GL_INVALID_VALUE is returned if the maximum length argument is less than zero. For reference, see:

Re: [Mesa-dev] Expected wide line rendering with clipping

On Mon, Feb 9, 2015 at 12:35 PM, Roland Scheidegger srol...@vmware.com wrote: Am 09.02.2015 um 09:53 schrieb Iago Toral: On Fri, 2015-02-06 at 21:27 +0100, Roland Scheidegger wrote: Am 06.02.2015 um 13:11 schrieb Iago Toral: Hi, Eduardo and I have been looking into a few dEQP test failures

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Layout a 1D miptree horizontally

On Wed, Feb 18, 2015 at 6:02 PM, Ian Romanick i...@freedesktop.org wrote: On 02/17/2015 06:03 AM, Neil Roberts wrote: + /* When this layout is used the horizontal alignment is fixed at 64 and the +* hardware ignores the value given in the surface state +*/ + const unsigned int

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Layout a 1D miptree horizontally

On Thu, Feb 19, 2015 at 1:12 AM, Matt Turner matts...@gmail.com wrote: On Wed, Feb 18, 2015 at 3:34 PM, Erik Faye-Lund kusmab...@gmail.com wrote: On Wed, Feb 18, 2015 at 6:02 PM, Ian Romanick i...@freedesktop.org wrote: On 02/17/2015 06:03 AM, Neil Roberts wrote: + /* When this layout

Re: [Mesa-dev] [PATCH] util: port _mesa_strto[df] to C

On Tue, Mar 17, 2015 at 12:32 AM, Ian Romanick i...@freedesktop.org wrote: On 03/15/2015 12:05 PM, Erik Faye-Lund wrote: _mesa_strtod and _mesa_strtof are only used from the GLSL compiler, It's also used in the ARB_vertex_program / ARB_fragment_program assembler in src/prog. Oh, right

[Mesa-dev] [PATCH] util: port _mesa_strto[df] to C

. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- Because of the recent discussion on libc++ and Mesa, I thought I'd have a look into what parts of mesa depended on libc++, and I spotted this file. In this case, it was rather trivial to port the code to plain C, making it dead obvious

Re: [Mesa-dev] [PATCH] util: port _mesa_strto[df] to C

On Mon, Mar 16, 2015 at 10:13 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 15/03/15 19:05, Erik Faye-Lund wrote: _mesa_strtod and _mesa_strtof are only used from the GLSL compiler, so the locale doesn't need to be initialized before the first context gets initialized. So let's use

Re: [Mesa-dev] [PATCH 2/2] nir: Optimize a + neg(a)

On Sat, Feb 28, 2015 at 9:19 PM, Matt Turner matts...@gmail.com wrote: On Sat, Feb 28, 2015 at 11:47 AM, Thomas Helland thomashellan...@gmail.com wrote: On Feb 28, 2015 8:39 PM, Jason Ekstrand ja...@jlekstrand.net wrote: Both patches are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com

Re: [Mesa-dev] [PATCH 1/8] util: Change hash_table to use quadratic probing.

On Sat, Feb 28, 2015 at 1:53 PM, Thomas Helland thomashellan...@gmail.com wrote: This should give better cache locality, less memory consumption, less code, and should also be faster since we avoid a modulo operation. This is not the quadratic probing function you see most places. They do not

Re: [Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions

On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner matts...@gmail.com wrote: On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul bri...@vmware.com wrote: Should be defined in math.h. If not, we can add them to c99_math.h And FWIW, the MSDN page [0] says that if you define _USE_MATH_DEFINES before

Re: [Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions

On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner matts...@gmail.com wrote: On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul bri...@vmware.com wrote: Should be defined in math.h. If not, we can add them to c99_math.h And FWIW

Re: [Mesa-dev] [PATCH 03/20] SQUASH! whitespace fixes after previous commit

On Thu, Apr 30, 2015 at 1:25 AM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com The title on this one doesn't seem quite right (after previous should probably be before next), but that probably doesn't

Re: [Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

On Mon, May 11, 2015 at 4:57 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, May 11, 2015 at 10:08 AM, Erik Faye-Lund kusmab...@gmail.com wrote: Shouldn't this be like this instead (and make sure ARB_texture_multisample is enabled for ES3.1)? @@ -2756,8 +2756,9

Re: [Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

On Mon, May 11, 2015 at 5:21 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, May 11, 2015 at 11:07 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Mon, May 11, 2015 at 4:57 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, May 11, 2015 at 10:08 AM, Erik Faye-Lund kusmab...@gmail.com

Re: [Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

On Mon, May 11, 2015 at 3:03 PM, Marta Lofstedt marta.lofst...@linux.intel.com wrote: From: Marta Lofstedt marta.lofst...@intel.com GLES 3.1 must be allowed to use multisampled frambuffer textures. Signed-off-by: Marta Lofstedt marta.lofst...@intel.com --- src/mesa/main/fbobject.c | 5

Re: [Mesa-dev] [PATCH 3/6] mesa/es3.1 : Correct error code for zero samples

On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt marta.lofst...@linux.intel.com wrote: From: Marta Lofstedt marta.lofst...@intel.com According to GLES 3.1 CTS test: ES31-CTS.texture_storage_multisample. APIGLTexStorage2DMultisample. multisample_texture_tex_storage_2d_zero_sample- A call to

Re: [Mesa-dev] [PATCH 2/6] mesa/es3.1: Correct error code for illegal internal formats

On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt marta.lofst...@linux.intel.com wrote: From: Marta Lofstedt marta.lofst...@intel.com According to GLES 3.1 CTS test: ES31-CTS.texture_storage_multisample. APIGLTexStorage2DMultisample.

Re: [Mesa-dev] [PATCH 6/6] mesa/es3.1: Fix error code for glCreateShaderProgram

On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt marta.lofst...@linux.intel.com wrote: From: Marta Lofstedt marta.lofst...@intel.com According to the OpenGL ES standard, 7.3. For a call to glCreateShaderProgram with count 0, a GL_INVALID_VALUE error should be generated. OpenGL 4.5 defines

Re: [Mesa-dev] [PATCH 1/6] mesa/es3.1: Do not allow zero size multisampled textures

On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt marta.lofst...@linux.intel.com wrote: From: Marta Lofstedt marta.lofst...@intel.com According to GLES 3.1 CTS test: ES31-CTS.texture_storage_multisample. APIGLTexStorage2DMultisample. multisample_texture_tex_storage_2d_

Re: [Mesa-dev] [PATCH 2/6] mesa/es3.1: Correct error code for illegal internal formats

On Tue, Jun 23, 2015 at 3:11 PM, Erik Faye-Lund kusmab...@gmail.com wrote: On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt marta.lofst...@linux.intel.com wrote: From: Marta Lofstedt marta.lofst...@intel.com According to GLES 3.1 CTS test: ES31-CTS.texture_storage_multisample

Re: [Mesa-dev] [PATCH 4/6] mesa/es3.1 : Correct error code for defect texture target

On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt marta.lofst...@linux.intel.com wrote: From: Marta Lofstedt marta.lofst...@intel.com According to GLES 3.1 CTS test: ES31-CTS.texture_storage_multisample. APIGLGetTexLevelParameterifv. invalid_texture_target_rejected: GL_INVALID_ENUM should be

Re: [Mesa-dev] [PATCH 5/6] mesa/es31: AtomicBufferBindings should be initialized to zero.

On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt marta.lofst...@linux.intel.com wrote: From: Marta Lofstedt marta.lofst...@intel.com Accoring to GLES 3.1 CTS: GLES 3.1 CTS: ES31-CTS.shader_atomic_counters. basic-buffer-bind. AtomicBufferBindings size and start should be initialized to zero.

[Mesa-dev] [PATCH v2 5/7] util: port _mesa_strto[df] to C

of depending on a C++ compiler to initialize at image-load time. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Reviewed-by: Matt Turner matts...@gmail.com --- src/glsl/glcpp/glcpp.c| 3 ++ src/glsl/main.cpp | 3 ++ src/mesa/main/context.c | 3 ++ src/util/Makefile.sources | 2 +- src

[Mesa-dev] [PATCH v2 6/7] mesa/main: free locale at exit

In order to save a small leak if mesa is continously loaded and unloaded, let's free the locale when the shared object is unloaded. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- src/mesa/main/context.c | 12 +++- src/util/strtod.c | 8 src/util/strtod.h | 3

[Mesa-dev] [PATCH v2 7/7] util: assert to verify that locale is initialized

Add an assert to Verify that the locale has been initialized when we call strtod. This might help some developers sleep better at night. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- src/util/strtod.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/util/strtod.c b/src/util

[Mesa-dev] [PATCH v2 4/7] glsl: No need to lock in _mesa_glsl_release_types

This function only gets called while mesa is unloading, so there's no potential of racing or multiple calls at the same time. So let's just get rid of the locking. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- src/glsl/glsl_types.cpp | 8 1 file changed, 4 insertions(+), 4

[Mesa-dev] [PATCH v2 1/7] mesa/main: Get rid of outdated GDB-hack

All of these enums are now in use around in the code, so there's no need to explicitly use them here any more. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- src/mesa/main/context.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/src/mesa/main/context.c b

[Mesa-dev] [PATCH v2 2/7] dri: don't touch the shader compiler

-off-by: Erik Faye-Lund kusmab...@gmail.com --- src/mesa/drivers/dri/common/dri_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index e7ababe..ae4592c 100644 --- a/src/mesa/drivers/dri/common/dri_util.c

[Mesa-dev] [PATCH v2 3/7] mesa/main: only call _mesa_destroy_shader_compiler once on exit

There's no point in calling _mesa_destroy_shader_compiler multiple times on exit; the resources will only be released once anyway. So let's move the atexit-call into the part that is only called once. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- src/mesa/main/context.c | 7 ++- 1

[Mesa-dev] [PATCH v2 0/7] port _mesa_strto[df] to C

of Mesa, and cleaned up a bunch of stuff in that area. And as a result, this time we end up freeing the locale also. No Piglit regressions observed. [1]: 1426446329-23984-1-git-send-email-kusmab...@gmail.com Erik Faye-Lund (7): mesa/main: Get rid of outdated GDB-hack dri: don't touch the shader

Re: [Mesa-dev] [PATCH v2 4/7] glsl: No need to lock in _mesa_glsl_release_types

On Fri, Jun 26, 2015 at 12:29 AM, Matt Turner matts...@gmail.com wrote: On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund kusmab...@gmail.com wrote: This function only gets called while mesa is unloading, so there's no potential of racing or multiple calls at the same time. So let's just get rid

Re: [Mesa-dev] [PATCH v2 5/7] util: port _mesa_strto[df] to C

On Fri, Jun 26, 2015 at 12:44 AM, Matt Turner matts...@gmail.com wrote: On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund kusmab...@gmail.com wrote: _mesa_strtod and _mesa_strtof are only used from the GLSL compiler and the ARB_[vertex|fragment]_program code, meaning that the locale doesn't need

Re: [Mesa-dev] [PATCH v2 6/7] mesa/main: free locale at exit

On Fri, Jun 26, 2015 at 12:36 AM, Matt Turner matts...@gmail.com wrote: On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund kusmab...@gmail.com wrote: In order to save a small leak if mesa is continously loaded and unloaded, let's free the locale when the shared object is unloaded. Signed-off

Re: [Mesa-dev] [RFC shader-db] Add support for shadertoy tests

On Wed, Jun 24, 2015 at 2:18 AM, Rob Clark robdcl...@gmail.com wrote: On Tue, Jun 23, 2015 at 7:27 PM, Dylan Baker baker.dyla...@gmail.com wrote: I have a couple of python pointers for you, feel free to take them or leave them. cool, thanks.. What do others think about including shadertoy

Re: [Mesa-dev] [PATCH v2 0/7] port _mesa_strto[df] to C

On Fri, Jun 26, 2015 at 6:14 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Jun 26, 2015 at 12:03 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 25 June 2015 at 23:10, Matt Turner matts...@gmail.com wrote: On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund kusmab...@gmail.com wrote

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

On Fri, Jun 26, 2015 at 3:05 PM, Davin McCall dav...@davmac.org wrote: On 26/06/15 12:55, Erik Faye-Lund wrote: On Fri, Jun 26, 2015 at 1:23 PM, Davin McCall dav...@davmac.org wrote: On 26/06/15 12:03, Davin McCall wrote: ... The stored value of 'n' is not accessed by any other type than

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

On Fri, Jun 26, 2015 at 4:01 PM, Francisco Jerez curroje...@riseup.net wrote: Davin McCall dav...@davmac.org writes: On 26/06/15 14:31, Eirik Byrkjeflot Anonsen wrote: Erik Faye-Lund kusmab...@gmail.com writes: On Fri, Jun 26, 2015 at 1:23 PM, Davin McCall dav...@davmac.org wrote: On 26/06

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

On Fri, Jun 26, 2015 at 5:25 PM, Francisco Jerez curroje...@riseup.net wrote: Erik Faye-Lund kusmab...@gmail.com writes: On Fri, Jun 26, 2015 at 4:53 PM, Francisco Jerez curroje...@riseup.net wrote: Erik Faye-Lund kusmab...@gmail.com writes: On Fri, Jun 26, 2015 at 4:16 PM, Davin McCall

[Mesa-dev] [PATCH v3 2/6] dri: don't touch the shader compiler

-off-by: Erik Faye-Lund kusmab...@gmail.com Reviewed-by: Matt Turner matts...@gmail.com --- src/mesa/drivers/dri/common/dri_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index e7ababe..ae4592c 100644

[Mesa-dev] [PATCH v3 6/6] mesa/main: free locale at exit

In order to save a small leak if mesa is continously loaded and unloaded, let's free the locale when the shared object is unloaded. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Reviewed-by: Matt Turner matts...@gmail.com --- src/mesa/main/context.c | 12 +++- src/util/strtod.c

Re: [Mesa-dev] [PATCH v2 0/7] port _mesa_strto[df] to C

On Fri, Jun 26, 2015 at 6:03 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 25 June 2015 at 23:10, Matt Turner matts...@gmail.com wrote: On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund kusmab...@gmail.com wrote: Back in March[1], I sent a patch porting _mesa_strto[df] to C rather than C

Re: [Mesa-dev] [PATCH v3 6/6] mesa/main: free locale at exit

On Fri, Jun 26, 2015 at 9:05 PM, Brian Paul bri...@vmware.com wrote: On 06/26/2015 12:06 PM, Erik Faye-Lund wrote: In order to save a small leak if mesa is continously loaded and unloaded, let's free the locale when the shared object is unloaded. Signed-off-by: Erik Faye-Lund kusmab

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

On Thu, Jun 25, 2015 at 1:48 AM, Davin McCall dav...@davmac.org wrote: This is an alternative to my earlier patch [1] (and it is now constructed properly using git format-patch). Quick background: There is a problem in exec_list due to it directly including a trio of 'struct exec_node *'

Re: [Mesa-dev] [PATCH 6/7] mesa: build xmlconfig to a separate static library

On Thu, Jun 11, 2015 at 1:19 AM, Matt Turner matts...@gmail.com wrote: On Wed, Jun 10, 2015 at 3:54 PM, Emil Velikov emil.l.veli...@gmail.com wrote: From: Erik Faye-Lund kusmab...@gmail.com As we use the file from both the dri modules and loader, we end up with multiple definition

[Mesa-dev] [PATCH v4 5/6] util: port _mesa_strto[df] to C

of depending on a C++ compiler to initialize at image-load time. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Reviewed-by: Matt Turner matts...@gmail.com Reviewed-by: Brian Paul bri...@vmware.com --- src/glsl/glcpp/glcpp.c| 3 ++ src/glsl/main.cpp | 3 ++ src/mesa/main/context.c | 3

[Mesa-dev] [PATCH v4 3/6] mesa/main: only call _mesa_destroy_shader_compiler once on exit

There's no point in calling _mesa_destroy_shader_compiler multiple times on exit; the resources will only be released once anyway. So let's move the atexit-call into the part that is only called once. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Reviewed-by: Matt Turner matts...@gmail.com

[Mesa-dev] [PATCH v4 4/6] glsl: No need to lock in _mesa_glsl_release_types

This function only gets called while mesa is unloading, so there's no potential of racing or multiple calls at the same time. So let's just get rid of the locking. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Reviewed-by: Matt Turner matts...@gmail.com Reviewed-by: Brian Paul bri

[Mesa-dev] [PATCH v4 6/6] mesa/main: free locale at exit

In order to save a small leak if mesa is continously loaded and unloaded, let's free the locale when the shared object is unloaded. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Reviewed-by: Matt Turner matts...@gmail.com Reviewed-by: Brian Paul bri...@vmware.com --- src/mesa/main/context.c

[Mesa-dev] [PATCH v4 2/6] dri: don't touch the shader compiler

-off-by: Erik Faye-Lund kusmab...@gmail.com Reviewed-by: Matt Turner matts...@gmail.com Reviewed-by: Brian Paul bri...@vmware.com --- src/mesa/drivers/dri/common/dri_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common

[Mesa-dev] [PATCH v4 1/6] mesa/main: Get rid of outdated GDB-hack

All of these enums are now in use around in the code, so there's no need to explicitly use them here any more. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Reviewed-by: Matt Turner matts...@gmail.com Reviewed-by: Brian Paul bri...@vmware.com --- src/mesa/main/context.c | 27

[Mesa-dev] [PATCH v4 0/6] port _mesa_strto[df] to C

Here's the fourth, and hopefully final version of this series. The only code-change this time is fixing up the definition of one_time_fini to have an explict void argument-list. Erik Faye-Lund (6): mesa/main: Get rid of outdated GDB-hack dri: don't touch the shader compiler mesa/main: only

Re: [Mesa-dev] [PATCH v4 0/6] port _mesa_strto[df] to C

On Mon, Jun 29, 2015 at 6:40 PM, Matt Turner matts...@gmail.com wrote: Thanks! Pushed, and sent a note describing how to fix the problems caused by renaming strtod.cpp - strtod.c. Thanks a lot :) ___ mesa-dev mailing list

[Mesa-dev] [PATCH v2] glsl: add a missing call to _mesa_locale_init

After c61bc6e (util: port _mesa_strto[df] to C), make check fails due to a missing _mesa_locale_init. Fixup this oversight, by moving the stand-alone compiler initializer inside initialize_context_to_defaults(). Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- Here's what the latter

[Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

After c61bc6e (util: port _mesa_strto[df] to C), make check fails due to a missing _mesa_locale_init. Fixup this oversight. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Tested-by: Vinson Lee v...@freedesktop.org --- src/glsl/test.cpp | 4 1 file changed, 4 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

On Thu, Jul 2, 2015 at 2:56 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Jul 2, 2015 at 5:54 PM, Matt Turner matts...@gmail.com wrote: On Thu, Jul 2, 2015 at 2:22 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Can this be done at dlopen/init time? For example what happens if you do static

Re: [Mesa-dev] [PATCH v2] mesa: AtomicBufferBindings should be initialized to zero.

, ctx-Shared-NullBufferObj); - ctx-AtomicBufferBindings[i].Offset = -1; - ctx-AtomicBufferBindings[i].Size = -1; + ctx-AtomicBufferBindings[i].Offset = 0; + ctx-AtomicBufferBindings[i].Size = 0; } } Looks good to me! Reviewed-by: Erik Faye-Lund kusmab...@gmail.com

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

On Fri, Jun 26, 2015 at 1:23 PM, Davin McCall dav...@davmac.org wrote: On 26/06/15 12:03, Davin McCall wrote: ... The stored value of 'n' is not accessed by any other type than the type of n itself. This value is then cast to a different pointer type. You are mistaken if you think that the

Re: [Mesa-dev] [PATCH V2] glsl: fix atomic buffer index for bindings other than 0

On Sat, Jul 25, 2015 at 4:24 PM, Timothy Arceri t_arc...@yahoo.com.au wrote: Since commit c0cd5b var-data.binding was being used as a replacement for atomic buffer index, but they don't have to be the same value they just happen to end up the same when binding is 0. Now we store atomic buffer

[Mesa-dev] [PATCH 2/2] mesa: limit scope of GL 1.0 compatibility shim

OpenGL doesn't expect internalformat={1,2,3,4} to work elsewhere than glTexImage{1,2,3}D, as clearly stated in the spec of glCopyTexImage2D (taken from the OpenGL 1.1 spec, similar wording is present up to OpenGL 3.1 core, where OpenGL 1.0 compatibility was scrapped entirely): Parameters level,

[Mesa-dev] [PATCH 1/2] mesa: only look up base-format once

There's no point in repeatedly looking up the base-format of an internalformat. So let's cache it in a variable instead. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- src/mesa/main/teximage.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/main

Re: [Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes

On Sat, Oct 24, 2015 at 7:08 PM, Rob Clark wrote: > From: Rob Clark > > +#define NIR_PASS_PROGRESS(pass, nir, ...) ({ \ > + assert(nir_shader_is_mutable(nir)); \ > + bool __ret = pass(nir, ##__VA_ARGS__);

Re: [Mesa-dev] [PATCH 2/4] st/dri2: Add shared flag to missing locations

On Thu, Oct 22, 2015 at 10:54 AM, Marek Olšák <mar...@gmail.com> wrote: > On Thu, Oct 22, 2015 at 10:22 AM, Erik Faye-Lund <kusmab...@gmail.com> wrote: >> On Wed, Oct 21, 2015 at 10:34 PM, Marek Olšák <mar...@gmail.com> wrote: >>> On Wed, Oct 21, 2015 at 1

Re: [Mesa-dev] [RFC 10/21] mesa: Remove equality check in helper functions

On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery wrote: > From: Nanley Chery > > Since the version numbers being compared are integral and we don't ever > expect gl_context::Version to be equal to 0, subtract 1 from the rhs of > the equation and

Re: [Mesa-dev] [PATCH 2/4] st/dri2: Add shared flag to missing locations

On Thu, Oct 22, 2015 at 12:18 PM, Marek Olšák <mar...@gmail.com> wrote: > On Thu, Oct 22, 2015 at 10:56 AM, Erik Faye-Lund <kusmab...@gmail.com> wrote: >> On Thu, Oct 22, 2015 at 10:54 AM, Marek Olšák <mar...@gmail.com> wrote: >>> On Thu, Oct 22, 2015

Re: [Mesa-dev] [PATCH 2/4] st/dri2: Add shared flag to missing locations

On Wed, Oct 21, 2015 at 10:34 PM, Marek Olšák wrote: > On Wed, Oct 21, 2015 at 12:28 PM, Axel Davy wrote: >> The PIPE_BIND_SHARED flag should be added whenever >> the resource may be shared with another process. >> >> In particular if the resource is imported,

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery wrote: > From: Nanley Chery > > - { "GL_SUN_multi_draw_arrays", o(dummy_true), > GLL,1999 }, > +#define EXT(name_str, driver_cap,

Re: [Mesa-dev] [RFC 2/2] gallium: add tegra support

On Sun, Oct 11, 2015 at 5:09 PM, Christian Gmeiner wrote: > @@ -2181,6 +2188,13 @@ if test -n "$with_gallium_drivers"; then > done > fi > > +dnl We need to validate some needed dependencies for renderonly drivers. > + > +if test "x$HAVE_GALLIUM_NOUVEAU" != xyes

Re: [Mesa-dev] [PATCH shader-db 1/2] report.py: rework and update for cycle info

On Fri, Oct 2, 2015 at 11:37 PM, Connor Abbott wrote: > Now that we have three separate things we want to measure (instructions, > cycles, and loops), it's impractical to keep adding special code for > changes in each thing. Instead, for each program in before and after we >

Re: [Mesa-dev] [PATCH] mesa: Match MESA_FORMAT_B5G6R5 for a shallow pixel format of GL_RGB

On Wed, Sep 9, 2015 at 12:41 PM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Wed, Sep 09, 2015 at 12:09:40PM +0200, Erik Faye-Lund wrote: >> On Wed, Sep 9, 2015 at 11:25 AM, Chris Wilson <ch...@chris-wilson.co.uk> >> wrote: >> > On Wed, Sep 09, 2015

Re: [Mesa-dev] [PATCH] mesa: Match MESA_FORMAT_B5G6R5 for a shallow pixel format of GL_RGB

On Thu, Sep 3, 2015 at 6:05 PM, Chris Wilson wrote: > If the user supplies a pixel format of GL_RGB + GL_UNSIGNED_SHORT_5_6_5 > and specifies a generic unsized GL_RGB internal format, match that to a > texture format of MESA_FORMAT_B5G6R5 if supported by the hardware. >

Re: [Mesa-dev] [PATCH] mesa: Match MESA_FORMAT_B5G6R5 for a shallow pixel format of GL_RGB

On Wed, Sep 9, 2015 at 11:25 AM, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Wed, Sep 09, 2015 at 11:11:59AM +0200, Erik Faye-Lund wrote: >> On Thu, Sep 3, 2015 at 6:05 PM, Chris Wilson <ch...@chris-wilson.co.uk> >> wrote: >> > If the us

Re: [Mesa-dev] [PATCH] nir: add nir_swizzle

On Thu, Sep 10, 2015 at 10:08 PM, Rob Clark wrote: > From: Rob Clark > > Rather than make yet another copy of channel(), let's move it into nir. > > Signed-off-by: Rob Clark > --- > src/glsl/nir/nir_builder.h

Re: [Mesa-dev] [PATCH] ralloc: Use __attribute__((destructor)) instead of atexit(3)

On Thu, Sep 10, 2015 at 7:58 PM, Ian Romanick wrote: > On 09/10/2015 05:29 AM, Jose Fonseca wrote: >> On 10/09/15 02:54, Ian Romanick wrote: >> >> It's not necessary to do it in several places, at least for the >> destructor -- we could have a single C++ module inside

Re: [Mesa-dev] [PATCH] ralloc: Use __attribute__((destructor)) instead of atexit(3)

On Mon, Sep 7, 2015 at 3:54 PM, Jose Fonseca wrote: > On 07/09/15 10:17, Jean-Sébastien Pédron wrote: >> >> On 04.09.2015 01:37, Matt Turner wrote: >>> >>> You need to test for this support in configure.ac. It's as simple as >>> adding a call to AX_GCC_FUNC_ATTRIBUTE in the

Re: [Mesa-dev] [PATCH 09/11] nir: add lowering stage for user-clip-planes / clipdist

On Tue, Sep 15, 2015 at 6:49 PM, Rob Clark <robdcl...@gmail.com> wrote: > On Tue, Sep 15, 2015 at 12:39 PM, Erik Faye-Lund <kusmab...@gmail.com> wrote: >> On Mon, Sep 14, 2015 at 11:53 AM, Erik Faye-Lund <kusmab...@gmail.com> wrote: >>> On Sun, Sep 13

Re: [Mesa-dev] [PATCH 09/11] nir: add lowering stage for user-clip-planes / clipdist

On Mon, Sep 14, 2015 at 11:53 AM, Erik Faye-Lund <kusmab...@gmail.com> wrote: > On Sun, Sep 13, 2015 at 5:51 PM, Rob Clark <robdcl...@gmail.com> wrote: >> From: Rob Clark <robcl...@freedesktop.org> >> >> The vertex shader lowering adds calculation for CLIPD

Re: [Mesa-dev] [PATCH 09/11] nir: add lowering stage for user-clip-planes / clipdist

On Tue, Sep 15, 2015 at 6:49 PM, Ilia Mirkin wrote: > However having a piglit test that covers this would be neat... I guess > you could clip a pixel in half and make sure that the resolved result > is some in-between color? Lots of implementation-dependent stuff going > on

Re: [Mesa-dev] [PATCH 09/11] nir: add lowering stage for user-clip-planes / clipdist

On Tue, Sep 15, 2015 at 6:49 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Tue, Sep 15, 2015 at 12:39 PM, Erik Faye-Lund <kusmab...@gmail.com> wrote: >> On Mon, Sep 14, 2015 at 11:53 AM, Erik Faye-Lund <kusmab...@gmail.com> wrote: >>> On Sun, Sep 13

Re: [Mesa-dev] [PATCH 09/11] nir: add lowering stage for user-clip-planes / clipdist

On Tue, Sep 15, 2015 at 7:12 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Tue, Sep 15, 2015 at 1:09 PM, Erik Faye-Lund <kusmab...@gmail.com> wrote: >> On Tue, Sep 15, 2015 at 6:49 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >>> However having a piglit

Re: [Mesa-dev] [PATCH] Revert "mesa/extensions: restrict GL_OES_EGL_image to GLES"

On Wed, Sep 16, 2015 at 11:00 PM, Dave Airlie wrote: > This reverts commit 48961fa3ba37999a6f8fd812458b735e39604a95. > I also don't have a copy of this patch in my mail archive, which > seems wierd, did it get posted to mesa-dev? The same applies to 8200793 ("mesa/teximage:

Re: [Mesa-dev] [PATCH] Revert "mesa/extensions: restrict GL_OES_EGL_image to GLES"

On Thu, Sep 17, 2015 at 11:15 AM, Erik Faye-Lund <kusmab...@gmail.com> wrote: > On Wed, Sep 16, 2015 at 11:00 PM, Dave Airlie <airl...@gmail.com> wrote: >> This reverts commit 48961fa3ba37999a6f8fd812458b735e39604a95. > >> I also don't have a copy of this patch in m

Re: [Mesa-dev] Compile error in nir/nir_builder.h in current head

On Thu, Sep 17, 2015 at 3:27 PM, Emil Velikov wrote: > Hi Gottfried, > > On 17 September 2015 at 13:42, Gottfried Haider > wrote: >> I am getting this error on 7e286506 - comping mesa used to work fine >> on this system a couple of weeks ago

Re: [Mesa-dev] [PATCH 09/11] nir: add lowering stage for user-clip-planes / clipdist

On Sun, Sep 13, 2015 at 5:51 PM, Rob Clark wrote: > From: Rob Clark > > The vertex shader lowering adds calculation for CLIPDIST, if needed > (ie. user-clip-planes), and the frag shader lowering adds conditional > kills based on CLIPDIST value

Re: [Mesa-dev] Question: st/mesa and context-shareable shaders

On Mon, Sep 28, 2015 at 4:39 PM, Roland Scheidegger wrote: > > In short, for simplicity, only things were sharable which were really > required to be shared (pretty much just actual resources - and yes that > doesn't work too well for GL neither as you can't share sampler/rt >

Re: [Mesa-dev] [PATCH 2/2] st/mesa: try PIPE_BIND_RENDER_TARGET when choosing float texture formats

On Tue, Sep 29, 2015 at 7:50 PM, Brian Paul wrote: > > I was actually thinking of expanding this change to cover _all_ color formats > but wanted to take a small step first. What do you think? > I have some patches in this area sitting around here:

Re: [Mesa-dev] [PATCH v2] Add .mailmap

On Thu, Dec 17, 2015 at 10:09 AM, Giuseppe Bilotta wrote: > +# missing svn authors: I'm not sure this is useful, but just for kicks, I decided to try to track down these contributors, and this is what I came up with (suspected contributors CC'ed, so they can confirm

Re: [Mesa-dev] [PATCH v2] Add .mailmap

On Thu, Dec 17, 2015 at 10:39 AM, Erik Faye-Lund <kusmab...@gmail.com> wrote: > On Thu, Dec 17, 2015 at 10:09 AM, Giuseppe Bilotta > <giuseppe.bilo...@gmail.com> wrote: >> +# missing svn authors: > > I'm not sure this is useful, but just for kicks, I

[Mesa-dev] [PATCH 2/2] main: get rid of needless conditional

We already check if the driver changed the completeness, we don't need to duplicate that check. Let's just early out there instead. Signed-off-by: Erik Faye-Lund <kusmab...@gmail.com> --- src/mesa/main/fbobject.c | 25 - 1 file changed, 12 insertions(+), 13 del

[Mesa-dev] [PATCH 1/2] gallium/util: removed unused header-file

This hasn't been in use since c476305 ("gallium/util: pregenerate half float tables"), where the last bit of run-time init using this was killed. So let's just get rid of the pointless header. Signed-off-by: Erik Faye-Lund <kusmab...@gmail.com> --- src/gallium/auxiliary/Makef

[Mesa-dev] [PATCH 0/2] trivial cleanups

Here's some trivial cleanups I found while diving into something else. Instead of them collecting dust in my tree, perhaps we could apply them to the central tree? Erik Faye-Lund (2): gallium/util: removed unused header-file main: get rid of needless conditional src/gallium/auxiliary

Re: [Mesa-dev] [PATCH v5] Add .mailmap

On Mon, Dec 28, 2015 at 12:23 PM, wrote: > Should I be expecting to see myself on here? > Only if you have commits in mesa.git attributed to you using the same name but different e-mail addresses... ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH v2] Add .mailmap

On Tue, Dec 22, 2015 at 12:47 PM, Thomas Tanner <tan...@gmx.net> wrote: > Hi, > my primary email address for open source contributions is tan...@gmx.net > cheers > OK, I think Giuseppe will want this info for his final version of the patch (CC'ed), thanks :) > On 17.12.15

Re: [Mesa-dev] [PATCH 0/2] trivial cleanups

On Mon, Jan 11, 2016 at 11:50 PM, Timothy Arceri <t_arc...@yahoo.com.au> wrote: > On Mon, 2016-01-11 at 16:35 +0100, Erik Faye-Lund wrote: >> Ping? >> > > The other patch is also now > Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> > > I tak

Re: [Mesa-dev] [PATCH 08/18] meta/blit: Don't pollute the sampler object namespace in _mesa_meta_setup_sampler

On Tue, Jan 12, 2016 at 5:44 PM, Ian Romanick <i...@freedesktop.org> wrote: > On 01/12/2016 01:36 AM, Erik Faye-Lund wrote: >> On Sat, Jan 9, 2016 at 3:59 AM, Ian Romanick <i...@freedesktop.org> wrote: >>> From: Ian Romanick <ian.d.roman...@intel.com> >>&g

<    1   2   3   4   5   6   7   8   >