Re: [Mesa3d-dev] How do we init half float tables?

2010-04-03 Thread Jose Fonseca
, 2010 1:48 To: Jose Fonseca Cc: mesa3d-...@lists.sf.net Subject: Re: [Mesa3d-dev] How do we init half float tables? The s3tc-teximage test seems fixed by the two line change I put in gallium-util-format-is-supported. s3tc-texsubimage prints: Mesa: User error: GL_INVALID_VALUE in glTexSubImage2D

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-03 Thread Luca Barbieri
They are not passing for me with current master and a 32-bit system: Here are the failures: Testing util_format_dxt1_rgb_pack_8unorm ... FAILED: f2 d7 90 20 ae 2c 6f 97 obtained f2 d7 b0 20 ae 2c 6f 97 expected Testing util_format_dxt5_rgba_pack_8unorm ... FAILED: f7 10 c5 0c 9a 73 b4

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-03 Thread Luca Barbieri
For instance, the DXT1 test is wrong. The red values used are: 33 93 153 214 99 - 33 = 60 153 - 93 = 60 214 - 153 = 61 213 should be used instead (i.e. 0xd5 instead 0xd6) -- Download Intel#174; Parallel Studio Eval Try

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Jose Fonseca
2:17 To: Brian Paul Cc: mesa3d-dev@lists.sourceforge.net Subject: Re: [Mesa3d-dev] How do we init half float tables? Are you sure about this? I've tried doing it, and it turns out that basically every Gallium module needs this initialized. For instance: st/mesa due to glReadPixels vg/mesa due

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Brian Paul
Luca Barbieri wrote: On Fri, Apr 2, 2010 at 9:51 AM, Jose Fonseca jfons...@vmware.com wrote: Reliability goes both ways: using a global constructor simplifies the problem substantially, but it is only as reliable as the global constructor mechanism itself -- which it's not much given the

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Roland Scheidegger
On 02.04.2010 17:09, Luca Barbieri wrote: Additionally, the S3TC library may now support only a subset of the formats. This may be even more useful as further compressed formats are added. FWIW, I don't see any new s3tc formats. rgtc will not be handled by s3tc library since it isn't patent

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Luca Barbieri
FWIW, I don't see any new s3tc formats. rgtc will not be handled by s3tc library since it isn't patent encumbered. util_format_is_s3tc will not include rgtc formats. (Though I guess that external decoding per-pixel is really rather lame, should do it per-block...) Yes the other formats (rgtc

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Luca Barbieri
So far, there are no dependencies on Gallium in core Mesa. We've talked about refactoring some of the Gallium code into a separate module that'd be sharable between Gallium and Mesa.  The format code would probably fit into that. Can't we just unconditionally pull gallium/auxiliary in Mesa?

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Jose Fonseca
From: luca.barbi...@gmail.com [luca.barbi...@gmail.com] On Behalf Of Luca Barbieri [l...@luca-barbieri.com] Sent: Friday, April 02, 2010 16:09 To: Jose Fonseca Cc: Brian Paul; mesa3d-dev@lists.sourceforge.net Subject: Re: [Mesa3d-dev] How do we init half float tables? On Fri, Apr 2, 2010 at 9:51

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Luca Barbieri
What are you seeing a regression on? texcompress and texcompsub seemed to work for me: I'll try to test something else and recheck the code. -- Download Intel#174; Parallel Studio Eval Try the new software tools for

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Luca Barbieri
Sorry for the regression. This whole thing was done to fix the u_gctors.cpp issue, originally done by me, sent out without full testing since I saw duplicate work being done, and then merged by Roland if I recall correctly. I probably should not have fixed s3tc/util_format like it was done for

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Jose Fonseca
0:50 To: Jose Fonseca Cc: Brian Paul; mesa3d-dev@lists.sourceforge.net Subject: Re: [Mesa3d-dev] How do we init half float tables? What are you seeing a regression on? texcompress and texcompsub seemed to work for me: I'll try to test something else and recheck the code

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Jose Fonseca
@lists.sourceforge.net Subject: Re: [Mesa3d-dev] How do we init half float tables? On 02.04.2010 17:09, Luca Barbieri wrote: Additionally, the S3TC library may now support only a subset of the formats. This may be even more useful as further compressed formats are added. FWIW, I don't see any new s3tc

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Luca Barbieri
One more thing: I'm maintaining the u_format* modules. I'm not speaking the just in the long term, but in the sense I'm actually working on this as we speak.  Please do not make this kind of deep reaching changes to the u_format stuff in master without clearing them first with me. Yes

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Jose Fonseca
-barbieri.com] Sent: Saturday, April 03, 2010 1:08 To: Jose Fonseca Cc: Brian Paul; mesa3d-dev@lists.sourceforge.net Subject: Re: [Mesa3d-dev] How do we init half float tables? Sorry for the regression. This whole thing was done to fix the u_gctors.cpp issue, originally done by me, sent out without full

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Jose Fonseca
Subject: Re: [Mesa3d-dev] How do we init half float tables? One more thing: I'm maintaining the u_format* modules. I'm not speaking the just in the long term, but in the sense I'm actually working on this as we speak. Please do not make this kind of deep reaching changes to the u_format stuff

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-02 Thread Luca Barbieri
The s3tc-teximage test seems fixed by the two line change I put in gallium-util-format-is-supported. s3tc-texsubimage prints: Mesa: User error: GL_INVALID_VALUE in glTexSubImage2D(xoffset+width) Probe at (285,12) Expected: 1.00 0.00 0.00 Observed: 0.00 0.00 0.00 which

[Mesa3d-dev] How do we init half float tables?

2010-04-01 Thread Luca Barbieri
The half float conversion code initially used a global C++ constructor to initialize the tables. That fails to work since ld does not get the symbol from the shared library, so I changed to use register a global constructor from C, using GCC- or MSVC-specific code. This is not necessarily the

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-01 Thread Brian Paul
On Thu, Apr 1, 2010 at 4:29 PM, Luca Barbieri l...@luca-barbieri.com wrote: The half float conversion code initially used a global C++ constructor to initialize the tables. That fails to work since ld does not get the symbol from the shared library, so I changed to use register a global

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-01 Thread Luca Barbieri
OK. I'd like to add that u_atomic.h already requires either GCC, MSVC or Solaris, and GCC and MSVC are already supported by this system. Thus we do indeed now have a simple way to do global constructors, that only removes support for non-GCC Solaris until someone figures out how to do that. And

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-01 Thread Luca Barbieri
Are you sure about this? I've tried doing it, and it turns out that basically every Gallium module needs this initialized. For instance: st/mesa due to glReadPixels vg/mesa due to vgReadPixels st/python due to mesa sampling several programs in rbug to dump textures to disk softpipe due to

Re: [Mesa3d-dev] How do we init half float tables?

2010-04-01 Thread Corbin Simpson
On Thu, Apr 1, 2010 at 6:17 PM, Luca Barbieri l...@luca-barbieri.com wrote: Are you sure about this? I've tried doing it, and it turns out that basically every Gallium module needs this initialized. For instance: st/mesa due to glReadPixels vg/mesa due to vgReadPixels st/python due to