namely i had a bad feeling about this. we should not be implementing
escape_html to begin with, the functionality should all be in apache.
(...)
The main point in this case: someone decided to escape (double
quote) in escape_html. For HTML, ' (single quote) is practically
equivalent (and can
some of us on modperl-dev had a discussion with Doug recently about
expanding Apache::Util::escape_html() to do things like HTML::Entities
(such as high-bit characters) and it was decided it was a bad idea.
see:
http://marc.theaimsgroup.com/?l=apache-modperl-cvsm=101708056429561w=2
and
Your patch seems to me to be partially wrong (you missed similar
addition a few lines above, while calculating the destination
size).
Erm, yeah, so I see, now that you mention it.
And this patch version seem to be correct
(oh, maybe someone could consider also adding some test case to
(oh, maybe someone could consider also adding some test case to
t/net/perl/util.pl but it does not seem to be very important)
tests are always important :)
I'm think that, with mod_perl 2.0, mod_perl 1.x might not be high on
maintainer's list of stuff to do
sorry, but I haven't been
* Geoffrey Young [EMAIL PROTECTED] [2002-11-11 13:16]:
(oh, maybe someone could consider also adding some test case to
t/net/perl/util.pl but it does not seem to be very important)
tests are always important :)
I'm think that, with mod_perl 2.0, mod_perl 1.x might not be high on
Two patches, one for t/net/util.pl and one for src/modules/perl/Util.xs.
Apply them from the root of the untarred source.
cool, thanks.
you know, the test compares the results of Apache::Util::escape_html()
to HTML::Entities::encode, both of which do not translate ' into apos
by default.
* Marcin Kasperski [EMAIL PROTECTED] [2002-11-08 17:33]:
darren chamberlain [EMAIL PROTECTED] writes:
* Marcin Kasperski [EMAIL PROTECTED] [2002-11-08 16:22]:
I use Apache::Util::escape_html to perform fast HTML-escaping of the
data before displaying it. Unfortunately, this function
I use Apache::Util::escape_html to perform fast HTML-escaping of the
data before displaying it. Unfortunately, this function handles
, , and but does not handle ' (single quote) - which
can be escaped as apos;
It would be nice if apos was handled. After all, in HTML file it is
almost
* Marcin Kasperski [EMAIL PROTECTED] [2002-11-08 16:22]:
I use Apache::Util::escape_html to perform fast HTML-escaping of the
data before displaying it. Unfortunately, this function handles
, , and but does not handle ' (single quote) - which
can be escaped as apos;
Hey, this is an easy
darren chamberlain [EMAIL PROTECTED] writes:
* Marcin Kasperski [EMAIL PROTECTED] [2002-11-08 16:22]:
I use Apache::Util::escape_html to perform fast HTML-escaping of the
data before displaying it. Unfortunately, this function handles
, , and but does not handle ' (single quote) - which
10 matches
Mail list logo
