Re: Adding to legal_options_for_inheritance

2009-11-03 Thread Tuomas Jormola
On Mon, Nov 02, 2009 at 09:31:52PM -0600, Jesse Luehrs wrote: On Mon, Nov 02, 2009 at 08:54:04PM -0600, Jesse Luehrs wrote: Maybe this is another point in favor of dropping the whole legal options concept in general? perigrin on IRC pointed out that we've been thinking about replacing the

Was the attribute set in the constructor?

2009-11-03 Thread Ovid
When parsing documents, if my code finds more than one title in a document, it's an error because we don't know which title is needed. The user should be able to override this in the constructor and provide their own title (this is actually true for several attributes): my $parser =

Re: Was the attribute set in the constructor?

2009-11-03 Thread Hans Dieter Pearcey
Excerpts from Ovid's message of Tue Nov 03 11:01:12 -0500 2009: When parsing documents, if my code finds more than one title in a document, it's an error because we don't know which title is needed. The user should be able to override this in the constructor and provide their own title

Re: Was the attribute set in the constructor?

2009-11-03 Thread Evan Carroll
On Tue, Nov 3, 2009 at 10:01 AM, Ovid publiustemp-catal...@yahoo.com wrote: When parsing documents, if my code finds more than one title in a document, it's an error because we don't know which title is needed. The user should be able to override this in the constructor and provide their own

Re: Was the attribute set in the constructor?

2009-11-03 Thread Hans Dieter Pearcey
Excerpts from Evan Carroll's message of Tue Nov 03 11:38:47 -0500 2009: On Tue, Nov 3, 2009 at 10:01 AM, Ovid publiustemp-catal...@yahoo.com wrote: When parsing documents, if my code finds more than one title in a document, it's an error because we don't know which title is needed. The user

Re: Was the attribute set in the constructor?

2009-11-03 Thread Evan Carroll
This might be preferable to my suggestion if your object's methods are being called mid-parse, rather than building up a data structure first and setting attributes based on it after parsing is done.  Even then, I think I'd rather have a separate method than modify the accessor. Yea that was

Re: Was the attribute set in the constructor?

2009-11-03 Thread Hans Dieter Pearcey
Excerpts from Evan Carroll's message of Tue Nov 03 11:55:04 -0500 2009: has 'attribute' = ( isa = 'Str', is = 'rw', predicate = 'has_attribute' ); around 'attribute' = sub { my ($next, $this, $key) = @_; if ( $key ) { $self-has_attribute ? die 'exception' : $this-$next($key); }

Re: Adding to legal_options_for_inheritance

2009-11-03 Thread Tuomas Jormola
On Tue, Nov 03, 2009 at 10:30:41AM +0200, Tuomas Jormola wrote: On Mon, Nov 02, 2009 at 09:31:52PM -0600, Jesse Luehrs wrote: On Mon, Nov 02, 2009 at 08:54:04PM -0600, Jesse Luehrs wrote: Maybe this is another point in favor of dropping the whole legal options concept in general?

Re: Was the attribute set in the constructor?

2009-11-03 Thread Jesse Luehrs
On Tue, Nov 03, 2009 at 11:09:19AM -0600, Evan Carroll wrote: around 'attribute' = sub { my ($next, $this, $key) = @_; unless ( $this-meta-get_attribute('attribute')-has_init_arg ) { if ( $key ) { $self-has_attribute ? die 'exception' :

doc bug

2009-11-03 Thread Evan Carroll
In the docs I see this for Moose::Meta::Attribute ## EXCERPT get_value set_value eval { $point-meta-get_attribute('x')-set_value($point, 'forty-two') }; if($@) { print Oops: $...@\n; } Attribute (x) does not pass the type constraint (Int) with 'forty-two'

Re: doc bug

2009-11-03 Thread Jesse Luehrs
On Tue, Nov 03, 2009 at 05:21:12PM -0600, Evan Carroll wrote: perl -Moose -e'has q[format_feed]= ( isa = Str, is = ro ); print Class-new-meta-get_attribute(q[format_feed])-get_value()' get_value and set_value both require the instance as the first argument, as pointed out in the docs for