Hi,
This behavior has been introduced in MPD 0.14: When MPD returns an empty
value, it doesn't mean that the tag is empty but that the tag is unknown
(not set in the music file). As a client developer I find this behavior very
useful for example if you want to build a tree like this:
The Doors
11 other patches available on my repository:
Add unit tests to libmpclient
Fix glib include
Change include guards
Convert MPD_INFO_ENTITY_ to enum
Fix currentsong test
Cosmetic
Improve calls to mpd_executeCommand
Small performance improvements
- I saw that your idle patch introduced inconsistent indentation
(e.g. mpd_glibStartIdle); please configure your editor to indent
with tabs.
I don't want to start a 'religion war' on this point but don't you think it
would be better to use spaces everywhere instead of tabs?
This discussion
Hi,
There are some commits on my repository that you may find interesting to
integrate.
Marc Pavot:
Use tabs instead of spaces
Split libmpdclient: status
Set local includes first for idle.c
Split libmpdclient: stats
Merge branch 'master' of git://git.musicpd.org
- portability - even Windows? There's no good C99 compiler on
Windows.. mingw32?
Just a quick remark about this point: I compile Ario and libmpdclient on
windows with mingw32 and it works fine. (I distribute .exe files for Ario).
Some of you already promised to help me with that. From now on, I
will accept patches (git pull requests preferred). Please keep your
git repository rebased on mine.
I have created a git repository to help you on this project:
http://repo.or.cz/w/libmpdclient/marc.git
It is based on your
but with this bug the elapsed time
continues to be incremented on a new song.
I propose a patch to MPD to fix this issue but I don't really know this part
of MPD so it may not be the best solution.
Marc
2008/11/23 Marc Pavot [EMAIL PROTECTED]
Hi,
Thanks, I have merged your patch. Please
Hi,
Thanks, I have merged your patch. Please write a patch which adds
documentation for that feature to doc/protocol.xml.
Done.
I also attach a patch to libmpdclient that can be used as a basis for the
discussion on 'idle' implementation on client side.
Main points about this
Hi,
- It adds the possibility to choose which notification you want to
receive.
The idle command can now take no argument (same behavior as before) or
several arguments.
For example if a client uses command 'idle mixer elapsed', it will only
receive notifications when the volume changed
Hi,
This new patch replaces the previous one. It adds the possibility to send
the new value in a notification.
For example, if the volume changes to 85, MPD sends 'changed: mixer 85'.
Marc
2008/11/16 Marc Pavot [EMAIL PROTECTED]
Hi,
I propose you a patch that improves different aspects
Hi,
I propose you a patch that improves different aspects of idle command:
- It adds a new 'elapsed' event to notify clients when the elapsed time has
changed (in absolute value in second)
- It adds the possibility to choose which notification you want to receive.
The idle command can now take no
in any other events.
See my previous response to Marc in this thread:
On 2008/11/14 09:01, Max Kellermann [EMAIL PROTECTED] wrote:
On 2008/11/13 21:45, Marc Pavot [EMAIL PROTECTED] wrote:
- you cannot subscribe to receive only some of the notifications
Sounds like a reasonable feature
Hi
Why not? The client can let the connection block until something
happens, or it can abort idle as soon as he wishes to use the
connection for something else. That is simple, but powerful.
As already proposed by someone else, a publish-subscribe protocol would be
much more appropriate
13 matches
Mail list logo
