On Tue, Aug 23, 2016 at 11:04:57AM +0200, Eike Rathke wrote:
> On Monday, 2016-08-22 20:17:14 -0700, Kevin J. McCarthy wrote:
>
> > Please everyone, don't be shy to let me know if you think this is a
> > stupid change.
>
> Well, I think removing the $locale
ated, and delete it in e.g. 1.9.
I'd appreciate more feedback/discussion and ideas from others about this
change.
One interesting thing Derek just mentioned is a conditional based on
version. I know there is an ifdef patch, which sort of helps, but
without an "else" doesn't comple
On Wed, Aug 24, 2016 at 02:37:30AM +0200, Vincent Lefevre wrote:
> On 2016-08-23 11:06:22 -0700, Kevin J. McCarthy wrote:
> > I think even keeping a $locale alias is still better with the changes
> > made. $locale no longer affects the index or various other output, so
> &g
an tell, we always
> need socket libs now, hence I removed the entire conditional.
Thanks for the patch Fabian, I'll take a look at this soon.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
Thanks for the heads-up and details Oswald and Antonio. Unfortunately
some personal family issues have drastically reduced my time available
last and the next few weeks, but I will put this at the top of my list
to look into.
Oswald, if you have time to work on the patch, of course that
, I don't mean to dump these on you. I'll take care of merges and
> pushes. I just want to get these in front of mutt-dev one last time
> before I do.
It's wonderful to see your patches coming in, David!
I will take a look as I can, but don't let me block these getting in
ew code.
Just to note, this is not technically true. A very large chunk of Mutt
code mixes tabs/whitespace. It's true that I have tabs turned off and
so don't have them in my patches, but I don't believe we have a firm
policy on this.
--
Kevin J. McCarthy
GPG Fingerprint: 897
rewrite everything. And lastly, please consider how you
present yourself on the #mutt channel: talking trash about the code
there just makes you sound immature (at least to me).
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
alias_reverse_lookup (a)
> + ((a->mailbox && patmatch (pat, a->mailbox) == 0) ||
!patmatch (pat, a->mailbox))
(since you changed it below, just for symmetry)
> + (match_personal && a->personal && !patmatch (pat, a->personal)
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
avoid a segfault on an empty mailbox.
You probably also want a CHECK_VISIBLE since it doesn't make sense to do
this on a selected but invisible message.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Thu, Sep 01, 2016 at 06:32:25PM -0500, Derek Martin wrote:
> On Thu, Sep 01, 2016 at 04:07:48PM -0700, Kevin J. McCarthy wrote:
> > alias_reverse_lookup (a)
>
> Blech. I know Mutt tries to conform to GNU C coding standards, but
> I've
bed24edc754
> When $flag_safe is set, flagged messages cannot be deleted.
>
> This saves them from bulk operations on threads and tagged messages. To
> remove a flagged message, first unflag it.
Looks good to me.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF
On Sun, Sep 04, 2016 at 01:53:27PM +0200, Fabian Groffen wrote:
> On 31-08-2016 09:13:37 -0700, Kevin J. McCarthy wrote:
> > On Mon, Aug 29, 2016 at 11:24:13AM +0200, Fabian Groffen wrote:
> > > While trying to compile Mutt on Solaris, I found that since
> > &g
cpy(work, tmp->data, sizeof(work));
> +len = strlen(work);
> + work[len++] = '=';
> +mutt_extract_token (tmp, s, 0);
> +strncpy(&work[len], tmp->data, sizeof(work)-len);
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
ted than it sounds, as we'd have to handle changing
mailboxes in places where this might not make sense. I think the index
and pager are probably the only places set up to do this.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
where we
lose data, then perhaps we should be allocating the string instead.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
to rip it out, though.
Vincent, Derek, what do you think?
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
Hi Everyone,
My schedule (and life) has been pretty turbulent recently, but I'm back
home now. I'll start going through tickets, emails, and patches soon.
Thanks everyone for your understanding.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684
, as I forgot IMAP
keeps the context around and what was before a noop will now try to
access a NULL mx_ops.
I've expanded the patch to check for a NULL mx_ops in other functions
and will commit it shortly.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 80
. Is this documented/expected behavior?
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
me valid "mbox" folders but are not. Notably old
> versions of Mailman do this, making archive files that cannot be read by
> mutt.
>
> This patch causes mutt to skip leading NLs and CRs when detecting magic.
Looks fine to me. It may be worth adding a brief comment in the
heck to the
if (oldcount && check != MUTT_REOPENED
&& ((Sort & SORT_MASK) == SORT_THREADS))
if statement that allocates it.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
subst token */
> +++p;
> + for (i = pmatch[n].rm_so; (i < pmatch[n].rm_eo) && (tlen <
> LONG_STRING-1); i++)
> + dst[tlen++] = src[i];
> + }
> + }
> + else
> + dst[tlen++] = *p++;
This should be
On Tue, Aug 30, 2016 at 05:58:17PM -0700, d...@bikeshed.us wrote:
> Add subjectrx command to replace matching subjects with something else.
Looks good to me.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
ct there...
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Sat, Sep 24, 2016 at 04:13:19PM -0700, Kevin J. McCarthy wrote:
> The first is general. Mutt uses fixed size buffers for a lot of things,
> but I think this might be one of the cases where we don't want to use a
> LONG_STRING fixed length buffer. I realize this makes the
> im
*hdr, char *new)
{
if (hdr == NULL)
return 0;
if (mutt_strcmp (hdr->env->x_label, new) == 0)
return 0;
mutt_str_replace (&hdr->env->xlabel, new);
return hdr->changed = hdr->xlabel_changed = 1;
}
> diff --git a/pager.c b/pager.c
> --- a/pager.c
>
2b8596bc3ad6
> Add reentrant hash_walk() function for iterating down a hash table.
Looks fine to me.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
;s a bit odd having those hash tables exposed and
maintained where they are. That's just my opinion though! :-)
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Tue, Aug 30, 2016 at 06:03:58PM -0700, d...@bikeshed.us wrote:
> add pointer check in hash_destroy()
Looks fine to me.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Tue, Aug 30, 2016 at 06:18:37PM -0700, d...@bikeshed.us wrote:
> Permit tab completion of pattern expressions with ~y (labels).
Looks okay, but the indendation is all goofed up.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.
This behavior mutt justified, or should create the patch,
> which will mutt work with unicode characters?
The issue when forwarding should probably be fixed in mutt_copy_body().
We create the sanitized tempfile, but don't try to preserve the original
filename in d_filename. I'll take
On Sun, Oct 02, 2016 at 04:46:44PM -0700, Kevin J. McCarthy wrote:
> On Sun, Oct 02, 2016 at 08:43:38PM +0500, Konstantin Ovsov wrote:
> > The function mutt_sanitize_filename (char * f, short slash) (from
> > lib.c) which forms a "safe" file name, i.e. it replaces all non-
on that it needed to be in 1.7.1.
Thank you.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
em.
By the way, the upcoming 1.7.1 release will be off of the stable
branch. I'll hold off commiting your translation updates until we can
figure out this issue.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Tue, Oct 04, 2016 at 02:31:58PM -0700, Kevin J. McCarthy wrote:
> On Tue, Oct 04, 2016 at 10:38:57PM +0200, Petr Pisar wrote:
> > When I was updating po/mutt.pot locally, I noticed the sidebar messages
> > (e.g.
> > "move the highlight to next mailbox") get rem
n't hesitate to speak up, but I don't
see a security issue here.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Wed, Oct 05, 2016 at 09:45:53PM +0200, Petr Pisar wrote:
> On Tue, Oct 04, 2016 at 03:19:55PM -0700, Kevin J. McCarthy wrote:
> > What happens if you rm keymap_alldefs.h and then rerun 'cd po;make
> > mutt.pot'?
> >
> That's it. I updated sources from hg
level for
mutt_socket_write_d(), as above. If it's non-null, pop_query_d() logs
that message *instead* and bumps the mutt_socket_write_d() dbg parameter
higher.
So this hunk has actually removed the ability to log the actual pass
command even at level 4.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Tue, Oct 11, 2016 at 09:32:51AM -0400, Damien Riegel wrote:
> On Mon, Oct 10, 2016 at 07:10:30PM -0700, Kevin J. McCarthy wrote:
> > What is happening is that if the debuglevel is less than 5, it *instead*
> > prints the above message.
>
> Maybe you disagree, but I t
ution are you running?
The patch also changes library checking for libtinfo, and at least on
Debian there is no libtinfow.
Would any distribution packagers care to comment?
Thanks!
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Descrip
dering
removing the tinfo changes and just pushing up the "test" fix and the
search for ncurses.h in the top-level include dir for ncursesw.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
clang-format and wondered how I
felt about it. If anyone has comments about this tool, or a suggested
better tool, please speak up.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
tt-standard".
>
> I've rebased that code to the latest default (45023e44c92c - Define PATH_MAX)
>
> Tree:
> https://github.com/neomutt/neomutt/tree/devel/compress
> Patch:
> https://github.com/neomutt/neomutt/commit/e969f0d.patch
Excellent, thanks.
ng a (very lightly tested) patch based on top of yours.
What do you think?
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
# HG changeset patch
# User Kevin McCarthy
# Date 1478379979 25200
# Sat Nov 05 14:06:19 2016 -0700
# Node ID 7834
Change check_mailbox to delegate to the child_ops->check_mailbox if
the compressed mailbox has changed. This allows the mailbox to
properly recover if both the decompressed mailbox and compressed file
have changed.
Change sync_mailbox to call check_mailbox before attempting to sync.
This will pre
setup_paths leaks memory: realpath is already set in mx_open_mailbox()
restore_paths is unneeded. mx_fastclose_mailbox() will free stuff,
and nothing is looking at the path once we are closing or aborting.
Make a copy of the hooks. Otherwise 'unhook *' will leave dangling
pointers.
Add compres
Change compress.sync_mailbox() to lock the compressed mailbox around
both the tempfile sync and compress operations. This will prevent
changes made inbetween the two syncs from being overwritten.
# HG changeset patch
# User Kevin McCarthy
# Date 1478734909 28800
# Wed Nov 09 15:41:49 2016
Some operations, such as open_append and sync, need an exclusive lock
across a longer period than a single compress/decompress. Remove it
from the execute_command and pull into the outer callers. Store lock
information inside compress_info.
Sync and check_mailbox need more fixes, which will be a
Also, include compress.h in compress.c so the mx_comp_ops doesn't need
to be redeclared.
# HG changeset patch
# User Kevin McCarthy
# Date 1478734906 28800
# Wed Nov 09 15:41:46 2016 -0800
# Node ID 6d7f9d97d0c00656d4f546a35c3774e7a46f7ccd
# Parent f2cb736bcb7af5109de1f0ef007835f62a62c6d8
The open_append and close were partially duplicating mbox open_append
and close operations internally. Change it to call the actual
delegate functions instead.
Inline the open_read() function inside open_mailbox(). Having it
split improved nothing and just complicated the code (i.e. added
error-
Move the muttrc to contrib, and add it to the Makefile.am so it is
distributed.
Remove the vimrc sample, it's not relevant.
# HG changeset patch
# User Kevin McCarthy
# Date 1478734907 28800
# Wed Nov 09 15:41:47 2016 -0800
# Node ID cd0918ebda17a496378823ea7fd1d2675c270e89
# Parent 6d7f9
Patch subject is complete summary.
# HG changeset patch
# User Kevin McCarthy
# Date 1478734908 28800
# Wed Nov 09 15:41:48 2016 -0800
# Node ID 7186fdb54bdd233846c47818b264ff753ed3fdbd
# Parent b08235dfc7855189252702449b298d58a0b1dec6
Compress: safe_fopen() the tempfile, to prevent tempfi
The format strings are placed in single quotes. mutt_system() invokes
sh, so escape the single quotes using bourne-shell syntax: '\''
# HG changeset patch
# User Kevin McCarthy
# Date 1478734910 28800
# Wed Nov 09 15:41:50 2016 -0800
# Node ID d3d59df8a6906f40693f4861ac5ce6df22cf0754
# Par
I'm sending this out a bit early, as I need some more time to test it more
thoroughly.
This bundle of patches is the NeoMutt compressed folder patch plus a
set of changes/fixes I've made to improve it (hopefully without
breaking too much).
Patch 01 is the original neomutt patch, except that I tr
Patch subject is complete summary.
# HG changeset patch
# User Kevin McCarthy
# Date 1478734907 28800
# Wed Nov 09 15:41:47 2016 -0800
# Node ID 326fac112b39ddfde430e80a6ee58fed74c0b9e0
# Parent cd0918ebda17a496378823ea7fd1d2675c270e89
Compress: remove extra fluff from manual.
diff --git
This was too big, so I'm resending it compressed.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
01-neomutt-compress.patch.gz
Description: application/gunzip
signature.asc
Description: PGP signature
This one seems to have gotten lost in the first patchbomb. Resending
it.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
# HG changeset patch
# User Kevin McCarthy
# Date 1478734907 28800
# Wed Nov 09 15:41:47 2016 -0800
# Node ID
nstead?
If neither of the first two are possible, I think this is reasonable
compromise. We have a --disable-doc function, so a problem building
makedoc can be worked around. I'd appreciate others input on the issue
though.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
decided to push anyway.
Should muttbug.sh.in use $XDG_CONFIG_HOME and fall back to .config if
that is unset?
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Thu, Nov 10, 2016 at 10:28:48AM -0800, Kevin J. McCarthy wrote:
> On Wed, Nov 09, 2016 at 10:44:07PM +0100, Evgeni Golov wrote:
> If neither of the first two are possible, I think this is reasonable
> compromise. We have a --disable-doc function, so a problem building
> makedoc c
27;s patches in first.
>
> Yeah, no worries. I don't think there is any hurry here. Just a bit of
> aid for ppl who want to bootstrap new archs and use mutt there (who
> wouln't?).
>
> Shall we create a track ticket to track this effort?
A ticket sounds like a good idea.
On Tue, Nov 15, 2016 at 01:29:15PM +, Andras Salamon wrote:
> On 2016-11-14 18:08:24 -0800, Kevin J. McCarthy wrote:
> > On Mon, Nov 14, 2016 at 11:59:35PM +0100, Evgeni Golov wrote:
> > > > For md5, we can use a built-in, or even just use perl's Digest::MD5.
>
is change seems incorrect if MUTT_VERSION contains the % character.
> Ditto for the other similar changes.
Thanks Vincent, I completely missed that problem. I will back out that
part of the patch when I have some more time, probably tomorrow.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
same scope behavior as "!" or "^": inside of a
pattern modifier, it is treated normally.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
>if (access (buffer, F_OK) == 0)
> return safe_strdup(buffer);
> }
Sorry, I think I turned my brain off during the backout, and forgot to
turn it back on when I made this change.
I have no idea what I thought I was doing here, but I will put
mutt_find_cfg() back the way it was, and quit for the night!
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
tic/error-style-guide.html
That's a nice starting point. Despite being a native English speaker,
my language skills are really quite poor. If this is something someone
would like to take on, I would be grateful.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
e macro.
It's easy to add it to the MENU_MAIN instead. Do you think it should
also be added to the pager?
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Fri, Nov 18, 2016 at 09:45:51AM -0800, Kevin J. McCarthy wrote:
> It's easy to add it to the MENU_MAIN instead. Do you think it should
> also be added to the pager?
Answering my own question: no. Inside the pager, the operation
searches for text in the message. I suppose we co
plication fail that went unnoticed as the
> documentation moved around. I'll make a fix unless someone else does.
If you have time, that would be great. Thanks, David.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
erences
header? What about the domain part - should we be idn encoding that
part if $idn_encode is set?
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Sun, Nov 20, 2016 at 10:08:13AM +1100, Cameron Simpson wrote:
> On 19Nov2016 13:13, Kevin J. McCarthy wrote:
> > Should mutt be rfc-2047 encoding/decoding the references
> > header?
>
> No. RFC2047 tokens need to be whitespace delimited from the surrounding
> text. No
.
Thanks Claus and Vincent, for the interesting discussion and the
commit-fix. Something was telling me NULL was incorrect, when I typed
it. Now I know what to use in the future!
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Wed, Nov 23, 2016 at 07:20:06PM +0100, Olaf Hering wrote:
> On Thu, Jun 16, Kevin J. McCarthy wrote:
> > Thank you for the patches. I'm going to apply patch 1 and 2, but I'd
> > like to think about 3, 4, and 5.
> >
> > With $mail_check_stats set, buffy w
tt
is already doing the right thing in this case. It should not attempt to
somehow encode the utf-8 character in the left-side of the references
msg-id when sending.
On the other side, a received illegally rfc2047-encoded references
msg-id should not be decoded before attempting to interpret it.
ry-picking these into the stable branch:
84ad86e8b8ab Fix build failure with GPGME 1.8
695243ba6374 More openssl1.1 fixes
821022f6c78c Fix openssl 1.1 compilation issues.
If there are any other commits to default you think should be in 1.7.2,
please let me know.
Thank you.
--
Kevin J. Mc
, spool, normal. I know this change might piss some people
off, but I'd rather just make the change than add this option. Richard,
how do you feel?
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
h the trade-off. However, I am still
willing to hear other's opinions on this. I'll hold off on committing
this until next weekend, and am even willing to revert 1196c859942e if
other mutt developers voice an opinion against.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910
to see the files[] inside of mutt_find_sys_cfg(), instead of
exposed like that.
Quickly commenting on the other patches here. In patch 2, you shouldn't
move the overwrite of AliasFile after you have sourced the system
muttrc. I'm not crazy about either patches 3 and 4, but will think
about them.
ing ^ and
trailing $, and using \\. instead of .).
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
, reset, and set.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
# HG changeset patch
# User Kevin McCarthy
# Date 1481685423 28800
# Tue Dec 13 19:17:03 2016 -0800
# Node ID eb09bb75f18345bf9550c25cf32041343df486fe
# Parent
Make to_chars and status_chars accept mulitibyte characters. (closes
#3024)
Change Tochars and StChars to use the mbchars_table type introduced in
the last patch.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
# HG changeset patch
# User Kevin McCarthy
patch
converts to_chars and status_chars over.
I'm posting this for early review. I'm tired and need to take a closer
look at the patches when I'm fresh tomorrow, but welcome feedback!
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.
und a
new appreciation of the wonders of electricity and heat. :-)
I'm back online now, but have a great deal of clean up to take care of
around the house and property, so I don't expect to be able to pay
attention to mutt until next week.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3
On Sun, Dec 25, 2016 at 10:14:56PM +0100, Vincent Lefevre wrote:
> On 2016-12-08 16:21:47 -0800, Kevin J. McCarthy wrote:
> > On Thu, Dec 08, 2016 at 05:30:35PM +0100, Vincent Lefevre wrote:
> > > The hangs is due to this big Cc and the "subscribe" / "l
On Wed, Dec 28, 2016 at 04:03:41PM -0800, Kevin J. McCarthy wrote:
> I'm attaching a "general idea" patch. This is <10 minutes of work,
> absolutely incomplete, without comments, etc etc
Whoops, I forgot I initially set the cache->list to be a single bit.
I've cha
On Mon, Jan 09, 2017 at 11:11:31PM +0100, Simon Ruderich wrote:
> Noticed a few minor issues in the man page while trying to change
> the color of error messages.
Pushed. Thank you for the patches!
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 803
g them
perfect, but more code reviewers is always appreciated.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
v
may have some ideas. Can anyone think what the reason might be for
preferring the From address in the case?
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
sense
> in documentation rather than code.
Thank you Vincent and David, your explanations make sense to me. I'll
make a patch to change this later today.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
to allow me to use
> folder-hooks to change the replacements in use.
I've just committed parent, but haven't overlooked this patch. Will
mostly likely get to it tomorrow.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Sat, Sep 24, 2016 at 06:33:11PM -0700, Kevin J. McCarthy wrote:
> On Tue, Aug 30, 2016 at 05:59:07PM -0700, d...@bikeshed.us wrote:
> > Adds mailboxrx (and unmailboxrx) command.
>
> The implementation looks fine, but I'll echo what Aaron said:
> mutt_pretty_mailbox is
try to address any issues people might raise, if any.
Thanks Fabian,
This was actually next on my list after I finish up with David's
patches. I appreciate you bundling this up and sending it to the list!
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
e
cleanup you did, I went through the effort because I planned to anyway.
You and your developers have the right to fork the code and have fun
tearing it apart, but I didn't spend the last four years working my way
up the Mutt development team just to spend all my time henceforth
reviewing giant
ch isn't built into vanilla mutt. You may want to pose your
question to the mutt-kz or neomutt mailing lists.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
you have
> the NeoMutt version in mind because you reference ctx?
>
> Revised patch attached.
I've pushed this up, with some additional fixes in a separate patch.
Please let me know if I bungled anything.
Thanks again for posting this to the list.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
On Fri, Jan 27, 2017 at 10:27:13AM -0800, Kevin J. McCarthy wrote:
> On Fri, Jan 27, 2017 at 12:07:19PM +, Richard Russon wrote:
> > > > Please find attached a patch against current Mutt tip to add LMDB
> >
> > > This was actually next on my list
> > >
et those things done, I'll push it
out, but right now let's plan for starting the freeze on 2/13.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
uilt-in verification routines using
SSL_set_verify().
When you upgraded to 1.7.2, was this a vanilla mutt version?
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
m a bit confused.
--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
501 - 600 of 1170 matches
Mail list logo
