From: John Bäckstrand <[EMAIL PROTECTED]>
Date: Fri, 05 Aug 2005 17:53:11 +0200
> KERNEL: assertion (cnt <= tp->packets_out) failed at
> net/ipv4/tcp_input.c (1476)
I suspect this is a side effect of some changes Herbert Xu and
myself did to fix some other bugs.
Herbert, I think there are serio
Simply do the pci_save_state before the register_netdev()
call, no need to mess around with the locking.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Daniel Phillips <[EMAIL PROTECTED]>
Date: Sat, 6 Aug 2005 04:52:07 +1000
> So then there is no choice but to throttle the per-cpu ->input_pkt queues.
Make the driver support NAPI if you want device fairness.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body o
All pulled, as well as your dccp-2.6.14 tree, into net-2.6.14
It should show up on the kernel.org mirrors shortly.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Can you guys stop peeing your pants over this, put aside
your differences, and work on a mutually acceptable fix
for these bugs?
Much appreciated, thanks :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at h
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
Date: Sat, 6 Aug 2005 10:01:05 -0300
> + /* Be more specific, e.g. net-pf-2-132-1
> (net-pf-PF_INET-IPPROTO_SCTP-SOCK_STREAM) */
> + if (++try_loading_module == 1)
> + request_mo
Michael, I've added all 6 patches to my net-2.6.14 tree.
It should show up on the kernel.org GIT mirrors shortly.
I decided against sticking this into 2.6.13, as these changes
can introduce regressions and the space of users effected by
this problem is decidedly small compared to how many could b
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Sat, 6 Aug 2005 17:57:17 +1000
> Hang on a second, the original poster mentioned rc5. Is this really
> pristine rc5 with the one netpoll patch? If so then it can't be the
> patches we're talking about because they only went in days later.
This seems to
From: Harald Welte <[EMAIL PROTECTED]>
Date: Mon, 8 Aug 2005 00:39:34 +0200
> [NETFILTER] move conntrack helper buffers from BSS to kmalloc()ed memory
Patch applied, thanks :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More m
From: Harald Welte <[EMAIL PROTECTED]>
Date: Mon, 8 Aug 2005 11:50:55 +0200
> DaveM is probably travelling back from UKUUG at the moment and therefore
> wasn't able to push this fix to you.
I'm actually back and operational as of this morning :-)
I'll push this stuff to Linus later today. So Li
mbers.
NETLINK_ARPD is unused, allocate it to the Open-iSCSI folks.
NETLINK_ROUTE6 and NETLINK_TAPBASE are no longer used, delete
them.
Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
diff --git a/include/linux/netlink.h b/include/linux/netlink.h
--- a/include/linux/netlink.h
+++
We have an icky situation in this area. Harald is right,
I think.
I'd suggest that Arnaldo fixes up his af_inet.c changes
so that it uses "net-pf-*" like the rest of the tree
does.
Arnaldo, I pulled in your net-2.6.14 tree earlier today,
so please send me a patch on-top of that.
Thanks.
-
To u
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon, 08 Aug 2005 23:19:37 +0200
> David S. Miller wrote:
> > So we can increase MAX_LINKS to 256 and that's what I think I will do
> > for 2.6.14 unless there is a very serious objection. The tables sized
> >
From: Peter Hagervall <[EMAIL PROTECTED]>
Date: Tue, 9 Aug 2005 01:09:40 +0200
> - { 0 },
> + { "" },
It wanst NULL, not an empty string.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.k
From: Harald Welte <[EMAIL PROTECTED]>
Date: Mon, 8 Aug 2005 19:03:05 +0200
> [NETFILTER] more verbose return codes from nf_{log,queue}
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.ke
From: Harald Welte <[EMAIL PROTECTED]>
Date: Mon, 8 Aug 2005 15:24:13 +0200
> [NETFILTER] add correct bridging support to nfnetlink_{queue,log}
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http:/
From: Harald Welte <[EMAIL PROTECTED]>
Date: Mon, 8 Aug 2005 19:04:31 +0200
> [NETFILTER] check nf_log function call arguments
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/
From: Harald Welte <[EMAIL PROTECTED]>
Date: Mon, 8 Aug 2005 22:05:59 +0200
> [NETFILTER] return ENOMEM when ip_conntrack_alloc() fails.
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.k
From: Robert Olsson <[EMAIL PROTECTED]>
Date: Mon, 8 Aug 2005 15:38:00 +0200
> A fixed patch is below. Dave IMO it can be applied now.
Applied to net-2.6.14, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo in
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Mon, 08 Aug 2005 17:35:05 -0700
> I ACK all the other changes.
Ok, please make the changes Michael and myself have
noted and send the updated patch so I can add it to
the net tree.
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe
From: Harald Welte <[EMAIL PROTECTED]>
Subject: [PATCH] untracked fix now in Linus' tree, but not in net-2.6.14
Date: Tue, 9 Aug 2005 09:26:12 +0200
> Hi Dave, please apply the untracked fix (that has been adopted by Linus
> for 2.6.13) to your net-2.6.14 tree. Thanks!
It will show up there when
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
Date: Tue, 9 Aug 2005 16:19:52 -0300
> [INET] Request module protocol strings
>
> Changed the syntax to:
>
> nf-pf--proto--type-
>
> Matching the one in netlink, as pointed out by Harald.
>
> Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PRO
From: Robert Olsson <[EMAIL PROTECTED]>
Date: Mon, 8 Aug 2005 15:58:28 +0200
> Dave IMO it can be appiled.
>
> Signed-off-by: Robert Olsson <[EMAIL PROTECTED]>
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Done.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
t
From: Robert Olsson <[EMAIL PROTECTED]>
Date: Mon, 8 Aug 2005 16:01:23 +0200
> Stephen Hemminger writes:
> > Use const where possible and get rid of EXTRACT() macro
> > that was never used.
...
> Signed-off-by: Robert Olsson <[EMAIL PROTECTED]>
>
> > Signed-off-by: Stephen Hemmigner <[EMAIL
From: Scott Bardone <[EMAIL PROTECTED]>
Date: Tue, 02 Aug 2005 22:01:22 -0700
> @@ -735,6 +737,9 @@
> ssize_t res;
> struct sock *sk = sock->sk;
>
> + if (sk->sk_prot->sendpage)
> + return sk->sk_prot->sendpage(sk, page, offset, size, flags);
> +
This doesn't make an
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
Date: Tue, 9 Aug 2005 19:15:44 -0300
> Please consider pulling from:
>
> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
Pulled, thanks Arnaldo.
I took the opportunity to fix up all the u64 printf
format string warn
I pushed a bunch of bluetooth updates into my net-2.6.14
tree, and in there you will find the change to make
the bluetooth stack not use skb->pkt_type in the funny
way it used to.
This opens up the possibility to shrink it's size.
Just FYI...
-
To unsubscribe from this list: send the line "unsub
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
Date: Tue, 9 Aug 2005 21:07:50 -0300
> Please consider pulling from:
>
> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
Pulled, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body
I want some net bug fixes in Linus's tree to propagate into the
net-2.6.14 tree so I plan to rebase it this evening, so please be
careful when sync'ing with my tree over the next day.
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PR
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
Date: Tue, 9 Aug 2005 23:12:24 -0300
> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
All 3 patches hand applied into my rebased net-2.6.14 tree.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the b
From: Steven Whitehouse <[EMAIL PROTECTED]>
Date: Wed, 10 Aug 2005 15:45:55 +0100
> Below is the patch I mentioned at UKUUG, its against an older kernel but
> it still applies when I tried it against 2.6.12 just now,
Applied, thanks Steven.
-
To unsubscribe from this list: send the line "unsubscr
From: Benjamin LaHaise <[EMAIL PROTECTED]>
Date: Wed, 10 Aug 2005 12:46:55 -0400
> Please consider the patch below which makes use of file->private_data to
> store the pointer to the socket, which avoids touching several unused
> cachelines in the dentry and inode in sockfd_lookup.
Please repor
From: Benjamin LaHaise <[EMAIL PROTECTED]>
Date: Wed, 10 Aug 2005 17:17:37 -0400
> Here is a resend properly signed off.
Applied to net-2.6.14, thanks Ben.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at htt
From: Peter Hagervall <[EMAIL PROTECTED]>
Date: Tue, 9 Aug 2005 09:49:10 +0200
> This patch contains the following possible cleanups/fixes:
Applied to net-2.6.14, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordo
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 07:55:36 +1000
> Here is a patch that adjusts fackets_out accordingly.
And what's more the original code there modifying packets_out
looks wrong.
I think I'm going to push this in for 2.6.13.
-
To unsubscribe from this list: send the li
From: Harald Welte <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 18:44:30 +0200
> On Tue, Aug 09, 2005 at 06:23:33PM -0700, David S. Miller wrote:
> > I want some net bug fixes in Linus's tree to propagate into the
> > net-2.6.14 tree so I plan to rebase it this evening
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 13:22:58 -0400
> Personally, I -hope- it's a merge.
It's not, I absolutely do not want those ugly branches in my
tree history just because I felt like rebasing. I want
a clean tree, and also it gives me the opportunity to combine
bug f
From: Hal Rosenstock <[EMAIL PROTECTED]>
Date: 11 Aug 2005 14:48:37 -0400
> The patch below is to accomodate IPoIB link layer address in the
> sockaddr_ll struct so that user space can send and receive IPoIB link
> later packets. Unfortunately, IPoIB has 20 bytes LL addresses rather
> than the 8 b
From: "Vladimir B. Savkin" <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 15:48:36 +0400
> Today my gateway crashed.
Known problem, please try Linus's current tree as we've
made a bug fix since -rc5 that we think fixes this bug.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
t
From: Harald Welte <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 09:12:43 +0200
> [NETFILTER] Fix compilation when no PROC_FS enabled
>
> Signed-off-by: Harald Welte <[EMAIL PROTECTED]>
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL P
From: Harald Welte <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 09:13:21 +0200
> [NETFILTER] Fix NF_QUEUE_NR() macro
>
> I obviously wanted to use bitwise-or, not logical or.
>
> Signed-off-by: Harald Welte <[EMAIL PROTECTED]>
Applied.
-
To unsubscribe from this list: send the line "unsubscribe n
From: Harald Welte <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 22:03:49 +0200
> +struct ipt_connbytes_info
> +{
> + struct {
> + u_int64_t from; /* count to be matched */
> + u_int64_t to; /* count to be matched */
> + } count;
> + u_int8_t what; /* ip
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 07:46:55 +1000
> Actually, these two versions are different. & is higher than | so
> Harald's version is actually
>
> #define NF_QUEUE_NR(x) (((x << NF_VERDICT_QBITS) & NF_VERDICT_QMASK) |
> NF_QUEUE)
>
> Which is it?
It's the forme
From: Alexey Dobriyan <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 19:49:48 +0400
> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
Applied, but I may defer this to 2.6.14, we'll see.
Also, please properly "-p1" root your patch next time.
> --- linux.orig/linux-sparse/include/linux/skbuff.h
From: "Leonid Grossman" <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 19:05:22 -0400
> Basically, it looks like with SuperTSO most of the traffic in our tests
> comes down to the driver with mss 0 (TSO is mostly "off").
> With the original TSO, is was always "on" (see below).
> Could you describe how
From: Dmitry Yusupov <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 16:30:49 -0700
> But even with new TSO schema, this logic can not send more than
> MAX_SKB_FRAGS which at best case ~60K. With old TSO schema.
> I thought with SuperTSO we could send >> than 60K. And than it could be
> very beneficial
From: Scott Bardone <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 23:16:14 -0700
> - static was removed from functions '__tcp_inherit_port' & '__tcp_v4_hash'
> because these are called outside of tcp_ipv4.c from the TOM driver.
There is no way you're going to be allowed to call such deep TCP
intern
From: Harald Welte <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 17:37:30 +0200
> But getting back to the original connbytes issue. Is it worth fixing
> it, if the core iptables doesn't even work (the "old bug")?
I think it is a good policy to not let in new code, regardless of
context, which uses
From: Dimitris Michailidis <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 10:22:47 -0700
> This is true. There is nothing fundamentally preventing both passive
> and active opens to check netfilter before OKing a connection. Once a
> connection is established, it's rather impractical to run each of
From: "Leonid Grossman" <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 14:04:47 -0400
> Why the total length has to be in the header, there may be other
> ways to pass the total TSO length to the driver?
Because the packet has to look like a legal IPV4 frame
for the rest of the networking stack, for
From: Dimitris Michailidis <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 10:00:12 -0700
> On 8/12/05, David S. Miller <[EMAIL PROTECTED]> wrote:
> > This would mean that every time we wish to change the data structures
> > and interfaces for TCP socket lookup, your drive
From: Ralf Baechle <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 11:38:15 +0100
> NET/ROM uses virtual interfaces so setting a queue length is wrong.
>
> Signed-off-by: Ralf Baechle DL5RB <[EMAIL PROTECTED]>
Applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
Date: Fri, 12 Aug 2005 13:17:36 -0300
> Just checked:
>
> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
>
> Has the reworked, not touching selinux tree
We might have to reneg on changing things from tcpdiag
to inetdiag,
From: Harald Welte <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 21:03:43 +0200
> Ok, I hope everyone is fine with this patch:
It is, but I did not add the connbytes patch into my tree so I can't
use this patch as-is. That's why I replied "this is broken, fix u64
alignment" to the connbytes patch i
From: James Morris <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 15:00:49 -0400 (EDT)
> On Fri, 12 Aug 2005, Arnaldo Carvalho de Melo wrote:
>
> > > Let me think about this over the weekend before we commit
> > > to doing things one way or the other.
> >
> > Take your time but as far as I understoo
From: Kyle Moffett <[EMAIL PROTECTED]>
Date: Wed, 27 Jul 2005 22:44:00 -0400
> I would like to propose a cleanup for struct sockaddr_in that I think
> will make the code much more obvious and remove some icky padding
> math:
We can't use anonymous unions in the kernel, because they are not
suppor
From: Jon Wetzel <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 15:52:28 -0500
> Adds a new field to net device to hold the permanent hardware
> address, and adds a new generic ethtool_op function to get that
> address.
>
> Signed-off-by: Jon Wetzel <[EMAIL PROTECTED]>
> Signed-off-by: John W. Linvill
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed, 10 Aug 2005 02:18:46 +0200
> BTW, an idea to make room for ipvs_property would be to place the three
> nfctinfo bits in the lower three bits of the nfct pointer. I'm not sure
> if it guarantees 8 byte alignemnt, which would be required for this
From: Patrick McHardy <[EMAIL PROTECTED]>
Subject: Re: [PATCH] add new iptables ipt_connbytes match
Date: Sat, 13 Aug 2005 03:20:06 +0200
> Harald Welte wrote:
> > Just send two incremental patches to Dave.
>
> Here they are. The first patch fixes the div64_64 function, the second
> one renames s
From: Harald Welte <[EMAIL PROTECTED]>
Date: Sat, 13 Aug 2005 16:51:57 +0200
> Ok, just in case Dave was waiting for my comments (which are usually
> not required since Patricks patches tend to have a higher quality than
> mine):
>
> ACK-ed-by: Harald Welte <[EMAIL PROTECTED]>
I like to see ACK
From: Harald Welte <[EMAIL PROTECTED]>
Date: Sat, 13 Aug 2005 18:06:21 +0200
> TSO can only happen for locally-generated packets, am I right?
That is correct.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Sat, 13 Aug 2005 11:32:39 +1000
> I actually had a play with the fast clone stuff. However, eventually
> I gave up because of this dilemma: I needed to either introduce an extra
> atomic op on the __kfree_skb path, or add bloat to the inlined kfree_skb
>
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sat, 13 Aug 2005 04:25:08 +0200
> I just wanted to make the patch to break compilation for
> unconverted code for the skb->stamp change and noticed that
> the patch is missing from your latest net-2.6.14 tree. Is
> this deliberate or did it get lost?
Thanks for posting this Patrick. I'll review this when I'm at
home instead of at an internet cafe up in the mountains with dodgy
wireless access :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vge
From: Harald Welte <[EMAIL PROTECTED]>
Date: Sat, 13 Aug 2005 16:50:23 +0200
> So for new development, I'm now more inclined to push things sooner to
> you - even more for code that only adds new featurss. If you generally
> dislike that, please let me know.
I think this is the way to go.
-
To un
From: Harald Welte <[EMAIL PROTECTED]>
Date: Sat, 13 Aug 2005 17:46:19 +0200
> [NETFILTER] Add new iptables "connbytes" match
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/m
From: Harald Welte <[EMAIL PROTECTED]>
Date: Sat, 13 Aug 2005 17:45:34 +0200
> [NETFILTER] introduce and use aligned_u64 data type
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.
From: Tommy Christensen <[EMAIL PROTECTED]>
Subject: Re: skb->pkt_type
Date: Sun, 14 Aug 2005 00:20:28 +0200
> David S. Miller wrote:
> > Here is the current patch. It dies on the destruction of the
> > first TCP socket, while pruning the write queue of the socket,
> &
From: Bernd Eckenfels <[EMAIL PROTECTED]>
Date: Sun, 14 Aug 2005 19:51:39 +0200
> I have this error report on ifconfig (also a problem with ip link) that a
> down interface receives packets. I remeber this was discussed before but
> cannot find a result of the outcome. Is this a driver problem?
B
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Sun, 14 Aug 2005 02:31:30 +0200
> The disadvantage is that we cannot do "clone resycling" easly
> anymore, that is we allow a fast-clone'able skb to be cloned
> up again if the clone portion was already freed.
I do not see much value in that capability
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 09:52:51 +1000
> 1) When you allocate for fast clones you do two kmem_cache_alloc's
> in a row. You store the second pointer in the shared skb data area.
>
> The fast path within kmem_cache_alloc is good enough that the second
> one sho
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sun, 14 Aug 2005 23:23:32 +0200
> [NET]: Store skb->timestamp as offset to a base timestamp
>
> Reduces skb size by 8 bytes.
>
> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
Updated patch applied, thanks Patrick.
-
To unsubscribe from this l
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 10:42:44 +1000
> Well I don't think I understand the new skb->user solution yet :)
>
> For a start, skb->users will prevent the skb->data area from being
> freed as well as the skb itself. We'll also need to audit the TCP
> code paths t
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 02:33:30 +0200
> [NETLINK]: Support dynamic number of multicast groups per netlink family
>
> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
I applied patches 1 -> 7, but I had to stop after that.
This patch here will break ne
From: Evgeniy Polyakov <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 13:43:39 +0400
> On Mon, Aug 15, 2005 at 11:06:27AM +0200, Patrick McHardy ([EMAIL PROTECTED])
> wrote:
> > Evgeniy Polyakov wrote:
> > >it's not Dave's bug, all this changes force compiler to scream, which
> > >thrusts forward.
>
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 16:05:49 +0200
> It was intentional, but I agree the other way around would be more
> consistent. If you want to send a patch, go ahead, otherwise I'll
> put it on my cleanup-list. Not allowing user sockets for unregistered
> protoco
From: bert hubert <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 22:16:49 +0200
> Currently socket(PF_INET, SOCK_DGRAM, IPPROTO_IP) delivers the exact same
> source port each time I run it, 32776. The second invocation, without
> closing the first socket, generates 32777.
>
> This strikes me as being
From: bert hubert <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 22:38:44 +0200
> Yes it does. Nameservers also need to send outgoing packets. The DNS
> 'keyspace' for response spoofing is a sad 16 bits, there are two bytes
> available in the DNS packet. By randomising the source port, another 16 bits
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 16:43:57 +0200
> Dave, I found another problem in the earlier patch of mine,
> when we free the clone portion and the parent is still alive
> we used to set UNAVAIL in the else branch but at this point
> the skb could have been gone alre
Ok, this scheme doesn't work as-is.
We never run the __kfree_skb() actions on the parent
SKB if the child drops the parent SKB users count to zero.
This means we don't release the DST and other objects
referenced in the parent SKB. We also never release the
SKB memory in this case either.
-
To
From: "David S. Miller" <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 15:45:00 -0700 (PDT)
> Ok, this scheme doesn't work as-is.
FWIW the fclone_ref version works perfectly fine, and
I'm running this right now. I'm including it below
against current net-2.6.1
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 16 Aug 2005 12:02:31 +1000
> I have a suggestion as to where fclone_ref
> should be though. I'd put it outside sk_buff. So when you
> allocate sk_buff * 2 for fast clones, make that
> sk_buff * 2 + atomic_t. Then you will only have to carry
> it a
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
Date: Tue, 16 Aug 2005 02:24:14 -0300
> Please consider pulling from:
>
> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
>
> Please let me know about anything you may want reworked.
Looks good, pulled.
-
To u
From: Matthew J Galgoci <[EMAIL PROTECTED]>
Date: Tue, 16 Aug 2005 07:13:45 +0100
> Is this a spurrious BUG() statement that is no longer applicable, or
> is there a subtle problem with the skge driver that involves hw
> checksumming syn packets?
skge sets CHECKSUM_HW on received packets, sk98lin
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
Date: Tue, 16 Aug 2005 19:07:03 -0300
> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
Pulled, thanks Arnaldo.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTE
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
Date: Tue, 16 Aug 2005 19:57:48 -0300
> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
Looks good, pulled.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
M
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Tue, 16 Aug 2005 13:22:50 -0700
> Convert fib_trie to use Read Copy Update. Since all updates to
> FIB happen under RTNL mutex (semaphore), we don't need fib_lock
> for writing.
Robert was independantly working on an RCU patch, which recently he
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed, 17 Aug 2005 05:33:44 +0200
> [IPV6]: Fix raw socket hardware checksum failures
>
> When packets hit raw sockets the csum update isn't done yet, do it manually.
> Packets can also reach rawv6_rcv on the output path through
> ip6_call_ra_chain, i
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed, 17 Aug 2005 05:52:06 +0200
> David S. Miller wrote:
> > Applied to both net-2.6 and net-2.6.14
>
> BTW, the IPv6 skb leak fix is only in your net-2.6.14 tree
> so far, I think it should go in net-2.6 as well.
Agree
Can you please at least _COMPILE_ the patches you post
so that my time isn't wasted like this?
include/linux/ethtool.h:259: error: two types specified in one empty declaration
Of course, you missed the semi-colon:
+struct ethtool_perm_addr {
+ u32 cmd;/* ETHTOOLGPERMADDR *
From: Christoph Hellwig <[EMAIL PROTECTED]>
Subject: Re: [PATCH netdev-2.6] sky2: new experimental Marvell Yukon2 driver
Date: Wed, 17 Aug 2005 20:27:40 +0100
> On Wed, Aug 17, 2005 at 03:25:30PM -0400, Jeff Garzik wrote:
> > >>It's just highly irregular to use pci_unmap_xxx functions immediately
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Tue, 16 Aug 2005 22:01:04 -0700
> On Tue, 16 Aug 2005 20:37:25 -0700 (PDT)
> "David S. Miller" <[EMAIL PROTECTED]> wrote:
>
> > Robert was independantly working on an RCU patch, which recently he
> > s
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Wed, 17 Aug 2005 21:37:21 +0200
> David, do you think we could place file->private_data in the same cache line
> than file->f_count and file->f_op, so that sockfd_lookup() can
> access all the needed information (f_count, f_op, private_data) using one
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Wed, 17 Aug 2005 22:06:05 +0200
> Then I wait first that Benjamin patch is included. :)
It's in my net-2.6.14 tree already.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo
From: Daniel Phillips <[EMAIL PROTECTED]>
Date: Thu, 18 Aug 2005 06:50:35 +1000
> One solution is to use a more modern card for the outside interface.
> But is there any fundamental problem with fragmenting the bridge
> traffic when necessary, and let the bridge MTU be the maximum of the
> interfa
and
suggestions from Herbert Xu.
Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -162,6 +162,13 @@ struct skb_timeval {
u32 off_usec;
};
+
+en
From: "John W. Linville" <[EMAIL PROTECTED]>
Date: Wed, 17 Aug 2005 16:49:59 -0400
> Change operations on rif_lock from spin_{un}lock_bh to
> spin_{un}lock_irq{save,restore} equivalents. Some of the
> rif_lock critical sections are called from interrupt context via
> tr_type_trans->tr_add_rif_inf
From: Andi Kleen <[EMAIL PROTECTED]>
Date: Thu, 18 Aug 2005 03:05:25 +0200
> I would just set the ra pointer to a single global structure if the
> allocation fails. Then you can avoid all the other checks. It will
> slow down things and trash some state, but not fail and nobody
> should expect goo
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Thu, 18 Aug 2005 09:14:47 +0200
> After reading your suggestions, I understand we still need two slabs.
> One (filp_cachep) without the readahead data, the other one
> (filp_ra_cachep) with it.
Correct.
> static inline struct file_ra_state *get_ra_sta
From: Anton Blanchard <[EMAIL PROTECTED]>
Date: Fri, 19 Aug 2005 05:08:36 +1000
> Maybe we should instead fire off the blink timer, return immediately
> and stop the blink when our timeout has been exceeded. If the user
> wanted to clear a blink they could then issue another ethtool call with
> a
501 - 600 of 1576 matches
Mail list logo
