wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2116731634
Thanks for adding this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
wu-sheng merged PR #689:
URL: https://github.com/apache/skywalking-java/pull/689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2115264224
Please follow the comments to polish the codes. Generally, this PR is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2114238065
It seems the UTs failing. Please recheck and fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1602738229
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractTracingSpan.java:
##
@@ -63,7 +63,8 @@ public abstract cla
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1602737156
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/AbstractTracerContext.java:
##
@@ -138,4 +138,10 @@ public interface Abs
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1602736268
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java:
##
@@ -163,7 +163,12 @@ public static void continue
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601141856
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredTr
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601138854
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredTr
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601138854
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredTr
gzlicanyi commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601125642
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredT
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1601087830
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredTr
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1600911559
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredTr
gzlicanyi commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1600851431
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredT
gzlicanyi commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1600849761
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredT
wu-sheng commented on code in PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#discussion_r1600845711
##
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/IgnoredTracerContext.java:
##
@@ -34,14 +34,21 @@ public class IgnoredTr
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2109871615
Please update here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2109868469
> Which problem do you mean No matter what spans they are. As they are not
reported, they are fine to be GCed.
I have made alterations using a new way and submitted another
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2109865016
Which problem do you mean No matter what spans they are. As they are not
reported, they are fine to be GCed.
--
This is an automated message from the Apache Git Service.
To resp
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2109749252
> > > > I think you got it wrong. It should be in ContextManager#continued
method, which controls the context.
> > >
> > >
> > > Understood. How can the
[span](https://
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2109743159
> > > I think you got it wrong. It should be in ContextManager#continued
method, which controls the context.
> >
> >
> > Understood. How can the
[span](https://github.c
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107534947
> > I think you got it wrong. It should be in ContextManager#continued
method, which controls the context.
>
> Understood. How can the
[span](https://github.com/apache/skywa
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107529372
> > This is a force sampling(unsampling), we don't need to worry about
sampling counter.
>
> ForceSampling might not necessarily be true. I feel that it could still
impact t
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107509503
> This is a force sampling(unsampling), we don't need to worry about
sampling counter.
> This is a force sampling(unsampling), we don't need to worry about
sampling
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107480474
> I think you got it wrong. It should be in ContextManager#continued method,
which controls the context.
Understood. How can the
[span](https://github.com/apache/skywalking
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107451077
This is a force sampling(unsampling), we don't need to worry about sampling
counter.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107449336
I think you got it wrong. It should be in ContextManager#continued method,
which controls the context.
--
This is an automated message from the Apache Git Service.
To respond to
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107376314
> When this is about ContextManager, it should not affect
TracingContext#CreateLocal span. Only snapshot should be changed, and
ContextManager asked TracingContext switching to Ig
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107355009
When this is about ContextManager, it should not affect
TracingContext#CreateLocal span. Only snapshot should be changed, and
ContextManager asked TracingContext switching to Ignor
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107275825
You are adding a mechanism for local span creation. This should not happen,
if there is a context switching out, it must be controlled by ContextManager.
--
This is an automated
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107265410
I don't have direct answer, if I had, I already told you in the last
discussion.
The reason it doesn't exist is, the tracing context is created before the
snapshot is contin
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107252722
> I think we need to separate the context. Cross thread is different from
cross process. Cross process is defined here,
https://skywalking.apache.org/docs/main/latest/en/api/x-pro
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107220318
I am feeling you are doing a hijack only, which should not be the official
way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107218830
I think we need to separate the context. Cross thread is different from
cross process.
Cross process is defined here,
https://skywalking.apache.org/docs/main/latest/en/api/x-pr
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107191416
> Add what?
here: https://github.com/apache/skywalking-java/pull/689#issue-2292115894
--
This is an automated message from the Apache Git Service.
To respond to the messag
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107183993
Add what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107173269
> Please write a proposal about what is a force-ignoring mechanism. The
discussion we did was only about the context.
Added.
--
This is an automated message from the Apac
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106941367
For an official proposal, you could refer to
SWIP(https://skywalking.apache.org/docs/main/next/en/swip/readme/), which is
mandatory for OAP, but not for the agent.
A key part of
gzlicanyi commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106934764
> Please write a proposal about what is a force-ignoring mechanism. The
discussion we did was only about the context.
Do you have a proposal template?
--
This is an a
wu-sheng commented on PR #689:
URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106928547
Please write a proposal about what is a force-ignoring mechanism. The
discussion we did was only about the context.
--
This is an automated message from the Apache Git Service.
gzlicanyi opened a new pull request, #689:
URL: https://github.com/apache/skywalking-java/pull/689
Add a [forceIgnoring
mechanism](https://github.com/apache/skywalking/discussions/12161) and apply it
to the plugins (Spring Cloud Gateway, HttpClient, JDK-ForkJoinPool,
JDK-Threading, JDK-Thr
41 matches
Mail list logo
