RE: [PATCH 1/4] radio settings: allow for more than one property

Hi Denis, I really don't want to argue about this. SetProperty(TechnologyPreference, ..) - Sets RADIO_SETTINGS_MODE_CACHED GetProperties() - queries Fast dormancy GetProperties() - queries Fast dormancy - + } else if (rs-driver-query_fast_dormancy) { +

Re: [PATCH] hso: Set modem name based on udev network interface name

Hi Denis, De : Denis Kenzior Hi Benoît, I prefer you do this in plugins/hso and not in udev. Is the patch below correct ? I moved the call to set_name to hso_probe. Benoît -- Subject: [PATCH] hso: Set modem name based on udev network interface name Useful if you have multiple identical

Re: [PATCH] hso: Set modem name based on udev network interface name

Hi Benoit, Subject: [PATCH] hso: Set modem name based on udev network interface name Useful if you have multiple identical modems and you need a way to know which modem you're talking to. --- plugins/hso.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git

Add Barred Dialing Support

Hi, This patch adds the barred dialing support. If Barred Dialing service is enabled, then oFono will go into emergency mode. Patch has been tested with the phonesim. Regards, jeevaka ___ ofono mailing list ofono@ofono.org

[PATCH 1/4] simutil: add Efbdn fileid to sim_fileid enum

--- src/simutil.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 50ad418..5b56099 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -32,6 +32,7 @@ enum sim_fileid { SIM_EFMSISDN_FILEID = 0x6f40, SIM_EFSPN_FILEID =

[PATCH 3/4] doc: Add BarredDialing property

--- doc/sim-api.txt |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/doc/sim-api.txt b/doc/sim-api.txt index 6dc5e0b..d4d2b1b 100644 --- a/doc/sim-api.txt +++ b/doc/sim-api.txt @@ -138,3 +138,10 @@ Properties boolean Present [readonly] If

[PATCH 2/4] sim: add barred dialing support

--- src/sim.c | 87 +++- 1 files changed, 79 insertions(+), 8 deletions(-) diff --git a/src/sim.c b/src/sim.c index 699ebe9..c631e31 100644 --- a/src/sim.c +++ b/src/sim.c @@ -73,6 +73,7 @@ struct ofono_sim { unsigned char *efsst;

[PATCH 4/4] TODO: Marking the Barred Dialing task as done

--- TODO |7 --- doc/features.txt |5 + 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/TODO b/TODO index d9a6580..ad96241 100644 --- a/TODO +++ b/TODO @@ -110,13 +110,6 @@ SMS SIM / SIM File system = -- Barred Dialing numbers

Re: [PATCH] hso: Set modem name based on udev network interface name

Hi Marcel, De : Marcel Holtmann Hi Benoit, the friendly modem name is for devices that do have a friendly name, like Bluetooth headsets. Why do you wanna misuse the interface name here. I am a bit against this, because it leads to speculation and assumptions in userspace programs.

Call counters proposal (TODO patch)

I am proposing adding Call counters to Voicecall. Here is the TODO patch: diff --git a/TODO b/TODO index d9a6580..89e180c 100644 --- a/TODO +++ b/TODO @@ -329,6 +329,15 @@ Voicecall Complexity: C2 Owner: Pekka Pessi pekka.pe...@nokia.com +- Call counters. Provide total outgoing and

[PATCH 0/6] radio settings: fast dormancy support

Hi All, Here's another go at fast dormancy. I hope I managed to address the concerns about the previous patch set. A driver implementation for isimodem is now included. Br, MikaL [PATCH 1/6] radio settings: add FastDormancy property [PATCH 2/6] radio settings: document FastDormancy

[PATCH 1/6] radio settings: add FastDormancy property

--- include/radio-settings.h | 11 src/radio-settings.c | 134 + 2 files changed, 133 insertions(+), 12 deletions(-) diff --git a/include/radio-settings.h b/include/radio-settings.h index d41ec0b..a6b19d0 100644 ---

[PATCH 2/6] radio settings: document FastDormancy property

--- doc/radio-settings-api.txt | 59 ++- 1 files changed, 41 insertions(+), 18 deletions(-) diff --git a/doc/radio-settings-api.txt b/doc/radio-settings-api.txt index f1b91ad..00eca54 100644 --- a/doc/radio-settings-api.txt +++

[PATCH 6/6] AUTHORS: add myself

--- AUTHORS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/AUTHORS b/AUTHORS index 654b314..c0218c6 100644 --- a/AUTHORS +++ b/AUTHORS @@ -37,3 +37,4 @@ Petteri Tikander petteri.tikan...@ixonos.com Jeevaka Badrappan jeevaka.badrap...@elektrobit.com Frank Gau

[PATCH 3/6] test: add scripts to enable and disable fast dormancy

--- Makefile.am|4 +++- test/disable-fast-dormancy | 20 test/enable-fast-dormancy | 20 3 files changed, 43 insertions(+), 1 deletions(-) create mode 100755 test/disable-fast-dormancy create mode 100755

[PATCH 4/6] isimodem: add support for FastDormancy property

--- drivers/isimodem/radio-settings.c | 91 - 1 files changed, 90 insertions(+), 1 deletions(-) diff --git a/drivers/isimodem/radio-settings.c b/drivers/isimodem/radio-settings.c index d220476..558e032 100644 --- a/drivers/isimodem/radio-settings.c +++

[PATCH 5/6] TODO: mark fast dormancy as done

--- TODO | 20 doc/features.txt |8 2 files changed, 8 insertions(+), 20 deletions(-) diff --git a/TODO b/TODO index d9a6580..d3d6687 100644 --- a/TODO +++ b/TODO @@ -519,26 +519,6 @@ Miscellaneous Priority: Medium Complexity: C2 -- Add a

Re: Call counters proposal (TODO patch)

Hi Andras, I am proposing adding Call counters to Voicecall. Here is the TODO patch: diff --git a/TODO b/TODO index d9a6580..89e180c 100644 --- a/TODO +++ b/TODO @@ -329,6 +329,15 @@ Voicecall Complexity: C2 Owner: Pekka Pessi pekka.pe...@nokia.com +- Call counters. Provide

Re: [PATCH 1/6] radio settings: add FastDormancy property

Hi Mika, include/radio-settings.h | 11 src/radio-settings.c | 134 + 2 files changed, 133 insertions(+), 12 deletions(-) diff --git a/include/radio-settings.h b/include/radio-settings.h index d41ec0b..a6b19d0 100644 ---

Re: [PATCH 2/6] radio settings: document FastDormancy property

Hi Mika, doc/radio-settings-api.txt | 59 ++- 1 files changed, 41 insertions(+), 18 deletions(-) sounds good to me. And I just went ahead and applied this patch. Regards Marcel ___ ofono mailing list

Re: [PATCH 3/6] test: add scripts to enable and disable fast dormancy

Hi Mika, Makefile.am|4 +++- test/disable-fast-dormancy | 20 test/enable-fast-dormancy | 20 3 files changed, 43 insertions(+), 1 deletions(-) create mode 100755 test/disable-fast-dormancy create mode 100755

Re: [PATCH 6/6] AUTHORS: add myself

Hi Mika, --- AUTHORS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) nobody should need to add themselves to the AUTHORS file. I apologize for this oversight. You are added now. Regards Marcel ___ ofono mailing list ofono@ofono.org

RE: [PATCH 1/6] radio settings: add FastDormancy property

Hi Marcel, @@ -103,14 +103,60 @@ static DBusMessage *radio_get_properties_reply(DBusMessage *msg, OFONO_PROPERTIES_ARRAY_SIGNATURE, dict); - ofono_dbus_dict_append(dict, TechnologyPreference, + if

Re: [PATCH 1/6] radio settings: add FastDormancy property

Hi Mika, On 10/25/2010 10:05 AM, mika.liljeb...@nokia.com wrote: Hi Marcel, @@ -103,14 +103,60 @@ static DBusMessage *radio_get_properties_reply(DBusMessage *msg, OFONO_PROPERTIES_ARRAY_SIGNATURE, dict); -

Re: [PATCH 1/6] radio settings: add FastDormancy property

Hi Mika, On 10/25/2010 08:28 AM, Mika Liljeberg wrote: --- include/radio-settings.h | 11 src/radio-settings.c | 134 + 2 files changed, 133 insertions(+), 12 deletions(-) diff --git a/include/radio-settings.h

[ANNOUNCE] oFono 0.33

Hi Everyone, oFono 0.33 is out. This release is mostly a mixed development and bug fix release. The main new features are Fixed Dialing support and Send DTMF support. Another major feature is GPRS support on Infineon modems. ChangeLog: - Fix wrong string to enum mapping of radio settings. -

[PATCH] voicecall: Limit tone string length per request.

Also change to avoid memcpying into a buffer. --- src/voicecall.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 26cfb9a..bd64432 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -2472,7 +2472,7 @@ static

[PATCH 1/2] stk: Add duration_to_msecs to reduce duplication.

--- src/stk.c | 61 ++--- 1 files changed, 26 insertions(+), 35 deletions(-) diff --git a/src/stk.c b/src/stk.c index 82bc91e..ebd3801 100644 --- a/src/stk.c +++ b/src/stk.c @@ -437,6 +437,24 @@ static void stk_alpha_id_unset(struct

[PATCH 2/2] stk: Handle the Play Tone proactive command.

--- src/stk.c | 131 + 1 files changed, 131 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index ebd3801..24326ae 100644 --- a/src/stk.c +++ b/src/stk.c @@ -2081,6 +2081,132 @@ static gboolean

Re: Call counters proposal (TODO patch)

Hi, 2010/10/25 Marcel Holtmann mar...@holtmann.org: I am proposing adding Call counters to Voicecall. Here is the TODO patch: diff --git a/TODO b/TODO index d9a6580..89e180c 100644 --- a/TODO +++ b/TODO @@ -329,6 +329,15 @@ Voicecall     Complexity: C2     Owner: Pekka Pessi

Re: Call counters proposal (TODO patch)

Hi Aki, On 10/25/2010 02:43 PM, Aki Niemi wrote: Hi, 2010/10/25 Marcel Holtmann mar...@holtmann.org: I am proposing adding Call counters to Voicecall. Here is the TODO patch: diff --git a/TODO b/TODO index d9a6580..89e180c 100644 --- a/TODO +++ b/TODO @@ -329,6 +329,15 @@ Voicecall

Re: [PATCH] voicecall: Limit tone string length per request.

Hi Andrew, On 10/25/2010 12:51 AM, Andrzej Zaborowski wrote: Also change to avoid memcpying into a buffer. --- src/voicecall.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 1/2] stk: Add duration_to_msecs to reduce duplication.

Hi Andrew, On 10/25/2010 12:51 AM, Andrzej Zaborowski wrote: --- src/stk.c | 61 ++--- 1 files changed, 26 insertions(+), 35 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 2/2] stk: Handle the Play Tone proactive command.

Hi Andrew, On 10/25/2010 12:51 AM, Andrzej Zaborowski wrote: --- src/stk.c | 131 + 1 files changed, 131 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis

Re: modem atom api change request for support GSMCDMA dual mode

Hi Caiwen, Zhang, Caiwen to ofono Hi all, Considering support GSM + CDMA dual mode, it is necessary to let upper layer to know the type of the modem currently in use. My proposed solution is add a property 'Type' in modem atom to indicate it. The following is the definition of the property:

RE: modem atom api change request for support GSMCDMA dual mode

Hi Rajesh, Considering support GSM + CDMA dual mode, it is necessary to let upper layer to know the type of the modem currently in use. My proposed solution is add a property 'Type' in modem atom to indicate it. The following is the definition of the property: string Type [readonly]