Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
Fix : Added the missed out RTL checks to the key mappings in
TableViewBehaviorBase class.
Testing : Modified unit tests in TableViewKeyInputTest to take orientation as a
parameter. The Left/Right key press tests have been modified to addres
On Fri, 14 Feb 2020 09:09:13 GMT, Ajit Ghaisas wrote:
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a
On Fri, 14 Feb 2020 09:09:13 GMT, Ajit Ghaisas wrote:
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a
On Fri, 14 Feb 2020 11:26:14 GMT, Jeanette Winzenburg
wrote:
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>>
>> Fix : Added the missed out RTL checks to the key mappings in
>> TableViewBehaviorBase class.
>>
>> Testing : Modified unit tests in TableViewKeyInputTest to take orient
On Fri, 14 Feb 2020 14:06:28 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java
>> line 152:
>>
>>> 151:
>>> 152: new KeyMapping(LEFT, (rtl? e -> selectRightCell() : e
>>> -> selectLeftCell())),
On Fri, 14 Feb 2020 09:09:13 GMT, Ajit Ghaisas wrote:
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a
On Fri, 14 Feb 2020 14:27:15 GMT, Jeanette Winzenburg
wrote:
>> To add multiple comments, go to the `Files changed` tab and click on a line
>> of code to add a comment there. Select `Start a review` rather than `Add
>> single comment`. This way you can batch up multiple comments. Then you
>>
On Sat, 15 Feb 2020 14:54:50 GMT, Kevin Rushforth wrote:
>> thanks, Kevin - that's what I tried, but it refused to accept the second ..
>> so sticking with single comments until I feel like digging into this
>> weirdness.
>
> Regarding the fix, it seems that you need to eliminate the `rtl` var
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been modi
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been modi
On Fri, 14 Feb 2020 11:18:12 GMT, Jeanette Winzenburg
wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java
> line 139:
>
>> 138: boolean rtl = isRTL();
>> 139:
On Sat, 15 Feb 2020 14:59:30 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java
> line 102:
>
>> 101:
>> 102: private NodeOrientation orientation;
>> 103:
On Tue, 25 Feb 2020 15:04:05 GMT, Jeanette Winzenburg
wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java
> line 1141:
>
>> 1140: keyboard.doLeftArrowPress(KeyModifier.
On Mon, 24 Feb 2020 17:15:02 GMT, Ajit Ghaisas wrote:
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>>
>> Fix : Added the missed out RTL checks to the key mappings in
>> TableViewBehaviorBase class.
>>
>> Testing : Modified unit tests in TableViewKeyInputTest to take orientation
>
On Tue, 25 Feb 2020 15:10:50 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewKeyInputTest.java
>> line 1141:
>>
>>> 1140: keyboard.doLeftArrowPress(KeyModifier.getShortcutKey());
>>> 1141: }
>>> 1142: keybo
On Fri, 28 Feb 2020 12:00:23 GMT, Ajit Ghaisas wrote:
>> Also, I'm a bit weary about the "else if" (vs a simple "else") - wouldn't it
>> be some kind of setup error if the node orientation is neither rtl nor ltr?
>> If so, I would add a test to check for it once.
>
> Initially I had thought abo
On Fri, 28 Feb 2020 17:22:39 GMT, Jeanette Winzenburg
wrote:
>> Regarding your suggestion of having forward/backward semantic methods and
>> calling them in tests -
>> There are two types of tests -
>> 1. Key action remains same - asserts differ based on NodeOrientation
>> 2. Key action differ
On Fri, 28 Feb 2020 12:14:24 GMT, Ajit Ghaisas wrote:
>> Initially I had thought about adding separate test file for RTL - something
>> like RTLTableViewKeyInputTest - but, realized that although it's a cleaner
>> approach, we would simply duplicate the tests. Also, the fact is only
>> LEFT/RI
On Sat, 15 Feb 2020 15:01:47 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> @kleopatra is right about the need to handle the case where the orientation
> of a node changes. As for the test, I think the idea of parameterizing it
> with LTR, RTL is
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been modi
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been modi
On Sun, 1 Mar 2020 12:24:06 GMT, Jeanette Winzenburg
wrote:
>> @kleopatra is right about the need to handle the case where the orientation
>> of a node changes. As for the test, I think the idea of parameterizing it
>> with LTR, RTL is good. I haven't reviewed it in detail, but added one minor
On Fri, 6 Mar 2020 11:47:42 GMT, Ajit Ghaisas wrote:
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>>
>> Fix : Added the missed out RTL checks to the key mappings in
>> TableViewBehaviorBase class.
>>
>> Testing : Modified unit tests in TableViewKeyInputTest to take orientation
>>
On Fri, 6 Mar 2020 21:38:15 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> extra space removed
>
> I think the fix looks good and the approach you took for the new test looks
> good to me. If
On Fri, 6 Mar 2020 11:47:42 GMT, Ajit Ghaisas wrote:
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>>
>> Fix : Added the missed out RTL checks to the key mappings in
>> TableViewBehaviorBase class.
>>
>> Testing : Modified unit tests in TableViewKeyInputTest to take orientation
>>
On Thu, 12 Mar 2020 12:39:16 GMT, Jeanette Winzenburg
wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> extra space removed
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewHorizontalArro
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press
> tests have been mo
On Fri, 13 Mar 2020 17:23:52 GMT, Ajit Ghaisas wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewHorizontalArrowsTest.java
>> line 122:
>>
>>> 121: }
>>> 122:
>>> 123: /**
>>
>> changing the parameter of the test is at least unusual, should be doc'ed so
On Mon, 16 Mar 2020 13:00:32 GMT, Jeanette Winzenburg
wrote:
>> Good catch!!!
>> It definitely would have unintentional side effect of incorrect orientation
>> in subsequent tests.
>> I updated the test to restore the orientation at the end of the test. Also
>> documented the same.
>
> hmm ...
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press
> tests have been mo
On Thu, 12 Mar 2020 12:42:28 GMT, Jeanette Winzenburg
wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> extra space removed
>
> sry for the spelling errors you inherited :)
@aghaisas can't see your last response he
On Tue, 17 Mar 2020 07:38:45 GMT, Ajit Ghaisas wrote:
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>>
>> Fix : Added the missed out RTL checks to the key mappings in
>> TableViewBehaviorBase class.
>>
>> Testing : Added a test to take NodeOrientation as a parameter and test
>> ho
On Tue, 17 Mar 2020 07:38:45 GMT, Ajit Ghaisas wrote:
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>>
>> Fix : Added the missed out RTL checks to the key mappings in
>> TableViewBehaviorBase class.
>>
>> Testing : Added a test to take NodeOrientation as a parameter and test
>> ho
33 matches
Mail list logo
