On Thu, 20 May 2021 11:12:09 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127
> small changes based on
On Tue, 18 May 2021 13:11:39 GMT, Jeanette Winzenburg
wrote:
>> Florian Kirmaier has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8264127
>>fixed assertion text,
>>exception handler is now installed/uninstalled like in TableCel
On Thu, 20 May 2021 11:12:09 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127
> small changes based on
On Tue, 18 May 2021 10:14:11 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8264127
>fixed assertion text
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127
small changes based on CR
-
Changes:
- all: https://git.openjdk.java.net/jfx/pul
On Tue, 18 May 2021 10:14:11 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8264127
>fixed assertion text
On Tue, 18 May 2021 10:14:11 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8264127
>fixed assertion text
On Tue, 18 May 2021 10:14:11 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8264127
>fixed assertion text
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with two additional
commits since the last revision:
- 8264127
fixed assertion text,
exception handler is now installed/uninstalled like in TableCellTest
On Mon, 17 May 2021 08:40:44 GMT, Jeanette Winzenburg
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8264127
>> More changes, simplifications and tests based on CR
>
> modules/javafx.controls/src/test/java/
On Fri, 14 May 2021 13:26:55 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127
> More changes, simplific
On Wed, 12 May 2021 08:13:32 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> we now use a try final
On Thu, 13 May 2021 12:29:46 GMT, Jeanette Winzenburg
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8264127:
>> we now use a try finally statement, to make sure updateEditingIndex is
>> reset!
>
> modules
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127
More changes, simplifications and tests based on CR
-
Changes:
- all: https://gi
On Wed, 12 May 2021 08:13:32 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> we now use a try final
On Wed, 12 May 2021 08:13:32 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> we now use a try final
On Tue, 27 Apr 2021 09:26:05 GMT, Florian Kirmaier
wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellTest.java
>> line 921:
>>
>>> 919: assertFalse("cell must not be editing if cell index is " +
>>> cell.getIndex(), cell.isEditing());
>>> 920: a
On Tue, 27 Apr 2021 11:52:58 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> removed accidentally c
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
we now use a try finally statement, to make sure updateEditingIndex is reset!
-
C
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
removed accidentally commited print statements.
-
Changes:
- all: https://git.o
On Tue, 27 Apr 2021 10:38:07 GMT, Jeanette Winzenburg
wrote:
>> I've now rewritten the code. It's now way simpler and avoids duplicate code.
>> I guess the different implementation in the different cells all have some
>> subtle differences.
>>
>> Then i guess we wait for the other review to f
On Tue, 27 Apr 2021 10:00:44 GMT, Florian Kirmaier
wrote:
>
>
> I guess the different implementation in the different cells all have some
> subtle differences.
>
actually, I doubt that they are different - my guess: we could formally prove
that the logic is equivalent :) Or the other way:
On Mon, 26 Apr 2021 11:46:57 GMT, Jeanette Winzenburg
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8264127:
>> Added missing test case
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ListCe
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
restructured the if/else cascade in updating index. It's now simpler an less
nested and avoid
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with two additional
commits since the last revision:
- 8264127:
Added more asserts to the ListCellTest, to make it more symmetric to the
other test
- 8264
On Mon, 26 Apr 2021 11:34:34 GMT, Jeanette Winzenburg
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8264127:
>> Added missing test case
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/L
On Mon, 26 Apr 2021 11:58:16 GMT, Jeanette Winzenburg
wrote:
>> yes, remove it: the focus of this issue is that the cell sync's its own
>> editing state on updateIndex off/to list editing index - I think that
>> implies the list always editing with a valid editingIndex :)
>
> yes, remove it: t
On Mon, 26 Apr 2021 11:24:40 GMT, Jeanette Winzenburg
wrote:
>> I guess it doesn't make sense. Probably missunderstanding somewhere. Should
>> i remove? This would also get rid of the if in the test.
>
> yes, remove it: the focus of this issue is that the cell sync's its own
> editing state on
On Fri, 23 Apr 2021 16:52:14 GMT, Florian Kirmaier
wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellTest.java
>> line 867:
>>
>>> 865: @Test
>>> 866: public void testChangeIndexToEditing3_jdk_8264127() {
>>> 867: assertChangeIndexToEditing(1, -1
On Fri, 23 Apr 2021 17:06:54 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Added missing test cas
On Thu, 22 Apr 2021 11:44:41 GMT, Jeanette Winzenburg
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8264127:
>> Fixed another index case based on code review
>
> modules/javafx.controls/src/main/java/javaf
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
Added missing test case
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull
On Fri, 23 Apr 2021 16:57:54 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> More changes based on
On Thu, 22 Apr 2021 11:58:33 GMT, Jeanette Winzenburg
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8264127:
>> Fixed another index case based on code review
>
> modules/javafx.controls/src/test/java/test/
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
More changes based on codereview.
Simplified the tests, we are now using for both cases "test
On Thu, 22 Apr 2021 11:00:43 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Fixed another index ca
On Wed, 21 Apr 2021 14:25:53 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Small update to the te
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
Fixed another index case based on code review
-
Changes:
- all: https://git.ope
On Wed, 21 Apr 2021 14:22:21 GMT, Florian Kirmaier
wrote:
>
>
> Finally found time to update the PR.
>
> 1. As suggested, I've moved the updateIndex method below the if.
>
looks good :)
> 2. The test from 1 to -1 is a bit more complicated. Because -1 represents
> "not editing" the
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
Small update to the tests and the fix
-
Changes:
- all: https://git.openjdk.jav
On Wed, 14 Apr 2021 11:58:14 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Added checks, whether
On Wed, 14 Apr 2021 11:58:14 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Added checks, whether
On Wed, 14 Apr 2021 11:58:14 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Added checks, whether
On Wed, 14 Apr 2021 11:58:14 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Added checks, whether
On Wed, 14 Apr 2021 11:45:17 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Fixed some more testca
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
Added checks, whether the correction ammount of editStart/cancel events are
triggered
---
On Wed, 14 Apr 2021 11:45:17 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Fixed some more testca
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
Fixed some more testcases
-
Changes:
- all: https://git.openjdk.java.net/jfx/pu
On Fri, 9 Apr 2021 10:40:19 GMT, Florian Kirmaier wrote:
>
>
> I've looked into it.
> This is somehow linked to the fact, that the default focusIndex for the list
> is 0 instead of -1.
> If you change the updateDefaultFocus methods in ListView, then it works.
>
good dig :) Wouldn't have expe
On Tue, 6 Apr 2021 13:30:46 GMT, Jeanette Winzenburg
wrote:
>> @kleopatra
>> I've added another test for the case, when index changes in such a way, that
>> the cell should no longer be in the editing state,
>> and the test seems to work. Do I miss something?
>>
>> About the Events, when i th
On Sat, 3 Apr 2021 15:20:33 GMT, Florian Kirmaier wrote:
> @kleopatra
> I've added another test for the case, when index changes in such a way, that
> the cell should no longer be in the editing state,
> and the test seems to work. Do I miss something?
hmm .. that's weird: your test (cell 1 ->
On Thu, 1 Apr 2021 14:41:46 GMT, Jeanette Winzenburg
wrote:
>> I don't think B is right.
>> I would expect a editCancel event when the index of an editing cell is
>> changed.
>> If there would be another cell, which will get the index 1 (which isn't the
>> case in this artifical test) then i w
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with two additional
commits since the last revision:
- 8264127:
removed accidentally commited line
- 8264127:
Added another test for ListCell, now when
On Wed, 31 Mar 2021 09:25:28 GMT, Florian Kirmaier
wrote:
>
>
> I don't think B is right.
> I would expect a editCancel event when the index of an editing cell is
> changed.
> If there would be another cell, which will get the index 1 (which isn't the
> case in this artifical test) then i wo
On Fri, 26 Mar 2021 12:26:53 GMT, Jeanette Winzenburg
wrote:
>> To clarify, this with happening with ListViews in production code.
>> In some conditions, the status of a single cell doesn't update. The effect
>> is, that a Cell is stuck in the Editing mode.
>> If I remember correctly, it was ir
On Thu, 25 Mar 2021 23:11:28 GMT, Florian Kirmaier
wrote:
>
> Handling the logic from the ListView seems wrong to me,
looks like I was unclear, because that's a 100% me-too :)
Reformulating my second sentence in test snippets:
A:
cell.updateIndex(1);
list.edit(1);
cell.
On Thu, 25 Mar 2021 11:44:21 GMT, Jeanette Winzenburg
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> good catch, yet another property that's not correctly updated on index change
> :)
>
> Quick questions:
> - what are the macroscopic effects (that is i
On Wed, 24 Mar 2021 14:58:40 GMT, Florian Kirmaier
wrote:
> Fixing ListCell editing status is true, when index changes while editing.
good catch, yet another property that's not correctly updated on index change
:)
Quick questions:
- what are the macroscopic effects (that is in a running lis
Fixing ListCell editing status is true, when index changes while editing.
-
Commit messages:
- 8264127:
Changes: https://git.openjdk.java.net/jfx/pull/441/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=441&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8264
59 matches
Mail list logo
