Please review the fix for bug:
JBS: https://bugs.openjdk.java.net/browse/JDK-8207774
openjfx: https://github.com/javafxports/openjdk-jfx/pull/575
Thanks,
Jeanette
Please review bug fix for
JBS: https://bugs.openjdk.java.net/browse/JDK-8092352
openjfx: https://github.com/javafxports/openjdk-jfx/pull/580
Thanks
Jeanette
On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote:
> Allright, this is a fix for JDK-8207957
>
>
>
> Commits:
> - 969ebb51: Fixing TableColumnHeaderTest
> - 9d379619: Removing Tablecolumnbasehelper
> - 4fe020fc: Fix javadoc for TableColumnHeader
> - c422c80f: Minor modifi
On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir wrote:
> Allright, this is a fix for JDK-8207957
>
>
>
> Commits:
> - 969ebb51: Fixing TableColumnHeaderTest
> - 9d379619: Removing Tablecolumnbasehelper
> - 4fe020fc: Fix javadoc for TableColumnHeader
> - c422c80f: Minor modifi
On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote:
> On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote:
>
>> The pull request has been updated with additional changes.
>>
>>
>>
>> Added commits:
>> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for
>
On Wed, 9 Oct 2019 15:49:21 GMT, Nir Lisker wrote:
> On Wed, 9 Oct 2019 12:25:26 GMT, Hadzic Samir wrote:
>
>> The pull request has been updated with additional changes.
>>
>>
>>
>> Added commits:
>> - e846e51c: Remove TableColumn argument for resizeColumnToFitContent for
>
compiles fine in Eclipse, throws when compiling in cygwin with gradle
:controls:test
The test class (excerpt):
@RunWith(Parameterized.class)
public abstract class DefaultCancelButtonTest {
private ButtonType buttonType;
private boolean consume;
private boolean registerAfterSh
Zitat von Jeanette Winzenburg :
okay, probably found the reason:
dependencies {
testCompile group: "junit", name: "junit", version: "4.8.2"
if (BUILD_CLOSED && DO_JCOV) {
testCompile name: "jcov"
}
.. with gradle :controls:test
Maybe related to the outdated version (4.8.2 of junit) as well as the
problem with missing name property (of Parameterized? Don't know,
though.
The workaround seems to be to @Ignore abstract tests - descendants are
run as expected.
umble across
them, I always do sooner or later
-- Kevin
On 10/15/2019 4:48 AM, Jeanette Winzenburg wrote:
.. with gradle :controls:test
Maybe related to the outdated version (4.8.2 of junit) as well as
the problem with missing name property (of Parameterized? Don't
know, though.
The
Zitat von Sverre Moe :
A comment on the JDK-8231644 issue was added by Jeanette Winzenburg
https://bugs.openjdk.java.net/browse/JDK-8231644
hmm .. no testing done but: the data object looks pathological - it's
always problematic to have nodes as data (even though technically
pos
This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759
The issue is that default/cancel button on a scene are triggered even though a
onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug for
details on both cause and fix.
There are additional/changed tests to ver
While fixing https://bugs.openjdk.java.net/browse/JDK-8207759 it
turned out that the underlying reason for the bug was a broken event
dispatch sequence introduced by behavior.forwardToParent. Which is a
call to parent.fireEvent with the event that was received. This builds
a nested chain
The issue is that firing keyEvents on a node that is not focusOwner might
produce false green tests, please see the issue for details.
fix for https://bugs.openjdk.java.net/browse/JDK-8231692
- added contructor taking the scene
- changed event firing to use either the target directly or inject in
Just filed a bug (https://bugs.openjdk.java.net/browse/JDK-8231692)
and accidentally opened it - the child in me can't refrain from
clicking buttons to see what happens ;) Having it opened, I went the
whole way and assigned it to me (it's in my current line of interes
anyway).
Not cert
the bug reference in my last message - was wrong, it's
https://bugs.openjdk.java.net/browse/JDK-8233040
ar ... wrong bug id: https://bugs.openjdk.java.net/browse/JDK-8233040
Zitat von Jeanette Winzenburg :
Just filed a bug (https://bugs.openjdk.java.net/browse/JDK-8231692)
and accidentally opened it - the child in me can't refrain from
clicking buttons to see what happens ;) Havi
thanks :)
Zitat von Nir Lisker :
I triage and self-assign my issues by the dozens :)
On Sat, Oct 26, 2019 at 7:07 PM Philip Race wrote:
I see no problem with filing a bug .. and bonus points for assigning it
to yourself and triaging it.
-phil.
On 10/26/19, 8:20 AM, Jeanette Winzenburg
On Mon, 22 Feb 2021 20:29:29 GMT, Kevin Rushforth wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
> Not yet reviewed. All
On Wed, 24 Mar 2021 23:53:24 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
> I reviewed only the public
On Wed, 24 Mar 2021 14:58:40 GMT, Florian Kirmaier
wrote:
> Fixing ListCell editing status is true, when index changes while editing.
good catch, yet another property that's not correctly updated on index change
:)
Quick questions:
- what are the macroscopic effects (that is in a running lis
On Thu, 25 Mar 2021 13:14:45 GMT, Nir Lisker wrote:
>
>
> Can you list the other affected methods?
at line 211 (in the changed skinBase)
/**
* Subclasses can invoke this method to register that they want to listen to
* property change events for the given property. Registered {@link
On Thu, 25 Mar 2021 13:52:20 GMT, Nir Lisker wrote:
>>>
>>>
>>> Can you list the other affected methods?
>>
>> at line 211 (in the changed skinBase)
>>
>> /**
>> * Subclasses can invoke this method to register that they want to
>> listen to
>> * property change events for the given
On Thu, 25 Mar 2021 23:11:28 GMT, Florian Kirmaier
wrote:
>
> Handling the logic from the ListView seems wrong to me,
looks like I was unclear, because that's a 100% me-too :)
Reformulating my second sentence in test snippets:
A:
cell.updateIndex(1);
list.edit(1);
cell.
On Sun, 28 Mar 2021 23:13:22 GMT, Marius Hanl
wrote:
> This PR fixes an issue, where table cells are not removed from the table row
> when the corresponding table column got removed. This will lead to empty
> "ghost" cells laying around in the table.
> This bug only occurs, when a fixed cell s
) and null observables (new) - this allows
> simplified code on rewiring "path" properties (see reference example in the
> issue)
Jeanette Winzenburg has updated the pull request incrementally with one
additional commit since the last revision:
SkinBase: changed javadoc for xxIn
On Wed, 24 Mar 2021 23:18:25 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
> modules/javafx.controls/src/
On Wed, 24 Mar 2021 23:39:13 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
> modules/javafx.controls/src/
On Wed, 24 Mar 2021 23:28:47 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed missing/incorrect @since tags in new api doc
>
> modules/javafx.controls/src/
) and null observables (new) - this allows
> simplified code on rewiring "path" properties (see reference example in the
> issue)
Jeanette Winzenburg has updated the pull request incrementally with one
additional commit since the last revision:
fixed trailing whitespace
-
C
) and null observables (new) - this allows
> simplified code on rewiring "path" properties (see reference example in the
> issue)
Jeanette Winzenburg has updated the pull request incrementally with one
additional commit since the last revision:
xxInvalidationListener: changed
On Thu, 25 Mar 2021 14:07:24 GMT, Jeanette Winzenburg
wrote:
>> I see. I recommend that they be improved in this PR. I don't know if this
>> will need to be part of the CSR, though.
>
> @nlisker and @Kevin so we agree, thanks :)
>
> my plan:
>
> - will wo
On Mon, 29 Mar 2021 17:17:30 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed trailing whitespace
>
> modules/javafx.controls/src/main/java/javafx/sc
On Mon, 29 Mar 2021 22:19:08 GMT, Jonathan Vusich
wrote:
>
>
> @kleopatra @kevinrushforth Are the system tests that I have provided
> sufficient for this PR to move forward or do they need to be rewritten as
> unit tests?
good question :) Personally, I would also add a unit test (even thoug
On Mon, 29 Mar 2021 12:35:23 GMT, Marius Hanl
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkinBase.java
>> line 556:
>>
>>> 554: }
>>> 555: getChildren().removeAll(toRemove);
>>> 556: } else if (resetChildren || cellsEmpty)
On Sun, 28 Mar 2021 23:13:22 GMT, Marius Hanl
wrote:
> This PR fixes an issue, where table cells are not removed from the table row
> when the corresponding table column got removed. This will lead to empty
> "ghost" cells laying around in the table.
> This bug only occurs, when a fixed cell s
On Tue, 30 Mar 2021 12:43:41 GMT, Kevin Rushforth wrote:
>
> The failure on Windows is because your branch isn't up-to-date with `master`,
> and is missing a recent fix to the Window build. You can either `git merge
> master` (after updating your `master` branch from the upstream repo) or
> i
On Tue, 30 Mar 2021 15:54:37 GMT, Marius Hanl
wrote:
>> This PR fixes an issue, where table cells are not removed from the table row
>> when the corresponding table column got removed. This will lead to empty
>> "ghost" cells laying around in the table.
>> This bug only occurs, when a fixed ce
On Wed, 31 Mar 2021 14:04:42 GMT, Marius Hanl
wrote:
>> This PR fixes an issue, where table cells are not removed from the table row
>> when the corresponding table column got removed. This will lead to empty
>> "ghost" cells laying around in the table.
>> This bug only occurs, when a fixed ce
On Wed, 31 Mar 2021 09:25:28 GMT, Florian Kirmaier
wrote:
>
>
> I don't think B is right.
> I would expect a editCancel event when the index of an editing cell is
> changed.
> If there would be another cell, which will get the index 1 (which isn't the
> case in this artifical test) then i wo
On Thu, 1 Apr 2021 13:22:47 GMT, Kevin Rushforth wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> xxInvalidationListener: changed doc as per review
>
> modules/javafx.contr
On Sat, 3 Apr 2021 15:20:33 GMT, Florian Kirmaier wrote:
> @kleopatra
> I've added another test for the case, when index changes in such a way, that
> the cell should no longer be in the editing state,
> and the test seems to work. Do I miss something?
hmm .. that's weird: your test (cell 1 ->
On Thu, 1 Apr 2021 15:09:34 GMT, Kevin Rushforth wrote:
>> @Kevin
>>
>> don't worry, I have seen your comment (and been thinking about it :) - but
>> also can't find it right now (nor can I find Nir's comment which started the
>> overhaul ..), no idea what happened.
>>
>> Seeing your suggest
) and null observables (new) - this allows
> simplified code on rewiring "path" properties (see reference example in the
> issue)
Jeanette Winzenburg has updated the pull request incrementally with one
additional commit since the last revision:
changed javadoc of unregister (
On Thu, 1 Apr 2021 15:14:15 GMT, Kevin Rushforth wrote:
>> ahh .. looks like you marked the conversation that contained the original
>> comment as resolved:
>> https://github.com/openjdk/jfx/pull/409#discussion_r604387696 ..
>
> I guess I didn't look closely enough. Mystery solved, though.
> I
) and null observables (new) - this allows
> simplified code on rewiring "path" properties (see reference example in the
> issue)
Jeanette Winzenburg has updated the pull request incrementally with one
additional commit since the last revision:
updated doc of list/Change methods tha
On Fri, 9 Apr 2021 10:40:19 GMT, Florian Kirmaier wrote:
>
>
> I've looked into it.
> This is somehow linked to the fact, that the default focusIndex for the list
> is 0 instead of -1.
> If you change the updateDefaultFocus methods in ListView, then it works.
>
good dig :) Wouldn't have expe
On Mon, 24 Feb 2020 07:39:43 GMT, yosbits
wrote:
> If there are many columns, the current TableView will stall scrolling.
> Resolving this performance issue requires column virtualization.
> Virtualization mode is enabled when the row height is fixed by the following
> method.
>
> `tableView
On Mon, 31 Aug 2020 19:16:31 GMT, yosbits
wrote:
>
>
> Since there was a problem that the cell was not updated when the window was
> maximized, I added a fix to TreeTableViewSkin.java.
>
that's just the added listener to hbar properties (same as in TableViewSkin),
or anything else changed?
) and null observables (new) - this allows
> simplified code on rewiring "path" properties (see reference example in the
> issue)
Jeanette Winzenburg has updated the pull request incrementally with one
additional commit since the last revision:
replaced param name in chan
On Wed, 7 Apr 2021 13:11:52 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated doc of list/Change methods that of invalidation methods
>
> modules/javafx
On Mon, 12 Apr 2021 10:39:07 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
&
On Mon, 12 Apr 2021 13:59:13 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> replaced param name in changeListener methods
>
> modules/javafx.controls/src/
) and null observables (new) - this allows
> simplified code on rewiring "path" properties (see reference example in the
> issue)
Jeanette Winzenburg has updated the pull request incrementally with one
additional commit since the last revision:
changed description as s
On Mon, 12 Apr 2021 13:24:18 GMT, Kevin Rushforth wrote:
>
> The Draft CSR looks good, and should keep the monsters contained. 😄 Go ahead
> and move it to Proposed.
thanks, done :) Also updated to the most recent state (including Nir's
suggestion).
-
PR: https://git.openjdk.java
On Wed, 14 Apr 2021 11:58:14 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Added checks, whether
On Thu, 15 Apr 2021 12:55:56 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LambdaMultiplePropertyChangeListenerHandler.java
>> line 63:
>>
>>> 61: */
>>> 62: public final class LambdaMultiplePropertyChangeListenerHandler {
>>> 63: // FIXME: n
On Wed, 14 Apr 2021 11:58:14 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Added checks, whether
On Wed, 14 Apr 2021 11:58:14 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Added checks, whether
On Thu, 15 Apr 2021 12:57:30 GMT, Kevin Rushforth wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed description as suggested in review
>
> modules/javafx.controls/src/
) and null observables (new) - this allows
> simplified code on rewiring "path" properties (see reference example in the
> issue)
Jeanette Winzenburg has updated the pull request incrementally with one
additional commit since the last revision:
changed according to review
On Sat, 17 Apr 2021 14:23:32 GMT, Kevin Rushforth wrote:
>> changed as suggested. I used a similar pattern in BehaviorMemoryTest -
>> should I file a testbug to change it in the same way?
>
> Yes, please file a new bug (not high priority, since it is a corner case). I
> took a look and there ar
Issue is usage of JMemoryBuddy in module graphics (SceneTest, added in
[JDK-8264330](https://bugs.openjdk.java.net/browse/JDK-8264330).
Fix is to add-exports in Eclipse .classpath in graphics (same as done for
controls in fix of
[JDK-8256184](https://bugs.openjdk.java.net/browse/JDK-8256184)
the top of the failure trace:
org.junit.ComparisonFailure: expected:<...y, January 12, 60 Sh[ō]wa,
12:34:56 PM> but was:<...y, January 12, 60 Sh[o]wa, 12:34:56 PM>
at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at
test.j
to include this
one. I'd probably recommend the latter, since it is in the same
general area (a controls unit test that is failing because of a date
/ time format issue).
-- Kevin
On 4/20/2021 4:39 AM, Jeanette Winzenburg wrote:
the top of the failure trace:
org.junit.ComparisonFa
Issue is missing update of Tree-/TableCell's editiable state when changing its
index from editingIndex to -1.
Seems to be a left-over from fixing cell's editing update - done in
[JDK-8150525](https://bugs.openjdk.java.net/browse/JDK-8150525) - on index
change for the special case of new index
On Wed, 21 Apr 2021 10:49:25 GMT, Ambarish Rapte wrote:
> As mentioned in JBS the unit test execution fails when tests have a duplicate
> package name.
> This was introduced by JDK-8204568: it created a test in a new package
> `test.javafx.css` in controls tests. A similar package already exist
On Wed, 21 Apr 2021 14:07:21 GMT, Johan Vos wrote:
>> Issue is missing update of Tree-/TableCell's editiable state when changing
>> its index from editingIndex to -1.
>>
>> Seems to be a left-over from fixing cell's editing update - done in
>> [JDK-8150525](https://bugs.openjdk.java.net/brows
On Wed, 21 Apr 2021 14:22:21 GMT, Florian Kirmaier
wrote:
>
>
> Finally found time to update the PR.
>
> 1. As suggested, I've moved the updateIndex method below the if.
>
looks good :)
> 2. The test from 1 to -1 is a bit more complicated. Because -1 represents
> "not editing" the
On Thu, 22 Apr 2021 09:24:48 GMT, Ambarish Rapte wrote:
>> As mentioned in JBS the unit test execution fails when tests have a
>> duplicate package name.
>> This was introduced by JDK-8204568: it created a test in a new package
>> `test.javafx.css` in controls tests. A similar package already e
On Wed, 21 Apr 2021 17:53:34 GMT, Johan Vos wrote:
>> hmm .. don't quite understand your comment: it's a flag to tell cancelEdit
>> to not update control's editing state (that whole block is simply extracted
>> from the pre-fix state .. where it has been for ages ;) So the answer is
>> most pr
On Thu, 22 Apr 2021 11:00:43 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Fixed another index ca
On Tue, 20 Apr 2021 11:06:32 GMT, Jeanette Winzenburg
wrote:
> Issue is usage of JMemoryBuddy in module graphics (SceneTest, added in
> [JDK-8264330](https://bugs.openjdk.java.net/browse/JDK-8264330).
>
> Fix is to add-exports in Eclipse .classpath in graphics (same as done for
change for the special case of new index -1.
>
> Fixed by cleaning out editing state in that corner case also, added tests
> that were failing before and passing after the fix. Note that there are also
> tests that passed before: the previous fix didn't add any tests, so added
On Fri, 23 Apr 2021 11:40:00 GMT, Johan Vos wrote:
>> thanks for the explanation and spelling it out to me :)
>>
>>> But my question is about the pre- and postconditions. What would happen if
>>> a subclass overrides `cancelEdit` and throws an exception, so that
>>> `updateEditingIndex = true`
On Sat, 24 Apr 2021 20:55:52 GMT, mstr2
wrote:
>> This PR fixes the implementation of `ControlUtils.reducingChange`, which
>> incorrectly computed adjacent removed indices, thus resulting in incorrect
>> removal notifications.
>>
>> Since there were no unit tests for this method, I also added
On Fri, 23 Apr 2021 17:06:54 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> Added missing test cas
On Fri, 23 Apr 2021 16:52:14 GMT, Florian Kirmaier
wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellTest.java
>> line 867:
>>
>>> 865: @Test
>>> 866: public void testChangeIndexToEditing3_jdk_8264127() {
>>> 867: assertChangeIndexToEditing(1, -1
On Mon, 26 Apr 2021 11:24:40 GMT, Jeanette Winzenburg
wrote:
>> I guess it doesn't make sense. Probably missunderstanding somewhere. Should
>> i remove? This would also get rid of the if in the test.
>
> yes, remove it: the focus of this issue is that the cell sync
On Sun, 25 Apr 2021 15:36:49 GMT, mstr2
wrote:
>
>
> You're right that removing `ControlUtils.reducingChange` is enough to solve
> the problem. Maybe the method was created because it might be confusing that,
> while the indices are often not adjacent, they _are_ (as you correctly say)
> ad
On Sat, 24 Apr 2021 18:33:43 GMT, Kevin Rushforth wrote:
>
>
> Regarding [JDK-8189228](https://bugs.openjdk.java.net/browse/JDK-8189228), if
> this fix also fixes that issue, then either that issue should be closed as a
> duplicate or else that issue should be added to this PR with `/isuse ad
On Tue, 27 Apr 2021 10:00:44 GMT, Florian Kirmaier
wrote:
>
>
> I guess the different implementation in the different cells all have some
> subtle differences.
>
actually, I doubt that they are different - my guess: we could formally prove
that the logic is equivalent :) Or the other way:
On Tue, 27 Apr 2021 16:20:27 GMT, mstr2
wrote:
> This JBS issue lists the following issues:
>
> 1. The SelectedItems list does not get Remove change notifications in
> many cases
>
> 2. IndexOutOfBoundsException is thrown while changing the selection in
> some cases
>
> 3. If th
On Tue, 27 Apr 2021 19:10:29 GMT, mstr2
wrote:
> > The only very minor drawback is that it requires to update the Eclipse
> > classpath to add-exports for the base testing package (not a big deal).
>
> Can you share where specifically this needs to be added?
Could do, but if you aren't using
On Tue, 27 Apr 2021 16:30:52 GMT, mstr2
wrote:
> I think you're right that the same test could also be added for
> TreeTableView, and that the test should probably cover the entirety of the
> change notification. However, my preference is to not create a test that
> duplicates all aspects of
On Tue, 27 Apr 2021 19:18:59 GMT, mstr2
wrote:
>> This PR fixes the implementation of `ControlUtils.reducingChange`, which
>> incorrectly computed adjacent removed indices, thus resulting in incorrect
>> removal notifications.
>>
>> Since there were no unit tests for this method, I also added
On Wed, 28 Apr 2021 10:50:29 GMT, Jeanette Winzenburg
wrote:
> There is one more issue mentioned (2nd comment by OP): toggling selection
> throws an NPE - that's still the case, both with and without this PR.
*hach .. that's fixed by the most recent change in MultipleSe
On Mon, 22 Feb 2021 14:58:45 GMT, Jeanette Winzenburg
wrote:
> Changes in Lambda..Handler:
> - added api and implemenation to support invalidation and listChange
> listeners in the same way as changeListeners
> - added java doc
> - added tests
>
> Changes in SkinBa
On Wed, 21 Apr 2021 11:29:38 GMT, Jeanette Winzenburg
wrote:
> Issue is missing update of Tree-/TableCell's editiable state when changing
> its index from editingIndex to -1.
>
> Seems to be a left-over from fixing cell's editing update - done in
On Tue, 4 May 2021 12:29:54 GMT, Ambarish Rapte wrote:
> This issue [JDK-8264157](https://bugs.openjdk.java.net/browse/JDK-8264157) is
> a regression of
> [JDK-8209788](https://bugs.openjdk.java.net/browse/JDK-8209788), which
> removed two KeyMappings from `ComboBoxListViewBehavior`. That remo
On Mon, 3 May 2021 20:51:13 GMT, mstr2
wrote:
>> This PR fixes the implementation of `ControlUtils.reducingChange`, which
>> incorrectly computed adjacent removed indices, thus resulting in incorrect
>> removal notifications.
>>
>> Since there were no unit tests for this method, I also added
On Mon, 3 May 2021 20:51:13 GMT, mstr2
wrote:
>> This PR fixes the implementation of `ControlUtils.reducingChange`, which
>> incorrectly computed adjacent removed indices, thus resulting in incorrect
>> removal notifications.
>>
>> Since there were no unit tests for this method, I also added
Just sync'ed my local repository with upstream .. now can't build with
gradle, the error:
* Where:
Build file
'C:\Daten\data-for-work\eclipse\gitrep-openjdk\jfx-fork\build.gradle'
line: 4249
* What went wrong:
A problem occurred evaluating root project 'jfx-fork'.
Dependency verificat
CI builds.
Regards,
Ajit
On 11-May-2021, at 2:58 PM, Jeanette Winzenburg
wrote:
Just sync'ed my local repository with upstream .. now can't build
with gradle, the error:
* Where:
Build file
'C:\Daten\data-for-work\eclipse\gitrep-openjdk\jfx-fork\build.gradle' line:
radle
rm -rf caches native
gradle ...
If this doesn't work, I will propose that we disable checking of the
pom files in verification.xml.
-- Kevin
On 5/11/2021 2:28 AM, Jeanette Winzenburg wrote:
Just sync'ed my local repository with upstream .. now can't build
wi
was introduced with fix
[JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) which uses
MockListObserver in tests. Fix is analogous to previous eclipse build problems
(f.i. [JDK-8265513](https://bugs.openjdk.java.net/browse/JDK-8265513)):
add-exports to allow access to base' test pac
On Tue, 27 Apr 2021 09:26:05 GMT, Florian Kirmaier
wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellTest.java
>> line 921:
>>
>>> 919: assertFalse("cell must not be editing if cell index is " +
>>> cell.getIndex(), cell.isEditing());
>>> 920: a
On Wed, 12 May 2021 08:13:32 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> we now use a try final
On Tue, 11 May 2021 09:36:29 GMT, Jeanette Winzenburg
wrote:
> was introduced with fix
> [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) which uses
> MockListObserver in tests. Fix is analogous to previous eclipse build
> problems (f.i.
> [JDK
fix is analogous to similar issues for Tree/TableCell (combined
[JDK-8150525](https://bugs.openjdk.java.net/browse/JDK-8150525) and
[JDK-8265206](https://bugs.openjdk.java.net/browse/JDK-8265206))
added tests that failed before and passed after the fix
note: this PR also adds two asserts (which
1 - 100 of 642 matches
Mail list logo
