On Tue, 22 Nov 2022 22:16:46 GMT, Kevin Rushforth wrote:
>> rotationStartTime is a double. the type cast is really unnecessary
>
> But you don't know that without looking. Really, though, if I were going to
> make a readability argument, it's the divisor that should be a double
> constant, sin
On Tue, 22 Nov 2022 22:25:12 GMT, Kevin Rushforth wrote:
>> 100.0 is a double, so the result is also a double
>
> Right. Which is why I said that in this specific case it (meaning the changed
> code) is clear without the explicit cast. So I don't object to this
> particular change. I just used
On Tue, 22 Nov 2022 20:55:56 GMT, Kevin Rushforth wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be a
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style theme
On Tue, 22 Nov 2022 17:45:03 GMT, Ambarish Rapte wrote:
> Clean backport.
This pull request has now been integrated.
Changeset: 1c89a208
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/1c89a208af344373c5041fa8178db037b3b70ee8
Stats: 3 lines in 3 files changed: 0
On Tue, 22 Nov 2022 17:44:31 GMT, Ambarish Rapte wrote:
> Clean backport, Verified on Mac and Windows
This pull request has now been integrated.
Changeset: b5b112ac
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/b5b112ac96dc71e8408be2a1ba1df1e4ee2fca08
Stats: 2
On Tue, 22 Nov 2022 20:22:06 GMT, Andy Goryachev wrote:
>> Introduction
>>
>> There is a number of places where various listeners (strong as well as weak)
>> are added, to be later disconnected in one go. For example, Skin
>> implementations use dispose() method to clean up the listeners insta
This is regression from
[JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352).
[JDK-8043352](https://bugs.openjdk.org/browse/JDK-8043352) moved clearing
pending events in progress buffer when upstream sends EOS. We need to do this
for any other events except EOS. If we clear pending EOS, t
On Tue, 22 Nov 2022 22:30:16 GMT, Kevin Rushforth wrote:
>> I agree. The problem is that we will not be able to enable the warning in
>> IDE, or it has to be @suppressed.
>>
>> So the choice is either fix the code and enable warning, or keep the code as
>> is and disable the warning.
>
> I do
On Tue, 22 Nov 2022 22:23:52 GMT, Andy Goryachev wrote:
>> I would just revert it back.
>
> (long) width * height * 4;
> is dangerous if one does not remember the precedence rules - is typecast
> applied to width or the end result?
> 4L * w * h; is unambiguous.
I'm not sure I like either of the
On Tue, 22 Nov 2022 22:18:54 GMT, Andy Goryachev wrote:
>> If it aids readability, I don't see it as unnecessary. In this case, since
>> the types of all of the variables are not known, you could certainly argue
>> it doesn't matter much -- you need to look at the types to reason about what
>>
On Tue, 22 Nov 2022 22:15:12 GMT, Kevin Rushforth wrote:
>> Eclipse knows it is unnecessary. Personally, I am in favor of removing such
>> unnecessary code.
>
> If it aids readability, I don't see it as unnecessary. In this case, since
> the types of all of the variables are not known, you cou
On Tue, 22 Nov 2022 22:01:10 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/LauncherImpl.java
>> line 783:
>>
>>> 781: if (simulateSlowProgress) {
>>> 782: for (int i = 0; i < 100; i++) {
>>> 783:
On Tue, 22 Nov 2022 21:09:50 GMT, Kevin Rushforth wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be a
On Tue, 22 Nov 2022 18:39:43 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Tue, 22 Nov 2022 20:32:29 GMT, Kevin Rushforth wrote:
> Clean backport. CI build run on all three platforms.
This pull request has now been integrated.
Changeset: 16db4525
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx11u/commit/16db452513540b4e3f012f063d96e337cfd55e8a
S
Not a clean backport. The one line change to `build.properties` applied
cleanly. The other two files, `gradle/verification.metadata` and the GitHub
actions script, don't exist in jfx11u.
CI build run on Linux.
-
Commit messages:
- 8283402: Update to gcc 11.2 on Linux
Changes: htt
On Tue, 22 Nov 2022 20:31:23 GMT, Kevin Rushforth wrote:
> Not a clean backport. The one line change to `build.properties` applied
> cleanly. The other two files, `gradle/verification.metadata` and the GitHub
> actions script, don't exist in jfx11u.
>
> CI build run on Linux.
Reviewer: @arapt
On Tue, 22 Nov 2022 20:27:57 GMT, Kevin Rushforth wrote:
> Nearly clean backport, except for the changes in
> `gradle/verification.metadata`, since that file doesn't exist in jfx11u.
>
> CI build run on all three platforms.
Reviewer: @arapte or @johanvos
-
PR: https://git.openjdk
On Tue, 22 Nov 2022 20:29:10 GMT, Kevin Rushforth wrote:
> Nearly clean backport, except for the changes in
> `gradle/verification.metadata`, since that file doesn't exist in jfx11u, and
> a trivial merge conflict in the updated copyright line in 3 files.
>
> CI build run on all three platform
Clean backport. CI build run on all three platforms.
-
Commit messages:
- 8291087: Wrong position of focus of screen reader on Windows with screen
scale > 1
Changes: https://git.openjdk.org/jfx11u/pull/121/files
Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=121&range=00
Is
Nearly clean backport, except for the changes in
`gradle/verification.metadata`, since that file doesn't exist in jfx11u.
CI build run on all three platforms.
-
Commit messages:
- 8289541: Update ICU4C to 71.1
Changes: https://git.openjdk.org/jfx11u/pull/118/files
Webrev: https:/
Nearly clean backport, except for the changes in
`gradle/verification.metadata`, since that file doesn't exist in jfx11u, and a
trivial merge conflict in the updated copyright line in 3 files.
CI build run on all three platforms.
-
Commit messages:
- 8294400: Provide media support
- Remove unsupported/unnecessary SuppressWarning annotations
- Remove reduntant type specifications (use diamond operator)
- Remove unused or duplicate imports
- Remove unnecessary casts (type is already correct type or can be autoboxed)
- Remove unnecessary semi-colons (at end of class definitions
> Introduction
>
> There is a number of places where various listeners (strong as well as weak)
> are added, to be later disconnected in one go. For example, Skin
> implementations use dispose() method to clean up the listeners installed in
> the corresponding Control (sometimes using
> Lambda
On Tue, 22 Nov 2022 18:21:36 GMT, Ambarish Rapte wrote:
>> Not clean compared to jfx mainline.
>> But clean when backported from jfx17u.
>> Created this PR using commit hash from jfx17u.
>>
>> The `@since` tag still needs to modified, trying this fist commit to test if
>> the PR will be marked
On Fri, 4 Nov 2022 19:04:03 GMT, Kevin Rushforth wrote:
> we would need more descriptive names for `ChLi`, `MaChLi`, and so forth
> (presuming they need to be exposed).
they don't need to be exposed, will convert them to `private`.
-
PR: https://git.openjdk.org/jfx/pull/908
On Tue, 22 Nov 2022 19:06:47 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be aut
On Tue, 22 Nov 2022 18:35:36 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indent of 5 spaces to 4 spaces
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>
>
On Tue, 22 Nov 2022 18:41:16 GMT, John Hendrikx wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/AccordionTest.java
>> line 57:
>>
>>> 55:
>>> 56: @Before public void setup() {
>>> 57: tk = Toolkit.getToolkit();//This step is not needed (Just to
>>> make s
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class d
On Tue, 22 Nov 2022 18:45:13 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert changes to javafx.web src/main/native
>
> modules/javafx.swing/src/main/java/com/sun/javafx/embed/swing/newim
On Tue, 22 Nov 2022 16:49:52 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be aut
On Tue, 22 Nov 2022 18:41:18 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert changes to javafx.web src/main/native
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446
On Tue, 22 Nov 2022 18:45:58 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix warnings in fxml
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1497:
>
>> 1495: pu
On Tue, 22 Nov 2022 18:30:00 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert changes to javafx.web src/main/native
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line
On Tue, 22 Nov 2022 18:54:11 GMT, John Hendrikx wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 156:
>>
>>> 154:
>>> 155: @SuppressWarnings("unchecked")
>>> 156: public void add(Object element) {
>>
>> by removing a checked exception we are changing
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond
>> operators (ecj has no issues). I had two options, add a
>> `SuppressWarnings("unused")` or to use a lambda instead of a method
>> reference to make `javac` h
On Tue, 22 Nov 2022 18:54:39 GMT, John Hendrikx wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond
>> operators (ecj has no issues). I had two options, add a
>> `SuppressWarnings("unused")` or to use a lambda instead of a method
>> reference to make `javac` h
On Tue, 22 Nov 2022 17:38:37 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert "Fix warnings in fxml"
>>
>> This reverts commit b148aa3cc8a4676167a9eb8a023cddce3de116e7.
>
> modules/j
> Note: I ran into a `javac` compiler bug while replacing types with diamond
> operators (ecj has no issues). I had two options, add a
> `SuppressWarnings("unused")` or to use a lambda instead of a method reference
> to make `javac` happy. I choose the later and added a comment so it can be
>
On Tue, 22 Nov 2022 16:43:06 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be aut
On Tue, 22 Nov 2022 16:49:52 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be aut
On Tue, 22 Nov 2022 18:08:19 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert "Fix warnings in fxml"
>>
>> This reverts commit b148aa3cc8a4676167a9eb8a023cddce3de116e7.
>
> modules/j
Clean backport, tested on Mac and Windows.
-
Commit messages:
- 8289542: Update JPEG Image Decoding Software to 9e
Changes: https://git.openjdk.org/jfx11u/pull/116/files
Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=116&range=00
Issue: https://bugs.openjdk.org/browse/JDK-82
Clean backport, verified on Mac and Windows.
-
Commit messages:
- 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea &
TextField when deleted last char
Changes: https://git.openjdk.org/jfx11u/pull/117/files
Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=117&ra
Update: I had a quick look, downloaded the code and for a single scroll
event, there are 74 calls to updateItem. However, 69 of those are invoked
via
`com.jfoenix.skins.JFXListViewSkin.estimateHeight` which calls
`com.jfoenix.adapters.VirtualFlowHelper.forEach` which calls into
`VirtualFlow.setCell
On Tue, 22 Nov 2022 16:44:01 GMT, John Hendrikx wrote:
>> Note: I ran into a `javac` compiler bug while replacing types with diamond
>> operators (ecj has no issues). I had two options, add a
>> `SuppressWarnings("unused")` or to use a lambda instead of a method
>> reference to make `javac` h
> Not clean compared to jfx mainline.
> But clean when backported from jfx17u.
> Created this PR using commit hash from jfx17u.
>
> The `@since` tag still needs to modified, trying this fist commit to test if
> the PR will be marked as clean.
Ambarish Rapte has updated the pull request increment
Not clean compared to jfx mainline.
But clean when backported from jfx17u.
Created this PR using commit hash from jfx17u.
The `@since` tag still needs to modified, trying this fist commit to test if
the PR will be marked as clean.
-
Commit messages:
- 8087557: [Win] [Accessibility,
Clean backport.
-
Commit messages:
- 8294722: FX: Update copyright year in docs, readme files to 2023
Changes: https://git.openjdk.org/jfx17u/pull/100/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=100&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8294722
Stats
Clean backport, Verified on Mac and Windows
-
Commit messages:
- 8293795: [Accessibility] [Win] [Narrator] Exceptions when deleting text with
continous key press in TextArea and TextField
Changes: https://git.openjdk.org/jfx17u/pull/99/files
Webrev: https://webrevs.openjdk.org/?re
Hi Glavo,
I could see there are many UI-related operations in some of the updateItems
-- room for improvement that we can discuss off-list.
Having said that, I agree with the confusing part about updateItem being
called without the item being rendered.
- Johan
On Tue, Nov 22, 2022 at 12:17 PM G
On Tue, 22 Nov 2022 16:03:53 GMT, Ambarish Rapte wrote:
> Clean backport, Verified on Mac and Windows
This pull request has now been integrated.
Changeset: 3a79a154
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/3a79a154ab96d19cd9e5a0cc2bf3ad8744852bbb
Stats: 2
On Tue, 22 Nov 2022 16:03:03 GMT, Ambarish Rapte wrote:
> Clean backport, Verified on Mac and Windows
This pull request has now been integrated.
Changeset: 547252e8
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/547252e84896a2034a9b8c98fc9ab23df7025344
Stats: 5
On Tue, 22 Nov 2022 15:09:30 GMT, Kevin Rushforth wrote:
> I just noticed that this touches files under `javafx.web/src/main/native`.
> This will cause extra work for us, since we keep all of the files under
> `javafx.web/src/main/native` in sync across release families (and we will
> definite
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class d
> Note: I ran into a `javac` compiler bug while replacing types with diamond
> operators (ecj has no issues). I had two options, add a
> `SuppressWarnings("unused")` or to use a lambda instead of a method reference
> to make `javac` happy. I choose the later and added a comment so it can be
>
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class d
> Note: I ran into a `javac` compiler bug while replacing types with diamond
> operators (ecj has no issues). I had two options, add a
> `SuppressWarnings("unused")` or to use a lambda instead of a method reference
> to make `javac` happy. I choose the later and added a comment so it can be
>
Clean backport, Verified on Mac and Windows
-
Commit messages:
- 8284281: [Accessibility] [Win] [Narrator] Exceptions with TextArea &
TextField when deleted last char
Changes: https://git.openjdk.org/jfx17u/pull/98/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=98&range
Clean backport, Verified on Mac and Windows
-
Commit messages:
- 8289542: Update JPEG Image Decoding Software to 9e
Changes: https://git.openjdk.org/jfx17u/pull/97/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=97&range=00
Issue: https://bugs.openjdk.org/browse/JDK-828
On Sun, 11 Sep 2022 12:13:47 GMT, Johan Vos wrote:
> Don't set TabHeader to mouseTransparent, since it might get stuck in that
> state (e.g. in case an Alert is shown).
> The TabPaneSkin deals with the dragging internally, and does not require the
> dragged node to be mouseTransparent.
This pu
Hi Craig,
That boils down to the same issue I described earlier in this thread, and
that is also mentioned on https://bugs.openjdk.org/browse/JDK-8280442. I
agree the workaround does not look pretty (I suggested it myself), but the
fact that it works is not by accident. There is indeed a differenc
On Tue, 22 Nov 2022 11:13:40 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Tue, 22 Nov 2022 11:13:40 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Tue, 22 Nov 2022 12:24:31 GMT, Kevin Rushforth wrote:
> Nearly clean backport to jfx17u (trivial conflict in the diff for the
> copyright line in two files).
>
> CI build run on all three platforms.
This pull request has now been integrated.
Changeset: b39260ce
Author:Kevin Rushforth
On Mon, 21 Nov 2022 20:05:10 GMT, Ambarish Rapte wrote:
> Backport this a11y fix to jfx17u.
> This is not a clean backport. The source code changes apply cleanly but there
> was a conflict in test file.
> The test `DialogTest.java` file does not exist in jfx17u source.
> The file is now added bu
On Tue, 22 Nov 2022 12:24:31 GMT, Kevin Rushforth wrote:
> Nearly clean backport to jfx17u (trivial conflict in the diff for the
> copyright line in two files).
>
> CI build run on all three platforms.
Marked as reviewed by arapte (Reviewer).
-
PR: https://git.openjdk.org/jfx17u/
Note: I ran into a `javac` compiler bug while replacing types with diamond
operators (ecj has no issues). I had two options, add a
`SuppressWarnings("unused")` or to use a lambda instead of a method reference
to make `javac` happy. I choose the later and added a comment so it can be
fixed onc
On Fri, 28 Oct 2022 13:54:40 GMT, eduardsdv wrote:
>> This fixes a race condition between application and 'Print Job Thread'
>> threads when printing.
>>
>> The race condition occurs when application thread calls `endJob()`, which in
>> effect sets the `jobDone` flag to true,
>> and when the '
On Sat, 19 Nov 2022 18:01:41 GMT, Michael Strauß wrote:
> This PR fixes a bug where multi-level focus is not correctly preserved.
> The original implementation incorrectly assumed that there can only be a
> single focused node in the scene graph, which is not the case when a branch
> of the sce
On Tue, 22 Nov 2022 11:13:40 GMT, John Hendrikx wrote:
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autobox
On Mon, 21 Nov 2022 23:59:51 GMT, Andy Goryachev wrote:
> > Just making sure, I can integrate this now?
>
> format requirements have been fulfilled (1 reviewer, 1 author). go!
Yes, this one was ready to go, thanks for checking.
As a general comment, and not specific to this review, I want to r
Nearly clean backport to jfx17u (trivial conflict in the diff for the copyright
line in two files).
CI build run on all three platforms.
-
Commit messages:
- 8294400: Provide media support for libavcodec version 59
Changes: https://git.openjdk.org/jfx17u/pull/96/files
Webrev: htt
On Mon, 21 Nov 2022 23:43:01 GMT, Kevin Rushforth wrote:
> Clean backport. CI build run on all three platforms.
This pull request has now been integrated.
Changeset: f34d86d3
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx17u/commit/f34d86d39945fbbe5968e756bd0efbf18d84e13d
S
I encountered the same problem and described my solution here:
https://mail.openjdk.org/pipermail/openjfx-dev/2022-July/034764.html
It's not pretty but it does seem to work.
On Tue, Nov 22, 2022 at 1:18 PM Glavo wrote:
> We created an advanced list with titles, subtitles, icons, and tags, and
>
On Mon, 21 Nov 2022 23:43:41 GMT, Kevin Rushforth wrote:
> Clean backport. CI build run on Linux.
This pull request has now been integrated.
Changeset: 76bbd593
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx17u/commit/76bbd593f8437b2ce3095ffb6d94bedd22a65b3b
Stats: 6 li
On Mon, 21 Nov 2022 23:42:26 GMT, Kevin Rushforth wrote:
> Clean backport. CI build run on all three platforms.
This pull request has now been integrated.
Changeset: 04b32321
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx17u/commit/04b32321bd22f2e6fa5373a53f67b116bd570a53
S
On Tue, 22 Nov 2022 04:49:15 GMT, Ambarish Rapte wrote:
>> Backport this a11y fix to jfx17u.
>> This is not a clean backport. The source code changes apply cleanly but
>> there was a conflict in test file.
>> The test `DialogTest.java` file does not exist in jfx17u source.
>> The file is now add
On Tue, 22 Nov 2022 03:46:57 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Correct @since
>
> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleRole.java line
> 836:
>
>> 834:
- Remove unsupported/unnecessary SuppressWarning annotations
- Remove reduntant type specifications (use diamond operator)
- Remove unused or duplicate imports
- Remove unnecessary casts (type is already correct type or can be autoboxed)
- Remove unnecessary semi-colons (at end of class definitions
We created an advanced list with titles, subtitles, icons, and tags, and
updated these contents in the updateItem.
I took a screenshot of it and uploaded it as a comment to GitHub next to
the relevant code:
https://github.com/huanghongxun/HMCL/pull/1849/commits/4f8cde63acf959d85416b706acf22f9b3c8
That is good food indeed. It would be sort of a circumvention of what is
often leading to major issues of different kinds: the Cell.updateItem is
used for a number of differen goals. The javadoc for this one [1] is
already an indication that this is something dangerous:"It is very
important that su
I agree, I implemented something similar already. I will share it here right away, up for discussion if this is worth to add. :)
In (Tree)TableView:
setCellSizeProvider(ToDoubleFunction cellSizeProvider)
In (Tree)TableRow:
ToDoubleFunction cellSizeProvider = tableView.getCellSizeProvider()
Food for thought: something that might be nice to have could be a separate
model that tells the VirtualFlows what the row heights are. In FlexGanttFX the
height of each row is explicitly controlled by a heightProperty() of a “row"
class and not by calculation. E.g. VirtualFlow.setHeightProvider(
There is actually a ticket for the problem that the table slows down more and more when scrolling to the bottom:
https://bugs.openjdk.org/browse/JDK-8293836
This also happens when setting the fixed cell size, so there is 100% a bug somewhere down there.
-- Marius
Gesendet: Dienstag, 22.
I took a quick look, I didn't see any Node creation, the updateItem
calls look pretty normal (setting some labels and a list of tags).
I downloaded the application and installed the application (it's nicely
packaged) and clicked on "download" which shows the problematic list.
It indeed perfor
On Wed, 14 Sep 2022 18:44:14 GMT, Marius Hanl wrote:
> This PR fixes a memory leak in dnd code in the `MouseHandler` of a `Scene`.
> The memory leak occurs after calling `startFullDrag()`. The
> `fullPDRTmpTargetWrapper` is then populated but never cleared.
> Fix is to call `clear()` on the `ful
On Wed, 14 Sep 2022 18:44:14 GMT, Marius Hanl wrote:
> This PR fixes a memory leak in dnd code in the `MouseHandler` of a `Scene`.
> The memory leak occurs after calling `startFullDrag()`. The
> `fullPDRTmpTargetWrapper` is then populated but never cleared.
> Fix is to call `clear()` on the `ful
Hi Glavo,
There are more frequent calls to updateItem() since the VirtualFlow tries
to gradually improve its estimation how large the total list size is
(rather than assuming all cells have the same size). The major point is
that if you override updateItem, it should not do more than strictly need
Hi,
I'm one of the maintainers of the open source project HMCL (Hello!
Minecraft Launcher*)*. This is a Minecraft launcher based on JavaFX.
In the past year, we have received a lot of feedback on performance
problems. Through performance analysis, I noticed that from JavaFX 17 ea+8,
the performan
92 matches
Mail list logo
