Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v13]

2023-04-27 Thread John Neffenger
On Wed, 26 Apr 2023 03:59:36 GMT, John Neffenger wrote: > I created bug reports to track each of the remaining potential problems: I forgot the original remaining problem! It's listed as item 4 under **Fixes** in the description at the top of this pull request and now described by the

Re: RFR: 8299335: Monkey Tester Application [v13]

2023-04-27 Thread Andy Goryachev
> Monkey Tester - a JavaFX application designed to support manual ad-hoc > testing of individual JavaFX controls. > > Feedback and suggestions are always welcome. > > ![screenshot](https://user-images.githubusercontent.com/107069028/232911797-3d02da68-ce11-419e-8f16-c2661b778f9c.png) Andy

Re: RFR: 8299335: Monkey Tester Application [v12]

2023-04-27 Thread Andy Goryachev
> Monkey Tester - a JavaFX application designed to support manual ad-hoc > testing of individual JavaFX controls. > > Feedback and suggestions are always welcome. > > ![screenshot](https://user-images.githubusercontent.com/107069028/232911797-3d02da68-ce11-419e-8f16-c2661b778f9c.png) Andy

Re: RFR: 8299335: Monkey Tester Application [v11]

2023-04-27 Thread Andy Goryachev
> Monkey Tester - a JavaFX application designed to support manual ad-hoc > testing of individual JavaFX controls. > > Feedback and suggestions are always welcome. > > ![screenshot](https://user-images.githubusercontent.com/107069028/232911797-3d02da68-ce11-419e-8f16-c2661b778f9c.png) Andy

Re: RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims [v3]

2023-04-27 Thread Ambarish Rapte
> Add `TEST_ONLY` flag to gradle with default value as false. > Add new task named `shims`, This task depends on all shim tasks from all > projects. Hence it will build all shim classes. > > If TEST_ONLY is set to true, the all non test tasks get disabled. When > running a test task, this flag

Re: RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims [v2]

2023-04-27 Thread Ambarish Rapte
> Add `TEST_ONLY` flag to gradle with default value as false. > Add new task named `shims`, This task depends on all shim tasks from all > projects. Hence it will build all shim classes. > > If TEST_ONLY is set to true, the all non test tasks get disabled. When > running a test task, this flag

Re: RFR: 8299335: Monkey Tester Application [v10]

2023-04-27 Thread Andy Goryachev
> Monkey Tester - a JavaFX application designed to support manual ad-hoc > testing of individual JavaFX controls. > > Feedback and suggestions are always welcome. > > ![screenshot](https://user-images.githubusercontent.com/107069028/232911797-3d02da68-ce11-419e-8f16-c2661b778f9c.png) Andy

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

2023-04-27 Thread John Hendrikx
On Thu, 27 Apr 2023 19:04:39 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

2023-04-27 Thread Andy Goryachev
On Thu, 27 Apr 2023 19:32:02 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/RegionTest.java >> line 1281: >> >>> 1279: } >>> 1280: >>> 1281: random.setSeed(seed); >> >> it might be better to set the seed only once at the beginning.

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

2023-04-27 Thread John Hendrikx
On Thu, 27 Apr 2023 15:27:14 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

2023-04-27 Thread Andy Goryachev
On Thu, 27 Apr 2023 19:04:39 GMT, John Hendrikx wrote: >> Region has floor and ceiling functions that ensure that calling them twice >> in a row will yield the same result: >> >> ceil(x) = ceil(ceil(x)) >> >> However, due to use of a constant `EPSILON` which is added/subtracted before

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

2023-04-27 Thread John Hendrikx
> Region has floor and ceiling functions that ensure that calling them twice in > a row will yield the same result: > > ceil(x) = ceil(ceil(x)) > > However, due to use of a constant `EPSILON` which is added/subtracted before > doing the rounding, this only works for small numbers (in the

Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v5]

2023-04-27 Thread Martin Fox
> The algorithm in `KeyCharacterCombination.match` relies on the call > `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It > defies the way most keyboard API’s work and no platform has got it right yet. > In particular the Mac and Linux implementations have to resort to a

Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v4]

2023-04-27 Thread Martin Fox
> The algorithm in `KeyCharacterCombination.match` relies on the call > `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It > defies the way most keyboard API’s work and no platform has got it right yet. > In particular the Mac and Linux implementations have to resort to a

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v5]

2023-04-27 Thread Jose Pereda
On Tue, 25 Apr 2023 00:31:07 GMT, Thiago Milczarek Sayao wrote: >> That seems good enough to verify that the window doesn't stay showing. > > @kevinrushforth I was checking and `SceneChangeShouldNotFocusStageTest` added > on [JDK-8296621](https://bugs.openjdk.org/browse/JDK-8296621) does

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values

2023-04-27 Thread Andy Goryachev
On Thu, 27 Apr 2023 10:11:42 GMT, John Hendrikx wrote: > Region has floor and ceiling functions that ensure that calling them twice in > a row will yield the same result: > > ceil(x) = ceil(ceil(x)) > > However, due to use of a constant `EPSILON` which is added/subtracted before > doing

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values

2023-04-27 Thread Andy Goryachev
On Thu, 27 Apr 2023 10:11:42 GMT, John Hendrikx wrote: > Region has floor and ceiling functions that ensure that calling them twice in > a row will yield the same result: > > ceil(x) = ceil(ceil(x)) > > However, due to use of a constant `EPSILON` which is added/subtracted before > doing

Re: RFR: 8299335: Monkey Tester Application [v9]

2023-04-27 Thread Andy Goryachev
On Thu, 27 Apr 2023 14:08:56 GMT, Karthik P K wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> snapping in hbox page > > Tested the Chart, ChoiceBox, ComboBox, DatePicker, Label, Spinner, Text, > TextArea and

Re: RFR: 8299335: Monkey Tester Application [v9]

2023-04-27 Thread Karthik P K
On Wed, 26 Apr 2023 19:57:54 GMT, Andy Goryachev wrote: >> Monkey Tester - a JavaFX application designed to support manual ad-hoc >> testing of individual JavaFX controls. >> >> Feedback and suggestions are always welcome. >> >>

Integrated: 8296590: StraightLineTest fails always on Linux and sometimes on other platforms

2023-04-27 Thread Jay Bhaskar
On Tue, 25 Apr 2023 11:42:28 GMT, Jay Bhaskar wrote: > Issue: The test fails, in case snapshot is taken before web view finish web > content load > Solution: Introduce a sleep , before taking snapshot of web view , to test > straight line This pull request has now been integrated. Changeset:

Re: RFR: 8296590: StraightLineTest fails always on Linux and sometimes on other platforms

2023-04-27 Thread Kevin Rushforth
On Tue, 25 Apr 2023 20:02:58 GMT, Johan Vos wrote: > We have seen similar issues with snapshots containing WebView. I agree that > adding a sleep fixes the issue here, but it would be great if we can have a > clear path that indicates when a snapshot can successfully be taken. Yes, we should

Re: RFR: 8296590: StraightLineTest fails always on Linux and sometimes on other platforms [v3]

2023-04-27 Thread Kevin Rushforth
On Thu, 27 Apr 2023 13:23:53 GMT, Jay Bhaskar wrote: >> Issue: The test fails, in case snapshot is taken before web view finish web >> content load >> Solution: Introduce a sleep , before taking snapshot of web view , to test >> straight line > > Jay Bhaskar has updated the pull request

Re: RFR: 8296590: StraightLineTest fails always on Linux and sometimes on other platforms [v3]

2023-04-27 Thread Jay Bhaskar
> Issue: The test fails, in case snapshot is taken before web view finish web > content load > Solution: Introduce a sleep , before taking snapshot of web view , to test > straight line Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8296590: StraightLineTest fails always on Linux and sometimes on other platforms [v2]

2023-04-27 Thread Kevin Rushforth
On Thu, 27 Apr 2023 02:34:53 GMT, Jay Bhaskar wrote: >> Issue: The test fails, in case snapshot is taken before web view finish web >> content load >> Solution: Introduce a sleep , before taking snapshot of web view , to test >> straight line > > Jay Bhaskar has updated the pull request

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v6]

2023-04-27 Thread Johan Vos
On Mon, 24 Apr 2023 23:35:14 GMT, Thiago Milczarek Sayao wrote: >> I replicated the fix on #1054 on Linux. >> >> Also fixes [Monocle: Stage no longer gets focus after fix for >> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734) > > Thiago Milczarek Sayao has updated the pull request

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values

2023-04-27 Thread Kevin Rushforth
On Thu, 27 Apr 2023 10:11:42 GMT, John Hendrikx wrote: > Region has floor and ceiling functions that ensure that calling them twice in > a row will yield the same result: > > ceil(x) = ceil(ceil(x)) > > However, due to use of a constant `EPSILON` which is added/subtracted before > doing

Re: RFR: 8306648: Update the JavaDocs to show the NEW section and DEPRECATED versions [v2]

2023-04-27 Thread Nir Lisker
> Adds the javadoc commands to generate the NEW page and to be able to select > versions in the DEPRECATED page. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Auto-detect latest version - Changes: - all:

RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values

2023-04-27 Thread John Hendrikx
Region has floor and ceiling functions that ensure that calling them twice in a row will yield the same result: ceil(x) = ceil(ceil(x)) However, due to use of a constant `EPSILON` which is added/subtracted before doing the rounding, this only works for small numbers (in the range of 0-50

Withdrawn: 8271205: [windows] Intermittent test failure in test.javafx.scene.web.MiscellaneousTest::testDOMTimer

2023-04-27 Thread Jay Bhaskar
On Tue, 25 Apr 2023 06:41:56 GMT, Jay Bhaskar wrote: > Issue: [windows] Intermittent test failure in > test.javafx.scene.web.MiscellaneousTest::testDOMTimer > Analysis: > setTimeout call is not a real-time function. it is considered just a minimum > delay before the callback is executed. The

RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims

2023-04-27 Thread Ambarish Rapte
Add `TEST_ONLY` flag to gradle with default value as false. Add new task named `shims`, This task depends on all shim tasks from all projects. Hence it will build all shim classes. If TEST_ONLY is set to true, the all non test tasks get disabled. When running a test task, this flag would reduce

Re: RFR: 8306648: Update the JavaDocs to show the NEW section and DEPRECATED versions

2023-04-27 Thread Nir Lisker
On Fri, 21 Apr 2023 13:30:38 GMT, Nir Lisker wrote: > 3. Each major release, a new version string will need to be added. This can be solved by reading the major version directly from the properties file, but it would require to script the generation of the string that includes the versions.

Re: RFR: 8299335: Monkey Tester Application [v9]

2023-04-27 Thread John Hendrikx
On Wed, 26 Apr 2023 19:57:54 GMT, Andy Goryachev wrote: >> Monkey Tester - a JavaFX application designed to support manual ad-hoc >> testing of individual JavaFX controls. >> >> Feedback and suggestions are always welcome. >> >>

Re: RFR: 8304831: TextFlow.hitTest.insertionIndex incorrect with surrogate pairs

2023-04-27 Thread Karthik P K
On Wed, 26 Apr 2023 19:47:43 GMT, Andy Goryachev wrote: > > I'm also seeing same issue > > I wonder what could be the difference? text size? Text size is one difference. One more observation I made is that if the emojis and text in the TextFlow are separate text nodes then this fix works. If