Hi! Devs it's my first message at openjfx-dev@openjdk.org. I am using the
jfoenix material design library in my projects.
It's a very nice and best library in Javafx. But unfortunately it's
official support has stopped for years.
Official git repo: https://github.com/sshahine/JFoenix/tree/JFoeni
On Fri, 19 Jan 2024 23:39:59 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Switched to local array variables
>
> I think this code crashes on macOS with Arabic input...
>
> correction: not cras
On Thu, 11 Jan 2024 20:13:09 GMT, Marius Hanl wrote:
> For some reason the `skinProperty` did not allow to set a new skin when it is
> the same class as the previous one.
> This leads to multiple issues:
> 1. When creating a new skin (same class as previous), the skin will likely
> install list
On Fri, 19 Jan 2024 16:15:10 GMT, Martin Fox wrote:
>> On Windows we need to ensure InputMethodRequests coming from JFXPanel are
>> processed on the JavaFX application thread instead of the AWT EventQueue
>> thread. This PR adds the runAndWait() calls to do that.
>>
>> This would be difficult
On Fri, 19 Jan 2024 16:15:10 GMT, Martin Fox wrote:
>> On Windows we need to ensure InputMethodRequests coming from JFXPanel are
>> processed on the JavaFX application thread instead of the AWT EventQueue
>> thread. This PR adds the runAndWait() calls to do that.
>>
>> This would be difficult
On Fri, 19 Jan 2024 16:15:10 GMT, Martin Fox wrote:
>> On Windows we need to ensure InputMethodRequests coming from JFXPanel are
>> processed on the JavaFX application thread instead of the AWT EventQueue
>> thread. This PR adds the runAndWait() calls to do that.
>>
>> This would be difficult
Thanks, Nir.
I see that Michael replied to this thread a short time ago with a pretty
convincing argument for letting the change make in JDK-8159048 stand.
-- Kevin
On 1/19/2024 2:06 PM, Nir Lisker wrote:
I will look at this tomorrow due to the short time window. Haven't
kept up with this t
There are several issues (bugs and enhancements) still targeted to jfx22
in JBS. Given that we are in rampdown for JavaFX 22, and that fixes
first go into the master branch for jfx23, I will bulk moved all of them
to jfx23 shortly. Once they are fixed and integrated into master for
jfx23, they
I will look at this tomorrow due to the short time window. Haven't kept up
with this thread.
On Fri, Jan 19, 2024 at 10:34 PM Kevin Rushforth
wrote:
> Hi Jurgen,
>
> There is a very short window for making any changes like this that
> require a CSR in JavaFX 22. If we were to do what you suggest
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
Hi Jurgen,
the start, stop, pause, etc. methods on the Animation class cannot
reasonably work in the way you suggest.
While it is generally possible to construct a JavaFX object graph on a
thread other than the JavaFX application thread, this relies on the
fact that JavaFX will not interfere with
On Sun, 14 Jan 2024 16:06:42 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show d
On Fri, 19 Jan 2024 12:47:29 GMT, Marius Hanl wrote:
> This pull request contains a (clean) backport of commit
> [872dbc8a](https://github.com/openjdk/jfx/commit/872dbc8a2d254cba4df33fcc778b15b1a3c9b69f)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> Target branch is **j
On Fri, 19 Jan 2024 16:07:31 GMT, Michael Strauß wrote:
> The `Animation` class states in the documentation of various methods that the
> method call would be asynchronous, using language similar to:
>
>
> {@code stop()} is an asynchronous call, the {@code Animation} may not stop
> immediatel
Hi Jurgen,
There is a very short window for making any changes like this that
require a CSR in JavaFX 22. If we were to do what you suggest, we would
need to:
1. File a new Enhancement request to:
-- revert JDK-8159048 (except for the doc changes about Animation being
run on the FX applicati
On Fri, 19 Jan 2024 17:54:17 GMT, Andy Goryachev wrote:
> > Scene Builder releases are always tight to the JavaFX version
>
> Thank you for clarification! Still, there might be other tools out there that
> we don't know of.
That's always possible. I couldn't find anything with an internet sea
On Fri, 19 Jan 2024 18:12:26 GMT, Kevin Rushforth wrote:
> I note that we could still consider deprecating the `SimpleSelector` and
> `CompoundSelector` classes for _eventual_ removal, but it wouldn't have to be
> done in such a rush.
That's certainly true, the only reason we wanted to do a qu
On Fri, 19 Jan 2024 10:21:05 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructe
On Fri, 19 Jan 2024 18:12:26 GMT, Kevin Rushforth wrote:
> I note that we could still consider deprecating the `SimpleSelector` and
> `CompoundSelector` classes for _eventual_ removal
I like the idea of deprecating with the following removal, coupled with adding
the "missing" APIs to Selector.
On Fri, 19 Jan 2024 10:21:05 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructe
On Fri, 19 Jan 2024 10:21:05 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructe
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
On Fri, 19 Jan 2024 17:52:31 GMT, Jose Pereda wrote:
> Scene Builder releases are always tight to the JavaFX version
Thank you for clarification!
Still, there might be other tools out there that we don't know of.
-
PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1900
On Fri, 19 Jan 2024 01:06:50 GMT, Jay Bhaskar wrote:
>> Issue: constructor Path(Path) which takes another Path object fails to draw
>> on canvas html.
>> Solution: copy the old path while creating a new Path object from the
>> existing Path that is already created with the same canvas rendering
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
On Fri, 19 Jan 2024 10:21:05 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructe
> On Windows we need to ensure InputMethodRequests coming from JFXPanel are
> processed on the JavaFX application thread instead of the AWT EventQueue
> thread. This PR adds the runAndWait() calls to do that.
>
> This would be difficult to test on Windows without a fix for
> [JDK-8090267](https
The `Animation` class states in the documentation of various methods that the
method call would be asynchronous, using language similar to:
{@code stop()} is an asynchronous call, the {@code Animation} may not stop
immediately.
This is factually wrong, there are no asynchronous calls. In fact
On Fri, 19 Jan 2024 15:37:33 GMT, Andy Goryachev wrote:
>> @andy-goryachev-oracle Scenic View source code doesn't use neither of them.
>>
>> However, Scene Builder does:
>> https://github.com/gluonhq/scenebuilder/blob/master/kit/src/main/java/com/oracle/javafx/scenebuilder/kit/util/CssInternal.
On Fri, 19 Jan 2024 16:07:31 GMT, Michael Strauß wrote:
> The `Animation` class states in the documentation of various methods that the
> method call would be asynchronous, using language similar to:
>
>
> {@code stop()} is an asynchronous call, the {@code Animation} may not stop
> immediatel
> The SimpleSelector and CompoundSelector classes are public classes in an
> exported package, javafx.css, but they are not intended to be used by
> applications. They are implementation details. They cannot be constructed
> directly and no other JavaFX API accepts or returns a SimpleSelector or
On Fri, 19 Jan 2024 10:02:19 GMT, John Hendrikx wrote:
> The SimpleSelector and CompoundSelector classes are public classes in an
> exported package, javafx.css, but they are not intended to be used by
> applications. They are implementation details. They cannot be constructed
> directly and n
On Fri, 19 Jan 2024 09:50:44 GMT, Jose Pereda wrote:
> However, Scene Builder does:
Thank you, @jperedadnr !
Does this mean that we ought to add a public method to Selector?
-
PR Comment: https://git.openjdk.org/jfx/pull/1333#issuecomment-1900643988
On Mon, 15 Jan 2024 15:09:45 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 21.0.2.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=45268
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.
On Tue, 16 Jan 2024 20:30:01 GMT, Johan Vos wrote:
> Start work on 21.0.3
This pull request has now been integrated.
Changeset: 6893bb38
Author:Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/6893bb3878b311270fee367451c31467780320dd
Stats: 2 lines in 2 files changed: 0 ins;
On Tue, 16 Jan 2024 17:59:42 GMT, Martin Fox wrote:
> On Windows we need to ensure InputMethodRequests coming from JFXPanel are
> processed on the JavaFX application thread instead of the AWT EventQueue
> thread. This PR adds the runAndWait() calls to do that.
>
> This would be difficult to te
On Fri, 19 Jan 2024 12:47:29 GMT, Marius Hanl wrote:
> This pull request contains a (clean) backport of commit
> [872dbc8a](https://github.com/openjdk/jfx/commit/872dbc8a2d254cba4df33fcc778b15b1a3c9b69f)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> Target branch is **j
On Fri, 19 Jan 2024 12:37:48 GMT, Marius Hanl wrote:
> Ahh, makes sense, thanks. First time backporting. :)
Yeah, and it's somewhat confusing to have jfx22u active during RDP1 of JavaFX
22 where most fixes that go back into the 22 code line will want to go into 22
GA rather than 22.0.1. I had
On Fri, 19 Jan 2024 12:47:29 GMT, Marius Hanl wrote:
> This pull request contains a (clean) backport of commit
> [872dbc8a](https://github.com/openjdk/jfx/commit/872dbc8a2d254cba4df33fcc778b15b1a3c9b69f)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> Target branch is **j
On Fri, 19 Jan 2024 10:02:19 GMT, John Hendrikx wrote:
> The SimpleSelector and CompoundSelector classes are public classes in an
> exported package, javafx.css, but they are not intended to be used by
> applications. They are implementation details. They cannot be constructed
> directly and n
On Fri, 19 Jan 2024 01:06:50 GMT, Jay Bhaskar wrote:
>> Issue: constructor Path(Path) which takes another Path object fails to draw
>> on canvas html.
>> Solution: copy the old path while creating a new Path object from the
>> existing Path that is already created with the same canvas rendering
This pull request contains a (clean) backport of commit
[872dbc8a](https://github.com/openjdk/jfx/commit/872dbc8a2d254cba4df33fcc778b15b1a3c9b69f)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
Target branch is **jfx22**.
-
Commit messages:
- Backport 872dbc8a2d25
On Thu, 18 Jan 2024 16:41:31 GMT, Kevin Rushforth wrote:
> So I recommend abandoning the above PR and instead target the jfx22 branch of
> the jfx repo: `/backport jfx jfx22` instead.
Ahh, makes sense, thanks. First time backporting. :)
I deleted the backport branch in jfx22u.
-
P
Hi Kevin
I was hoping that others would way in on this fix (PR #1167), but now that
we're in RDP1 with no other input coming in I decided to looked into this
matter again and have found that this is not the correct solution for the
following two reasons:
1. The current solution doesn't ac
On Fri, 19 Jan 2024 10:02:19 GMT, John Hendrikx wrote:
> The SimpleSelector and CompoundSelector classes are public classes in an
> exported package, javafx.css, but they are not intended to be used by
> applications. They are implementation details. They cannot be constructed
> directly and n
On Fri, 19 Jan 2024 11:40:27 GMT, Nir Lisker wrote:
> Should this deprecation happen in 22 already so that they can be removed in
> 23?
That's the idea, but it needs to go in 23 first so it can be backported to 22
(Kevin mentioned as much in the linked ticket)
-
PR Comment: https
On Fri, 19 Jan 2024 10:02:19 GMT, John Hendrikx wrote:
> The SimpleSelector and CompoundSelector classes are public classes in an
> exported package, javafx.css, but they are not intended to be used by
> applications. They are implementation details. They cannot be constructed
> directly and n
On Fri, 19 Jan 2024 09:52:23 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/Selector.java line 179:
>>
>>> 177: * @throws IOException if reading from {@code DataInputStream}
>>> fails
>>> 178: */
>>> 179: protected static Selector readBinary(int bssV
> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>
> This can be done with only a minor API break, as `SimpleSelector` and
> `CompoundSelector` were public before. However, these classes could not be
> constructed by 3rd parties. The only way to access them was by doing a
The SimpleSelector and CompoundSelector classes are public classes in an
exported package, javafx.css, but they are not intended to be used by
applications. They are implementation details. They cannot be constructed
directly and no other JavaFX API accepts or returns a SimpleSelector or
Compou
On Thu, 18 Jan 2024 23:55:56 GMT, Kevin Rushforth wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> construc
On Fri, 19 Jan 2024 09:31:31 GMT, Johan Vos wrote:
> almost clean Backport (apart from a (c) date change) of
> 8321722: Tab header flickering when dragging slowly other tabs and reordering
> uncompleted
>
> Reviewed-by: angorya, mstrauss, kcr
This pull request has now been integrated.
Changes
On Fri, 19 Jan 2024 00:00:32 GMT, Kevin Rushforth wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> construc
On Fri, 19 Jan 2024 00:43:20 GMT, Andy Goryachev wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> construct
almost clean Backport (apart from a (c) date change) of
8321722: Tab header flickering when dragging slowly other tabs and reordering
uncompleted
Reviewed-by: angorya, mstrauss, kcr
-
Commit messages:
- 8321722: Tab header flickering when dragging slowly other tabs and
reordering
On Thu, 18 Jan 2024 23:58:17 GMT, Kevin Rushforth wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> construc
On Tue, 16 Jan 2024 20:26:40 GMT, Johan Vos wrote:
> Increase the release version to JavaFX 17.0.11
This pull request has now been integrated.
Changeset: 31c4308b
Author:Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/31c4308b9218f397f4d86855affdbeb2253c566f
Stats: 2 lines
On Tue, 16 Jan 2024 20:26:40 GMT, Johan Vos wrote:
> Increase the release version to JavaFX 17.0.11
Marked as reviewed by jpereda (Reviewer).
-
PR Review: https://git.openjdk.org/jfx17u/pull/176#pullrequestreview-1831961532
On Mon, 15 Jan 2024 15:09:45 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 21.0.2.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=45268
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.
61 matches
Mail list logo
