On Fri, 2 Feb 2024 22:17:15 GMT, Kevin Rushforth wrote:
> No, we're not. The `@available` generates a runtime check so that code is
> executed only if the runtime platform is macOS 14.x or later.
Right, forgot about the other `@available` check.
-
PR Comment: https://git.openjdk.o
On Fri, 2 Feb 2024 22:06:41 GMT, Martin Fox wrote:
> > So basically, a pragma to workaround a limitation of Xcode.
>
> I wouldn't describe this as a limitation of Xcode. After all, the glass code
> is trying to access a 14.0 API using a 13.3 SDK. If the language was C++ the
> call wouldn't be
On Fri, 2 Feb 2024 21:04:13 GMT, Kevin Rushforth wrote:
> So basically, a pragma to workaround a limitation of Xcode.
I wouldn't describe this as a limitation of Xcode. After all, the glass code is
trying to access a 14.0 API using a 13.3 SDK. If the language was C++ the call
wouldn't be in th
On Fri, 2 Feb 2024 13:30:19 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly an
On Fri, 2 Feb 2024 19:47:17 GMT, Martin Fox wrote:
>> Turning on warnings-as-errors for the macOS glass native code. Deprecated
>> declarations are excluded and still appear as warnings.
>>
>> In the code that tries to locate the application's dock icon there were
>> three instances where `NO`
On Fri, 2 Feb 2024 19:47:17 GMT, Martin Fox wrote:
>> Turning on warnings-as-errors for the macOS glass native code. Deprecated
>> declarations are excluded and still appear as warnings.
>>
>> In the code that tries to locate the application's dock icon there were
>> three instances where `NO`
On Fri, 2 Feb 2024 19:34:02 GMT, Jose Pereda wrote:
> Yes, I think so, simplifying the code without breaking the existing
> functionality should be fine. I guess it should be easy to do a build with
> this PR and test Scene Builder before and after the proposed change.
In order to fully test i
On Fri, 2 Feb 2024 19:47:17 GMT, Martin Fox wrote:
>> Turning on warnings-as-errors for the macOS glass native code. Deprecated
>> declarations are excluded and still appear as warnings.
>>
>> In the code that tries to locate the application's dock icon there were
>> three instances where `NO`
> Turning on warnings-as-errors for the macOS glass native code. Deprecated
> declarations are excluded and still appear as warnings.
>
> In the code that tries to locate the application's dock icon there were three
> instances where `NO` was being passed into a method that required a pointer
>
On Fri, 2 Feb 2024 13:30:19 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly an
On Fri, 2 Feb 2024 19:04:33 GMT, John Hendrikx wrote:
>>> My conclusion is that we either need two rounds to get this right (to first
>>> free up our first choice getStyleClasses), or we can settle on one of:
>>> getStyleClassNames, getStyles, getStyleNames, getClasses, getClassNames.
>>
>> Le
On Fri, 2 Feb 2024 16:00:28 GMT, Kevin Rushforth wrote:
> There is one other method used by SceneBuilder's `CssInternal` class,
> `CompoundSelector::getSelectors`. I think you need to add a method to the
> `Selector` base class that returns a `List` instead of the
> `List` returned by the exis
On Fri, 2 Feb 2024 18:55:49 GMT, Kevin Rushforth wrote:
> Periodic sync of `jfx:jfx22` into `jfx22u:master`.
This pull request has now been integrated.
Changeset: 3980a726
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx22u/commit/3980a7260ab1711a92c19d136161a7f8fe42ed0a
Stat
Periodic sync of `jfx:jfx22` into `jfx22u:master`.
-
Commit messages:
- Merge jfx:jfx22
- 8324879: Platform-specific preferences keys are incorrect for Windows toolkit
- 8324658: Allow animation play/start/stop/pause methods to be called on any
thread
The merge commit only contai
On Fri, 2 Feb 2024 18:43:19 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>> gener
> In the Mac glass code the presence of "marked" text (which is tracked in the
> nsAttrBuffer) signals that an IME is active. In this state the current code
> assumes that when NSTextInputContext handles a `keyDown:` it will either
> generate a call to `insertText:replacementRange:` or one of th
On Sat, 20 Jan 2024 20:35:15 GMT, Johan Vos wrote:
> Thanks for the additional test. There was already a test in the
> SystemMenuBarTest, but it's really good to have an additional test for this
> -- I added it.
@johanvos [8323787](https://bugs.openjdk.org/browse/JDK-8323787) seems like a
dis
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>> gene
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>> gene
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>> gene
On Fri, 19 Jan 2024 10:21:05 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructe
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>> gene
On Tue, 30 Jan 2024 20:43:33 GMT, Martin Fox wrote:
>>> The order in which they get resolved doesn't matter.
>>
>> would it be possible to get
>> [JDK-8320912](https://bugs.openjdk.org/browse/JDK-8320912) integrated first
>> then? It seems the scenario it addresses is narrower, and it will b
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote:
> This is a Mac only bug. If the user was in the middle of IM text composition
> and clicked on a different node the partially composed text was left in the
> old node and the IM window wasn't dismissed. This PR implements the existing
> fini
On Fri, 2 Feb 2024 16:11:52 GMT, Kevin Rushforth wrote:
>> This is a Mac only bug. If the user was in the middle of IM text composition
>> and clicked on a different node the partially composed text was left in the
>> old node and the IM window wasn't dismissed. This PR implements the existing
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>> gene
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote:
> This is a Mac only bug. If the user was in the middle of IM text composition
> and clicked on a different node the partially composed text was left in the
> old node and the IM window wasn't dismissed. This PR implements the existing
> fini
On Fri, 2 Feb 2024 15:40:35 GMT, Martin Fox wrote:
>> Turning on warnings-as-errors for the macOS glass native code. Deprecated
>> declarations are excluded and still appear as warnings.
>>
>> In the code that tries to locate the application's dock icon there were
>> three instances where `NO`
On Fri, 2 Feb 2024 06:55:36 GMT, Robert Lichtenberger
wrote:
> The PR simply moves column and view-updates outside the loop. Since the
> column or view never changes within the for-loop it is not necessary to call
> these again and again.
I see it working right in macOS 14.2.1, by double-clic
On Fri, 2 Feb 2024 15:40:35 GMT, Martin Fox wrote:
>> Turning on warnings-as-errors for the macOS glass native code. Deprecated
>> declarations are excluded and still appear as warnings.
>>
>> In the code that tries to locate the application's dock icon there were
>> three instances where `NO`
On Fri, 2 Feb 2024 13:27:50 GMT, John Hendrikx wrote:
> My conclusion is that we either need two rounds to get this right (to first
> free up our first choice getStyleClasses), or we can settle on one of:
> getStyleClassNames, getStyles, getStyleNames, getClasses, getClassNames.
Let's settle o
> Turning on warnings-as-errors for the macOS glass native code. Deprecated
> declarations are excluded and still appear as warnings.
>
> In the code that tries to locate the application's dock icon there were three
> instances where `NO` was being passed into a method that required a pointer
>
On Thu, 1 Feb 2024 06:36:51 GMT, Ao Qi wrote:
> [JDK-8297068](https://bugs.openjdk.org/browse/JDK-8297068) updated boot JDK
> to 19.0.1 from 18.0.2, and
> [JDK-8321434](https://bugs.openjdk.org/browse/JDK-8321434) updated boot JDK
> to 21.0.1. `CONTRIBUTING.md` should be updated correspondingl
On Fri, 2 Feb 2024 13:37:15 GMT, Kevin Rushforth wrote:
>> [JDK-8297068](https://bugs.openjdk.org/browse/JDK-8297068) updated boot JDK
>> to 19.0.1 from 18.0.2, and
>> [JDK-8321434](https://bugs.openjdk.org/browse/JDK-8321434) updated boot JDK
>> to 21.0.1. `CONTRIBUTING.md` should be updated
On Fri, 2 Feb 2024 06:55:36 GMT, Robert Lichtenberger
wrote:
> The PR simply moves column and view-updates outside the loop. Since the
> column or view never changes within the for-loop it is not necessary to call
> these again and again.
@andy-goryachev-oracle Can you review this?
-
On Thu, 1 Feb 2024 06:36:51 GMT, Ao Qi wrote:
> [JDK-8297068](https://bugs.openjdk.org/browse/JDK-8297068) updated boot JDK
> to 19.0.1 from 18.0.2, and
> [JDK-8321434](https://bugs.openjdk.org/browse/JDK-8321434) updated boot JDK
> to 21.0.1. `CONTRIBUTING.md` should be updated correspondingl
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
> The SimpleSelector and CompoundSelector classes are public classes in an
> exported package, javafx.css, but they are not intended to be used by
> applications. They are implementation details. They cannot be constructed
> directly and no other JavaFX API accepts or returns a SimpleSelector or
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
Laurent Bourgès has updated the pull request incrementally with one additional
commit since the last revision:
fixed tests thanks to + copyright years
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1348/f
On Fri, 2 Feb 2024 08:44:45 GMT, Marius Hanl wrote:
>>> can this also be moved out? `cell.updateTableRow(tableRow);`
>>
>> I don't think so. Since tableRow gets an updated index above, the cell's
>> style could change (e.g. odd / even styling).
>
> Well, the `tableRow` is still set (but before
If you look closely, I removed:
tableSkin.getChildren().remove(cell);
So the cell was previously removed, but it was never added to the table skin in the first place.
The cell is added to the row instead.
Thats why the line below does remove the table row instead:
tableSkin.getChi
Am 02.02.24 um 07:10 schrieb Robert Lichtenberger:
However, if you want to narrow it down further (perhaps there is more
performance to be gained), you could run your tests against the early
access builds. You may be able to find a set of 10-20 isolated
commits that could have led to the
I agree that this a nice feature, especially for headless tests as you also mentioned.
Really looking forward to this feature.
- Marius
Gesendet: Dienstag, 30. Januar 2024 um 12:46 Uhr
Von: "Johan Vos"
An: "openjfx-dev"
Betreff: Headless glass platform
Hi,
I created a branch in t
On Fri, 2 Feb 2024 08:20:09 GMT, Robert Lichtenberger
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java
>> line 668:
>>
>>> 666: tableRow.updateIndex(row);
>>> 667:
>>> 668: cell.updateTableRow(tableRow);
>>
>> can this a
On Fri, 2 Feb 2024 08:05:12 GMT, Marius Hanl wrote:
> can this also be moved out? `cell.updateTableRow(tableRow);`
I don't think so. Since tableRow gets an updated index above, the cell's style
could change (e.g. odd / even styling).
-
PR Review Comment: https://git.openjdk.org/jf
On Fri, 2 Feb 2024 06:55:36 GMT, Robert Lichtenberger
wrote:
> The PR simply moves column and view-updates outside the loop. Since the
> column or view never changes within the for-loop it is not necessary to call
> these again and again.
modules/javafx.controls/src/main/java/javafx/scene/con
46 matches
Mail list logo
