[jfx17u] RFR: 8236689: macOS 10.15 Catalina: LCD text renders badly

2024-07-02 Thread Jose Pereda
Hi all, This pull request contains a clean backport of commit [a118d333](https://github.com/openjdk/jfx/commit/a118d33314a363336134d31c45b50329594e5a24) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Phil Race on 20 Oct 2021 and was

Re: RFR: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs [v3]

2024-06-25 Thread Jose Pereda
rolling a `TabPane` will behave in the same way that `ScrollBar` > does regarding those same events and control orientation > (vertical/horizontal). Jose Pereda has updated the pull request incrementally with one additional commit since the last revision: Add tests for all four sides ---

Re: RFR: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs [v2]

2024-06-25 Thread Jose Pereda
rolling a `TabPane` will behave in the same way that `ScrollBar` > does regarding those same events and control orientation > (vertical/horizontal). Jose Pereda has updated the pull request incrementally with one additional commit since the last revision: Add unit tests -

RFR: 8334874: Horizontal scroll events from touch pads should scroll the TabPane tabs

2024-06-24 Thread Jose Pereda
This PR considers the horizontal scroll events that can be generated on a trackpad, on an horizontally sided `TabPane` control (top or bottom), adding to the existing vertical scroll events from mouse wheel and trackpad, to scroll its tabs. Therefore, scrolling a `TabPane` will behave in the

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v18]

2024-06-13 Thread Jose Pereda
On Thu, 13 Jun 2024 20:07:32 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with two

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v16]

2024-06-13 Thread Jose Pereda
On Thu, 9 May 2024 19:48:19 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one

Re: RFR: 8289115: Touch events is not dispatched after upgrade to JAVAFX17+

2024-05-27 Thread Jose Pereda
On Tue, 21 May 2024 14:25:51 GMT, Michael Strauß wrote: > This PR fixes a bug > ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was > introduced with #394, which changed the following line in the > `NotifyTouchInput` function (ViewContainer.cpp): > > - const bool isDirect =

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v2]

2024-05-23 Thread Jose Pereda
On Thu, 23 May 2024 10:37:09 GMT, Thiago Milczarek Sayao wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Should still report location > > The linux build seems to be failing because the lack of gcc-13

Re: RFR: 8289115: Touch events is not dispatched after upgrade to JAVAFX17+

2024-05-22 Thread Jose Pereda
On Tue, 21 May 2024 14:25:51 GMT, Michael Strauß wrote: > This PR fixes a bug > ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was > introduced with #394, which changed the following line in the > `NotifyTouchInput` function (ViewContainer.cpp): > > - const bool isDirect =

[jfx21u] Integrated: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-15 Thread Jose Pereda
On Wed, 15 May 2024 16:20:04 GMT, Jose Pereda wrote: > Hi all, > > This pull request contains a backport of commit > [d3da033a](https://github.com/openjdk/jfx/commit/d3da033a2dd5c287733545935242a8d1f71c0554) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.

[jfx21u] RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField

2024-05-15 Thread Jose Pereda
Hi all, This pull request contains a backport of commit [d3da033a](https://github.com/openjdk/jfx/commit/d3da033a2dd5c287733545935242a8d1f71c0554) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Oliver Kopp on 8 May 2024 and was

Re: [jfx17u] RFR: 8330682: Change JavaFX release version to 17.0.12 in jfx17u

2024-04-20 Thread Jose Pereda
On Fri, 19 Apr 2024 13:32:14 GMT, Johan Vos wrote: > Increase JavaFX release version to 17.0.12 Marked as reviewed by jpereda (Reviewer). - PR Review: https://git.openjdk.org/jfx17u/pull/189#pullrequestreview-2013084899

Re: [jfx21u] RFR: 8330683: Change JavaFX release version to 21.0.4 in jfx21u

2024-04-19 Thread Jose Pereda
On Fri, 19 Apr 2024 13:29:07 GMT, Johan Vos wrote: > Increase JavaFX release version Marked as reviewed by jpereda (Reviewer). - PR Review: https://git.openjdk.org/jfx21u/pull/56#pullrequestreview-2011757631

Integrated: 8324939: Editable TableView loses focus after commit

2024-04-04 Thread Jose Pereda
On Wed, 20 Mar 2024 10:55:56 GMT, Jose Pereda wrote: > This PR fixes the issue that after committing an edit on a > ListView/TreeView/TableView/TreeTableView control, the control might lose the > focus unexpectedly. > > For that, it refactors the

Re: RFR: 8324939: Editable TableView loses focus after commit [v2]

2024-04-03 Thread Jose Pereda
hat the focus > remains at the control, one for edit cancel (this passes before and after the > proposed changes), one for edit commit (this fails before and passes after > including the proposed fix). Jose Pereda has updated the pull request incrementally with one additional commit since the las

Re: RFR: 8324939: Editable TableView loses focus after commit [v2]

2024-04-03 Thread Jose Pereda
On Thu, 28 Mar 2024 11:20:23 GMT, Marius Hanl wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback from reviewer > > modules/javafx.controls/src/test/java/test/javafx/s

RFR: 8324939: Editable TableView loses focus after commit

2024-03-20 Thread Jose Pereda
This PR fixes the issue that after committing an edit on a ListView/TreeView/TableView/TreeTableView control, the control might lose the focus unexpectedly. For that, it refactors the `ControlUtils::requestFocusOnControlOnlyIfCurrentFocusOwnerIsChild` method, in order to check if the control

Re: RFR: 8326989 : Text selection issues on WebView after WebKit 617.1

2024-03-06 Thread Jose Pereda
On Wed, 6 Mar 2024 14:51:40 GMT, Hima Bindu Meda wrote: > Text Selection issue is observed due to a pending layout call. This issue is > resolved by a call to the method "updateSelectionAppearanceNow". > Verified Sanity testing and unit test verification looks fine. No issue seen. > > Note:

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v10]

2024-03-05 Thread Jose Pereda
On Tue, 5 Mar 2024 07:34:32 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassSystemMenu.java >> line 226: >> >>> 224: mb.textProperty().when(active).addListener(valueModel -> >>> glassMenu.setTitle(parseText(mb))); >>> 225:

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v10]

2024-03-04 Thread Jose Pereda
On Tue, 27 Feb 2024 09:30:14 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request with a new target base due to

[jfx17u] Integrated: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

2024-03-01 Thread Jose Pereda
On Thu, 29 Feb 2024 15:48:30 GMT, Jose Pereda wrote: > Almost clean backport of 8322703: Intermittent crash in WebView in a JFXPanel > from IME calls on macOS > > Reviewed-by: jbhaskar, arapte > > Very minor conflicts after cherry picking the commit: > >

[jfx17u] RFR: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

2024-02-29 Thread Jose Pereda
Almost clean backport of 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS Reviewed-by: jbhaskar, arapte - Commit messages: - 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS Changes:

[jfx21u] Integrated: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

2024-02-29 Thread Jose Pereda
On Thu, 29 Feb 2024 09:22:38 GMT, Jose Pereda wrote: > Hi all, > > This pull request contains a clean backport of commit > [40809a3f](https://github.com/openjdk/jfx/commit/40809a3f84d5f9f91b265f455a95d045e5b4f692) > from the [openjdk/jfx](https://git.openjdk.org/

[jfx21u] RFR: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

2024-02-29 Thread Jose Pereda
Hi all, This pull request contains a clean backport of commit [40809a3f](https://github.com/openjdk/jfx/commit/40809a3f84d5f9f91b265f455a95d045e5b4f692) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Kevin Rushforth on 30 Jan 2024

Integrated: 8320965: Scrolling on a touch enabled display fails on Wayland

2024-02-26 Thread Jose Pereda
On Tue, 12 Dec 2023 11:19:23 GMT, Jose Pereda wrote: > This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and > `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and > wrapped functions for GTK 3.20+ (so systems without it still run with G

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-25 Thread Jose Pereda
On Sat, 24 Feb 2024 17:34:54 GMT, Thiago Milczarek Sayao wrote: >> I've just reverted the previous changes, and just applied the touch mask to >> the `gdk_pointer_grab` function. Tests should be green now. > > @jperedadnr Would you confirm that scroll on a touch screen still works on > Xorg ?

[jfx21u] Integrated: 8321970: New table columns don't appear when using fixed cell size unless refreshing tableView

2024-02-23 Thread Jose Pereda
On Thu, 22 Feb 2024 10:52:08 GMT, Jose Pereda wrote: > Hi all, > > This pull request contains a clean backport of commit > [ab68b716](https://github.com/openjdk/jfx/commit/ab68b716fbfd807918ca4a1bc096dcf40d9cfcbd) > from the [openjdk/jfx](https://git.openjdk.org/

[jfx21u] RFR: 8321970: New table columns don't appear when using fixed cell size unless refreshing tableView

2024-02-22 Thread Jose Pereda
Hi all, This pull request contains a clean backport of commit [ab68b716](https://github.com/openjdk/jfx/commit/ab68b716fbfd807918ca4a1bc096dcf40d9cfcbd) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Jose Pereda on 21 Dec 2023

[jfx21u] Integrated: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-02-22 Thread Jose Pereda
On Tue, 20 Feb 2024 10:18:36 GMT, Jose Pereda wrote: > Hi all, > > This pull request contains a clean backport of commit > [90cbc663](https://github.com/openjdk/jfx/commit/90cbc66305d0a1380cf3a8cd99ad40db240e554c) > from the [openjdk/jfx](https://git.openjdk.org/

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-20 Thread Jose Pereda
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still ru

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v4]

2024-02-20 Thread Jose Pereda
> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and > `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and > wrapped functions for GTK 3.20+ (so systems without it still run with GTK > 3.8+), and fixes the dragging issue on Wayland. Jos

[jfx21u] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-02-20 Thread Jose Pereda
Hi all, This pull request contains a clean backport of commit [90cbc663](https://github.com/openjdk/jfx/commit/90cbc66305d0a1380cf3a8cd99ad40db240e554c) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Kevin Rushforth on 15 Jan 2024

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-19 Thread Jose Pereda
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still ru

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-19 Thread Jose Pereda
On Mon, 19 Feb 2024 00:35:48 GMT, Thiago Milczarek Sayao wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add compile-time checks to GdkSeat > > A shot in the dark since I don

[jfx22u] Integrated: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-19 Thread Jose Pereda
On Sat, 17 Feb 2024 20:00:22 GMT, Jose Pereda wrote: > Hi all, > > This pull request contains a clean backport of commit > [e2f42c5b](https://github.com/openjdk/jfx/commit/e2f42c5b71ef061c614540508fbac3fb610b1ae3) > from the [openjdk/jfx](https://git.openjdk.org/

[jfx22u] RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-17 Thread Jose Pereda
Hi all, This pull request contains a clean backport of commit [e2f42c5b](https://github.com/openjdk/jfx/commit/e2f42c5b71ef061c614540508fbac3fb610b1ae3) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Robert Lichtenberger on 14 Feb

[jfx21u] Integrated: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-17 Thread Jose Pereda
On Fri, 16 Feb 2024 21:12:21 GMT, Jose Pereda wrote: > Hi all, > > This pull request contains a clean backport of commit > [e2f42c5b](https://github.com/openjdk/jfx/commit/e2f42c5b71ef061c614540508fbac3fb610b1ae3) > from the [openjdk/jfx](https://git.openjdk.org/

[jfx21u] RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-16 Thread Jose Pereda
Hi all, This pull request contains a clean backport of commit [e2f42c5b](https://github.com/openjdk/jfx/commit/e2f42c5b71ef061c614540508fbac3fb610b1ae3) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Robert Lichtenberger on 14 Feb

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v3]

2024-02-04 Thread Jose Pereda
On Fri, 2 Feb 2024 13:30:19 GMT, John Hendrikx wrote: >> The SimpleSelector and CompoundSelector classes are public classes in an >> exported package, javafx.css, but they are not intended to be used by >> applications. They are implementation details. They cannot be constructed >> directly

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v3]

2024-02-02 Thread Jose Pereda
On Fri, 2 Feb 2024 13:30:19 GMT, John Hendrikx wrote: >> The SimpleSelector and CompoundSelector classes are public classes in an >> exported package, javafx.css, but they are not intended to be used by >> applications. They are implementation details. They cannot be constructed >> directly

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v3]

2024-02-02 Thread Jose Pereda
On Fri, 2 Feb 2024 13:30:19 GMT, John Hendrikx wrote: >> The SimpleSelector and CompoundSelector classes are public classes in an >> exported package, javafx.css, but they are not intended to be used by >> applications. They are implementation details. They cannot be constructed >> directly

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v17]

2024-01-30 Thread Jose Pereda
On Tue, 30 Jan 2024 01:24:52 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Jose Pereda
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

2024-01-29 Thread Jose Pereda
On Mon, 29 Jan 2024 03:28:51 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v5]

2024-01-29 Thread Jose Pereda
On Sat, 27 Jan 2024 21:56:59 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line >> 903: >> >>> 901: } >>> 902: >>> 903: private void playFromOnFxThread(String cuePoint) { >> >> I take that adding these private `xxOnFxThread` methods

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v5]

2024-01-27 Thread Jose Pereda
On Sat, 27 Jan 2024 17:26:45 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-23 Thread Jose Pereda
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still ru

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-22 Thread Jose Pereda
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still ru

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-22 Thread Jose Pereda
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still ru

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-21 Thread Jose Pereda
On Mon, 18 Dec 2023 22:00:28 GMT, Kevin Rushforth wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add compile-time checks to GdkSeat > > The addition of the compile-time flags looks O

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v2]

2024-01-19 Thread Jose Pereda
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote: >> The SimpleSelector and CompoundSelector classes are public classes in an >> exported package, javafx.css, but they are not intended to be used by >> applications. They are implementation details. They cannot be constructed >> directly

Re: RFR: JDK-8323706 Move SimpleSelector and CompoundSelector to internal packages

2024-01-19 Thread Jose Pereda
On Fri, 19 Jan 2024 00:43:20 GMT, Andy Goryachev wrote: >> Moves `SimpleSelector` and `CompoundSelector` to internal packages. >> >> This can be done with only a minor API break, as `SimpleSelector` and >> `CompoundSelector` were public before. However, these classes could not be >>

Re: [jfx17u] RFR: 8323829: Change javaFX release version to 17.0.11 in jfx17u

2024-01-19 Thread Jose Pereda
On Tue, 16 Jan 2024 20:26:40 GMT, Johan Vos wrote: > Increase the release version to JavaFX 17.0.11 Marked as reviewed by jpereda (Reviewer). - PR Review: https://git.openjdk.org/jfx17u/pull/176#pullrequestreview-1831961532

Integrated: 8321970: New table columns don't appear when using fixed cell size unless refreshing tableView

2023-12-21 Thread Jose Pereda
On Mon, 18 Dec 2023 12:09:21 GMT, Jose Pereda wrote: > This PR fixes an issue when a new `TableColumn` is added to a `TableView` > control with fixed cell size set, where the `TableRowSkinBase` failed to add > the cells for the new column. > > A test is included that fails

Re: RFR: 8321970: New table columns don't appear when using fixed cell size unless refreshing tableView [v2]

2023-12-18 Thread Jose Pereda
On Mon, 18 Dec 2023 14:13:51 GMT, Jeanette Winzenburg wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address feedback > > modules/javafx.controls/src/test/java/test/javafx/scene/cont

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2023-12-18 Thread Jose Pereda
> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and > `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and > wrapped functions for GTK 3.20+ (so systems without it still run with GTK > 3.8+), and fixes the dragging issue on Wayland. Jos

RFR: 8321970: New table columns don't appear when using fixed cell size unless refreshing tableView

2023-12-18 Thread Jose Pereda
This PR fixes an issue when a new `TableColumn` is added to a `TableView` control with fixed cell size set, where the `TableRowSkinBase` failed to add the cells for the new column. A test is included that fails before applying this PR and passes with it. - Commit messages: - Add

Re: RFR: 8321970: New table columns don't appear when using fixed cell size unless refreshing tableView [v2]

2023-12-18 Thread Jose Pereda
> This PR fixes an issue when a new `TableColumn` is added to a `TableView` > control with fixed cell size set, where the `TableRowSkinBase` failed to add > the cells for the new column. > > A test is included that fails before applying this PR and passes with it. Jose Per

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

2023-12-18 Thread Jose Pereda
On Mon, 18 Dec 2023 10:34:02 GMT, Thiago Milczarek Sayao wrote: >> The check is to allow compilation and test on Ubuntu 16.04 - When shipping >> the final build it should be built on gtk 3.20+, so both dlsym and the check >> makes sense. >> >> So when running on Ubuntu 16.04: >> - For

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

2023-12-18 Thread Jose Pereda
On Mon, 18 Dec 2023 10:09:29 GMT, Thiago Milczarek Sayao wrote: >> I take `GdkSeat` is available since GTK 3.0? >> https://docs.gtk.org/gdk3/class.Seat.html >> >> But don't we have a minimum set on 3.8.0? >> >> Would this work? >> >> #if GTK_CHECK_VERSION(3, 0, 0) >> static GdkSeat *

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

2023-12-18 Thread Jose Pereda
On Sat, 16 Dec 2023 22:21:55 GMT, Thiago Milczarek Sayao wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove compile-time if checks > > modules/javafx.graphics/src/main/nativ

[jfx17u] Integrated: 8251240: Menus inaccessible on Linux with i3 wm

2023-12-17 Thread Jose Pereda
On Sun, 17 Dec 2023 12:40:49 GMT, Jose Pereda wrote: > Clean backport of 8251240: Menus inaccessible on Linux with i3 wm > Reviewed-by: jpereda, jvos This pull request has now been integrated. Changeset: b7e3871c Author: Jose Pereda URL: https://git.openjdk.org/jfx17u/

[jfx17u] RFR: 8251240: Menus inaccessible on Linux with i3 wm

2023-12-17 Thread Jose Pereda
Clean backport of 8251240: Menus inaccessible on Linux with i3 wm Reviewed-by: jpereda, jvos - Commit messages: - 8251240: Menus inaccessible on Linux with i3 wm Changes: https://git.openjdk.org/jfx17u/pull/173/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u=173=00 Issue:

[jfx17u] Integrated: 8260528: Clean glass-gtk sizing and positioning code

2023-12-17 Thread Jose Pereda
On Sun, 17 Dec 2023 12:14:03 GMT, Jose Pereda wrote: > Clean backport of 8260528: Clean glass-gtk sizing and positioning code > Reviewed-by: jvos, kcr This pull request has now been integrated. Changeset: 84c2bd93 Author: Jose Pereda URL: https://git.openjdk.org/jfx17u/

[jfx17u] RFR: 8260528: Clean glass-gtk sizing and positioning code

2023-12-17 Thread Jose Pereda
Clean backport of 8260528: Clean glass-gtk sizing and positioning code Reviewed-by: jvos, kcr - Commit messages: - 8260528: Clean glass-gtk sizing and positioning code Changes: https://git.openjdk.org/jfx17u/pull/172/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u=172=00

[jfx17u] Integrated: 8299968: Second call to Stage.setScene() create sizing issue with uiScale > 1.0

2023-12-17 Thread Jose Pereda
On Tue, 5 Dec 2023 12:03:10 GMT, Jose Pereda wrote: > Backport of 8299968: Second call to Stage.setScene() create sizing issue with > uiScale > 1.0 > > Reviewed-by: kcr, arapte > > The backport didn't pass the pre-submit tests: The added test in JDK-8299968 &g

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

2023-12-14 Thread Jose Pereda
> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and > `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and > wrapped functions for GTK 3.20+ (so systems without it still run with GTK > 3.8+), and fixes the dragging issue on Wayland. Jos

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland

2023-12-14 Thread Jose Pereda
On Thu, 14 Dec 2023 16:02:48 GMT, Kevin Rushforth wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >>

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-12-13 Thread Jose Pereda
On Mon, 20 Nov 2023 08:00:58 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-12-13 Thread Jose Pereda
On Mon, 20 Nov 2023 08:00:58 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one

RFR: 8320965: Scrolling on a touch enabled display fails on Wayland

2023-12-12 Thread Jose Pereda
This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and wrapped functions for GTK 3.20+ (so systems without it still run with GTK 3.8+), and fixes the dragging issue on Wayland. - Commit

Integrated: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Jose Pereda
On Mon, 11 Dec 2023 18:36:35 GMT, Jose Pereda wrote: > This PR prevents changes in direction when dragging a tab header over a > TabPane control, if delta value is zero, which can happen with slow drag > events, in order to prevent starting and stopping too frequently the &g

Re: RFR: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Jose Pereda
On Mon, 11 Dec 2023 19:01:19 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java >> line 2162: >> >>> 2160: } >>> 2161: // Stop dropHeaderAnim if direction of drag is changed >>> 2162: if (dragDirection != 0 &&

RFR: 8321722: Tab header flickering when dragging slowly other tabs and reordering uncompleted

2023-12-11 Thread Jose Pereda
This PR prevents changes in direction when dragging a tab header over a TabPane control, if delta value is zero, which can happen with slow drag events, in order to prevent starting and stopping too frequently the animation of the target tab header in opposite directions. - Commit

Re: RFR: 8301302: Platform preferences API [v47]

2023-12-07 Thread Jose Pereda
On Thu, 7 Dec 2023 18:30:24 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/application/WindowsHighContrastScheme.java >> line 43: >> >>> 41: * The high contrast feature may not be available on all platforms. >>> 42: */ >>> 43: enum

Re: RFR: 8301302: Platform preferences API [v47]

2023-12-07 Thread Jose Pereda
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v47]

2023-12-07 Thread Jose Pereda
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v46]

2023-12-07 Thread Jose Pereda
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v42]

2023-12-06 Thread Jose Pereda
On Wed, 6 Dec 2023 19:23:38 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: [jfx17u] RFR: 8299968: Second call to Stage.setScene() create sizing issue with uiScale > 1.0 [v2]

2023-12-05 Thread Jose Pereda
> Clean backport of 8299968: Second call to Stage.setScene() create sizing > issue with uiScale > 1.0 > > Reviewed-by: kcr, arapte Jose Pereda has updated the pull request incrementally with one additional commit since the last revision: Apply required changes f

[jfx17u] RFR: 8299968: Second call to Stage.setScene() create sizing issue with uiScale > 1.0

2023-12-05 Thread Jose Pereda
Clean backport of 8299968: Second call to Stage.setScene() create sizing issue with uiScale > 1.0 Reviewed-by: kcr, arapte - Commit messages: - 8299968: Second call to Stage.setScene() create sizing issue with uiScale > 1.0 Changes: https://git.openjdk.org/jfx17u/pull/171/files

[jfx17u] Integrated: 8292922: [Linux] No more drag events when new Stage is created in drag handler

2023-12-05 Thread Jose Pereda
On Tue, 5 Dec 2023 11:02:14 GMT, Jose Pereda wrote: > Clean backport of 8292922: [Linux] No more drag events when new Stage is > created in drag handler > > Reviewed-by: angorya, kcr This pull request has now been integrated. Changeset: d6b9c7ae Author: Jose Pereda URL:

[jfx17u] RFR: 8292922: [Linux] No more drag events when new Stage is created in drag handler

2023-12-05 Thread Jose Pereda
Clean backport of 8292922: [Linux] No more drag events when new Stage is created in drag handler Reviewed-by: angorya, kcr - Commit messages: - 8292922: [Linux] No more drag events when new Stage is created in drag handler Changes: https://git.openjdk.org/jfx17u/pull/170/files

[jfx17u] Integrated: 8201538: Remove implementation support for applets from JavaFX

2023-12-05 Thread Jose Pereda
On Tue, 5 Dec 2023 09:39:59 GMT, Jose Pereda wrote: > Clean backport of 8201538: Remove implementation support for applets from > JavaFX > Reviewed-by: mstrauss, aghaisas, jvos This pull request has now been integrated. Changeset: efbbfcf0 Author:Jose Pereda URL:

[jfx17u] RFR: 8201538: Remove implementation support for applets from JavaFX

2023-12-05 Thread Jose Pereda
Clean backport of 8201538: Remove implementation support for applets from JavaFX Reviewed-by: mstrauss, aghaisas, jvos - Commit messages: - 8201538: Remove implementation support for applets from JavaFX Changes: https://git.openjdk.org/jfx17u/pull/169/files Webrev:

[jfx17u] Integrated: 8320267: WebView crashes on macOS 11 with WebKit 616.1

2023-12-01 Thread Jose Pereda
On Fri, 1 Dec 2023 20:42:41 GMT, Jose Pereda wrote: > Clean backport of 8320267: WebView crashes on macOS 11 with WebKit 616.1 > Reviewed-by: jbhaskar, jpereda This pull request has now been integrated. Changeset: a9a3f5c5 Author: Jose Pereda URL: https://git.openjdk.org/

[jfx17u] RFR: 8320267: WebView crashes on macOS 11 with WebKit 616.1

2023-12-01 Thread Jose Pereda
Clean backport of 8320267: WebView crashes on macOS 11 with WebKit 616.1 Reviewed-by: jbhaskar, jpereda - Commit messages: - 8320267: WebView crashes on macOS 11 with WebKit 616.1 Changes: https://git.openjdk.org/jfx17u/pull/168/files Webrev:

Re: RFR: 8320267: WebView crashes on macOS 11 with WebKit 616.1

2023-11-30 Thread Jose Pereda
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote: > With the help of debug build which pinpointed the crash, I found the commit > in upstream WebKit core that caused the crash. That commit was subsequently > reverted not long after it was initially committed. This reverted commit >

Re: RFR: 8320267: WebView crashes on macOS 11 with WebKit 616.1

2023-11-29 Thread Jose Pereda
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote: > With the help of debug build which pinpointed the crash, I found the commit > in upstream WebKit core that caused the crash. That commit was subsequently > reverted not long after it was initially committed. This reverted commit >

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-28 Thread Jose Pereda
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote: > The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at > least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent > alters its state in some way that confuses NSTextInputContext.handleEvent. > The

Re: RFR: 8320267: WebView crashes on macOS 11 with WebKit 616.1

2023-11-28 Thread Jose Pereda
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote: > With the help of debug build which pinpointed the crash, I found the commit > in upstream WebKit core that caused the crash. That commit was subsequently > reverted not long after it was initially committed. This reverted commit >

Re: RFR: 8320773: [macOS] All IME input blocked

2023-11-28 Thread Jose Pereda
On Tue, 28 Nov 2023 16:36:31 GMT, Andy Goryachev wrote: >> A short test appears to have solved the problem caused by side effects. >> I also found a known IME related issue, but am concerned that this fix will >> not complicate it. >> >> Steps to reproduce: >> >> Click on another TextInput

[jfx21u] Integrated: 8251240: Menus inaccessible on Linux with i3 wm

2023-11-23 Thread Jose Pereda
On Thu, 23 Nov 2023 14:42:17 GMT, Jose Pereda wrote: > Clean backport of 8251240: Menus inaccessible on Linux with i3 wm > Reviewed-by: jpereda, jvos This pull request has now been integrated. Changeset: 292315f0 Author: Jose Pereda URL: https://git.openjdk.org/jfx21u/

[jfx21u] RFR: 8251240: Menus inaccessible on Linux with i3 wm

2023-11-23 Thread Jose Pereda
Clean backport of 8251240: Menus inaccessible on Linux with i3 wm Reviewed-by: jpereda, jvos - Commit messages: - 8251240: Menus inaccessible on Linux with i3 wm Changes: https://git.openjdk.org/jfx21u/pull/34/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u=34=00 Issue:

[jfx21u] Integrated: 8311185: VirtualFlow jump when cellcount changes

2023-11-21 Thread Jose Pereda
On Tue, 21 Nov 2023 08:56:42 GMT, Jose Pereda wrote: > Clean backport of 8311185: VirtualFlow jump when cellcount changes > Reviewed-by: angorya, kcr This pull request has now been integrated. Changeset: 376d70d2 Author: Jose Pereda URL: https://git.openjdk.org/jfx21u/

[jfx21u] RFR: 8311185: VirtualFlow jump when cellcount changes

2023-11-21 Thread Jose Pereda
Clean backport of 8311185: VirtualFlow jump when cellcount changes Reviewed-by: angorya, kcr - Commit messages: - 8311185: VirtualFlow jump when cellcount changes Changes: https://git.openjdk.org/jfx21u/pull/31/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u=31=00 Issue:

Re: RFR: 8274967: KeyCharacterCombinations for punctuation and symbols fail on non-US keyboards

2023-11-14 Thread Jose Pereda
On Tue, 17 Oct 2023 20:21:30 GMT, Martin Fox wrote: > After finding the Window virtual key code for a character getKeyCodeForChar > was using a mapping table that only works correctly for U.S. English to > retrieve the Java key code. This caused getKeyCodeForChar to encode keys > differently

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v7]

2023-11-10 Thread Jose Pereda
On Fri, 10 Nov 2023 10:17:18 GMT, Johan Vos wrote: >> When the Java layer removes a systemmenu, release the native resources >> related to this systemmenu. >> This removes the strong JNI Global ref, which prevents its references from >> being gc'ed. >> >> The current implementation for the

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-09 Thread Jose Pereda
On Thu, 9 Nov 2023 15:17:25 GMT, Johan Vos wrote: >> When the Java layer removes a systemmenu, release the native resources >> related to this systemmenu. >> This removes the strong JNI Global ref, which prevents its references from >> being gc'ed. >> >> The current implementation for the

Re: RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v6]

2023-11-09 Thread Jose Pereda
On Thu, 9 Nov 2023 15:17:25 GMT, Johan Vos wrote: >> When the Java layer removes a systemmenu, release the native resources >> related to this systemmenu. >> This removes the strong JNI Global ref, which prevents its references from >> being gc'ed. >> >> The current implementation for the

  1   2   3   >