This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and
`gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and wrapped
functions for GTK 3.20+ (so systems without it still run with GTK 3.8+), and
fixes the dragging issue on Wayland.
-
Commit mes
On Mon, 11 Dec 2023 18:36:35 GMT, Jose Pereda wrote:
> This PR prevents changes in direction when dragging a tab header over a
> TabPane control, if delta value is zero, which can happen with slow drag
> events, in order to prevent starting and stopping too frequently the
> anim
On Mon, 11 Dec 2023 19:01:19 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java
>> line 2162:
>>
>>> 2160: }
>>> 2161: // Stop dropHeaderAnim if direction of drag is changed
>>> 2162: if (dragDirection != 0 && p
This PR prevents changes in direction when dragging a tab header over a TabPane
control, if delta value is zero, which can happen with slow drag events, in
order to prevent starting and stopping too frequently the animation of the
target tab header in opposite directions.
-
Commit
On Thu, 7 Dec 2023 18:30:24 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/WindowsHighContrastScheme.java
>> line 43:
>>
>>> 41: * The high contrast feature may not be available on all platforms.
>>> 42: */
>>> 43: enum WindowsHighContrastScheme
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Wed, 6 Dec 2023 19:23:38 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
> Clean backport of 8299968: Second call to Stage.setScene() create sizing
> issue with uiScale > 1.0
>
> Reviewed-by: kcr, arapte
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Apply required changes f
Clean backport of 8299968: Second call to Stage.setScene() create sizing issue
with uiScale > 1.0
Reviewed-by: kcr, arapte
-
Commit messages:
- 8299968: Second call to Stage.setScene() create sizing issue with uiScale >
1.0
Changes: https://git.openjdk.org/jfx17u/pull/171/files
On Tue, 5 Dec 2023 11:02:14 GMT, Jose Pereda wrote:
> Clean backport of 8292922: [Linux] No more drag events when new Stage is
> created in drag handler
>
> Reviewed-by: angorya, kcr
This pull request has now been integrated.
Changeset: d6b9c7ae
Author: Jose Pereda
URL:
Clean backport of 8292922: [Linux] No more drag events when new Stage is
created in drag handler
Reviewed-by: angorya, kcr
-
Commit messages:
- 8292922: [Linux] No more drag events when new Stage is created in drag
handler
Changes: https://git.openjdk.org/jfx17u/pull/170/files
W
On Tue, 5 Dec 2023 09:39:59 GMT, Jose Pereda wrote:
> Clean backport of 8201538: Remove implementation support for applets from
> JavaFX
> Reviewed-by: mstrauss, aghaisas, jvos
This pull request has now been integrated.
Changeset: efbbfcf0
Author:Jose Pereda
URL:
Clean backport of 8201538: Remove implementation support for applets from JavaFX
Reviewed-by: mstrauss, aghaisas, jvos
-
Commit messages:
- 8201538: Remove implementation support for applets from JavaFX
Changes: https://git.openjdk.org/jfx17u/pull/169/files
Webrev: https://webrevs.
On Fri, 1 Dec 2023 20:42:41 GMT, Jose Pereda wrote:
> Clean backport of 8320267: WebView crashes on macOS 11 with WebKit 616.1
> Reviewed-by: jbhaskar, jpereda
This pull request has now been integrated.
Changeset: a9a3f5c5
Author: Jose Pereda
URL:
https://git.openjdk.org/
Clean backport of 8320267: WebView crashes on macOS 11 with WebKit 616.1
Reviewed-by: jbhaskar, jpereda
-
Commit messages:
- 8320267: WebView crashes on macOS 11 with WebKit 616.1
Changes: https://git.openjdk.org/jfx17u/pull/168/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote:
> With the help of debug build which pinpointed the crash, I found the commit
> in upstream WebKit core that caused the crash. That commit was subsequently
> reverted not long after it was initially committed. This reverted commit
> wasn
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote:
> With the help of debug build which pinpointed the crash, I found the commit
> in upstream WebKit core that caused the crash. That commit was subsequently
> reverted not long after it was initially committed. This reverted commit
> wasn
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote:
> The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at
> least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent
> alters its state in some way that confuses NSTextInputContext.handleEvent.
> The resul
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote:
> With the help of debug build which pinpointed the crash, I found the commit
> in upstream WebKit core that caused the crash. That commit was subsequently
> reverted not long after it was initially committed. This reverted commit
> wasn
On Tue, 28 Nov 2023 16:36:31 GMT, Andy Goryachev wrote:
>> A short test appears to have solved the problem caused by side effects.
>> I also found a known IME related issue, but am concerned that this fix will
>> not complicate it.
>>
>> Steps to reproduce:
>>
>> Click on another TextInput con
On Thu, 23 Nov 2023 14:42:17 GMT, Jose Pereda wrote:
> Clean backport of 8251240: Menus inaccessible on Linux with i3 wm
> Reviewed-by: jpereda, jvos
This pull request has now been integrated.
Changeset: 292315f0
Author: Jose Pereda
URL:
https://git.openjdk.org/jfx21u/
Clean backport of 8251240: Menus inaccessible on Linux with i3 wm
Reviewed-by: jpereda, jvos
-
Commit messages:
- 8251240: Menus inaccessible on Linux with i3 wm
Changes: https://git.openjdk.org/jfx21u/pull/34/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=34&range=00
On Tue, 21 Nov 2023 08:56:42 GMT, Jose Pereda wrote:
> Clean backport of 8311185: VirtualFlow jump when cellcount changes
> Reviewed-by: angorya, kcr
This pull request has now been integrated.
Changeset: 376d70d2
Author: Jose Pereda
URL:
https://git.openjdk.org/jfx21u/
Clean backport of 8311185: VirtualFlow jump when cellcount changes
Reviewed-by: angorya, kcr
-
Commit messages:
- 8311185: VirtualFlow jump when cellcount changes
Changes: https://git.openjdk.org/jfx21u/pull/31/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=31&range=00
On Tue, 17 Oct 2023 20:21:30 GMT, Martin Fox wrote:
> After finding the Window virtual key code for a character getKeyCodeForChar
> was using a mapping table that only works correctly for U.S. English to
> retrieve the Java key code. This caused getKeyCodeForChar to encode keys
> differently t
On Fri, 10 Nov 2023 10:17:18 GMT, Johan Vos wrote:
>> When the Java layer removes a systemmenu, release the native resources
>> related to this systemmenu.
>> This removes the strong JNI Global ref, which prevents its references from
>> being gc'ed.
>>
>> The current implementation for the mac
On Thu, 9 Nov 2023 15:17:25 GMT, Johan Vos wrote:
>> When the Java layer removes a systemmenu, release the native resources
>> related to this systemmenu.
>> This removes the strong JNI Global ref, which prevents its references from
>> being gc'ed.
>>
>> The current implementation for the mac-
On Thu, 9 Nov 2023 15:17:25 GMT, Johan Vos wrote:
>> When the Java layer removes a systemmenu, release the native resources
>> related to this systemmenu.
>> This removes the strong JNI Global ref, which prevents its references from
>> being gc'ed.
>>
>> The current implementation for the mac-
On Tue, 7 Nov 2023 11:55:36 GMT, Jose Pereda wrote:
> Clean backport of 8307536: FileAlreadyExistsException from NativeLibLoader
> when running concurrent applications with empty cache
>
> Reviewed-by: kcr, angorya, jvos
This pull request has now been integrated.
Changeset: ea9
Clean backport of 8307536: FileAlreadyExistsException from NativeLibLoader when
running concurrent applications with empty cache
Reviewed-by: kcr, angorya, jvos
-
Commit messages:
- 8307536: FileAlreadyExistsException from NativeLibLoader when running
concurrent applications with
On Tue, 31 Oct 2023 19:17:19 GMT, Jose Pereda wrote:
> Clean backport of 8319066: Application window not always activated in macOS
> 14 Sonoma
> Reviewed-by: kcr, arapte
This pull request has now been integrated.
Changeset: 22bd6571
Author:Jose Pereda
URL:
https://git.op
On Tue, 31 Oct 2023 18:41:56 GMT, Jose Pereda wrote:
> Clean backport of 8319066: Application window not always activated in macOS
> 14 Sonoma
> Reviewed-by: kcr, arapte
This pull request has now been integrated.
Changeset: 1b18effd
Author:Jose Pereda
URL:
https://git.op
Clean backport of 8319066: Application window not always activated in macOS 14
Sonoma
Reviewed-by: kcr, arapte
-
Commit messages:
- 8319066: Application window not always activated in macOS 14 Sonoma
Changes: https://git.openjdk.org/jfx17u/pull/166/files
Webrev: https://webrevs.op
Clean backport of 8319066: Application window not always activated in macOS 14
Sonoma
Reviewed-by: kcr, arapte
-
Commit messages:
- 8319066: Application window not always activated in macOS 14 Sonoma
Changes: https://git.openjdk.org/jfx21u/pull/23/files
Webrev: https://webrevs.op
On Mon, 30 Oct 2023 12:46:03 GMT, Jose Pereda wrote:
> On macOS 14. when a JavaFX application is launched from the command line it
> is not activated, and the terminal application remains active.
>
> This PR forces the application activation on macOS 14, in case the app didn't
t icon, for instance).
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Introduce requiresActivation to limit the cases that require activation
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1273/files
- new: https:/
On macOS 14. when a JavaFX application is launched from the command line it is
not activated, and the terminal application remains active.
This PR forces the application activation on macOS 14, in case the app didn't
get activated yet (when launched from a shortcut icon, for instance).
On Wed, 25 Oct 2023 13:51:35 GMT, Johan Vos wrote:
> bump release version to 17.0.10
Marked as reviewed by jpereda (Reviewer).
-
PR Review: https://git.openjdk.org/jfx17u/pull/165#pullrequestreview-1697544862
On Tue, 26 Sep 2023 19:11:22 GMT, Jose Pereda wrote:
> Clean backport of 8315657: Application window not activated in macOS 14 Sonoma
> Reviewed-by: jpereda, aghaisas
This pull request has now been integrated.
Changeset: 7b3027a7
Author: Jose Pereda
URL:
https://git.openj
Clean backport of 8315657: Application window not activated in macOS 14 Sonoma
Reviewed-by: jpereda, aghaisas
-
Commit messages:
- 8315657: Application window not activated in macOS 14 Sonoma
Changes: https://git.openjdk.org/jfx17u/pull/164/files
Webrev: https://webrevs.openjdk.org
On Thu, 21 Sep 2023 19:10:38 GMT, Kevin Rushforth wrote:
> The fix for [JDK-8233678](https://bugs.openjdk.org/browse/JDK-8233678) added
> a step to the NSApplication initialization to deactivate and then reactivate
> the application. We trigger the deactivation the first time
> applicationDidB
On Thu, 21 Sep 2023 19:10:38 GMT, Kevin Rushforth wrote:
> The fix for [JDK-8233678](https://bugs.openjdk.org/browse/JDK-8233678) added
> a step to the NSApplication initialization to deactivate and then reactivate
> the application. We trigger the deactivation the first time
> applicationDidB
On Thu, 21 Sep 2023 19:10:38 GMT, Kevin Rushforth wrote:
> The fix for [JDK-8233678](https://bugs.openjdk.org/browse/JDK-8233678) added
> a step to the NSApplication initialization to deactivate and then reactivate
> the application. We trigger the deactivation the first time
> applicationDidB
On Wed, 6 Sep 2023 16:02:08 GMT, Jose Pereda wrote:
> Clean backport of 8311185: VirtualFlow jump when cellcount changes
> Reviewed-by: angorya, kcr
This pull request has now been integrated.
Changeset: 07955dd2
Author: Jose Pereda
URL:
https://git.openjdk.org/jfx17u/
Clean backport of 8311185: VirtualFlow jump when cellcount changes
Reviewed-by: angorya, kcr
-
Commit messages:
- 8311185: VirtualFlow jump when cellcount changes
Changes: https://git.openjdk.org/jfx17u/pull/163/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=163&range=00
On Wed, 6 Sep 2023 14:23:39 GMT, Jose Pereda wrote:
> Almost clean backport of 8311127: Regression: The fix for TableView and
> TreeTableView menu button affects all table column headers
> Reviewed-by: angorya
>
> There was a conflict with the insertion point
Almost clean backport of 8311127: Regression: The fix for TableView and
TreeTableView menu button affects all table column headers
Reviewed-by: angorya
There was a conflict with the insertion point of the test in TreeTableViewTest,
that was solved by swapping the order of tests to match up with
On Wed, 6 Sep 2023 13:49:30 GMT, Jose Pereda wrote:
> Almost clean backport of 8138842: TableViewSelectionModel.selectIndices does
> not select index 0
> Reviewed-by: angorya, aghaisas
>
> There were conflicts with the insertion point of the two tests TableViewTest
> and
Almost clean backport of 8138842: TableViewSelectionModel.selectIndices does
not select index 0
Reviewed-by: angorya, aghaisas
There were conflicts with the insertion point of the two tests TableViewTest
and TreeTableViewTest.
In the case of TableViewTest: also two tests that already exist were
On Wed, 6 Sep 2023 11:02:23 GMT, Jose Pereda wrote:
> Almost clean backport of 8310638: Filtering a TableView with a large number
> of items freezes the UI
> Reviewed-by: kcr, angorya
>
> There was a small conflict in VirtualFlowTest due to JDK-8297414:
>
>
Almost clean backport of 8310638: Filtering a TableView with a large number of
items freezes the UI
Reviewed-by: kcr, angorya
There was a small conflict in VirtualFlowTest due to JDK-8297414:
-list = new ArrayLinkedListShim();
+list = new ArrayLinkedListShim<>();
-
On Wed, 6 Sep 2023 10:21:14 GMT, Jose Pereda wrote:
> Clean backport of 8309470: Potential performance improvements in VirtualFlow
> Reviewed-by: kpk, angorya
This pull request has now been integrated.
Changeset: 4b1022f6
Author: Jose Pereda
URL:
https://git.openjdk.org/
Clean backport of 8309470: Potential performance improvements in VirtualFlow
Reviewed-by: kpk, angorya
-
Commit messages:
- 8309470: Potential performance improvements in VirtualFlow
Changes: https://git.openjdk.org/jfx17u/pull/159/files
Webrev: https://webrevs.openjdk.org/?repo=jf
On Wed, 6 Sep 2023 09:41:35 GMT, Jose Pereda wrote:
> Clean backport of 8293836: Rendering performance degradation at bottom of
> TableView with many rows
>
> Reviewed-by: angorya, kcr
This pull request has now been integrated.
Changeset: 514dfaec
Author: Jose Pereda
URL:
Clean backport of 8293836: Rendering performance degradation at bottom of
TableView with many rows
Reviewed-by: angorya, kcr
-
Commit messages:
- 8293836: Rendering performance degradation at bottom of TableView with many
rows
Changes: https://git.openjdk.org/jfx17u/pull/158/file
On Wed, 6 Sep 2023 08:49:50 GMT, Jose Pereda wrote:
> Clean backport of 8306447: Adding an element to a long existing list may
> cause the first visible element to jump
> Reviewed-by: angorya, kcr
This pull request has now been integrated.
Changeset: a90a028f
Author:Jose Pe
Clean backport of 8306447: Adding an element to a long existing list may cause
the first visible element to jump
Reviewed-by: angorya, kcr
-
Commit messages:
- 8306447: Adding an element to a long existing list may cause the first
visible element to jump
Changes: https://git.openj
On Wed, 6 Sep 2023 08:16:46 GMT, Jose Pereda wrote:
> Clean backport of 8303680: Virtual Flow freezes after calling scrollTo and
> scrollPixels in succession
> Reviewed-by: angorya, jvos
This pull request has now been integrated.
Changeset: 877ee019
Author:Jose Pereda
URL:
Clean backport of 8303680: Virtual Flow freezes after calling scrollTo and
scrollPixels in succession
Reviewed-by: angorya, jvos
-
Commit messages:
- 8303680: Virtual Flow freezes after calling scrollTo and scrollPixels in
succession
Changes: https://git.openjdk.org/jfx17u/pull/15
On Wed, 6 Sep 2023 07:45:58 GMT, Jose Pereda wrote:
> Clean backport of 8303680: Virtual Flow freezes after calling scrollTo and
> scrollPixels in succession
>
> Reviewed-by: angorya, jvos
This pull request has been closed without being integrated.
-
PR: https://git
On Wed, 6 Sep 2023 07:45:58 GMT, Jose Pereda wrote:
> Clean backport of 8303680: Virtual Flow freezes after calling scrollTo and
> scrollPixels in succession
>
> Reviewed-by: angorya, jvos
Errors are due to branch not being up to date.
-
PR Comment: https://git
Clean backport of 8303680: Virtual Flow freezes after calling scrollTo and
scrollPixels in succession
Reviewed-by: angorya, jvos
-
Commit messages:
- 8303680: Virtual Flow freezes after calling scrollTo and scrollPixels in
succession
Changes: https://git.openjdk.org/jfx17u/pull/1
On Tue, 5 Sep 2023 23:36:25 GMT, Jose Pereda wrote:
> Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
> Reviewed-by: aghaisas, angorya
>
> There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
>
>
> -setS
Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
Reviewed-by: aghaisas, angorya
There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
-setSkin(new SkinStub(this));
+setSkin(new SkinStub<>(this));
-
Commit messages:
-
On Tue, 5 Sep 2023 20:12:36 GMT, Jose Pereda wrote:
> Clean backport of 8289751: Multiple unit test failures after JDK-8251483
> Reviewed-by: kcr
This pull request has now been integrated.
Changeset: 289ac761
Author: Jose Pereda
URL:
https://git.openjdk.org/jfx17u/
Clean backport of 8289751: Multiple unit test failures after JDK-8251483
Reviewed-by: kcr
-
Commit messages:
- 8289751: Multiple unit test failures after JDK-8251483
Changes: https://git.openjdk.org/jfx17u/pull/153/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=153&range
On Tue, 5 Sep 2023 18:59:56 GMT, Jose Pereda wrote:
> Clean backport of 8251483: TableCell: NPE on modifying item's list
> Reviewed-by: aghaisas, mstrauss
This pull request has now been integrated.
Changeset: 0985af97
Author:Jose Pereda
URL:
https://git.openjdk.org/jf
Clean backport of 8251483: TableCell: NPE on modifying item's list
Reviewed-by: aghaisas, mstrauss
-
Commit messages:
- 8251483: TableCell: NPE on modifying item's list
Changes: https://git.openjdk.org/jfx17u/pull/152/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=152&ra
On Tue, 5 Sep 2023 17:02:40 GMT, Jose Pereda wrote:
> Clean backport of 8251481: TableCell accessing row: NPE on auto-sizing
> Reviewed-by: fastegal
This pull request has now been integrated.
Changeset: 2e56cc0e
Author: Jose Pereda
URL:
https://git.openjdk.org/jfx17u/
On Tue, 5 Sep 2023 09:22:58 GMT, Jose Pereda wrote:
> Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
> Reviewed-by: aghaisas, angorya
>
> There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
>
> -setSkin
On Tue, 5 Sep 2023 09:22:58 GMT, Jose Pereda wrote:
> Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
> Reviewed-by: aghaisas, angorya
>
> There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
>
> -setSkin
Clean backport of 8251481: TableCell accessing row: NPE on auto-sizing
Reviewed-by: fastegal
-
Commit messages:
- 8251481: TableCell accessing row: NPE on auto-sizing
Changes: https://git.openjdk.org/jfx17u/pull/150/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=150&rang
Almost clean backport of 8298728: Cells in VirtualFlow jump after resizing
Reviewed-by: aghaisas, angorya
There was a small conflict in VirtualFlowTest::CellStub, due to JDK-8297414:
-setSkin(new SkinStub(this));
+setSkin(new SkinStub<>(this));
-
Commit messages:
-
On Mon, 4 Sep 2023 09:10:18 GMT, Jose Pereda wrote:
> Almost clean backport of 8089280: horizontal scrollbar should never become
> visible in TableView with constrained resize policy
>
> Reviewed-by: kcr, aghaisas
>
> It had some minor conflicts from JDK-8089280 (TableViewS
Almost clean backport of 8089280: horizontal scrollbar should never become
visible in TableView with constrained resize policy
Reviewed-by: kcr, aghaisas
It had some minor conflicts from JDK-8089280 (TableViewSkinBase: copyright
year, and TableViewTest, TreeTableViewTest: wrong insertion point
On Sun, 3 Sep 2023 18:46:48 GMT, Jose Pereda wrote:
> Almost clean backport of 8307960: Create Table Column PopupMenu lazily
> Reviewed-by: angorya
>
> There was a conflict from JDK-8297414: Remove easy warnings in
> javafx.controls, that was easily fixed.
This pull reque
Almost clean backport of 8307960: Create Table Column PopupMenu lazily
Reviewed-by: angorya
There was a conflict from JDK-8297414: Remove easy warnings in javafx.controls,
that was easily fixed.
-
Commit messages:
- 8307960: Create Table Column PopupMenu lazily
Changes: https://gi
On Sat, 2 Sep 2023 12:47:18 GMT, Jose Pereda wrote:
> Clean backport of 8311097: Synchron XMLHttpRequest not receiving data
> Reviewed-by: jbhaskar, kcr
This pull request has now been integrated.
Changeset: 7e1a7122
Author: Jose Pereda
URL:
https://git.openjdk.org/jfx17u/
Clean backport of 8311097: Synchron XMLHttpRequest not receiving data
Reviewed-by: jbhaskar, kcr
-
Commit messages:
- 8311097: Synchron XMLHttpRequest not receiving data
Changes: https://git.openjdk.org/jfx17u/pull/146/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=146&r
On Fri, 1 Sep 2023 11:53:22 GMT, Johan Vos wrote:
> Increase version to 17.0.9
Marked as reviewed by jpereda (Reviewer).
-
PR Review: https://git.openjdk.org/jfx17u/pull/137#pullrequestreview-1606826170
On Fri, 18 Aug 2023 17:48:16 GMT, Andy Goryachev wrote:
>> You might be right.
>>
>> In this case, `topPrefHeight` comes from `getAreaHeight()`, that calls
>> `computeChildPrefAreaHeight()` that ultimately uses `snapSpaceY()`.
>>
>> However, this would also mean that the returned value shoul
On Wed, 16 Aug 2023 21:26:21 GMT, Andy Goryachev wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Migrate old tests to JUnit 5
>
> modules/javafx.graphics/src/main/java/javafx/scene/
On Fri, 28 Jul 2023 09:11:07 GMT, Jose Pereda wrote:
> This PR adds a file lock to the cache directory, allowing access from
> multiple processes (that is, from more than one JVM) to that directory.
>
> This helps solving the issue where the cache is empty or doesn't exis
On Tue, 15 Aug 2023 17:26:11 GMT, Andy Goryachev wrote:
>> Unless we suspect a problem, I don't see a need to do anything differently.
>
> A possible problem is we might reach the maximum of open file handles in the
> underlying OS (I've experienced this before). I think we should definitely
>
On Tue, 15 Aug 2023 23:05:38 GMT, John Hendrikx wrote:
>> The original ("broken") version has been working fine, and no bugs have been
>> reported so far, and there would be a reason to have a custom implementation
>> instead of the one in `AbstractSet` in the first place.
>>
>> I'm not again
On Wed, 16 Aug 2023 12:11:54 GMT, Jose Pereda wrote:
> This PR fixes some failing tests that started failing after the check on
> animations being played on the JavaFX thread was enforced, by simply wrapping
> the `play` call with `Platform.runLater`
This pull request has now been i
This PR fixes some failing tests that started failing after the check on
animations being played on the JavaFX thread was enforced, by simply wrapping
the `play` call with `Platform.runLater`
-
Commit messages:
- Run timelines on JavaFX thread
Changes: https://git.openjdk.org/jfx/
On Tue, 15 Aug 2023 19:26:20 GMT, John Hendrikx wrote:
>> Okay, thanks for the clarification.
>>
>> So if I get it right, the removal of `toArray` doesn't have to do with the
>> bug, but with the fact that with the immutable set it is not longer required?
>
> I removed it because my fix requir
On Tue, 15 Aug 2023 14:08:08 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/PseudoClassState.java
>> line 65:
>>
>>> 63: /** {@inheritDoc} */
>>> 64: @Override
>>> 65: public T[] toArray(T[] a) {
>>
>> You have mentioned that this was a bug b
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had t
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had t
On Mon, 3 Jul 2023 15:49:31 GMT, Jose Pereda wrote:
> This PR adds a check to the Animation and AnimationTimer public methods to
> verify that these are called from the JavaFX Application thread. If the call
> is done from any other thread, an IllegalStateException will be thrown.
On Mon, 31 Jul 2023 17:47:06 GMT, Jose Pereda wrote:
>> This PR adds a check to the Animation and AnimationTimer public methods to
>> verify that these are called from the JavaFX Application thread. If the call
>> is done from any other thread, an IllegalStateExcept
On Mon, 31 Jul 2023 17:47:06 GMT, Jose Pereda wrote:
>> This PR adds a check to the Animation and AnimationTimer public methods to
>> verify that these are called from the JavaFX Application thread. If the call
>> is done from any other thread, an IllegalStateExcept
On Tue, 8 Aug 2023 12:25:53 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Migrate old tests to JUnit 5
>
> modules/javafx.graphics/src/test/java/test/javafx/sc
dk.org/browse/JDK-8313709, but still shows how without this
> patch, two of the cases (padding with or without margin) fail, while pass
> with it.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Migrate old tests to JUnit
On Mon, 7 Aug 2023 10:53:06 GMT, Jose Pereda wrote:
> So far, BorderPane does the calculation for the children min/pref
> width/height taken into account only the margin applied to them, if any, but
> not the total padding that could be applied as well to the BorderPane itself.
>
On Mon, 7 Aug 2023 10:53:06 GMT, Jose Pereda wrote:
> So far, BorderPane does the calculation for the children min/pref
> width/height taken into account only the margin applied to them, if any, but
> not the total padding that could be applied as well to the BorderPane itself.
>
101 - 200 of 292 matches
Mail list logo
