On Fri, 9 Feb 2024 03:37:17 GMT, Martin Fox wrote:
>> On Windows a common shortcut like Ctrl+'+' could only be invoked from the
>> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not
>> have enough context to know whether it should return a result from the main
>>
On Fri, 9 Feb 2024 03:37:17 GMT, Martin Fox wrote:
>> On Windows a common shortcut like Ctrl+'+' could only be invoked from the
>> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not
>> have enough context to know whether it should return a result from the main
>>
On Thu, 8 Feb 2024 19:26:42 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
On Thu, 8 Feb 2024 19:20:32 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
> On Windows a common shortcut like Ctrl+'+' could only be invoked from the
> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not
> have enough context to know whether it should return a result from the main
> keyboard or the keypad.
>
> This PR alters getKeyCodeForChar
On Fri, 17 Nov 2023 20:05:09 GMT, Martin Fox wrote:
> On Windows a common shortcut like Ctrl+'+' could only be invoked from the
> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not
> have enough context to know whether it should return a result from the main
>
On Fri, 17 Nov 2023 20:05:09 GMT, Martin Fox wrote:
> On Windows a common shortcut like Ctrl+'+' could only be invoked from the
> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not
> have enough context to know whether it should return a result from the main
>
On Fri, 17 Nov 2023 20:05:09 GMT, Martin Fox wrote:
> On Windows a common shortcut like Ctrl+'+' could only be invoked from the
> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not
> have enough context to know whether it should return a result from the main
>
On Fri, 17 Nov 2023 20:05:09 GMT, Martin Fox wrote:
> On Windows a common shortcut like Ctrl+'+' could only be invoked from the
> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not
> have enough context to know whether it should return a result from the main
>
On Windows a common shortcut like Ctrl+'+' could only be invoked from the main
keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not have
enough context to know whether it should return a result from the main keyboard
or the keypad.
This PR alters getKeyCodeForChar to pass in
On Mon, 10 Jul 2023 16:41:47 GMT, Andy Goryachev wrote:
>> At this point I don't have a strong opinion on whether this field is private
>> or not. Originally I wanted it to be private because I thought of it as
>> "whatever magic value makes KeyCharacterCombinations work" and was concerned
>>
On Tue, 9 May 2023 17:34:23 GMT, Martin Fox wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/input/KeyEvent.java line
>> 388:
>>
>>> 386: * The hardware key code which is private to the implementation.
>>> 387: */
>>> 388: private int hardwareCode;
>>
>> Does it need
On Thu, 11 May 2023 02:46:47 GMT, Martin Fox wrote:
>> Note: the Java-side changes in this PR are also in #694 which fixes the same
>> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
>> making it difficult to test on that platform (see #718).
>>
>>
On Fri, 9 Jun 2023 18:25:39 GMT, Martin Fox wrote:
> App developers have a hard time sorting this out
There was a discussion on the mailing list about adding a doc/ folder with
markdown informational notes. (Build instructions and snapping rules were the
prime candidates for such notes).
On Thu, 11 May 2023 02:46:47 GMT, Martin Fox wrote:
>> Note: the Java-side changes in this PR are also in #694 which fixes the same
>> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
>> making it difficult to test on that platform (see #718).
>>
>>
> Note: the Java-side changes in this PR are also in #694 which fixes the same
> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
> making it difficult to test on that platform (see #718).
>
> KeyCharacterCombinations allow the specification of accelerators based on
On Fri, 5 May 2023 20:20:02 GMT, John Hendrikx wrote:
> > I'm not quite sold on having `notifyKey` and `notifyKeyEx` be two separate
> > methods. Why not just have one? Not changing the existing call sites
> > doesn't seem to be a sufficient reason to expand the toolkit API surface.
>
> I
> Note: the Java-side changes in this PR are also in #694 which fixes the same
> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
> making it difficult to test on that platform (see #718).
>
> KeyCharacterCombinations allow the specification of accelerators based on
On Tue, 9 May 2023 20:38:35 GMT, Martin Fox wrote:
>> modules/javafx.graphics/src/main/native-glass/win/KeyTable.cpp line 366:
>>
>>> 364: UINT keyChar = ::MapVirtualKeyEx(UINT(hardwareCode), 2,
>>> layout);
>>> 365: // Filter out dead keys
>>> 366: BOOL isDead =
On Fri, 5 May 2023 20:04:12 GMT, John Hendrikx wrote:
>> Note: the Java-side changes in this PR are also in #694 which fixes the same
>> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
>> making it difficult to test on that platform (see #718).
>>
>>
On Fri, 5 May 2023 20:25:23 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line
>> 709:
>>
>>> 707: * The default implementation bridges into the existing
>>> getKeyCodeForChar call.
>>> 708: */
>>> 709: public boolean
On Fri, 5 May 2023 20:00:55 GMT, John Hendrikx wrote:
>> Note: the Java-side changes in this PR are also in #694 which fixes the same
>> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
>> making it difficult to test on that platform (see #718).
>>
>>
On Fri, 5 May 2023 19:45:53 GMT, John Hendrikx wrote:
>> Note: the Java-side changes in this PR are also in #694 which fixes the same
>> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
>> making it difficult to test on that platform (see #718).
>>
>>
On Fri, 5 May 2023 19:38:36 GMT, Martin Fox wrote:
> I'm not quite sold on having `notifyKey` and `notifyKeyEx` be two separate
> methods. Why not just have one? Not changing the existing call sites doesn't
> seem to be a sufficient reason to expand the toolkit API surface.
I also think it
On Thu, 4 May 2023 17:18:21 GMT, Martin Fox wrote:
> Note: the Java-side changes in this PR are also in #694 which fixes the same
> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
> making it difficult to test on that platform (see #718).
>
>
On Fri, 5 May 2023 16:35:38 GMT, Michael Strauß wrote:
> I'm not quite sold on having `notifyKey` and `notifyKeyEx` be two separate
> methods. Why not just have one? Not changing the existing call sites doesn't
> seem to be a sufficient reason to expand the toolkit API surface.
The long term
On Thu, 4 May 2023 17:18:21 GMT, Martin Fox wrote:
> Note: the Java-side changes in this PR are also in #694 which fixes the same
> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
> making it difficult to test on that platform (see #718).
>
>
On Thu, 4 May 2023 17:18:21 GMT, Martin Fox wrote:
> Note: the Java-side changes in this PR are also in #694 which fixes the same
> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
> making it difficult to test on that platform (see #718).
>
>
Note: the Java-side changes in this PR are also in #694 which fixes the same
issue (and more) on Linux. Unfortunately the Linux Robot code is not working
making it difficult to test on that platform (see #718).
KeyCharacterCombinations allow the specification of accelerators based on
29 matches
Mail list logo
