Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-08-09 Thread Kevin Rushforth
On Wed, 3 Aug 2022 23:41:54 GMT, Kevin Rushforth wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed pixel color tests on hi-dpi > > modules/javafx.graphics/src/main/java/com/sun/marlin/MarlinProperties.java

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-08-09 Thread Laurent Bourgès
On Thu, 4 Aug 2022 23:01:37 GMT, Kevin Rushforth wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed pixel color tests on hi-dpi > > I did a quick skim of the DPQS class, enough to know that code review is >

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-08-05 Thread Laurent Bourgès
On Thu, 4 Aug 2022 23:01:37 GMT, Kevin Rushforth wrote: > I did a quick skim of the DPQS class, enough to know that code review is > unlikely to spot the kind of subtle bugs that such code might have. So my > main question is around testing of DQPS itself. How much standalone testing > has bee

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-08-05 Thread Kevin Rushforth
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler) to

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-08-03 Thread Kevin Rushforth
On Fri, 29 Jul 2022 11:55:22 GMT, Laurent Bourgès wrote: >> At this point, due to time constraints, we will need to do this early in >> JavaFX 20 rather than late in JavaFX 19 (which is probably better anyway). > > @kevinrushforth could you tell me approximately when you will have free > cycles

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-08-03 Thread Kevin Rushforth
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler) to

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-29 Thread Kevin Rushforth
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler) to

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-29 Thread Laurent Bourgès
On Tue, 12 Jul 2022 23:05:06 GMT, Kevin Rushforth wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed pixel color tests on hi-dpi > > At this point, due to time constraints, we will need to do this early in >

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-14 Thread Laurent Bourgès
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler) to

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-12 Thread Kevin Rushforth
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler) to

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-08 Thread Laurent Bourgès
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler) to

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-08 Thread Laurent Bourgès
On Fri, 8 Jul 2022 18:02:44 GMT, Kevin Rushforth wrote: >> Yes, the tests now all pass on my MacBook Pro which has a retina display. >> >>> I will merge with my latest marlin code asap = 0.9.4.6 (2 more bugs fixed), >>> low risk (few lines) if you agree. >> >> Yes, that would be fine. Let's ch

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-08 Thread Kevin Rushforth
On Fri, 8 Jul 2022 18:01:25 GMT, Kevin Rushforth wrote: > I will merge with my latest marlin code asap = 0.9.4.6 (2 more bugs fixed), > low risk (few lines) if you agree. (but don't change your branch name or would need to create a new PR, which doesn't seem worth it) - PR: https

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-08 Thread Kevin Rushforth
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler) to

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-08 Thread Laurent Bourgès
> Changelog for this MarlinFX 0.9.4.5 release: > > The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path > clipper: > - improved Stroker to handle huge coordinates, up to 1E15 > - improved PathClipFilter (filler) to handle huge coordinates, up to 1E15 > > > This is the Marlin-

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-08 Thread Laurent Bourgès
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler) to