decrease it! On my Ubuntu system rmem_max and default
is 212992.
Thanks,
Hans
> -Original Message-
> From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
> Sent: den 19 maj 2014 06:41
> To: de...@list.opensaf.org; Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.ne
since that makes it impossible to use standard tool sysctl
Thanks,
Hans
> -Original Message-
> From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
> Sent: den 19 maj 2014 06:41
> To: de...@list.opensaf.org; Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
healtchecks can be delayed sitting in a queue somewhere...
Thanks,
Hans
> -Original Message-
> From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
> Sent: den 19 maj 2014 06:41
> To: de...@list.opensaf.org; Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subj
jo...@genband.com]
> Sent: den 13 maj 2014 16:59
> To: Nagendra Kumar; Hans Feldt; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 1 of 1] amfd: allow change to saAmfSGNumPrefActiveSUs for
> N+M SG while UNLOCKED [#871]
>
> Oh. That is really to di
> Sent: den 19 maj 2014 12:36
> To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] amfd: send node down notification during controller
> failover [#914]
>
> osaf/services/saf/amf/amfd/clm.cc
> -Original Message-
> From: SuryaNarayana Garlapati [mailto:suryanarayana.garlap...@oracle.com]
> Sent: den 20 maj 2014 08:17
> To: Hans Feldt; mahesh.va...@oracle.com; de...@list.opensaf.org
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 1
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: den 20 maj 2014 09:02
> To: Hans Feldt
> Cc: de...@list.opensaf.org; opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 3 of 3] dtm: make TCP_NODELAY set socket option
> config
> -Original Message-
> From: Nagendra Kumar [mailto:nagendr...@oracle.com]
> Sent: den 20 maj 2014 08:30
> To: Hans Feldt; Hans Nordebäck; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: RE: [PATCH 1 of 1] amfd: send node down notification during
>
> -Original Message-
> From: Nagendra Kumar [mailto:nagendr...@oracle.com]
> Sent: den 21 maj 2014 07:18
> To: Hans Feldt; Hans Nordebäck; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: RE: [PATCH 1 of 1] amfd: send node down notification du
getnext is not needed. Maps have a built in iterator that can/should be used
directly
At least that is the pattern followed so far.
/HansF
> -Original Message-
> From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
> Sent: den 21 maj 2014 12:00
> To: Hans Feldt; Ha
Ack
/Hans
> -Original Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: den 22 maj 2014 09:20
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] amfd: use correct SU when calling set_su_failover
> [#713]
>
>
Ack
/Hans
> -Original Message-
> From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
> Sent: den 22 maj 2014 10:31
> To: Hans Feldt; nagendr...@oracle.com; Hans Nordebäck
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] amfd:
Ack with tiny comments inline
Thanks,
Hans
> -Original Message-
> From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
> Sent: den 21 maj 2014 13:20
> To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subj
osaf/libs/core/include/ncsencdec_pub.h | 110 +++--
osaf/libs/core/leap/hj_enc.c | 144
2 files changed, 171 insertions(+), 83 deletions(-)
Services not using EDU ends repeating functionality that should be common.
This patch propo
icate scope for each "y" above):
-
changeset d5e676cc25730a7128dd96af993800059f53d8c4
Author: Hans Feldt
Date: Thu, 22 May 2014 14:55:05 +0200
base: add encode/decode utility functions [#910]
Services not using EDU ends repeat
Ack with minor comments inline
/Hans
> -Original Message-
> From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
> Sent: den 23 maj 2014 10:45
> To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [
osaf/services/saf/amf/amfd/ckpt_dec.cc | 7 +--
osaf/services/saf/amf/amfd/include/si.h | 1 +
osaf/services/saf/amf/amfd/si.cc| 2 +-
3 files changed, 7 insertions(+), 3 deletions(-)
abort in standby amfd with back trace:
#0 0x7f71264bcb35 in raise () from /lib64/libc.so.6
pe for each "y" above):
-
changeset d933a1f00ffd10767e168beff9654d4abcb6bfcd
Author: Hans Feldt
Date: Fri, 23 May 2014 13:21:08 +0200
amfd: create SI to store ckpt:ed dep_state [#926]
abort in standby amfd with back tr
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 23 maj 2014 15:06
> To: Hans Feldt
> Cc: nagendr...@oracle.com; opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 1 of 1] amfd: create SI to store ckpt:ed dep_state [#
Yes agree
Skickat från min Sony Xperia™-smartphone
praveen malviya skrev
On 23-May-14 6:40 PM, Hans Feldt wrote:
>> -Original Message-
>> From: praveen malviya [mailto:praveen.malv...@oracle.com]
>> Sent: den 23 maj 2014 15:06
>> To: Hans Feldt
>
"remove trace" means ENTER AND LEAVE
- for logs add "context" for example function name: log("%s: bla",
__FUNCTION__);
See inline
Thanks,
Hans
> -Original Message-
> From: Hans Nordebäck
> Sent: den 22 maj 2014 15:05
> To: Hans Feldt; praveen.malv
; From: Nagendra Kumar [mailto:nagendr...@oracle.com]
> Sent: den 16 maj 2014 08:28
> To: Gary Lee; Hans Feldt; Hans Nordebäck; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: RE: [PATCH 1 of 1] amfd: Remove asserts from validation routines
> [#849]
>
> Hi
Hi,
I think this is a good start. Some minor comments inline.
Thanks,
Hans
> -Original Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: den 26 maj 2014 05:46
> To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com;
> nagendr...@oracle.com
>
About comment nr1, I am not sure what I am talking about yet...
/HansF
> -Original Message-
> From: Hans Feldt [mailto:hans.fe...@ericsson.com]
> Sent: den 26 maj 2014 15:34
> To: Hans Nordebäck; praveen.malv...@oracle.com; nagendr...@oracle.com
> Cc: opensaf-devel@lists.
scope for each "y" above):
-
changeset 1db4cdd09d3d9e67a11ea7a8e67aa6dd95b2597b
Author: Hans Feldt
Date: Tue, 27 May 2014 14:41:51 +0200
amfd: create sgtype.h [#713]
changeset ead3a94139c8453935f23618a0bf1d253b1a9c61
Author: Hans Feldt
Date:
osaf/services/saf/amf/amfd/app.cc | 1 -
osaf/services/saf/amf/amfd/apptype.cc | 1 +
osaf/services/saf/amf/amfd/ckpt_dec.cc | 1 +
osaf/services/saf/amf/amfd/ckpt_updt.cc| 1 +
osaf/services/saf/amf/amfd/imm.cc | 1 +
osaf/services/saf/
osaf/services/saf/amf/amfd/include/Makefile.am | 1 +
osaf/services/saf/amf/amfd/include/app.h | 14 +---
osaf/services/saf/amf/amfd/include/apptype.h | 48 ++
3 files changed, 50 insertions(+), 13 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/inclu
osaf/services/saf/amf/amfd/include/su.h | 2 +-
osaf/services/saf/amf/amfd/su.cc| 43 ++--
2 files changed, 25 insertions(+), 20 deletions(-)
saAmfSUMaintenanceCampaign was not initialized properly thus causing SMF
campaigns to fail. While fixing that we al
ate scope for each "y" above):
-
changeset 0143eeaa1635db5e229ed505fb1d1371e8671ac0
Author: Hans Feldt
Date: Wed, 28 May 2014 09:44:12 +0200
amfd: fix SU constructor [#713]
saAmfSUMaintenanceCampaign was not initializ
See inline and please comment.
/HansF
> -Original Message-
> From: Nagendra Kumar [mailto:nagendr...@oracle.com]
> Sent: den 28 maj 2014 12:13
> To: Hans Nordebäck; Hans Feldt; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: RE: [PATCH 1 of 1] AMF:
Should find() stay as is with ptr argument instead of reference?
Skickat från min Sony Xperia™-smartphone
Hans Nordebäck skrev
Yes I can do that, it will be done next week.
/Regards HansN
On 05/28/14 12:21, praveen malviya wrote:
> Patch looks fine, but it cannot be pushed without mak
b4bdf9494440c1fedd317
Author: Hans Feldt
Date: Wed, 28 May 2014 14:10:20 +0200
amfd: use simple decode in SU ckpt [713]
changeset a6f671cf8cde40255df3d20d7e3828a2ec5e8f75
Author: Hans Feldt
Date: Wed, 28 May 2014 14:13:51 +0200
amfd: use simple encode
osaf/services/saf/amf/amfd/ckpt_edu.cc| 59 ---
osaf/services/saf/amf/amfd/ckpt_enc.cc| 139 -
osaf/services/saf/amf/amfd/include/ckpt_edu.h |3 -
3 files changed, 48 insertions(+), 153 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/ck
osaf/services/saf/amf/amfd/ckpt_enc.cc | 299 ++--
1 files changed, 95 insertions(+), 204 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/ckpt_enc.cc
b/osaf/services/saf/amf/amfd/ckpt_enc.cc
--- a/osaf/services/saf/amf/amfd/ckpt_enc.cc
+++ b/osaf/services/saf/a
osaf/services/saf/amf/amfd/ckpt_edu.cc| 68 ---
osaf/services/saf/amf/amfd/include/ckpt_edu.h | 9 ---
2 files changed, 0 insertions(+), 77 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/ckpt_edu.cc
b/osaf/services/saf/amf/amfd/ckpt_edu.cc
--- a/osaf/ser
osaf/services/saf/amf/amfd/ckpt_dec.cc | 473 +++-
osaf/services/saf/amf/amfd/ckpt_updt.cc| 12 +-
osaf/services/saf/amf/amfd/include/ckpt_updt.h |2 +-
osaf/services/saf/amf/amfd/include/su.h|2 +-
4 files changed, 140 insertions(+), 349 dele
osaf/services/saf/amf/amfd/ckpt_dec.cc | 265 +---
1 files changed, 73 insertions(+), 192 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc
b/osaf/services/saf/amf/amfd/ckpt_dec.cc
--- a/osaf/services/saf/amf/amfd/ckpt_dec.cc
+++ b/osaf/services/saf/a
Ack from me too. Since this is a defect Gary can you please provide one patch
per branch and some maintainer can push?
Thanks,
Hans
> -Original Message-
> From: Nagendra Kumar [mailto:nagendr...@oracle.com]
> Sent: den 28 maj 2014 13:08
> To: Gary Lee; Hans Feldt; Hans Nordeb
Ack
/Hans
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 29 maj 2014 14:34
> To: opensaf-devel@lists.sourceforge.net
> Cc: Alex Jones
> Subject: Re: [devel] [PATCH 1 of 1] amfnd: fix process of proxy/proxied
> cleanup on OpenSAF shutdown [#629
Ack,
This check was previously in avd_su_db_add but got removed with the new db
Thanks,
Hans
> -Original Message-
> From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
> Sent: den 30 maj 2014 13:20
> To: Hans Feldt; nagendr...@oracle.com
> Cc
nal Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: den 2 juni 2014 05:09
> To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com;
> nagendr...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 2] amfnd: Improve logging for error
Comments inline
Thanks,
Hans
> -Original Message-
> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
> Sent: den 2 juni 2014 08:20
> To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com;
> praveen.malv...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> S
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 2 juni 2014 09:20
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [opensaf:tickets] #654 MDS improvements
Hi Hans,
On 5/20/2014 12:36 AM, Hans Feldt wrote:
Next steps:
- Set DEST_DROPPABLE=False
What are we
@oracle.com [mailto:praveen.malv...@oracle.com]
> Sent: den 2 juni 2014 13:32
> To: Hans Feldt; nagendr...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] amfd : skip processing of ccb completed cbk at
> standby amfd [#305]
>
> osaf/services/saf/amf/amfd/imm.
osaf/services/saf/amf/amfd/include/su.h | 2 ++
osaf/services/saf/amf/amfd/sgproc.cc| 26 +++---
osaf/services/saf/amf/amfd/su.cc| 19 +++
3 files changed, 24 insertions(+), 23 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/su.h
osaf/services/saf/amf/amfd/include/su.h |9 +
osaf/services/saf/amf/amfd/su.cc| 461 +--
2 files changed, 257 insertions(+), 213 deletions(-)
complexity of su.cc dropped pretty good:
$ pmccabe su.cc | sort -nr | head -2
73 78 154 865 33
osaf/libs/common/amf/d2nmsg.c | 184 --
osaf/libs/common/amf/include/amf_d2nmsg.h |1 -
osaf/services/saf/amf/amfd/include/mds.h |1 -
osaf/services/saf/amf/amfd/include/msg.h |1 -
osaf/services/saf/amf/amfd/mds.cc | 175
osaf/services/saf/amf/amfd/include/su.h | 1 +
osaf/services/saf/amf/amfd/sgproc.cc| 40
osaf/services/saf/amf/amfd/su.cc| 17 ++
3 files changed, 28 insertions(+), 30 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/su.h
te scope for each "y" above):
-
changeset 4069cbdbf1b767fa0359c2933f8e516ca7550f13
Author: Hans Feldt
Date: Tue, 03 Jun 2014 06:22:25 +0200
amfd: remove mds copy support [#713]
This support is no longer needed. Was used
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 3 juni 2014 06:21
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [opensaf:tickets] #654 MDS improvements
Hi Hans,
On 6/2/2014 1:40 PM, Hans Feldt wrote:
[Hans] DEST_DROPPABLE works on the sending node whereas
Can this ugliness be removed later/somehow:
> + app_db->erase(Amf::to_string(&app->name));
Perhaps when "name" is a string?
/HansF
> -Original Message-
> From: Hans Nordebäck
> Sent: den 2 juni 2014 13:55
> To: Hans Feldt; nagendr...@oracle.c
> Sent: den 3 juni 2014 21:03
> To: Minh Chau H; Hans Feldt; Hans Nordebäck; Nagendra Kumar; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: RE: [devel] [PATCH 0 of 1] Review Request for v2 amfd: Send
> notifications when cold sync is completed [#860]
>
>
Guess not and I this one might as well be sent by the active amfd. It has the
knowledge
Skickat från min Sony Xperia™-smartphone
praveen malviya skrev
Here it is standby controller that is sending the notification.
Are there any other notifications which standby sends ?
Thanks
Prave
Ack minor comment inline
/Hans
> -Original Message-
> From: Hans Nordebäck
> Sent: den 4 juni 2014 08:55
> To: Hans Feldt; praveen.malv...@oracle.com; nagendr...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 2] amfd: use simple decode
Ack
/Hans
> -Original Message-
> From: Hans Nordebäck
> Sent: den 4 juni 2014 08:55
> To: Hans Feldt; praveen.malv...@oracle.com; nagendr...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 2 of 2] amfd: use simple encode in App ckpt [#713]
>
Ack but please ticket 713 since it is not closed. Again we should not have new
tickets when the original ticket is still open.
/Hans
> -Original Message-
> From: Hans Nordebäck
> Sent: den 5 juni 2014 13:40
> To: Hans Feldt; praveen.malv...@oracle.com; nagendr...@oracle.com
&
Why the attribute name prefix "opensaf"?
It should not be needed and adds no value.
Thanks,
Hans
> -Original Message-
> From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
> Sent: den 9 juni 2014 08:18
> To: reddy.neelaka...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.
> -Original Message-
> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
> Sent: den 5 juni 2014 14:13
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 1 of 4] amfd: remove mds copy support [#713]
>
> ack, minor com
Ack for series, review only
/HansF
> -Original Message-
> From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
> Sent: den 9 juni 2014 10:19
> To: praveen.malv...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [devel] [PATCH 0 of 2] Review Request for AMF: remove EDU
pe for each "y" above):
-
changeset bda1bfa3ffc9665f07539825955e4f81f8131a78
Author: Hans Feldt
Date: Fri, 28 Feb 2014 08:54:50 +0100
amfnd: correct term-failed behaviour [#538]
Possible split brain on application level an
osaf/services/saf/amf/amfnd/clc.cc | 3 +-
osaf/services/saf/amf/amfnd/su.cc | 1 -
osaf/services/saf/amf/amfnd/susm.cc | 56 +++-
3 files changed, 13 insertions(+), 47 deletions(-)
Possible split brain on application level and spec violation.
The AMF nod
And the rest of the series then?
I will look into this one but the other ones should be ok I hope.
Thanks,
Hans
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 9 juni 2014 13:40
> To: Hans Feldt
> Cc: opensaf-devel@lists.
osaf/services/saf/amf/amfd/include/sg.h | 13 +
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 23 ++-
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 22 +-
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 22 +-
osaf/s
osaf/services/saf/amf/amfd/include/sg.h | 19 +--
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 27 +--
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 27 +--
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 27 +--
osaf/services/saf/amf/amfd/include/app.h| 6 +++---
osaf/services/saf/amf/amfd/include/csi.h| 2 +-
osaf/services/saf/amf/amfd/include/sg.h | 14 +++---
osaf/services/saf/amf/amfd/include/sgtype.h | 8
osaf/services/saf/amf/amfd/include/si.h | 2 +-
osaf/s
osaf/services/saf/amf/amfd/ckpt_dec.cc | 4 +-
osaf/services/saf/amf/amfd/include/sg.h | 54 +--
osaf/services/saf/amf/amfd/sg.cc | 36 +
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 4 ++
osaf/services/saf/amf/amfd/sg_nored_fs
st of the comlexity
is. This fist patches will be followed by other to remove all functions
pointers changing them to methods and then cleanup of the fsm code.
changeset 3aa4160316dbf43bb6dd5b482aef01f7e4bc3ada
Author: Hans Feldt
Date: Wed, 11 Jun 2014 06:45:19 +0200
amfd: change struct
Not a proper commit message
/Hans
Skickat från min Sony Xperia™-smartphone
mahesh.va...@oracle.com skrev
osaf/services/saf/cpsv/cpnd/cpnd_evt.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
In case of section deletion dataSize is set to zero in the TrackCallback()
di
Not a proper commit message
/Hans
Skickat från min Sony Xperia™-smartphone
mahesh.va...@oracle.com skrev
osaf/libs/agents/saf/cpa/cpa_proc.c | 2 +-
osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
Now in the TrackCallback() the
tools/devel/review/00-README
It is impossible from just reading the patch to understand what this is about
/Hans
> -Original Message-
> From: Hans Feldt [mailto:hans.fe...@ericsson.com]
> Sent: den 11 juni 2014 08:28
> To: ramesh.bet...@oracle.com; mahesh.va...@oracle.com
&
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: den 11 juni 2014 08:49
> To: Hans Feldt
> Cc: ramesh.bet...@oracle.com; opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 1 of 1] cpsv: set dtaBuff to NULL and readSize to
>
I believe you should remove the macro while you are at it... Is that possible?
/Hans
> -Original Message-
> From: ramesh.bet...@oracle.com [mailto:ramesh.bet...@oracle.com]
> Sent: den 11 juni 2014 11:04
> To: mathi.naic...@oracle.com; Anders Widell
> Cc: opensaf-devel@lists.sourceforge.ne
osaf/services/saf/amf/amfd/ckpt_dec.cc | 8 +++-
osaf/services/saf/amf/amfd/include/db_template.h | 4 +++-
osaf/services/saf/amf/amfd/include/su.h | 2 --
osaf/services/saf/amf/amfd/su.cc | 21 -
4 files changed, 10 insertions(+),
osaf/services/saf/amf/amfd/imm.cc| 47
osaf/services/saf/amf/amfd/include/imm.h | 1 -
2 files changed, 0 insertions(+), 48 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/imm.cc
b/osaf/services/saf/amf/amfd/imm.cc
--- a/osaf/services/saf/amf/amf
s (indicate scope for each "y" above):
-
<>
changeset 7cb6d859dd4a435a297e0fc000fc54e5ab8b6e35
Author: Hans Feldt
Date: Fri, 13 Jun 2014 07:53:44 +0200
amfd: remove unused applier related code [#713]
changeset 4baddee30747f7dadf9e4efec59c38a4e
First great work with this series I will try find some time to review and test.
One comment inline
Thanks,
Hans
> -Original Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: den 13 juni 2014 07:49
> To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com;
&g
osaf/services/saf/amf/amfd/include/app.h| 6 +-
osaf/services/saf/amf/amfd/include/csi.h| 2 +-
osaf/services/saf/amf/amfd/include/sg.h | 18 +++---
osaf/services/saf/amf/amfd/include/sgtype.h | 8 ++--
osaf/services/saf/amf/amfd/include/si.h | 2 +-
osaf/services/saf/
osaf/services/saf/amf/amfd/include/sg.h | 19 +--
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 27 +--
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 27 +--
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 27 +--
most of the comlexity
is. This fist patches will be followed by other to remove all functions
pointers changing them to methods and then cleanup of the fsm code.
changeset ea37b5c651e813adc64c0b084848608569e24541
Author: Hans Feldt
Date: Mon, 16 Jun 2014 07:01:31 +0200
amfd: change
osaf/services/saf/amf/amfd/include/sg.h | 18 ++
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 23 ++-
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 22 +-
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 22 +-
o
osaf/services/saf/amf/amfd/ckpt_dec.cc | 4 +-
osaf/services/saf/amf/amfd/include/sg.h | 48 +--
osaf/services/saf/amf/amfd/sg.cc | 36 +++-
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 4 ++
osaf/services/saf/amf/amfd/sg_nored
Inline
Thanks,
Hans
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 16 juni 2014 11:49
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 2 of 4] amfd: add specialized red model specific
At the same time we have Application which
> can contains several SGs and an SG can contains several SUs and so on.
> In this way factory class can also be an application class (though it is
> not fully implemented) and inheritance will start from it.
> So, is it possible to make two factory
Ack
See inline
Thanks,
Hans
> -Original Message-
> From: praveen malviya [mailto:praveen.malv...@oracle.com]
> Sent: den 17 juni 2014 08:42
> To: Hans Feldt
> Cc: nagendr...@oracle.com; opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 1 of 1] amfd : skip
General comment, use NULL instead of 0
See inline for some comments.
/HansF
> -Original Message-
> From: Hans Nordebäck
> Sent: den 12 juni 2014 15:51
> To: Hans Feldt; praveen.malv...@oracle.com; nagendr...@oracle.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subj
osaf/services/saf/amf/amfd/include/proc.h| 5 -
osaf/services/saf/amf/amfd/include/sg.h | 14 --
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 22 +-
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 22 +-
osaf/services/saf/amf/a
n
Comments (indicate scope for each "y" above):
-
changeset a286a6bca7ddbf60107c3b937b73621b1d9a7ae6
Author: Hans Feldt
Date: Thu, 19 Jun 2014 07:48:41 +0200
amfd: change SG func ptr si_func to method si_as
osaf/services/saf/amf/amfd/include/proc.h| 5 -
osaf/services/saf/amf/amfd/include/sg.h | 14 --
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 22 +-
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 22 +-
osaf/services/saf/amf/a
osaf/services/saf/amf/amfd/include/proc.h| 5 -
osaf/services/saf/amf/amfd/include/sg.h | 17 ++---
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 25 +
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 25 +
osaf/services/
osaf/services/saf/amf/amfd/include/proc.h| 5 -
osaf/services/saf/amf/amfd/include/sg.h | 14 --
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 22 +-
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 22 +-
osaf/services/saf/amf/a
osaf/services/saf/amf/amfd/include/sg.h | 41 ++
osaf/services/saf/amf/amfd/sg.cc| 72 +
2 files changed, 113 insertions(+), 0 deletions(-)
Macros are supposed to be replaced by calls to these methods eventually.
diff --git a/osaf/servic
osaf/services/saf/amf/amfd/include/proc.h| 10 -
osaf/services/saf/amf/amfd/include/sg.h | 24 ++--
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 31 +--
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 31 +--
osa
osaf/services/saf/amf/amfd/include/proc.h | 3 ---
osaf/services/saf/amf/amfd/include/sg.h | 11 +--
osaf/services/saf/amf/amfd/sg.cc | 8
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 14 +-
osaf/services/saf/amf/amfd/si.cc | 19 +++---
osaf/services/saf/amf/amfd/include/proc.h| 5 -
osaf/services/saf/amf/amfd/include/sg.h | 14 --
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 22 +-
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 22 +-
osaf/services/saf/amf/a
osaf/services/saf/amf/amfd/csi.cc| 2 +-
osaf/services/saf/amf/amfd/include/proc.h| 15 ---
osaf/services/saf/amf/amfd/include/sg.h | 14 --
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 24 +---
osaf/services/saf/amf/amfd/sg_n
osaf/services/saf/amf/amfd/include/proc.h| 11 ---
osaf/services/saf/amf/amfd/sg.cc | 12
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 9 -
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 8
osaf/services/saf/amf/amfd/sg_npm_fsm.cc |
osaf/services/saf/amf/amfd/include/proc.h| 10
osaf/services/saf/amf/amfd/include/sg.h | 35 +--
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 34 +-
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 35 +--
n
Comments (indicate scope for each "y" above):
-
changeset 146ccec59c55b62b9bef93282ea5c2d8ceedb04e
Author: Hans Feldt
Date: Thu, 19 Jun 2014 12:24:40 +0200
base: add utilities for sending, receiving over a UNIX socket [#554]
osaf/libs/core/common/Makefile.am|3 +-
osaf/libs/core/common/include/Makefile.am|3 +-
osaf/libs/core/common/include/osaf_secutil.h | 83 +++
osaf/libs/core/common/osaf_secutil.c | 302 +++
4 files changed, 389 insertions(+), 2 deleti
OK to push with me
I think there is not much left todo except comptype (needs to be sorted out)
/HansF
> -Original Message-
> From: Hans Nordebäck
> Sent: den 23 juni 2014 09:29
> To: Nagendra Kumar; Hans Feldt; Praveen Malviya
> Cc: opensaf-devel@lists.sourceforge.ne
1 - 100 of 901 matches
Mail list logo
