Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-14 Thread Huie-Ying Lee
Ludovic Rousseau wrote: > On Mon, Oct 13, 2008 at 8:24 PM, Huie-Ying Lee <[EMAIL PROTECTED]> wrote: > >> OK, the updated patch is attached. >> > > Commited in revision 341. > http://www.opensc-project.org/pam_pkcs11/changeset/341 > > I added some more i18n and French l10n. > > Thanks > >

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-14 Thread Ludovic Rousseau
On Mon, Oct 13, 2008 at 8:24 PM, Huie-Ying Lee <[EMAIL PROTECTED]> wrote: > OK, the updated patch is attached. Commited in revision 341. http://www.opensc-project.org/pam_pkcs11/changeset/341 I added some more i18n and French l10n. Thanks -- Dr. Ludovic Rousseau __

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-13 Thread Huie-Ying Lee
Ludovic Rousseau wrote: On Fri, Oct 10, 2008 at 8:38 PM, Huie-Ying Lee <[EMAIL PROTECTED]> wrote: Robert Relyea wrote: It still looks like you are unconditionally changing the prompt to be 'Enter your user name'. That still leaves the problem of telling the user that 'smart card login'

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-11 Thread Ludovic Rousseau
On Fri, Oct 10, 2008 at 8:38 PM, Huie-Ying Lee <[EMAIL PROTECTED]> wrote: > Robert Relyea wrote: >> It still looks like you are unconditionally changing the prompt to be >> 'Enter your user name'. That still leaves the problem of telling the user >> that 'smart card login' is enabled. We at least n

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-11 Thread Ludovic Rousseau
On Fri, Oct 10, 2008 at 7:49 PM, Robert Relyea <[EMAIL PROTECTED]> wrote: > Ludovic Rousseau wrote: >> >> On Fri, Oct 10, 2008 at 2:45 AM, Robert Relyea <[EMAIL PROTECTED]> wrote: >> >>> >>> BTW does the _(password_prompt) do the right thing for the translation >>> teams? >>> >> >> >> In general we

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-10 Thread Huie-Ying Lee
Robert Relyea wrote: Huie-Ying Lee wrote: Hello, I have completed the prompt configuration enhancement, as suggested by Ludovic. In this enhancement, I added a new field, token_type, in the pam_pkcs11.conf file. The value of the "token_type" will be used in the user prompt messages a

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-10 Thread Robert Relyea
Ludovic Rousseau wrote: On Fri, Oct 10, 2008 at 2:45 AM, Robert Relyea <[EMAIL PROTECTED]> wrote: BTW does the _(password_prompt) do the right thing for the translation teams? In general we go that using a declaration like N_("Smart card") in the source code. OK, that's the part I

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-10 Thread Robert Relyea
Douglas E. Engert wrote: You need to look at the bigger picture of how the pam stack is being called, and what the user is seeing on the screen. So I don't have a problem with the ability to change the prompt on pam_pkcs11, but I do have a problem with forcing the change. In our situation, we

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-10 Thread Douglas E. Engert
Robert Relyea wrote: > Huie-Ying Lee wrote: >> Hello, >> >> I have completed the prompt configuration enhancement, as suggested by >> Ludovic. In this enhancement, I added a new field, token_type, in >> the pam_pkcs11.conf file. The value of the "token_type" will be >> used in the user

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-10 Thread Ludovic Rousseau
On Fri, Oct 10, 2008 at 2:45 AM, Robert Relyea <[EMAIL PROTECTED]> wrote: > BTW does the _(password_prompt) do the right thing for the translation > teams? That would translate the string contained in password_prompt so this call is OK. But the program shall also declare that the string "Smart car

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-09 Thread Robert Relyea
Huie-Ying Lee wrote: Hello, I have completed the prompt configuration enhancement, as suggested by Ludovic. In this enhancement, I added a new field, token_type, in the pam_pkcs11.conf file. The value of the "token_type" will be used in the user prompt messages and its default value i

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-10-09 Thread Huie-Ying Lee
Hello, I have completed the prompt configuration enhancement, as suggested by Ludovic. In this enhancement, I added a new field, token_type, in the pam_pkcs11.conf file. The value of the "token_type" will be used in the user prompt messages and its default value is "Smart card". The

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-09-30 Thread Huie-Ying Lee
Ludovic Rousseau wrote: > On Tue, Sep 30, 2008 at 1:49 AM, Huie-Ying Lee <[EMAIL PROTECTED]> wrote: >> Ludovic Rousseau wrote: >>> Hello, >>> >>> On Sat, Sep 27, 2008 at 12:27 AM, Huie-Ying Lee <[EMAIL PROTECTED]> >>> wrote: >>> The pam_pkcs11 module assumpts that all PKCS#11 tokens are smart

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-09-30 Thread Douglas E. Engert
Huie-Ying Lee wrote: > Douglas E. Engert wrote: >> >> >> Huie-Ying Lee wrote: >>> Hello, >>> >>> The pam_pkcs11 module assumpts that all PKCS#11 tokens are >>> smartcards, so it will display "Smart card" key word in the PAM >>> prompt message.However, most of the PKCS#11 tokens are not Sm

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-09-30 Thread Ludovic Rousseau
On Tue, Sep 30, 2008 at 1:49 AM, Huie-Ying Lee <[EMAIL PROTECTED]> wrote: > Ludovic Rousseau wrote: >> >> Hello, >> >> On Sat, Sep 27, 2008 at 12:27 AM, Huie-Ying Lee <[EMAIL PROTECTED]> >> wrote: >> >>> >>> The pam_pkcs11 module assumpts that all PKCS#11 tokens are smartcards, >>> so >>> it will

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-09-29 Thread Huie-Ying Lee
Douglas E. Engert wrote: > > > Huie-Ying Lee wrote: >> Hello, >> >> The pam_pkcs11 module assumpts that all PKCS#11 tokens are >> smartcards, so it will display "Smart card" key word in the PAM >> prompt message.However, most of the PKCS#11 tokens are not Smart >> cards. so we modified som

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-09-29 Thread Huie-Ying Lee
Ludovic Rousseau wrote: > Hello, > > On Sat, Sep 27, 2008 at 12:27 AM, Huie-Ying Lee <[EMAIL PROTECTED]> wrote: > >> The pam_pkcs11 module assumpts that all PKCS#11 tokens are smartcards, so >> it will display "Smart card" key word in the PAM prompt message.However, >> most of the PKCS#11

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-09-29 Thread Huie-Ying Lee
Robert Relyea wrote: > Huie-Ying Lee wrote: >> Hello, >> >> The pam_pkcs11 module assumpts that all PKCS#11 tokens are >> smartcards, so it will display "Smart card" key word in the PAM >> prompt message.However, most of the PKCS#11 tokens are not Smart >> cards. so we modified some prompt

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-09-29 Thread Douglas E. Engert
Huie-Ying Lee wrote: > Hello, > > The pam_pkcs11 module assumpts that all PKCS#11 tokens are smartcards, > so it will display "Smart card" key word in the PAM prompt message. > However, most of the PKCS#11 tokens are not Smart cards. so we modified > some prompt messages to avoid confusi

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-09-29 Thread Ludovic Rousseau
Hello, On Sat, Sep 27, 2008 at 12:27 AM, Huie-Ying Lee <[EMAIL PROTECTED]> wrote: > The pam_pkcs11 module assumpts that all PKCS#11 tokens are smartcards, so > it will display "Smart card" key word in the PAM prompt message.However, > most of the PKCS#11 tokens are not Smart cards. so we mod

Re: [opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-09-26 Thread Robert Relyea
Huie-Ying Lee wrote: Hello, The pam_pkcs11 module assumpts that all PKCS#11 tokens are smartcards, so it will display "Smart card" key word in the PAM prompt message.However, most of the PKCS#11 tokens are not Smart cards. so we modified some prompt messages to avoid confusion when we p

[opensc-devel] Some small PAM prompt changes to pam_pkcs11 module

2008-09-26 Thread Huie-Ying Lee
Hello, The pam_pkcs11 module assumpts that all PKCS#11 tokens are smartcards, so it will display "Smart card" key word in the PAM prompt message. However, most of the PKCS#11 tokens are not Smart cards. so we modified some prompt messages to avoid confusion when we ported this module to S