Re: [opensource-dev] Review Request: OPEN-152 Fog is broken on water, and extra-broken on water in deferred rendering

2013-01-11 Thread Geenz Spad
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/611/#review1291 --- Ship it! Looks good to me. - Geenz Spad On Dec. 2, 2012,

Re: [opensource-dev] Upcoming server side avatar baking

2013-01-11 Thread Henri Beauchamp
On Wed, 9 Jan 2013 17:26:51 +0100, Henri Beauchamp wrote: The Linux viewer available for download from Sunshine's Wiki page has alas been compiled with a way too new glibc end refuse to run on my system (Mandriva 2010.2, glibc v2.11.1), aborting with: bin/do-not-directly-run-secondlife-bin:

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
On Dec. 2, 2012, 9:23 a.m., Celierra Darling wrote: indra/newview/app_settings/settings.xml, line 7823 http://codereview.secondlife.com/r/612/diff/1/?file=8132#file8132line7823 I still think it might be valuable to attenuate (HSV) saturation, but since it'd been stuck at 1.0

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/612/ --- (Updated Jan. 11, 2013, 1:16 p.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/612/ --- (Updated Jan. 11, 2013, 1:22 p.m.) Review request for Viewer.

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
On Dec. 2, 2012, 9:23 a.m., Celierra Darling wrote: indra/newview/app_settings/shaders/class2/deferred/sunLightSSAOF.glsl, line 127 http://codereview.secondlife.com/r/612/diff/1/?file=8137#file8137line127 The 'if' here might be problematic.. I remember some cards were choking

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
On Dec. 2, 2012, 9:23 a.m., Celierra Darling wrote: indra/newview/app_settings/shaders/class2/deferred/sunLightSSAOF.glsl, line 127 http://codereview.secondlife.com/r/612/diff/1/?file=8137#file8137line127 The 'if' here might be problematic.. I remember some cards were choking

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Tofu Buzzard
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/612/ --- (Updated Jan. 11, 2013, 1:34 p.m.) Review request for Viewer. Changes

[opensource-dev] Review Request: OPEN-159 / Faster, nicer Depth of Field

2013-01-11 Thread Tofu Buzzard
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/615/ --- Review request for Viewer. Description --- This turns on bilinear

Re: [opensource-dev] Review Request: OPEN-159 / Faster, nicer Depth of Field

2013-01-11 Thread Tofu Buzzard
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/615/ --- (Updated Jan. 11, 2013, 2 p.m.) Review request for Viewer. Description

Re: [opensource-dev] Review Request: OPEN-159 / Faster, nicer Depth of Field

2013-01-11 Thread Tofu Buzzard
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/615/#review1295 --- indra/llrender/llpostprocess.cpp

Re: [opensource-dev] Review Request: OPEN-159 / Faster, nicer Depth of Field

2013-01-11 Thread Monty Brandenberg
On 1/11/2013 5:03 PM, Tofu Buzzard wrote: llassert_always(false); Ah, yes. I added this assert to mark this function as broken because it ate some of my time just unobviously doing nothing. http://catb.org/jargon/html/magic-story.html ___

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Celierra Darling
On Dec. 2, 2012, 9:23 a.m., Celierra Darling wrote: indra/newview/app_settings/settings.xml, line 7823 http://codereview.secondlife.com/r/612/diff/1/?file=8132#file8132line7823 I still think it might be valuable to attenuate (HSV) saturation, but since it'd been stuck at 1.0

Re: [opensource-dev] Review Request: VWR-29083 Make SSAO work better

2013-01-11 Thread Celierra Darling
On Dec. 2, 2012, 9:23 a.m., Celierra Darling wrote: indra/newview/app_settings/shaders/class2/deferred/sunLightSSAOF.glsl, line 132 http://codereview.secondlife.com/r/612/diff/1/?file=8137#file8137line132 Out of curiosity, why a minimum, instead of ex. (angrel0) ? distrel :

Re: [opensource-dev] Upcoming server side avatar baking

2013-01-11 Thread Latif Khalifa
On Fri, Jan 11, 2013 at 9:13 PM, Henri Beauchamp sl...@free.fr wrote: Nevermind (though, having a propely built Linux Sunshine-viewer would still be a good thing), I figured out the bug (race condition between links creation in COF and rebake requests). How do you work around that? When I was