'namespace boost' around
intrusive functions. I couldn't get it explained to Oz...
- Aleric Inglewood
On April 13, 2013, 3:21 p.m., Nicky Perian wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
rate, but will still fail to
reach the final scale when you increase the frame rate (or when the destination
scale is simply so close to the start scale that this condition is never true).
- Aleric Inglewood
On Feb. 17, 2013, 7:02 p.m., MartinRJ Fayray wrote
(Singularity has this
patch since a long time).
- Aleric Inglewood
On Sept. 19, 2012, 8:26 a.m., Gistya Eusebio wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/603
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/313/#review793
---
indra/llvfs/lldiriterator.cpp
On June 21, 2011, 6:56 a.m., Aleric Inglewood wrote:
indra/llvfs/lldiriterator.cpp, line 123
http://codereview.secondlife.com/r/313/diff/1/?file=2823#file2823line123
What is your reasoning to use native() here and not string()?
Boroondas Gupte wrote:
I tried to stick to a 1
On June 21, 2011, 6:56 a.m., Aleric Inglewood wrote:
indra/llvfs/lldiriterator.cpp, line 123
http://codereview.secondlife.com/r/313/diff/1/?file=2823#file2823line123
What is your reasoning to use native() here and not string()?
Boroondas Gupte wrote:
I tried to stick to a 1
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/324/#review736
---
Ship it!
- Aleric
On June 7, 2011, 11:42 a.m., Log Linden
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/315/#review724
---
indra/newview/llvocache.cpp
This is just a reminder that there are still six patches of me waiting
on the reviewboard:
https://codereview.secondlife.com/r/88/
https://codereview.secondlife.com/r/92/
https://codereview.secondlife.com/r/80/
https://codereview.secondlife.com/r/95/
https://codereview.secondlife.com/r/81/
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review429
---
Ship it!
Perfect.
- Aleric
On March 7, 2011, 3:51 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/172/#review416
---
You want to know what I think...
On Feb. 27, 2011, 5:57 a.m., Boroondas Gupte wrote:
indra/llcommon/llavatarname.cpp, lines 93-108
http://codereview.secondlife.com/r/153/diff/1/?file=981#file981line93
This could be shortened to
if (!mUsername.empty() !mIsDisplayNameDefault)
{
, 6:56 a.m., Aleric Inglewood wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/167/
---
(Updated Feb. 26, 2011, 6:56 a.m
---
On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/167
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/167/
---
Review request for Viewer.
Summary
---
Oz: please merge into your
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/167/#review388
---
On Feb. 26, 2011, 6:56 a.m., Aleric Inglewood wrote:
---
This is an automatically
, especially Linden Lab prebuilt. Therefore
I think it's better to use PREBUILT as keyword than
SYSTEM_LIBS.
On Mon, Feb 21, 2011 at 4:46 PM, Boroondas Gupte
slli...@boroon.dasgupta.ch wrote:
On 02/21/2011 04:41 PM, Aleric Inglewood wrote:
A LOT worse, but still better than 'standalone' would
On Feb. 3, 2011, 6:35 p.m., Aleric Inglewood wrote:
Can this patch please be added to viewer-development? It's getting really
annoying that I have to apply patches to the soruce tree before it even can
compile cleanly :(.
- Aleric
sucks a bit]
- Aleric
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/81/#review300
---
On Jan. 16, 2011, 5:53 a.m., Aleric Inglewood
://codereview.secondlife.com/r/99/#review315
---
On Jan. 29, 2011, 9:10 a.m., Aleric Inglewood wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/99
If you are using linux and get this error while compiling the viewer:
/usr/bin/ld: error: unsupported symbol binding
(or, for that matter:
/usr/bin/gold: error: unsupported symbol binding
then you are using ld.gold version 2.20.x.
You need to upgrade it to 2.21.
If you are using debian
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/99/
---
(Updated Jan. 29, 2011, 9:10 a.m.)
Review request for Viewer.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review245
---
Ship it!
Latest diff looks good. Great that you found the
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/93/
---
(Updated Jan. 21, 2011, 4:25 a.m.)
Review request for Viewer.
Changes
there are several cascaded ones. :-)
Aleric Inglewood wrote:
Yeah, I'm strongly convinced that TYPE const is superior in anyway over
const TYPE.
See http://www.xs4all.nl/~carlo17/cpp/const.qualifier.html for the
reasoning.
In one line: all type qualifiers work to the left, it's best
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/81/#review221
---
On Jan. 16, 2011, 5:53 a.m., Aleric Inglewood wrote
On Jan. 20, 2011, 3:54 a.m., Boroondas Gupte wrote:
I agree though, that we should try to handle this similarly in both tests,
if possible. So I tried setting the pointers in
indra/llui/tests/llurlentry_stub.cpp to NULL, too, which works nicely.
However, I then realized that the
. I need to
understand better what that idx is all about or you need to give a bit more
explanation before I approve this diff.
Aleric Inglewood wrote:
The debug setting CacheValidateCounter is set to 'next_id', which makes
clear what it's meaning is: namely, the id that we will check
I can confirm that. I'm using a RAM disk (0.08ms random access time)
and that does indeed
drop link time significantly (I measured 8 seconds for viewer 1, not
sure how long it is
for viewer 2).
___
Policies and (un)subscribe information available here:
for setting the
other also to a random string, like Grumpity Productengine, or Aleric
Inglewood now I think about it. Other options are All Your Base Are Belong To
Us and Hi mom!. Got be SURE they aren't used though -- don't want any new
'Grumpity' embarrashments :p
- Aleric
On Jan. 18, 2011, 7:29
---
On Jan. 14, 2011, 1:02 p.m., Aleric Inglewood wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/90
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/80/
---
(Updated Jan. 17, 2011, 5:24 a.m.)
Review request for Viewer.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/87/
---
(Updated Jan. 17, 2011, 5:32 a.m.)
Review request for Viewer.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/97/#review179
---
Ship it!
Perfect ;)
- Aleric
On Jan. 17, 2011, 10:03 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/99/
---
Review request for Viewer.
Summary
---
Please see
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/96/
---
Review request for Viewer.
Summary
---
This patch stops early spawns
/81/#review153
---
On Jan. 16, 2011, 5:53 a.m., Aleric Inglewood wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/81
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/84/
---
(Updated Jan. 16, 2011, 6:12 a.m.)
Review request for Viewer.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/83/#review154
---
On Jan. 14, 2011, 12:48 p.m., Aleric Inglewood wrote
I'm afraid that VWR-24366 won't reduce link times significantly.
On Fri, Jan 14, 2011 at 11:49 PM, Boroondas Gupte
slli...@boroon.dasgupta.ch wrote:
On 01/14/2011 06:04 PM, Jonathan Welch wrote:
I just did a quick study on link times for various viewers on my 2Gb XP
system
Viewer 1st link
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/81/
---
Review request for Viewer.
Summary
---
Turns out that most of my
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/82/
---
Review request for Viewer.
Summary
---
See
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/83/
---
Review request for Viewer.
Summary
---
At start up one can get the
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/84/
---
Review request for Viewer.
Summary
---
This turned out to be a simple
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/85/
---
Review request for Viewer.
Summary
---
Fixes a bug that causes the
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/86/
---
Review request for Viewer.
Summary
---
Fixes this warning. Note that
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/88/
---
Review request for Viewer.
Summary
---
These are caused because
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/89/
---
Review request for Viewer.
Summary
---
See
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/90/
---
Review request for Viewer.
Summary
---
Trivial patch, just removes
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/91/
---
Review request for Viewer.
Summary
---
Without this patch,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/92/
---
Review request for Viewer.
Summary
---
Added: On linux, when
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/93/
---
Review request for Viewer.
Summary
---
Just fixed the logic, so
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/94/
---
Review request for Viewer.
Summary
---
See
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/95/
---
Review request for Viewer.
Summary
---
Setting CMAKE_EXE_LINKER_FLAGS
And now for the real answer...
You can't resize a prim along an arbitrary axis, so if any linked
prim is rotated, it's simply not possible (in 99.9% of the cases).
You might be able to pull it of for many special cases by changing
sheer values, and use rotation (and texture rotation to correct
On Jan. 6, 2011, 5:37 p.m., Aleric Inglewood wrote:
This is really not how you want to deal with this bug :/. It's a known
fact that audio mixers are very bad with low volumes. Setting a volume to 0
(or something really small) can put a very high load on the CPU for the
audio mixer
On Jan. 7, 2011, 9:36 a.m., Joshua Linden wrote:
I believe Aleric's comment is accurate. Logic testing for a prefix should
be removed from the patch, and the flag should simply always be specified
in this case.
It is notable that the flag does trigger exactly the same test that is
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/70/#review119
---
You missed indra/newview/llfloaterwebcontent.cpp
Also, why not
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/71/#review120
---
What about /Me, /ME or /me followed by another punctuation? Ie,
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/70/#review124
---
Ship it!
Should be ok, I see no diff on the review board at all
On Jan. 6, 2011, 7 a.m., Aleric Inglewood wrote:
What about /Me, /ME or /me followed by another punctuation? Ie, /me?,
/me!, etc...
Just asking because these comparisions with just /me and /me' seem
very limited,
almost weird. More logical would be to not check anything at ALL
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/18/#review107
---
Ship it!
- Aleric
On Dec. 23, 2010, 12:12 p.m., Jonathan Yap
On Wed, Dec 29, 2010 at 10:05 PM, Nicky D. sl.nicky...@googlemail.com wrote:
But I just *run* snowstorm under gdb by setting LL_WRAPPER. I have not
one breakpoint
set, neither do I interrupt the program at all.
I just use the viewer and it will just lock up the whole X display
sooner or
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/67/#review101
---
I think this line should be deleted, not commented out. If there
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/65/#review88
---
indra/newview/llpanelmaininventory.cpp
The attachment to this post, of 2.5 MB, caused my firewall PC to
overload while
trying to determine if it is spam, spamd to time out and temporarily
reject the
mail, which caused google to try to deliver it over and over again (27
times so far).
I'd like to request that large attachments are not
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/63/#review78
---
Huh - I wrote this a long time ago (before the others commented)...
On 2010-12-23 17:29:10, Aleric Inglewood wrote:
indra/llkdu/llimagej2ckdu.h, line 58
http://codereview.secondlife.com/r/63/diff/1/?file=255#file255line58
This feels wrong. Those functions are implementations of the base class
interface, they are called by the base class
On 2010-12-20 14:40:41, Nyx Linden wrote:
I have no technical objections to the code provided.
And in fact, the code provided *should* change the functionality back to
what the users are reporting is their expectation of what the behavior
should be.
The part that makes me nervous
but is only visible along the outside of the region along the
void. Also, what about prims that are centered in a neiboring region? Are
thous detected as encroaching?
On Wed, Dec 22, 2010 at 10:45 AM, Aleric Inglewood
aleric.inglew...@gmail.com mailto:aleric.inglew...@gmail.com wrote
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/48/
---
(Updated 2010-12-21 07:59:33.568556)
Review request for Viewer.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/46/
---
(Updated 2010-12-20 06:19:04.960312)
Review request for Viewer.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/49/
---
Review request for Viewer.
Summary
---
Work around for bug in cmake
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/39/#review49
---
On 2010-12-18 09:01:35, Aleric Inglewood wrote
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/44/
---
Review request for Viewer.
Summary
---
If tut/tut.hpp isn't installed
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/45/
---
Review request for Viewer.
Summary
---
Only define -DLIB_NDOF=1 when
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/46/
---
Review request for Viewer.
Summary
---
This patch has only effect on
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/47/
---
Review request for Viewer.
Summary
---
On linux (and remember this is
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/48/
---
Review request for Viewer.
Summary
---
To use ld.gold configure with:
---
On 2010-12-19 09:42:53, Aleric Inglewood wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/48
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/39/
---
Review request for Viewer.
Summary
---
There is no #include tut.h
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/29/
---
Review request for Viewer.
Summary
---
Packages (tar balls) installed
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/18/#review32
---
..testing the review system (hi mom!)..
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/6/#review37
---
Ship it!
99% chance that this is correct (not counting the added
On 2010-12-16 11:11:33, Kitty Barnett wrote:
*confuzzled*
Does it want an incremental change starting at the previous diff? Or a diff
that includes the original diff (starting from viewer-dev)?
When I click on the link 'Diff r2', I don't get a diff - I get an error message
that 2 our of 5
In indra/newview/llfeaturemanager.cpp LLFeatureManager::loadGPUClass
reads the file GPU_TABLE_FILENAME
and LLFeatureManager::parseGPUTable matches
the string 'renderer' with it.
You could start with printing 'renderer'
and see if it's the same on windows
and Mac and if not find out why not.
If on
On Fri, Dec 17, 2010 at 2:48 AM, Aleric Inglewood
aleric.inglew...@gmail.com wrote:
In indra/newview/llfeaturemanager.cpp LLFeatureManager::loadGPUClass
reads the file GPU_TABLE_FILENAME
and LLFeatureManager::parseGPUTable matches
the string 'renderer' with it.
You could start with printing
I'm not happy to say it, but I can't help myself...
I told you so
When LL announced the TPV list, it was already clear to me
that they want to control what viewer can connect and that
this was the beginning of whitelist. Soon every viewer that
is not derived from their holy 2.0 will be blocked.
people that I have learned to appreciate and respect are
already there. If you are not, please join us! This doesn't have
to a goodbye: I hope to see you join us on the other side!
Thank you for your time,
Aleric Inglewood.
PS CC to imprudence mailinglist
Hi,
I didn't actually test it, but looked at the changeset in a review-kind-of-way,
and have the following concerns:
1) It has been agreed in the past, imho, that this would be turned off
by default;
the current patch turns it on.
2) If there has communication with people with this turned
The following has been proposed before:
* Add new bits to each object (all existing objects should act as if
all bits are set).
* Give the bits a default meaning (read: human readable word, which
can be different per attachment point),
but allow each user to override those descriptions locally.
the add and remove
attachments/clothing EVERY time, when wearing stuff from inventory.
Any change to wearing a new outfit that is in a just-bought box is
orthogonal to my proposal.
( all this marked with a giant IMHO)
--
Sent by iPhone
Il giorno 27/ago/2010, alle ore 14:11, Aleric Inglewood
Status: reviewed by Merov, committed to snowglobe 1.4, 1.5 and 2.1.
Background:
When developing many viewers in parallel (and snowstorm with it's many
clones that need to be checked out
won't change that), it becomes necessary to automate certain things with
scripts. One of the things those
The auto builds (at least for 1.5) seem to have stopped.
Can this please be fixed asap?
Aleric
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep
Please your attention for http://jira.secondlife.com/browse/SNOW-799
The only reason I can currently think of that this might not be a
showstopper is when
it is caused by having 'Use HTTP textures' turned on... but shouldn't that
be working with 1.4?
Cursors are missing from the artwork...
This was assigned to Soft Linden who closed it as 'resolved', but it is NOT
resolved.
Should I be confused? Perhaps it should be assigned to Merov?
___
Policies and (un)subscribe information available here:
I can't think of a reason that adding any files to the repository can or
should be blocking someone from doing an update.
And since I haven't seen any error messages or explanation, I'm clueless.
Seems like a local problem to me.
On Tue, Jul 27, 2010 at 8:20 AM, Philippe (Merov) Bossut
Hi all,
the jira makes no difference between Snowglobe 1.4 and Snowglobe 2.1, the
two most active development branches
at the moment. While many jira entries are specifically about one or the
other, some things apply to both.
There are two ways to deal with this: either create a new jira for the
I did a few commits:
http://svn.secondlife.com/trac/linden/changeset/3486
http://svn.secondlife.com/trac/linden/changeset/3487
http://svn.secondlife.com/trac/linden/changeset/3488
http://svn.secondlife.com/trac/linden/changeset/3489
After that it compiled and linked for me on linux, and probably
/snowglobe_icon.png ... but just now
realized
that that is a symbolic link that I added in order to run the viewer without
packaging it :/.
I'll make a new commit that reverts the last hunk of changeset 3489.
On Wed, Jul 14, 2010 at 4:42 PM, Aleric Inglewood
aleric.inglew...@gmail.com wrote:
Hi Merov, can
1 - 100 of 118 matches
Mail list logo
