[Openvpn-devel] Summary of the IRC meeting (15th Mar 2012)

Hi, Here's the summary of the previous IRC meeting / sprint. --- COMMUNITY MEETING Place: #openvpn-devel on irc.freenode.net List-Post: openvpn-devel@lists.sourceforge.net Date: Thursday 15th Mar 2012 Time: 18:00 UTC Planned meeting topics for this meeting were on this page:

[Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

Hi all, In yesterday's meeting we reviewed this patch PATCH 39/52 build: proper lzo detection and usage URL: http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5811 The patch was ACKed, but there was disagreement whether LZO should be enabled or disabled by default. Whichever the c

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

Hello, Part of the reasoning was discussed here[1]. If we do not want to do auto detection, enabling optional components may lead to configure failure, and force the user to explicitly disable this feature. It is possible, and I don't mind so much, however, I prefer configure to use the minimum

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

Sorry... [1] http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5947 2012/3/16 Alon Bar-Lev : > Hello, > > Part of the reasoning was discussed here[1]. > > If we do not want to do auto detection, enabling optional components > may lead to configure failure, and force the user to explic

Re: [Openvpn-devel] [PATCH 30/52] build: add libtool + windows resources for executables

Hi, This patch was ACKed in the IRC meeting on 15th Mar 2012: However some of the lines in "src/openvpn/openvpn_win32_resources.rc" may need to be fixed: VALUE "CompanyName", "OpenVPN.net" VALUE "LegalCopyright", "Copyright � OpenVPN Pr

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

On Fri, Mar 16, 2012 at 01:38:47PM +0200, Samuli Seppänen wrote: > Hi all, > > In yesterday's meeting we reviewed this patch > > PATCH 39/52 build: proper lzo detection and usage > URL: http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5811 > > The patch was ACKed, but there was di

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

Or: [1] http://permalink.gmane.org/gmane.network.openvpn.devel/5535 2012/3/16 Alon Bar-Lev : > Sorry... > [1] http://thread.gmane.org/gmane.network.openvpn.devel/5772/focus=5947 > > 2012/3/16 Alon Bar-Lev : >> Hello, >> >> Part of the reasoning was discussed here[1]. >> >> If we do not want to do

Re: [Openvpn-devel] [PATCH 30/52] build: add libtool + windows resources for executables

I left the OpenVPN.net not to cause copyright discussion :) But here we are... "The OpenVPN Project" is good for me. 2012/3/16 Samuli Seppänen : > Hi, > > This patch was ACKed in the IRC meeting on 15th Mar 2012: > > > > However some of th

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

On Fri, Mar 16, 2012 at 1:47 PM, Alberto Gonzalez Iniesta wrote: > Since support for LZO is enabled/disabled in runtime configuration, I > don't see why disabling it on built time, thus limiting its use later. We are talking about the build. Runtime is irrelevant. Alon

Re: [Openvpn-devel] [tap-windows 04/11] debug: add DbgPrint support

The vDbgPrintEx[1] sends a message to the Windows kernel debugger, if "DBG_PRINT" is defined. The va_start and va_end macros[2] fetch function's optional arguments. They only move the list pointer around, so va_start after va_end is safe. I don't see a problem with this and it sounds useful, so it

Re: [Openvpn-devel] [tap-windows 03/11] cleanup: remove warnings of redefinition of macros

ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev > --- > src/resource.rc |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/src/resource.rc b/src/resource.rc > index 84884cf..8b2d2f6 1007

Re: [Openvpn-devel] [tap-windows 05/11] build: set default to newer ddk

I think we can drop WinDDK <= 5600 support entirely. If I'm not mistaken, this means supporting Visual Studio 2008 and later only, which is fine. Afaik the only "reason" to support Visual Studio 2005 and older is Win2k support, which we don't need. OpenVPN 2.1.3 was the last version with Win2k supp

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 16/03/12 13:09, Alon Bar-Lev wrote: > On Fri, Mar 16, 2012 at 1:47 PM, Alberto Gonzalez Iniesta > wrote: >> Since support for LZO is enabled/disabled in runtime configuration, >> I don't see why disabling it on built time, thus limiting its use >>

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

On Fri, Mar 16, 2012 at 2:47 PM, David Sommerseth wrote: > The impact on this change mainly hits packagers on the Linux, *BSD and > Solaris packagers platforms - and those who do their own Windows builds. >  The official Windows builds we control and can make sure this feature is > enabled. Pleas

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

On Fri, Mar 16, 2012 at 02:09:44PM +0200, Alon Bar-Lev wrote: > On Fri, Mar 16, 2012 at 1:47 PM, Alberto Gonzalez Iniesta > wrote: > > Since support for LZO is enabled/disabled in runtime configuration, I > > don't see why disabling it on built time, thus limiting its use later. > > We are talkin

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

> On Fri, Mar 16, 2012 at 2:47 PM, David Sommerseth > wrote: >> The impact on this change mainly hits packagers on the Linux, *BSD and >> Solaris packagers platforms - and those who do their own Windows builds. >> The official Windows builds we control and can make sure this feature is >> enable

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

Hi, 2012/3/16 Alon Bar-Lev : > If we do not want to do auto detection, enabling optional components > may lead to configure failure, and force the user to explicitly > disable this feature. > > It is possible, and I don't mind so much, however, I prefer configure > to use the minimum absolutely ne

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

On Fri, Mar 16, 2012 at 3:29 PM, Fabian Knittel wrote: > In my opinion, the build defaults should reflect what the project > considers as the recommended defaults - the features we want to see in > every typical OpenVPN server and client. I strongly against that approach. This is a common mix up

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

Hi Alon, 2012/3/16 Alon Bar-Lev : > On Fri, Mar 16, 2012 at 3:29 PM, Fabian Knittel > wrote: >> In my opinion, the build defaults should reflect what the project >> considers as the recommended defaults - the features we want to see in >> every typical OpenVPN server and client. > > I strongly ag

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

Hi, On Fri, Mar 16, 2012 at 03:07:24PM +0200, Samuli Seppänen wrote: > Having as much stuff as possible disabled by default and then enabled > selectively _feels_ cleaner. But I'm fine with either approach. I think the default should be "what most people are using". - enable crypto and ssl - e

Re: [Openvpn-devel] New generic buildsystem: lzo enabled or disabled by default?

Hi, On Fri, Mar 16, 2012 at 02:29:22PM +0100, Fabian Knittel wrote: > In my opinion, the build defaults should reflect what the project > considers as the recommended defaults - the features we want to see in > every typical OpenVPN server and client. Fully seconded. gert -- USENET is *not* th

Re: [Openvpn-devel] [PATCH 35/52] build: proper selinux detection and usage

Hi Alon, sorry for digging up the dead, but our disagreements might have started earlier and just went unnoticed so far ... :) 2012/3/8 Alon Bar-Lev : > I wrote this in the introduction of the patch set. > > There are two approaches to detecting dependencies: > > 1. Detect all compile time depend

Re: [Openvpn-devel] [PATCH 35/52] build: proper selinux detection and usage

On Fri, Mar 16, 2012 at 5:25 PM, Fabian Knittel wrote: > Hi Alon, > > sorry for digging up the dead, but our disagreements might have > started earlier and just went unnoticed so far ... :) > > 2012/3/8 Alon Bar-Lev : >> I wrote this in the introduction of the patch set. >> >> There are two approa

Re: [Openvpn-devel] [PATCH 35/52] build: proper selinux detection and usage

Are you referring to the configure code? I might be missing something obvious, but AC_CHECK_LIB([selinux], [setcon], [SELINUX_LIBS="-lselinux"]) versus AC_CHECK_HEADER([selinux/selinux.h], [ AC_CHECK_LIB([selinux], [setcon], [SELINUX_LIBS="-lselinux"], [AC_MSG_RESULT([SELinux libr

Re: [Openvpn-devel] [PATCH 30/52] build: add libtool + windows resources for executables

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 16/03/12 13:02, Samuli Seppänen wrote: > Hi, > > This patch was ACKed in the IRC meeting on 15th Mar 2012: > > > > However some of the lines in "src/openvpn/openvpn_win32_resources.rc" >

Re: [Openvpn-devel] [PATCH 35/52] build: proper selinux detection and usage

Hi Alon, >> AC_CHECK_LIB([selinux], [setcon], [SELINUX_LIBS="-lselinux"]) >> >> versus >> >> AC_CHECK_HEADER([selinux/selinux.h], [ >>    AC_CHECK_LIB([selinux], [setcon], [SELINUX_LIBS="-lselinux"], >>        [AC_MSG_RESULT([SELinux library not found.])] >>    )],  [AC_MSG_ERROR([SELinux headers

Re: [Openvpn-devel] [PATCH 35/52] build: proper selinux detection and usage

On Fri, Mar 16, 2012 at 6:29 PM, Fabian Knittel wrote: > So it sounds as if we're actually somewhat in agreement! You don't > want complex, automatic detection of non-standard situations and I > agree wholeheartedly. > But I _do_ want basic checking to achieve clear error messages at > configurati

Re: [Openvpn-devel] [PATCH 00/35] build revolution

Hi everyone, Just to give an update, compilation on Alon's generic/ fails when it tries to compile openvpn with messages like: In file included from base64.c:40:0: syshead.h:345:22: fatal error: ntddndis.h: No such file or directory etc. ntddndis.h can be found in several places i.e. /usr/includ

Re: [Openvpn-devel] [PATCH 00/35] build revolution

Which toolchain do you use? It looks like you are trying to use an old toolchain... On Fri, Mar 16, 2012 at 6:51 PM, Athanasios Douitsis wrote: > Hi everyone, > > Just to give an update, compilation on Alon's generic/ fails when it tries > to compile openvpn with messages like: > > In file includ

Re: [Openvpn-devel] [PATCH 00/35] build revolution

I have installed cygwin just two days ago. And I issue: CHOST=i686-pc-mingw32 CBUILD=i686-pc-linux-gnu ./build On Fri, Mar 16, 2012 at 7:05 PM, Alon Bar-Lev wrote: > Which toolchain do you use? > It looks like you are trying to use an old toolchain... > > On Fri, Mar 16, 2012 at 6:51 PM, Atha

Re: [Openvpn-devel] [PATCH 00/35] build revolution

It should be: CHOST=i686-w64-mingw32 CBUILD=i686-pc-cygwin On Fri, Mar 16, 2012 at 7:25 PM, Athanasios Douitsis wrote: > I have installed cygwin just two days ago. And I issue: > > CHOST=i686-pc-mingw32 CBUILD=i686-pc-linux-gnu ./build > > > > > On Fri, Mar 16, 2012 at 7:05 PM, Alon Bar-Lev wro

Re: [Openvpn-devel] [PATCH 35/52] build: proper selinux detection and usage

However, from my experience it is not needed, people are most capable of manage this without creating noise. On the contrary, displaying meaningful error messages from configure is *never* a "noise". As Fabian pointed out - quite rightly - if make fails due to wrong/incorrect/missing depend

Re: [Openvpn-devel] [PATCH 00/35] build revolution

Checked again, and working. On Fri, Mar 16, 2012 at 7:43 PM, Alon Bar-Lev wrote: > It should be: > > CHOST=i686-w64-mingw32 CBUILD=i686-pc-cygwin > > On Fri, Mar 16, 2012 at 7:25 PM, Athanasios Douitsis > wrote: >> I have installed cygwin just two days ago. And I issue: >> >> CHOST=i686-pc-ming