Re: [ovs-dev] [RFC] [PATCH 0/6] Add port_group to prevent loopback between interfaces

On 21 April 2017 at 18:45, Ben Pfaff wrote: > On Mon, Apr 03, 2017 at 11:40:54AM +0200, Matthias May wrote: >> When using openvswitch in combination with a hardware switch attached via dsa >> it may be desirable to prevent frames from being looped back to interfaces >> which reside

Re: [ovs-dev] [PATCH v2 09/13] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

On Wed, May 3, 2017 at 6:43 PM, Mickey Spiegel wrote: > On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > >> Without this support, ovn-trace is not very useful with OpenStack, which >> uses connection tracking extensively. >> >> Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH] ovn-controller: Support vxlan tunnel in ovn

On Wed, May 3, 2017 at 10:17 PM, xurong00037997 wrote: > Because vxlan envelope have no enough fields to carry pipeline information > between ovs, so current ovn version do not support vxlan tunnel. > However, may only vxlan tunnel can be used in some special scenario. so we >

Re: [ovs-dev] ovsdb-idl: Need details/examples on one of the comment mentioned in ovsdb-idl.h

Thanks Ben. BTW, Got one more clarification: Say there is a client using ovsdb-idl for all transactions and reading data from ovsdb-server's db. Now the client has started a transaction I.e. txn_create and txn_insert(New row) for row-5 in table-1. But it hasn't committed the txn. Now if the

[ovs-dev] [PATCH] ovn-controller: Support vxlan tunnel in ovn

Because vxlan envelope have no enough fields to carry pipeline information between ovs, so current ovn version do not support vxlan tunnel. However, may only vxlan tunnel can be used in some special scenario. so we think it is necessary to implement the function of vxlan. For this purpose, we do

Re: [ovs-dev] [PATCH] fedora: do not restart ovn svcs automatically on pkg upgrade

On Tue, May 2, 2017 at 10:36 PM, Lance Richardson wrote: >> From: "Russell Bryant" >> To: "Lance Richardson" >> Cc: "ovs dev" >> Sent: Tuesday, 2 May, 2017 9:41:39 PM >> Subject: Re: [ovs-dev] [PATCH] fedora: do

[ovs-dev] [PATCH 2/2] Ovn tunnel encapsulation should consider both local and remote

--- ovn/controller/encaps.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/ovn/controller/encaps.c b/ovn/controller/encaps.c index f187a8f..5da7fbe 100644 --- a/ovn/controller/encaps.c +++ b/ovn/controller/encaps.c @@ -136,14 +136,14 @@ exit: } static

Re: [ovs-dev] [PATCH] datapath: backport: vxlan: correctly handle ipv6.disable module parameter

On Wed, May 3, 2017 at 11:10 AM, Joe Stringer wrote: > On 2 May 2017 at 16:08, Pravin B Shelar wrote: >> From: Jiri Benc >> >> upstream commit: >> commit d074bf9600443403aa24fbc12c1f18eadc90f5aa >> Author: Jiri Benc >>

[ovs-dev] [PATCH] datapath: backport: vxlan: do not output confusing error message

From: Jiri Benc Upstream commit: commit baf4d7860771287f30fbe9b6b2dc18b04361439d Author: Jiri Benc Date: Thu Apr 27 21:24:36 2017 +0200 vxlan: do not output confusing error message The message "Cannot bind port X, err=Y" creates only

Re: [ovs-dev] [PATCH v2 09/13] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > Without this support, ovn-trace is not very useful with OpenStack, which > uses connection tracking extensively. > > Signed-off-by: Ben Pfaff > Acked-by: Mickey Spiegel A couple of minor

Re: [ovs-dev] [PATCH branch-2.7] docs: Add dpdk stable release to DPDK install docs.

Ian This patch does not apply to 2.7; could you respin ? Thanks Darrell On 2/16/17, 11:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ian Stokes" wrote: DPDK now provides a stable release branch. Modify install docs

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 11 April 2017 at 03:14, Sugesh Chandran wrote: > Openvswitch datapath recirculates packets for tunneling, i.e. > the incoming packets are encapsulated at first pass. Further actions are > applied on encapsulated packets on the second pass after recirculating. > The

Re: [ovs-dev] [PATCH 1/1] dpif-netdev: The pmd-*-show commands will show info in core order

On Tue, Apr 25, 2017 at 05:12:49PM +0200, Eelco Chaudron wrote: > On 15/04/17 06:33, Ben Pfaff wrote: > >On Wed, Mar 22, 2017 at 11:10:23AM +0100, Eelco Chaudron wrote: > >>The "ovs-appctl dpif-netdev/pmd-rxq-show" and "ovs-appctl > >>dpif-netdev/pmd-stats-show" commands show their output per

Re: [ovs-dev] [PATCH v4 2/7] userspace: Support for push_eth and pop_eth actions

On Tue, Apr 25, 2017 at 04:30:23PM +, Zoltán Balogh wrote: > From: Jan Scheurich > > Add support for actions push_eth and pop_eth to the netdev datapath and > the supporting libraries. This patch relies on the support for these actions > in the kernel datapath to

Re: [ovs-dev] [PATCH v4 1/7] userspace: Add packet_type in dp_packet and flow

On Tue, Apr 25, 2017 at 04:29:59PM +, Zoltán Balogh wrote: > From: Jan Scheurich > > This commit adds a packet_type attribute to the structs dp_packet and flow > to explicitly carry the type of the packet as prepration for the > introduction of the so-called

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

On Wed, May 03, 2017 at 07:42:46PM -0400, Russell Bryant wrote: > On Wed, May 3, 2017 at 11:45 AM, Ben Pfaff wrote: > > It's much easier to see what's going on in the southbound database if > > human-friendly names are available. > > > > Really it's too bad that we didn't put the

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

On Wed, May 3, 2017 at 11:45 AM, Ben Pfaff wrote: > It's much easier to see what's going on in the southbound database if > human-friendly names are available. > > Really it's too bad that we didn't put the human-friendly name in "name" > and the UUID in something like

Re: [ovs-dev] [PATCH v2 08/13] ovn-trace: Fix message style in VLOG_WARN call.

On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > \n in a vlog call is not needed and our convention is to not include it. > > This change does not change visible behavior in any way. > > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou

Re: [ovs-dev] [PATCH v2 07/13] ovn-sbctl: Display and accept friendly logical port and datapath names.

On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 06/13] ovn-sbctl: Add --ovs option to "lflow-list", for listing OpenFlow flows.

On Wed, May 03, 2017 at 03:59:52PM -0700, Andy Zhou wrote: > On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > > This is like the --ovs option to ovn-trace, but it applies to every flow > > dumped, so it has different applications. > > > > Signed-off-by: Ben Pfaff >

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

On Wed, May 03, 2017 at 02:59:15PM -0700, Andy Zhou wrote: > On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > > It's much easier to see what's going on in the southbound database if > > human-friendly names are available. > > > > Really it's too bad that we didn't put the

Re: [ovs-dev] [PATCH] datapath: Remove untracked CT on newer kernels.

On 3 May 2017 at 13:25, Greg Rose wrote: > On Wed, May 3, 2017 at 11:53 AM, Joe Stringer wrote: >> Upstream commits cc41c84b7e7f ("netfilter: kill the fake untracked >> conntrack objects") and ab8bc7ed864b ("netfilter: remove >> nf_ct_is_untracked") removed

Re: [ovs-dev] [PATCH v2 06/13] ovn-sbctl: Add --ovs option to "lflow-list", for listing OpenFlow flows.

On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > This is like the --ovs option to ovn-trace, but it applies to every flow > dumped, so it has different applications. > > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou

Re: [ovs-dev] [PATCH v2 05/13] ovn-sbctl: Get rid of redundant code by using function from db-ctl-base.

On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > This renames get_row() to ctl_get_row() and makes it public. It's > unfortunate that it adds a cast, but getting rid of redundant code seems > worth it to me. > > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou

Re: [ovs-dev] [PATCH v2 04/13] ovn-sbctl: Allow database commands to refer to datapaths by name.

On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > Until now, only the lflow-list command supported using UUIDs or names > for datapaths. This commit extends that support to all the database > commands, as well as adding support for matching "logical-switch" or > "logical-router"

Re: [ovs-dev] [PATCH v2 03/13] ovn-northd: Keep external-ids up-to-date in Datapath_Binding.

On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > Without this, ovn-northd sets external-ids properly when it creates a > Datapath_Binding record, but failed to update the external-ids if they > should have changed. > > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou

Re: [ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > It's much easier to see what's going on in the southbound database if > human-friendly names are available. > > Really it's too bad that we didn't put the human-friendly name in "name" > and the UUID in something like

Re: [ovs-dev] [PATCH] ovs-atomic: Report error for contradictory configuration.

On Wed, May 03, 2017 at 01:39:46PM -0700, Joe Stringer wrote: > On 3 May 2017 at 11:05, Ben Pfaff wrote: > > A user reported that GCC 5.x was using the atomic fallback for GCC 4.x > > because the test > > #elif __GNUC__ >= 4 && __GNUC_MINOR__ >= 7 > > didn't include GCC 5.

Re: [ovs-dev] [PATCH v2 01/13] ovn-northd: Propagate Neutron port names to southbound database.

On Wed, May 3, 2017 at 8:45 AM, Ben Pfaff wrote: > This makes it possible for southbound utilities to use friendlier names, > which will happen in upcoming commits. > > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou

[ovs-dev] [PATCH 3/3] OVN localport type support

From: Daniel Alvarez This patch introduces a new type of OVN ports called "localport". These ports will be present in every hypervisor and may have the same IP/MAC addresses. They are not bound to any chassis and traffic to these ports will never go through a tunnel. Its

[ovs-dev] [PATCH 2/3] physical: Simplify updating localvif_to_ofport map in physical_run().

These two loops were updating 'localvif_to_ports' to be the same as 'new_localvif_to_ports' and setting physical_map_changed if there had been any differences. This is more work than necessary, so this commit simplifies it. Signed-off-by: Ben Pfaff --- ovn/controller/physical.c |

[ovs-dev] [PATCH 1/3] simap: New function simap_equal().

This will acquire a user in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/simap.c | 21 - lib/simap.h | 4 +++- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/lib/simap.c b/lib/simap.c index 9c30f6886b2f..157819ea3970 100644 ---

Re: [ovs-dev] [PATCH] Windows: Secure the namedpipe implementation

Hi Ben, Thanks for taking the time to review this. I will address the coding style changes along with other potential comments in the next version. Thanks, Sairam On 5/3/17, 1:05 PM, "Ben Pfaff" wrote: >On Wed, May 03, 2017 at 12:22:48PM -0700, Sairam Venugopal wrote: >>

Re: [ovs-dev] [PATCH] tests/ofproto.at: Workaround some races

On Thu, Apr 27, 2017 at 05:24:22PM +0200, Timothy Redaelli wrote: > Port commit a6d1a2997db4: > ofproto.at: Workaround a race > > While a barrier serializes requests from the same connection, > it doesn't wait for requests from other connections to the switch. > Replace the

Re: [ovs-dev] [PATCH] datapath: Remove untracked CT on newer kernels.

On Wed, May 3, 2017 at 11:53 AM, Joe Stringer wrote: > Upstream commits cc41c84b7e7f ("netfilter: kill the fake untracked > conntrack objects") and ab8bc7ed864b ("netfilter: remove > nf_ct_is_untracked") removed the 'untracked' conntrack objects and > functions. The latter commit

Re: [ovs-dev] [v2] vswitchd: Add --cleanup option to the 'appctl exit' command

On Fri, Apr 28, 2017 at 5:00 PM, Jarno Rajahalme wrote: > Some types noted below, otherwise: > > Acked-by: Jarno Rajahalme Thanks Jarno for the review. Pushed to master with fixes suggested. Will backport to branch 2.7 soon.

Re: [ovs-dev] [PATCH] Windows: Secure the namedpipe implementation

On Wed, May 03, 2017 at 12:22:48PM -0700, Sairam Venugopal wrote: > Update the security policies around the creation of the namedpipe. The > current security updates restrict how the namedpipe can be accessed. > > - Disable Network access > - Windows Services can access the namedpipe > -

Re: [ovs-dev] [PATCH v4] netdev-dpdk: leverage the mempool offload support

Thanks everyone! I applied this to master. On Fri, Apr 14, 2017 at 10:36:54PM +, Darrell Ball wrote: > Acked-by: Darrell Ball > > On 4/12/17, 10:31 PM, "Hemant Agrawal" wrote: > > DPDK 16.07 introduced the support for mempool offload support.

Re: [ovs-dev] [PATCH] netdev-dpdk: Enable INDIRECT_DESC on DPDK vHostUser.

Applied to master, thanks! On Fri, Apr 14, 2017 at 10:14:19PM +, Darrell Ball wrote: > Acked-by: Darrell Ball > > On 4/10/17, 4:21 AM, "Kevin Traynor" wrote: > > On 04/10/2017 08:03 AM, Darrell Ball wrote: > > > > > > On 4/5/17,

Re: [ovs-dev] [PATCH V2] netdev-dpdk: fix mempool_configure error state

Done. On Wed, May 03, 2017 at 06:47:09PM +, Darrell Ball wrote: > Please apply to 2.6 and 2.7 > > Thanks Darrell > > On 5/3/17, 11:36 AM, "Ben Pfaff" wrote: > > Thanks everyone, I applied this to master. > > Let me know if this should be applied to older

[ovs-dev] [PATCH] Windows: Secure the namedpipe implementation

Update the security policies around the creation of the namedpipe. The current security updates restrict how the namedpipe can be accessed. - Disable Network access - Windows Services can access the namedpipe - Administrators can access the namedpipe Signed-off-by: Sairam Venugopal

[ovs-dev] [PATCH] datapath: Remove untracked CT on newer kernels.

Upstream commits cc41c84b7e7f ("netfilter: kill the fake untracked conntrack objects") and ab8bc7ed864b ("netfilter: remove nf_ct_is_untracked") removed the 'untracked' conntrack objects and functions. The latter commit removes the usage of nf_ct_is_untracked() from OVS. However, older kernels

Re: [ovs-dev] [PATCH V2] netdev-dpdk: fix mempool_configure error state

Please apply to 2.6 and 2.7 Thanks Darrell On 5/3/17, 11:36 AM, "Ben Pfaff" wrote: Thanks everyone, I applied this to master. Let me know if this should be applied to older branches. On Wed, May 03, 2017 at 02:00:31AM +, Darrell Ball wrote: >

Re: [ovs-dev] [PATCH V2] netdev-dpdk: fix mempool_configure error state

Thanks everyone, I applied this to master. Let me know if this should be applied to older branches. On Wed, May 03, 2017 at 02:00:31AM +, Darrell Ball wrote: > Acked-by: Darrell Ball > > On 3/13/17, 4:46 AM, "ovs-dev-boun...@openvswitch.org on behalf of Stokes, > Ian"

Re: [ovs-dev] [PATCH] datapath: backport: vxlan: correctly handle ipv6.disable module parameter

On 2 May 2017 at 16:08, Pravin B Shelar wrote: > From: Jiri Benc > > upstream commit: > commit d074bf9600443403aa24fbc12c1f18eadc90f5aa > Author: Jiri Benc > Date: Thu Apr 27 21:24:35 2017 +0200 > > vxlan: correctly handle

[ovs-dev] [PATCH] ovs-atomic: Report error for contradictory configuration.

A user reported that GCC 5.x was using the atomic fallback for GCC 4.x because the test #elif __GNUC__ >= 4 && __GNUC_MINOR__ >= 7 didn't include GCC 5. However, GCC 5+ has and shouldn't use any of the GCC-specific cases at all. I think that this user was actually pulling our atomics out

Re: [ovs-dev] [PATCH] tests: Only run python SSL test if SSL support is configured

On Wed, May 03, 2017 at 05:55:51PM +0200, Simon Horman wrote: > Only run python SSL test, which invokes ovsdb with a --remote=pssl, > if SSL support is configured. > > Without this change the following error appears when running > the test-suite when OVS is configured with --disable-ssl. > >

Re: [ovs-dev] [PATCH v4 0/5] Backport upstream mpls fix

On 3 May 2017 at 08:50, Simon Horman wrote: > On Tue, May 02, 2017 at 10:38:17AM -0700, Joe Stringer wrote: >> On 2 May 2017 at 05:03, Simon Horman wrote: >> > On Mon, May 01, 2017 at 10:24:30AM -0700, Yi-Hung Wei wrote: >> >> This series

Re: [ovs-dev] [PATCH 0/5 v2] DPDK multi-segment mbuf support

Thanks, Michael 在 2017年5月3日，下午11:28，Kavanagh, Mark B 写道： >> >> Currently, OVS only support DPDK single segment mbuf, >> it could lead problems, like a large non-DPDK source >> packet transmit to dpdk port. >> >> Also, OVS doesn't copy enough info in mbuf when do

Re: [ovs-dev] [PATCH 4/5] lib/dp-packet: copy multi-segments data from DPDK mbuf

在 2017年5月3日，下午11:37，Kavanagh, Mark B 写道： >> >> From: Michael Qiu >> >> When doing packet clone, if packet source is from DPDK driver, >> multi-segment must be considered, and copy the segment's >> data one by one. >> >> Signed-off-by: Michael

Re: [ovs-dev] [PATCH 2/5] lib/dp-packet: copy additional packet info when do packet copy

在 2017年5月3日，下午11:32，Kavanagh, Mark B 写道： >> >> From: Michael Qiu >> >> Currently, when doing packet copy, lots of DPDK mbuf's info >> will be missed, like packet type, ol_flags, etc. >> Those information is very important for DPDK to do >>

Re: [ovs-dev] [PATCH] ovn-controller: Disable probes by default for unix sockets.

On Tue, May 02, 2017 at 01:22:35PM -0700, Han Zhou wrote: > Normally the OVS JSON-RPC library does not probe idle connections across > Unix domain sockets, since the kernel can tell OVS whether the connections > are truly connected without probes, but ovn-controller carelessly > overrode that. >

Re: [ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

在 2017年5月3日，下午11:33，Kavanagh, Mark B 写道： >> From: Michael Qiu >> >> When a packet is from DPDK source, and it contains >> multiple segments, data_len is not equal to the >> packet size. This patch fix this issue. >> >> Signed-off-by: Michael Qiu

Re: [ovs-dev] [PATCH ovs V8 00/26] Introducing HW offload support for openvswitch

On Wed, May 3, 2017 at 5:07 PM, Roi Dayan wrote: > This patch series introduces rule offload functionality to dpif-netlink > via netdev ports new flow offloading API. The user can specify whether to > enable rule offloading or not via OVS configuration. Netdev providers > are

[ovs-dev] [PATCH] tests: Only run python SSL test if SSL support is configured

Only run python SSL test, which invokes ovsdb with a --remote=pssl, if SSL support is configured. Without this change the following error appears when running the test-suite when OVS is configured with --disable-ssl. +ovsdb-server: Private key specified but Open vSwitch was built without SSL

[ovs-dev] [PATCH ovs V8 26/26] dpif-netlink: Use dpif logging functions

Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/dpif-netlink.c | 55 +- 1 file changed, 17 insertions(+), 38 deletions(-) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index

[ovs-dev] [PATCH ovs V8 25/26] dpif: Refactor flow logging functions to be used by other modules

Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/dpif.c | 87 +++--- lib/dpif.h | 28 2 files changed, 72 insertions(+), 43 deletions(-) diff --git a/lib/dpif.c

[ovs-dev] [PATCH ovs V8 24/26] netdev: Init flow api on already added ports on offload enable

From: Paul Blakey Ports already added to a switch are not being initialized for offloading so when enabling offload we need to go over those ports. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman

Re: [ovs-dev] [PATCH v4 0/5] Backport upstream mpls fix

On Tue, May 02, 2017 at 10:38:17AM -0700, Joe Stringer wrote: > On 2 May 2017 at 05:03, Simon Horman wrote: > > On Mon, May 01, 2017 at 10:24:30AM -0700, Yi-Hung Wei wrote: > >> This series backports the upstream mpls fixes and add a system traffic > >> test for mpls

Re: [ovs-dev] [PATCH v4 7/7] checkpatch: fix pointer declaration

On Wed, May 03, 2017 at 11:25:03AM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Tue, May 02, 2017 at 12:24:53PM -0400, Aaron Conole wrote: > >> Ben Pfaff writes: > >> > >> > On Mon, May 01, 2017 at 04:39:30PM -0400, Aaron Conole wrote: > >> >> Ben Pfaff

[ovs-dev] [PATCH v2 13/13] Documentation: Add an OVN tutorial for OpenStack.

Signed-off-by: Ben Pfaff --- Documentation/automake.mk |1 + Documentation/tutorials/index.rst |1 + Documentation/tutorials/ovn-openstack.rst | 1922 + 3 files changed, 1924 insertions(+) create mode 100644

[ovs-dev] [PATCH v2 12/13] ovn-trace: Display friendlier port and datapath names.

This makes ovn-trace use short name instead of UUIDs (etc.) in its own output, by default. Since it's possible that there's software out there parsing ovn-trace output, it also adds a --no-friendly-names option. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-trace.8.xml | 15

[ovs-dev] [PATCH v2 11/13] ovn-trace: Accept human-friendly logical port and datapath names.

This allows the user to specify these names in a natural way, e.g. "ovn-trace myswitch 'inport == "myport"' instead of having to specify whatever UUID or other horrible name the CMS invented. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-trace.c | 18 +- 1 file

[ovs-dev] [PATCH v2 10/13] ovn-trace: Add support for partial UUID matches for ports and datapaths.

This makes ovn-trace commands easier to type. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-trace.c | 44 1 file changed, 36 insertions(+), 8 deletions(-) diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c index

[ovs-dev] [PATCH v2 09/13] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

Without this support, ovn-trace is not very useful with OpenStack, which uses connection tracking extensively. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-trace.8.xml | 50 + ovn/utilities/ovn-trace.c | 52

[ovs-dev] [PATCH v2 08/13] ovn-trace: Fix message style in VLOG_WARN call.

\n in a vlog call is not needed and our convention is to not include it. This change does not change visible behavior in any way. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-trace.c

[ovs-dev] [PATCH v2 07/13] ovn-sbctl: Display and accept friendly logical port and datapath names.

Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-sbctl.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index 97354df2da94..0142062fd13f 100644 --- a/ovn/utilities/ovn-sbctl.c +++

[ovs-dev] [PATCH v2 06/13] ovn-sbctl: Add --ovs option to "lflow-list", for listing OpenFlow flows.

This is like the --ovs option to ovn-trace, but it applies to every flow dumped, so it has different applications. Signed-off-by: Ben Pfaff --- NEWS| 2 + include/openvswitch/ofp-print.h | 4 +- lib/db-ctl-base.c | 19 -

[ovs-dev] [PATCH v2 04/13] ovn-sbctl: Allow database commands to refer to datapaths by name.

Until now, only the lflow-list command supported using UUIDs or names for datapaths. This commit extends that support to all the database commands, as well as adding support for matching "logical-switch" or "logical-router" in addition to "name". Signed-off-by: Ben Pfaff ---

[ovs-dev] [PATCH v2 02/13] ovn-northd: Propagate Neutron datapath names to southbound database.

It's much easier to see what's going on in the southbound database if human-friendly names are available. Really it's too bad that we didn't put the human-friendly name in "name" and the UUID in something like "external_ids:neutron-uuid", but it'll take more coordination to change that at this

[ovs-dev] [PATCH v2 01/13] ovn-northd: Propagate Neutron port names to southbound database.

This makes it possible for southbound utilities to use friendlier names, which will happen in upcoming commits. Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 13 + ovn/ovn-nb.xml | 16 ovn/ovn-sb.ovsschema| 10 +++---

Re: [ovs-dev] [PATCH 23/27] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

On Tue, May 02, 2017 at 11:33:27AM -0700, Mickey Spiegel wrote: > One minor nit and one real comment below. > > On Tue, May 2, 2017 at 11:07 AM, Ben Pfaff wrote: > > > On Mon, May 01, 2017 at 05:50:57PM -0700, Mickey Spiegel wrote: > > > On Mon, May 1, 2017 at 5:12 PM, Ben Pfaff

[ovs-dev] [PATCH v2 00/13] Add OVN tutorial for OpenStack

This is what I'm planning to present at OpenStack Boston. The tutorial itself is pretty simple; I spent most of the time working on it either trying to figure how to do things in OpenStack or figuring out ways to improve the OVN utilities that make them easier to use in an OpenStack environment.

Re: [ovs-dev] [PATCH 5/5] lib/netdev-dpdk: copy large packet to multi-segment mbufs

> >From: Michael Qiu > >Currently, one packet is only copied to one segment >in function dpdk_do_tx_copy(), this could be an issue >when a jumbo frame comes, especially for multiple segments. > >This patch calculate the segment number needed by the packet and >copy the data

Re: [ovs-dev] [PATCH 4/5] lib/dp-packet: copy multi-segments data from DPDK mbuf

> >From: Michael Qiu > >When doing packet clone, if packet source is from DPDK driver, >multi-segment must be considered, and copy the segment's >data one by one. > >Signed-off-by: Michael Qiu >--- > lib/dp-packet.c | 27 --- > 1

Re: [ovs-dev] [PATCH 14/27] ovn-nbctl: Allow access to DHCP options via logical switch port name.

On Wed, May 03, 2017 at 01:00:57AM -0700, Andy Zhou wrote: > On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > > After this, if port "myvif" has DHCPv4 or DHCPv6 options, you can use > > "ovn-nbctl list dhcp myvif" to see them. > > > > Signed-off-by: Ben Pfaff >

Re: [ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

>From: Michael Qiu > >When a packet is from DPDK source, and it contains >multiple segments, data_len is not equal to the >packet size. This patch fix this issue. > >Signed-off-by: Michael Qiu >Signed-off-by: Marcin Ksiadz

Re: [ovs-dev] [PATCH 2/5] lib/dp-packet: copy additional packet info when do packet copy

> >From: Michael Qiu > >Currently, when doing packet copy, lots of DPDK mbuf's info >will be missed, like packet type, ol_flags, etc. >Those information is very important for DPDK to do >packets processing. > >Signed-off-by: Michael Qiu >--- >

Re: [ovs-dev] [PATCH 13/27] ovn-nbctl: Display and accept Neutron port names.

On Wed, May 03, 2017 at 12:56:53AM -0700, Andy Zhou wrote: > On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > > These are slightly less useful in practice than switch or router names > > because Neutron doesn't by default give names to ports. (You can add > > them with

Re: [ovs-dev] [PATCH 0/5 v2] DPDK multi-segment mbuf support

> >Currently, OVS only support DPDK single segment mbuf, >it could lead problems, like a large non-DPDK source >packet transmit to dpdk port. > >Also, OVS doesn't copy enough info in mbuf when do >packet copy. > >At the same time, vlan and tunnelling packet's DPDK >offloads, for example TSO, needs

Re: [ovs-dev] [PATCH 05/27] ovn-sbctl, ovn-nbctl, ovs-vsctl: Remove useless record id methods.

On Tue, May 02, 2017 at 04:34:44PM -0400, Russell Bryant wrote: > On Tue, May 2, 2017 at 4:30 PM, Russell Bryant wrote: > > On Sun, Apr 30, 2017 at 7:22 PM, Ben Pfaff wrote: > >> These only did anything if both the first two members of the struct were > >> nonnull,

[ovs-dev] [PATCH ovs V8 23/26] compat: Add tc compatibility headers for old kernels

From: Paul Blakey Added compatibility headers for actions vlan and tunnel key. Do not use compat code when compiling kernel datapath there is no need for it as TC compatibility is not provided there. In other words, the compat code is only used when compiling user-space code

[ovs-dev] [PATCH ovs V8 19/26] netdev-vport: Use common offloads interface

From: Paul Blakey netdev vports are backed by actualy netdev at the kernel level, so they can use the common netdev-tc offloads interface for flow offloading (if enabled). Signed-off-by: Paul Blakey Signed-off-by: Simon Horman

[ovs-dev] [PATCH ovs V8 22/26] tests: Add system-offloads-testsuite

From: Paul Blakey The new system-offloads-testsuite, which can be launched via `make check-offloads`, tests offloading capabilities to makes sure that certian flows are actually offloaded. The tests run on virtual netdevices (VETH). Signed-off-by: Paul Blakey

[ovs-dev] [PATCH ovs V8 21/26] dpctl: Add an option to dump only certain kinds of flows

From: Paul Blakey Usage: # to dump all datapath flows (default): ovs-dpctl dump-flows # to dump only flows that in kernel datapath: ovs-dpctl dump-flows type=ovs # to dump only flows that are offloaded: ovs-dpctl dump-flows type=offloaded

[ovs-dev] [PATCH ovs V8 16/26] dpif-netlink: Use netdev flow get api to query a flow

From: Paul Blakey Search all datapath added netdevs for a given flow using netdev flow api and parse it back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ---

[ovs-dev] [PATCH ovs V8 20/26] netdev-tc-offloads: Add ingress on netdev flow api init

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH ovs V8 17/26] netdev-tc-offloads: Implement flow get using tc interface

From: Paul Blakey Search the requested ufid for a offloaded flow, and if found, dump and parse it back to required format. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ---

[ovs-dev] [PATCH ovs V8 18/26] netdev-linux: Disallow setting policing when configured with hw offload

From: Paul Blakey Notify as not supported. Otherwise the ingress qdisc is being removed and offload rules will be removed. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ---

[ovs-dev] [PATCH ovs V8 14/26] dpif-netlink: Use netdev flow del api to delete a flow

From: Paul Blakey If a flow was offloaded to a netdev we delete it using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 12

[ovs-dev] [PATCH ovs V8 15/26] netdev-tc-offloads: Implement netdev flow del using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 33 ++--- 1 file changed, 30 insertions(+), 3

[ovs-dev] [PATCH ovs V8 12/26] netdev-tc-offloads: Add flower mask to priority map

From: Paul Blakey Flower classifer requires a different priority per mask, so we hash the mask and generate a new priority for each new mask used. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman

[ovs-dev] [PATCH ovs V8 10/26] netdev-tc-offloads: Implement netdev flow dump api using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 182 --- 1 file changed, 174

[ovs-dev] [PATCH ovs V8 11/26] dpif-netlink: Use netdev flow put api to insert a flow

From: Paul Blakey Using the new netdev flow api operate will now try and offload flows to the relevant netdev of the input port. Other operate methods flows will come in later patches. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan

[ovs-dev] [PATCH ovs V8 06/26] dpif-netlink: Flush added ports using netdev flow api

From: Paul Blakey If netdev flow offloading is enabled, flush all added ports using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 5

[ovs-dev] [PATCH ovs V8 08/26] dpif-netlink: Dump netdevs flows on flow dump

From: Paul Blakey While dumping flows, dump flows that were offloaded to netdev and parse them back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ---

[ovs-dev] [PATCH ovs V8 09/26] netdev-tc-offloads: Add ufid to tc/netdev map

From: Paul Blakey Flows offloaded to tc are identified by priority and handle pair while OVS flows are identified by ufid. Added a hash map to convert between the two for later retrieval and deleting of offloaded flows. Signed-off-by: Paul Blakey

[ovs-dev] [PATCH ovs V8 07/26] netdev-tc-offloads: Implement netdev flow flush using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH ovs V8 05/26] dpif: Save added ports in a port map for netdev flow api use

From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to translate dpif ports to netdevs. Signed-off-by: Paul Blakey Reviewed-by:

[ovs-dev] [PATCH ovs V8 04/26] other-config: Add tc-policy switch to control tc flower flag

From: Paul Blakey Add a new configuration tc-policy option that controls tc flower flag. Possible options are none, skip_sw, skip_hw. The default is none which is to insert the rule both to sw and hw. This option is only relevant if hw-offload is enabled. Signed-off-by: Paul

  1   2   >