Re: [ovs-dev] [PATCH] OVN: Add NEWS for Policy-based routing

2019-04-16 Thread Ben Pfaff
On Wed, Apr 17, 2019 at 02:05:30AM +, Mary Manohar wrote: > Signed-off-by: Mary Manohar Thanks! Applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/5 V2] datapath: meter: Use struct_size() in kzalloc()

2019-04-16 Thread Ben Pfaff
On Tue, Apr 16, 2019 at 04:58:55PM -0700, Gregory Rose wrote: > > On 4/16/2019 4:56 PM, Gregory Rose wrote: > > > > > > On 4/16/2019 2:04 PM, Ben Pfaff wrote: > > > On Wed, Mar 27, 2019 at 10:14:00AM -0700, Greg Rose wrote: > > > > From: "Gustavo A. R. Silva" > > > > > > > > Upstream commit:

Re: [ovs-dev] OVN: Add NEWS for Policy-based routing

2019-04-16 Thread 0-day Robot
Bleep bloop. Greetings Mary Manohar, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Mary Manohar needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [ovs-dev, v3, 2/3] OVN ACL: Allow ct_mark and ct_label values to be set from register as well

2019-04-16 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #128 FILE:

Re: [ovs-dev] [ovs-dev, v3, 1/3] OVN ACL: Replace the usage of ct_label with ct_mark

2019-04-16 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 141 characters long (recommended limit is 79) #33 FILE:

[ovs-dev] [PATCH] OVN: Add NEWS for Policy-based routing

2019-04-16 Thread Mary Manohar
Signed-off-by: Mary Manohar --- NEWS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS b/NEWS index 5a215b2..f3233d2 100644 --- a/NEWS +++ b/NEWS @@ -26,6 +26,9 @@ Post-v2.11.0 * Select IPAM mac_prefix in a random manner if not provided by the user * Added the HA chassis

Re: [ovs-dev] [ovs-dev, v3, 3/4] L3 N-S support in ovn, do not replace router port mac on gateway chassis

2019-04-16 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #66 FILE:

Re: [ovs-dev] [ovs-dev, v3, 2/4] L3 N-S support in ovn, advertise router port mac from gateway chassis

2019-04-16 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: C99 style comment #57 FILE: ovn/controller/pinctrl.c:224: #define

Re: [ovs-dev] [ovs-dev, v3, 1/4] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-04-16 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: C99 style comment #196 FILE: ovn/controller/chassis.c:343: // Return the

Re: [ovs-dev] [PATCH 1/5 V2] datapath: meter: Use struct_size() in kzalloc()

2019-04-16 Thread Gregory Rose
On 4/16/2019 4:56 PM, Gregory Rose wrote: On 4/16/2019 2:04 PM, Ben Pfaff wrote: On Wed, Mar 27, 2019 at 10:14:00AM -0700, Greg Rose wrote: From: "Gustavo A. R. Silva" Upstream commit: commit c5c3899de09e307e3a0999ab8d620ab0ede05aa1 Author: Gustavo A. R. Silva Date:   Tue

[ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-04-16 Thread Ankur Sharma
This patch allows user to associate a value with acl, which will be assigned to ct.label of the corresponding connection tracking entry. This value can be used to map a ct entry with corresponding OVN ACL or higher level constructs like security group. Signed-off-by: Ankur Sharma ---

[ovs-dev] [PATCH v3 2/3] OVN ACL: Allow ct_mark and ct_label values to be set from register as well

2019-04-16 Thread Ankur Sharma
OVN allows only an integer (or masked integer) to be assigned to ct_mark and ct_label. This patch, enhances the parser code to allow ct_mark and ct_label to be assigned from 32 bit registers (MFF_REG0 - MFF_REG15) and 128 bit registers (MFF_XXREG0 - MFF_XXREG3) respectively. Signed-off-by:

[ovs-dev] [PATCH v3 0/3] Associate identifier with OVN ACL connection tracking entry

2019-04-16 Thread Ankur Sharma
What: a. Goal is to be able to associate some identifier with a connection tracking entry. b. This identifier can be used to map OVN ACL which added this entry or higher level constructs like openstack security group etc. c. There are 2 connection tracking fields which can be used for it.

[ovs-dev] [PATCH v3 1/3] OVN ACL: Replace the usage of ct_label with ct_mark

2019-04-16 Thread Ankur Sharma
OVN ACL implementation used ct_label to indicate if a previosuly allowed connection shoudl not be allowed anymore and vice versa. However, ct_label is a 128 bit value and we should rather leverage on ct_mark which is a 32 bit value. Using ct_mark for this purpose, allows us to use ct_label for

Re: [ovs-dev] [PATCH 1/5 V2] datapath: meter: Use struct_size() in kzalloc()

2019-04-16 Thread Gregory Rose
On 4/16/2019 2:04 PM, Ben Pfaff wrote: On Wed, Mar 27, 2019 at 10:14:00AM -0700, Greg Rose wrote: From: "Gustavo A. R. Silva" Upstream commit: commit c5c3899de09e307e3a0999ab8d620ab0ede05aa1 Author: Gustavo A. R. Silva Date: Tue Jan 15 15:19:17 2019 -0600

[ovs-dev] [PATCH v3 4/4] L3 N-S support in ovn, avoid chassis redirection as default for vlan backed networks

2019-04-16 Thread Ankur Sharma
Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical

[ovs-dev] [PATCH v3 3/4] L3 N-S support in ovn, do not replace router port mac on gateway chassis

2019-04-16 Thread Ankur Sharma
Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical

[ovs-dev] [PATCH v3 2/4] L3 N-S support in ovn, advertise router port mac from gateway chassis

2019-04-16 Thread Ankur Sharma
Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical

[ovs-dev] [PATCH v3 1/4] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-04-16 Thread Ankur Sharma
Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical

[ovs-dev] [PATCH v3 0/4] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-04-16 Thread Ankur Sharma
This series is about enhancing the logical router functionality in OVN to work with vlan backed logical switches. Intial proposal was discused here: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2]

Re: [ovs-dev] [RFC] Introduce "OpenFlow Controller as Shared Library"

2019-04-16 Thread Ben Pfaff
On Sun, Mar 24, 2019 at 09:54:02PM -0700, Ansis Atteka wrote: > From: Ansis Atteka > > Currently ovs-vswitchd process can communicate with an OpenFlow > controller only through tcp, unix and ssl sockets. > > This patch would allow ovs-vswitchd process to communicate > with an OpenFlow

Re: [ovs-dev] [PATCH] rhel ovn: Remove ovn-common rpm

2019-04-16 Thread Ben Pfaff
On Tue, Apr 16, 2019 at 02:31:53PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > ovn-fedora spec generates the rpms - ovn, ovn-common, ovn-host etc > in which ovn is an empty package. The ovn fedora spec file here [1] > has moved all the ovn-common files to the 'ovn' package. >

Re: [ovs-dev] [PATCH 1/3] sat-math: Add functions for saturating arithmetic on "long long int".

2019-04-16 Thread Ben Pfaff
This series still needs a review. It still applies cleanly and passes all the tests. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2.10 v2 0/2] Fix ovn-nbctl daemon table printing issues.

2019-04-16 Thread Ben Pfaff
On Tue, Feb 26, 2019 at 09:25:58AM -0500, Mark Michelson wrote: > This is a backport for a fix present in 2.11. ovn-kubernetes encounters > issues with the daemon mode of ovn-nbctl with 2.10. > > ovn-nbctl when run in daemon mode has two issues: > 1) An extra newline is prepended to table output

Re: [ovs-dev] [PATCH 0/2] netdev-linux: fix update via netlink

2019-04-16 Thread Ben Pfaff
On Tue, Mar 26, 2019 at 02:14:58PM -0300, Flavio Leitner wrote: > The first patch is actually an improvement to avoid reallocation. > > The second patch is a bug fix. > > More details in each patch. > > Those patches need to be applied on master, branch-2.11 and > branch-2.10. The same patches

Re: [ovs-dev] [PATCH v3] ovs-tcpdump: add dump_cmd checker before _doexec()

2019-04-16 Thread Ben Pfaff
On Fri, Mar 08, 2019 at 03:32:29PM +0800, txfh2007 via dev wrote: > Hi Aaron: > Thanks for your kinkdly suggession. I have tried your proposol and test > in my repository. This is the new version. > > Add dump_cmd executable checker in ovs-tcpdump > > Signed-off-by: Liu Chang

Re: [ovs-dev] [PATCH v1] ofp-monitor: Fixed the usage of 'usable_protocols' variable in 'parse_flow_monitor_request' function.

2019-04-16 Thread Ben Pfaff
On Fri, Mar 15, 2019 at 04:04:19PM -0700, Ashish Varma wrote: > 'usable_protocols' is now getting set to OFPUTIL_P_OF10_ANY on return from > 'parse_flow_monitor_request' function. The calling function now checks for the > value in this variable against the 'allowed_protocols' variable. > Also a

Re: [ovs-dev] [PATCH] stream-ssl: Add support for TLS SNI (Server Name Indication).

2019-04-16 Thread Ben Pfaff
Thanks! Applied to master. On Tue, Mar 26, 2019 at 02:03:53PM -0700, Yifeng Sun wrote: > Looks good to me, thanks. > > Tested-by: Yifeng Sun > Reviewed-by: Yifeng Sun > > On Wed, Mar 20, 2019 at 5:39 PM Ben Pfaff wrote: > > > > This TLS extension, introduced in RFC 3546, allows the server

Re: [ovs-dev] [PATCH 1/5 V2] datapath: meter: Use struct_size() in kzalloc()

2019-04-16 Thread Ben Pfaff
On Wed, Mar 27, 2019 at 10:14:00AM -0700, Greg Rose wrote: > From: "Gustavo A. R. Silva" > > Upstream commit: > commit c5c3899de09e307e3a0999ab8d620ab0ede05aa1 > Author: Gustavo A. R. Silva > Date: Tue Jan 15 15:19:17 2019 -0600 > > openvswitch: meter: Use struct_size() in

Re: [ovs-dev] [PATCHv2] rhel: if rpms were built without libcapng then let processrs to run as root

2019-04-16 Thread Ansis Atteka
On Tue, 16 Apr 2019 at 12:36, Ben Pfaff wrote: > > On Tue, Apr 16, 2019 at 12:27:59PM -0700, Ansis Atteka wrote: > > Otherwise, Open vSwitch will fail to start with the following > > error "libcap-ng is not configured at compile time" when it > > attempts to downgrade to Open vSwitch user. > > >

Re: [ovs-dev] [PATCH v2] faq: Add information about git-pw.

2019-04-16 Thread Ben Pfaff
On Thu, Mar 28, 2019 at 05:32:43PM +0100, David Marchand wrote: > On Thu, Mar 28, 2019 at 5:02 PM Kevin Traynor wrote: > > > git-pw is similar to pwclient but it can apply series directly. > > > > Signed-off-by: Kevin Traynor > > --- > > > > v2: fix block indent > > > >

Re: [ovs-dev] [PATCH v2] OVN: add the possibility to configure a static IPv4/IPv6 address and dynamic MAC

2019-04-16 Thread Ben Pfaff
On Fri, Mar 29, 2019 at 04:58:57PM +0100, Lorenzo Bianconi wrote: > Add the possibility to configure a static IPv4 and/or IPv6 address > and get MAC address dynamically allocated. This can be done using the > following commands: > > $ovn-nbctl ls-add sw0 > $ovn-nbctl set Logical-Switch sw0

Re: [ovs-dev] [dpdk-latest PATCH v1] dpdk: Update by new color definitions.

2019-04-16 Thread Ian Stokes
On 4/16/2019 9:46 PM, Ophir Munk wrote: Thanks Ian for accepting this. Please note a review comment from Asaf: Typo in commit message: Follwoing --> Following No problem, I had fixed that upon commit also. Thanks Ian Regards, Ophir -Original Message- From: Ian Stokes Sent:

Re: [ovs-dev] [dpdk-latest PATCH v1] dpdk: Update by new color definitions.

2019-04-16 Thread Ophir Munk
Thanks Ian for accepting this. Please note a review comment from Asaf: Typo in commit message: Follwoing --> Following Regards, Ophir > -Original Message- > From: Ian Stokes > Sent: Tuesday, April 16, 2019 4:00 PM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Olga Shern ; Kevin

Re: [ovs-dev] [patch v2] conntrack: Fix minimum connections to clean.

2019-04-16 Thread Ben Pfaff
On Fri, Mar 29, 2019 at 02:59:07PM -0700, Darrell Ball wrote: > If there is low maximum connection count configuration and less than 10 > connections in a bucket, the calculation of the maximum number of > connections to clean for the bucket could be zero, leading to these > connections not being

[ovs-dev] Hallo

2019-04-16 Thread mtn
Hallo, ANBEI IST DIE PROFITIEREN-BENACHRICHTIGUNG. Mit freundlichen Grüssen Mary Mkhululi ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rhel: Include all header files in the Fedora's devel package

2019-04-16 Thread Ben Pfaff
On Mon, Apr 01, 2019 at 09:26:31AM -0700, Ansis Atteka wrote: > From: Ansis Atteka > > While the header files added by this patch into Fedora's devel > rpm package can be considered private, the other devel packages > for RHEL/CentOS and Debian/Ubuntu distros include them. > > So this patch

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-16 Thread Ben Pfaff
On Mon, Apr 01, 2019 at 03:46:48PM -0700, William Tu wrote: > The patch series introduces AF_XDP support for OVS netdev. > AF_XDP is a new address family working together with eBPF. > In short, a socket with AF_XDP family can receive and send > packets from an eBPF/XDP program attached to the

Re: [ovs-dev] [PATCH] rhel: if rpms were built without libcapng then let processrs to run as root

2019-04-16 Thread Ansis Atteka
On Tue, 16 Apr 2019 at 12:36, Ansis Atteka wrote: > > On Tue, 16 Apr 2019 at 10:46, Aaron Conole wrote: > > > > Ansis Atteka writes: > > > > > Otherwise, Open vSwitch will fail to start with the following > > > error "libcap-ng is not configured at compile time" when it > > > attempts to

Re: [ovs-dev] [PATCH] rhel: if rpms were built without libcapng then let processrs to run as root

2019-04-16 Thread Ansis Atteka
On Tue, 16 Apr 2019 at 10:46, Aaron Conole wrote: > > Ansis Atteka writes: > > > Otherwise, Open vSwitch will fail to start with the following > > error "libcap-ng is not configured at compile time" when it > > attempts to downgrade to Open vSwitch user. > > > > Also, if packages were built in a

Re: [ovs-dev] [PATCHv2] rhel: if rpms were built without libcapng then let processrs to run as root

2019-04-16 Thread Ben Pfaff
On Tue, Apr 16, 2019 at 12:27:59PM -0700, Ansis Atteka wrote: > Otherwise, Open vSwitch will fail to start with the following > error "libcap-ng is not configured at compile time" when it > attempts to downgrade to Open vSwitch user. > > Also, if packages were built in a way where processes are >

[ovs-dev] UiPath B2B Contact List

2019-04-16 Thread Lori Wright
Hi, I was wondering if you are looking for below mentioned technologies. * Alteryx Analytics, Win shuttle, Pega Platform, Open Text MBPM, UFTpond and many more. We also provide tech intelligence where you can connect to the decision makers from the company using your competitor's product. Let

Re: [ovs-dev] [PATCH v4 2/2] chassis.c: Return chassis record whenever available in chassis_run().

2019-04-16 Thread Ben Pfaff
On Tue, Apr 16, 2019 at 11:42:04AM -0700, Han Zhou wrote: > From: Han Zhou > > The ovn-controller main loop relies on the return value of chassis_run(). > When ovnsb_idl_txn is NULL (i.e. there is a pending transaction for SB), > chasssis_run() returns NULL, which blocks functions to be executed

[ovs-dev] [PATCHv2] rhel: if rpms were built without libcapng then let processrs to run as root

2019-04-16 Thread Ansis Atteka
Otherwise, Open vSwitch will fail to start with the following error "libcap-ng is not configured at compile time" when it attempts to downgrade to Open vSwitch user. Also, if packages were built in a way where processes are supposed to be running only as root, then there is no point in creating

Re: [ovs-dev] [PATCH] datapath: Revert "datapath: Fix template leak in error cases."

2019-04-16 Thread Ben Pfaff
OK, I backported as far as 2.6. On 2.5, the original patch hadn't been applied, so there was nothing to revert. On Tue, Apr 16, 2019 at 11:12:11AM -0700, Yifeng Sun wrote: > The more appropriate patch (7664423) mentioned in the revert message > was introduced in ovs-2.5. > So I think this revert

Re: [ovs-dev] [PATCH v3 1/2] ovn-controller: Fix busy loop when sb disconnected.

2019-04-16 Thread Han Zhou
On Tue, Apr 16, 2019 at 10:43 AM Ben Pfaff wrote: > > On Wed, Apr 03, 2019 at 05:49:12PM -0700, Han Zhou wrote: > > From: Han Zhou > > > > In the main loop, if the SB DB is disconnected when there is a pending > > transaction, there can be busy loop causing 100% CPU of ovn-controller, > > until

[ovs-dev] [PATCH v4 2/2] chassis.c: Return chassis record whenever available in chassis_run().

2019-04-16 Thread Han Zhou
From: Han Zhou The ovn-controller main loop relies on the return value of chassis_run(). When ovnsb_idl_txn is NULL (i.e. there is a pending transaction for SB), chasssis_run() returns NULL, which blocks functions to be executed in the main loop unnecessarily. This patch updates chassis_run() so

[ovs-dev] [PATCH v4 1/2] ovn-controller: Fix busy loop when sb disconnected.

2019-04-16 Thread Han Zhou
From: Han Zhou In the main loop, if the SB DB is disconnected when there is a pending transaction, there can be busy loop causing 100% CPU of ovn-controller, until SB DB is connected again. The root cause is that when a transaction is pending, ovsdb_idl_loop_run() will return NULL for

Re: [ovs-dev] [PATCHv2] datapath: Add support for kernel 4.19.x and 4.20.x

2019-04-16 Thread Yifeng Sun
Thanks Yi-Hung! I will look at it and come up with a new version. Yifeng On Mon, Apr 15, 2019 at 5:39 PM Yi-Hung Wei wrote: > > On Fri, Apr 12, 2019 at 10:23 AM Yifeng Sun wrote: > > > > This patch introduces changes needed by OVS to support latest > > Linux kernels (4.19.x and 4.20.x). Recent

Re: [ovs-dev] [PATCH] datapath: Revert "datapath: Fix template leak in error cases."

2019-04-16 Thread Yifeng Sun
The more appropriate patch (7664423) mentioned in the revert message was introduced in ovs-2.5. So I think this revert patch should be backported to 2.5. Thanks, Yifeng On Mon, Apr 15, 2019 at 4:08 PM Ben Pfaff wrote: > > On Wed, Apr 03, 2019 at 03:34:34PM -0300, Flavio Leitner via dev wrote: >

Re: [ovs-dev] [PATCH v4] Policy-based routing (PBR) in OVN.

2019-04-16 Thread Ben Pfaff
On Wed, Apr 03, 2019 at 11:27:56PM +, Mary Manohar wrote: > PBR provides a mechanism to configure permit/deny and reroute policies on the > router. Permit/deny policies are similar to OVN ACLs, but exist on the > logical-router. Reroute policies are needed for service-insertion and >

Re: [ovs-dev] [PATCH] rhel: if rpms were built without libcapng then let processrs to run as root

2019-04-16 Thread Aaron Conole
Ansis Atteka writes: > Otherwise, Open vSwitch will fail to start with the following > error "libcap-ng is not configured at compile time" when it > attempts to downgrade to Open vSwitch user. > > Also, if packages were built in a way where processes are > supposed to be running only as root,

Re: [ovs-dev] [PATCH v3 1/2] ovn-controller: Fix busy loop when sb disconnected.

2019-04-16 Thread Ben Pfaff
On Wed, Apr 03, 2019 at 05:49:12PM -0700, Han Zhou wrote: > From: Han Zhou > > In the main loop, if the SB DB is disconnected when there is a pending > transaction, there can be busy loop causing 100% CPU of ovn-controller, > until SB DB is connected again. > > The root cause is that when a

Re: [ovs-dev] [PATCH v2] OVN: fix DVR Floating IP support

2019-04-16 Thread Ben Pfaff
On Sat, Apr 06, 2019 at 05:42:52PM +0200, Lorenzo Bianconi wrote: > When DVR is enabled FIP traffic need to be forwarded directly using > external connection to the underlay network and not be distributed > through geneve tunnels. > Fix this adding new logical flows to take care of distributed

Re: [ovs-dev] [PATCH v7 0/5] ovn: Add HA chassis group and 'external' port

2019-04-16 Thread Numan Siddique
On Tue, Apr 16, 2019 at 10:39 PM Ben Pfaff wrote: > On Thu, Mar 28, 2019 at 11:39:17AM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch series adds a generic HA chassis group support in OVN > > deprecating the existing Gateway chassis support. The final patch > > of

Re: [ovs-dev] [PATCH] checkpatch: Fix handling of line endings.

2019-04-16 Thread Ben Pfaff
On Tue, Apr 16, 2019 at 10:31:20AM +0300, Ilya Maximets wrote: > On 15.04.2019 22:35, Ben Pfaff wrote: > > On Mon, Apr 15, 2019 at 04:36:54PM +0300, Ilya Maximets wrote: > >> Unlike manual splitting, 'splitlines' correctly handles different > >> line endings. Without this change script fails to

Re: [ovs-dev] [PATCH v7 0/5] ovn: Add HA chassis group and 'external' port

2019-04-16 Thread Ben Pfaff
On Thu, Mar 28, 2019 at 11:39:17AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch series adds a generic HA chassis group support in OVN > deprecating the existing Gateway chassis support. The final patch > of the series adds the 'external' port support in OVN. > The

[ovs-dev] KPIS de Recursos Humanos

2019-04-16 Thread Indicadores que debes de medir
Cursos TOP - Webinar Interactivo – Viernes 22 de Mayo KPIS de Recursos Humanos - Para mejorar resultados de tu departamento - Los KPIS adecuados deben ser concisos, simples, fáciles de procesar y equiparables. Para cualquier área resultan de mucha utilidad ya que nos proporcionan mucha

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not send out nbls when cloned nbls are being accessed

2019-04-16 Thread Alin Gabriel Serdean
> On 11 Apr 2019, at 19:14, Anand Kumar via dev wrote: > > As per MSDN documentation, "As soon as a filter driver calls the > NdisFSendNetBufferLists function, it relinquishes ownership of > the NET_BUFFER_LIST structures and all associated resources. > A filter driver should never try to

Re: [ovs-dev] [PATCH v7 0/5] dpcls func ptrs & optimizations

2019-04-16 Thread Ilya Maximets
On 15.04.2019 21:50, Van Haaren, Harry wrote: >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Monday, April 15, 2019 9:33 AM >> To: Van Haaren, Harry ; ovs-dev@openvswitch.org >> Cc: Stokes, Ian ; acon...@redhat.com; >> echau...@redhat.com >> Subject:

Re: [ovs-dev] [PATCH] compiler: Fix compilation when using VStudio 2015/2017

2019-04-16 Thread Alin Gabriel Serdean
Thanks both! I applied this patch as far back as branch-2.9. > On 16 Apr 2019, at 02:16, Anand Kumar via dev wrote: > > Acked-by: Anand Kumar > > Thanks, > Anand Kumar > > ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] rhel: if rpms were built without libcapng then let processrs to run as root

2019-04-16 Thread Darrell Ball
For '3' comment below: s/Regarding playbook-fedora-builder.yml in general, there is issue with playbook-fedora-builder.yml, assuming I use "as is"./ Regarding POC in general, there is an issue with POC for Fedora usage, assuming I use "as is"./ On Mon, Apr 15, 2019 at 11:21 PM Darrell Ball

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

2019-04-16 Thread Ilya Maximets
On 16.04.2019 12:45, David Marchand wrote: > Rather than poll all disabled queues and waste some memory for vms that > have been shutdown, we can reconfigure when receiving a destroy > connection notification from the vhost library. > > $ while true; do > ovs-appctl dpif-netdev/pmd-rxq-show

Re: [ovs-dev] [PATCH v2 2/3] netdev-dpdk: avoid reconfiguration on VIRTIO_NET_F_MQ changes

2019-04-16 Thread Ilya Maximets
On 16.04.2019 12:45, David Marchand wrote: > At the moment, a malicious guest might negotiate VIRTIO_NET_F_MQ and > !VIRTIO_NET_F_MQ in a loop which would be seen as qp_num going from 1 to > n and n to 1 continuously, triggering datapath reconfigurations at each > transition. > > Limit this by

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

2019-04-16 Thread Ilya Maximets
Hi. One comment for the patch names. It's not a rule, but it's better to make the part of the subject a complete sentence. i.e. start with a capital letter and end with a period. Same rule is applicable to the comments in the code, but this is documented in coding-style. More comments inline.

[ovs-dev] (no subject)

2019-04-16 Thread carex martine
Hello Gentlemen & Ladies, Looking for a commercial loan, personal loan, home loan, auto loan, student loans, debt consolidation loans, unsecured loan, venture capital, or was denied a loan by a bank or financial institution for either reason? We offer all types of loans ranging from €1000 to

Re: [ovs-dev] [dpdk-latest PATCH v1] dpdk: Update by new color definitions.

2019-04-16 Thread Ian Stokes
On 4/16/2019 7:41 AM, Ophir Munk wrote: Follwoing dpdk new color definitions (see [1]) 'e_RTE_METER_GREEN' was replaced with 'RTE_COLOR_GREEN'. [1] Commit c1656328dbc2: ("meter: replace color definitions") Signed-off-by: Ophir Munk Thanks for this Ophir, this fixes compilation with DPDK

[ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

2019-04-16 Thread David Marchand
Rather than poll all disabled queues and waste some memory for vms that have been shutdown, we can reconfigure when receiving a destroy connection notification from the vhost library. $ while true; do ovs-appctl dpif-netdev/pmd-rxq-show |awk ' /port: / { tot++; if ($NF == "disabled")

[ovs-dev] [PATCH v2 2/3] netdev-dpdk: avoid reconfiguration on VIRTIO_NET_F_MQ changes

2019-04-16 Thread David Marchand
At the moment, a malicious guest might negotiate VIRTIO_NET_F_MQ and !VIRTIO_NET_F_MQ in a loop which would be seen as qp_num going from 1 to n and n to 1 continuously, triggering datapath reconfigurations at each transition. Limit this by only reconfiguring on increased qp_num. The previous

[ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

2019-04-16 Thread David Marchand
We currently poll all available queues based on the max queue count exchanged with the vhost peer and rely on the vhost library in DPDK to check the vring status beneath. This can lead to some overhead when we have a lot of unused queues. To enhance the situation, we can skip the disabled queues.

[ovs-dev] [PATCH] rhel ovn: Remove ovn-common rpm

2019-04-16 Thread nusiddiq
From: Numan Siddique ovn-fedora spec generates the rpms - ovn, ovn-common, ovn-host etc in which ovn is an empty package. The ovn fedora spec file here [1] has moved all the ovn-common files to the 'ovn' package. This patch does the same. [1] -

[ovs-dev] [PATCH v3 6/6] ovn: Generate ICMPv4 packet in router pipeline for larger packets

2019-04-16 Thread nusiddiq
From: Numan Siddique This patch adds 2 stages in router pipeline after ARP_RESOLVE and adds the logical flows to check the packet length and generate ICMPv4 packet. * S_ROUTER_IN_CHK_PKT_LEN - Which checks the packet length using check_pkt_larger OVN action

[ovs-dev] [PATCH v3 5/6] ovn: Support OVS action 'check_pkt_larger' in OVN

2019-04-16 Thread nusiddiq
From: Numan Siddique Previous commit added a new OVS action 'check_pkt_larger'. This patch supports that action in OVN. The syntax to use this would be reg0[0] = check_pkt_larger(LEN) Upcoming commit will make use of this action in ovn-northd and will generate an ICMPv4 packet if the packet

[ovs-dev] [PATCH v3 4/6] ovn: Add a new OVN action 'icmp4_error'

2019-04-16 Thread nusiddiq
From: Numan Siddique This action is similar to the existing 'icmp4' OVN action except that that this action is expected to be used to generate an ICMPv4 packet in response to an error in original IP packet. When this action injects the icmpv4 packet, it also copies the original IP datagram

[ovs-dev] [PATCH v3 2/6] datapath: Add a new action check_pkt_len

2019-04-16 Thread nusiddiq
From: Numan Siddique Upstream commit: commit 4d5ec89fc8d14dcdab7214a0c13a1c7321dc6ea9 Author: Numan Siddique Date: Tue Mar 26 06:13:46 2019 +0530 net: openvswitch: Add a new action check_pkt_len This patch adds a new action - 'check_pkt_len' which checks the packet

[ovs-dev] [PATCH v3 3/6] ovn: Add a new OVN field icmp4.frag_mtu

2019-04-16 Thread nusiddiq
From: Numan Siddique In order to support OVN specific fields (which are not yet supported in OpenvSwitch to set or modify values) a generic OVN field support is added in this patch. These OVN fields gets translated to controller actions. This patch adds only one field for now - icmp4.frag_mtu.

[ovs-dev] [PATCH v3 1/6] Add a new OVS action check_pkt_larger

2019-04-16 Thread nusiddiq
From: Numan Siddique This patch adds a new action 'check_pkt_larger' which checks if the packet is larger than the given size and stores the result in the destination register. Usage: check_pkt_larger(len)->REGISTER Eg. match=...,actions=check_pkt_larger(1442)->NXM_NX_REG0[0],next; This patch

[ovs-dev] [PATCH v3 0/6] Address MTU issue for larger packets in OVN

2019-04-16 Thread nusiddiq
From: Numan Siddique This series addresses the MTU issues for OVN reported here [1]. This series has 6 patches Patch 1 adds a new OVS action - check_pkt_larger. It makes use of the datapath action - 'check_pkt_len' which was added recently to net-next [2]. Patch 2 is the datapath patch from

Re: [ovs-dev] [PATCH] checkpatch: Fix handling of line endings.

2019-04-16 Thread Ilya Maximets
On 15.04.2019 22:35, Ben Pfaff wrote: > On Mon, Apr 15, 2019 at 04:36:54PM +0300, Ilya Maximets wrote: >> Unlike manual splitting, 'splitlines' correctly handles different >> line endings. Without this change script fails to check files with >> '\r\n' endings treating the whole patch as a header.

[ovs-dev] [dpdk-latest PATCH v1] dpdk: Update by new color definitions.

2019-04-16 Thread Ophir Munk
Follwoing dpdk new color definitions (see [1]) 'e_RTE_METER_GREEN' was replaced with 'RTE_COLOR_GREEN'. [1] Commit c1656328dbc2: ("meter: replace color definitions") Signed-off-by: Ophir Munk --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [ovs-dev] [PATCH] rhel: if rpms were built without libcapng then let processrs to run as root

2019-04-16 Thread Darrell Ball
Thanks for the fix 1/ Main changes to openvswitch-fedora.spec.in look ok to me, but we should probably also see if there is any specific use case concerns from others. 2/ Couple comments inline 3/ Regarding playbook-fedora-builder.yml in general, there is issue with playbook-fedora-builder.yml,