[ovs-dev] Is this your d...@openvswitch.org still active ??

2020-02-06 Thread Nelson Corey
I have tried to reach you on this d...@openvswitch.org mail account severally but I have gotten no response from you, Please get back to me at your earliest convenience if you have received my email this time. Sincerely, Nelson C. ___ dev mailing

[ovs-dev] [OVN]Cookie of OpenFlow will not change, if UUID of logical-flow changes.

2020-02-06 Thread taoyunupt
Hi,Numa, When I change the MTU of netork in OpenStack,the dhcp_options will also changes, and it will delete the old logical flow ,and create a new one for put_dhcp_opts. So the UUID of releated logical-flow will change. But,the cookie of OpenFlow in the allocated chassis not

Re: [ovs-dev] [PATCH v2 1/2] ovs-numa: Non-consecutively numa nodes and cores

2020-02-06 Thread dwilder
On 2020-02-06 12:58, Ben Pfaff wrote: On Thu, Feb 06, 2020 at 12:38:16PM -0800, David Wilder wrote: +char *path; + +path = xasprintf( "/sys/devices/system/cpu/cpu%d/topology/core_id" , + core_id); +if (access(path, F_OK) != 0) { +return 0; } + +

Re: [ovs-dev] Question Regarding ovs_packet_cmd_execute in Kernel Datapath

2020-02-06 Thread Ben Pfaff
On Thu, Feb 06, 2020 at 01:32:12PM -0800, Pravin Shelar wrote: > On Thu, Feb 6, 2020 at 12:18 PM Ben Pfaff wrote: > > > > On Thu, Feb 06, 2020 at 11:36:19AM -0800, Pravin Shelar wrote: > > > Another option would be to add new command that install and execute > > > packet in same netlink msg. That

Re: [ovs-dev] [PATCH net-next v4] openvswitch: add TTL decrement action

2020-02-06 Thread David Miller
From: Matteo Croce Date: Thu, 6 Feb 2020 21:29:49 +0100 > New action to decrement TTL instead of setting it to a fixed value. > This action will decrement the TTL and, in case of expired TTL, drop it > or execute an action passed via a nested attribute. > The default TTL expired action is to

Re: [ovs-dev] Question Regarding ovs_packet_cmd_execute in Kernel Datapath

2020-02-06 Thread Pravin Shelar
On Thu, Feb 6, 2020 at 12:18 PM Ben Pfaff wrote: > > On Thu, Feb 06, 2020 at 11:36:19AM -0800, Pravin Shelar wrote: > > Another option would be to add new command that install and execute > > packet in same netlink msg. That would save us a netlink msg to handle > > a miss-call. what do you

Re: [ovs-dev] [PATCH] netdev-dpdk: Don't enable offloading on HW device if not requested.

2020-02-06 Thread David Marchand
On Thu, Feb 6, 2020 at 2:35 PM Ilya Maximets wrote: > > DPDK drivers has different implementations of transmit functions. > Enabled offloading may cause driver to choose slower variant > significantly affecting performance if userspace TSO wasn't requested. > > Fixes: 29cf9c1b3b9c ("userspace:

Re: [ovs-dev] [PATCH v2] netdev-linux: Prepend the std packet in the TSO packet

2020-02-06 Thread Ben Pfaff
On Thu, Feb 06, 2020 at 05:53:21PM -0300, Flavio Leitner wrote: > On Thu, Feb 06, 2020 at 12:26:38PM -0800, Ben Pfaff wrote: > > On Mon, Feb 03, 2020 at 06:45:50PM -0300, Flavio Leitner wrote: > > > Usually TSO packets are close to 50k, 60k bytes long, so to > > > to copy less bytes when receiving

Re: [ovs-dev] [PATCH] netdev-linux-private: fix max length to be 16 bits

2020-02-06 Thread Flavio Leitner
On Thu, Feb 06, 2020 at 12:27:53PM -0800, Ben Pfaff wrote: > On Thu, Feb 06, 2020 at 04:54:25PM -0300, Flavio Leitner wrote: > > On Thu, Feb 06, 2020 at 11:37:06AM -0800, Ben Pfaff wrote: > > > On Thu, Feb 06, 2020 at 11:31:37AM -0800, Ben Pfaff wrote: > > > > On Mon, Feb 03, 2020 at 11:22:22AM

Re: [ovs-dev] [PATCH v2 1/2] ovs-numa: Non-consecutively numa nodes and cores

2020-02-06 Thread Ben Pfaff
On Thu, Feb 06, 2020 at 12:38:16PM -0800, David Wilder wrote: > +char *path; > + > +path = xasprintf( "/sys/devices/system/cpu/cpu%d/topology/core_id" , > + core_id); > +if (access(path, F_OK) != 0) { > +return 0; > } > + > +return 1; I didn't read

Re: [ovs-dev] [PATCH v2] db-ctl-base: add uuid specified method for create cmd

2020-02-06 Thread Ben Pfaff
On Thu, Feb 06, 2020 at 05:17:33PM +0800, Tao YunXiang wrote: > Commit a529e3cd1f (ovsdb-server: Allow OVSDB clients to specify the > UUID for inserted rows) solves ovsdb-client specifing the UUID for > insert operation. OVSDB now can support directly using uuid to identify > a row. But for

Re: [ovs-dev] [PATCH v2] netdev-linux: Prepend the std packet in the TSO packet

2020-02-06 Thread Flavio Leitner
On Thu, Feb 06, 2020 at 12:26:38PM -0800, Ben Pfaff wrote: > On Mon, Feb 03, 2020 at 06:45:50PM -0300, Flavio Leitner wrote: > > Usually TSO packets are close to 50k, 60k bytes long, so to > > to copy less bytes when receiving a packet from the kernel > > change the approach. Instead of extending

[ovs-dev] [PATCH v2 0/2] Support for non-consecutive numa nodes and core ids.

2020-02-06 Thread David Wilder
Ovs-numa currently makes the assumption that numa node ids and cpu core ids will be numbered consecutively. Current Power systems don't always follow this model. Furthermore, cpus on Power may be on/off lined based the setting of Simultaneous multithreading (SMT). The result can be gaps in the

[ovs-dev] [PATCH v2 1/2] ovs-numa: Non-consecutively numa nodes and cores

2020-02-06 Thread David Wilder
This change removes the assumption that numa nodes and cores are numbered consecutively in linux. This change is required to support some Power systems. An additional check has been added to verify that cores are online, offline cores result in non-consecutively numbered cores. I manually

[ovs-dev] [PATCH v2 2/2] ovs-numa: Dpdk options with non-consecutive nodes.

2020-02-06 Thread David Wilder
If not supplied by the user --socket-mem and --socket-limit EAL options are set to a default value based system topology. The assumption that numa nodes must be numbered consecutive is removed by this change. These options can be seen in the ovs-vswitchd.log. For example: a system containing

[ovs-dev] [PATCH net-next v4] openvswitch: add TTL decrement action

2020-02-06 Thread Matteo Croce
New action to decrement TTL instead of setting it to a fixed value. This action will decrement the TTL and, in case of expired TTL, drop it or execute an action passed via a nested attribute. The default TTL expired action is to drop the packet. Supports both IPv4 and IPv6 via the ttl and

Re: [ovs-dev] [PATCH] netdev-linux-private: fix max length to be 16 bits

2020-02-06 Thread Ben Pfaff
On Thu, Feb 06, 2020 at 04:54:25PM -0300, Flavio Leitner wrote: > On Thu, Feb 06, 2020 at 11:37:06AM -0800, Ben Pfaff wrote: > > On Thu, Feb 06, 2020 at 11:31:37AM -0800, Ben Pfaff wrote: > > > On Mon, Feb 03, 2020 at 11:22:22AM -0300, Flavio Leitner wrote: > > > > The dp_packet length is limited

Re: [ovs-dev] [PATCH v2] netdev-linux: Prepend the std packet in the TSO packet

2020-02-06 Thread Ben Pfaff
On Mon, Feb 03, 2020 at 06:45:50PM -0300, Flavio Leitner wrote: > Usually TSO packets are close to 50k, 60k bytes long, so to > to copy less bytes when receiving a packet from the kernel > change the approach. Instead of extending the MTU sized > packet received and append with remaining TSO data

Re: [ovs-dev] Question Regarding ovs_packet_cmd_execute in Kernel Datapath

2020-02-06 Thread Ben Pfaff
On Thu, Feb 06, 2020 at 11:36:19AM -0800, Pravin Shelar wrote: > Another option would be to add new command that install and execute > packet in same netlink msg. That would save us a netlink msg to handle > a miss-call. what do you think about it? When I experimented with that in the past, I

Re: [ovs-dev] [PATCH] netdev-linux-private: fix max length to be 16 bits

2020-02-06 Thread Flavio Leitner
On Thu, Feb 06, 2020 at 11:37:06AM -0800, Ben Pfaff wrote: > On Thu, Feb 06, 2020 at 11:31:37AM -0800, Ben Pfaff wrote: > > On Mon, Feb 03, 2020 at 11:22:22AM -0300, Flavio Leitner wrote: > > > The dp_packet length is limited to 16 bits, so document that > > > and fix the length value accordingly.

Re: [ovs-dev] [PATCH 2/2] Prepare for post-20.03.0 (20.03.90).

2020-02-06 Thread Mark Michelson
All right, branch-20.03 is now created! On 2/5/20 5:51 AM, Numan Siddique wrote: On Wed, Feb 5, 2020 at 1:49 AM Mark Michelson wrote: Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan --- NEWS | 6 +- configure.ac | 2 +- debian/changelog | 6 ++

Re: [ovs-dev] [PATCH] netdev-linux-private: fix max length to be 16 bits

2020-02-06 Thread Ben Pfaff
On Thu, Feb 06, 2020 at 11:31:37AM -0800, Ben Pfaff wrote: > On Mon, Feb 03, 2020 at 11:22:22AM -0300, Flavio Leitner wrote: > > The dp_packet length is limited to 16 bits, so document that > > and fix the length value accordingly. > > > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation

Re: [ovs-dev] Question Regarding ovs_packet_cmd_execute in Kernel Datapath

2020-02-06 Thread Pravin Shelar
On Wed, Feb 5, 2020 at 10:11 AM Dincer Beken wrote: > > Hello all, > > I am not entirely new to Open vSwitch and am implementing new actions to > realize the TS25.446 SYNC algorithm from 3GPP to create an BM-SC component > for LTE-Multicast (eMBMS). I am lacking the experience to judge over the

Re: [ovs-dev] [PATCH] netdev-linux-private: fix max length to be 16 bits

2020-02-06 Thread Ben Pfaff
On Mon, Feb 03, 2020 at 11:22:22AM -0300, Flavio Leitner wrote: > The dp_packet length is limited to 16 bits, so document that > and fix the length value accordingly. > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") > Signed-off-by: Flavio Leitner Thanks! Applied to

Re: [ovs-dev] [PATCH RFC] connmgr: support changing openflow versions without restarting

2020-02-06 Thread Ben Pfaff
On Fri, Jan 31, 2020 at 03:34:02PM -0500, Aaron Conole wrote: > When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive > connections more uniform") was applied, it didn't take into account > that a reconfiguration of the allowed_versions setting needs to > propagate to the rconn

Re: [ovs-dev] [PATCH] netdev-dpdk: Don't enable offloading on HW device if not requested.

2020-02-06 Thread Kevin Traynor
On 06/02/2020 13:35, Ilya Maximets wrote: > DPDK drivers has different implementations of transmit functions. > Enabled offloading may cause driver to choose slower variant > significantly affecting performance if userspace TSO wasn't requested. > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP

[ovs-dev] 答复: 答复: 答复: 答复: 答复: [PATCH v2] netdev-linux: Prepend the std packet in the TSO packet

2020-02-06 Thread 杨燚
Got it, I didn't apply the third one " netdev-linux-private: fix max length to be 16 bits ", that should be the reason of the issue. I had thought you just added a comment in this patch, so didn't apply it, it changed 65536 to 65535, it is my mistake. Thanks a lot. -邮件原件- 发件人: Flavio

Re: [ovs-dev] [PATCH] netdev-dpdk: Don't enable offloading on HW device if not requested.

2020-02-06 Thread Flavio Leitner
On Thu, Feb 06, 2020 at 02:35:30PM +0100, Ilya Maximets wrote: > DPDK drivers has different implementations of transmit functions. > Enabled offloading may cause driver to choose slower variant > significantly affecting performance if userspace TSO wasn't requested. > > Fixes: 29cf9c1b3b9c

Re: [ovs-dev] [PATCH] netdev-dpdk: Don't enable offloading on HW device if not requested.

2020-02-06 Thread Ilya Maximets
On 2/6/20 2:35 PM, Ilya Maximets wrote: > DPDK drivers has different implementations of transmit functions. > Enabled offloading may cause driver to choose slower variant > significantly affecting performance if userspace TSO wasn't requested. > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-06 Thread Ilya Maximets
On 2/6/20 1:28 PM, David Marchand wrote: > On Thu, Feb 6, 2020 at 12:50 PM Flavio Leitner wrote: >> >> On Thu, Feb 06, 2020 at 11:48:58AM +0100, Ilya Maximets wrote: >>> On 2/5/20 7:01 PM, David Marchand wrote: On Wed, Feb 5, 2020 at 12:42 PM Flavio Leitner wrote: > > On Tue, Feb

[ovs-dev] [PATCH] netdev-dpdk: Don't enable offloading on HW device if not requested.

2020-02-06 Thread Ilya Maximets
DPDK drivers has different implementations of transmit functions. Enabled offloading may cause driver to choose slower variant significantly affecting performance if userspace TSO wasn't requested. Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") Signed-off-by: Ilya

[ovs-dev] Contact Federal Reserve Bank New York to receive your inheritance contract payment (US$12.8M)

2020-02-06 Thread MS. MARYANNA B. THOMASON
Attention Fund Beneficiary, Contact Federal Reserve Bank New York to receive your inheritance contract payment (US$12.8M) Payment Release Instruction from US department of Homeland Security New York. Contact Federal Reserve Bank New York to receive your inheritance contract payment (US$12.8M)

[ovs-dev] 答复: [PATCH] Use TPACKET_V1/V2/V3 to accelerate veth for DPDK datapath

2020-02-06 Thread 杨燚
Thanks Illya for pointing out this, I checked if_packet.h in git.kernel.org by using v3.10 tag, it indeed can support TPACKET_V3 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/if_packet.h?h=v3.10

Re: [ovs-dev] 答复: 答复: 答复: 答复: [PATCH v2] netdev-linux: Prepend the std packet in the TSO packet

2020-02-06 Thread Flavio Leitner
On Thu, Feb 06, 2020 at 01:03:32PM +, Yi Yang (杨燚)-云服务集团 wrote: > Hi, Flavio > > What's the difference between > https://github.com/fleitner/ovs/tree/tso-tap-enable-tx-v1 and ovs > master? My network is very slow, maybe you call tell me which > commits are new compared to ovs master, I can

[ovs-dev] 答复: 答复: 答复: 答复: [PATCH v2] netdev-linux: Prepend the std packet in the TSO packet

2020-02-06 Thread 杨燚
Hi, Flavio What's the difference between https://github.com/fleitner/ovs/tree/tso-tap-enable-tx-v1 and ovs master? My network is very slow, maybe you call tell me which commits are new compared to ovs master, I can get those commits and apply them against my local ovs tree, that will be

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-06 Thread David Marchand
On Thu, Feb 6, 2020 at 12:50 PM Flavio Leitner wrote: > > On Thu, Feb 06, 2020 at 11:48:58AM +0100, Ilya Maximets wrote: > > On 2/5/20 7:01 PM, David Marchand wrote: > > > On Wed, Feb 5, 2020 at 12:42 PM Flavio Leitner wrote: > > >> > > >> On Tue, Feb 04, 2020 at 10:28:26PM +0100, David Marchand

Re: [ovs-dev] 答复: 答复: 答复: [PATCH v2] netdev-linux: Prepend the std packet in the TSO packet

2020-02-06 Thread Flavio Leitner
On Thu, Feb 06, 2020 at 07:34:35AM +, Yi Yang (杨燚)-云服务集团 wrote: > Hi, Flavio > > I tried current ovs master and your two patches (this one and the > one for tap), tap to tap and veth to veth performance are very bad > when tso is on, I think merged tso patch series are wrong for such > use

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-06 Thread Flavio Leitner
On Thu, Feb 06, 2020 at 11:48:58AM +0100, Ilya Maximets wrote: > On 2/5/20 7:01 PM, David Marchand wrote: > > On Wed, Feb 5, 2020 at 12:42 PM Flavio Leitner wrote: > >> > >> On Tue, Feb 04, 2020 at 10:28:26PM +0100, David Marchand wrote: > >>> The check on TSO capability did not ensure ip

Re: [ovs-dev] [PATCH] Use TPACKET_V1/V2/V3 to accelerate veth for DPDK datapath

2020-02-06 Thread Ilya Maximets
> On Sun, Feb 2, 2020 at 8:06 PM Yi Yang (杨燚)-云服务集团 > wrote: >> >> Hi, William >> >> Sorry for last reply, I don't know why I always can't get your comments >> email from my outlook, Ben's comments are ok, I also can't see your comments >> in outlook junk box. >> >> About your comments in >>

Re: [ovs-dev] [PATCH v10 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

2020-02-06 Thread Ilya Maximets
On 2/6/20 7:39 AM, Vishal Deep Ajmera wrote: >>> >>> So, the root cause of all the issues in this patch, in my understanding, >>> is the fact that you need to collect statistics for all the bond hashes >>> in order to be able to rebalance traffic. This forces you to have access >>> to PMD local

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix port init when lacking Tx offloads for TSO.

2020-02-06 Thread Ilya Maximets
On 2/5/20 7:01 PM, David Marchand wrote: > On Wed, Feb 5, 2020 at 12:42 PM Flavio Leitner wrote: >> >> On Tue, Feb 04, 2020 at 10:28:26PM +0100, David Marchand wrote: >>> The check on TSO capability did not ensure ip checksum, tcp checksum and >>> TSO tx offloads were available which resulted in

[ovs-dev] [PATCH v2] db-ctl-base: add uuid specified method for create cmd

2020-02-06 Thread Tao YunXiang
Commit a529e3cd1f (ovsdb-server: Allow OVSDB clients to specify the UUID for inserted rows) solves ovsdb-client specifing the UUID for insert operation. OVSDB now can support directly using uuid to identify a row. But for xxxctl tool,specifying uuid when creating a row is not yet supported . This

Re: [ovs-dev] [PATCH v10 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

2020-02-06 Thread Vishal Deep Ajmera via dev
> > > > So, the root cause of all the issues in this patch, in my understanding, > > is the fact that you need to collect statistics for all the bond hashes > > in order to be able to rebalance traffic. This forces you to have access > > to PMD local caches. > > > > The basic idea how to overcome

Re: [ovs-dev] [PATCH] db-ctl-base: add uuid specified method for create cmd

2020-02-06 Thread 0-day Robot
Bleep bloop. Greetings Yunxiang Tao, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Yunxiang Tao needs to sign off. ERROR: Co-author Liu Chang needs to sign off.

[ovs-dev] [PATCH] db-ctl-base: add uuid specified method for create cmd

2020-02-06 Thread Yunxiang Tao
Commit a529e3cd1f (ovsdb-server: Allow OVSDB clients to specify the UUID for inserted rows) solves ovsdb-client specifing the UUID for insert operation. OVSDB now can support directly using uuid to identify a row. But for xxxctl tool,specifying uuid when creating a row is not yet supported . This