Hi Sunil,
Thanks for the reviews will add the necessary documentation changes .
Regards
Amber
> -Original Message-
> From: Pai G, Sunil
> Sent: Tuesday, October 4, 2022 9:00 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; f...@sysclose.or
Hi Sunil,
I will take all the comments in V6
Regards
Amber
> -Original Message-
> From: Pai G, Sunil
> Sent: Tuesday, October 4, 2022 7:50 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; f...@sysclose.org; Amber, Kumar
>
> Subject: RE: [o
Sure have fixed the typo in the next patch
> -Original Message-
> From: Pai G, Sunil
> Sent: Tuesday, October 4, 2022 5:32 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; f...@sysclose.org; Amber, Kumar
>
> Subject: RE: [ovs-dev] [PATC
Hi Sunil,
Sure will fix that comment.
Regards
Amber
> -Original Message-
> From: Pai G, Sunil
> Sent: Tuesday, October 4, 2022 3:21 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; f...@sysclose.org; Amber, Kumar
>
> Subject: RE: [ovs-dev
Hi Sunil,
Sure, have added the comments in the commit log.
Regards
Amber
> -Original Message-
> From: Pai G, Sunil
> Sent: Tuesday, October 4, 2022 12:32 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; f...@sysclose.org; Amber, Kumar
>
>
Hi Cian,
> -Original Message-
> From: Ferriter, Cian
> Sent: Thursday, September 29, 2022 8:58 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: echau...@redhat.com; i.maxim...@ovn.org; Stokes, Ian
> ; f...@sysclose.org; Van Haaren, Harry
>
> Subject: RE:
Hi Cian,
Please find the comments inline.
> -Original Message-
> From: Ferriter, Cian
> Sent: Thursday, September 29, 2022 9:01 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: echau...@redhat.com; i.maxim...@ovn.org; Stokes, Ian
> ; f...@sysclose.org;
Hi Cian,
Please find the comments inline.
> > /* Do a batch minfilow extract into keys. */
> > - /* Do a batch minfilow extract into keys, but only for outer packets.
> > */
>
> In the earlier DPIF part of this patchset, I guess you add the above comment
> line that you are removing
Hi Sunil,
Sure will put the intent in the Commit log.
> -Original Message-
> From: Pai G, Sunil
> Sent: Monday, October 3, 2022 8:56 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; f...@sysclose.org; Amber, Kumar
>
> Subject: RE: [ovs-dev
Hi Michael,
The Regression looks good, and the patch looks good too.
Regression CI runs are added as Screenshots.
Acked-by: Kumar Amber
> -Original Message-
> From: Phelan, Michael
> > Fixes: bf47829116a8feb54fe795aa19915f6e6283af93 ("tests: Add OVS-
> DPDK
> > MTU unit tests.")
>
Hey all,
Have tested the all the patches in the series.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers: Harry van Haaren
Lines checked: 255, Warnings: 1, Errors: 0
Second CI failure is random again.
Tested-by: Kumar Amber
BR
Hey all,
Have tested the all the patches in the series.
Can be fixed while applying:
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers: Harry van Haaren
Lines checked: 255, Warnings: 1, Errors: 0
Tested-by: Kumar Amber
BR
Amber
Hey all,
Have tested the all the patches in the series.
Tested-by: Kumar Amber
BR
Amber
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hey all,
Have tested the all the patches in the series.
Tested-by: Kumar Amber
BR
Amber
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hey all,
Have tested the all the patches in the series.
Tested-by: Kumar Amber
BR
Amber
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hey all,
Have tested the all the patches in the series.
CI fails randomly again due to ubuntu download dependency/ random fails not
related to patch.
Tested-by: Kumar Amber
BR
Amber
___
dev mailing list
d...@openvswitch.org
Hey all,
Have tested the all the patches in the series.
Tested-by: Kumar Amber
BR
Amber
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hey all,
Have tested the all the patches in the series.
Tested-by: Kumar Amber
BR
Amber
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hey Harry,
The CI fails due to dependency Error and not related to patch and it's a random
error:
E: Failed to fetch
http://azure.archive.ubuntu.com/ubuntu/pool/main/u/unbound/libunbound2_1.6.7-1ubuntu2.4_amd64.deb
Could not connect to azure.archive.ubuntu.com:80 (20.106.104.242), connection
> > Hi Michael,
> >
> > The patch uses MTU sizes > 9000 values to check and fail but 9000 may
> > not be good value for older NICs As they might fail the test ?
> >
> > Can we kind of confirm is MTU > 9000 is safe if not we can just use a
> > lower value like 1500 etc etc to be safe So that we
Hi Michael,
The patch uses MTU sizes > 9000 values to check and fail but 9000 may not be
good value for older NICs
As they might fail the test ?
Can we kind of confirm is MTU > 9000 is safe if not we can just use a lower
value like 1500 etc etc to be safe
So that we don't fail un-necessary
Hi Flavio, Mike,
I did have a quick look over the patch-set
https://patchwork.ozlabs.org/project/openvswitch/list/?series=307485
I have some comments over the patches mentioned below:
1. Can a Cover letter be provided with the patch-set to
understand the intent/approach of
Hi Ilya,
Please find the replies inline.
> >> #include "dpif-netdev-private-dpcls.h"
> >> +#include "dpif-netdev-private-dpif.h"
> >> +#include "dpif-netdev-private-extract.h"
>
> "private" dpif-netdev headers should not be included in non dpif-netdev
> modules.
>
There are many structures
Hi Ilya,
Can you please provide feedback / review on the request flow-based testing
patch for MFEX ?
http://patchwork.ozlabs.org/project/openvswitch/list/?series=297158
Regards
Amber
___
dev mailing list
d...@openvswitch.org
Hi Ilya,
> -Original Message-
> From: Ilya Maximets
> Sent: Wednesday, June 29, 2022 5:55 PM
> To: Eelco Chaudron
> Cc: i.maxim...@ovn.org; ovs-dev@openvswitch.org; Flavio Leitner
> ; Amber, Kumar
> Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Fix leak of AVX5
Thanks, Eelco, All the review helped to improve the patch
Regards
Amber
> -Original Message-
> From: Eelco Chaudron
> Sent: Friday, May 27, 2022 2:07 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; Ferriter, Cian ;
> i.maxim...@ovn.org; Stokes, Ian ;
Hi Ilya,
Can you please provide feedback on the patch-set, if it suffices the flow based
testing or needs some change to adapt it to flow based testing for AVX512 MFEX ?
Regards
Amber
> -Original Message-
> From: Amber, Kumar
> Sent: Wednesday, April 27, 2022 4:49 PM
>
Hi Harry,
> -Original Message-
> From: Van Haaren, Harry
> Sent: Wednesday, May 25, 2022 8:00 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: echau...@redhat.com; ktray...@redhat.com; i.maxim...@ovn.org;
> Ferriter, Cian ; Stokes, Ian ;
> david.m
Hi Cian, Eelco
Thanks for the suggestions.
Replies inline.
> -Original Message-
> From: Ferriter, Cian
> Sent: Wednesday, May 25, 2022 9:09 PM
> To: Eelco Chaudron ; Amber, Kumar
>
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian
> ; Van Haaren,
Hi Eelco,
Please find replies inline.
> > +# Relative path for the pcap file location.
> > path = str(sys.argv[1]) + "/pcap/fuzzy.pcap"
>
> Would it be better to supply the full file name, rather than a fixed file name
> and directory being concatenated?
>
Sure, would make the script usable
Hi Eelco,
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, May 24, 2022 4:22 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; Ferriter, Cian ;
> i.maxim...@ovn.org; Stokes, Ian ; Van Haaren, Harry
>
> Subject: Re: [PATCH v4] tests/mfex: Impr
Hi Eelco,
> Sound like a plan, as I know Ilya commented on them before, but I could not
> quickly find it. So it will be good to know why they are there.
> Would also be nice to confirm you also see these messages without AVX512
> enabled doing the same tests.
>
> //Eelco
ACK
Sent V4 omitting
Hi Eelco,
Thanks again replies Ilnie.
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, May 24, 2022 3:15 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; Ferriter, Cian ;
> i.maxim...@ovn.org; Stokes, Ian ; Van Haaren, Harry
>
> Subject: R
Hi Eelco,
Thanks again for reviews . Please find my replies inline.
> > +tcp = TCP(dport=RandShort(), sport=RandShort(), flags='S',
> > + dataofs=random.randint(0, 15))
>
> Maybe a new line before the command, as it was before.
>
Fixed in next version.
> > +
Hi Eelco,
Please find my replies Inline.
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday, May 12, 2022 2:53 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; Ferriter, Cian ;
> Stokes, Ian ; Van Haaren, Harry
> ; Ilya Maximets
> Subject: R
Hi Eelco,
Thanks for pointing out, I have updated a patch with the fix for the two
problems you were witnessing.
The patch also contains improvements to the MFEX testing as well like reducing
the packet generation time,
Script generating more complicated traffic for testing corner cases like
Hi Cian,
Please find my replies inline.
> -Original Message-
> From: Ferriter, Cian
> Sent: Monday, April 25, 2022 5:12 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: Stokes, Ian ; echau...@redhat.com;
> ktray...@redhat.com; i.maxim...@ovn.org; f...@sysclo
Hi Cian,
Thanks for the comments please see my replies inline.
> -Original Message-
> From: Ferriter, Cian
> Sent: Monday, April 25, 2022 5:05 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org;
> i.maxim...@ovn.org
> Cc: Stokes, Ian ; echau...@redhat.com;
> k
Hi Cian,
> -Original Message-
> From: Ferriter, Cian
> Sent: Monday, April 25, 2022 5:15 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: Stokes, Ian ; echau...@redhat.com;
> ktray...@redhat.com; i.maxim...@ovn.org; f...@sysclose.org; Van Haaren,
> Harry
>
Hi Ilya,
Please find my replies inline.
> -Original Message-
> From: Ilya Maximets
> Sent: Wednesday, March 30, 2022 10:23 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org;
> Stokes, Ian
> Cc: i.maxim...@ovn.org; f...@sysclose.org; Eelco Chaudron
> ; Ferriter, Cian
Hi Ilya,
Thanks a lot for such a wonderful review of the series.
Replies inline.
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, April 12, 2022 5:05 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; echau...@redhat.com; ktray...@redhat.
Hi Ilya,
Please find my replies Inline.
> -Original Message-
> From: Ilya Maximets
> Sent: Wednesday, April 6, 2022 3:38 AM
> To: Stokes, Ian ; Amber, Kumar
> ; ovs-dev@openvswitch.org
> Cc: f...@sysclose.org; i.maxim...@ovn.org; Aaron Conole
> ; Adrian Mor
HI Michael Ian,
> -Original Message-
> From: Phelan, Michael
> Sent: Tuesday, April 5, 2022 7:47 PM
> To: Stokes, Ian ; Amber, Kumar
> ; ovs-dev@openvswitch.org
> Cc: echau...@redhat.com; Ferriter, Cian ;
> f...@sysclose.org; Van Haaren, Harry
> Subject: RE: [
Hi Ilya,
Thanks for review comments.
> -Original Message-
> From: Ilya Maximets
> Sent: Wednesday, March 30, 2022 10:46 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; Ferriter, Cian ; Stokes, Ian
> ; f...@sysclose.org; echau...@redhat.com; V
Hi Ilya,
Thanks for highlighting the Patch.
Replies Inline.
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, March 21, 2022 10:26 PM
> To: d...@openvswitch.org; Stokes, Ian ; Van Haaren,
> Harry ; Ferriter, Cian
> ; Amber, Kumar
> Cc: i.maxim...
Hi Ilya,
Thanks for the comments.
Replies Inline.
> -Original Message-
> From: Ilya Maximets
> Sent: Thursday, March 17, 2022 6:21 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; f...@sysclose.org
> Subject: Re: [ovs-dev] [PATCH v1
Hi Ilya,
Thanks for the comments.
Replies are inline.
> -Original Message-
> From: Ilya Maximets
> Sent: Thursday, March 17, 2022 5:30 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org;
> Stokes, Ian
> Cc: f...@sysclose.org; i.maxim...@ovn.org; Eelco Chaudron
Hi Ilya,
Thanks a lot for the valuable feedback.
Please find the reply inline.
> -Original Message-
> From: Ilya Maximets
> Sent: Saturday, March 12, 2022 3:57 AM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; f...@sysclose.org
> Subject: Re: [
alahasthi,
> Suneetha ; Amber, Kumar
>
> Subject: Re: [ovs-build] |fail| pw1600225 [ovs-dev, branch-2.15] dpdk: Use
> DPDK 20.11.4 release
>
> On 3/14/22 12:29, Phelan, Michael wrote:
> >> -Original Message-
> >> From: Ilya Maximets
> >> S
Hi IIlya,
> -Original Message-
> From: Ilya Maximets
> Sent: Saturday, March 12, 2022 3:26 AM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; Phelan, Michael
> Subject: Re: [ovs-dev] [PATCH v1] system-dpdk.at: Add ignore warning for
> c
Hi llya,
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, March 1, 2022 1:50 AM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; Phelan, Michael
> Subject: Re: [ovs-dev] [PATCH v1] system-dpdk.at: Add ignore warning for
> c
Hi Cian,
I agree with the suggestion we can use the normal AT_CHECK since we already
have used the AT_CHECK_IF for checking AVX512.
Thanks
> -Original Message-
> From: Ferriter, Cian
> Sent: Monday, February 28, 2022 2:44 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
Hi IIya,
Thanks for the comments
>
>
> Hi. These warnings are more about long poll intervals and that should not
> happen during tests. Which test is causing this problem?
>
> Long poll intervals usually indicate a problem with the test itself.
> Usual suspect is poor pinning of PMD
Hi Cian,
Thanks for the Patch.
I have tested the patch and reviewed as well.
One small minor comment .
> +atomic_store_relaxed(>miniflow_extract_opt,
> +miniflow_funcs[MFEX_IMPL_SCALAR].extract_func);
> VLOG_INFO("Not enough packets matched (%u/%u),
to be
Added here
Regards
Amber
> -Original Message-
> From: Eelco Chaudron
> Sent: Friday, February 4, 2022 2:54 PM
> To: Van Haaren, Harry
> Cc: ovs-dev@openvswitch.org; Ferriter, Cian ; Stokes,
> Ian ; i.maxim...@ovn.org; Amber, Kumar
>
> Subject: Re: [PATCH v
Hi Harry,
Tested Again and looks ohk now in random testing.
Regards
Amber
> -Original Message-
> From: Van Haaren, Harry
> Sent: Monday, January 31, 2022 7:25 PM
> To: ovs-dev@openvswitch.org
> Cc: Ferriter, Cian ; Stokes, Ian
> ; i.maxim...@ovn.org; echau...@redhat.c
Hi Harry,
Thanks for the fix while testing found an issue around frag masking.
The mask is causing one bit to be not exactly what is being generated from
scalar MFEX and due to which
Auto-validator tests are failing.
Hi IIlya,
Thanks for the patch.
Tested and Reviewed all looks good.
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, January 4, 2022 4:46 AM
> To: ovs-dev@openvswitch.org
> Cc: David Marchand ; Amber, Kumar
> ; Ilya Maximets
> Subject: [PATCH] dpif-n
Thanks A lot, Eelco for all those reviews and great comments .
Regards
Amber
> -Original Message-
> From: Eelco Chaudron
> Sent: Friday, December 17, 2021 4:35 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; Stokes, Ian
> ; Van Haaren, Ha
.
Regards
Amber
> -Original Message-
> From: Eelco Chaudron
> Sent: Friday, December 10, 2021 6:49 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; Stokes, Ian
> ; Van Haaren, Harry
> Subject: Re: [PATCH v4] dpcls: Change info-get function to fetc
Hi Ilya,
Reviewed and Tested the Patch looks good. Thanks for the Fixes .
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, December 14, 2021 3:49 AM
> To: ovs-dev@openvswitch.org
> Cc: Stokes, Ian ; Amber, Kumar
> ; Ferriter, Cian ; Van
> Haaren,
Hi David,
Please find my replies inline.
> -Original Message-
> From: David Marchand
> Sent: Tuesday, November 30, 2021 8:30 PM
> To: d...@openvswitch.org
> Cc: i.maxim...@ovn.org; Stokes, Ian ;
> tredae...@redhat.com; Amber, Kumar ;
> f...@sysclose.org
Hi David,
Please find the Replies inline.
> -Original Message-
> From: David Marchand
> Sent: Wednesday, December 1, 2021 6:24 PM
> To: Amber, Kumar
> Cc: d...@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian
> ; tredae...@redhat.com; f...@sysclose.org;
>
edae...@redhat.com; Amber, Kumar ;
> f...@sysclose.org; echau...@redhat.com; maxime.coque...@redhat.com
> Subject: [PATCH v3 4/4] tests: Move MFEX tests to dpif-netdev.
>
> The MFEX code and tests do not depend on DPDK anymore.
> We can move the unit tests to dpif-netdev.
>
> Sign
Hi IIya,
Pls find the replies inline.
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, September 28, 2021 6:22 PM
> To: Amber, Kumar ; Ilya Maximets
> ; ovs-dev@openvswitch.org;
> tony.vanderp...@alliedtelesis.co.nz
> Cc: Stokes, Ian ; Van Haaren, Harry
&
instruction.
This test seems to expect *a specific value* of a hash result, causing it to
pass/fail based on hashing implementation selected at ./configure time.
Regards
Amber
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, September 21, 2021 7:00 PM
> To: Ambe
test-case.
Regards
Amber
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, September 20, 2021 5:05 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org;
> i.maxim...@ovn.org; tony.vanderp...@alliedtelesis.co.nz
> Cc: Stokes, Ian ; Van Haaren, Harry
>
> Subject: Re:
Hi all,
The following commit ID with the following description added a test case for
"tunnel-push-pop" test-suit by the name: "tunnel_push_pop - packet_out
debug_slow" has been found to be failing on the latest master branch.
## --- ##
## openvswitch 2.16.90
Thursday, September 2, 2021 10:40 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org
> Subject: Re: [PATCH v3] pmd.at: Add test-cases for DPCLS and DPIF commands.
>
> On 26/08/2021 20:57, Kumar Amber wrote:
> > Added 2 separate test-cases for DPCLS and DPIF c
: generic
])
V3: http://patchwork.ozlabs.org/project/openvswitch/list/?series=259816
Thanks for the get and set idea .
And more responses are in-lined.
> -Original Message-
> From: Kevin Traynor
> Sent: Friday, August 27, 2021 3:35 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
&
Hi Kevin,
Thanks a lot for the Reviews.
Responses are inlined.
> -Original Message-
> From: Kevin Traynor
> Sent: Thursday, August 26, 2021 8:50 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [PATCH v2] pmd.at: Add
Hi Ilya,
Thanks for the Reviews .
Replies are Inline.
> -Original Message-
> From: Ilya Maximets
> Sent: Wednesday, August 25, 2021 8:02 PM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [PATCH v1] system-dpdk: Add
Hi IIya,
Will update the v2 with both the changes.
Br
Amber
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, July 19, 2021 6:55 PM
> To: Amber, Kumar ; Ilya Maximets
> ; ovs-dev@openvswitch.org
> Cc: Stokes, Ian
> Subject: Re: [PATCH v1] tests: fix py
Hi llya,
Pls find my comments inline.
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, July 19, 2021 4:51 PM
> To: Amber, Kumar ; Ilya Maximets
> ; ovs-dev@openvswitch.org
> Cc: Stokes, Ian
> Subject: Re: [PATCH v1] tests: fix python2 module not find er
Hi llya,
Pls find the comments inline.
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, July 19, 2021 4:07 PM
> To: Ilya Maximets ; Amber, Kumar
> ; ovs-dev@openvswitch.org
> Cc: Stokes, Ian
> Subject: Re: [PATCH v1] tests: fix python2 module not find err
rue)
NameError: name 'PcapWriter' is not defined
Is this ohk ?
Regards
Amber
> -Original Message-
> From: Ilya Maximets
> Sent: Saturday, July 17, 2021 12:21 AM
> To: Amber, Kumar ; ovs-dev@openvswitch.org
> Cc: i.maxim...@ovn.org; Stokes, Ian
> Subject: Re: [PATCH
1 2:52 PM
> To: Stokes, Ian
> Cc: Flavio Leitner ; Amber, Kumar
> ; ovs-dev@openvswitch.org; i.maxim...@ovn.org;
> Van Haaren, Harry ; Ferriter, Cian
>
> Subject: Re: [PATCH v14 10/11] dpif-netdev/mfex: Add AVX512 based optimized
> miniflow extract
>
>
>
> O
Hi Flavio,
> -Original Message-
> From: Flavio Leitner
> Sent: Thursday, July 15, 2021 8:28 PM
> To: Eelco Chaudron
> Cc: Amber, Kumar ; ovs-dev@openvswitch.org;
> i.maxim...@ovn.org; Van Haaren, Harry ;
> Ferriter, Cian ; Stokes, Ian
> Subject: Re: [PATCH v13
Hi Eelco,
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday, July 15, 2021 1:38 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
> Subject: Re: [v12
Hi Eelco,
Yeah I missed one Comments below but all have been fixed waiting for more
reviews on this patch before sending new one.
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 14, 2021 8:43 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f.
Hi Eelco,
From: Eelco Chaudron
Sent: Wednesday, July 14, 2021 8:26 PM
To: Amber, Kumar
Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van Haaren,
Harry ; Ferriter, Cian ;
Stokes, Ian
Subject: Re: [v12 07/11] test/sytem-dpdk: Add unit test for mfex autovalidator
Hi Eelco,
The requested changes for the rework of MFEX-set commands are now available in
v12
Br Amber
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 14, 2021 4:04 PM
> To: Van Haaren, Harry
> Cc: Amber, Kumar ; ovs-dev@openvswitch.org;
>
Hi Eelco,
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 14, 2021 4:21 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
> Subject: Re: [v11
Hi Eelco,
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 14, 2021 4:08 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
> Subject: Re: [v11 07/
Hi Eelco,
> > +
> > +AT_SKIP_IF([! ovs-appctl dpif-netdev/miniflow-parser-get | sed 1,4d |
> > +grep -v "not available"], [], [dnl
> > +])
>
> Please, if you make changes, test them, as this has never worked, as you
> changed this to True/False.
> Here is a working example:
>
> AT_SKIP_IF([!
Hi Eelco,
Fixed the minor typos in v11
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, July 13, 2021 5:51 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
Hi Eelco
Added the requested feature in v11.
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, July 13, 2021 5:50 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stoke
.
And again, Thank you for all the valuable feedbacks and Comments
BR
Amber
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, July 13, 2021 7:28 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harr
Thanks Flavio
> -Original Message-
> From: Flavio Leitner
> Sent: Wednesday, July 14, 2021 2:03 AM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org
> Subject: Re: [ovs-dev] [v5] dpif/dpcls: limit count subtable search info logs
>
> On Tue, Jul 13, 2021 at
Done and added the ack
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, July 13, 2021 3:18 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
> Subje
Hi Eelco,
Fixed both and hence keeping the Ack
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, July 13, 2021 2:58 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; S
Hi Eelco,
Fixed
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, July 13, 2021 3:04 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
> Subject: Re: [v10
Hi Eelco,
Done
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, July 13, 2021 3:08 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
> Subject: Re: [v10
Hi Eelco,
Pls find my replies and should I add your ack after fixing those if those are
the last ones
> > +
> > +miniflow_extract_func
> > +dp_mfex_impl_get_default(void)
> > +{
> > +return default_mfex_func;
>
> This is still not atomic, you need an atomic_read_relaxed() here.
>
Yes
Hi Eelco,
Pls ignore the comments on check-patch error for python query I have fixed all
of them will be there in v11.
> -Original Message-
> From: Amber, Kumar
> Sent: Tuesday, July 13, 2021 2:10 PM
> To: 'Eelco Chaudron'
> Cc: ovs-dev@openvswitch.org; f...@sysclo
Hi Eelco,
Thanks I didn’t knew about his file .
I will fix them
> I opened the below python file in emacs and got tons of flake warnings.
> Looking at the makefile, I noticed you forgot to add it to the flake list.
> Please make the following modification:
>
> diff --git a/tests/automake.mk
Hi Eelco,
Thanks for the typo and added you Ack.
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, July 13, 2021 1:34 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; S
Hi Eelco,
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, July 13, 2021 1:15 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
> Subject: Re: [v9 08/12]
Hi Eelco,
Pls find my comments inline.
> -Original Message-
> From: Eelco Chaudron
> Sent: Monday, July 12, 2021 9:17 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
Hi Eelco,
Fixed all and reworked default.
> -Original Message-
> From: Eelco Chaudron
> Sent: Monday, July 12, 2021 6:50 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ia
1 - 100 of 163 matches
Mail list logo
