On Fri, Oct 20, 2023 at 8:40 AM Simon Horman wrote:
> On Thu, Oct 19, 2023 at 09:00:39AM -0400, Ihar Hrachyshka wrote:
> > On 10/19/23 7:14 AM, Simon Horman wrote:
> > > On Thu, Oct 19, 2023 at 02:57:26AM +0000, Ihar Hrachyshka wrote:
> > > > The command reads
On Thu, Oct 19, 2023 at 6:29 PM Ilya Maximets wrote:
> On 10/19/23 16:11, Ihar Hrachyshka wrote:
> > The command reads a flow string and an optional additional payload on
> > stdin and produces a hex-string representation of the corresponding
> > frame on stdout. It
observed frames against.
As an example of the tool use, a single test case is converted to it.
The test uses both normal and --bad-csum behavior of the tool,
confirming it works as advertised.
Signed-off-by: Ihar Hrachyshka
---
v1: - initial version.
v2: - convert from appctl to ovstest.
- add
On 10/19/23 7:14 AM, Simon Horman wrote:
On Thu, Oct 19, 2023 at 02:57:26AM +, Ihar Hrachyshka wrote:
The command reads a flow string and an optional additional payload on
stdin and produces a hex-string representation of the corresponding
frame on stdout. It may receive more than a single
observed frames against.
As an example of the tool use, a single test case is converted to it.
The test uses both normal and --bad-csum behavior of the tool,
confirming it works as advertised.
Signed-off-by: Ihar Hrachyshka
---
v1: - initial version.
v2: - convert from appctl to ovstest.
- add
On 10/18/23 9:34 PM, Ihar Hrachyshka wrote:
Yes. But also - this revealed a bug in ds_put_hex, where the first
byte is NOT converted to two hex characters, but to one only. See the
v2 series that includes the patch to fix the issue in ds_put_hex. That
said, I wonder if this is "safe"
On 10/13/23 6:11 AM, Ilya Maximets wrote:
On 10/10/23 22:44, Ihar Hrachyshka wrote:
The command receives a flow string and an optional additional payload
and produces a hex-string representation of the corresponding frame.
The command is datapath-independent and may be useful in tests, where
I've reviewed the series. Most of the patches are good to go, but 1)
HAVE_SCAPY macro should be applied and 2) see replies to some of the
patches with suggestions. Let me know if this was helpful.
Ihar
On Tue, Oct 10, 2023 at 8:37 PM Ihar Hrachyshka wrote:
> Thanks a lot for the series
On Tue, Oct 10, 2023 at 4:34 PM Mark Michelson wrote:
> ...passthru=true, ND/NA responder disabled.
>
> Note that in order to be able to get the solicited node multicast
> address, we need access to the socket library. This commit imports the
>
Would scapy.utils6.in6_getLinkScopedMcastAddr
On Tue, Oct 10, 2023 at 4:34 PM Mark Michelson wrote:
> This test is slower than it used to be since some of the test_ip calls
> that were backgrounded (with '&') cannot do this anymore. This is
> because there is a race condition with starting the scapy server when
> the calls are backgrounded.
On Tue, Oct 10, 2023 at 4:34 PM Mark Michelson wrote:
> ...passthru=true, ARP responder disabled
>
> Execution time: 2.466s
> Execution time on "main" branch: 1.751s
>
> Signed-off-by: Mark Michelson
> ---
> tests/ovn.at | 13 -
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
>
Thanks, all good.
Reviewed-By: Ihar Hrachyshka
On Wed, Oct 11, 2023 at 9:23 AM Dumitru Ceara wrote:
> Simulated chassis are added with ovn_attach(), ovn_az_attach() and
> start_virtual_controller(). Wait for ovn-controllers to register in the
> Southbound (create their Encap recor
On Tue, Oct 10, 2023 at 4:44 PM Ihar Hrachyshka wrote:
> This is a canary test case transformation to validate hexify usefulness.
> The test case was chosen as one that relies on hardcoded frames.
>
> Signed-off-by: Ihar Hrachyshka
> ---
> tests/d
Thanks a lot for the series! I will review it later in more detail, but for
now - a general comment for all (?) of them: right now we have to tag all
scapy tests with the `AT_SKIP_IF([test $HAVE_SCAPY = no])` macro.
(Note: I think this macro should go away and we should just assume scapy is
-off-by: Ihar Hrachyshka
---
ofproto/ofproto-dpif-trace.c | 70
ofproto/ofproto-unixctl.man | 36 ++-
tests/ofproto-dpif.at| 45 +++
3 files changed, 150 insertions(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif
This is a canary test case transformation to validate hexify usefulness.
The test case was chosen as one that relies on hardcoded frames.
Signed-off-by: Ihar Hrachyshka
---
tests/dpif-netdev.at | 42 ++
1 file changed, 18 insertions(+), 24 deletions
Packet cloning is relevant to multichassis ports only, so the message
made no sense for single chassis ports with no additional_chassis.
Even for multichassis ports, this part of the message is redundant and
confusing. It's better to remove it.
Signed-off-by: Ihar Hrachyshka
---
controller
On Wed, Sep 27, 2023 at 7:16 AM Dumitru Ceara wrote:
> On 9/26/23 19:26, Mark Michelson wrote:
> >
> > 2) I don't think a controller action is necessary. The controller action
> > sets some registers and then resubmits to table 40 or 41. I think this
> > could be done directly in OpenFlow
oto (File exists)
```
Signed-off-by: Ihar Hrachyshka
---
controller/ovn-controller.8.xml | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/controller/ovn-controller.8.xml b/controller/ovn-controller.8.xml
index 7b4100592..0b9641045 100644
--- a/controller/ovn-control
+1 to the idea, and I'd recommend having someone take public notes during
the calls. If the slot will fit my schedule, I can take this role unless
someone else is willing to do it.
Ihar
On Thu, Sep 21, 2023 at 11:25 AM Dumitru Ceara wrote:
> Hi all,
>
> As you probably know and as the ovn.org
This fixes make clean removing the daemon file because of the mechanics
of pycov make target.
Signed-off-by: Ihar Hrachyshka
---
tests/automake.mk | 2 +-
tests/ovn-macros.at | 2 +-
tests/{scapy-server => scapy-server.py} | 0
3 files changed
, Aug 29, 2023 at 10:18 AM Ilya Maximets wrote:
> On 8/25/23 18:50, Ihar Hrachyshka wrote:
> > The daemon life cycle spans over the whole test case life time, which
> > significantly speeds up test cases that rely on fmt_pkt for packet byte
> > representations.
> >
and pid files on suite exit (and not
on test case exit.)
Signed-off-by: Ihar Hrachyshka
unixctl impl
---
tests/automake.mk | 3 +-
tests/ovn-macros.at | 16 ---
tests/scapy-server | 69 +
3 files changed, 83 insertions(+), 5 deletions
RFC 4861 (Neighbor Discovery for IP version 6) requires that Hop Limit
is set to 255, but the flows we generated for 135 and 136 erroneously
used 225.
Fixes: 8cab00bdb581 ("ovn-controller: Add OF rules for port security.")
Signed-off-by: Ihar Hrachyshka
---
controller/lflow.c | 6 +++
and pid files on suite exit (and not
on test case exit.)
Signed-off-by: Ihar Hrachyshka
---
tests/automake.mk | 1 +
tests/ovn-macros.at | 27 ++--
tests/scapy_server.py | 100 ++
3 files changed, 124 insertions(+), 4 deletions(-)
create mode
Yes. We also have a bit of a mess in openstack upstream gates where we
committed some stateless security groups test scenarios that rely on a bug
fix that is in the non-released version of the branch. (And it turned out
that our initial attempt to adjust deployment scripts to pull a git commit
Reviewed-By: Ihar Hrachyshka
+1. Removing IHAR from OVN? Long overdue. :)
On Thu, Jul 13, 2023 at 11:30 AM Dumitru Ceara wrote:
> Remove what seems to be an accidental test debug echo command.
>
> Fixes: ab7b0eb8ca05 ("Add connectivity test for 2 controllers on the same
> ho
On Fri, Jun 30, 2023 at 3:31 AM Frode Nordahl
wrote:
> Hello all,
>
> On Tue, May 30, 2023 at 5:16 PM Felix Huettner
> wrote:
> >
> > Hi Dumitru,
> >
> > On Fri, May 26, 2023 at 01:30:54PM +0200, Dumitru Ceara wrote:
> > > On 5/24/23 09:37, Felix Huettner wrote:
> > > > Hi everyone,
> > >
> > >
This thread is to discuss improvements that would allow OVN (and maybe
OVS?) to adopt fmt_pkt (frontend to scapy packet constructor) in the test
suite.
(For those not aware of what it is, please consult this commit:
https://github.com/ovn-org/ovn/commit/d8c0d3ae4f3a293737d662a865761235ed9ea1cf
Thanks for the patch, and sorry for missing before that we could macro it
instead.
You should also update ovn-architechture.xml that was modified in patches
4/5 and 5/5 of the original series. Thanks!
On Wed, Jun 7, 2023 at 7:02 AM Dumitru Ceara wrote:
> Make it alias
Thank you Ales!
Acked-By: Ihar Hrachyshka
On Wed, Jun 7, 2023 at 1:58 AM Ales Musil wrote:
> Skip GARP packet with link-local address being advertised
> when "always_learn_from_arp_request=false", this should
> prevent huge grow of MAC Binding table. To keep the option
>
On Tue, May 30, 2023 at 6:00 AM Ales Musil wrote:
> Skip GARP packet with link-local address being advertised
> when "always_learn_from_arp_request=false", this should
> prevent huge grow of MAC Binding table. To keep the option
> consistent overwrite the previous MAC with LLA if it was
>
On Tue, May 30, 2023 at 5:53 PM Ihar Hrachyshka wrote:
>
> On Tue, May 30, 2023 at 5:06 PM Ihar Hrachyshka wrote:
> >
> > On Tue, May 30, 2023 at 2:28 PM Mark Michelson wrote:
> > >
> > > Thanks Ihar and Dumitru.
> > >
> > > I appli
old table=37 becomes table=40).
Otherwise, no changes to existing tables and flows introduced.
Conflicts:
controller/lflow.h
controller/physical.c
tests/ovn-controller.at
tests/ovn.at
tests/system-ovn-kmod.at
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
This will be used in a later patch to calculate tunneling overhead for
effective path MTU.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
Signed-off-by: Mark Michelson
(cherry picked from commit 935034b4065b3ad052aa2b0d711254db53fcb938)
(cherry picked from commit
gh tunnels")
Conflicts:
NEWS
controller/physical.c
lib/ovn-util.h
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
Signed-off-by: Mark Michelson
(cherry picked from commit c519c9551b4d1f48d7ee64abfad2ac266ea83380)
(cherry picked from commit ee8992a1bb556195ec11b
This will be used in a later patch to calculate the effective interface
MTU after considering tunneling overhead.
NOTE: ideally, OVN would support Logical_Port MTU, in which case we
wouldn't have to track OVSDB for interfaces.
Conflicts:
controller/ovn-controller.c
Signed-off-by: Ihar
is "additional".
Fixes: fa8c591fa2a7 ("Support LSP:options:requested-chassis as a list")
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
Signed-off-by: Mark Michelson
(cherry picked from commit 23ffec7e22de97b67984acc6703d44f169dafb27)
(cherr
gh tunnels")
Conflicts:
NEWS
lib/ovn-util.h
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
Signed-off-by: Mark Michelson
(cherry picked from commit c519c9551b4d1f48d7ee64abfad2ac266ea83380)
(cherry picked from commit ee8992a1bb556195ec11b73fee0d08806afa48f5)
---
NE
old table=37 becomes table=40).
Otherwise, no changes to existing tables and flows introduced.
Conflicts:
tests/ovn-controller.at
tests/ovn.at
tests/system-ovn-kmod.at
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
Signed-off-by: Mark Michelson
(cherr
This will be used in a later patch to calculate tunneling overhead for
effective path MTU.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
Signed-off-by: Mark Michelson
(cherry picked from commit 935034b4065b3ad052aa2b0d711254db53fcb938)
(cherry picked from commit
is "additional".
Fixes: fa8c591fa2a7 ("Support LSP:options:requested-chassis as a list")
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
Signed-off-by: Mark Michelson
(cherry picked from commit 23ffec7e22de97b67984acc6703d44f169dafb27)
(cherr
This will be used in a later patch to calculate the effective interface
MTU after considering tunneling overhead.
NOTE: ideally, OVN would support Logical_Port MTU, in which case we
wouldn't have to track OVSDB for interfaces.
Conflicts:
controller/ovn-controller.c
Signed-off-by: Ihar
old table=37 becomes table=40).
Otherwise, no changes to existing tables and flows introduced.
Conflicts:
tests/ovn-controller.at
tests/ovn.at
tests/system-ovn-kmod.at
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
Signed-off-by: Mark Michelson
(cherr
gh tunnels")
Conflicts:
NEWS
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
Signed-off-by: Mark Michelson
(cherry picked from commit c519c9551b4d1f48d7ee64abfad2ac266ea83380)
---
NEWS | 6 +
controller/physical.c | 260 ++
This will be used in a later patch to calculate tunneling overhead for
effective path MTU.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
Signed-off-by: Mark Michelson
(cherry picked from commit 935034b4065b3ad052aa2b0d711254db53fcb938)
---
controller/local_data.c | 2 ++
controller
is "additional".
Fixes: fa8c591fa2a7 ("Support LSP:options:requested-chassis as a list")
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
Signed-off-by: Mark Michelson
(cherry picked from commit 23ffec7e22de97b67984acc6703d44f169dafb27)
---
control
This will be used in a later patch to calculate the effective interface
MTU after considering tunneling overhead.
NOTE: ideally, OVN would support Logical_Port MTU, in which case we
wouldn't have to track OVSDB for interfaces.
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
Signed-off
On Tue, May 30, 2023 at 5:06 PM Ihar Hrachyshka wrote:
>
> On Tue, May 30, 2023 at 2:28 PM Mark Michelson wrote:
> >
> > Thanks Ihar and Dumitru.
> >
> > I applied this series to main and branch-23.06. I encountered conflicts
> > when trying to apply this to b
.
Should I backport down to LTS (22.03)?
>
> Thanks,
> Mark Michelson
>
> On 5/23/23 17:55, Ihar Hrachyshka wrote:
> > This series fixes a non-optimal behavior with some multichassis ports.
> >
> > Specifically,
> >
> > - when a multichassis port belong
+1. Thanks Dumitru for cleaning it up!
Reviewed-By: Ihar Hrachyshka
On Tue, May 30, 2023 at 4:51 PM Dumitru Ceara wrote:
>
> Commit 549e8ccebca7 ("ovn-controller.c: Fix assertion failure during
> address set update.") added a new ovn-controller.at test and commit
>
old table=37 becomes table=40).
Otherwise, no changes to existing tables and flows introduced.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
---
controller/lflow.c | 4 +-
controller/lflow.h | 49 ---
controller/physical.c| 77 ++
controller/pinctrl
This will be used in a later patch to calculate the effective interface
MTU after considering tunneling overhead.
NOTE: ideally, OVN would support Logical_Port MTU, in which case we
wouldn't have to track OVSDB for interfaces.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c
ill make them switch back to the "usual"
MTU.
Among other scenarios, this patch helps to maintain existing services
working during live migration of a VM, if multichassis ports are used.
(E.g. in OpenStack Nueutron.)
Fixes: 7084cf437421 ("Always funnel multichassis port traffic thr
is "additional".
Fixes: fa8c591fa2a7 ("Support LSP:options:requested-chassis as a list")
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
---
controller/binding.c | 46 ++
controller/binding.h | 4
control
- update more tests in ovn-controller.at to reflect new table
numbers.
v7: - remove ovs submodule bump that creeped in by mistake.
---
Ihar Hrachyshka (5):
Track ip version of tunnel in chassis_tunnel struct
Track interface MTU in if-status-mgr
if-status: track interfaces for additional chassi
This will be used in a later patch to calculate tunneling overhead for
effective path MTU.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
---
controller/local_data.c | 2 ++
controller/local_data.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/controller/local_data.c b
old table=37 becomes table=40).
Otherwise, no changes to existing tables and flows introduced.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
---
controller/lflow.c | 4 +-
controller/lflow.h | 49 ---
controller/physical.c| 77 ++
controller/pinctrl
ill make them switch back to the "usual"
MTU.
Among other scenarios, this patch helps to maintain existing services
working during live migration of a VM, if multichassis ports are used.
(E.g. in OpenStack Nueutron.)
Fixes: 7084cf437421 ("Always funnel multichassis port traffic thr
This will be used in a later patch to calculate the effective interface
MTU after considering tunneling overhead.
NOTE: ideally, OVN would support Logical_Port MTU, in which case we
wouldn't have to track OVSDB for interfaces.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c
- update more tests in ovn-controller.at to reflect new table
numbers.
---
Ihar Hrachyshka (5):
Track ip version of tunnel in chassis_tunnel struct
Track interface MTU in if-status-mgr
if-status: track interfaces for additional chassis
Add new egress tables to accommodate for too-big packets
is "additional".
Fixes: fa8c591fa2a7 ("Support LSP:options:requested-chassis as a list")
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
---
controller/binding.c | 46 ++
controller/binding.h | 4
control
This will be used in a later patch to calculate tunneling overhead for
effective path MTU.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
---
controller/local_data.c | 2 ++
controller/local_data.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/controller/local_data.c b
On Mon, May 22, 2023 at 8:00 AM Dumitru Ceara wrote:
>
> On 5/17/23 21:34, Ihar Hrachyshka wrote:
> > On Tue, May 16, 2023 at 9:40 AM Dumitru Ceara wrote:
> >>
> >> On 5/3/23 22:13, Ihar Hrachyshka wrote:
> >>> This will be used in a later patch to c
old table=37 becomes table=40).
Otherwise, no changes to existing tables and flows introduced.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
---
controller/lflow.c | 4 +-
controller/lflow.h | 49 ---
controller/physical.c| 77 +++
controller/pinctrl
This will be used in a later patch to calculate the effective interface
MTU after considering tunneling overhead.
NOTE: ideally, OVN would support Logical_Port MTU, in which case we
wouldn't have to track OVSDB for interfaces.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c
ill make them switch back to the "usual"
MTU.
Among other scenarios, this patch helps to maintain existing services
working during live migration of a VM, if multichassis ports are used.
(E.g. in OpenStack Nueutron.)
Fixes: 7084cf437421 ("Always funnel multichassis port traffic thr
is "additional".
Fixes: fa8c591fa2a7 ("Support LSP:options:requested-chassis as a list")
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
---
controller/binding.c | 46 ++
controller/binding.h | 4
control
ers.
- if-status-mgr: remove set_mtu public function, instead other
modules should call to if_status_mgr_iface_update. This allows the
callers to not care which particular fields if-status-mgr would
like to persist from the OVS record, keeping concerns separated.
---
Ihar Hrac
This will be used in a later patch to calculate tunneling overhead for
effective path MTU.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
---
controller/local_data.c | 2 ++
controller/local_data.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/controller/local_data.c b
On Mon, May 22, 2023 at 9:55 AM Dumitru Ceara wrote:
>
> On 5/22/23 15:42, Ihar Hrachyshka wrote:
> > On Mon, May 22, 2023 at 7:55 AM Dumitru Ceara wrote:
> >>
> >> On 5/17/23 18:46, Ihar Hrachyshka wrote:
> >>> Thank you Dumitru! See below.
> >
On Mon, May 22, 2023 at 7:55 AM Dumitru Ceara wrote:
>
> On 5/17/23 18:46, Ihar Hrachyshka wrote:
> > Thank you Dumitru! See below.
> >
> > On Tue, May 16, 2023 at 9:41 AM Dumitru Ceara wrote:
> >> I'm not necessarily rejecting this change. I just wanted to brin
old table=37 becomes table=40).
Otherwise, no changes to existing tables and flows introduced.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
---
controller/lflow.c | 4 +-
controller/lflow.h | 49 ---
controller/physical.c| 77 +++
controller/pinctrl
ill make them switch back to the "usual"
MTU.
Among other scenarios, this patch helps to maintain existing services
working during live migration of a VM, if multichassis ports are used.
(E.g. in OpenStack Nueutron.)
Fixes: 7084cf437421 ("Always funnel multichassis port traffic thr
This will be used in a later patch to calculate tunneling overhead for
effective path MTU.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
---
controller/local_data.c | 2 ++
controller/local_data.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/controller/local_data.c b
is "additional".
Fixes: fa8c591fa2a7 ("Support LSP:options:requested-chassis as a list")
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
---
controller/binding.c | 46 ++
controller/binding.h | 4
control
This will be used in a later patch to calculate the effective interface
MTU after considering tunneling overhead.
NOTE: ideally, OVN would support Logical_Port MTU, in which case we
wouldn't have to track OVSDB for interfaces.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c| 4
based to latest main;
- updated acks based on latest review comments.
v4: - fix compilation issue in the middle of the series due to previous
commit rearrangement.
---
Ihar Hrachyshka (5):
Track ip version of tunnel in chassis_tunnel struct
Track interface MTU in if-status-mgr
if
is "additional".
Fixes: fa8c591fa2a7 ("Support LSP:options:requested-chassis as a list")
Signed-off-by: Ihar Hrachyshka
Acked-by: Dumitru Ceara
---
controller/binding.c | 46 ++
controller/binding.h | 4
control
old table=37 becomes table=40).
Otherwise, no changes to existing tables and flows introduced.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
---
controller/lflow.c | 4 +-
controller/lflow.h | 49 ---
controller/physical.c| 77 +++
controller/pinctrl
ill make them switch back to the "usual"
MTU.
Among other scenarios, this patch helps to maintain existing services
working during live migration of a VM, if multichassis ports are used.
(E.g. in OpenStack Nueutron.)
Fixes: 7084cf437421 ("Always funnel multichassis port traffic thr
This will be used in a later patch to calculate the effective interface
MTU after considering tunneling overhead.
NOTE: ideally, OVN would support Logical_Port MTU, in which case we
wouldn't have to track OVSDB for interfaces.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c| 4
based to latest main;
- updated acks based on latest review comments.
---
Ihar Hrachyshka (5):
Track ip version of tunnel in chassis_tunnel struct
Track interface MTU in if-status-mgr
if-status: track interfaces for additional chassis
Add new egress tables to accommodate for too-b
This will be used in a later patch to calculate tunneling overhead for
effective path MTU.
Acked-by: Dumitru Ceara
Signed-off-by: Ihar Hrachyshka
---
controller/local_data.c | 2 ++
controller/local_data.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/controller/local_data.c b
On Tue, May 16, 2023 at 9:41 AM Dumitru Ceara wrote:
>
> On 5/3/23 22:13, Ihar Hrachyshka wrote:
> > Make ICMP Path MTU Discovery flows in table=38 react to underlying
> > interface MTU update.
> >
> > NOTE: ideally, OVN would support Logical_Port MTU, in which case
On Tue, May 16, 2023 at 9:40 AM Dumitru Ceara wrote:
>
> On 5/3/23 22:13, Ihar Hrachyshka wrote:
> > This will be used in a later patch to calculate the effective interface
> > MTU after considering tunneling overhead.
> >
> > Signed-off-by: Ihar Hrachyshka
>
7084cf437421 ("Always funnel multichassis port traffic through
> > tunnels")
> >
> > Signed-off-by: Ihar Hrachyshka
> > ---
> > NEWS| 6 +
> > controller/ovn-controller.c | 3 +
> > controller/physical.c | 293 +++
Path MTU discovery for multichassis ports on localnet attached
switches: https://patchwork.ozlabs.org/project/ovn/list/?series=353374
As stated elsewhere, I consider it a bug fix to an undesired behavior
of the previously added feature (albeit a sizable one, even if it's
well isolated from the
Thanks Mark! I will update the series according to your suggestions
after more reviews land to the series.
On Wed, May 3, 2023 at 4:55 PM Mark Michelson wrote:
>
> On 5/2/23 21:12, Ihar Hrachyshka wrote:
> > When a multichassis port belongs to a switch with a localnet port,
Most of the documentation was updated when the feature was implemented,
but these two places were omitted by mistake.
Fixes: b07f1bc3d068 ("Add VXLAN support for non-VTEP datapath bindings")
Signed-off-by: Ihar Hrachyshka
---
controller/ovn-controller.8.xml | 10 --
old table=37 becomes table=40).
Otherwise, no changes to existing tables and flows introduced.
Signed-off-by: Ihar Hrachyshka
---
controller/lflow.c | 4 +-
controller/lflow.h | 49 ---
controller/physical.c| 77 +++
controller/pinctrl.c | 8 +-
ovn-archit
ill make them switch back to the "usual"
MTU.
Among other scenarios, this patch helps to maintain existing services
working during live migration of a VM, if multichassis ports are used.
(E.g. in OpenStack Nueutron.)
Fixes: 7084cf437421 ("Always funnel multichassis port traffic thr
is
best effort and doesn't handle all scenarios. (E.g. a scenario where
MTUs are not changed consistently for all switch interfaces across all
chassis.)
Signed-off-by: Ihar Hrachyshka
---
controller/if-status.c | 23 +++-
controller/if-status.h | 3 ++
controller/ovn
This will be used in a later patch to calculate the effective interface
MTU after considering tunneling overhead.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 4 ++--
controller/if-status.c | 31 +++
controller/if-status.h | 3 +++
3 files changed
is "additional".
Fixes: fa8c591fa2a7 ("Support LSP:options:requested-chassis as a list")
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 46 ++
controller/binding.h | 4
controller/if-status.c | 8 ++--
control
;
- added a NEWS entry for patch 6/7 that implements the core of the
feature;
- rebased to latest main.
---
Ihar Hrachyshka (6):
Track ip version of tunnel in chassis_tunnel struct
Track interface MTU in if-status-mgr
if-status: track interfaces for additional chassis
Add new
This will be used in a later patch to calculate tunneling overhead for
effective path MTU.
Signed-off-by: Ihar Hrachyshka
---
controller/local_data.c | 2 ++
controller/local_data.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/controller/local_data.c b/controller/local_data.c
index
old table=37 becomes table=40).
Otherwise, no changes to existing tables and flows introduced.
Signed-off-by: Ihar Hrachyshka
---
controller/lflow.c | 4 +-
controller/lflow.h | 49
controller/physical.c | 77 +++-
controller/pinctrl.c| 8 +-
ovn-archi
is
best effort and doesn't handle all scenarios. (E.g. a scenario where
MTUs are not changed consistently for all switch interfaces across all
chassis.)
Signed-off-by: Ihar Hrachyshka
---
controller/if-status.c | 23 +++-
controller/if-status.h | 3 ++
controller/ovn
ill make them switch back to the "usual"
MTU.
Among other scenarios, this patch helps to maintain existing services
working during live migration of a VM, if multichassis ports are used.
(E.g. in OpenStack Nueutron.)
Fixes: 7084cf437421 ("Always funnel multichassis port traffic thr
101 - 200 of 751 matches
Mail list logo
