support, and additional filesystem access.
Aaron Conole (2):
soexpand: enable dpdk specific blocks
selinux: enable dpdk permissions
Makefile.am | 6 +-
build-aux/soexpand.pl| 25 ++---
selinux/automake.mk | 1 +
selinux
as template file to be
built up based on options passed to configure.
Signed-off-by: Aaron Conole
---
selinux/automake.mk | 1 +
selinux/openvswitch-custom.te| 16
selinux/openvswitch-custom.te.in | 40
3 files changed, 41
-processor. For those
files which are not, the soexpand utility grows a new feature to simply
filter out those stanzas which aren't dpdk relevant.
Signed-off-by: Aaron Conole
---
Makefile.am | 6 +-
build-aux/soexpand.pl | 25 ++---
2 files changed, 27 inser
Aaron Conole writes:
> Aaron Conole writes:
>> Daniele Di Proietto writes:
>>> On 26/01/2017 12:35, "Ansis Atteka" wrote:
>>>>On 26 January 2017 at 21:24, Aaron Conole wrote:
>>>>Daniele Di Proietto writes:
>>>>> On 25/
Hi Bhanu,
Bhanuprakash Bodireddy writes:
> This patch is aimed at achieving Fastpath Service Assurance in
> OVS-DPDK deployments. This commit adds support for monitoring the packet
> processing cores(pmd thread cores) by dispatching heartbeats at regular
> intervals. Incase of heartbeat miss the
Bhanuprakash Bodireddy writes:
> This commit initializes the keepalive subsystem and spawns keepalive
> thread that wakes up at regular intervals to update the timestamp and
> status of pmd cores in shared memory.
>
> This patch implements POSIX shared memory object for storing the events
> that
Bhanuprakash Bodireddy writes:
> Introduce helper functions in 'dpdk' module that are needed for
> keepalive functionality. Also add dummy functions in 'dpdk-stub' module
> that are needed when DPDK is not available.
>
> Signed-off-by: Bhanuprakash Bodireddy
> ---
I think it's better to add hel
Bhanuprakash Bodireddy writes:
> Implement function to retrieve the process status. This will be used by
> Keepalive monitoring thread for detecting false alarms.
>
> Signed-off-by: Bhanuprakash Bodireddy
> ---
> lib/process.c | 60
> +++
Bhanuprakash Bodireddy writes:
> This will be used by KA framework that needs millisecond granularity.
>
> Signed-off-by: Bhanuprakash Bodireddy
> ---
Without this patch, builds starting at 3/7 will fail. That's pretty
bad. Please see my earlier comment about including helpers when they
are u
"Bodireddy, Bhanuprakash" writes:
>>Bhanuprakash Bodireddy writes:
>>
>>> This will be used by KA framework that needs millisecond granularity.
>>>
>>> Signed-off-by: Bhanuprakash Bodireddy
>>>
>>> ---
>>
>>Without this patch, builds starting at 3/7 will fail. That's pretty
>> bad. Please see
"Bodireddy, Bhanuprakash" writes:
> Thanks Aaron for reviewing this patch series. My comments inline.
>
>>
>>Hi Bhanu,
>>
>>Bhanuprakash Bodireddy writes:
>>
>>> This patch is aimed at achieving Fastpath Service Assurance in
>>> OVS-DPDK deployments. This commit adds support for monitoring the
"Bodireddy, Bhanuprakash" writes:
>>>
>>> +/*
>>> + * OVS Shared Memory structure
>>> + *
>>> + * The information in the shared memory block will be read by collectd.
>>> + * */
>>> +struct dpdk_keepalive_shm {
>>> +/* IPC semaphore. Posted when a core dies */
>>> +sem_t core_died;
>>> +
dpdk/detach' removed because not needed anymore.
>
> CC: Ciara Loftus
> Fixes: 55e075e65ef9 ("netdev-dpdk: Arbitrary 'dpdk' port naming")
> Fixes: 69876ed78611 ("netdev-dpdk: Add support for virtual DPDK PMDs (vdevs)")
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
cut off the arguments from this string before calling
> 'rte_eth_dev_get_port_by_name()' to avoid double attaching of
> the same device.
>
> CC: Ciara Loftus
> Fixes: 69876ed78611 ("netdev-dpdk: Add support for virtual DPDK PMDs (vdevs)")
> Signed-off-by: Ilya
dk functions where uint8_t expected.
>
> Such behaviour doesn't produce any issues, but it's better to
> use same type as in dpdk library for consistency.
>
> Also, magic number '-1' replaced with DPDK_ETH_PORT_ID_INVALID
> macro.
>
> Signed-off-by: Ilya Maxime
Hi Ansis,
Ansis Atteka writes:
> On 29 March 2017 at 12:25, Aaron Conole wrote:
>
> Thanks for doing this. I should have probably built OVS with your patch, but
> since my RHEL setup is down
> at the moment, then I will do that later. Anyway see my comments inline.
Thank you
Hi Mark,
Mark Kavanagh writes:
> TCP Segmentation Offload (TSO) is a feature which enables
> the TCP/IP network stack to delegate segmentation of a TCP
> segment to the NIC, thus saving compute resources.
>
> This commit adds support for TSO in the DPDK vHost-User backend,
> to OvS v2.6.1; this
"Kavanagh, Mark B" writes:
>>Hi Mark,
>>
>>Mark Kavanagh writes:
>>
>>> TCP Segmentation Offload (TSO) is a feature which enables
>>> the TCP/IP network stack to delegate segmentation of a TCP
>>> segment to the NIC, thus saving compute resources.
>>>
>>> This commit adds support for TSO in the
ere:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329600.html
Aaron Conole (2):
install-doc: suggest to use ovs-ctl for start/stop
lib/automake.mk: don't install runtime directories
Documentation/intro/install/dpdk.rst| 2 +-
Documentation/intro/install/g
start/stop the daemons.
The ovs-ctl script is already mentioned a bit in the install
doc, so this just reinforces its use.
Suggested-by: Ben Pfaff
Signed-off-by: Aaron Conole
---
Documentation/intro/install/dpdk.rst| 2 +-
Documentation/intro/install/general.rst | 36
Chandras
Signed-off-by: Aaron Conole
---
lib/automake.mk | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/automake.mk b/lib/automake.mk
index 62b2f38..faace79 100644
--- a/lib/automake.mk
+++ b/lib/automake.mk
@@ -534,10 +534,7 @@ EXTRA_DIST += build-aux/extract-ofp-msgs
INSTALL_DATA_LOCAL
Joe Stringer writes:
> On 21 March 2017 at 13:32, Aaron Conole wrote:
>> Signed-off-by: Aaron Conole
>> ---
>
> Hi Aaron, thanks for the patch. Feedback below, I can apply if you're
> happy with it.
LGTM, thanks!
>> lib/dpctl.man | 35 +++
Ben Pfaff writes:
> On Thu, Apr 13, 2017 at 01:51:29PM -0400, Aaron Conole wrote:
>> The install documentation guided users to manually start/stop
>> daemons. This is good information to have, but with the
>> existence of ovs-ctl, is probably not the best way to start
&g
ere:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329600.html
v1->v2:
* Discussion here:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/330783.html
* Modified install documentation to detail the location of ovs-ctl script
Aaron Conole (2):
install-doc: suggest to use ovs-
start/stop the daemons.
The ovs-ctl script is already mentioned a bit in the install
doc, so this just reinforces its use.
Suggested-by: Ben Pfaff
Signed-off-by: Aaron Conole
---
v1->v2:
* Added the location of ovs-ctl script
Documentation/intro/install/dpdk.rst| 3 ++-
Documentation/in
, whereas the runtime user desired may be openvswitch:openvswitch.
Since these directories are automatically created as part of the ovs-ctl
command, and with the correct user:group permissions, it makes sense to
delay creation until these directories are actually required.
Signed-off-by: Aaron
orted (for instance vfio), and it requires manual
intervention.
Fixes: 36af136b690c ("rhel-systemd: Delay shutting down the services")
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1397299
Suggested-by: Flavio Leitner
Signed-off-by: Aaron Conole
---
rhel/usr_lib_sys
common notation in
comments to mean 'raise to the power of', so ensure that it is not
accidentally flagged as well by adding a not-group populated with *.
Reported-by: Lance Richardson
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 3 ++-
1 file changed, 2 insertions(+),
Ben Pfaff writes:
> On Wed, Apr 19, 2017 at 05:42:58PM -0400, Aaron Conole wrote:
>> Lance pointed to a problem where scripts were incorrectly being flagged as
>> pointer spacing warnings. As an example, the text:
>>
>> --u*|-u)
>>
>> would flag
x27;hugetlbfs' are created
This is presented as RFC (v0, since it will likely need changes) for
initial feedback.
Aaron Conole (4):
rhel: allow arbitrary user:group
fedora: dynamically allocate ovs user
fedora: Also include the db lockfile
fedora: allow dpdk to also run as non-roo
After this commit, the fedora RPM will create the openvswitch user, from the
non-static pool, for use as an Open vSwitch user.
Signed-off-by: Aaron Conole
---
rhel/openvswitch-fedora.spec.in | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/rhel
efaults to
root:root, but can be overridden by changing the /etc/sysconfig/openvswitch
environment file.
Signed-off-by: Aaron Conole
---
rhel/usr_lib_systemd_system_ovs-vswitchd.service | 4
rhel/usr_lib_systemd_system_ovsdb-server.service | 5 +
will
be removed automatically. This means that if no extra files exist in
/etc/openvswitch, the whole directory will be removed from /etc/.
Signed-off-by: Aaron Conole
---
rhel/openvswitch-fedora.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/rhel/openvswitch-fedora.spec.in b/r
ever grows an uninit
/ reinit function, non-root ovs likely could never use it.
Signed-off-by: Aaron Conole
---
rhel/openvswitch-fedora.spec.in | 25
rhel/usr_lib_systemd_system_ovs-vswitchd.service | 2 ++
2 files changed, 27 insertions(+)
diff --git a
most editors support out of the box. And while I was in
there, I added pretty colors, because we all need some
color in our terminals.
Aaron Conole (7):
checkpatch: introduce a flexible framework
checkpatch: common print_line
checkpatch: move the checks to the framework
checkpatch: corr
plugging in checks very
quickly. Hook up the line-length test as an initial demonstration.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 51 -
1 file changed, 42 insertions(+), 9 deletions(-)
diff --git a/utilities/checkpatch.py b
With the new framework, print_line can be moved out to the checks
framework.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index ddee7c8..1504668 100755
All of the checks are now part of the new 'check' framework.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 39 +--
1 file changed, 25 insertions(+), 14 deletions(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
ind
s are
omitted from the text stream during processing.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index d567933..22afbe4 100755
--- a/utilities/checkpatch.py
+++ b/util
Other utilities (notoriously the linux kernel's checkpatch.pl) have a more
standardized form for printing file and lines. With this change, the
template used to print gains two enhancements:
1. Color
2. Conformance with the kernel's version of checkpatch.pl
Signed-off-by: Aa
Filenames that come from the hunks match include the git-ified 'b/'
prefix, which makes jumping to the error file that much harder. This
patch corrects that by simply skipping those bytes.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 inser
A common way of expressing 'raise to the power of' when authoring
comments uses **. This is currently getting caught by the pointer
spacing warning. So, catch it here.
Reported-by: Lance Richardson
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1
Aaron Conole writes:
> The following series refactors checkpatch to make
> file-type specific checks. This lets checkpatch have
> finer grained checks, and should reduce the amount
> of false positives.
>
> Additionally, I've incorporated an older request to print
>
most editors support out of the box. And while I was in
there, I added pretty colors, because we all need some
color in our terminals.
v2:
* Fix flake8 errors
* Remove python from the line-length errors blacklist
Aaron Conole (8):
checkpatch: introduce a flexible framework
checkpatch: c
plugging in checks very
quickly. Hook up the line-length test as an initial demonstration.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 51 -
1 file changed, 42 insertions(+), 9 deletions(-)
diff --git a/utilities/checkpatch.py b
With the new framework, print_line can be moved out to the checks
framework.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index ddee7c8..14d4f53 100755
All of the checks are now part of the new 'check' framework.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 39 +--
1 file changed, 25 insertions(+), 14 deletions(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
ind
s are
omitted from the text stream during processing.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index 119a996..b1e70e1 100755
--- a/utilities/checkpatch.py
+++ b/util
Other utilities (notoriously the linux kernel's checkpatch.pl) have a more
standardized form for printing file and lines. With this change, the
template used to print gains two enhancements:
1. Color
2. Conformance with the kernel's version of checkpatch.pl
Signed-off-by: Aa
Filenames that come from the hunks match include the git-ified 'b/'
prefix, which makes jumping to the error file that much harder. This
patch corrects that by simply skipping those bytes.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 inser
Even though the build system flags this error, it is better for
checkpatch to flag it early. It doesn't cost anything to do so.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/utilities/checkpatch.py b/util
A common way of expressing 'raise to the power of' when authoring
comments uses **. This is currently getting caught by the pointer
spacing warning. So, catch it here.
Reported-by: Lance Richardson
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1
Hi Bhanu,
Bhanuprakash Bodireddy writes:
> This patch is aimed at achieving Fastpath Service Assurance in
> OVS-DPDK deployments. This commit adds support for monitoring the packet
> processing cores(pmd thread cores) by dispatching heartbeats at regular
> intervals. Incase of heartbeat miss the
Lance Richardson writes:
>> From: "Russell Bryant"
>> To: "Ben Pfaff"
>> Cc: "ovs dev" , "Flavio Leitner"
>> , "Lance Richardson" ,
>> "Aaron Conole"
>> Sent: Thursday, 27 April, 2017 3:04:43 PM
Hi Joe,
Some stream-of-consciousness thoughts follow, sorry if it's a bit
disconnected.
Joe Stringer writes:
> I have recently been looking into backporting a fix for variable-length
> metadata fields from master to branch-2.7. Unfortunately, the fix makes
> several
> changes to libopenvswitch
Greetings dev,
I have whipped up a quick little utility (find below), that I've done a
bit of debugging with and it seems to have made working with dump-flows
from ovs-ofctl a little easier to use.
If you think it's worthwhile to add to the repository, I'll submit it
formally. We were using it w
Ben Pfaff writes:
> On Mon, Apr 17, 2017 at 01:59:49PM -0400, Aaron Conole wrote:
>> The install documentation guided users to manually start/stop
>> daemons. This is good information to have, but with the
>> existence of ovs-ctl, is probably not the best way to start
&g
Ben Pfaff writes:
> On Wed, Apr 26, 2017 at 11:54:52AM -0400, Aaron Conole wrote:
>> The following series refactors checkpatch to make
>> file-type specific checks. This lets checkpatch have
>> finer grained checks, and should reduce the amount
>> of false positives
most editors support out of the box. And while I was in
there, I added pretty colors, because we all need some
color in our terminals.
v2:
* Fix flake8 errors
* Remove python from the line-length errors blacklist
v3:
* Fix the remaining flake8 errors (make flake8-check
passes on my system)
plugging in checks very
quickly. Hook up the line-length test as an initial demonstration.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 51 -
1 file changed, 42 insertions(+), 9 deletions(-)
diff --git a/utilities/checkpatch.py b
With the new framework, print_line can be moved out to the checks
framework.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index 4ee5670..239ce69 100755
All of the checks are now part of the new 'check' framework.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 41 ++---
1 file changed, 26 insertions(+), 15 deletions(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
ind
s are
omitted from the text stream during processing.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index 68c4156..2088865 100755
--- a/utilities/checkpatch.py
+++ b/util
Other utilities (notoriously the linux kernel's checkpatch.pl) have a more
standardized form for printing file and lines. With this change, the
template used to print gains two enhancements:
1. Color
2. Conformance with the kernel's version of checkpatch.pl
Signed-off-by: Aa
Filenames that come from the hunks match include the git-ified 'b/'
prefix, which makes jumping to the error file that much harder. This
patch corrects that by simply skipping those bytes.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 inser
A common way of expressing 'raise to the power of' when authoring
comments uses **. This is currently getting caught by the pointer
spacing warning. So, catch it here.
Reported-by: Lance Richardson
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1
Ben Pfaff writes:
> On Mon, May 01, 2017 at 03:44:37PM -0400, Aaron Conole wrote:
>> Developers wishing to add checks to checkpatch sift through an adhoc mess,
>> currently. The process goes something like:
>> 1. Figure out what to test in the patch
>> 2. Write some
plugging in checks very
quickly. Hook up the line-length test as an initial demonstration.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 51 -
1 file changed, 42 insertions(+), 9 deletions(-)
diff --git a/utilities/checkpatch.py b
* Fix a python 3 lambda syntax error.
Aaron Conole (7):
checkpatch: introduce a flexible framework
checkpatch: common print_line
checkpatch: move the checks to the framework
checkpatch: correct a parsing issue
checkpatch: print conformance
checkpatch: filename from hunks fix
checkpatch
With the new framework, print_line can be moved out to the checks
framework.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index b3b833b..30c0a3e 100755
All of the checks are now part of the new 'check' framework.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 41 ++---
1 file changed, 26 insertions(+), 15 deletions(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
ind
s are
omitted from the text stream during processing.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index 9d4e469..9f8f30f 100755
--- a/utilities/checkpatch.py
+++ b/util
Other utilities (notoriously the linux kernel's checkpatch.pl) have a more
standardized form for printing file and lines. With this change, the
template used to print gains two enhancements:
1. Color
2. Conformance with the kernel's version of checkpatch.pl
Signed-off-by: Aa
Filenames that come from the hunks match include the git-ified 'b/'
prefix, which makes jumping to the error file that much harder. This
patch corrects that by simply skipping those bytes.
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1 inser
A common way of expressing 'raise to the power of' when authoring
comments uses **. This is currently getting caught by the pointer
spacing warning. So, catch it here.
Reported-by: Lance Richardson
Signed-off-by: Aaron Conole
---
utilities/checkpatch.py | 2 +-
1 file changed, 1
Ben Pfaff writes:
> On Mon, May 01, 2017 at 04:14:09PM -0400, Aaron Conole wrote:
>> A common way of expressing 'raise to the power of' when authoring
>> comments uses **. This is currently getting caught by the pointer
>> spacing warning. So, catch it
Hi Ben,
Ben Pfaff writes:
...
> I think it'd be even better to include measurements in one of the commit
> messages, because those are available in the repository after the
> patches are applied. It's harder to find cover letters because they're
> only on the mailing list.
One thing that other
Ben Pfaff writes:
> On Mon, May 01, 2017 at 04:45:56PM -0400, Aaron Conole wrote:
>> Ben Pfaff writes:
>> ...
>> > I think it'd be even better to include measurements in one of the commit
>> > messages, because those are available in the repository aft
Ben Pfaff writes:
> On Mon, May 01, 2017 at 04:39:30PM -0400, Aaron Conole wrote:
>> Ben Pfaff writes:
>>
>> > On Mon, May 01, 2017 at 04:14:09PM -0400, Aaron Conole wrote:
>> >> A common way of expressing 'raise to the power of' when author
961a99f57 ("lib/automake.mk: don't install runtime directories")
Reported-by: Lance Richardson
Tested-by: Lance Richardson
Signed-off-by: Aaron Conole
---
NOTE: If there is a required corresponding change
for Debian, please let me know.
rhel/openvswitch-fedora.spe
Ben Pfaff writes:
> On Tue, May 02, 2017 at 12:24:53PM -0400, Aaron Conole wrote:
>> Ben Pfaff writes:
>>
>> > On Mon, May 01, 2017 at 04:39:30PM -0400, Aaron Conole wrote:
>> >> Ben Pfaff writes:
>> >>
>> >> > On Mon, May 01,
Hi Numan,
nusid...@redhat.com writes:
> From: Numan Siddique
>
> I have picked up the patch series authored by Zong Kai LI to support IPv6
> Router Advertisement in ovn -
> https://mail.openvswitch.org/pipermail/ovs-dev/2016-October/242988.html
> as this patch series was inactive for quite a lon
Timothy Redaelli writes:
> Use ovs-ctl --delete-transient-ports-on-boot to start ovsdb-server.
>
> This feature can be disabled by appending --no-delete-transient-ports-on-boot
> to OPTIONS in /etc/sysconfig/openvswitch
>
> Signed-off-by: Timothy Redaelli
> ---
> rhel/automake.mk
Ben Pfaff writes:
> Hi Aaron, checkpatch currently tries to ignores files in the "datapath"
> directories but it's not entirely successful. I think that's because,
> in the "parse == 1" case, it doesn't strip a leading "a/" or "b/" from
> filenames:
> current_file = match.group(2
Hi Ben,
Thanks for the look!
Ben Pfaff writes:
> On Fri, Apr 28, 2017 at 04:44:32PM -0400, Aaron Conole wrote:
>> Greetings dev,
>>
>> I have whipped up a quick little utility (find below), that I've done a
>> bit of debugging with and it seems to have made wor
Ben Pfaff writes:
> The code in checkpatch inconsistently stripped "a/" or "b/" from the
> beginning of a file name, and the check for "datapath" only worked when
> the prefix was not stripped. This fixes the problem.
>
> CC: Aaron Conole
> Sig
Hi Satya,
I haven't checked the OF1.5 spec with this, yet. Just saw a few things.
Thanks for the contribution!
Ben Pfaff writes:
> From: Satya Valli
>
Missing signed-off-by line. Also, it would be good to describe exactly
which flow stat types are being provided.
> ---
> include/openflow
Aaron Conole writes:
> It's possible to race with the udev service, such that dpdk ports are
> not finished being bound until after ovs-vswitchd has been started.
> This means that attempts to use the port will fail. While it is
> possible to work around this for some NICs using
Hi Ilya,
Ilya Maximets writes:
> On 17.05.2017 18:32, Darrell Ball wrote:
>>
>>
>> On 5/17/17, 7:59 AM, "Ilya Maximets" wrote:
>>
>> I guess, we need some more opinions about this.
>>
>> My comments inline.
>>
>> Best regards, Ilya Maximets.
>>
>> On 13.05.2017
ar OVS-X.Y release series, but if this is not possible
> this patch introduced a mechanism to allow an ABI-breaking fix to be
> introduced. In such a case, developers may update the libtool CURRENT
> version to indicate this breakage to library users.
>
> Signed-off-by: Joe Stringer
Joe Stringer writes:
> The previous commit renamed libopenvswitch-X to libopenvswitch-X.Y to
> allow ABI breakage to be expressed through libtool numbering. Document
> this change.
>
> Signed-off-by: Joe Stringer
> ---
Acked-by: Aaron Conole
_
Han Zhou writes:
> Signed-off-by: Han Zhou
> ---
LGTM.
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ben Pfaff writes:
> Signed-off-by: Ben Pfaff
> ---
Acked-by: Aaron Conole
I'll be installing and playing with 2/2.
Really pumped about this series! :)
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ben Pfaff writes:
> On Sun, Apr 23, 2017 at 10:21:10AM -0400, Aaron Conole wrote:
>> This series attempts to introduce the ability to start and use
>> Open vSwitch 'out of the box' as a non-root user. It does this by
>> modifying the service files to pass the
Ben Pfaff writes:
> On Sat, May 13, 2017 at 11:08:13AM -0400, Aaron Conole wrote:
>> Aaron Conole writes:
>> > It's possible to race with the udev service, such that dpdk ports are
>> > not finished being bound until after ovs-vswitchd has been started.
>>
Stephen Finucane writes:
> On Tue, 2017-05-02 at 12:21 -0400, Aaron Conole wrote:
>> Ben Pfaff writes:
>>
>> > On Mon, May 01, 2017 at 04:45:56PM -0400, Aaron Conole wrote:
>> > > Ben Pfaff writes:
>> > > ...
>> > > > I think it&
akshay6 agarwal writes:
> Hi All
>
> My objective is to use fast failover using linux nat in OVS but before
> implementing that I am stuck in NAT
> (ip tables) issue.
>
> I have one ovs bridge with 2 lan interface ( 1 virtual interface (ethlan)and
> one physical interface(eth1.4))
> Also added
commit adds that support.
>
> For backward compatibility, only interactive ovs-ofctl commands by default
> display port names; to display them in scripts, use the new --names
> option.
>
> Signed-off-by: Ben Pfaff
> ---
Tested-by: Aaron Conole
I suggest folding in the f
replace library functions
> Fix naming of functions xfoo() -> ovs_foo() where appropriate
> Fix descriptions
> ---
This version LGTM.
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ric warnings were actually reported.
> This fixes that problem.
>
> Signed-off-by: Ben Pfaff
> ---
Makes sense, and looks good to me.
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
201 - 300 of 1897 matches
Mail list logo
