Robert Haas írta:
2010/1/12 Boszormenyi Zoltan z...@cybertec.at:
Tom Lane írta:
Alvaro Herrera alvhe...@commandprompt.com writes:
But it would be broken in very obvious ways, no? It's not like it would
be silently broken and thus escape testing ...
Well, if we
Mark Mielke wrote:
On 01/29/2010 09:01 PM, Tom Lane wrote:
Maybe. We concluded in the April 2009 thread that
standard_conforming_strings = ON had gotten little or no field testing,
and I don't see any strong reason to hope that it's gotten much more
since then.
Not to contradict any
On Sat, Jan 30, 2010 at 11:09:34AM +0100, Boszormenyi Zoltan wrote:
After I sent it and reread my mail, I realized that my fix
wouldn't be enough because of the above: ECPG uses sprintf()
for float and double, and just like in the backend, a common
code to send NaN and +/- Infinity to the
Michael Meskes írta:
On Sat, Jan 30, 2010 at 11:09:34AM +0100, Boszormenyi Zoltan wrote:
After I sent it and reread my mail, I realized that my fix
wouldn't be enough because of the above: ECPG uses sprintf()
for float and double, and just like in the backend, a common
code to send NaN
2010/2/1 KaiGai Kohei kai...@ak.jp.nec.com:
I'm making a general statement - if something is BROKEN (like the
rename case we just dealt with), we should look at fixing it. If it's
just something that could be cleaned up or done more nicely, we should
leave it alone for now.
OK, Please
On Tue, Feb 02, 2010 at 03:34:24PM +0100, Boszormenyi Zoltan wrote:
Here's the new patch with the updated regression test.
Committed. Thanks a lot.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at
Jesper Krogh jes...@krogh.cc wrote:
Ultimately I would like an infinite amount of configurabillity
There was some discussion of this previously. I was thinking of
doing something with it, but Laurent indicated off-list he was
working on it, so I left it to him. Besides reading these
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes:
AFAICS, the assertion is broken, but the code is correct. We just need to
adjust the expression in the assertion.
I think this is 100% wrong. Toast tables shouldn't be changing
namespace either; which means you broke something somewhere
Andres Freund and...@anarazel.de writes:
On Tuesday 02 February 2010 18:36:12 Robert Haas wrote:
I took a look at this patch today and I agree with Tom that
pg_fsync_start() is a very confusing name. I don't know what the
right name is, but this doesn't fsync so I don't think it shuld have
On Tuesday 02 February 2010 18:36:12 Robert Haas wrote:
On Fri, Jan 29, 2010 at 1:56 PM, Greg Stark gsst...@mit.edu wrote:
On Tue, Jan 19, 2010 at 3:25 PM, Tom Lane t...@sss.pgh.pa.us wrote:
That function *seriously* needs documentation, in particular the fact
that it's a no-op on machines
On Tue, Feb 2, 2010 at 12:50 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Andres Freund and...@anarazel.de writes:
On Tuesday 02 February 2010 18:36:12 Robert Haas wrote:
I took a look at this patch today and I agree with Tom that
pg_fsync_start() is a very confusing name. I don't know what the
Simon Riggs wrote:
On Fri, 2010-01-29 at 15:01 +, Simon Riggs wrote:
Putting it back takes time and
given enough of that rare cloth, it will eventually be put back.
Looks like I'll have time to add the starts-at-shutdown-checkpoint item
back in after all.
Great! Thank you, much
On Tuesday 02 February 2010 19:14:40 Robert Haas wrote:
On Tue, Feb 2, 2010 at 12:50 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Andres Freund and...@anarazel.de writes:
On Tuesday 02 February 2010 18:36:12 Robert Haas wrote:
I took a look at this patch today and I agree with Tom that
On Mon, Feb 01, 2010 at 07:53:05PM -0700, Alex Hunsaker wrote:
On Mon, Feb 1, 2010 at 03:58, Tim Bunce tim.bu...@pobox.com wrote:
On Sat, Jan 30, 2010 at 06:38:59PM -0700, Alex Hunsaker wrote:
plc_safe_ok.pl seems to loose its CVS $PostgreSQL$ keyword.
Probably a slip-up when I merged the
I wrote:
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes:
AFAICS, the assertion is broken, but the code is correct. We just need to
adjust the expression in the assertion.
I think this is 100% wrong. Toast tables shouldn't be changing
namespace either; which means you broke something
On Tue, Feb 2, 2010 at 1:34 PM, Andres Freund and...@anarazel.de wrote:
For now it could - but it very well might be converted to sync_file_range or
similar, which would have different sideeffects.
As the potential code duplication is rather small I would prefer to describe
the prime effect
On Tuesday 02 February 2010 20:06:32 Robert Haas wrote:
On Tue, Feb 2, 2010 at 1:34 PM, Andres Freund and...@anarazel.de wrote:
For now it could - but it very well might be converted to sync_file_range
or similar, which would have different sideeffects.
As the potential code duplication
Some more _personalized_ copyright noticed have crept into our source
tree:
/src/tutorial/basics.sourceCopyright (c) 1994, Andrew Yu, University of
California
/contrib/intagg/Makefile Copyright (c) 2001 Digital Music Network by
Mark L. Woodward
/src/port/rint.c
I wrote:
After tracing through it, the problem is that rebuild_relation() assumes
toast tables are always in PG_TOAST_NAMESPACE; which has not been true
since 8.3. CLUSTER has been renaming temp toast tables into the wrong
namespace right along. Without the assert to call attention to it,
2010/2/1 Magnus Hagander mag...@hagander.net:
2010/1/28 Magnus Hagander mag...@hagander.net:
On Thu, Jan 28, 2010 at 21:16, Tom Lane t...@sss.pgh.pa.us wrote:
Magnus Hagander mag...@hagander.net writes:
On Thu, Jan 28, 2010 at 17:16, Tom Lane t...@sss.pgh.pa.us wrote:
However, now that I know
On sön, 2010-01-31 at 09:34 +0100, Guillaume Lelarge wrote:
I worked on a patch to make PostgreSQL binaries use the new
PQconnectdbParams() libpq functions.
Can someone dig out the patch that Heikki had started to support psql
automatically setting the client encoding? I think that's what
On Fri, Jan 29, 2010 at 1:56 PM, Greg Stark gsst...@mit.edu wrote:
On Tue, Jan 19, 2010 at 3:25 PM, Tom Lane t...@sss.pgh.pa.us wrote:
That function *seriously* needs documentation, in particular the fact
that it's a no-op on machines without the right kernel call. The name
you've chosen is
Robert Haas robertmh...@gmail.com writes:
Hmm, in that case, I think the problem is that this function has no
comment explaining its intended charter.
That's certainly a big problem, but a comment won't fix the fact that
the name is misleading. We need both a comment and a name change.
On Tue, Feb 2, 2010 at 2:33 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
Hmm, in that case, I think the problem is that this function has no
comment explaining its intended charter.
That's certainly a big problem, but a comment won't fix the fact that
the
With perhaps some minor tweaks to some of the names and a rework of the else
clause in ginInsertEntry(), I feel this patch is reasonably close to commit.
Yeah, I think it can get there, but only if Oleg and Teodor provide an
updated version pretty soon...
Updated version of patch based on
So based on our discussion of last week my understanding is that as long as
these people are content to release the code under the same license then
these statements don't change anything since they're included in the
Postgresql global development group anyways.
greg
On 2 Feb 2010 19:39, Bruce
2010/2/2 Teodor Sigaev teo...@sigaev.ru:
With perhaps some minor tweaks to some of the names and a rework of
the else
clause in ginInsertEntry(), I feel this patch is reasonably close to
commit.
Yeah, I think it can get there, but only if Oleg and Teodor provide an
updated version
Bruce Momjian wrote:
I received permission from Andrew Yu to remove a copyright he had on
another file in 2007:
http://archives.postgresql.org/pgsql-hackers/2007-03/msg01528.php
I have emailed him to get approval to remove this mention also.
I received an email reply from Andrew
Greg Stark wrote:
So based on our discussion of last week my understanding is that as long as
these people are content to release the code under the same license then
these statements don't change anything since they're included in the
Postgresql global development group anyways.
Yes, I
On Tue, Feb 2, 2010 at 6:48 PM, Bruce Momjian br...@momjian.us wrote:
The intagg copyright is on a _Makefile_:
# Makefile for integer aggregator
# Copyright (C) 2001 Digital Music Network.
# by Mark L. Woodward
# $PostgreSQL: pgsql/contrib/intagg/Makefile,v 1.10
Dave Page wrote:
On Tue, Feb 2, 2010 at 6:48 PM, Bruce Momjian br...@momjian.us wrote:
The intagg copyright is on a _Makefile_:
? ? ? ?# Makefile for integer aggregator
? ? ? ?# Copyright (C) 2001 Digital Music Network.
? ? ? ?# by Mark L. Woodward
? ? ? ?# $PostgreSQL:
On Tue, Feb 2, 2010 at 8:20 PM, Bruce Momjian br...@momjian.us wrote:
Seems we either have to contact the author or rewrite the file.
Why? Even if the text is removed, he will still own the copyright, as
is the case for any patch submitted because we don't have any form of
copyright
Dave Page wrote:
On Tue, Feb 2, 2010 at 8:20 PM, Bruce Momjian br...@momjian.us wrote:
Seems we either have to contact the author or rewrite the file.
Why? Even if the text is removed, he will still own the copyright, as
is the case for any patch submitted because we don't have any form
(2010/02/02 23:50), Robert Haas wrote:
2010/2/1 KaiGai Koheikai...@ak.jp.nec.com:
I'm making a general statement - if something is BROKEN (like the
rename case we just dealt with), we should look at fixing it. If it's
just something that could be cleaned up or done more nicely, we should
On Sat, Jan 30, 2010 at 1:12 AM, Oleg Bartunov o...@sai.msu.su wrote:
I made available test data I used on
http://www.sai.msu.su/~megera/wiki/2009-07-27,
so anyone can reproduce my results. You can download data
http://www.sai.msu.su/~megera/postgres/files/links2.sql.gz, it's big (580Mb)
Ugh.
On Wed, 2010-02-03 at 00:10 +0100, Joachim Wieland wrote:
I admit that it was not clear what I meant. The comment should only
address LISTEN / NOTIFY on the standby server. Do you see any problems
allowing it?
The original comment was a part of the NotifyStmt case, and I don't
think we can
Robert Haas robertmh...@gmail.com writes:
On Sat, Jan 30, 2010 at 1:12 AM, Oleg Bartunov o...@sai.msu.su wrote:
I made available test data I used on
http://www.sai.msu.su/~megera/wiki/2009-07-27,
so anyone can reproduce my results. You can download data
On Sat, Jan 30, 2010 at 08:49, Tim Bunce tim.bu...@pobox.com wrote:
This is an update the fourth of the patches to be split out from the
former 'plperl feature patch 1'.
Changes in this patch:
- Adds plperl.on_trusted_init and plperl.on_untrusted_init GUCs
on_trusted_init is PGC_USERSET,
On Tue, Feb 2, 2010 at 10:42 PM, Alex Hunsaker bada...@gmail.com wrote:
On Sat, Jan 30, 2010 at 08:49, Tim Bunce tim.bu...@pobox.com wrote:
This is an update the fourth of the patches to be split out from the
former 'plperl feature patch 1'.
Changes in this patch:
- Adds
On Tue, Feb 2, 2010 at 10:46 PM, Robert Haas robertmh...@gmail.com wrote:
On Tue, Feb 2, 2010 at 10:42 PM, Alex Hunsaker bada...@gmail.com wrote:
On Sat, Jan 30, 2010 at 08:49, Tim Bunce tim.bu...@pobox.com wrote:
This is an update the fourth of the patches to be split out from the
former
Robert Haas escribió:
On Tue, Feb 2, 2010 at 10:46 PM, Robert Haas robertmh...@gmail.com wrote:
On Tue, Feb 2, 2010 at 10:42 PM, Alex Hunsaker bada...@gmail.com wrote:
On Sat, Jan 30, 2010 at 08:49, Tim Bunce tim.bu...@pobox.com wrote:
This is an update the fourth of the patches to be split
On Tue, Feb 2, 2010 at 10:51 PM, Alvaro Herrera
alvhe...@commandprompt.com wrote:
Robert Haas escribió:
On Tue, Feb 2, 2010 at 10:46 PM, Robert Haas robertmh...@gmail.com wrote:
On Tue, Feb 2, 2010 at 10:42 PM, Alex Hunsaker bada...@gmail.com wrote:
On Sat, Jan 30, 2010 at 08:49, Tim Bunce
On Tue, Feb 2, 2010 at 20:46, Robert Haas robertmh...@gmail.com wrote:
On Tue, Feb 2, 2010 at 10:46 PM, Robert Haas robertmh...@gmail.com wrote:
On Tue, Feb 2, 2010 at 10:42 PM, Alex Hunsaker bada...@gmail.com wrote:
On Sat, Jan 30, 2010 at 08:49, Tim Bunce tim.bu...@pobox.com wrote:
This is
On Thu, Jan 14, 2010 at 7:04 PM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
1. Walsender calls pq_wait() which calls select(), waiting for timeout,
or data to become available for reading in the underlying socket.
2. Client issues an SSL renegotiation by sending a message to
Alex Hunsaker bada...@gmail.com writes:
Yeah the both is gross. How about:
plperl.on_plperl_init
plperl.on_plperlu_init
plperl.on_init ?
I like the first two. The problem of selecting a good name for the
third one is easily solved: don't have it. What would it be except
a headache and a
On Tue, Feb 2, 2010 at 21:38, Tom Lane t...@sss.pgh.pa.us wrote:
Alex Hunsaker bada...@gmail.com writes:
Yeah the both is gross. How about:
plperl.on_plperl_init
plperl.on_plperlu_init
plperl.on_init ?
I like the first two. The problem of selecting a good name for the
third one is easily
Alex Hunsaker bada...@gmail.com writes:
On Tue, Feb 2, 2010 at 21:38, Tom Lane t...@sss.pgh.pa.us wrote:
Alex Hunsaker bada...@gmail.com writes:
Yeah the both is gross. Â How about:
plperl.on_plperl_init
plperl.on_plperlu_init
plperl.on_init ?
I like the first two. Â The problem of
On Wednesday, February 3, 2010, Tom Lane t...@sss.pgh.pa.us wrote:
Alex Hunsaker bada...@gmail.com writes:
On Tue, Feb 2, 2010 at 21:38, Tom Lane t...@sss.pgh.pa.us wrote:
Alex Hunsaker bada...@gmail.com writes:
Yeah the both is gross. How about:
plperl.on_plperl_init
plperl.on_plperlu_init
Fujii Masao wrote:
On Thu, Jan 14, 2010 at 7:04 PM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
1. Walsender calls pq_wait() which calls select(), waiting for timeout,
or data to become available for reading in the underlying socket.
2. Client issues an SSL renegotiation by
On Tue, Feb 2, 2010 at 22:50, Tom Lane t...@sss.pgh.pa.us wrote:
Alex Hunsaker bada...@gmail.com writes:
On Tue, Feb 2, 2010 at 21:38, Tom Lane t...@sss.pgh.pa.us wrote:
Alex Hunsaker bada...@gmail.com writes:
Yeah the both is gross. How about:
plperl.on_plperl_init
plperl.on_plperlu_init
50 matches
Mail list logo
