Re: [HACKERS] WAL format and API changes (9.5)

2014-07-02 Thread Michael Paquier
On Tue, Jul 1, 2014 at 7:18 AM, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jul 1, 2014 at 5:51 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Thanks for the review! On 06/27/2014 09:12 AM, Michael Paquier wrote: Looking at this patch, it does not compile when assertions

Re: [HACKERS] 9.5 CF1

2014-07-02 Thread Abhijit Menon-Sen
Performance --- scalable LWLocks Generic atomics implementation Both under active discussion. KNN-GiST with recheck Partial sort Some earlier discussion, but no conclusions, and as far as I know nobody is working on these patches at the moment. lowering array_agg memory

Re: [HACKERS] RETURNING PRIMARY KEY syntax extension

2014-07-02 Thread Ian Barwick
On 14/07/01 23:13, Robert Haas wrote: On Tue, Jul 1, 2014 at 8:00 AM, Rushabh Lathia rushabh.lat...@gmail.com wrote: .) In map_primary_key_to_list() patch using INDEX_ATTR_BITMAP_IDENTITY_KEY bitmap to get the keycols. In IndexAttrBitmapKind there is also INDEX_ATTR_BITMAP_KEY, so was

Re: [HACKERS] better atomics - v0.5

2014-07-02 Thread Ants Aasma
On Fri, Jun 27, 2014 at 9:00 PM, Andres Freund and...@2ndquadrant.com wrote: Imagine the situation for the buffer header spinlock which is one of the bigger performance issues atm. We could aim to replace all usages of that with clever and complicated logic, but it's hard. The IMO reasonable

[HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Kyotaro HORIGUCHI
Hello, This is about a document fix of local_preload_libraries for the versions 9.3 and earlier to at least 8.4. There's inconsistency between documentation about local_preload_libraries for 9.3 and earlier and their behavior. The 9.3 document for local_preload_libraries says that:

Re: [HACKERS] Audit of logout

2014-07-02 Thread Fujii Masao
On Mon, Jun 23, 2014 at 5:42 PM, Fujii Masao masao.fu...@gmail.com wrote: On Sat, Jun 21, 2014 at 12:59 PM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/13/2014 07:29 AM, Tom Lane wrote: Fujii Masao masao.fu...@gmail.com writes: On Thu, Jun 12,

Re: [HACKERS] WAL format and API changes (9.5)

2014-07-02 Thread Michael Paquier
On Tue, Jul 1, 2014 at 5:51 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 06/27/2014 09:12 AM, Michael Paquier wrote: 2) Description of XLogBeginInsert, XLogHasBlockRef, XLogGetBlockRef and XLogGetBlockRefIds are missing in src/backend/access/transam/README. Added descriptions

Re: [HACKERS] WAL format and API changes (9.5)

2014-07-02 Thread Michael Paquier
On Wed, Jul 2, 2014 at 4:09 PM, Michael Paquier michael.paqu...@gmail.com wrote: 3) I noticed a bug in gin redo code path when trying to use the WAL replay facility. Looking at the backtrace, it seems that a page for gin is corrupted. The buffer capture patch does some sanity checks on the

Re: [HACKERS] 9.5 CF1

2014-07-02 Thread Michael Paquier
On Wed, Jul 2, 2014 at 2:44 PM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: WAL format API changes I'm not sure what's happening here. Will look more closely, but updates are welcome from the people who've been participating in the discussion/review. Patch has been reviewed

Re: [HACKERS] Spinlocks and compiler/memory barriers

2014-07-02 Thread Andres Freund
On 2014-07-01 20:21:37 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-07-01 23:21:07 +0100, Mark Cave-Ayland wrote: Also if you're struggling for Sun buildfarm animals, recent versions of QEMU will quite happily install and run later versions of 32-bit

Re: [HACKERS] better atomics - v0.5

2014-07-02 Thread Andres Freund
On 2014-07-02 09:27:52 +0300, Ants Aasma wrote: On Fri, Jun 27, 2014 at 9:00 PM, Andres Freund and...@2ndquadrant.com wrote: Imagine the situation for the buffer header spinlock which is one of the bigger performance issues atm. We could aim to replace all usages of that with clever and

Re: [HACKERS] Spinlocks and compiler/memory barriers

2014-07-02 Thread Mark Cave-Ayland
On 02/07/14 08:36, Andres Freund wrote: On 2014-07-01 20:21:37 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-07-01 23:21:07 +0100, Mark Cave-Ayland wrote: Also if you're struggling for Sun buildfarm animals, recent versions of QEMU will quite happily install and

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-07-02 Thread Abhijit Menon-Sen
At 2014-06-30 10:59:22 -0400, robertmh...@gmail.com wrote: That means we need some review of the patch for what it is, which there hasn't been much of, yet. Regardless of the eventual fate of pgaudit, we'd certainly welcome some review of the code. -- Abhijit -- Sent via pgsql-hackers

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-07-02 Thread Abhijit Menon-Sen
At 2014-07-01 21:39:27 +0900, maumau...@gmail.com wrote: Won't it be burden and a headache to maintain pgaudit code when it becomes obsolete in the near future? Maybe it's a bit unfair to single out this statement to respond to, because it seems at best tangential to your larger point, but:

Re: [HACKERS] WAL replay bugs

2014-07-02 Thread Kyotaro HORIGUCHI
Hello, Thanks for your comments. Looking forward to seeing some more input. Thank you. bufcapt.c was a poser. bufcapt.c: 326 memcpy(tail, page[BLCKSZ - 2], 2); This seems duzzling.. Isn't *(uint16*)(page[BLCKSZ - 2]) applicable? bufcapt.c: 331 else if (PageGetSpecial Generally

Re: [HACKERS] RLS Design

2014-07-02 Thread Yeb Havinga
On 01/07/14 21:51, Robert Haas wrote: On Tue, Jul 1, 2014 at 3:20 PM, Dean Rasheed dean.a.rash...@gmail.com wrote: That seems like a pretty strong argument. If RLS quals are instead regarded as constraints on access, and multiple policies apply, then it seems that the quals should now be

Re: [HACKERS] Add the number of pinning backends to pg_buffercache's output

2014-07-02 Thread Rajeev rastogi
On 23 June 2014 15:22, Andres Freund Wrote: This may be harmless but pinning_backends should be defined as int4 rather than int8 because BufferDesc-refcount is just defined as unsigned and it's converted to Datum by Int32GetDatum(). Well, in theory a uint32 can't generally be converted

Re: [HACKERS] gaussian distribution pgbench

2014-07-02 Thread Fabien COELHO
Hello Mitsumasa-san, And I'm also interested in your decile percents output like under followings, decile percents: 39.6% 24.0% 14.6% 8.8% 5.4% 3.3% 2.0% 1.2% 0.7% 0.4% Sure, I'm really fine with that. I think that it is easier than before. Sum of decile percents is just 100%. That's a

[HACKERS] Missing IPv6 for pgbuildfarm.org

2014-07-02 Thread Torsten Zuehlsdorff
Hello, i've tried to setup a FreeBSD 10 machine as buildfarm-member. But it's an IPv6 only machine and there is no IPv6 for the homepage. Can anyone add support for IPv6 to it? Greetings, Torsten -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] 9.5 CF1

2014-07-02 Thread Etsuro Fujita
(2014/07/02 14:06), Abhijit Menon-Sen wrote: Foreign table inheritance Moved from ready for committer back to waiting on author after Noah's review comments. Should we expect an updated patch to be posted in this CF?

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-07-02 Thread Christoph Berg
Re: Tom Lane 2014-07-01 20654.1404247...@sss.pgh.pa.us Yeah, I'm unexcited about this proposal. In any case, given the two existing APIs we have to deal with, allowing PG_OOM_ADJUST_VALUE to default to 0 is sane in both APIs but a default for the file name can work for only one. Nod. Fair

Re: [HACKERS] 9.5 CF1

2014-07-02 Thread Abhijit Menon-Sen
Thanks for the update. I have marked the patch returned with feedback and moved it to the 2014-08 CF. -- Abhijit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-07-02 Thread Simon Riggs
On 1 July 2014 18:32, Stephen Frost sfr...@snowman.net wrote: Having functions to control the auditing would work, but it's not exactly the ideal approach, imv, and What aspect is less than ideal? the only reason it's being discussed here is because it might be a way to allow an extension

Re: [HACKERS] 9.5 CF1

2014-07-02 Thread Etsuro Fujita
(2014/07/02 18:19), Abhijit Menon-Sen wrote: Thanks for the update. I have marked the patch returned with feedback and moved it to the 2014-08 CF. OK I've changed the status from returned with feedback to Waiting on Author. Thanks, Best regards, Etsuro Fujita -- Sent via pgsql-hackers

Re: [HACKERS] Allowing NOT IN to use ANTI joins

2014-07-02 Thread Jeevan Chalke
On Sun, Jun 29, 2014 at 4:18 PM, David Rowley dgrowle...@gmail.com wrote: I think I'm finally ready for a review again, so I'll update the commitfest app. I have reviewed this on code level. 1. Patch gets applied cleanly. 2. make/make install/make check all are fine No issues found till

[HACKERS] Aggregate function API versus grouping sets

2014-07-02 Thread Andrew Gierth
I've been assisting Atri with development of an implementation of GROUPING SETS, beginning with a one-pass implementation of ROLLUP. Two issues have arisen regarding the API for calling aggregate transition and final functions that I think need answering now, since they relate to changes in 9.4.

Re: [HACKERS] Allowing NOT IN to use ANTI joins

2014-07-02 Thread David Rowley
On Wed, Jul 2, 2014 at 9:25 PM, Jeevan Chalke jeevan.cha...@enterprisedb.com wrote: Testing more on SQL level. I'm just looking into an issue I've found in the find_inner_rels() function, where it does not properly find the rel in the from list in certain cases, for example: explain

Re: [HACKERS] Selectivity estimation for inet operators

2014-07-02 Thread Dilip kumar
On, 15 May 2014 14:04 Emre Hasegeli Wrote, * matching first MCV to second MCV * searching first MCV in the second histogram * searching second MCV in the first histogram * searching boundaries of the first histogram in the second histogram Comparing the lists with each other slows down

Re: [HACKERS] gaussian distribution pgbench

2014-07-02 Thread Fabien COELHO
I have just updated the wording so that it may be clearer: Oops, I have sent the wrong patch, without the wording fix. Here is the real updated version, which I tested. probability of fist/last percent of the range: 11.3% 0.0% -- Fabien.diff --git a/contrib/pgbench/pgbench.c

Re: [HACKERS] New functions in sslinfo module

2014-07-02 Thread Воронин Дмитрий
24.06.2014, 00:07, "Andreas Karlsson" andr...@proxel.se: On 04/21/2014 07:51 AM, Воронин Дмитрий wrote:  I put patch generated on git diffs to this letter. I make an a thread in  postgresql commit fest:  https://commitfest.postgresql.org/action/patch_view?id=1438 Thanks for the patch, it seems

Re: [HACKERS] New functions in sslinfo module

2014-07-02 Thread Воронин Дмитрий
Oh, how can I write a documentation for my functions? 02.07.2014, 16:17, Воронин Дмитрий carriingfat...@yandex.ru: 24.06.2014, 00:07, Andreas Karlsson andr...@proxel.se:  On 04/21/2014 07:51 AM, Воронин Дмитрий wrote:   I put patch generated on git diffs to this letter. I make an a thread in  

Re: [HACKERS] New functions in sslinfo module

2014-07-02 Thread Michael Paquier
On Wed, Jul 2, 2014 at 9:19 PM, Воронин Дмитрий carriingfat...@yandex.ru wrote: Oh, how can I write a documentation for my functions? You will need to edit the sgml documentation and to include the diffs in your patch. Hence in your case simply list the new functions and a description of what

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-07-02 Thread Stephen Frost
* Abhijit Menon-Sen (a...@2ndquadrant.com) wrote: I foresee lots of disappointment, then. I don't think even Stephen is advocating NIST-compliance as the *baseline* for serious auditing in core, just that we need a design that lets us get there sometime. Agreed. I'm not suggesting that we

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-07-02 Thread Robert Haas
On Wed, Jul 2, 2014 at 5:19 AM, Simon Riggs si...@2ndquadrant.com wrote: On 1 July 2014 18:32, Stephen Frost sfr...@snowman.net wrote: Having functions to control the auditing would work, but it's not exactly the ideal approach, imv, and What aspect is less than ideal? the only reason it's

Re: [HACKERS] 9.5 CF1

2014-07-02 Thread Alexander Korotkov
On Wed, Jul 2, 2014 at 10:08 AM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: KNN-GiST with recheck Partial sort Some earlier discussion, but no conclusions, and as far as I know nobody is working on these patches at the moment. I'm now working on next revision of KNN-GiST with

Re: [HACKERS] better atomics - v0.5

2014-07-02 Thread Andres Freund
Hi, On 2014-06-30 20:28:52 +0200, Andres Freund wrote: To quantify this, on my 2 socket xeon E5520 workstation - which is too small to heavily show the contention problems in pgbench -S - the numbers are: pgbench -M prepared -c 16 -j 16 -T 10 -S (best of 5, noticeably variability) master:

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-07-02 Thread Jonathan Corbet
On Tue, 1 Jul 2014 15:57:25 -0400 Robert Haas robertmh...@gmail.com wrote: Of course, we have no guarantee that the Linux kernel guys won't change this again. Apparently we don't break userspace is a somewhat selectively-enforced principle. It's selectively enforced in that kernel developers

Re: [HACKERS] better atomics - v0.5

2014-07-02 Thread Andres Freund
On 2014-06-26 00:42:37 +0300, Heikki Linnakangas wrote: On 06/25/2014 11:36 PM, Andres Freund wrote: - I completely loathe the file layout you've proposed in src/include/storage. If we're going to have separate #include files for each architecture (and I'd rather we didn't go that route,

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-07-02 Thread Stephen Frost
Simon, * Simon Riggs (si...@2ndquadrant.com) wrote: On 1 July 2014 18:32, Stephen Frost sfr...@snowman.net wrote: Having functions to control the auditing would work, but it's not exactly the ideal approach, imv, and What aspect is less than ideal? I certainly don't like passing table

Re: [HACKERS] RLS Design

2014-07-02 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: On Tue, Jul 1, 2014 at 3:20 PM, Dean Rasheed dean.a.rash...@gmail.com wrote: If RLS quals are instead regarded as constraints on access, and multiple policies apply, then it seems that the quals should now be combined with AND rather than OR,

Re: [HACKERS] Spinlocks and compiler/memory barriers

2014-07-02 Thread Robert Haas
On Wed, Jul 2, 2014 at 4:06 AM, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: The point I wanted to make was that there are certain applications for which SPARCv8 is still certified for particular military/aerospace use. While I don't use it myself, some people are still using it enough

Re: [HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Tom Lane
Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp writes: postgres=# alter user horiguti2 set local_preload_libraries='libname'; ERROR: parameter local_preload_libraries cannot be set after connection start Hm ... it's kind of annoying that that doesn't work; it's certainly not hard to

Re: [HACKERS] Audit of logout

2014-07-02 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/01/2014 11:55 PM, Fujii Masao wrote: Hmm... I found that you had marked this proposal as Returned with Feedback. But I don't think that we reached the consensus to do that. I think that it's still worth discussing this topic in this CF. So I

Re: [HACKERS] Aggregate function API versus grouping sets

2014-07-02 Thread Tom Lane
Andrew Gierth and...@tao11.riddles.org.uk writes: 1. Assumptions about the relationship between aggcontext and fn_extra Tom's version of the ordered-set aggregate code makes the assumption that it is safe to store the aggcontext returned by AggCheckCallContext in a structure hung off

Re: [HACKERS] RLS Design

2014-07-02 Thread Robert Haas
On Wed, Jul 2, 2014 at 9:47 AM, Stephen Frost sfr...@snowman.net wrote: But you could do it other ways. For example: ALTER TABLE table_name [ NO ] ROW LEVEL SECURITY; ALTER TABLE table_name GRANT ROW ACCESS TO role_name USING qual; If a table is set to NO ROW LEVEL SECURITY then it behaves

Re: [HACKERS] Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.

2014-07-02 Thread Robert Haas
On Tue, Jul 1, 2014 at 7:32 PM, Gurjeet Singh gurj...@singh.im wrote: On Tue, Jul 1, 2014 at 10:05 AM, Kevin Grittner kgri...@ymail.com wrote: Tom Lane t...@sss.pgh.pa.us wrote: If we're going to do it like this, then I think the force flag should be considered to do nothing except override

Re: [HACKERS] 9.5 CF1

2014-07-02 Thread Kevin Grittner
Abhijit Menon-Sen a...@2ndquadrant.com wrote: Spread shared memory across NUMA memory nodes Marked waiting on author, but status unclear. Any updates? The review was a little sparse: http://www.postgresql.org/message-id/CADyhKSXs+oUetngSbeiM0tVSRy=QeCaSNBQBDbM=sfqtdg+...@mail.gmail.com

[HACKERS] autovacuum: found orphan temp table

2014-07-02 Thread Joshua D. Drake
Hello, While it is obvious what is happening in $SUBJECT as well as reasonably obvious why it can happen. What isn't obvious is what to do about it. It seems we log in as a super user and drop the temp tables. However, I would think if we know that it is orphaned that autovacuum should

Re: [HACKERS] autovacuum: found orphan temp table

2014-07-02 Thread Alvaro Herrera
Joshua D. Drake wrote: Hi, While it is obvious what is happening in $SUBJECT as well as reasonably obvious why it can happen. What isn't obvious is what to do about it. It seems we log in as a super user and drop the temp tables. However, I would think if we know that it is orphaned that

Re: [HACKERS] autovacuum: found orphan temp table

2014-07-02 Thread Tom Lane
Joshua D. Drake j...@commandprompt.com writes: While it is obvious what is happening in $SUBJECT as well as reasonably obvious why it can happen. What isn't obvious is what to do about it. It seems we log in as a super user and drop the temp tables. You don't need to do anything --- the

Re: [HACKERS] 9.5 CF1

2014-07-02 Thread Stephen Frost
* Abhijit Menon-Sen (a...@2ndquadrant.com) wrote: Row-security based on Updatable security barrier views Lots of discussion that I haven't dared to look at properly yet. I gather there's still plenty of design-level work needed, and this is not in any imminent danger of being

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-07-02 Thread Tom Lane
Christoph Berg c...@df7cb.de writes: Re: Tom Lane 2014-07-01 20654.1404247...@sss.pgh.pa.us Fair enough. I went for a minimum-change approach when hacking that script, but we could change it some more in the name of readability. Will do something about that. Thanks, it's much nicer now.

Re: [HACKERS] RLS Design

2014-07-02 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: On Wed, Jul 2, 2014 at 9:47 AM, Stephen Frost sfr...@snowman.net wrote: But you could do it other ways. For example: ALTER TABLE table_name [ NO ] ROW LEVEL SECURITY; ALTER TABLE table_name GRANT ROW ACCESS TO role_name USING qual; If a

Re: [HACKERS] RLS Design

2014-07-02 Thread Robert Haas
On Wed, Jul 2, 2014 at 11:42 AM, Stephen Frost sfr...@snowman.net wrote: What if policies exist and they decide to 'turn off' RLS for the table- suddenly everyone can see all the rows? That'd be my vote. Sorta like disabling triggers. Hmm. Ok- how would you feel about at least spitting

Re: [HACKERS] Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.

2014-07-02 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: On Tue, Jul 1, 2014 at 7:32 PM, Gurjeet Singh gurj...@singh.im wrote: Considering this as a bug-fix, I'd vote for it to be applied to all supported releases. I initially considered that position, but balanced that against this: I view this as a

Re: [HACKERS] Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.

2014-07-02 Thread Robert Haas
On Wed, Jul 2, 2014 at 11:45 AM, Kevin Grittner kgri...@ymail.com wrote: I'll vote for master-only. Well, it seems tame enough to me to apply to the release still in beta testing. It didn't seem important enough to me to justify a beta-to-release behavior change, but I won't complain too much

Re: [HACKERS] slotname vs slot_name

2014-07-02 Thread Andres Freund
On 2014-06-05 12:57:57 +0200, Andres Freund wrote: BTW, what about also renaming pg_llog directory? I'm afraid that a user can confuse pg_log with pg_llog. We have: * pg_ldecoding (Heikki) * pg_lcse or pg_lcset (Petr) * pg_logical (Andres) I like, what a surprise, my own suggestion

Re: [HACKERS] Keepalive-related socket options under FreeBSD 9, 10

2014-07-02 Thread Palle Girgensohn
Since upgrading FreeBSD from 8 to 9, I've noticed the following messages showing up in logs when a connection with pgAdmin3 is made: LOG: getsockopt(TCP_KEEPCNT) failed: Protocol not available STATEMENT: SELECT setting FROM pg_settings WHERE name IN ('autovacuum', 'track_counts') LOG:

Re: [HACKERS] RLS Design

2014-07-02 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: On Wed, Jul 2, 2014 at 11:42 AM, Stephen Frost sfr...@snowman.net wrote: What if policies exist and they decide to 'turn off' RLS for the table- suddenly everyone can see all the rows? That'd be my vote. Sorta like disabling triggers.

Re: [HACKERS] Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.

2014-07-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Wed, Jul 2, 2014 at 11:45 AM, Kevin Grittner kgri...@ymail.com wrote: I'll vote for master-only. Well, it seems tame enough to me to apply to the release still in beta testing. It didn't seem important enough to me to justify a beta-to-release

Re: [HACKERS] /proc/self/oom_adj is deprecated in newer Linux kernels

2014-07-02 Thread Robert Haas
On Wed, Jul 2, 2014 at 9:08 AM, Jonathan Corbet cor...@lwn.net wrote: On Tue, 1 Jul 2014 15:57:25 -0400 Robert Haas robertmh...@gmail.com wrote: Of course, we have no guarantee that the Linux kernel guys won't change this again. Apparently we don't break userspace is a somewhat

Re: [HACKERS] 9.5 CF1

2014-07-02 Thread Alvaro Herrera
Abhijit Menon-Sen wrote: Minmax indexes Álvaro will respond to the design questions Heikki raised. I'm currently reworking the patch so that things that need to be abstract per discussion are abstract, without enlarging the scope excessively. I'm working on an opclass implementation that

Re: [HACKERS] Aggregate function API versus grouping sets

2014-07-02 Thread Andrew Gierth
Tom == Tom Lane t...@sss.pgh.pa.us writes: Doing rollup via GroupAggregate by maintaining multiple transition values at a time (one per grouping set) means that the transfn is being called interleaved for transition values in different contexts. So the question becomes: is it wrong for

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-07-02 Thread Jeff Janes
On Mon, Jun 30, 2014 at 3:17 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Jeff Janes wrote: In particular, pgpipe is almost an exact duplicate between them, except the copy in vac_parallel.c has fallen behind changes made to parallel.c. (Those changes would have fixed the Windows

Re: [HACKERS] 9.5 CF1

2014-07-02 Thread Abhijit Menon-Sen
At 2014-07-02 11:19:10 -0400, sfr...@snowman.net wrote: I'd be fine leaving this open for now at least ('waiting on author' perhaps) and then bumping it to August only if necessary. Since there's active discussion/development happening, I wasn't planning to change the status anyway. It looks

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-07-02 Thread Alvaro Herrera
Jeff Janes wrote: I would only envision using the parallel feature for vacuumdb after a pg_upgrade or some other major maintenance window (that is the only time I ever envision using vacuumdb at all). I don't think autovacuum can be expected to handle such situations well, as it is designed

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-07-02 Thread Sawada Masahiko
On Wed, Jul 2, 2014 at 2:27 PM, Dilip kumar dilip.ku...@huawei.com wrote: On 01 July 2014 22:17, Sawada Masahiko Wrote, I have executed latest patch. One question is that how to use --jobs option is correct? $ vacuumdb -d postgres --jobs=30 I got following error. vacuumdb: unrecognized

[HACKERS] log_error_verbosity and unexpected errors

2014-07-02 Thread Greg Stark
I think log_error_verbosity is a strange variable. It's useless for expected user-facing errors but essential for unexpected errors that indicate bugs in the code -- and you can only have it on for everything or off for everything. I'm finding I usually want it set to 'verbose' for anything that

Re: [HACKERS] Aggregate function API versus grouping sets

2014-07-02 Thread Tom Lane
Andrew Gierth and...@tao11.riddles.org.uk writes: Tom == Tom Lane t...@sss.pgh.pa.us writes: Tom Another approach would be to remove AggGetPerAggEContext as such Tom from the API altogether, and instead offer an interface that Tom says register an aggregate cleanup callback, leaving it to

Re: [HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Fujii Masao
On Wed, Jul 2, 2014 at 11:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp writes: postgres=# alter user horiguti2 set local_preload_libraries='libname'; ERROR: parameter local_preload_libraries cannot be set after connection start Hm ... it's

Re: [HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: On Wed, Jul 2, 2014 at 11:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp writes: postgres=# alter user horiguti2 set local_preload_libraries='libname'; ERROR: parameter local_preload_libraries cannot be set

Re: [HACKERS] log_error_verbosity and unexpected errors

2014-07-02 Thread Tom Lane
Greg Stark st...@mit.edu writes: I think log_error_verbosity is a strange variable. It's useless for expected user-facing errors but essential for unexpected errors that indicate bugs in the code -- and you can only have it on for everything or off for everything. I'm finding I usually want

Re: [HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Fujii Masao
On Thu, Jul 3, 2014 at 3:53 AM, Tom Lane t...@sss.pgh.pa.us wrote: Fujii Masao masao.fu...@gmail.com writes: On Wed, Jul 2, 2014 at 11:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp writes: postgres=# alter user horiguti2 set

[HACKERS] Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged;?

2014-07-02 Thread Andres Freund
Hi, Fujii noticed that I'd used \echo Use CREATE EXTENSION pg_buffercache to load this file. \quit in an extension upgrade script. That's obviously wrong, because it should say ALTER EXTENSION. The reason it's that way is that I copied the line from the unpackaged--1.0.sql file. I noticed all

Re: [HACKERS] log_error_verbosity and unexpected errors

2014-07-02 Thread Merlin Moncure
On Wed, Jul 2, 2014 at 2:10 PM, Tom Lane t...@sss.pgh.pa.us wrote: Greg Stark st...@mit.edu writes: I think log_error_verbosity is a strange variable. It's useless for expected user-facing errors but essential for unexpected errors that indicate bugs in the code -- and you can only have it on

[HACKERS] docs: additional subsection for page-level locks in explicit-locking section

2014-07-02 Thread Michael Banck
Hi, While reading through the Explicit Locking section of the manual today, I felt the last paragraph of section 13.3.2. (Row-level Locks) might merit its own subsection. It talks about page-level locks as distinct from table- and row-level locks. Then again, it is just one paragraph, so maybe

Re: [HACKERS] alter user set local_preload_libraries.

2014-07-02 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: Agreed. I was also thinking we can set it per role, but got surprised when I found that's impossible. Is this a problem of only local_preload_libraries? I'm afraid that all PGC_BACKEND parameters have the same problem. Well, there aren't that many

Re: [HACKERS] Can simplify 'limit 1' with slow function?

2014-07-02 Thread Martijn van Oosterhout
On Tue, Jul 01, 2014 at 02:36:55PM -0500, Merlin Moncure wrote: On Tue, Jul 1, 2014 at 2:16 PM, Martijn van Oosterhout klep...@svana.org wrote: On Sun, Jun 29, 2014 at 10:05:50PM +0800, gotoschool6g wrote: The simplified scene: select slowfunction(s) from a order by b limit 1; is slow

Re: [HACKERS] Audit of logout

2014-07-02 Thread Fujii Masao
On Wed, Jul 2, 2014 at 11:39 PM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/01/2014 11:55 PM, Fujii Masao wrote: Hmm... I found that you had marked this proposal as Returned with Feedback. But I don't think that we reached the consensus to do

Re: [HACKERS] log_error_verbosity and unexpected errors

2014-07-02 Thread Tom Lane
Merlin Moncure mmonc...@gmail.com writes: Not trying to hijack your thread, just wondering out load if a SQLSTATE driven verbosity decision, if you were to do that, could/should also be hooked to client console logging and/or psql. Yeah, you could certainly argue that a similar facility on the

Re: [HACKERS] Aggregate function API versus grouping sets

2014-07-02 Thread Andrew Gierth
Tom == Tom Lane t...@sss.pgh.pa.us writes: Tom Another approach would be to remove AggGetPerAggEContext as such Tom from the API altogether, and instead offer an interface that Tom says register an aggregate cleanup callback, leaving it to the Tom agg/window core code to figure out which

Re: [HACKERS] Patch to send transaction commit/rollback stats to the stats collector unconditionally.

2014-07-02 Thread Kevin Grittner
In preparing to push the patch, I noticed I hadn't responded to this: Gurjeet Singh gurj...@singh.im wrote: Kevin Grittner kgri...@ymail.com wrote: I have reviewed this patch, and think we should do what the patch is trying to do, but I don't think the submitted patch would actually work.

Re: [HACKERS] Audit of logout

2014-07-02 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/02/2014 12:43 PM, Fujii Masao wrote: I think that we should use Waiting on Author in that case. Returned with Feedback is not Rejected. That's right. But it basically means that the bugfixed or revised version of the patch will NOT be

Re: [HACKERS] Can simplify 'limit 1' with slow function?

2014-07-02 Thread David G Johnston
Martijn van Oosterhout wrote On Tue, Jul 01, 2014 at 02:36:55PM -0500, Merlin Moncure wrote: On Tue, Jul 1, 2014 at 2:16 PM, Martijn van Oosterhout lt; kleptog@ gt; wrote: On Sun, Jun 29, 2014 at 10:05:50PM +0800, gotoschool6g wrote: The simplified scene: select slowfunction(s) from a

Re: [HACKERS] gaussian distribution pgbench

2014-07-02 Thread Gavin Flower
On 02/07/14 21:05, Fabien COELHO wrote: Hello Mitsumasa-san, And I'm also interested in your decile percents output like under followings, decile percents: 39.6% 24.0% 14.6% 8.8% 5.4% 3.3% 2.0% 1.2% 0.7% 0.4% Sure, I'm really fine with that. I think that it is easier than before. Sum of

Re: [HACKERS] Audit of logout

2014-07-02 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: On Wed, Jul 2, 2014 at 11:39 PM, Joe Conway m...@joeconway.com wrote: Returned with Feedback means, well exactly that ;-) -- the patch as linked to the CF page is wrong and cannot be applied the way it is currently. It is therefore returned to you to

Re: [HACKERS] Aggregate function API versus grouping sets

2014-07-02 Thread Tom Lane
Andrew Gierth and...@tao11.riddles.org.uk writes: Tom == Tom Lane t...@sss.pgh.pa.us writes: Tom If we're going to do that, I think it needs to be in 9.4. Are Tom you going to work up a patch? Do we want a decision on the fn_extra matter first, or shall I do one patch for the econtext,

Re: [HACKERS] Aggregate function API versus grouping sets

2014-07-02 Thread Andrew Gierth
Tom == Tom Lane t...@sss.pgh.pa.us writes: Do we want a decision on the fn_extra matter first, or shall I do one patch for the econtext, and a following one for fn_extra? Tom I think they're somewhat independent, and probably best patched Tom separately. In any case orderedsetagg.c's use

Re: [HACKERS] Can simplify 'limit 1' with slow function?

2014-07-02 Thread Tom Lane
David G Johnston david.g.johns...@gmail.com writes: Martijn van Oosterhout wrote I'm probably dense, but I'm not sure I understand. Or it is that the slowfunction() is called prior to the sort? That seems insane. The basic reality is that limit applies to the final set of rows that could be

Re: [HACKERS] Audit of logout

2014-07-02 Thread Abhijit Menon-Sen
At 2014-07-02 12:52:51 -0700, m...@joeconway.com wrote: Doesn't mean that to me but feel free to change it to Waiting on Author if you prefer :-) Is there any official explanation as to what those states mean documented anywhere? I don't know if there's an official definition, but my

Re: [HACKERS] Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.

2014-07-02 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: FWIW, master + 9.4 seems like a reasonable compromise to me too. Pushed to those branches.  Marked in CF. -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Audit of logout

2014-07-02 Thread Tom Lane
I wrote: In short, maybe we ought to invent a new category PGC_SU_BACKEND (not wedded to this spelling), which is to PGC_BACKEND as PGC_SUSET is to PGC_USERSET, ie same when-it-can-be-changed behavior but only superusers are allowed to change it. I don't have any objection to making these two

Re: [HACKERS] Audit of logout

2014-07-02 Thread Alvaro Herrera
Abhijit Menon-Sen wrote: At 2014-07-02 12:52:51 -0700, m...@joeconway.com wrote: Doesn't mean that to me but feel free to change it to Waiting on Author if you prefer :-) Is there any official explanation as to what those states mean documented anywhere? I don't know if there's an

[HACKERS] Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally.

2014-07-02 Thread Gurjeet Singh
On Wed, Jul 2, 2014 at 3:49 PM, Kevin Grittner kgri...@ymail.com wrote: In preparing to push the patch, I noticed I hadn't responded to this: Gurjeet Singh gurj...@singh.im wrote: Kevin Grittner kgri...@ymail.com wrote: I have reviewed this patch, and think we should do what the patch is

Re: [HACKERS] Patch to send transaction commit/rollback stats to the stats collector unconditionally.

2014-07-02 Thread Kevin Grittner
Gurjeet Singh gurj...@singh.im wrote: On Wed, Jul 2, 2014 at 3:49 PM, Kevin Grittner kgri...@ymail.com wrote: Gurjeet Singh gurj...@singh.im wrote: Kevin Grittner kgri...@ymail.com wrote: I have reviewed this patch, and think we should do what the patch is trying to do, but I don't think the

Re: [HACKERS] Audit of logout

2014-07-02 Thread Abhijit Menon-Sen
At 2014-07-02 16:47:16 -0400, alvhe...@2ndquadrant.com wrote: If we expect that the author is going to update the patch, the right state to use is Waiting on author. Quite so. That's how I understand it, and what I've been doing. But what if we really *don't* expect the author to update the

Re: [HACKERS] Audit of logout

2014-07-02 Thread Alvaro Herrera
Abhijit Menon-Sen wrote: At 2014-07-02 16:47:16 -0400, alvhe...@2ndquadrant.com wrote: If we expect that the author is going to update the patch, the right state to use is Waiting on author. Quite so. That's how I understand it, and what I've been doing. But what if we really *don't*

Re: [HACKERS] Audit of logout

2014-07-02 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/02/2014 02:15 PM, Abhijit Menon-Sen wrote: At 2014-07-02 16:47:16 -0400, alvhe...@2ndquadrant.com wrote: If we expect that the author is going to update the patch, the right state to use is Waiting on author. Quite so. That's how I

Re: [HACKERS] Can simplify 'limit 1' with slow function?

2014-07-02 Thread Martijn van Oosterhout
On Wed, Jul 02, 2014 at 04:17:13PM -0400, Tom Lane wrote: David G Johnston david.g.johns...@gmail.com writes: Martijn van Oosterhout wrote I'm probably dense, but I'm not sure I understand. Or it is that the slowfunction() is called prior to the sort? That seems insane. The basic

Re: [HACKERS] New functions in sslinfo module

2014-07-02 Thread Andreas Karlsson
On 07/02/2014 02:17 PM, Воронин Дмитрий wrote: I apologize, that I am writing this message today. Thank you for testing my patch! You are welcome! I will modify functions ssl_extensions(), that it returns a set (key, value). Could you get me an example of code those function? You can look

  1   2   >