On Thu, Jun 08, 2017 at 11:17:38PM -0700, Noah Misch wrote:
> On Sun, Jun 04, 2017 at 10:24:30PM +, Noah Misch wrote:
> > On Thu, Jun 01, 2017 at 01:07:53AM -0700, Michael Paquier wrote:
> > > On Wed, May 31, 2017 at 12:30 PM, Michael Paquier
> > > wrote:
> > > > On Wed, May 31, 2017 at 6:57 A
On Fri, Jun 9, 2017 at 10:20 PM, Masahiko Sawada
wrote:
> On Sat, Jun 10, 2017 at 7:29 AM, Jeff Janes wrote:
> > If I create a publication "for all tables", \dRp+ doesn't indicate it is
> for
> > all tables, it just gives a list of the tables.
> >
> > So it doesn't distinguish between a publicat
On Sat, Jun 10, 2017 at 7:29 AM, Jeff Janes wrote:
> If I create a publication "for all tables", \dRp+ doesn't indicate it is for
> all tables, it just gives a list of the tables.
>
> So it doesn't distinguish between a publication specified to be for all
> tables (which will be dynamic regarding
Thank you for your reply
On Jun 9, 2017 5:39 PM, "Michael Meskes" wrote:
>
> Hi,
>
> > To develop the ECPG application more efficiently and improve
> > portability,
> > I would like to suggest one minor improvement "WHENEVER condition DO
> > CONTINUE" support in ECPG.
> > Oracle Pro*C supports WH
On 7 June 2017 at 01:01, Josh Berkus wrote:
> P3: apparently jsonb_to_tsvector with lang parameter isn't immutable?
> This means that it can't be used for indexing:
>
> libdata=# create index bookdata_fts on bookdata using gin ((
> to_tsvector('english',bookdata)));
> ERROR: functions in index ex
On Fri, Jun 9, 2017 at 7:48 PM, Amit Khandekar wrote:
> On 9 June 2017 at 19:10, Amit Kapila wrote:
>> On Thu, Jun 8, 2017 at 10:40 PM, Robert Haas wrote:
>>> On Thu, Jun 8, 2017 at 7:01 AM, Amit Kapila wrote:
I think before doing above check we can simply check if ctid.ip_blkid
On 6/9/17 17:06, Jeff Janes wrote:
> When creating a subscription, I get a NOTICE "synchronized table states"
>
> What is this supposed to be telling the end user? Is this just a
> debugging message not intended to be included in the released code?
I think we can remove this message.
--
Peter
If I create a publication "for all tables", \dRp+ doesn't indicate it is
for all tables, it just gives a list of the tables.
So it doesn't distinguish between a publication specified to be for all
tables (which will be dynamic regarding future additions), and one which
just happens to include all
On 06/09/2017 06:16 AM, Joe Conway wrote:
> On 06/08/2017 11:09 PM, Noah Misch wrote:
>> On Wed, Jun 07, 2017 at 08:45:20AM -0700, Joe Conway wrote:
>>> On 06/07/2017 06:49 AM, Mike Palmiotto wrote:
>>> > I ended up narrowing it down to 4 tables (one parent and 3 partitions)
>>> > in order to demon
I wrote:
> Yes, we already have guards for those cases, but they return fairly opaque
> error messages to the tune of "set-valued function called in context that
> cannot accept a set", because the executor hasn't enough context to do
> better. I'd like the messages to be more specific, like "set-
On Thu, Jun 8, 2017 at 3:13 PM, Robert Haas wrote:
> On Tue, Jun 6, 2017 at 8:19 PM, Peter Geoghegan wrote:
>> On Tue, Jun 6, 2017 at 5:01 PM, Peter Geoghegan wrote:
>>> Also, ISTM that the code within ENRMetadataGetTupDesc() probably
>>> requires more explanation, resource management wise.
>
>
On 4/27/17 15:06, Peter Eisentraut wrote:
> On 4/27/17 04:08, Petr Jelinek wrote:
>> Note that the workaround for all of this is not all that complex, you do
>> same thing (create slot manually) you'd do for physical replication with
>> slots.
>
> Maybe we should just document this issue for now.
When creating a subscription, I get a NOTICE "synchronized table states"
What is this supposed to be telling the end user? Is this just a debugging
message not intended to be included in the released code?
When I first saw this NOTICE, I thought, based on the wording, that it was
telling me the
On 6/5/17 15:06, Andrew Dunstan wrote:
>> In that case we're going to need to invent a way to do this similarly
>> in vcregress.pl. I'm not simply going to revert to the situation where
>> it and the makefiles are completely out of sync on this. The previous
>> patch was made more or less by ignori
On 2017-06-09 22:28:00 +0200, Petr Jelinek wrote:
> And here it is, seems better (the 0002 is same as before).
Cool, looks good on a quick scan.
> /* Define pathname of exported-snapshot files */
> #define SNAPSHOT_EXPORT_DIR "pg_snapshots"
> -#define XactExportFilePath(path, xid, num, suffix)
On 09/06/17 03:20, Petr Jelinek wrote:
> On 09/06/17 01:06, Andres Freund wrote:
>> Hi,
>>
>> On 2017-06-03 04:50:00 +0200, Petr Jelinek wrote:
>>> One thing I don't like is the GetLastLocalTransactionId() that I had to
>>> add because we clear the proc->lxid before we get to AtEOXact_Snapshot()
>>
On 09/06/17 20:56, Andres Freund wrote:
> On 2017-06-08 23:04:31 -0700, Noah Misch wrote:
>> On Wed, Jun 07, 2017 at 10:54:57PM -0700, Noah Misch wrote:
>>> On Fri, Jun 02, 2017 at 11:06:29PM -0700, Andres Freund wrote:
On 2017-06-02 22:12:46 -0700, Noah Misch wrote:
> On Fri, Jun 02, 2017
On Fri, Jun 9, 2017 at 12:00 AM, Thomas Munro
wrote:
> On Wed, Jun 7, 2017 at 5:36 PM, Thomas Munro
> wrote:
>> I spent a couple of hours drafting a proof-of-concept to see if my
>> hunch was right. It seems to work correctly so far and isn't huge
>> (but certainly needs more testing and work):
On Fri, Jun 9, 2017 at 11:52 AM, Heikki Linnakangas wrote:
> On 06/09/2017 05:47 PM, Jeff Janes wrote:
>
>> Your commit to fix this part, 76b11e8a43eca4612d, is giving me compiler
>> warnings:
>>
>> fe-connect.c: In function 'connectDBStart':
>> fe-connect.c:1625: warning: 'ret' may be used unini
On 2017-06-08 23:04:31 -0700, Noah Misch wrote:
> On Wed, Jun 07, 2017 at 10:54:57PM -0700, Noah Misch wrote:
> > On Fri, Jun 02, 2017 at 11:06:29PM -0700, Andres Freund wrote:
> > > On 2017-06-02 22:12:46 -0700, Noah Misch wrote:
> > > > On Fri, Jun 02, 2017 at 11:27:55PM -0400, Peter Eisentraut w
On 06/09/2017 05:47 PM, Jeff Janes wrote:
Your commit to fix this part, 76b11e8a43eca4612d, is giving me compiler
warnings:
fe-connect.c: In function 'connectDBStart':
fe-connect.c:1625: warning: 'ret' may be used uninitialized in this function
gcc version 4.4.7 20120313 (Red Hat 4.4.7-18) (GCC
Jeff Janes writes:
> Your commit to fix this part, 76b11e8a43eca4612d, is giving me compiler
> warnings:
> fe-connect.c: In function 'connectDBStart':
> fe-connect.c:1625: warning: 'ret' may be used uninitialized in this function
Me too ...
> gcc version 4.4.7 20120313 (Red Hat 4.4.7-18) (GCC)
I left out the retry in LWLockAcquire.
ProcArrayLock_part.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 5/24/17 15:34, Tom Lane wrote:
> I wrote:
>> Heikki Linnakangas writes:
>>> +1 for back-patching. If I understand correctly, it would change the
>>> behavior when you pass a string with non-ASCII leading or trailing
>>> whitespace characters to those functions. I suppose that can happen, but
> "Robert" == Robert Haas writes:
Robert> So, Andrew, are you running with this, or should I keep looking
Robert> into it?
I have it; I will post a status update before 23:59 BST on 11 Jun.
--
Andrew (irc:RhodiumToad)
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.or
On Fri, Jun 9, 2017 at 1:45 PM, Peter Eisentraut
wrote:
> On 6/9/17 12:17, Robert Haas wrote:
>> IOW, suppose there
>> were a collation API call distill() which had the property that
>> strcmp(distill(X), distill(Y)) == 0 iff X and Y are considered equal
>> under that collation. Then, you could d
On Fri, Jun 9, 2017 at 12:19 PM, Robert Haas wrote:
> On Thu, Jun 8, 2017 at 11:56 PM, Thomas Munro
> wrote:
>> [Adding Andrew Gierth]
>>
>> Here is a rebased version of the patch to fix transition tables with
>> inheritance. Fixes a typo in an error message ("not support on
>> partitions" -> ".
On 5/31/17 19:59, Neha Khatri wrote:
> Simplifying $subject. There are typos in xlogfuncs.c. So Either
>
> s/pg_xlog_switch/pg_switch_wal
fixed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsq
On Fri, Jun 9, 2017 at 10:45 AM, Robert Haas wrote:
>> But they are getting the sort order they need. They just don't get the
>> equality semantics they expect.
>
> You're right.
If we happened to ever guarantee the user a stable sort, then I'd be
wrong. We don't, though.
--
Peter Geoghegan
On 6/9/17 12:17, Robert Haas wrote:
> IOW, suppose there
> were a collation API call distill() which had the property that
> strcmp(distill(X), distill(Y)) == 0 iff X and Y are considered equal
> under that collation. Then, you could define your hash function as
> hash_any(distill(X)). Alternativ
On Fri, Jun 9, 2017 at 12:18 PM, Peter Geoghegan wrote:
> On Fri, Jun 9, 2017 at 9:17 AM, Robert Haas wrote:
>> I'm not exactly sure what is possible or
>> desirable, but I would not be too surprised to hear complaints about
>> the observed behavior different from the "pure" ICU behavior because
Jeff Janes writes:
> On Fri, Jun 9, 2017 at 9:06 AM, Tom Lane wrote:
>> The issue is how to initialize the state value to begin with.
> Why does it need to be initialized? initializing a NULL state upon first
> use is already the job of sfunc.
Right, but for partial aggregation the combinefunc
On Fri, Jun 9, 2017 at 3:05 AM, Heikki Linnakangas wrote:
> On 06/09/2017 08:56 AM, Supun Nakandala wrote:
>
>> Hi hackers,
>>
>> I am trying to extend PostgreSQL by adding UDT and UDF for a custom use
>> case and I am using C language extensions to do that.
>>
>> However, I have a requirement of
On Fri, Jun 9, 2017 at 9:06 AM, Tom Lane wrote:
> Jeff Janes writes:
> > The docs for creating aggregates for 9.6 and beyond say:
> > "For aggregate functions whose state_data_type is internal, the
> combinefunc
> > must not be strict. In this case the combinefunc must ensure that null
> > state
On Fri, Jun 9, 2017 at 9:17 AM, Robert Haas wrote:
> I'm not exactly sure what is possible or
> desirable, but I would not be too surprised to hear complaints about
> the observed behavior different from the "pure" ICU behavior because
> of the tiebreak, and at least some users might even find it
On Thu, Jun 8, 2017 at 11:56 PM, Thomas Munro
wrote:
> [Adding Andrew Gierth]
>
> Here is a rebased version of the patch to fix transition tables with
> inheritance. Fixes a typo in an error message ("not support on
> partitions" -> "... supported ..."), and changes regression test
> triggers to
On Fri, Jun 9, 2017 at 11:46 AM, Tom Lane wrote:
> Peter Eisentraut writes:
>> On 6/9/17 11:12, Tom Lane wrote:
>>> https://www.postgresql.org/message-id/27064.1134753...@sss.pgh.pa.us
>
>> Good to know. That just says that if we were to go with the strcoll()
>> result only, things would work co
Jeff Janes writes:
> The docs for creating aggregates for 9.6 and beyond say:
> "For aggregate functions whose state_data_type is internal, the combinefunc
> must not be strict. In this case the combinefunc must ensure that null
> states are handled correctly and that the state being returned is p
Peter Eisentraut writes:
> On 6/9/17 11:12, Tom Lane wrote:
>> https://www.postgresql.org/message-id/27064.1134753...@sss.pgh.pa.us
> Good to know. That just says that if we were to go with the strcoll()
> result only, things would work correctly.
There's still the hashing problem.
Peter Eisentraut writes:
> On 6/8/17 23:53, Tom Lane wrote:
>> ! ERROR: publication "addr_pub" does not exist
> The \d+ command attempts to print out any publications that the relation
> is part of. To find the publications it is part of, it runs this query:
> "SELECT pub.pubname\n"
>
On Sat, Jun 10, 2017 at 12:40 AM, Peter Eisentraut
wrote:
> On 6/8/17 21:58, Masahiko Sawada wrote:
>> Attached patch for $subject.
>
> committed
>
Thank you!
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mail
On 6/8/17 21:58, Masahiko Sawada wrote:
> Attached patch for $subject.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make cha
On 6/9/17 11:12, Tom Lane wrote:
> Robert Haas writes:
>> I have to admit that I'm still a little confused about what's actually
>> going on here. Commit says that it "fixes inconsistent behavior under
>> glibc's hu_HU locale", but it doesn't say what sort of inconsistent
>> behavior it fixes.
>
On 6/8/17 23:53, Tom Lane wrote:
> --- 155,161
>
> SET search_path = mvtest_mvschema, public;
> \d+ mvtest_tvm
> ! ERROR: publication "addr_pub" does not exist
> -- modify the underlying table data
> INSERT INTO mvtest_t VALUES (6, 'z', 13);
> -- confirm pre- and post-refresh con
The docs for creating aggregates for 9.6 and beyond say:
"For aggregate functions whose state_data_type is internal, the combinefunc
must not be strict. In this case the combinefunc must ensure that null
states are handled correctly and that the state being returned is properly
stored in the aggre
Robert Haas writes:
> I have to admit that I'm still a little confused about what's actually
> going on here. Commit says that it "fixes inconsistent behavior under
> glibc's hu_HU locale", but it doesn't say what sort of inconsistent
> behavior it fixes.
Unfortunately we were not good back then
On 6/9/17 10:31, Robert Haas wrote:
> + * In some locales strcoll() can claim that nonidentical strings are
> + * equal. Believing that would be bad news for a number of reasons,
> + * so we follow Perl's lead and sort "equal" strings according to
> + * strcmp().
>
On Thu, Jun 8, 2017 at 1:36 AM, Heikki Linnakangas wrote:
> While testing libpq and GSS the other day, I was surprised by the behavior
> of the host and hostaddr libpq options, if you specify a list of hostnames.
>
> I did this this, and it took me quite a while to figure out what was going
> on:
On Fri, Jun 9, 2017 at 10:01 AM, Mithun Cy wrote:
> I have merged Rafia's patch for cosmetic changes. I have also fixed
> some of the changes you have recommended over that. But kept few as it
> is since Rafia's opinion was needed on that.
>
Few comments on the latest patch:
1.
+ /* Check whether
On Fri, Jun 2, 2017 at 2:22 PM, Peter Geoghegan wrote:
> On Fri, Jun 2, 2017 at 10:34 AM, Amit Khandekar
> wrote:
>> Ok. I was thinking we are doing the tie-breaker because specifically
>> strcoll_l() was unexpectedly returning 0 for some cases. Now I get it,
>> that we do that to be compatible
On 6/6/17 23:52, Masahiko Sawada wrote:
> On Wed, Jun 7, 2017 at 12:41 PM, Peter Eisentraut
> wrote:
>> On 6/6/17 04:17, Masahiko Sawada wrote:
>>> With this patch, ALTER SUBSCRIPTION SET PUBLICATION [TAB]
>>> completes with "REFRESH" and "SKIP REFRESH".
>>> Specifying either REFRESH or SKIP REF
On 9 June 2017 at 19:10, Amit Kapila wrote:
> On Thu, Jun 8, 2017 at 10:40 PM, Robert Haas wrote:
>> On Thu, Jun 8, 2017 at 7:01 AM, Amit Kapila wrote:
>>> On Thu, Jun 8, 2017 at 1:33 AM, Robert Haas wrote:
On Wed, Jun 7, 2017 at 5:46 AM, Amit Kapila
wrote:
> As far as I underst
On 6/8/17 13:15, Josh Berkus wrote:
> Well, we *could* provide a system view, as we now do for archiving, and
> for the same reasons.
Which view are you referring to here?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Se
On 6/9/17 02:07, Noah Misch wrote:
> On Tue, Jun 06, 2017 at 03:21:34PM -0400, Peter Eisentraut wrote:
>> On 6/3/17 01:04, Noah Misch wrote:
>>> On Wed, May 31, 2017 at 10:15:50PM -0400, Peter Eisentraut wrote:
On 5/30/17 13:25, Masahiko Sawada wrote:
> I think this cause is that the relat
On 5/30/17 13:25, Masahiko Sawada wrote:
> However there is one more problem here; if the relation status entry
> is deleted while corresponding table sync worker is waiting to be
> changed its status, the table sync worker can be orphaned in waiting
> status. In this case, should table sync worker
Supun Nakandala writes:
> However, I have a requirement of reading a text file from one of the C
> functions. The compiled *.so files are placed in the "pg_config
> --pkglibdir" directory and tried copying my text files there but it didn't
> work. I found that, when these shared libs are loaded th
On Thu, Jun 8, 2017 at 10:40 PM, Robert Haas wrote:
> On Thu, Jun 8, 2017 at 7:01 AM, Amit Kapila wrote:
>> On Thu, Jun 8, 2017 at 1:33 AM, Robert Haas wrote:
>>> On Wed, Jun 7, 2017 at 5:46 AM, Amit Kapila wrote:
As far as I understand, it is to ensure that for deleted rows, nothing
On 6/8/17 03:54, Masahiko Sawada wrote:
> The reproduction step is provided by tushar but I could reproduced it
> with following step.
>
> X cluster ->
> =# select 'create table t' || generate_series(1,100) || '(c
> int);';\gexec -- create 100 tables
> =# create table t (c int); -- create one mor
On Fri, Jun 9, 2017 at 6:36 AM, Heikki Linnakangas wrote:
> Right. I think it's a usability fail as it is; it certainly fooled me. We
> could make the error messages and documentation more clear. But even better
> to allow multiple host addresses, so that it works as you'd expect.
Sure, I don't h
On 06/08/2017 11:09 PM, Noah Misch wrote:
> On Wed, Jun 07, 2017 at 08:45:20AM -0700, Joe Conway wrote:
>> On 06/07/2017 06:49 AM, Mike Palmiotto wrote:
>> > I ended up narrowing it down to 4 tables (one parent and 3 partitions)
>> > in order to demonstrate policy sorting and order of RLS/partition
On 6/8/17 01:57, Noah Misch wrote:
> On Fri, Jun 02, 2017 at 11:51:26AM -0700, Andres Freund wrote:
>> commit 7c4f52409a8c7d85ed169bbbc1f6092274d03920
>> Author: Peter Eisentraut
>> Date: 2017-03-23 08:36:36 -0400
>>
>> Logical replication support for initial data copy
>>
>> made walreceiver
May be we should pass a flag to predicate_implied_by() to handle NULL
behaviour for CHECK constraints. Partitioning has shown that it needs
to use predicate_implied_by() for comparing constraints and there may
be other cases that can come up in future. Instead of handling it
outside predicate_impli
On Fri, Jun 9, 2017 at 10:31 AM, Amit Langote
wrote:
> On 2017/06/08 19:25, Ashutosh Bapat wrote:
>> On Thu, Jun 8, 2017 at 3:13 PM, Amit Langote
I think this code could be removed entirely in light of commit
3ec76ff1f2cf52e9b900349957b42d28128b7bc7.
>>>
>>> I am assuming you think that
I'm looking at this recent failure:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mandrill&dt=2017-06-08%2023%3A54%3A12
which is
*** /home/nm/farm/xlc32/HEAD/pgsql.build/src/test/regress/expected/matview.out
Thu Jun 8 23:55:50 2017
--- /home/nm/farm/xlc32/HEAD/pgsql.build/src/test/reg
On 06/08/2017 06:18 PM, Robert Haas wrote:
On Thu, Jun 8, 2017 at 10:50 AM, Tom Lane wrote:
Robert Haas writes:
It doesn't seem like a problem to me if somebody else wants to extend
it to hostaddr, though. Whether that change belongs in v10 or v11 is
debatable. I would object to adding this
On Fri, Jun 9, 2017 at 3:22 PM, Heikki Linnakangas wrote:
> Hmm, there is one problem with our current use of comma as a separator:
you
> cannot use a Unix-domain socket directory that has a comma in the name,
> because it's interpreted as multiple hostnames. E.g. this doesn't work:
>
> psql "host
On 06/08/2017 06:39 PM, David G. Johnston wrote:
These are already failing so I'd agree that explicit rejection isn't
necessary - the question seems restricted to usability. Though I suppose
we need to consider whether there is any problem with the current setup if
indeed our intended separator
Hi,
> To develop the ECPG application more efficiently and improve
> portability,
> I would like to suggest one minor improvement "WHENEVER condition DO
> CONTINUE" support in ECPG.
> Oracle Pro*C supports WHENEVER statement with DO CONTINUE action.[1]
>
> EXEC SQL WHENEVER SQLERROR CONTINUE;
> i
Attached please find rebased version of the patch.
Now "projection" attribute is used instead of surjective/injective.
--
Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
diff --git a/doc/src/sgml/ref/create_index.sgml b/doc/src/sgml/ref/create_i
Hello,
To develop the ECPG application more efficiently and improve portability,
I would like to suggest one minor improvement "WHENEVER condition *DO
CONTINUE*" support in ECPG.
Oracle Pro*C supports WHENEVER statement with DO CONTINUE action.[1]
EXEC SQL WHENEVER SQLERROR CONTINUE;
is not sa
Andres Freund wrote:
> Looking at 0001:
> - GetOldestSafeDecodingTransactionId() only guarantees to return an xid
> safe for decoding (note how procArray->replication_slot_catalog_xmin
> is checked), not one for the initial snapshot - so afaics this whole
> exercise doesn't guarantee much s
On 06/09/2017 08:56 AM, Supun Nakandala wrote:
Hi hackers,
I am trying to extend PostgreSQL by adding UDT and UDF for a custom use
case and I am using C language extensions to do that.
However, I have a requirement of reading a text file from one of the C
functions. The compiled *.so files are
72 matches
Mail list logo