Re: [HACKERS] PATCH: two slab-like memory allocators

On 25/09/16 22:17, Tomas Vondra wrote: > On 09/25/2016 08:48 PM, Petr Jelinek wrote: > >> Slab: >> In general it seems understandable, the initial description helps to >> understand what's happening well enough. >> >> One thing I don't understand however

Re: [HACKERS] PATCH: two slab-like memory allocators

I am not quite sure about those FIXME functions (Free, Realloc, GetChunkSpace). It's slightly weird to call to mcxt but I guess the alternative there is to error out so this is probably preferable. Would want to hear other opinions here. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Logical Replication WIP

;cache" is perhaps inappropriate for LogicalRepRelMap, because it > implies that the value can be gotten from elsewhere if it's not in the > cache. In this case it's really session state that cannot be recovered > easily.) > Yeah I have different code and error for that now. -

Re: [HACKERS] ICU integration

conversion functions could use some docs. I wonder if some of the pieces of the code with following pattern: if (mylocale->provider == COLLPROVIDER_ICU) do lot's of icu stuff else call posix function should move the icu code to separate functions, it would certainly imp

Re: [HACKERS] Quorum commit for multiple synchronous replication.

rg/message-id/CAB7nPqRDvJn18e54ccNpOP1A2_iUN6-iU=4njgmmgiagvcs...@mail.gmail.com > > I misunderstood your intent, then. But I still stand by what I did > understand, namely that 'k (...)' should mean 'any k (...)'. It's much > more natural than having it mean 'first k (...)' and I

Re: [HACKERS] Logical Replication WIP

ng though because the slot creation needs snapshot and it will wait forever for the current query to finish. So it will never really work. The hanging query is now abortable though. Question is if doing the logical snapshot is really required since we don't really use the snapshot for anything here. -

Re: [HACKERS] Rename max_parallel_degree?

ht be premature. > > My main reason for wanting is that I suspect there will be a similar > desire to limit the number of replication workers at some point. > Yes there definitely is desire to use this for replication workers as well. The logical replication launcher currently hand

Re: [HACKERS] Logical Replication WIP

On 14/09/16 21:53, Andres Freund wrote: Hi, On 2016-09-14 21:17:42 +0200, Petr Jelinek wrote: +/* + * Gather Relations based o provided by RangeVar list. + * The gathered tables are locked in access share lock mode. + */ Why access share? Shouldn't we make this ShareUpdateExclusive

Re: [HACKERS] Logical Replication WIP

On 14/09/16 18:21, Andres Freund wrote: (continuing, uh, a bit happier) On 2016-09-09 00:59:26 +0200, Petr Jelinek wrote: +/* + * Relcache invalidation callback for our relation map cache. + */ +static void +logicalreprelmap_invalidate_cb(Datum arg, Oid reloid

Re: [HACKERS] Logical Replication WIP

of these that perform better but also behave correctly (in terms of triggers and stuff for example). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make cha

Re: [HACKERS] Logical Replication WIP

On 14/09/16 00:48, Andres Freund wrote: First read through the current version. Hence no real architectural comments. Hi, Thanks for looking! On 2016-09-09 00:59:26 +0200, Petr Jelinek wrote: diff --git a/src/backend/commands/publicationcmds.c b/src/backend/commands/publicationcmds.c

Re: [HACKERS] autonomous transactions

useful functionality but the naming is clearly contentious. It won't stop people using it for same use-cases as autonomous transactions though (which is fine). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent

Re: [HACKERS] Logical Replication WIP

On 13/09/16 02:55, Craig Ringer wrote: On 13 September 2016 at 06:03, Petr Jelinek <p...@2ndquadrant.com> wrote: Oh sure, I don't see that as big problem, the TupleData already contains type of the data it sends (to distinguish between nulls and text data) so that's mostly about addin

Re: [HACKERS] Logical Replication WIP

On 12/09/16 22:21, Andres Freund wrote: On 2016-09-12 21:57:39 +0200, Petr Jelinek wrote: On 12/09/16 21:54, Andres Freund wrote: On 2016-09-12 21:47:08 +0200, Petr Jelinek wrote: On 09/09/16 06:33, Peter Eisentraut wrote: The start_replication option pg_version option is not documented

Re: [HACKERS] Logical Replication WIP

On 12/09/16 21:54, Andres Freund wrote: On 2016-09-12 21:47:08 +0200, Petr Jelinek wrote: On 09/09/16 06:33, Peter Eisentraut wrote: The start_replication option pg_version option is not documented and not used in any later patch. We can probably do without it and just rely on the protocol

Re: [HACKERS] Logical Replication WIP

ing. The "proper" way to do this is probably to define a custom set of PQcommMethods. (low priority) If we change that, I'd probably rather go with direct use of StringInfo functions. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Supp

Re: [HACKERS] Quorum commit for multiple synchronous replication.

to me for a new feature that is going to be GA soon. Indeed. I'll vote for pulling a fast one on 9.6 for this. +1 -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgs

Re: [HACKERS] Logical Replication WIP

Hi, On 07/09/16 14:10, Erik Rijkers wrote: On 2016-08-31 22:51, Petr Jelinek wrote: and one more version with bug fixes, improved code docs and couple I am not able to get the replication to work. Would you (or anyone) be so kind to point out what I am doing wrong? Patches applied

Re: [HACKERS] Logical Replication WIP

it's potential issue, don't have good solution for it either. It's loosely coupled system so we can't have 100% control over everything. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mai

Re: [HACKERS] Logical Replication WIP

On 06/09/16 20:14, Peter Eisentraut wrote: On 9/3/16 5:14 AM, Petr Jelinek wrote: What are the BKI_ROWTYPE_OID assignments for? Are they necessary here? (Maybe this was just copied from pg_subscription?) Yes they are. Please explain/document why. It does not match other catalogs, which

Re: [HACKERS] Logical Replication WIP

On 01/09/16 08:29, Erik Rijkers wrote: On 2016-09-01 01:04, Erik Rijkers wrote: On 2016-08-31 22:51, Petr Jelinek wrote: Here are some small changes to logical-replication.sgml ... and other .sgml files. Thanks I'll integrate these into next iteration of the patch, -- Petr Jelinek

Re: [HACKERS] Proposal for changes to recovery.conf API

On 06/09/16 13:52, David Steele wrote: On 9/6/16 4:56 AM, Petr Jelinek wrote: On 06/09/16 07:18, Abhijit Menon-Sen wrote: Do we want something like this (easy to implement and document, perhaps not especially convenient to use): recovery_target = 'xid' # or 'time'/'name'/'lsn

Re: [HACKERS] Logical Replication WIP

On 05/09/16 23:35, Steve Singer wrote: On 09/05/2016 03:58 PM, Steve Singer wrote: On 08/31/2016 04:51 PM, Petr Jelinek wrote: Hi, and one more version with bug fixes, improved code docs and couple more tests, some general cleanup and also rebased on current master for the start of CF

Re: [HACKERS] Logical Replication WIP

On 05/09/16 21:58, Steve Singer wrote: On 08/31/2016 04:51 PM, Petr Jelinek wrote: Hi, and one more version with bug fixes, improved code docs and couple more tests, some general cleanup and also rebased on current master for the start of CF. To get the 'subscription' TAP tests to pass I

Re: [HACKERS] Proposal for changes to recovery.conf API

ke sense to have single config option for it IMHO. So +1 on the recovery_target = 'xid:xxx' idea. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] Logical decoding slots can go backwards when used from SQL, docs are wrong

output of that function? -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Logical Replication WIP

On 03/09/16 18:04, Tom Lane wrote: Petr Jelinek <p...@2ndquadrant.com> writes: On 02/09/16 22:57, Peter Eisentraut wrote: The new system catalog pg_publication_rel has columns pubid, relid, and does not use the customary column name prefixes. Maybe that is OK here. I can't actually

Re: [HACKERS] Logical Replication WIP

nd ALTER PUBLICATION FOR TABLE / FOR ALL TABLES confusing. Maybe that should be SET TABLE or something. Yeah I am not sure what is the best option there. SET was also what I was thinking but then it does not map well to the CREATE PUBLICATION syntax and I would like to have some harm

Re: [HACKERS] [PATCH] Transaction traceability - txid_status(bigint)

this functionality in other places as part of dealing with the problems discussed upthread with 'xid' exposed to users. You could put it to txid.c where all the other txid stuff is in? -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Train

Re: [HACKERS] Logical decoding slots can go backwards when used from SQL, docs are wrong

for repeated data on crash anyway. Correct me if I am wrong but I think the only situation where it would matter is on server that restarts often or crashes often (as the logical decoding then has to do the work many times) but I don't think it's worth optimizing for that kind of sce

Re: [HACKERS] autonomous transactions

ing xact-scoped stuff in globals for that to be viable. Caches alone. Peter will be able to explain more, I'm sure. I can also see some advantages in bgworker approach. For example it could be used for "fire and forget" type of interface in the future, where you return as soon as you send exec and don't c

Re: [HACKERS] pg_sequence catalog

cation functionality. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Renaming of pg_xlog and pg_clog

g_xact/trans (don't care really which one) And +1 for renaming pg_logical to something more reasonable. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.or

Re: [HACKERS] Logical decoding of sequence advances, part II

make the nextval() operation sometimes transactional and other times non-transactional. Well, that's what Craig is trying to do by tracking if the transactional change has happend on a sequence in current transaction, no? -- Petr Jelinek http://www.2ndQuadrant.com/ Postgr

Re: [HACKERS] [PATCH] Transaction traceability - txid_status(bigint)

On 23/08/16 11:27, Craig Ringer wrote: On 23 Aug 2016 16:02, "Petr Jelinek" <p...@2ndquadrant.com <mailto:p...@2ndquadrant.com>> wrote: On 23/08/16 02:55, Craig Ringer wrote: On 23 August 2016 at 01:03, Robert Haas <robertmh...@gmail.com <mailto:robertmh...@

Re: [HACKERS] LSN as a recovery target

on failure: FATAL: invalid input syntax for type pg_lsn: "popo" CONTEXT: line 11 of configuration file "recovery.conf", parameter "recovery_target_lsn" Looks very reasonable to me (both patches). Thanks for doing that. I am inclined to mark this as ready for com

Re: [HACKERS] [PATCH] Transaction traceability - txid_status(bigint)

bout the 3rd patch though. I wonder if it would not be better to have the opposite function instead - converting xid to txid as that will always work and does not have to have the NULL case and would be simpler in terms of code. -- Petr Jelinek http://www.2ndQuadrant

Re: [HACKERS] Logical decoding slots can go backwards when used from SQL, docs are wrong

ack-patched all the way to 9.4. I didn't look at the other one. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscriptio

Re: [HACKERS] LSN as a recovery target

On 20/08/16 02:13, Michael Paquier wrote: On Fri, Aug 19, 2016 at 10:47 PM, Adrien Nayrat wrote: I reviewed this patch rebased to deal with f6ced51f9188ad5806219471a0b40a91dde923aa, and minor adjustment (see below) Thanks! It do the job. However if you use an

Re: [HACKERS] Logical decoding restart problems

On 19/08/16 18:36, Konstantin Knizhnik wrote: On 19.08.2016 19:06, Petr Jelinek wrote: I don't think this will work correctly, there will be gap between when the new slot starts to decode and the drop of the old one as the new slot first needs to make snapshot. Do I understand correctly

Re: [HACKERS] Logical decoding restart problems

ction forwarding you are doing (See BDR and/or pglogical code for example of that). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to y

Re: [HACKERS] Logical Replication WIP

On 15/08/16 15:51, Stas Kelvich wrote: On 11 Aug 2016, at 17:43, Petr Jelinek <p...@2ndquadrant.com> wrote: * Also I wasn’t able actually to run replication itself =) While regression tests passes, TAP tests and manual run stuck. pg_subscription_rel.substate never becomes ‘r’.

Re: [HACKERS] Logical Replication WIP

On 13/08/16 17:34, Steve Singer wrote: On 08/05/2016 11:00 AM, Petr Jelinek wrote: Hi, as promised here is WIP version of logical replication patch. Thanks for keeping on this. This is important work Feedback is welcome. + + Publication + +A Publication object can be defined

Re: [HACKERS] Logical Replication WIP

really like so I want to limit them to the places where they are actually useful. On 05 Aug 2016, at 18:00, Petr Jelinek <p...@2ndquadrant.com> wrote: - DDL, I see several approaches we could do here for 10.0. a) don't deal with DDL at all yet, b) provide function which pushes t

Re: [HACKERS] multivariate statistics (v19)

dimension (the actual histogram building algorithm is more complex, but you get the idea). I think it makes sense to pursue this, but I also think we can easily live with not having it in the first version that gets committed and doing it as follow-up patch. -- Petr Jelinek

Re: [HACKERS] Logical Replication WIP

framework for managing the max workers using tags or something as part of this, it's big enough as it is and we can always move the limit to the more generic place once we have it. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Logical Replication WIP

o it can't really start workers for logical replication. I actually modeled it more after autovacuum (using bgworkers though) than the original extension. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql

Re: [HACKERS] Logical Replication WIP

On 09/08/16 09:59, Masahiko Sawada wrote: On 2016-08-05 17:00:13 +0200, Petr Jelinek wrote: as promised here is WIP version of logical replication patch. Thank you for working on this! Thanks for looking! I've applied these patches to current HEAD, but got the following error

Re: [HACKERS] Quorum commit for multiple synchronous replication.

ethod for each purpose. I think the "any" keyword is more explicit and understandable, also closer to SQL. So I would be in favor of doing that. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services --

Re: [HACKERS] BRIN vs. HOT

be HOT or not, but I like you idea more. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql

Re: [HACKERS] Design for In-Core Logical Replication

ION mypub2; This does not yet, but I agree we should have it. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subs

Re: [HACKERS] Design for In-Core Logical Replication

y... Just to add to what Simon wrote. There is one more reason for not using term origin for this - origin of data does not necessarily have to be on the provider database once there is a cascading so it does not really map all that well. -- Petr Jelinek http://www.2nd

Re: [HACKERS] A Modest Upgrade Proposal

first. Agreed. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] A Modest Upgrade Proposal

functions for manipulating slots and origins as those are just primitives which user should not have to fiddle with but for things that are directly meant for user interaction DDL just feels better. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24

Re: [HACKERS] A Modest Upgrade Proposal

ect logical replication patch to do all that, because if you do, you'll be disappointed. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] A Modest Upgrade Proposal

definitions in catalogs though. It's not like we want to do any kind of RPC to add table to replication set on the remote node. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing lis

Re: [HACKERS] A Modest Upgrade Proposal

s), I definitely think we should dump replication sets and their membership info for example. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To ma

Re: [HACKERS] Rename max_parallel_degree?

On 01/06/16 17:55, David G. Johnston wrote: On Wed, Jun 1, 2016 at 11:45 AM, Petr Jelinek <p...@2ndquadrant.com <mailto:p...@2ndquadrant.com>>wrote: That GUC also controls worker processes that are started by extensions, not just ones that parallel query starts. This is

Re: [HACKERS] Rename max_parallel_degree?

bout how the current limits work, the parallel query will fight for workers with extensions because they share the same limit. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hack

Re: [HACKERS] 10.0

rename clause where nobody wanted to rewrite couple thousand function which used it and there are many examples like that). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (p

Re: [HACKERS] 10.0

On 13/05/16 20:31, Alvaro Herrera wrote: Josh berkus wrote: Anyway, can we come up with a consensus of some minimum changes it will take to make the next version 10.0? I think the next version should be 10.0 no matter what changes we put in. +1 -- Petr Jelinek http

Re: [HACKERS] 10.0

to bump to 10, 11, etc. We can't possibly get all the major features people want into single release given the yearly release cycle. That being said, I think that once we released beta1 as 9.6 it's too late for bumping it. -- Petr Jelinek http://www.2ndQuadrant.com/ Post

Re: [HACKERS] Processes and caches in postgresql

oper feature and you should not use it for deploying anything. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your su

Re: [HACKERS] VS 2015 support in src/tools/msvc

t;caecilian" reported first successful build to the buildfarm. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to you

Re: [HACKERS] 9.6 and fsync=off

updates, and I'm fine with that). +1 (Abhijit's wording with data loss changed to data corruption) -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] VS 2015 support in src/tools/msvc

ify a single one that was clearly not created or edited by anything other than Visual Studio itself. I did some checking too, and yes it seems having version 12 .sln is fine or maybe even desirable. We mainly need to make sure that the tools version is 14 and platform toolset is v140 for MSVC15. -

[HACKERS] pg_stat_activity crashes

which is what this patch does though. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c index 64c4cc4..355e58c 100644 --- a/src/bac

Re: [HACKERS] Pglogical questions and problems

syntax that's not part of standard to death halting the actual feature development for prolonged time periods as a result. Finally a side note about sharding - I have strong believe that sharding needs to be tightly coupled to be effective and maintainable in production. -- Petr Jelinek

Re: [HACKERS] Pglogical questions and problems

PGCon, and I don't think Petr is either. That's unfortunate in terms of planning for this. That's a bummer. I suppose you won't be at NYC either? No NYC either. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -

Re: [HACKERS] VS 2015 support in src/tools/msvc

rry is that given that the header file is obviously unfinished in the area where this is defined and also the fact that this looks like something that's not meant to be used outside of that header makes people worry that it might change between point releases of the SDK. -- Petr Jelinek

Re: [HACKERS] VS 2015 support in src/tools/msvc

, but just in 12 hours or so, aka after the deadline if that matters for this patch. I won't be able to get back to it (well mainly to windows environment) till Thursday due to travel, sorry. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 S

Re: [HACKERS] Timeline following for logical slots

recovering from error rather than being hell bent on preventing it is something I am pushing as well. For example it should be easier to look at what's in replication queue and remove things from there if needed. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Develop

Re: [HACKERS] Proposal: Generic WAL logical messages

On 07/04/16 12:26, Andres Freund wrote: Hi, On 2016-04-06 20:03:20 +0200, Petr Jelinek wrote: Attached patch adds filtering of both database and origin. Added tests with slightly less hardcoding than what you proposed above. Not a fan of creating & dropping another database - that's re

Re: [HACKERS] VS 2015 support in src/tools/msvc

On 07/04/16 00:50, Michael Paquier wrote: On Thu, Apr 7, 2016 at 7:44 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: On Thu, Apr 7, 2016 at 6:11 AM, Petr Jelinek <p...@2ndquadrant.com> wrote: On 06/04/16 22:50, Andrew Dunstan wrote: I have spent way too much time on th

Re: [HACKERS] VS 2015 support in src/tools/msvc

mpiler. It's fun to set it up yes. I do have the machine with buildfarm client ready still (although now also traveling so slightly complicated to get to it) but I didn't activate it yet as I don't want it to just report failures forever. -- Petr Jelinek http://www.2ndQuadra

Re: [HACKERS] Proposal: Generic WAL logical messages

. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/contrib/test_decoding/expected/messages.out b/contrib/test_decoding/expected/messages.out index 70130e9..a5b13c5 100644 --- a/contrib/test_decoding/expe

Re: [HACKERS] [PATH] Jsonb, insert a new value into an array at arbitrary position

onable. Here is a new version of patch (it will throw an error for an existing key). Is it better now? This seems like reasonable compromise to me. I wonder if the errcode should be ERRCODE_INVALID_PARAMETER_VALUE but don't feel too strongly about that. -- Petr Jelinek

Re: [HACKERS] Timeline following for logical slots

her people would, too. I agree with the exception of working HA. I would consider it very sad if we got logical replication in core without having any provision for continuity of service. Doing that is relatively trivial in comparison to the logical replication itself however. -- Pe

Re: [HACKERS] Sequence Access Method WIP

On 04/04/16 15:53, Fabrízio de Royes Mello wrote: On Thu, Mar 31, 2016 at 9:19 AM, Petr Jelinek <p...@2ndquadrant.com <mailto:p...@2ndquadrant.com>> wrote: > > Hi, > > new version attached that should fix the issue. It was alignment - honestly don't know what I

Re: [HACKERS] Timeline following for logical slots

ded catalog xmin and lsn (simple way of doing that would be to add this to feedback protocol and let physical slot to keep the xmin/lsn as well), but that does not mean timeline following isn't good thing on it's own (not to mention that iterative development is a thing). -- Petr Jeli

Re: [HACKERS] Timeline following for logical slots

onable continuation of service when the original master dies. And waiting until we have logical that's on par with physical for failover will take long time as it needs the above. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &

Re: [HACKERS] Proposal: Generic WAL logical messages

Hi, I rebased this patch on top of current master as the generic wal commit added some conflicting changes. Also fixed couple of typos in comments and added non ascii message to test. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [HACKERS] Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches

have a look at whether you have core dumps from these? If so, > backtraces would be very useful. > The function does following: TransactionId new_xmin = (TransactionId) PG_GETARG_INT64(1); And we are passing NULL as that parameter, that could explain this. Also while reading it I wonder if

Re: [HACKERS] Sequence Access Method WIP

avoid reading as "is_initIALIZED" Sounds good. DEPENDS ON 0001-seqam-v10.patch , which isn't commited yet --- and it doesn't apply cleanly to current git master. Please update/rebase the patch and resubmit. The current version of seqam is 0001-seqam-2016-03-29 which should apply

Re: [HACKERS] Sequence Access Method WIP

On 29/03/16 22:08, Fabrízio de Royes Mello wrote: On Tue, Mar 29, 2016 at 4:59 PM, Petr Jelinek <p...@2ndquadrant.com <mailto:p...@2ndquadrant.com>> wrote: > > On 29/03/16 19:46, Fabrízio de Royes Mello wrotez >> >> >> > >> > Hmm I a

Re: [HACKERS] Sequence Access Method WIP

E. Hmm nothing special indeed, still can't reproduce, I did one blind try for a fix. Can you test with attached? -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services >From 7f42f2b420e2b931e1ca013f3fdeaccf302f3618 Mon Sep

Re: [HACKERS] WIP: Access method extendability

my merge 13, but somehow the diff was broken so now I just sent diff against Alexander's work with mine + Alvaro's changes, sorry for confusion. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hac

Re: [HACKERS] WIP: Access method extendability

be size of page plus size of fragment >+ * header. >+ */ >+ #define FRAGMENT_HEADER_SIZE (2 * sizeof(OffsetNumber)) >+ #define MATCH_THRESHOLD FRAGMENT_HEADER_SIZE >+ #define MAX_DELTA_SIZE BLCKSZ + FRAGMENT_HEADER_SIZE I incorporated your changes and did some

Re: [HACKERS] WIP: Access method extendability

it is. It's not perfect but it's better (I am not native speaker either). It's same as v12, just changed comments somewhat. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/src/backend/access/rmgrdesc/Makefile b

Re: [HACKERS] VS 2015 support in src/tools/msvc

have machine ready, waiting for animal name and secret. It will obviously fail until we push the 0002 and 0004 though. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing lis

Re: [HACKERS] Relation extension scalability

? It seems so, do you have ability to reasonably test with 64 clients? I am mostly wondering if we see the performance going further down or just plateau. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via p

Re: [HACKERS] VS 2015 support in src/tools/msvc

break other Windows builds? I mean, if we've got the names for those symbols wrong, how is this working right now? We didn't older versions just defined the other variants as well, but the _timezone and _tzname have been around since at least VS2003. -- Petr Jelinek http

Re: [HACKERS] Relation extension scalability

like this name, but I could not come up with any better, Please suggest one. GetNearestPageWithFreeSpace? (although not sure that's accurate description, maybe Nearby would be better) -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] VS 2015 support in src/tools/msvc

; a couple of times. Hmm I see you are right, I missed the last couple emails. Ok I'll mark it ready for committer - it does work fine on my vs2015 machine and I am happy with the code too. Well, as happy as I can be given the locale mess. -- Petr Jelinek http://www.2ndQu

Re: [HACKERS] Relation extension scalability

On 23/03/16 20:43, Robert Haas wrote: On Wed, Mar 23, 2016 at 3:33 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: Btw thinking about it some more, ISTM that not finding the block and just doing the extension if the FSM wasn't extended correctly previously is probably cleaner behavior tha

Re: [HACKERS] Relation extension scalability

On 23/03/16 20:19, Petr Jelinek wrote: On 23/03/16 20:01, Robert Haas wrote: On Wed, Mar 23, 2016 at 2:52 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: Second, if the other backend extended the relation in some other manner and did not extend the FSM, how does c

Re: [HACKERS] Relation extension scalability

On 23/03/16 20:01, Robert Haas wrote: On Wed, Mar 23, 2016 at 2:52 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: Second, if the other backend extended the relation in some other manner and did not extend the FSM, how does calling RecordAndGetPageWithFreeSpace help? As far as I c

Re: [HACKERS] Relation extension scalability

On 23/03/16 19:39, Robert Haas wrote: On Tue, Mar 22, 2016 at 1:12 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: I also think the code simplicity makes this worth it. Agreed. I went over this patch and did a cleanup pass today. I discovered that the LockWaiterCount() function was

Re: [HACKERS] multivariate statistics v14

itting the functionality into patchset. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mail

Re: [HACKERS] Proposal: Generic WAL logical messages

On 23/03/16 14:17, Alvaro Herrera wrote: Petr Jelinek wrote: +++ b/contrib/test_decoding/sql/messages.sql @@ -0,0 +1,17 @@ +-- predictability +SET synchronous_commit = on; + +SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_decoding'); + +SELECT 'msg1' FROM

<    1   2   3   4   5   6   7   8   9   10   >