Re: [Piglit] [PATCH] fbo-blit-scaled-linear: Use const reference.

Looks good. From: Piglit on behalf of Vinson Lee Sent: 16 December 2014 01:17 To: piglit@lists.freedesktop.org Subject: [Piglit] [PATCH] fbo-blit-scaled-linear: Use const reference. Fix Coverity "big parameter passed by value" defect. Signed-off-by: Vin

Re: [Piglit] [PATCH] glsl-deriv-varyings: Added checks for derivatives on parameters with negative or abs modifiers

On Mon, Dec 15, 2014 at 7:11 PM, Matt Turner wrote: > On Mon, Dec 15, 2014 at 5:01 PM, Vinson Lee wrote: >> On Mon, Dec 15, 2014 at 11:05 AM, Matt Turner wrote: >>> Reviewed-by: Matt Turner >>> ___ >>> Piglit mailing list >>> Piglit@lists.freedesktop.

Re: [Piglit] [PATCH 01/24] arb_direct_state_access: DSA 2D Textures "hello world" test.

Did you mean to leave the non-DSA nvidia workaround in here? I understand this might have been useful for getting it working initially, but... if their driver is broken, it's broken. On Tue, Dec 16, 2014 at 2:24 PM, Laura Ekstrand wrote: > Dylan Baker: all.py: Add dsa tests. > --- > tests/all.py

Re: [Piglit] [PATCH] glsl-deriv-varyings: Added checks for derivatives on parameters with negative or abs modifiers

On Mon, Dec 15, 2014 at 5:01 PM, Vinson Lee wrote: > On Mon, Dec 15, 2014 at 11:05 AM, Matt Turner wrote: >> Reviewed-by: Matt Turner >> ___ >> Piglit mailing list >> Piglit@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/4] utils: add initial WAFFLE_WGL support

On 15 December 2014 at 23:24, Dave Airlie wrote: > On 16 December 2014 at 07:57, Emil Velikov wrote: >> On 15/12/14 20:56, Jason Ekstrand wrote: >>> >>> >>> On Fri, Nov 21, 2014 at 11:52 AM, Emil Velikov >> > wrote: >>> >>> This will allow us to use waffle wit

[Piglit] [PATCH] arb_copy_image-targets: Add comments to silence Coverity defects.

Silence Coverity "missing break in switch" defects. Signed-off-by: Vinson Lee --- tests/spec/arb_copy_image/targets.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/arb_copy_image/targets.c b/tests/spec/arb_copy_image/targets.c index 86edeca..333631c 100644 --- a/tests/spec/ar

[Piglit] [PATCH 24/24] ext_packed_float: Refactored the getteximage-invalid-format-for-packed-type.c test.

I added comments and refactored the test into a newer Piglit style. This helped me diagnose some difficulties with Mesa's glGetTextureImage implementation. --- .../getteximage-invalid-format-for-packed-type.c | 105 + 1 file changed, 64 insertions(+), 41 deletions(-) diff -

[Piglit] [PATCH 22/24] arb_texture_rectangle: Updated error conditions to match the OpenGL 4.5 and ES 3.1 core specs.

--- .../texture-base-level-error.c | 35 +++--- 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/tests/spec/arb_texture_rectangle/texture-base-level-error.c b/tests/spec/arb_texture_rectangle/texture-base-level-error.c index 7a20f93..6c8ba56 10064

[Piglit] [PATCH 16/24] arb_direct_state_access: Added a test for glTextureStorage2DMultisample.

--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../texture-storage-multisample.c | 334 + 3 files changed, 336 insertions(+) create mode 100644 tests/spec/arb_direct_state_access/tex

[Piglit] [PATCH 21/24] general: Testing really basic texture errors.

Tests errors thrown by glGenTextures, glBindTexture, and glDeleteTextures. Oddly enough, these didn't seem to be tested elsewhere. --- tests/all.py| 1 + tests/general/CMakeLists.gl.txt | 1 + tests/general/tex-errors.c | 74 + 3 f

[Piglit] [PATCH 12/24] arb_direct_state_access: Add tests for non-generated texture object names passed to glTextureParameter.

From: Dylan Baker glTextureParameter requires that the texture argument be an OpenGL-generated texture name, such as one provided by glCreateTextures, or it should raise an GL_INVALID_OPERATION error. --- .../spec/arb_direct_state_access/texture-errors.c | 42 +- 1 file chan

[Piglit] [PATCH 13/24] arb_direct_state_access: Modified gettexture-image-formats.c to test glGenerateTextureMipmap.

--- tests/all.py | 1 + tests/spec/arb_direct_state_access/gettextureimage-formats.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/all.py b/tests/all.py index b79ae8b..6d20035 100644 --- a/tests/all.py +++ b/tests/all.

[Piglit] [PATCH 11/24] arb_direct_state_access: Added tests for glGetCompressedTextureImage.

--- tests/all.py | 3 +- .../spec/arb_direct_state_access/CMakeLists.gl.txt | 2 + .../compressedtextureimage.c | 288 ++ .../getcompressedtextureimage.c| 418 + tests/util/piglit-ut

[Piglit] [PATCH 08/24] arb_direct_state_access: Added tests for glGetTexLevelParameterfv to texture-storage.c

--- .../spec/arb_direct_state_access/texture-storage.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/spec/arb_direct_state_access/texture-storage.c b/tests/spec/arb_direct_state_access/texture-storage.c index 5838146..16bd39d 100644 --- a/tests/spec/arb_direct_

[Piglit] [PATCH 18/24] arb_direct_state_access: Testing glTextureStorage3DMultisample.

--- .../texture-storage-multisample.c | 59 ++ 1 file changed, 59 insertions(+) diff --git a/tests/spec/arb_direct_state_access/texture-storage-multisample.c b/tests/spec/arb_direct_state_access/texture-storage-multisample.c index f069245..f0437d4 100644 ---

[Piglit] [PATCH 04/24] arb_direct_state_access: Added glCreateTextures test.

--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../spec/arb_direct_state_access/create-textures.c | 80 ++ 3 files changed, 82 insertions(+) create mode 100644 tests/spec/arb_direct_state_access/create-

[Piglit] [PATCH 19/24] arb_direct_state_access: Added test for glCompressedTextureSubImage1D.

--- .../arb_direct_state_access/getcompressedtextureimage.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tests/spec/arb_direct_state_access/getcompressedtextureimage.c b/tests/spec/arb_direct_state_access/getcompressedtextureimage.c index abbffcf..7d6aba8 100644 --- a/te

[Piglit] [PATCH 14/24] arb_direct_state_access: Add additional error checking for *TextureParameter

From: Dylan Baker This adds checking for additional types of errors. --- .../spec/arb_direct_state_access/texture-errors.c | 244 ++--- 1 file changed, 159 insertions(+), 85 deletions(-) diff --git a/tests/spec/arb_direct_state_access/texture-errors.c b/tests/spec/arb_direct_s

[Piglit] [PATCH 09/24] arb_direct_state_access: Added tests for CopyTextureSubImage*D.

--- tests/all.py | 2 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 2 + .../arb_direct_state_access/copytexturesubimage.c | 293 + .../spec/arb_direct_state_access/texture-errors.c | 134 ++ 4 files changed, 431 inse

[Piglit] [PATCH 06/24] arb_direct_state_access: DSA texunits test (adapted from tests/general)

This doesn't test one specific DSA function, but rather tests how DSA and traditional functions get along. --- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + tests/spec/arb_direct_state_access/texunits.c | 383 ++

[Piglit] [PATCH 15/24] arb_direct_state_access: Most error checking for TextureParameter functions

From: Dylan Baker This covers all cases except the: GL_INVALID_ENUM is generated if params should have a defined constant value (based on the value of pname) and does not. case. arb_direct_state_access: Fixed minor nits in texture-errors.c. --- .../spec/arb_direct_state_access/texture-e

[Piglit] [PATCH 20/24] arb_direct_state_access: Added test for glTextureBuffer.

--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../spec/arb_direct_state_access/texture-buffer.c | 106 + 3 files changed, 108 insertions(+) create mode 100644 tests/spec/arb_direct_state_access/text

[Piglit] [PATCH 23/24] arb_texture_storage_multisample: Updated error conditions to match the OpenGL 4.5 and ES 3.1 core specs.

--- .../arb_texture_storage_multisample/tex-param.c| 86 ++ 1 file changed, 55 insertions(+), 31 deletions(-) diff --git a/tests/spec/arb_texture_storage_multisample/tex-param.c b/tests/spec/arb_texture_storage_multisample/tex-param.c index 06f1783..9b52fb5 100644 --- a/t

[Piglit] [PATCH 17/24] arb_direct_state_access: Using glTextureStorage2DMultisample for something not completely trivial.

--- .../texture-storage-multisample.c | 98 -- 1 file changed, 93 insertions(+), 5 deletions(-) diff --git a/tests/spec/arb_direct_state_access/texture-storage-multisample.c b/tests/spec/arb_direct_state_access/texture-storage-multisample.c index 4840c02..f06

[Piglit] [PATCH 05/24] arb_direct_state_access: Added glTextureStorage*D test.

--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../spec/arb_direct_state_access/texture-storage.c | 602 + 3 files changed, 604 insertions(+) create mode 100644 tests/spec/arb_direct_state_access/text

[Piglit] [PATCH 07/24] arb_direct_state_access: Added test for TextureParameter* and GetTextureParameter*.

--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../spec/arb_direct_state_access/texture-params.c | 204 + 3 files changed, 206 insertions(+) create mode 100644 tests/spec/arb_direct_state_access/text

[Piglit] [PATCH 10/24] arb_direct_state_access: Tests for glGetTextureImage.

--- tests/all.py | 6 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 5 + tests/spec/arb_direct_state_access/get-textures.c | 114 + .../gettextureimage-formats.c | 559 + .../gettextureimage-luminance.

[Piglit] [PATCH 03/24] arb_direct_state_access: Testing glBindTextureUnit.

--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../arb_direct_state_access/bind-texture-unit.c| 78 ++ 3 files changed, 80 insertions(+) create mode 100644 tests/spec/arb_direct_state_access/bind-te

[Piglit] [PATCH 01/24] arb_direct_state_access: DSA 2D Textures "hello world" test.

Dylan Baker: all.py: Add dsa tests. --- tests/all.py | 2 + tests/spec/CMakeLists.txt | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 13 +++ tests/spec/arb_direct_state_access/CMakeLists.txt | 1 + tests/spec/arb_d

[Piglit] [PATCH 00/24] ARB_direct_state_access texture tests

These tests test ARB_direct_state_access texture functions. Since DSA functions and traditional functions typically share the same backend implementation, some of the simpler or more obscure functions (such as glCompressedTextureSubImage1D) are only tested trivially. Moreover, many of the mor

[Piglit] [PATCH 02/24] arb_direct_state_access: glTextureSubImage*D test.

--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../spec/arb_direct_state_access/texturesubimage.c | 415 + 3 files changed, 417 insertions(+) create mode 100644 tests/spec/arb_direct_state_access/text

[Piglit] [PATCH] fbo-blit-scaled-linear: Use const reference.

Fix Coverity "big parameter passed by value" defect. Signed-off-by: Vinson Lee --- tests/spec/arb_framebuffer_object/blit-scaled-linear.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_framebuffer_object/blit-scaled-linear.cpp b/tests/spec/arb_framebuffer_o

Re: [Piglit] [PATCH] glsl-deriv-varyings: Added checks for derivatives on parameters with negative or abs modifiers

On Mon, Dec 15, 2014 at 11:05 AM, Matt Turner wrote: > Reviewed-by: Matt Turner > ___ > Piglit mailing list > Piglit@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/piglit This patch introduced two GCC warnings. glsl-deriv-varyi

Re: [Piglit] [PATCH 3/4] utils: add initial WAFFLE_WGL support

On 16 December 2014 at 07:57, Emil Velikov wrote: > On 15/12/14 20:56, Jason Ekstrand wrote: >> >> >> On Fri, Nov 21, 2014 at 11:52 AM, Emil Velikov > > wrote: >> >> This will allow us to use waffle with its upcoming WGL support for >> Windows. With that do

Re: [Piglit] [PATCH 3/4] utils: add initial WAFFLE_WGL support

On 15/12/14 20:56, Jason Ekstrand wrote: > > > On Fri, Nov 21, 2014 at 11:52 AM, Emil Velikov > wrote: > > This will allow us to use waffle with its upcoming WGL support for > Windows. With that done, the final step to removing glut is to convert > p

Re: [Piglit] [PATCH 2/4] cmake: Don't rely on pkg-config for all Windows builds.

On 15/12/14 20:09, Jose Fonseca wrote: > On 15/12/14 19:47, Emil Velikov wrote: >> On 15/12/14 12:19, Jose Fonseca wrote: >>> From: José Fonseca >>> >>> Instead of just MSVC builds. >>> >>> Because pkg-config is not commonly available when compiling natively on >>> Windows, and gives the wrong res

Re: [Piglit] [Patch v2 3/3] CMakeLists.txt: Use FindWaffle.cmake instead of pkg-find

On Monday, December 15, 2014 07:23:10 PM Jose Fonseca wrote: > > On 15/12/14 18:56, Dylan Baker wrote: > > This is nice because it should work on both windows and on linux, since > > FindWaffle is provided by waffle itself. > > > > This is tested on Linux, but not on Windows. > > > > NOTE: There i

Re: [Piglit] [PATCH 3/4] utils: add initial WAFFLE_WGL support

On Monday, December 15, 2014 12:56:43 PM Jason Ekstrand wrote: > On Fri, Nov 21, 2014 at 11:52 AM, Emil Velikov > wrote: > > > > This will allow us to use waffle with its upcoming WGL support for > > Windows. With that done, the final step to removing glut is to convert > > piglit to use waffle fo

Re: [Piglit] [PATCH 3/4] utils: add initial WAFFLE_WGL support

On Fri, Nov 21, 2014 at 11:52 AM, Emil Velikov wrote: > > This will allow us to use waffle with its upcoming WGL support for > Windows. With that done, the final step to removing glut is to convert > piglit to use waffle for MacOS. > > Current implementation does not have input handling/event loop

Re: [Piglit] [PATCH 2/4] cmake: Don't rely on pkg-config for all Windows builds.

On 15/12/14 19:47, Emil Velikov wrote: On 15/12/14 12:19, Jose Fonseca wrote: From: José Fonseca Instead of just MSVC builds. Because pkg-config is not commonly available when compiling natively on Windows, and gives the wrong results (the host package instead of target package) when cross-co

Re: [Piglit] [PATCH 2/4] cmake: Don't rely on pkg-config for all Windows builds.

On 15/12/14 12:19, Jose Fonseca wrote: > From: José Fonseca > > Instead of just MSVC builds. > > Because pkg-config is not commonly available when compiling natively on > Windows, and gives the wrong results (the host package instead of target > package) when cross-compiling to Windows. Short ve

Re: [Piglit] [Patch v2 3/3] CMakeLists.txt: Use FindWaffle.cmake instead of pkg-find

On 15/12/14 18:56, Dylan Baker wrote: > This is nice because it should work on both windows and on linux, since > FindWaffle is provided by waffle itself. > > This is tested on Linux, but not on Windows. > > NOTE: There is a bug in FindWaffle.cmake that causes it to never check > that the request

Re: [Piglit] [Patch v2 3/3] CMakeLists.txt: Use FindWaffle.cmake instead of pkg-find

On 15/12/14 19:36, Dylan Baker wrote: On Monday, December 15, 2014 07:23:10 PM Jose Fonseca wrote: On 15/12/14 18:56, Dylan Baker wrote: This is nice because it should work on both windows and on linux, since FindWaffle is provided by waffle itself. This is tested on Linux, but not on Windows

Re: [Piglit] [Patch v2 3/3] CMakeLists.txt: Use FindWaffle.cmake instead of pkg-find

On Monday, December 15, 2014 07:23:10 PM Jose Fonseca wrote: > > On 15/12/14 18:56, Dylan Baker wrote: > > This is nice because it should work on both windows and on linux, since > > FindWaffle is provided by waffle itself. > > > > This is tested on Linux, but not on Windows. > > > > NOTE: There i

Re: [Piglit] [Patch v2 3/3] CMakeLists.txt: Use FindWaffle.cmake instead of pkg-find

On 15/12/14 18:56, Dylan Baker wrote: This is nice because it should work on both windows and on linux, since FindWaffle is provided by waffle itself. This is tested on Linux, but not on Windows. NOTE: There is a bug in FindWaffle.cmake that causes it to never check that the requested version

Re: [Piglit] [PATCH 1/4] framework: Use WGL by default on Windows.

On Monday, December 15, 2014 07:12:45 PM Jose Fonseca wrote: > On 15/12/14 17:24, Dylan Baker wrote: > > On Monday, December 15, 2014 12:19:15 PM Jose Fonseca wrote: > >> From: José Fonseca > >> > >> Like done with GLX on Linux. > >> --- > >> tests/util/piglit-framework-gl/piglit_wfl_framework.c

Re: [Piglit] [PATCH 1/4] framework: Use WGL by default on Windows.

On 15/12/14 17:24, Dylan Baker wrote: On Monday, December 15, 2014 12:19:15 PM Jose Fonseca wrote: From: José Fonseca Like done with GLX on Linux. --- tests/util/piglit-framework-gl/piglit_wfl_framework.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/util/pigl

Re: [Piglit] [PATCH] Correct typos in README

I've pushed this upstream. Thanks. On Sunday, December 14, 2014 07:20:46 AM Dylan Baker wrote: > Reviewed-by: Dylan Baker > On Dec 14, 2014 1:01 AM, "Pavol Klačanský" wrote: > > > --- > > README | 16 > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/RE

Re: [Piglit] [PATCH 1/4] framework: Use WGL by default on Windows.

On 15/12/14 12:19, Jose Fonseca wrote: > From: José Fonseca > > Like done with GLX on Linux. Yes please. With or without pimping out the error message, this is Reviewed-by: Emil Velikov ___ Piglit mailing list Piglit@lists.freedesktop.org http://list

Re: [Piglit] [PATCH] glsl-deriv-varyings: Added checks for derivatives on parameters with negative or abs modifiers

Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [Patch v2 3/3] CMakeLists.txt: Use FindWaffle.cmake instead of pkg-find

This is nice because it should work on both windows and on linux, since FindWaffle is provided by waffle itself. This is tested on Linux, but not on Windows. NOTE: There is a bug in FindWaffle.cmake that causes it to never check that the requested version is present. There is a patch on the waffl

[Piglit] [Patch v2 2/3] cmake: Simplify finding python modules

This patch adds 3 files, PythonModule.cmake, FindPythonMako.cmake and FindPythonNumpy.cmake. PythonModule provides a simple function for running python and parsing the version strings, each FindPython*.cmake then just calls that function, and then calls the find_package_handle_standard_args macro

[Piglit] [Patch v2 1/3] CMake: use cmake builtin python module

This removes a bunch of code that we rolled for finding python interpreters, and uses the cmake builtins. Signed-off-by: Dylan Baker --- CMakeLists.txt | 23 --- cmake/Modules/PiglitFindMako.cmake | 2 +- cmake/piglit_dispatch.cmake| 2 +- genera

Re: [Piglit] [PATCH 1/4] framework: Use WGL by default on Windows.

On Monday, December 15, 2014 12:19:15 PM Jose Fonseca wrote: > From: José Fonseca > > Like done with GLX on Linux. > --- > tests/util/piglit-framework-gl/piglit_wfl_framework.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/util/piglit-framework-gl/piglit_wfl_

Re: [Piglit] [PATCH 1/4] framework: Use WGL by default on Windows.

On 12/15/2014 05:19 AM, Jose Fonseca wrote: From: José Fonseca Like done with GLX on Linux. --- tests/util/piglit-framework-gl/piglit_wfl_framework.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/util/piglit-framework-gl/piglit_wfl_framework.c b/tests/util/pig

Re: [Piglit] [PATCH 4/4] cmake: Better .

Oops. Forgot some words on the subject. It should have been: "cmake: Improve experience detecting waffle on Windows" Jose On 15/12/14 12:19, Jose Fonseca wrote: From: José Fonseca - Use find_path/find_library so one can see the variables on cmake-gui - Provide better error message. ---

[Piglit] [PATCH 2/4] cmake: Don't rely on pkg-config for all Windows builds.

From: José Fonseca Instead of just MSVC builds. Because pkg-config is not commonly available when compiling natively on Windows, and gives the wrong results (the host package instead of target package) when cross-compiling to Windows. --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1

[Piglit] [PATCH 4/4] cmake: Better .

From: José Fonseca - Use find_path/find_library so one can see the variables on cmake-gui - Provide better error message. --- CMakeLists.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 2da7aae..6fb6c8a 100644 --- a/CMakeLists.txt +++ b/

[Piglit] [PATCH 1/4] framework: Use WGL by default on Windows.

From: José Fonseca Like done with GLX on Linux. --- tests/util/piglit-framework-gl/piglit_wfl_framework.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/util/piglit-framework-gl/piglit_wfl_framework.c b/tests/util/piglit-framework-gl/piglit_wfl_framework.c index 75

[Piglit] [PATCH 3/4] cmake: Don't check WAFFLE_VERSION on Windows.

From: José Fonseca The version number must be manually on command line, hence this version check is just an hindrance for Windows. --- CMakeLists.txt | 28 ++-- README | 1 - 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/CMakeLists.txt b/CMakeL

Re: [Piglit] [PATCH 3/4] utils: add initial WAFFLE_WGL support

On 14/12/14 15:48, Emil Velikov wrote: On 12/12/14 15:00, Jose Fonseca wrote: On 23/11/14 15:09, Emil Velikov wrote: On 23/11/14 09:38, Jose Fonseca wrote: On 21/11/14 19:52, Emil Velikov wrote: [snip] --- /dev/null +++ b/tests/util/piglit-framework-gl/piglit_wgl_framework.c [snip] +static