On 12/09/2020 11:19 AM, Ian Romanick wrote:
On 12/9/20 7:55 AM, Brian Paul wrote:
On 12/08/2020 05:47 PM, Ian Romanick wrote:
On 12/1/20 7:43 AM, Brian Paul wrote:
On 11/26/2020 09:22 AM, Brian Paul wrote:
On Wed, Nov 25, 2020 at 8:19 PM Ian Romanick mailto:i...@freedesktop.org>>
On 12/08/2020 05:47 PM, Ian Romanick wrote:
On 12/1/20 7:43 AM, Brian Paul wrote:
On 11/26/2020 09:22 AM, Brian Paul wrote:
On Wed, Nov 25, 2020 at 8:19 PM Ian Romanick mailto:i...@freedesktop.org>> wrote:
I was looking at the dlist-beginend subtest test_illegal_begin_mode.
Th
On 11/26/2020 09:22 AM, Brian Paul wrote:
On Wed, Nov 25, 2020 at 8:19 PM Ian Romanick <mailto:i...@freedesktop.org>> wrote:
I was looking at the dlist-beginend subtest test_illegal_begin_mode.
The test compiles a display list with GL_COMPILE_AND_EXECUTE mode. The
glBeg
On Wed, Nov 25, 2020 at 8:19 PM Ian Romanick wrote:
> I was looking at the dlist-beginend subtest test_illegal_begin_mode.
> The test compiles a display list with GL_COMPILE_AND_EXECUTE mode. The
> glBegin in the test uses an invalid mode. This should generate a
> GL_INVALID_OPERATION error imm
format(int width, int height, GLfloat *image, GLenum
requested_format)
{
#ifdef PIGLIT_USE_OPENGL
GLubyte *compressed_image;
-#endif
GLenum format2;
+#endif
int x, y, w, h;
GLuint tex;
bool pass = true;
Reviewed-by:
Both patches look OK to me.
Reviewed-by: Brian Paul
On 03/13/2019 08:16 AM, Jose Fonseca wrote:
With GitLab is now much easier to setup.
---
appveyor.yml | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/appveyor.yml b/appveyor.yml
index 1f8779187
On 10/24/2018 05:20 AM, Sergii Romantsov wrote:
> Trivial fix of memory leaking for test 'initialized-vbo'.
>
> v2: Rb added.
>
> Fixes: 6a467e00cfae (security/initialized-vbo: test contents of uninitialized
> VBOs)
> CC: Brian Paul
> Signed-off-by: Se
One minor thing below.
Otherwise, Reviewed-by: Brian Paul
On 08/01/2018 05:21 PM, Marek Olšák wrote:
From: Marek Olšák
---
tests/opengl.py | 6 +
tests/spec/CMakeLists.txt | 1 +
.../CMakeLists.gl.txt | 13
Test polygon culling with glPolygonMode for better coverage.
---
tests/general/polygon-mode.c | 87 +++-
1 file changed, 54 insertions(+), 33 deletions(-)
diff --git a/tests/general/polygon-mode.c b/tests/general/polygon-mode.c
index c41c392..709c6db 100644
The GLSL compiler can easily unroll this loop and simplify the function
down to a single assignment. That defeats the purpose of the test.
Replace literals with uniforms to prevent unrolling.
---
tests/shaders/glsl-vs-loop-break.shader_test | 8 ++--
1 file changed, 6 insertions(+), 2 deletio
On 06/27/2018 11:32 AM, Dylan Baker wrote:
Fixes: 2a7047a32bb3a9a4fad5bea0a8185d63af6bddf3
("glx: Introduce a glx-swap-copy test v2")
CC: Thomas Hellstrom
CC: Brian Paul
---
tests/opengl.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/opengl.py b/tests/openg
Does this test do anything that isn't already done by the existing
clipflat.c test?
-Brian
On 06/14/2018 03:41 AM, Danylo Piliaiev wrote:
There is a hardware bug in i965/gen9+ with provoking vertices.
Test if workaround works correctly.
Ref:
https://na01.safelinks.protection.outlook.com/?url
I took a quick look and I'm OK with it. If anyone else wants to review
it more closely, please do so soon.
Reviewed-by: Brian Paul
On 05/24/2018 12:55 PM, Rhys Perry wrote:
Ping I guess?
On Mon, May 7, 2018 at 5:19 PM, Rhys Perry wrote:
Changelog:
v2:
- Rebase to handle meta pro
On 05/21/2018 05:53 AM, Tapani Pälli wrote:
Implementation supports GL_TEXTURE_2D, GL_TEXTURE_2D_ARRAY
and affects following functions:
- piglit_probe_texel_rect_rgba
- piglit_probe_texel_volume_rgba
v2: use read_texture only on GL ES
fix indentation issues
Signed-off-by: Tapani P
It looks like this will bypass glGetTexImage even for desktop GL. We
may loose some test coverage because of that. Could we do the
fbo/ReadPixels work-around only on ES?
One indentation issue below.
-Brian
On 05/18/2018 02:29 AM, Tapani Pälli wrote:
Any comments? I'm planning to push this
Reviewed-by: Brian Paul
Though, I can't help but think that we could do something better for the
drawing test.
My first approach would be to draw a triangle with conservative
rasterization on then off and compare how many pixels are written. The
conservative rasterization should gen
Reviewed-by: Brian Paul
Thanks, Timothy!
On 05/09/2018 05:52 PM, Timothy Arceri wrote:
From: Bruce Merry
V2 (Timothy Arceri):
- use piglit_get_gl_enum_name()
- use ARRAY_SIZE()
- set config.khr_no_error_support
Cc: Brian Paul
Bugzilla:
https://urldefense.proofpoint.com/v2/url?u
Minor things below.
-Brian
On 05/09/2018 12:13 AM, Timothy Arceri wrote:
From: Bruce Merry
Cc: Brian Paul
Bugzilla:
https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D73096&d=DwIBAQ&c=uilaK90D4TOVoH58
This new test checks that glGetInteger/Fload/Double/Booleanv() return the
right values when querying vertex array attributes.
Currently broken in Mesa.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106450
---
tests/opengl.py | 1 +
tests/spec/gl-1.5/CMakeLists.gl
On 05/04/2018 06:08 AM, Rhys Perry wrote:
Signed-off-by: Rhys Perry
---
tests/all.py | 6 +
tests/quick.py| 7 +
tests/spec/CMakeLists.txt | 1 +
tests/spec/arb_sample_locations/CMakeLists
utf-8') as f:
This seems to fix the failure on MinGW.
Tested-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
On 05/03/2018 06:23 AM, Ilia Mirkin wrote:
On Wed, May 2, 2018 at 10:04 PM, Brian Paul wrote:
Explicity convert strings to unicode before writing.
This fixes an error when building with MinGW:
Traceback (most recent call last):
File "/var/workspace/tests/find_static_tests.py", l
Explicity convert strings to unicode before writing.
This fixes an error when building with MinGW:
Traceback (most recent call last):
File "/var/workspace/tests/find_static_tests.py", line 74, in
main()
File "/var/workspace/tests/find_static_tests.py", line 69, in main
f.write(filename
On 03/30/2018 03:56 PM, Rhys Perry wrote:
Adds tests for GL_NV_conservative_raster, GL_NV_conservative_raster_dilate
and GL_NV_conservative_raster_pre_snap_triangles.
Changes in v2:
- cleanup the tests
- fix some test failures
- remove the gles version of the dilation test as the extension is no
The patch looks great overall. Just minor nit-picks below.
On 03/28/2018 11:13 AM, Rhys Perry wrote:
Adds tests for GL_NV_conservative_raster, GL_NV_conservative_raster_dilate
and GL_NV_conservative_raster_pre_snap_triangles.
Changes in v2:
- cleanup the tests
- fix some test failures
- remov
Use a simple if/else to organize the ES vs desktop GL code paths.
---
tests/util/piglit-util-gl.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c
index 3a41a5e..f851f82 100644
--- a/tests/uti
ght; i++) {
+ for (j = 0; j < comps; j++) {
+ pixels[k++] = pixels_b[i*4+j] / 255.0f;
+ }
+ }
free(pixels_b);
return pixels;
}
Looks good. Thanks!
Reviewed-by: Brian Paul
Do you need me to push thi
On 03/28/2018 05:37 AM, Rhys Perry wrote:
GLES2 requires GL_RGBA to be used with GL_UNSIGNED_BYTE in glReadPixels
---
tests/util/piglit-util-gl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c
index df39c1c87.
For 3&4,
Reviewed-by: Brian Paul
Tested-by: Brian Paul (on NVIDIA)
On 03/26/2018 05:32 PM, Marek Olšák wrote:
From: Nicolai Hähnle
The first two vertices are swapped for triangle strips with adjacency; see
Table 10.1 of the OpenGL 4.5 (Compatibility Profile) spec.
---
tests/spec/gl
On 03/25/2018 01:49 PM, Rhys Perry wrote:
GLES2 requires GL_RGBA to be used with GL_UNSIGNED_BYTE in glReadPixels
---
tests/util/piglit-util-gl.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c
index df39c1c87.
---
tests/fbo/fbo-drawbuffers2-blend.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/fbo/fbo-drawbuffers2-blend.c
b/tests/fbo/fbo-drawbuffers2-blend.c
index b97803b..2c16b8f 100644
--- a/tests/fbo/fbo-drawbuffers2-blend.c
+++ b/tests/fbo/fbo-drawbuffers2-blend.c
@
---
tests/spec/arb_texture_multisample/large-float-texture.c | 1 +
tests/spec/arb_vertex_program/property-bindings.c| 4 +++-
tests/spec/glsl-1.10/execution/built-in-uniform-state.c | 4 +++-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/tests/spec/arb_texture_multisampl
H THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+/**
+ * @file
+ * Basic tests of OpenGL 3.0 gl{Get,}TexParameterI{iv,uiv} functions
+ */
+
+#include "piglit-util-gl.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+ config.supports_gl_compat_version = 10;
30
Wi
Reviewed-by: Brian Paul
On 02/26/2018 04:15 AM, Iago Toral Quiroga wrote:
We have recently found a regression in the i965 driver related to
gl_PointCoord which was not being caught by this test. This patch
changes the test slightly so that we can expose the problem for
future regression
The function is supposed to return a piglit_result, not true/false.
Fixes incorrect 'fail' results.
---
tests/general/degenerate-prims.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/general/degenerate-prims.c b/tests/general/degenerate-prims.c
index 0eed99c..3001d34 10
and glGetStringi(GL_SHADING_LANGUAGE_VERSION, i) queries in GL 4.3.
Until recently, these queries were not implemented in Mesa.
---
tests/all.py | 5 +++
tests/spec/CMakeLists.txt | 1 +
tests/spec/gl-4.3/CMakeLists.gl.txt | 13 ++
tests/spec/gl-4.3/CMa
|| scGet[2] != sc[2]
|| scGet[3] != sc[3]) {
printf("Scissor Box for index %d got erroneously
changed\n",
i);
pass = false;
Reviewed-by: Brian Paul
Reviewed-by: Brian Paul
On Thu, Feb 8, 2018 at 5:59 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> The GL limit is MaxTextureCombinedUnits, but the real usable limit is
> MaxTextureCoordUnits. This is probably a spec bug.
>
> Mesa will ignore glTexEnv calls where unit >=
pass = iterate_sample_rates("partition", test_partition) &&
pass;
}
if (!run)
@@ -408,6 +488,9 @@ piglit_init(int argc, char **argv)
piglit_is_extension_supported("GL_ARB_gpu_shader5") &&
piglit_is_extension_sup
On 02/02/2018 11:57 AM, Dylan Baker wrote:
Quoting Brian Paul (2018-02-02 09:35:21)
If wflinfo is not installed or fails, the wfl_info.gl_extensions value
will be the empty set. Similarly, the gl_version, glsl_version, etc.
will be None.
In those cases, return True from the
If wflinfo is not installed or fails, the wfl_info.gl_extensions value
will be the empty set. Similarly, the gl_version, glsl_version, etc.
will be None.
In those cases, return True from the gl_extension_supported() and
is_feature_directory_supported() functions so that we don't skip any
subdirs.
On 02/02/2018 04:11 AM, Alejandro Piñeiro wrote:
Instead of a hardcoded 3.
---
tests/util/piglit-util-gl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c
index e9c20385ee..df39c1c877 100644
--- a/tests/util/piglit-u
Seems overkill to write a brand new test just for this so add it to
the existing invalid-formats.c test.
See Bugzilla https://bugs.freedesktop.org/show_bug.cgi?id=104908
---
.../spec/arb_texture_compression/invalid-formats.c | 26 ++
1 file changed, 26 insertions(+)
diff --gi
p;config)) {
+ config.window_width = DEFAULT_WINDOW_WIDTH;
+ config.window_height = DEFAULT_WINDOW_HEIGHT;
+ }
get_required_config(filename, &config);
For the series,
Reviewed-by: Brian Paul
___
Piglit mailing
Both with and without display lists.
---
tests/all.py | 1 +
tests/spec/gl-1.1/CMakeLists.gl.txt | 1 +
tests/spec/gl-1.1/color-material-array.c | 118 +++
3 files changed, 120 insertions(+)
create mode 100644 tests/spec/gl-1.1/colo
Both with and without display lists.
---
tests/all.py | 1 +
tests/spec/gl-1.1/CMakeLists.gl.txt | 1 +
tests/spec/gl-1.1/draw-arrays-start.c | 121 ++
3 files changed, 123 insertions(+)
create mode 100644 tests/spec/gl-1.1/draw-array
Both with and without display lists.
---
tests/all.py | 1 +
tests/spec/gl-2.0/CMakeLists.gl.txt | 1 +
tests/spec/gl-2.0/shader-materials.c | 141 +++
3 files changed, 143 insertions(+)
create mode 100644 tests/spec/gl-2.0/shader-mater
---
tests/util/piglit-util-gl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c
index e9c2038..df39c1c 100644
--- a/tests/util/piglit-util-gl.c
+++ b/tests/util/piglit-util-gl.c
@@ -1249,7 +1249,7 @@ probe_rect_ubyte(int
On 01/18/2018 01:27 PM, Eric Anholt wrote:
Brian Paul writes:
To avoid an infinite loop. See code comments for details.
Skipping a failing test and returning pass is wrong to me.
It's not ideal. But the bug is in LLVM and cannot readily be fixed in
llvmpipe.
I could have the
On 01/18/2018 12:38 PM, Roland Scheidegger wrote:
Am 18.01.2018 um 20:07 schrieb Brian Paul:
To avoid an infinite loop. See code comments for details.
---
tests/spec/gl-1.0/blend.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/tests/spec/gl-1.0
To avoid an infinite loop. See code comments for details.
---
tests/spec/gl-1.0/blend.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/tests/spec/gl-1.0/blend.c b/tests/spec/gl-1.0/blend.c
index 35e940f..e69ed31 100644
--- a/tests/spec/gl-1.0/blend.c
= GL_FUNC_ADD
I'll have to test a newer version of LLVM tomorrow. Have you run
gl-1.0-blend-func yourself, Roland?
-Brian
Either way,
for 1-2/3
Reviewed-by: Roland Scheidegger
Am 17.01.2018 um 23:54 schrieb Brian Paul:
The test normally runs about 27,000 tests and takes quite a long t
The test normally runs about 27,000 tests and takes quite a long time
with some drivers. With the --quick option, only 1% of the tests are run.
And update tests/quick.py to run the test with --quick.
---
tests/quick.py| 7 +++
tests/spec/gl-1.0/blend.c | 23 ++
This exercises two code paths in Mesa's display list VBO code.
---
tests/all.py| 1 +
tests/spec/gl-1.0/CMakeLists.gl.txt | 1 +
tests/spec/gl-1.0/dlist-materials.c | 164
3 files changed, 166 insertions(+)
create mode 100644 tests/
Just increment the test counter in run_all_factor_sets().
---
tests/spec/gl-1.0/blend.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/tests/spec/gl-1.0/blend.c b/tests/spec/gl-1.0/blend.c
index c1796a5..769339f 100644
--- a/tests/spec/gl-1.0/blend.c
+++ b/tests/spec/g
if (!(data[i] == observed[i] ||
+ (data[i] == 128 && observed[i] == 129))) {
This might be more obvious if you you'd cast the data and observed
pointers to GLbyte types (like you do for GLshort below) and then test
for the -127 and -128 val
Reviewed-by: Brian Paul
On 01/11/2018 12:54 PM, Fabian Bieler wrote:
Draw circles with long line loops and check the result.
In particular, check that the last line segment is drawn and that no
additional segments in between arbitrary vertices are drawn.
V2: Increase vertex size and count
->---const int len = sprintf(position, format, param);
+>--->---const char *old_position = position;
+>--->---position += len + 1;
+>--->---return old_position;
+>--->---}
>---}
}
I didn't do a super detailed
On 01/07/2018 03:14 PM, Fabian Bieler wrote:
Draw circles with long line loops and check the result.
In particular, check that the last line segment is drawn and that no
additional segments in between arbitrary vertices are drawn.
---
tests/all.py| 1 +
tests/spec/gl
On 12/29/2017 05:16 PM, Fabian Bieler wrote:
Replace GLenum stringification macros with calls to piglit_get_gl_enum_name.
V2: Make sure GL 1.0 legacy internal formats '3' and '4' are logged
correctly.
Reviewed-by: Brian Paul
__
nsure that future updates to gl.xml don't necessitate updates to
all.py.
However, these tests now abort on unknown command line arguments which were
silently ignored, previously. I hope this is acceptable.
As long as we don't have aborts when running tests/all.py I think that's OK.
On 12/26/2017 11:57 PM, Arthur Huillet wrote:
On Sun, 24 Dec 2017 15:41:38 -0700
Brian Paul wrote:
+ * Some drivers/GPUs may fail this test. NVIDIA, for example, appears to
+ * only store the MSAA coverage info, not the sample colors, for samples
+ * beyond the 8th sample. We may tune the
Create the largest possible 2D GL_RGBA_32F multisampled texture, load it
with known values the read it back and see if the values match up.
The --array option runs the test with a 2D texture array instead of an
MSAA texture. There are other options to specify texture size, number of
samples, fp16
On 12/22/2017 05:05 PM, Fabian Bieler wrote:
Only limit texture size to 512x512 in quick.py.
---
If you squash this into your test it should only limit the texture size in the
'quick' profile.
Two nitpicks:
+ config.khr_no_error_support = PIGLIT_NO_ERRORS;
Isn't it possible for this tes
Create the largest possible 2D GL_RGBA_32F multisampled texture, load it
with known values the read it back and see if the values match up.
The --array option runs the test with a 2D texture array instead of an
MSAA texture. There are other options to specify texture size, number of
samples, fp16
Create the largest possible 2D GL_RGBA_32F multisampled texture, load it
with known values the read it back and see if the values match up.
The --array option runs the test with a 2D texture array instead of an
MSAA texture. There are other options to specify texture size, number of
samples, fp16
(+), 20 deletions(-)
For the series, Reviewed-by: Brian Paul
Do you need me to push these for you?
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Stop running the test after 10 failures. As it was, a failure could
lead to nearly 9MB of output.
---
tests/spec/ext_transform_feedback/max-varyings.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/tests/spec/ext_transform_feedback/max-varyings.c
b/tests
No need to print passing cases. Reduced log noise.
---
tests/spec/ext_transform_feedback/interleaved.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/spec/ext_transform_feedback/interleaved.c
b/tests/spec/ext_transform_feedback/interleaved.c
index a52474c..0d237d7 10
).
Otherwise no changes.
Looks good. Thanks!
Reviewed-by: Brian Paul
Nicolai Hähnle, Vinson Lee, Wiktor Janas: Do any of you take issue with
the addition of the MIT copyright notice?
___
Piglit mailing list
Piglit@lists.freedesktop.org
https
On 12/15/2017 03:57 AM, Juan A. Suarez Romero wrote:
---
tox.ini | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tox.ini b/tox.ini
index c1b7a0104..2bd99f544 100644
--- a/tox.ini
+++ b/tox.ini
@@ -27,7 +27,7 @@ deps =
pytest-warnings
pytest-timeout
py{27,3
The vertices are drawn with a GL_TRIANGLE_STRIP. As it was, the
order of the 3rd and 4th vertices caused us to render a "twisted"
quad. With this change, a true quad is drawn.
llvmpipe passes as it did before. NVIDIA's driver still fails the test.
---
tests/spec/arb_texture_view/common.c | 12
The series looks good to me. Thanks for doing this.
Reviewed-by: Brian Paul
On 12/09/2017 05:52 AM, Fabian Bieler wrote:
This series removes the remaing Glean tests from Piglit.
3 subtests were cherry-picked and ported to Piglit.
These test were removed without replacement:
api2no
ize you're following the style above, but I think
putting this on two lines is better. That is:
if (i < 0)
i = -i - 1;
Just in case someone ever needs to set a breakpoint when debugging.
Reviewed-by: Brian Paul
+ isOdd = (i / texture_width) & 1;
+
The vertices are drawn with a GL_TRIANGLE_STRIP. As it was, the
order of the 3rd and 4th vertices caused us to render a "twisted"
quad. With this change, a true quad is drawn.
llvmpipe passes as it did before. NVIDIA's driver still fails the test.
---
tests/spec/arb_texture_view/common.c | 12
On 12/05/2017 10:19 AM, Roland Scheidegger wrote:
Am 05.12.2017 um 17:43 schrieb Brian Paul:
Instead of using a fixed number of samples, query the
GL_MAX_COLOR_TEXTURE_SAMPLES or GL_MAX_DEPTH_TEXTURE_SAMPLES value
and use those.
Fixes failures with llvmpipe and VMware driver when MSAA is
---
tests/spec/ext_framebuffer_multisample/fast-clear.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/spec/ext_framebuffer_multisample/fast-clear.c
b/tests/spec/ext_framebuffer_multisample/fast-clear.c
index d4bf7ce..49ec0a3 100644
--- a/tests/spec/ext_frame
Instead of using a fixed number of samples, query the
GL_MAX_COLOR_TEXTURE_SAMPLES or GL_MAX_DEPTH_TEXTURE_SAMPLES value
and use those.
Fixes failures with llvmpipe and VMware driver when MSAA is disabled.
---
tests/spec/arb_texture_multisample/errors.c| 10 +-
tests/spec/arb_text
---
tests/spec/arb_texture_storage_multisample/tex-param.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/spec/arb_texture_storage_multisample/tex-param.c
b/tests/spec/arb_texture_storage_multisample/tex-param.c
index 8aa3df3..bc40ecc 100644
--- a/tests/spec/arb_te
ot;;
+ case GL_POSITION:
+ return "position";
+ case GL_S:
+ return "s";
+ case GL_T:
+ return "t";
+ case GL_R:
+ return "r";
+ case GL_Q:
+ return
1, 1};
+
+ glEnable(GL_LIGHTING);
+ glEnable(GL_LIGHT0);
+
+ glMaterialfv(GL_FRONT_AND_BACK, GL_AMBIENT, black);
+ glMaterialfv(GL_FRONT_AND_BACK, GL_DIFFUSE, white);
+
+ glLightfv(GL_LIGHT0, GL_DIFFUSE, green_with_a_smitch_of_red);
+
+ glScalef(100.0, 10
On 11/29/2017 02:26 PM, Fabian Bieler wrote:
On 2017-11-29 04:53, Brian Paul wrote:
On 11/23/2017 01:44 PM, Fabian Bieler wrote:
This series replaces the "glsl1" Glean test with some Piglit tests.
Most tests were replaced by shader_runner tests.
The tests for built-in-uniform
there's no compiler warnings and all the tests pass/fail as the glean
tests did.
If there's no other comments in a few days, I can push the series.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
(GL_FRAMEBUFFER, 0);
+ glBindFramebuffer(GL_FRAMEBUFFER, piglit_winsys_fbo);
glClearColor(0.5, 0.5, 0.5, 0.5);
glClear(GL_COLOR_BUFFER_BIT);
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
https
We were generating tests both in spec/glsl-1.10/ and spec/glsl-110/.
This changes the later to match the former.
---
generated_tests/gen_variable_index_write_tests.py | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/generated_tests/gen_variable_index_write_tests.py
b/g
Reviewed-by: Brian Paul
On 11/15/2017 02:21 AM, Andres Gomez wrote:
Fixes: edc41a1db ("framework: move WflInfo class into new wflinfo.py module")
Cc: Brian Paul
Cc: Dylan Baker
Signed-off-by: Andres Gomez
---
unittests/framework/test/test_glsl_parser_test.py | 2 +-
* OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ *
+ */
+
+/**
+ * @file tex-env.c: Test the basic texture env modes
+ * Author: Brian Paul (bri...@valinux.com) April 2001
+ *
+ * Test procedure:
+ * Setup a texture with 81 columns of unique RGBA colors,
/* Expected to evaluate to a finite value */
B_POSINF = 2, /* Expected to evaluate to +Infinity */
B_NEGINF = 3, /* Expected to evaluate to -Infinity */
+ B_FINITE_NANOK = 4, /* Expected finite value, but NaN ok */
My only nit-pick is to change that to NAN_OK.
Reviewed
With NVIDIA's driver, wflinfo reports a GLSL version line like this:
"OpenGL shading language version string: 4.40 NVIDIA via Cg compiler"
The existing parsing code didn't expect the text after the version
number and generated an exception. Change the parsing to handle this.
---
framework/wflinfo
The wflinfo versions should be floats already, so don't call float() again.
If querying the ES api/version fails, we'll get None for the version number
so check for that.
---
tests/all.py | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tests/all.py b/tests/all.
NVIDIA's driver fails to compile the fragment shaders with "Failed to
compile fragment shader: 0(4) : error C7533: global variable gl_FragData
is deprecated after version 120".
Use 'out fragdata' or 'out fragcolor' instead.
Tested with Mesa too.
---
.../execution/ignore-centroid-qualifier.cpp
---
tests/util/piglit-util-gl.c | 2 +-
tests/util/piglit-util-gl.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c
index 041427d..43b38e5 100644
--- a/tests/util/piglit-util-gl.c
+++ b/tests/util/piglit-util-gl.c
@@
---
tests/spec/arb_indirect_parameters/tf-count-arrays.c | 2 +-
tests/spec/arb_indirect_parameters/tf-count-elements.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/spec/arb_indirect_parameters/tf-count-arrays.c
b/tests/spec/arb_indirect_parameters/tf-count-array
Texture IDs are GLuint, not GLenum.
---
tests/util/piglit-util-gl.c | 3 ++-
tests/util/piglit-util-gl.h | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c
index d8b8f85..041427d 100644
--- a/tests/util/piglit-util-gl.c
On 11/10/2017 12:16 PM, Charmaine Lee wrote:
From: Brian Paul
Sent: Thursday, November 9, 2017 12:52 PM
To: piglit@lists.freedesktop.org
Cc: Charmaine Lee; Brian Paul
Subject: [PATCH] gl-1.0-logicop: allow testing single mode on the command line
And require GL 1.1 since that's when
On 11/09/2017 05:29 PM, Dylan Baker wrote:
Quoting Brian Paul (2017-11-09 15:16:33)
The script searches all files under tests/ and generated_tests/ for
files ending in ".shader_test". For each match, a ShaderTest() object
is created and added to the test list.
For GL extensions o
So it doesn't have to be done after every call to delete_arg().
---
tests/util/piglit-framework-gl.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/tests/util/piglit-framework-gl.c b/tests/util/piglit-framework-gl.c
index 22aadc5..1b2078d 100644
--- a/
The script searches all files under tests/ and generated_tests/ for
files ending in ".shader_test". For each match, a ShaderTest() object
is created and added to the test list.
For GL extensions or versions not supported by the driver, this is
wasted effort.
This patch looks for directories unde
1. If the PIGLIT_PLATFORM string is 'mixed_glx_egl' we need to convert
it to 'glx' so that wflinfo understands it.
2. Look in the piglit bin/ directory for the wflinfo.exe program.
When we build piglit, we copy wflinfo.exe into the bin/ directory for
packaging to avoid having to install waffle on
The script searches all files under tests/ and generated_tests/ for
files ending in ".shader_test". For each match, a ShaderTest() object
is created and added to the test list.
For GL extensions or versions not supported by the driver, this is
wasted effort.
This patch looks for directories unde
1 - 100 of 1411 matches
Mail list logo
