This patch series modifies shader_runner and glslparsertest to be able
to test geometry shaders. Then it adds basic geometry shader sanity
tests. Finally, the code-generated tests for built-in functions are
modified so that they produce geometry shader variants.
This is by no means a thorough te
---
tests/all.tests| 9
.../spec/arb_geometry_shader4/compiler/sanity.geom | 17
.../execution/sanity.shader_test | 50 +
tests/spec/glsl-1.50/compiler/geometry-basic.geom | 18
.../glsl-1.50/executi
---
tests/shaders/shader_runner.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 07cc5c9..770f0c8 100644
--- a/tests/shaders/shader_runner.c
+++ b/tests/shaders/shader_runner.c
@@ -101,7 +101,6 @@ enum states {
ve
Note that there are two slightly different variants of geometry
shaders: those supported by GLSL 1.50 and those supported by
ARB_geometry_shader4. A principal difference between these two
variants is in how geometry shader layout parameters are specified
(i.e. input and output primitive types, max
---
.../default-precision-sampler.frag | 28 +++
.../default-precision-sampler.vert | 29 +++
.../compiler/default-precision-sampler.frag| 41 +
.../compiler/default-precision-sampler.vert| 42 +
---
.../varying-struct-nonflat-int.frag| 29 ++
.../varying-struct-nonflat-int.vert| 29 ++
.../varying-struct-nonflat-uint.frag | 29 ++
.../varying-struct-nonflat-uint.vert | 2
All of the GLSL specs from GLSL 1.30 (and GLSL ES 3.00) onward contain
language requiring certain integer variables to be declared with the
"flat" keyword, but they differ in exactly *when* the rule is
enforced:
(a) GLSL 1.30 and 1.40 say that vertex shader outputs having integral
type must be dec
On 11 February 2013 08:46, Eric Anholt wrote:
> Paul Berry writes:
>
> > In the documentation for BindBufferRange, OpenGL specs from 3.0
> > through 4.1 contain this language:
> >
> > "The error INVALID_VALUE is generated if size is less than or
> >
In the documentation for BindBufferRange, OpenGL specs from 3.0
through 4.1 contain this language:
"The error INVALID_VALUE is generated if size is less than or
equal to zero or if offset + size is greater than the value of
BUFFER_SIZE."
This text was dropped from OpenGL 4.2, and it d
sulting depth values, not stencil.
>
> Cc: Paul Berry
>
This is definitely better than what we had before, but I would be more
comfortable if we expanded the test to verify:
(a) that pixels aren't scrambled in some way by glCopyTexImage2D (since
stencil buffers use W tiling, it wouldn
On 31 January 2013 22:51, Matt Turner wrote:
> Caused the shader_runner tests generated from that template to be
> indented.
>
LGTM.
Reviewed-by: Paul Berry
> ---
> generated_tests/gen_builtin_packing_tests.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-
On 31 January 2013 22:51, Matt Turner wrote:
> The unpack builtins are implemented using floating-point division, which
> is implemented by reciprocal+multiply.
This should probably say something like "Which is implemented by
reciprocal+multiply on Mesa/i965". Other drivers don't necessarily u
This patch adds the following GLSL ES 3.00 tests:
- varying-struct-basic: a simple test case involving a single varying
struct.
- varying-struct-arrays: exercise complex interactions between structs
and arrays in varyings.
- varying-struct-copy-{function,local}-vs: exercise corner cases wher
On 29 January 2013 09:48, Christoph Bumiller wrote:
> On 29.01.2013 16:55, Tom Gall wrote:
> > Hi Christoph,
> >
> > If you look at the bottom of http://www.opengl.org/registry/ you will
> find:
> >
> > enum.spec - canonical description of the reserved OpenGL enumerants
> > and the ranges allocate
On 21 January 2013 19:50, Tom Gall wrote:
> When shader_runner parses the shader_test data file, only
> parse one [required] section, no longer parse the rest of the file.
>
> v2: better description. Remove warning.
>
> Signed-off-by: Tom Gall
>
Ok, I've pushed these two patches. Sorry for the
On 28 January 2013 17:18, Matt Turner wrote:
> On Mon, Jan 28, 2013 at 5:11 PM, Tom Gall wrote:
> > Sure, but tell that to the compiler.
> >
> > It is bad form to not have a return at the end of a function which is
> > supposed to return something. The other way perhaps is just knock out
> > th
On 28 January 2013 09:00, Brian Paul wrote:
> On Mon, Jan 28, 2013 at 9:17 AM, Marek Olšák wrote:
> > On Mon, Jan 28, 2013 at 4:54 PM, Brian Paul wrote:
> >> [cross-posting this reply to the mesa-dev list]
> >>
> >>
> >> On 01/27/2013 09:07 AM, Brian Paul wrote:
> >>>
> >>> On Sun, Jan 27, 2013
On 24 January 2013 19:50, Matt Turner wrote:
> This uses the existing pack/unpack testing infrasturcture for GLSL ES
> 3.0 and adds support for testing pack/unpack 4x8 operations.
>
> Generate the following test files:
> {const,vs,fs}-{pack,unpack}{Snorm,Unorm}{2x16,4x8}.shader_test
>
On 21 January 2013 15:24, Chad Versace wrote:
> +def make_inputs_for_pack_half_2x16():
> +# The domain of packHalf2x16 is ([-inf, +inf] + {NaN})^2. The function
> +# does not clamp its input.
> +#
> +# We test both -0.0 and +0.0 in order to stress the implementation's
> +# han
00/execution/built-in-functions.
>
> v2: Add reduced_input_table. This allows us to generate a smaller set of
> inputs for packHalf2x16 in order to avoid Linux's oom-killer.
>
> CC: Paul Berry
> Signed-off-by: Chad Versace
>
Argh, I quoted too much of the patch in m
This patch adds the following GLSL ES 3.00 tests:
- varying-struct-basic: a simple test case involving a single varying
struct.
- varying-struct-arrays: exercise complex interactions between structs
and arrays in varyings.
- varying-struct-copy-vs: exercise corner cases where a struct
inte
On 21 January 2013 12:03, Tom Gall wrote:
> On Mon, Jan 21, 2013 at 12:49 PM, Paul Berry
> wrote:
> > On 17 January 2013 15:08, Tom Gall wrote:
> >>
> >> When shader_runner parses the shader_test data file, add an
> >> optimization such that after th
On 17 January 2013 15:08, Tom Gall wrote:
> When shader_runner parses the shader_test data file, add an
> optimization such that after the [required] section is left to
> no longer parse the rest of the file.
>
> Signed-off-by: Tom Gall
> ---
> tests/shaders/shader_runner.c |5 -
> 1 fi
I'd suggest changing to a commit subject that describes precisely what
change you're making in the active voice, e.g. something like "Fix
shader_runner regexps to match new version requirement syntax". The
existing commit subject ("shader_runner regression with gles") is too vague.
On 17 January
On 13 January 2013 20:11, Dave Airlie wrote:
> From: Dave Airlie
>
> These are promoted from GL_ARB_fragment_coord_conventions.
>
> GLSL 1.50 add two layout parameters for gl_FragCoord,
> test them on their own, and in combination.
>
In general, for cases like this, I prefer to create a shader_
On 13 January 2013 19:15, Dave Airlie wrote:
> Ported one obvious test from glsl 3.00es, and added a generated test for
> glsl 1.50 determinant, this just lays the groundwork for adding more GLSL
> 1.50
> tests.
>
> Dave.
>
This series is:
Re
pass on i965 Gen7.
I had some minor nit-pick comments on patch 2/6. Whether or not you decide
to make those changes, this series is:
Reviewed-by: Paul Berry
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
This test was added back in April (b859d0c) but was never added to the
build or all.tests.
---
Probably doesn't really need code review. Brian, let me know if this
works for you and I'll commit it.
tests/all.tests | 1 +
tests/spec/glsl-1.10/execution/CMakeList
On 9 January 2013 09:30, Brian Paul wrote:
> I happened to notice that the program tests/spec/glsl-1.10/**
> execution/glsl-render-after-**bad-attach.c which Eric added last April
> (b859d0c) isn't getting built.
>
> Adding a piglit_add_executable() line in the directory's CMakeLists.txt
> file d
This patch introduces new vs and fs tests to provoke a bug in Mesa
which caused loop bounds to be inferred incorrectly when the loop
condition was expressed in an unusual way (e.g. "4 > i" instead of "i
< 4").
---
.../execution/fs-loop-bounds-unrolled.shader_test | 40 +
.../e
On 5 January 2013 01:07, Chris Forbes wrote:
> These cover most of the behavior specified by ARB_texture_multisample.
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
This series look
On 7 January 2013 14:21, Chris Forbes wrote:
> This test actually gets *simpler*, generalized to arbitrary sample
> counts. I'll cook something up tonight.
>
Ok, cool. While you're looking into that, there are several other ways I
think this test needs to be generalized:
- We need to test a pi
On 5 January 2013 01:07, Chris Forbes wrote:
> RGBA32I, RGBA32UI, and RGBA32F are huge and
> unsupported for multisample textures on at least Gen6 i965.
>
> This shouldn't be committed as-is, but it allowed for testing of
> multisample samplers with the generic textureSize() test.
>
> Signed-off-
On 5 January 2013 01:07, Chris Forbes wrote:
> Writes a test pattern to individual samples in a multisample texture,
> and tests texelFetch() reads the correct values for each sample.
>
> Signed-off-by: Chris Forbes
>
Unforunately, I think we need to generalize this test to test a variety of
sa
On 5 January 2013 01:07, Chris Forbes wrote:
> This tests that the new teximage state added in ARB_texture_multisample
> exists and has correct defaults for non-multisample textures:
>
> - GL_TEXTURE_SAMPLES = 0
> - GL_TEXTURE_FIXED_SAMPLE_LOCATIONS = false
>
I think you mean "true" here
On 5 January 2013 01:07, Chris Forbes wrote:
> This tests FBO setup with various combinations of multisample textures
> and `classic` multisample renderbuffers, and for each, checks:
>
> - That the renderbuffers or textures can be created
> - Completeness status
>
> If the configuration is expect
On 5 January 2013 01:07, Chris Forbes wrote:
> Verifies new minimum maximums in ARB_texture_multisample:
>
> GL_MAX_COLOR_TEXTURE_SAMPLES >= 1
> GL_MAX_DEPTH_TEXTURE_SAMPLES >= 1
> GL_MAX_INTEGER_SAMPLES >= 1
> GL_MAX_SAMPLE_MASK_WORDS >= 1
>
> Signed-off-by: Chris Forbes
> ---
> tests/all.test
On 3 January 2013 14:39, Eric Anholt wrote:
> Paul Berry writes:
> > +static const char vs_text[] =
> > + "#version " GLSL_VERSION "\n"
>
> Maybe fold GLSL_VERSION into the ifdefs instead of ifdeffing it
On 3 January 2013 15:11, Eric Anholt wrote:
> Paul Berry writes:
>
> > This patch adds compressed representations of uniform grayscale images
>
> maybe "This patch adds compressed representations of uniform grayscale
> blocks" -- I was thinking of these as ima
On 2 January 2013 15:28, Tom Gall wrote:
> Hi All,
>
> I was looking at some of the piglit-dispatch code experimenting a bit
> with the intent to implement it for gles and was wondering where did
> the past discussions on this end up?
>
> There is a comment above piglit_dispatch_default_init that
On 31 December 2012 18:40, Kenneth Graunke wrote:
>
> Now that Piglit's import of Glean is beginning to diverge from Glean
> proper,
> my hope is that someday people will port over various tests to the native
> Piglit framework, then delete the equivalent Glean code. A bit more work
> is necessa
On 2 January 2013 07:39, Brian Paul wrote:
>
> I think the filename could be a little more descriptive. Maybe
> piglit-util-compressed-grays.h
>
>
Sure, I can go along with that.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedes
---
tests/all.tests | 6 +
tests/spec/ext_texture_array/CMakeLists.gl.txt| 1 +
tests/spec/ext_texture_array/CMakeLists.gles3.txt | 8 +
tests/spec/ext_texture_array/compressed.c | 307 ++
4 files changed, 322 insertions(+)
c
This patch adds compressed representations of uniform grayscale images
to piglit, in the ETC1 and FXT1 compression formats. Although they
don't exercise the full capabilities of these compression formats,
they should be sufficient to create basic tests of compression
functionality without having t
This patch adds functions piglit_gen_ortho_uniform() and
piglit_ortho_uniform(), which can be used to set up an orthographic
projection when the legacy function glOrtho() is not available.
The functions work exactly like piglit_gen_ortho_projection() and
piglit_ortho_projection(), except that inst
On 19 December 2012 11:49, Ian Romanick wrote:
> On 12/19/2012 08:30 AM, Paul Berry wrote:
>
> Reviewed-by: Ian Romanick
>
> Now for the bad news...
>
> In GLSL ES 3.00 and GLSL 1.50 this language changes to:
>
> "They can only be float, floating-point ve
---
.../varying-packing-mixed-types.shader_test| 60 ++
1 file changed, 60 insertions(+)
create mode 100644
tests/spec/glsl-1.30/execution/varying-packing-mixed-types.shader_test
diff --git
a/tests/spec/glsl-1.30/execution/varying-packing-mixed-types.shader_test
b/
---
.../qualifiers/varying-bool-prohibited.frag| 20 +++
.../qualifiers/varying-bool-prohibited.vert| 21
.../qualifiers/varying-bvec2-prohibited.frag | 20 +++
.../qualifiers/varying-bvec2-prohibited.vert | 21 ++
On 18 December 2012 11:54, Ian Romanick wrote:
> On 12/17/2012 10:17 AM, Paul Berry wrote:
>
> This test looks good. You should add the note about NVIDIA's driver to
> the commit message when you push.
>
Ok, will do. Thanks.
>
> Reviewed-by: Ian Romanick
>
On 17 December 2012 10:17, Paul Berry wrote:
> ---
> tests/all.tests| 6 +
> .../spec/ext_transform_feedback/CMakeLists.gl.txt | 1 +
> tests/spec/ext_transform_feedback/change-size.c| 320
> +
> 3 files chang
; Support is added to piglit_get_gl_enum_name for
> GL_SHADER_BINARY_FORMATS which was previously missing from our
> enumext.spec.
>
> Signed-off-by: Ian Romanick
> Cc: Paul Berry
>
This looks correct to me.
Reviewed-by: Paul Berry
___
Piglit mailing
---
tests/all.tests| 6 +
.../spec/ext_transform_feedback/CMakeLists.gl.txt | 1 +
tests/spec/ext_transform_feedback/change-size.c| 320 +
3 files changed, 327 insertions(+)
create mode 100644 tests/spec/ext_transform_feedback/chang
---
tests/all.tests| 7 +
tests/spec/glsl-1.10/execution/CMakeLists.txt | 1 +
.../execution/varying-packing/CMakeLists.gl.txt| 14 +
.../execution/varying-packing/CMakeLists.txt | 1 +
.../glsl-1.10/execution/varying-packing/simple.c | 4
618, in get
raise NoOptionError(option, section)
I think you need to add the line "* glsl_version: 1.10" to the [config]
section.
With that fixed, this is:
Reviewed-by: Paul Berry
> ---
> I'm not sure this is the right place for this test script to live. It
> didn&
The time-elapsed test needs to consume a lot of GPU time so that it
can validate GPU time queries against elapsed wall-clock time.
Previously we did this by painting the window thousands of times.
That sometimes caused false failures due to the CPU time consumed in
preparing the draw calls.
This p
On 19 November 2012 13:26, Eric Anholt wrote:
> Paul Berry writes:
>
> > From: Ian Romanick
> >
> > To use multithreading with xlib, you're supposed to call XInitThreads
> > before any other xlib call. Without this, xlib and GLX calls won't be
> >
Currently, in Mesa with the i965 driver, calling glFlush() forces all
pending drawing operations to be sent to the kernel; this ensures that
any subsequent drawing operations will be performed after those
pending drawing operations, even if they come from other contexts.
The glx-multithread test wa
From: Ian Romanick
To use multithreading with xlib, you're supposed to call XInitThreads
before any other xlib call. Without this, xlib and GLX calls won't be
thread safe. It looks like this test had an extra mutex to work
around the lack of thread saftey in glXCreateContext and
glXMakeCurrent.
On 9 November 2012 11:15, Chad Versace wrote:
> Paul,
>
> I observed these Python errors during test generation. I haven't had a
> chance to look into them yet, but just wanted to inform you before I forgot
> about them.
>
> [87/1749] Generating builtin_uniform_tests.list
> /home/chad/proj/linux/
On 2 November 2012 09:32, Brian Paul wrote:
>
> I think I've brought this up in the past. On Windows, the minimum width
> of a window is 116 pixels (at least in my current Win7 setup). A lot of
> piglit tests create 100x100 pixels and when piglit creates the window, Win7
> resizes it to 116x100.
On 12 October 2012 08:20, Brian Paul wrote:
> On 10/12/2012 01:54 AM, jfons...@vmware.com wrote:
>
>> From: José Fonseca
>>
>> ARB_instanced_arrays specification says:
>>
>> Dependencies on ARB_draw_instanced
>>
>> If neither ARB_draw_instanced nor EXT_draw_instanced is
>>
On 10 October 2012 10:03, Ian Romanick wrote:
> On 09/24/2012 04:35 PM, Paul Berry wrote:
>
>> The behaviour specified by OpenGL for blits involving sRGB is
>> self-contradictory--it is unclear whether blits should perform sRGB
>> encoding/decoding, and if so, whethe
On 7 October 2012 17:10, Marek Olšák wrote:
> On Mon, Oct 8, 2012 at 1:41 AM, Paul Berry
> wrote:
> > On 6 October 2012 18:49, Marek Olšák wrote:
> >>
> >> AFAIK, integer formats cannot be resolved, but only one sample is chosen
> >> and
> >&g
On 6 October 2012 18:49, Marek Olšák wrote:
> AFAIK, integer formats cannot be resolved, but only one sample is chosen
> and
> copied to the destination. However the chosen sample might not be at the
> center
> of the pixel, so the tests might never pass.
>
According to my reading of the spec, i
This patch modifies framebuffer-blit-levels to test that blitting
between miplevels of the stencil portion of a depth/stencil texture
works properly. This is an important corner case for Mesa's i965
driver.
Note that stencil data can't be uploaded to a texture directly using
glTexImage2D(). It m
On 1 October 2012 14:49, Eric Anholt wrote:
> Now I remember, I was waiting to send review to go look at the original
> file to see if my review note made sense. I think there's a little
> cleanup available:
>
> Paul Berry writes:
> > static void
> > create
The behaviour specified by OpenGL for blits involving sRGB is
self-contradictory--it is unclear whether blits should perform sRGB
encoding/decoding, and if so, whether this encoding/decoding should be
dependent upon the setting of the GL_FRAMEBUFFER_SRGB enable flag.
Experiments with nVidia and ATI
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55039
---
tests/shaders/shader_runner.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 0aff387..650a228 100644
--- a/tests/shaders/shader_runner.c
+++
On 14 September 2012 14:08, Stuart Abercrombie wrote:
> I wondered about this case but it didn't come up with the subset I
> tested with -- glad you caught it.
>
> V2 looks good to me. It's hard to be rigorous about detecting
> #version directives without a real parser. This seems a practical
>
This patch modifies framebuffer-blit-levels to test that blitting
between miplevels of the stencil portion of a depth/stencil texture
works properly. This is an important corner case for Mesa's i965
driver.
Note that stencil data can't be uploaded to a texture directly using
glTexImage2D(). It m
This will facilitate expanding the test to cover depthstencil
textures, since the stencil data can't be uploaded into the texture
directly using glTexImage2D--it will need to be converted into a
combined depth/stencil format first.
---
.../framebuffer-blit-levels.c | 42 ++
From: Stuart Abercrombie
The version number is taken from the GLSL version requirement, if there is one.
This is part of the effort to make version handling more flexible for GLES.
v2 (Paul Berry ): use strstr() to check
whether a #version directive is already present, in case it isn't a
On 12 September 2012 11:18, Stuart Abercrombie wrote:
> This was a solitary patch. I think the git submit feature decided
> there were two on account of an old patch file in the same directory.
> Sorry for the confusion.
>
> Stuart
>
> On Mon, Sep 10, 2012 at 5:55 PM, Stuart Abercrombie
> wrote:
On 7 September 2012 13:09, Eric Anholt wrote:
> Paul Berry writes:
>
> > This patch modifies framebuffer-blit-levels to test that blitting
> > between miplevels of the stencil portion of a depth/stencil texture
> > works properly. This is an important corner case fo
l_req_version = strtod(line, NULL);
> + if (!compare(glsl_req_version, glsl_version, cmp)) {
> printf("Test requires GLSL version %s %.1f. "
>"Actual version is %.1f.\n",
> comparison
it into a negative test to ensure index == 2 is a
> compile error.
>
> This patch also adds layout-14.frag, a test to check that index < 0 is
> also a compile error.
>
Reviewed-by: Paul Berry
> ---
> .../1.20/compiler/layout-12.frag | 27
> ++-
---
tests/all.tests|9 +
.../ext_framebuffer_multisample/CMakeLists.gl.txt |1 +
.../ext_framebuffer_multisample/blit-flipped.cpp | 183
3 files changed, 193 insertions(+), 0 deletions(-)
create mode 100644 tests/spec/ext_frameb
This patch modifies framebuffer-blit-levels to test that blitting
between miplevels of the stencil portion of a depth/stencil texture
works properly. This is an important corner case for Mesa's i965
driver.
Note that since stencil data can't be uploaded to a texture using
glTexImage2D(), the test
This will facilitate expanding the test to cover depthstencil
textures, since the stencil data can't be uploaded into the texture
using glTexImage2D--it will need to be drawn using stencil operations.
---
.../framebuffer-blit-levels.c | 42 ++-
1 files change
Previously, the test made the erroneous assumption that if the size of
a texture is 2^n, then that texture has n miplevels. This was
wrong--the texture has n+1 miplevels, ranging in size from 2^n to 2^0.
---
.../framebuffer-blit-levels.c |7 ---
1 files changed, 4 ins
---
tests/util/piglit-util-gl-common.h |1 +
tests/util/piglit-util-gl.c| 55
2 files changed, 56 insertions(+), 0 deletions(-)
diff --git a/tests/util/piglit-util-gl-common.h
b/tests/util/piglit-util-gl-common.h
index d2e6b3e..c5e814c 100644
--
On 30 August 2012 11:59, Stuart Abercrombie wrote:
> This is part of the effort to make version handling more flexible for GLES.
>
Looks great, thanks.
Pushed to master.
> ---
> tests/shaders/shader_runner.c | 65
> +---
> 1 files changed, 28 insertions(+
On 29 August 2012 16:42, Stuart Abercrombie wrote:
> This is part of the effort to make version handling more flexible for GLES.
>
The patch has indentation errors that need to be fixed. Piglit uses tabs
for indentation, and is intended to be viewed with a tab width of 8.
> ---
> tests/shader
On 27 August 2012 18:35, Matt Turner wrote:
> Fixes egl-nok-swap-region and makes egl-nok-texture-from-pixmap not
> crash (but still fails).
>
Reviewed-by: Paul Berry
> ---
> tests/egl/egl-util.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> di
estion of making #version strings in the source optional.
>
> Minor problems:
>
> 1. Thanks. I was planning to revisit this.
>
> 2. I hadn't noticed the Open GL ES 3 #version syntax change -- thanks.
>
> The multi-patch plan sounds good. I'll pursue that.
>
>
On 24 August 2012 16:09, Stuart Abercrombie wrote:
> The idea is to allow different GLSL versions for GL vs GL ES. There
> shouldn't be a functional change until shader scripts are altered too.
>
> Added ES GLSL version string parsing.
>
I like where you're going with this. A few comments befor
ers() is because it is
testing that after glutSwapBuffers(), the correct pixels can be read out of
the front buffer. So the call to glutSwapBuffers() needs to happen no
matter how the test is run.
With that change backed out, patch 1/6 is:
Reviewed-by: Paul Berry
I've already sent comments on your
[2] - 0.5f;
> - printf(" Delta: %f,%f,%f\n", dr, dg, db);
> - if (dr > dmax) dmax = dr;
> - else if (-dr > dmax) dmax = -dr;
> - if (dg > dmax) dmax = dg;
> - else if (-dg > dmax) dmax = -dg;
> - if (db > dmax) dmax = db;
>
arring people (e.g. "also fixed a
bogus comment").
In any case, this patch is:
Reviewed-by: Paul Berry .
> {
> "texture #1",
> 0.125, 1.125,
> @@ -264,6 +264,7 @@ void
> piglit_init(int argc, char **argv)
> {
&g
On 25 August 2012 01:12, Chris Forbes wrote:
> Converts most of the custom reshape funcs to set the projection
> in either piglit_init or piglit_display, depending on whether
> it depends on the size.
>
> Signed-off-by: Chris Forbes
> ---
> tests/bugs/tri-tex-crash.c| 21 ++-
On 25 August 2012 01:12, Chris Forbes wrote:
>
> Signed-off-by: Chris Forbes
>
Functionally I'm fine with this patch. But it's hard to follow the diff
because the patch contains both whitespace changes (fixing up indentation)
and non-whitespace changes (changing the if test to a call to
piglit
On 25 August 2012 01:12, Chris Forbes wrote:
>
> Signed-off-by: Chris Forbes
>
Reviewed-by: Paul Berry
> ---
> tests/fbo/fbo-generatemipmap-formats.c | 3 +--
> tests/shaders/glsl-arb-fragment-coord-conventions.c | 2 +-
> tests
On 25 August 2012 01:12, Chris Forbes wrote:
> This is the first batch of patches which get rid of some
> stumbling-blocks for running tests with -fbo.
>
> Highlights:
> - gSwapBuffers -> piglit_present_results
> - glutKeyboardFunc never in -auto
> - glutReshapeFunc -> piglit_*_projection
> - som
On 24 August 2012 17:28, Chris Forbes wrote:
> > BTW, we are hoping to reduce the use of glutKeyboardFunc as much as
> possible
> > because it gets in the use of Waffle, so if you happen to notice some
> > opportunities to get rid of glutKeyboardFunc entirely (or at least take
> some
> > steps in
On 23 August 2012 17:27, Chris Forbes wrote:
> Hello
>
> I sent in a pile of random patches some time ago working toward having
> more of the tests support -fbo. This is important on WMs which don't
> give you the size you ask for [pretty much any tiling WM].
>
Sorry I didn't notice those. I wi
This test provokes a bug in Mesa as of 8/23/12 (commit 1cb07bd): when
fast depth clears are performed on multiple layers of a multilayer
depth texture (such as a 2D array or a cubemap texture), the
implementation doesn't properly track the need for depth resolves,
resulting in incorrect data when t
input color (SRC1_COLOR, ONE_MINUS_SRC1_COLOR, SRC1_ALPHA or
> ONE_MINUS_SRC1_ALPHA) using fixed function will produce undefined
> results."
>
> Fix this by disabling the blending temporarily in visualize_image
> function.
>
Looks good to me.
Reviewed-by: Paul Berry
>
&
A few of the recently-added MSAA tests were missing this check,
causing bogus failures on i965/gen6 and i965/gen7 (which only support
up to 4x MSAA and 8x MSAA, respectively).
---
.../alpha-to-coverage-dual-src-blend.cpp |7 +++
.../alpha-to-one-dual-src-blend.cpp
*/
> expected_color[alpha_idx] =
> @@ -382,7 +482,7 @@ compute_expected_color(bool sample_alpha_to_coverage,
> frag_alpha;
> }
> else if (sample_alpha_to_coverage) {
> - /* Taking in acc
On 15 August 2012 16:47, Chad Versace wrote:
> On 08/15/2012 02:17 PM, Paul Berry wrote:
> > On 15 August 2012 12:51, Chad Versace > <mailto:chad.vers...@linux.intel.com>> wrote:
> >
> > Extend the framebuffer-blit-levels test to verify that
> > g
401 - 500 of 637 matches
Mail list logo
