Re: Review Request 123727: [klipper] Ensure global shortcut actions work

2015-05-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123727/#review80232 --- Ship it! Ship It! - Martin Klapetek On May 12, 2015, 7:27

Re: Review Request 123426: Kickoff is not mounting removable devices and shows "Invalid URL"

2015-05-12 Thread Konrad Materka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123426/ --- (Updated May 12, 2015, 9:32 a.m.) Status -- This change has been mar

Re: Review Request 123727: [klipper] Ensure global shortcut actions work

2015-05-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123727/ --- (Updated May 12, 2015, 9:39 a.m.) Status -- This change has been mar

Re: testing the single QQmlEngine plasmashell

2015-05-12 Thread Aleix Pol
On Mon, May 11, 2015 at 6:20 PM, Marco Martin wrote: > On Monday 11 May 2015, Marco Martin wrote: >> please test it to see if there are obvious regressions, if it's faster or >> slower, more or less crashy, if it takes more or less memory (dere it slims >> by about 25 MB on a 32bit system, of abou

Re: testing the single QQmlEngine plasmashell

2015-05-12 Thread Marco Martin
On Tuesday 12 May 2015, Aleix Pol wrote: > Hi, > I wanted to give it a go as well, and so I did. :D > > http://proli.net/meu/kde/massif.out.3278-beforeBranchChange > http://proli.net/meu/kde/massif.out.5283-afterBranchChange > > http://proli.net/meu/kde/massif.out.5759-afterBranchChange << this i

Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Review Request 123736: single QQmlEngine for all applets

2015-05-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123736/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80241 --- Can you make the diff against the branch root instead of origi

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 3:35 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123736: single QQmlEngine for all applets

2015-05-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123736/#review80243 --- > For compatibility, applets without X-Plasma-RequiredExtensio

Re: Review Request 123736: single QQmlEngine for all applets

2015-05-12 Thread Marco Martin
> On May 12, 2015, 3:44 p.m., Kai Uwe Broulik wrote: > > > For compatibility, applets without X-Plasma-RequiredExtensions=LaunchApp > > > will still have own engine > > > > You mean SharedEngine? :) that :) - Marco --- This is an auto

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80244 --- src/kdeclarative/qmlobject.cpp (line 176)

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80249 --- src/kdeclarative/qmlobject.h (line 81)

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:05 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Marco Martin
> On May 12, 2015, 3:52 p.m., David Edmundson wrote: > > src/kdeclarative/qmlobjectsharedengine.cpp, line 62 > > > > > > this needs to be initialised. line 65 QQmlEngine *QmlObjectSharedEnginePrivate::s_engine =

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:10 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 12, 2015, 4:12 p.m.) Review request for KDE Frameworks and P

[Breeze] [Bug 347524] Qt Creator Options crashed in Breeze theme

2015-05-12 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=347524 Hugo Pereira Da Costa changed: What|Removed |Added Assignee|plasma-devel@kde.org|hugo.pere...@free.fr CC

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-12 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80252 --- src/kdeclarative/qmlobjectsharedengine.h (line 57)

Review Request 123738: Use column major in the taskbar when "Force row settings" is set

2015-05-12 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop Des

Review Request 123740: Add timezone filtering by region too

2015-05-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123740/ --- Review request for Plasma. Bugs: 346681 https://bugs.kde.org/show_bug

Re: Review Request 123738: Use column major in the taskbar when "Force row settings" is set

2015-05-12 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/#review80256 --- applets/taskmanager/package/contents/ui/main.qml (line 237) <

Re: Review Request 123740: Add timezone filtering by region too

2015-05-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123740/#review80257 --- Ship it! applets/digital-clock/plugin/timezonemodel.h (line

Re: Review Request 123740: Add timezone filtering by region too

2015-05-12 Thread Martin Klapetek
> On May 12, 2015, 10:23 p.m., David Edmundson wrote: > > applets/digital-clock/plugin/timezonemodel.h, line 34 > > > > > > it's worth always having a NOTIFY, otherwise if in the future anything > > binds to filt

Re: Review Request 123740: Add timezone filtering by region too

2015-05-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123740/ --- (Updated May 12, 2015, 8:53 p.m.) Status -- This change has been mar

Review Request 123746: Workaround DBusMenuQt's design

2015-05-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123746/ --- Review request for Plasma. Repository: plasma-workspace Description (up

Re: Review Request 123746: Workaround DBusMenuQt's design

2015-05-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123746/#review80272 --- Has DBusMenuQt been fixed? Or is it beyond our reach for a wei

Re: Review Request 123746: Workaround DBusMenuQt's design

2015-05-12 Thread Aleix Pol Gonzalez
> On May 13, 2015, 4:49 a.m., Aleix Pol Gonzalez wrote: > > Has DBusMenuQt been fixed? Or is it beyond our reach for a weird reason? PS: I don't mind the workaround as long as we fix upstream too. - Aleix --- This is an automatically ge